Files
PaperClipAI/ui/src/components/MemberMultiSelect.tsx
T
DottaandPaperclip 20ccf3f476 feat(apps): add connection grants and delegated identities (#12341)
## Thinking Path

> - Paperclip is the open source app people use to manage AI agents for
work.
> - External tools need explicit identity and access boundaries.
> - Shared connection credentials cannot represent every user-scoped use
case.
> - Grants must stay company-scoped and support safe delegation.
> - This pull request adds connection grants, identity rules, and their
database contract.
> - The benefit is durable control over which identity an agent may use.

## Linked Issues or Issue Description

Refs #11965

This is stack 3 of 11. It depends on stack 2 and replaces another
reviewable part of #11965.

## What Changed

- Add company and user connection grants.
- Add delegated identity and membership rules.
- Synchronize database, shared, server, and UI contracts.
- Register the grant-member replacement route in the OpenAPI surface in
the same layer that mounts it.
- Add migration 0231 with replay-safe guards and coverage.

## Verification

- `pnpm -r typecheck`
- `pnpm --filter @paperclipai/server exec vitest run
src/__tests__/tool-access-service.test.ts`
- `pnpm --filter @paperclipai/server exec vitest run
src/__tests__/openapi-routes.test.ts` (5 passed)
- `pnpm --filter @paperclipai/db check:migrations`
- `pnpm build`

## Risks

- Incorrect grant selection could expose the wrong credential scope.
- The service enforces company and subject boundaries before credential
use.
- Migration 0231 is generated, ordered after 0230, and safe to replay.

> I checked `ROADMAP.md`. This stack continues the existing app
connection work from #11965 and does not duplicate another planned item.

## Model Used

OpenAI Codex, GPT-5. The runtime model ID and context window were not
exposed. The model used reasoning, tool use, and code execution.

## Checklist

- [x] I have included a thinking path that traces from project context
to this change
- [x] I have specified the model used (with version and capability
details)
- [x] I have checked ROADMAP.md and confirmed this PR does not duplicate
planned core work
- [x] I have searched GitHub for duplicate or related PRs and linked
them above
- [x] I have either linked a public issue or pull request with `Refs #`
- [x] I have not referenced internal or instance-local Paperclip issues
or links
- [x] My branch name describes the change and contains no internal
Paperclip ticket id or instance-derived details
- [x] I have run tests locally and they pass
- [x] I have added or updated tests where applicable
- [x] I have updated relevant documentation to reflect my changes
- [x] I have considered and documented any risks above
- [x] All Paperclip CI gates are green
- [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups
- [x] I will address all Greptile and reviewer comments before
requesting merge

---------

Co-authored-by: Paperclip <noreply@paperclip.ing>
2026-08-29 12:08:33 -05:00

227 lines
8.5 KiB
TypeScript

import { useEffect, useMemo, useState, type ComponentProps, type ReactNode } from "react";
import { ChevronRight } from "lucide-react";
import { Identity } from "@/components/Identity";
import { Button } from "@/components/ui/button";
import { Checkbox } from "@/components/ui/checkbox";
import { Input } from "@/components/ui/input";
import { Popover, PopoverContent, PopoverTrigger } from "@/components/ui/popover";
import { Skeleton } from "@/components/ui/skeleton";
import { cn } from "@/lib/utils";
export interface MemberMultiSelectOption {
userId: string;
name?: string | null;
email?: string | null;
image?: string | null;
}
export function memberOptionLabel(member: MemberMultiSelectOption): string {
return member.name?.trim() || member.email?.trim() || member.userId;
}
/**
* People counterpart to `AgentMultiSelect` (PAP-17835).
*
* The organization-grant audience editor needs a searchable, keyboard-operable,
* selected-first people picker, and the design calls for one system component
* rather than a feature-local audience picker — a future Teams primitive can
* replace what feeds it without changing this API. Behaviour deliberately
* matches `AgentMultiSelect`: pass `onSave` for a staged draft (Save/Cancel), or
* `onChange` for live selection.
*/
export function MemberMultiSelect({
members,
selectedUserIds,
onChange,
onSave,
loading = false,
disabled = false,
pending = false,
getDescription,
triggerLabel,
triggerVariant = "outline",
triggerSize = "default",
triggerFullWidth = true,
triggerClassName,
contentAlign = "start",
emptyMessage = "No members yet.",
showSelectionPreview = true,
filterPlaceholder = "Filter people",
onOpenChange,
}: {
members: MemberMultiSelectOption[];
selectedUserIds: Set<string>;
onChange?: (next: Set<string>) => void;
onSave?: (next: Set<string>) => void;
loading?: boolean;
disabled?: boolean;
pending?: boolean;
getDescription?: (member: MemberMultiSelectOption) => string | null | undefined;
triggerLabel?: string;
triggerVariant?: ComponentProps<typeof Button>["variant"];
triggerSize?: ComponentProps<typeof Button>["size"];
triggerFullWidth?: boolean;
triggerClassName?: string;
contentAlign?: ComponentProps<typeof PopoverContent>["align"];
emptyMessage?: string;
showSelectionPreview?: boolean;
filterPlaceholder?: string;
onOpenChange?: (open: boolean) => void;
}): ReactNode {
const [open, setOpen] = useState(false);
const [filter, setFilter] = useState("");
const [draftUserIds, setDraftUserIds] = useState<Set<string>>(new Set(selectedUserIds));
const staged = Boolean(onSave);
const workingUserIds = staged ? draftUserIds : selectedUserIds;
useEffect(() => {
if (open && staged) setDraftUserIds(new Set(selectedUserIds));
}, [open, selectedUserIds, staged]);
const normalizedFilter = filter.trim().toLowerCase();
const filteredMembers = useMemo(
() =>
members
.filter((member) => {
const description = getDescription?.(member) ?? member.email ?? "";
return `${memberOptionLabel(member)} ${description}`.toLowerCase().includes(normalizedFilter);
})
.sort((a, b) => {
const aSelected = workingUserIds.has(a.userId);
const bSelected = workingUserIds.has(b.userId);
if (aSelected !== bSelected) return aSelected ? -1 : 1;
return memberOptionLabel(a).localeCompare(memberOptionLabel(b));
}),
[members, getDescription, normalizedFilter, workingUserIds],
);
const selectedCount = selectedUserIds.size;
const selectedMembers = members.filter((member) => selectedUserIds.has(member.userId));
function setSelection(next: Set<string>) {
if (staged) setDraftUserIds(next);
else onChange?.(next);
}
return (
<div className="space-y-2">
<Popover
open={open}
onOpenChange={(nextOpen) => {
setOpen(nextOpen);
onOpenChange?.(nextOpen);
if (!nextOpen) setFilter("");
}}
>
<PopoverTrigger asChild>
<Button
type="button"
variant={triggerVariant}
size={triggerSize}
className={cn("justify-between", triggerFullWidth && "w-full", triggerClassName)}
disabled={disabled || pending}
>
<span className="flex min-w-0 items-center">
<span className="truncate">
{triggerLabel ?? (selectedCount === 0
? "Select people"
: `${selectedCount} ${selectedCount === 1 ? "person" : "people"} selected`)}
</span>
</span>
<ChevronRight className="h-4 w-4 shrink-0 text-muted-foreground" />
</Button>
</PopoverTrigger>
<PopoverContent className="w-80 p-0" align={contentAlign}>
<div className="border-b border-border p-3">
<Input
value={filter}
onChange={(event) => setFilter(event.target.value)}
placeholder={filterPlaceholder}
className="h-8"
autoFocus
/>
</div>
{loading ? (
<div className="space-y-2 p-3">
<Skeleton className="h-6 w-full" />
<Skeleton className="h-6 w-full" />
</div>
) : members.length === 0 ? (
<div className="px-3 py-4 text-sm text-muted-foreground">{emptyMessage}</div>
) : (
<div className="max-h-60 overflow-y-auto py-1">
{filteredMembers.map((member) => {
const label = memberOptionLabel(member);
const description = getDescription?.(member)
?? (member.email && member.email !== label ? member.email : null);
return (
<label
key={member.userId}
className="flex cursor-pointer items-start gap-2 px-3 py-2 hover:bg-accent/30"
>
<Checkbox
checked={workingUserIds.has(member.userId)}
aria-label={`Allow ${label}`}
onCheckedChange={(checked) => {
const next = new Set(workingUserIds);
if (checked) next.add(member.userId);
else next.delete(member.userId);
setSelection(next);
}}
/>
<span className="flex min-w-0 flex-col">
<Identity name={label} avatarUrl={member.image ?? null} size="sm" />
{description ? (
<span className="truncate text-xs text-muted-foreground">{description}</span>
) : null}
</span>
</label>
);
})}
{filteredMembers.length === 0 ? (
<div className="px-3 py-4 text-sm text-muted-foreground">No matches.</div>
) : null}
</div>
)}
<div className="flex items-center justify-between border-t border-border px-3 py-2">
<span className="text-xs text-muted-foreground" aria-live="polite">
{workingUserIds.size === 0 ? "No people selected" : `${workingUserIds.size} selected`}
</span>
<div className="flex items-center gap-2">
{staged ? (
<Button type="button" variant="ghost" size="sm" onClick={() => setOpen(false)} disabled={pending}>
Cancel
</Button>
) : null}
<Button
type="button"
size="sm"
onClick={() => {
if (staged) onSave?.(draftUserIds);
setOpen(false);
}}
disabled={pending}
>
{staged ? (pending ? "Saving…" : "Save") : "Done"}
</Button>
</div>
</div>
</PopoverContent>
</Popover>
{showSelectionPreview && selectedMembers.length > 0 ? (
<div className="space-y-0.5">
{selectedMembers.slice(0, 3).map((member) => (
<div key={member.userId} className="flex items-center gap-2 px-1.5 py-1 text-sm">
<Identity name={memberOptionLabel(member)} avatarUrl={member.image ?? null} size="sm" />
</div>
))}
{selectedMembers.length > 3 ? (
<p className="px-1.5 pt-0.5 text-xs text-muted-foreground">
and {selectedMembers.length - 3} more
</p>
) : null}
</div>
) : null}
</div>
);
}