mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-21 08:22:20 +02:00
## Thinking Path > - Paperclip manages AI agents that perform work for a company. > - The shared Runner owns task admission, authority, receipts and finalization. > - An existing Grok Bot needs to receive assignments and return results through that Runner. > - The Bot also needs governed access when it starts work from its own conversation. > - This PR adds agent-purpose MCP access and routine webhook dispatch. > - It reuses the external-agent Rust Runner and keeps Grok capabilities explicit. > - The provider stays experimental until the real-client managed journeys pass. ## Linked Issues or Issue Description **Agent or provider** Grok Bot, distinct from the Grok Build coding runtime in #13882. **Why this adapter is useful** Users can assign work to an existing Bot, receive progress, questions, documents and files in Paperclip, and let the Bot initiate work under its agent permissions. **How the agent is invoked** A webhook-only routine delivers bounded references. Dedicated named-agent OAuth and MCP provide inbound calls. Setup follows [Grok routines](https://cursor.com/help/grok-bot/routines) and [custom plugins](https://cursor.com/help/grok-bot/connect-plugins). The current desktop app needs its Bot-generated Webhook URL navigation link when routine-row clicks fail. The GitHub search found related Grok Build runtime work, but no existing Grok Bot agent provider. This extends the roadmap’s existing agent, Runner, governance and artifact foundations. ## What Changed - Add default-off Grok Bot participation through the shared real Rust external backend, preserving native provider identity guarantees and distinguishing session closure from remote termination. - Bind agent OAuth to company, agent, client, gateway and authorizer; recheck permissions and task-bound execution authority without manufacturing a native identity. - Persist routine configuration, dispatch intents, authenticated acknowledgement and recovery holds. Store URL/key together in encrypted secret storage, use guarded public egress, and never automatically replay ambiguous HTTP delivery. - Reuse native tools, durable waiting, completion assessment and review. Add task-bound file grants through existing artifact storage; suppress proactive echo dispatch and synchronous result wake loops. - Enforce the current native deliverable work-mode policy at file-ticket issuance and use. Add operator retries for confirmed rejected wakes, with retained receipts, stable retry intent and current-authority checks. Recovery locks bindings before routine rows. Thread Stop resolves the selected run and its agent. - Cancel queued and preparing Stop targets before assignment creation, restore saved setup after a failed request and successful retry, and publish the Grok provider descriptor schema. Advance the versioned Copilot source declaration for the shared schema change; its qualification remains pending. - Filter task summaries with the shared privacy policy, preserve feedback admission when wake delivery is blocked, reconcile settled delivery receipts without restoring work authority, and bind every Stop control to its displayed run. Recovery records distinguish dispatch uncertainty from a revoked session. - Add resumable guided setup, credential replacement, consent, management, observed work status and stop/recovery controls, plus an interactive Storybook journey using the production task thread, question form and report card. Grok’s own apps remain available; Paperclip workspace and third-party tools are deferred. ## Verification - Five focused protocol, authorization, person MCP and Runner files: 192 tests pass. The Grok assigned-work case executes the actual Rust Runner, saves a document, uploads/deduplicates a file and reaches ordinary finalization. - Proactive intake/deduplication and renewed-session recovery pass. These use scripted clients and synthetic storage; they are not real-provider acceptance. - Repository typecheck, production build, token gates, map checks and Storybook build/catalog checks pass. The local full-suite campaign was stopped after macOS shared-memory exhaustion repeatedly prevented embedded PostgreSQL startup. No local aggregate pass is claimed. The first clean-worker CI run identified avatar fixture/configuration, flag defaults, feature-card ordering and OpenAPI route-coverage gaps; all four focused regressions pass after correction. Those regressions pass. The latest clean-worker CI run also found a Copilot source-hash declaration mismatch after the shared descriptor update; the corrected declaration passes all 28 integrity tests. The next review corrections pass 144 rendered UI tests, 21 OpenAPI tests and 82 Runner contract/integrity/history tests. The latest database fixtures were blocked at startup by host shared-memory exhaustion; clean-worker CI must execute their new regressions. Full current-head CI now passes: 54 successful checks and four intentional skips. The database regression uses the PostgreSQL driver result shape; file-policy, rejected-feedback and lock-order cases pass on clean workers. Current-head Greptile is 5/5 with no unresolved findings. - Rendered setup steps and outbound-only verification were walked through in Storybook. Simulation cannot enable Done without an authenticated-reply state. - Actual client OAuth, continued access, reconnect and one routine wake with an exact chat acknowledgement were observed separately. This candidate’s live authenticated challenge, assigned/proactive workflows, Linux managed artifact, restart and cleanup are not yet qualified. The provider stays disabled by default. - The separate Cloud ingress change forwards only exact task-bound upload/download paths and preserves host identity and header stripping. - Current Cloud policy reserves Test for pre-merge app/harness experiments; Staging accepts only master-derived revisions. Real-client qualification needs a supported, authorized deployment target and remains outstanding. ## Risks One append-only migration adds routine/dispatch state and extends shared bindings and file tickets. The unshipped migrations were regenerated after upstream consumed their original numbers. Rolling back code retains the durable rows; revoke grants and inspect unknown remote activity before resuming dispatch. Grok cannot confirm remote termination, stream its complete transcript or report spending. Plugins are account-wide and do not isolate credentials between Bots. Real-client managed acceptance remains required before enabling the experimental provider. ## Model Used OpenAI Codex based on GPT-6, with reasoning, code execution and browser/native UI tools. The exact deployment model ID and context-window size are not exposed by this runtime. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
265 lines
8.3 KiB
TypeScript
265 lines
8.3 KiB
TypeScript
// Redaction for HTTP log payloads.
|
|
//
|
|
// `customProps` in logger.ts copies `req.body` / `req.params` / `req.query`
|
|
// verbatim into the 4xx/5xx log lines so operators can diagnose. That means
|
|
// Better Auth's `POST /api/auth/sign-in/email` body (which has the user's
|
|
// plaintext password) and similar payloads (sign-up, reset-password, API
|
|
// keys via Authorization header equivalents) end up on disk.
|
|
//
|
|
// This walker returns a shallow copy of the input with values for sensitive
|
|
// keys replaced with the literal string "[REDACTED]". Recurses into nested
|
|
// objects/arrays. Caps depth so a hostile or accidental cycle can't pin
|
|
// the logger.
|
|
|
|
const SENSITIVE_KEYS = new Set<string>([
|
|
// Provider setup payloads deliberately group all durable authentication
|
|
// material under `credentials`. Redact the whole subtree instead of trying
|
|
// to keep an ever-changing allowlist of provider-specific field names in
|
|
// sync with every connector.
|
|
"sealed",
|
|
"handoff",
|
|
"claim",
|
|
"claimid",
|
|
"claim_id",
|
|
"managertoken",
|
|
"manager_token",
|
|
"configurationtoken",
|
|
"configuration_token",
|
|
"credential",
|
|
"credentials",
|
|
"password",
|
|
"currentpassword",
|
|
"newpassword",
|
|
"passwordconfirmation",
|
|
"password_confirmation",
|
|
"passwordconfirm",
|
|
"password_confirm",
|
|
"confirmpassword",
|
|
"confirm_password",
|
|
// Secret creation/update bodies use a generic `value` field. Failure logs
|
|
// must prefer losing that diagnostic value over persisting credential
|
|
// material. `token` is likewise ambiguous but frequently credential-bearing.
|
|
"value",
|
|
"token",
|
|
"secret",
|
|
"client_secret",
|
|
"clientsecret",
|
|
"access_token",
|
|
"accesstoken",
|
|
"refresh_token",
|
|
"refreshtoken",
|
|
"id_token",
|
|
"idtoken",
|
|
"api_key",
|
|
"apikey",
|
|
// Probe keys are transient, including rejected or future provider names.
|
|
// Redact the whole container instead of maintaining a second key allowlist.
|
|
"testcredentials",
|
|
"authorization",
|
|
"auth_token",
|
|
"authtoken",
|
|
"session_token",
|
|
"sessiontoken",
|
|
"private_key",
|
|
"privatekey",
|
|
// Defense in depth for legacy, malformed, or provider-specific payloads
|
|
// that place a credential outside the standard `credentials` envelope.
|
|
"app_secret",
|
|
"appsecret",
|
|
"application_secret",
|
|
"applicationsecret",
|
|
"bot_token",
|
|
"bottoken",
|
|
"secret_token",
|
|
"secrettoken",
|
|
"signing_secret",
|
|
"signingsecret",
|
|
"webhook_secret",
|
|
"webhooksecret",
|
|
"webhookkey",
|
|
"webhookurl",
|
|
"paperclip_capability",
|
|
// The Claude setup-token login fields. `browserCode` carries the one-time
|
|
// sign-in code and `authorization_code` carries the OAuth code; neither may
|
|
// reach a log line.
|
|
"browsercode",
|
|
"authorization_code",
|
|
"code_verifier",
|
|
"codeverifier",
|
|
"authorizationcode",
|
|
// The workspace login handoff ticket (PAP-17572). It is a signed bearer
|
|
// credential carried as a query parameter, so it must never reach a log line
|
|
// even though the exchange itself answers 302.
|
|
"ticket",
|
|
// Not secrets Paperclip holds, but attacker-authored prose: an OAuth provider
|
|
// controls `error_description` / `error_uri` on the callback query string, and
|
|
// `customProps` copies the whole query into 4xx log lines. Paperclip maps the
|
|
// `error` code to its own copy instead of reflecting these, so they have no
|
|
// debugging value here either (PAP-17108).
|
|
"error_description",
|
|
"errordescription",
|
|
"error_uri",
|
|
"erroruri",
|
|
]);
|
|
|
|
const MAX_DEPTH = 6;
|
|
const REDACTED = "[REDACTED]";
|
|
const URLISH_KEYS = new Set<string>([
|
|
"href",
|
|
"locator",
|
|
"source",
|
|
"source_locator",
|
|
"sourcelocator",
|
|
"source_url",
|
|
"sourceurl",
|
|
"uri",
|
|
"url",
|
|
// The Claude setup-token login URL. A structured `loginUrl` that reaches a log
|
|
// sink keeps its origin and path only; the OAuth query, fragment, and any
|
|
// credentials are stripped (SR-5 backstop).
|
|
"loginurl",
|
|
"login_url",
|
|
]);
|
|
|
|
function isSensitiveKey(key: string): boolean {
|
|
return SENSITIVE_KEYS.has(key.toLowerCase());
|
|
}
|
|
|
|
function isUrlishKey(key: string): boolean {
|
|
return URLISH_KEYS.has(key.toLowerCase());
|
|
}
|
|
|
|
export function stripSecretBearingUrlParts(value: string): string {
|
|
const suffixStart = value.search(/[?#]/);
|
|
const withoutQueryOrFragment =
|
|
suffixStart === -1 ? value : value.slice(0, suffixStart);
|
|
|
|
try {
|
|
const url = new URL(withoutQueryOrFragment);
|
|
if (!url.username && !url.password && suffixStart === -1) return value;
|
|
url.username = "";
|
|
url.password = "";
|
|
return url.toString();
|
|
} catch {
|
|
// Request URLs are normally origin-form paths rather than absolute URLs.
|
|
// They still need the same query/fragment policy as URL-valued payloads.
|
|
return withoutQueryOrFragment;
|
|
}
|
|
}
|
|
|
|
export function redactSensitive(value: unknown, depth = 0): unknown {
|
|
if (depth > MAX_DEPTH) return undefined;
|
|
if (value === null || typeof value !== "object") return value;
|
|
if (Array.isArray(value)) {
|
|
if (depth + 1 > MAX_DEPTH) return undefined;
|
|
return value.map((entry) => redactSensitive(entry, depth + 1));
|
|
}
|
|
const out: Record<string, unknown> = {};
|
|
for (const [key, entry] of Object.entries(value as Record<string, unknown>)) {
|
|
if (isSensitiveKey(key)) {
|
|
out[key] = REDACTED;
|
|
continue;
|
|
}
|
|
if (typeof entry === "string" && isUrlishKey(key)) {
|
|
out[key] = stripSecretBearingUrlParts(entry);
|
|
continue;
|
|
}
|
|
out[key] = redactSensitive(entry, depth + 1);
|
|
}
|
|
return out;
|
|
}
|
|
|
|
function collectSensitiveStringValuesInto(
|
|
value: unknown,
|
|
values: Set<string>,
|
|
collectAll: boolean,
|
|
depth: number,
|
|
): void {
|
|
if (depth > MAX_DEPTH || value === null || value === undefined) return;
|
|
if (typeof value === "string") {
|
|
if (collectAll && value.length > 0) values.add(value);
|
|
return;
|
|
}
|
|
if (typeof value !== "object") return;
|
|
if (Array.isArray(value)) {
|
|
for (const entry of value) {
|
|
collectSensitiveStringValuesInto(entry, values, collectAll, depth + 1);
|
|
}
|
|
return;
|
|
}
|
|
for (const [key, entry] of Object.entries(value as Record<string, unknown>)) {
|
|
collectSensitiveStringValuesInto(
|
|
entry,
|
|
values,
|
|
collectAll || isSensitiveKey(key),
|
|
depth + 1,
|
|
);
|
|
}
|
|
}
|
|
|
|
/** Collects submitted credential strings without exposing them to callers' logs. */
|
|
export function collectSensitiveStringValues(value: unknown): string[] {
|
|
const values = new Set<string>();
|
|
collectSensitiveStringValuesInto(value, values, false, 0);
|
|
return [...values];
|
|
}
|
|
|
|
function encodedSensitiveVariants(values: readonly string[]): string[] {
|
|
const variants = new Set<string>();
|
|
for (const value of values) {
|
|
const normalizedValues = new Set([value, value.trim()]);
|
|
for (const normalizedValue of normalizedValues) {
|
|
if (normalizedValue.length === 0) continue;
|
|
variants.add(normalizedValue);
|
|
const json = JSON.stringify(normalizedValue);
|
|
if (json.length >= 2) variants.add(json.slice(1, -1));
|
|
try {
|
|
const urlEncoded = encodeURIComponent(normalizedValue);
|
|
variants.add(urlEncoded);
|
|
variants.add(urlEncoded.replaceAll("%20", "+"));
|
|
} catch {
|
|
// A lone UTF-16 surrogate is not URI-encodable. The raw and JSON-escaped
|
|
// forms are still covered, and error handling must never throw again
|
|
// while trying to sanitize malformed input.
|
|
}
|
|
}
|
|
}
|
|
return [...variants]
|
|
.filter(Boolean)
|
|
.sort((left, right) => right.length - left.length);
|
|
}
|
|
|
|
/**
|
|
* Redacts sensitive-shaped fields, then removes submitted credential values
|
|
* wherever an upstream validator/provider echoed them into otherwise-safe
|
|
* response prose.
|
|
*/
|
|
export function redactSensitiveValueOccurrences(
|
|
value: unknown,
|
|
sensitiveValues: readonly string[],
|
|
): unknown {
|
|
const variants = encodedSensitiveVariants(sensitiveValues);
|
|
const redacted = redactSensitive(value);
|
|
|
|
const visit = (entry: unknown, depth: number): unknown => {
|
|
if (depth > MAX_DEPTH) return undefined;
|
|
if (typeof entry === "string") {
|
|
return variants.reduce(
|
|
(text, sensitiveValue) => text.replaceAll(sensitiveValue, REDACTED),
|
|
entry,
|
|
);
|
|
}
|
|
if (entry === null || typeof entry !== "object") return entry;
|
|
if (Array.isArray(entry))
|
|
return entry.map((item) => visit(item, depth + 1));
|
|
return Object.fromEntries(
|
|
Object.entries(entry as Record<string, unknown>).map(([key, item]) => [
|
|
key,
|
|
visit(item, depth + 1),
|
|
]),
|
|
);
|
|
};
|
|
|
|
return visit(redacted, 0);
|
|
}
|