mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-27 19:35:13 +01:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work. > - Task conversations save messages that arrive during an active turn. > - Legacy adapters deliver these messages in a later turn. > - A run can stop before the saved queue is delivered. > - The Interrupt button previously required an active run, so it could not release this queue. > - This pull request lets a board operator send the saved queue after the run stops and retries queues missed during finalization. > - Manual dispatch must use the clicking operator and must not require permission to create agents. > - The task can continue without a duplicate message or a second execution owner. ## Linked Issues or Issue Description **What happened?** A legacy task retained a queued message after its run stopped. Interrupt was disabled because the queue had no active target. Finalization and deferred message admission can also leave a queue without a successor. **Expected behavior** Interrupt sends the saved messages when no runner is active. Messages that arrive during normal completion are delivered automatically. An uncertain previous execution still requires proof that its process or sandbox stopped. **Steps to reproduce** 1. Queue a user message during a legacy conversation turn. 2. Let the turn stop or simulate a server restart before queue promotion. 3. Open the task with a deferred queue and no active run. 4. Try Interrupt. Before this change, the button is disabled. **Paperclip version or commit** Reproduced against `8f40b4ad4`. **Deployment mode** Legacy conversation adapter. The same persisted queue state is covered with an isolated PostgreSQL fixture. Related public work: #13275 adds active legacy interruption. #13291 addresses automatic sandbox conversation recovery. This change handles explicit saved-queue delivery and late queue promotion. ## What Changed - Accept a null Interrupt target while retaining queue identity, revision, company, and assignee checks. - Save the operator's request on the existing queue. Reuse normal admission after verified stop, including older messages, different authors, and queues whose original wake came from the system. - Strip interruption authority from caller-supplied wake payloads. Only the board queue route can persist that authority. - Retry durable interruption requests after restart and deferred queues after legacy cleanup. - Let an explicit Interrupt retry cleanup for its stopped run, including old ephemeral leases that recorded success without a provider stop receipt. Preserve retained resources, other lease owners, and the automatic retry limit. - Preserve the server's waiting explanation when normalizing and combining queue entries. - Revalidate the consumed board queue receipt at dispatch so a different message author does not cause setup failure. - Use the Interrupt user's execution identity for the new run. Preserve original message authors. Validate the receipt independently at startup and inherit the resulting identity on retry. - Persist authenticated board authority for ordinary manual wakes too. Adopting someone else's queued messages cannot switch a manual run to that author's permissions. Strip caller-supplied authority markers and retain private conversation ownership checks. - Keep the clicking user when a manual wake is merged into an older deferred receipt. Update its requester and payload in the same transaction. - Use the same current-queue/revision API on task details and pipeline conversations; show Interrupt after a legacy target stops. - Keep manual wakes out of active runs, including unscoped agent wakes. They receive their own execution identity; a matching receipt requester is not sufficient because an exact retry can retain a different originating identity. - Authorize both existing-agent wake endpoints with `agent:wake`, available to active non-viewer company members. Keep `agents:create` for hiring. Validate the stored task and current assignee before an exact task retry. - Reject viewer Interrupt requests before saving intent or stopping execution. Keep external chat retry authorization and per-action agent/user permission checks. - Preserve edits and discards until dispatch. Prevent another queue promotion when the same agent already has a successor. Keep independent reviewer recovery available. - Suppress cancelled/failed run toasts for intentional operator interruption. Keep ordinary runtime error notices. - Add UI, route, admission, restart, successor ownership, and toast regression tests. Document the behavior. - Reuse the existing socket reservation helper for both credential-quorum test cases after CI exposed an ambient-port collision. This changes test preparation only; production credential staging is still called exactly once. ## Verification - Failing regression tests reproduced the message-author identity bug and an operator's `agents:create` rejection before the fixes. - All 316 focused tests pass across eight route, queue, identity, authorization, continuation, and responsible-user suites, including the 44-test rerun of queue admission and actual startup after the final manual-wake restriction. Regressions reproduce cross-user merging both with and without a task, and same-requester receipt ambiguity. The cross-company existence guard also passes both tests. - Startup integration tests reach adapter execution under the clicking operator and retain that identity through follow-up. Coverage includes mixed authors, adopted queues, system-origin queues, restarts, forged or stale receipts, viewers, suspended memberships, changed assignees, private conversations, and caller-supplied authority markers. - The earlier queue/cleanup/UI regression suite passed 402 tests. The final review corrections pass another 180 tests across queue admission/persistence, real heartbeat startup, UI API, conversation rendering, and pipeline suites. Regression tests reproduced both review findings before correction. The final head has a 5/5 review with no unresolved threads. Full CI passes on `c2002979c`, including every general and serialized server shard, all browser shards, Paperclip Runner verification, typecheck, build, canary dry run, and the aggregate gates. - Full `pnpm -r typecheck`, `pnpm build`, and UI token gates pass after the final application changes. CI identified an outdated task-page API mock after the shared helper extraction; the fixture now exercises the real helper, and all 131 task-page/API tests pass. The final application build passes with the additional manual-wake restriction. - CI exposed a pre-existing port collision in the Codex credential-quorum fixture. It reproduced locally; both listener cases now use the existing bounded reservation helper. All 41 credential tests pass on rerun. One intervening local run hit a separate ambient bind collision in the two-occupied-port case. - The full local `pnpm test:run` attempt was stopped after host contention caused focused-suite timeouts. The affected focused tests passed on rerun. An expiring trace fixture and a missing private-conversation state were corrected. The successful full CI run is the complete-suite verification. - Hosted Interrupt previously cleared the original queue and produced exactly one successor with neutral interruption feedback. It exposed the dispatch authorization defect. Retry on that earlier build was rejected for missing `agents:create` before creating another run. - Deployed the final application build (`38257f391`) to the scoped hosted instance and verified readiness. The latest PR commit changes only the credential test fixture; application code matches that deployment. A live Retry by the same operator without `agents:create` created one successor attributed to that operator, passing the former dispatch permission gate. Startup then stopped at `configuration_incomplete` because that operator has not configured their required personal Claude Code OAuth secret; the post-deployment run page confirms the operator identity and no provider work started, and the My secrets UI still shows the token as not set. Provider execution remains unverified pending that credential. No permission grants or credentials were changed. ## Risks Queue admission and finalization can race. The task lock, durable queue receipt, current comment IDs, and successor guard prevent duplicate dispatch. Process and lease stop checks, task pauses, approvals, ownership, and budgets remain in force. The API change only allows null on legacy Interrupt; native steering still requires an active run. No schema migration is required. Active non-viewer board members can now invoke existing agents without agent-creation permission. Agent self-invocation rules, raw provider-trace admin access, task retry scope, external chat authorization, and action-specific user/agent permissions remain enforced. ## Model Used OpenAI GPT-6 through Codex. The session does not expose an exact backend model ID or context-window size. Used reasoning, repository search, code execution, tests, and browser tools. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
966 lines
38 KiB
TypeScript
966 lines
38 KiB
TypeScript
import { describe, expect, it, vi } from "vitest";
|
|
import { createAdmitWakeBehindIssueExecution, createReleaseIssueExecution } from "./use-cases.js";
|
|
import type { AdmitWakeBehindIssueExecutionInput } from "./use-cases.js";
|
|
import { WakeQueueApplicationError } from "./types.js";
|
|
import type {
|
|
DeferredWakeCandidate,
|
|
InvokableAgentSnapshot,
|
|
IssueLockWriter,
|
|
IssueSnapshot,
|
|
PromoteDeferredWakeInput,
|
|
RecoveryEscalationPort,
|
|
RunSnapshot,
|
|
RunSummary,
|
|
TransactionScope,
|
|
WakeAdmissionActiveExecutionRun,
|
|
WakeAdmissionHeartbeatHelpers,
|
|
WakeAdmissionReader,
|
|
WakeAdmissionWriter,
|
|
WakeQueueHost,
|
|
WakeQueueTransaction,
|
|
} from "./ports.js";
|
|
|
|
const RUN: RunSnapshot = {
|
|
id: "run-1",
|
|
companyId: "company-1",
|
|
agentId: "finishing-agent",
|
|
status: "failed",
|
|
runtimeMode: "process",
|
|
errorCode: null,
|
|
responsibleUserId: "user-1",
|
|
contextSnapshot: {},
|
|
configurationIncompletePayload: null,
|
|
};
|
|
|
|
const ISSUE: IssueSnapshot = {
|
|
id: "issue-1",
|
|
companyId: "company-1",
|
|
identifier: "ISSUE-1",
|
|
status: "in_progress",
|
|
assigneeAgentId: "finishing-agent",
|
|
assigneeUserId: null,
|
|
hiddenAt: null,
|
|
originKind: null,
|
|
monitorNextCheckAt: null,
|
|
executionState: null,
|
|
responsibleUserId: null,
|
|
parentId: null,
|
|
originId: null,
|
|
originRunId: null,
|
|
};
|
|
|
|
const AGENT: InvokableAgentSnapshot = {
|
|
id: "deferred-agent",
|
|
companyId: "company-1",
|
|
name: "Deferred Agent",
|
|
invokable: true,
|
|
};
|
|
|
|
function wakeCandidate(overrides: Partial<DeferredWakeCandidate> = {}): DeferredWakeCandidate {
|
|
return {
|
|
id: overrides.id ?? "wake-1",
|
|
companyId: "company-1",
|
|
agentId: "deferred-agent",
|
|
reason: "issue_commented",
|
|
source: "automation",
|
|
triggerDetail: null,
|
|
requestedByActorType: "user",
|
|
requestedByActorId: "actor-1",
|
|
payload: {},
|
|
queuedCommentIds: [],
|
|
preservesIndependentContinuation: false,
|
|
deferredContextSeed: {},
|
|
deferredCommentIds: [],
|
|
wakeReason: "issue_commented",
|
|
...overrides,
|
|
};
|
|
}
|
|
|
|
function runSummary(id: string): RunSummary {
|
|
return {
|
|
id,
|
|
companyId: "company-1",
|
|
agentId: "deferred-agent",
|
|
invocationSource: "automation",
|
|
triggerDetail: null,
|
|
wakeupRequestId: `wakeup-${id}`,
|
|
};
|
|
}
|
|
|
|
function createFakeHost(overrides: Partial<WakeQueueHost> = {}): WakeQueueHost {
|
|
return {
|
|
resolveResponsibleUserId: vi.fn(async () => "user-1"),
|
|
getRoutineEnv: vi.fn(async () => ({ routineId: null, env: null, responsibleUserId: null })),
|
|
resolveSessionBeforeForWakeup: vi.fn(async () => null),
|
|
...overrides,
|
|
};
|
|
}
|
|
|
|
function createFakeTransaction(overrides: Partial<WakeQueueTransaction> = {}): WakeQueueTransaction {
|
|
return {
|
|
findInvokableAgent: vi.fn(async () => AGENT),
|
|
findNextDeferredWake: vi.fn(async () => null),
|
|
getQueuedCommentLiveness: vi.fn(async () => ({ liveNonSelfCommentIds: [], containedSelfAuthoredComment: false })),
|
|
cancelDeferredWake: vi.fn(async () => true),
|
|
normalizeDeferredWakeCommentIds: vi.fn(async (input) => wakeCandidate({ id: input.wakeId, queuedCommentIds: input.liveCommentIds })),
|
|
failDeferredWake: vi.fn(async () => true),
|
|
getPauseHoldFacts: vi.fn(async () => ({
|
|
activePauseHold: false,
|
|
treeHoldInteractionWake: false,
|
|
holdId: null,
|
|
rootIssueId: null,
|
|
mode: null,
|
|
reason: null,
|
|
releasePolicy: null,
|
|
})),
|
|
getCommentSelfAuthorship: vi.fn(async () => ({ allSelfAuthored: false })),
|
|
reopenIssue: vi.fn(async () => null),
|
|
claimDeferredWakeForPromotion: vi.fn(async () => true),
|
|
finalizePromotedWake: vi.fn(async (input) => runSummary(input.wakeId)),
|
|
hasExistingExecutionPath: vi.fn(async () => false),
|
|
hasExplicitBlockerPath: vi.fn(async () => false),
|
|
isAutomaticRecoverySuppressedByPauseHold: vi.fn(async () => false),
|
|
isImmediateRecoverySourceBlocked: vi.fn(async () => false),
|
|
queueReviewParticipantRecoveryRun: vi.fn(async () => runSummary("review-recovery")),
|
|
queueImmediateRecoveryRun: vi.fn(async () => runSummary("immediate-recovery")),
|
|
...overrides,
|
|
};
|
|
}
|
|
|
|
function createFakeIssueLock(host: WakeQueueHost, transaction: WakeQueueTransaction, issue = ISSUE): IssueLockWriter {
|
|
return {
|
|
withIssueExecutionLock: vi.fn(async (_input, fn) => {
|
|
const result = await fn({ primaryIssue: issue, run: RUN }, { host, transaction });
|
|
return { ...result, run: RUN };
|
|
}),
|
|
};
|
|
}
|
|
|
|
function createFakeRecovery(): RecoveryEscalationPort {
|
|
return {
|
|
escalateStrandedAssignedIssue: vi.fn(async () => {}),
|
|
escalateStrandedRecoveryIssueInPlace: vi.fn(async () => {}),
|
|
};
|
|
}
|
|
|
|
describe("releaseIssueExecution", () => {
|
|
it.each([true, false])(
|
|
"preserves failed-chat retry input without reopening only with adapter proof: %s",
|
|
async (authorizedFailedChatRetry) => {
|
|
const queue = [
|
|
wakeCandidate({
|
|
authorizedFailedChatRetry,
|
|
queuedCommentIds: ["original-comment"],
|
|
deferredCommentIds: ["original-comment"],
|
|
deferredContextSeed: {
|
|
issueId: ISSUE.id,
|
|
wakeCommentIds: ["original-comment"],
|
|
retryOfRunId: "original-failed-run",
|
|
chatFailedRunRetry: { requestId: "exact-request" },
|
|
},
|
|
}),
|
|
];
|
|
const transaction = createFakeTransaction({
|
|
findNextDeferredWake: vi.fn(async () => queue.shift() ?? null),
|
|
});
|
|
const host = createFakeHost();
|
|
const release = createReleaseIssueExecution({
|
|
issueLock: createFakeIssueLock(host, transaction, {
|
|
...ISSUE,
|
|
status: "done",
|
|
}),
|
|
recovery: createFakeRecovery(),
|
|
});
|
|
|
|
const result = await release({
|
|
companyId: RUN.companyId,
|
|
runId: RUN.id,
|
|
now: new Date(),
|
|
});
|
|
|
|
expect(transaction.normalizeDeferredWakeCommentIds).not.toHaveBeenCalled();
|
|
expect(transaction.reopenIssue).not.toHaveBeenCalled();
|
|
if (authorizedFailedChatRetry) {
|
|
expect(transaction.getQueuedCommentLiveness).not.toHaveBeenCalled();
|
|
expect(transaction.cancelDeferredWake).not.toHaveBeenCalled();
|
|
expect(transaction.finalizePromotedWake).toHaveBeenCalledWith(
|
|
expect.objectContaining({
|
|
authorizedFailedChatRetry: true,
|
|
contextSnapshot: expect.objectContaining({
|
|
wakeCommentIds: ["original-comment"],
|
|
retryOfRunId: "original-failed-run",
|
|
chatFailedRunRetry: { requestId: "exact-request" },
|
|
}),
|
|
}),
|
|
);
|
|
expect(result.outcome.kind).toBe("promoted");
|
|
} else {
|
|
expect(transaction.getQueuedCommentLiveness).toHaveBeenCalledTimes(1);
|
|
expect(transaction.cancelDeferredWake).toHaveBeenCalledTimes(1);
|
|
expect(transaction.finalizePromotedWake).not.toHaveBeenCalled();
|
|
expect(result.outcome.kind).toBe("released");
|
|
}
|
|
},
|
|
);
|
|
|
|
it.each([false, true])(
|
|
"applies an exact source denial only after independent deferred input: %s",
|
|
async (hasDeferredInput) => {
|
|
const transaction = createFakeTransaction({
|
|
findNextDeferredWake: vi.fn(async () =>
|
|
hasDeferredInput ? wakeCandidate() : null,
|
|
),
|
|
isImmediateRecoverySourceBlocked: vi.fn(async () => true),
|
|
});
|
|
const release = createReleaseIssueExecution({
|
|
issueLock: createFakeIssueLock(createFakeHost(), transaction),
|
|
recovery: createFakeRecovery(),
|
|
});
|
|
|
|
const result = await release({
|
|
companyId: RUN.companyId,
|
|
runId: RUN.id,
|
|
now: new Date(),
|
|
});
|
|
|
|
expect(transaction.queueImmediateRecoveryRun).not.toHaveBeenCalled();
|
|
if (hasDeferredInput) {
|
|
expect(transaction.isImmediateRecoverySourceBlocked).not.toHaveBeenCalled();
|
|
expect(result.outcome.kind).toBe("promoted");
|
|
} else {
|
|
expect(transaction.isImmediateRecoverySourceBlocked).toHaveBeenCalledWith({
|
|
companyId: RUN.companyId,
|
|
runId: RUN.id,
|
|
});
|
|
expect(result.outcome.kind).toBe("blocked");
|
|
}
|
|
},
|
|
);
|
|
|
|
it("processes the deferred wakes in requestedAt order", async () => {
|
|
const claimOrder: string[] = [];
|
|
const queue = [wakeCandidate({ id: "wake-earliest" }), wakeCandidate({ id: "wake-latest" })];
|
|
const transaction = createFakeTransaction({
|
|
findNextDeferredWake: vi.fn(async () => {
|
|
const next = queue.shift() ?? null;
|
|
if (next) claimOrder.push(next.id);
|
|
return next;
|
|
}),
|
|
// Every wake fails invokability so the loop keeps draining without promoting.
|
|
findInvokableAgent: vi.fn(async () => null),
|
|
});
|
|
const host = createFakeHost();
|
|
const issueLock = createFakeIssueLock(host, transaction);
|
|
const releaseIssueExecution = createReleaseIssueExecution({ issueLock, recovery: createFakeRecovery() });
|
|
|
|
await releaseIssueExecution({ companyId: "company-1", runId: "run-1", now: new Date() });
|
|
|
|
expect(claimOrder).toEqual(["wake-earliest", "wake-latest"]);
|
|
expect(transaction.failDeferredWake).toHaveBeenCalledTimes(2);
|
|
});
|
|
|
|
it("stops the loop after the first promotion", async () => {
|
|
const findNextDeferredWake = vi.fn(async () => wakeCandidate({ id: "wake-promotes" }));
|
|
const transaction = createFakeTransaction({ findNextDeferredWake });
|
|
const host = createFakeHost();
|
|
const issueLock = createFakeIssueLock(host, transaction);
|
|
const releaseIssueExecution = createReleaseIssueExecution({ issueLock, recovery: createFakeRecovery() });
|
|
|
|
const result = await releaseIssueExecution({ companyId: "company-1", runId: "run-1", now: new Date() });
|
|
|
|
expect(result.outcome.kind).toBe("promoted");
|
|
expect(findNextDeferredWake).toHaveBeenCalledTimes(1);
|
|
});
|
|
|
|
it("continues the loop after a cancel outcome, a fail outcome, and a normalize outcome, then promotes", async () => {
|
|
const queue = [
|
|
// cancel_empty: queued comments, none live, no independent continuation.
|
|
wakeCandidate({ id: "wake-cancel", queuedCommentIds: ["c1"] }),
|
|
// fail_not_invokable: agent lookup misses for this one wake only.
|
|
wakeCandidate({ id: "wake-fail", agentId: "uninvokable-agent" }),
|
|
// normalize: queued comments differ from the live set, then promotes.
|
|
wakeCandidate({ id: "wake-normalize", queuedCommentIds: ["c1", "c2"] }),
|
|
];
|
|
const findNextDeferredWake = vi.fn(async () => queue.shift() ?? null);
|
|
const findInvokableAgent = vi.fn(async (input: { agentId: string }) =>
|
|
input.agentId === "deferred-agent" ? AGENT : null,
|
|
);
|
|
const getQueuedCommentLiveness = vi.fn(async (input: { queuedCommentIds: string[] }) =>
|
|
input.queuedCommentIds.length === 1
|
|
? { liveNonSelfCommentIds: [], containedSelfAuthoredComment: false }
|
|
: { liveNonSelfCommentIds: ["c2"], containedSelfAuthoredComment: false },
|
|
);
|
|
const transaction = createFakeTransaction({ findNextDeferredWake, findInvokableAgent, getQueuedCommentLiveness });
|
|
const host = createFakeHost();
|
|
const issueLock = createFakeIssueLock(host, transaction);
|
|
const releaseIssueExecution = createReleaseIssueExecution({ issueLock, recovery: createFakeRecovery() });
|
|
|
|
const result = await releaseIssueExecution({ companyId: "company-1", runId: "run-1", now: new Date() });
|
|
|
|
expect(transaction.cancelDeferredWake).toHaveBeenCalledTimes(1);
|
|
expect(transaction.failDeferredWake).toHaveBeenCalledTimes(1);
|
|
expect(transaction.normalizeDeferredWakeCommentIds).toHaveBeenCalledTimes(1);
|
|
expect(findNextDeferredWake).toHaveBeenCalledTimes(3);
|
|
expect(result.outcome.kind).toBe("promoted");
|
|
});
|
|
|
|
it("rejects with deferred_wake_not_advanced when the queue read returns the same wake id twice, instead of looping forever", async () => {
|
|
// queuedCommentIds with no live comments and no independent continuation
|
|
// routes to "cancel_empty", so the drain calls cancelDeferredWake and
|
|
// discards its result, then reads the queue again for the same row.
|
|
const repeatedCandidate = wakeCandidate({ id: "wake-repeat", queuedCommentIds: ["c1"] });
|
|
const findNextDeferredWake = vi.fn(async () => repeatedCandidate);
|
|
const cancelDeferredWake = vi.fn(async () => false);
|
|
const transaction = createFakeTransaction({ findNextDeferredWake, cancelDeferredWake });
|
|
const host = createFakeHost();
|
|
const issueLock = createFakeIssueLock(host, transaction);
|
|
const releaseIssueExecution = createReleaseIssueExecution({ issueLock, recovery: createFakeRecovery() });
|
|
|
|
await expect(
|
|
releaseIssueExecution({ companyId: "company-1", runId: "run-1", now: new Date() }),
|
|
).rejects.toMatchObject({
|
|
constructor: WakeQueueApplicationError,
|
|
code: "deferred_wake_not_advanced",
|
|
});
|
|
expect(findNextDeferredWake).toHaveBeenCalledTimes(2);
|
|
});
|
|
|
|
it("returns the post-commit effects as data without running them", async () => {
|
|
const transaction = createFakeTransaction({ findNextDeferredWake: vi.fn(async () => wakeCandidate()) });
|
|
const host = createFakeHost();
|
|
const issueLock = createFakeIssueLock(host, transaction);
|
|
const recovery = createFakeRecovery();
|
|
const releaseIssueExecution = createReleaseIssueExecution({ issueLock, recovery });
|
|
|
|
const result = await releaseIssueExecution({ companyId: "company-1", runId: "run-1", now: new Date() });
|
|
|
|
expect(result.postCommitEffects).toEqual([{ kind: "run_queued", run: runSummary("wake-1") }]);
|
|
expect(recovery.escalateStrandedAssignedIssue).not.toHaveBeenCalled();
|
|
expect(recovery.escalateStrandedRecoveryIssueInPlace).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it("carries the deferred wake's raw issue, interaction, execution-stage, and accepted-plan context onto the promoted run, and clears only the rendered text projections", async () => {
|
|
const finalizePromotedWake = vi.fn(async (input: PromoteDeferredWakeInput) => runSummary(input.wakeId));
|
|
const transaction = createFakeTransaction({
|
|
findNextDeferredWake: vi.fn(async () =>
|
|
wakeCandidate({
|
|
deferredContextSeed: {
|
|
issueId: ISSUE.id,
|
|
wakeCommentIds: ["comment-1"],
|
|
// A queue-time render from a prior coalesced run. Promotion must
|
|
// not persist this alongside the current (unrelated) comment id.
|
|
paperclipTaskMarkdown: "queue-time markdown",
|
|
paperclipTaskMarkdownCompact: "queue-time compact markdown",
|
|
paperclipWake: { commentId: "comment-1" },
|
|
executionStage: { stage: "review" },
|
|
planReviewInteraction: { acceptedTargetRevision: { revisionId: "revision-1" } },
|
|
acceptedPlanWakeRouting: { targetAgentId: "agent-1" },
|
|
},
|
|
}),
|
|
),
|
|
finalizePromotedWake,
|
|
});
|
|
const host = createFakeHost();
|
|
const issueLock = createFakeIssueLock(host, transaction);
|
|
const releaseIssueExecution = createReleaseIssueExecution({ issueLock, recovery: createFakeRecovery() });
|
|
|
|
const result = await releaseIssueExecution({ companyId: "company-1", runId: "run-1", now: new Date() });
|
|
|
|
expect(result.outcome.kind).toBe("promoted");
|
|
expect(finalizePromotedWake).toHaveBeenCalledTimes(1);
|
|
const promotedContextSnapshot = finalizePromotedWake.mock.calls[0]![0].contextSnapshot;
|
|
// The rendered text is cleared; `executeRun` rebuilds it, with proper
|
|
// trust-based redaction, from the current issue and comment rows before
|
|
// the run dispatches.
|
|
expect(promotedContextSnapshot.paperclipTaskMarkdown).toBeUndefined();
|
|
expect(promotedContextSnapshot.paperclipTaskMarkdownCompact).toBeUndefined();
|
|
expect(promotedContextSnapshot.paperclipWake).toBeUndefined();
|
|
// The raw fields that render depends on are not dropped.
|
|
expect(promotedContextSnapshot.issueId).toBe(ISSUE.id);
|
|
expect(promotedContextSnapshot.executionStage).toEqual({ stage: "review" });
|
|
expect(promotedContextSnapshot.planReviewInteraction).toEqual({
|
|
acceptedTargetRevision: { revisionId: "revision-1" },
|
|
});
|
|
expect(promotedContextSnapshot.acceptedPlanWakeRouting).toEqual({ targetAgentId: "agent-1" });
|
|
});
|
|
|
|
it.each(["done", "cancelled"])("cancels stale assignee continuations before claiming promotion on %s tasks", async (status) => {
|
|
const queue = [wakeCandidate({ agentId: ISSUE.assigneeAgentId!, requestedByActorType: "agent" })];
|
|
const transaction = createFakeTransaction({
|
|
findNextDeferredWake: vi.fn(async () => queue.shift() ?? null),
|
|
});
|
|
const release = createReleaseIssueExecution({
|
|
issueLock: createFakeIssueLock(createFakeHost(), transaction, { ...ISSUE, status }),
|
|
recovery: createFakeRecovery(),
|
|
});
|
|
|
|
const result = await release({ companyId: RUN.companyId, runId: RUN.id, now: new Date() });
|
|
|
|
expect(transaction.cancelDeferredWake).toHaveBeenCalledWith(expect.objectContaining({
|
|
wakeId: "wake-1",
|
|
reason: "Deferred execution wake no longer applies to a terminal task",
|
|
}));
|
|
expect(transaction.claimDeferredWakeForPromotion).not.toHaveBeenCalled();
|
|
expect(transaction.finalizePromotedWake).not.toHaveBeenCalled();
|
|
expect(result.outcome.kind).toBe("released");
|
|
});
|
|
|
|
it("reopens a completed task before promoting its assignee's human follow-up", async () => {
|
|
const queue = [wakeCandidate({
|
|
agentId: ISSUE.assigneeAgentId!,
|
|
requestedByActorType: "user",
|
|
deferredCommentIds: ["human-follow-up"],
|
|
})];
|
|
const transaction = createFakeTransaction({
|
|
findNextDeferredWake: vi.fn(async () => queue.shift() ?? null),
|
|
reopenIssue: vi.fn(async () => ({ ...ISSUE, status: "todo" })),
|
|
});
|
|
const release = createReleaseIssueExecution({
|
|
issueLock: createFakeIssueLock(createFakeHost(), transaction, { ...ISSUE, status: "done" }),
|
|
recovery: createFakeRecovery(),
|
|
});
|
|
|
|
const result = await release({ companyId: RUN.companyId, runId: RUN.id, now: new Date() });
|
|
|
|
expect(transaction.cancelDeferredWake).not.toHaveBeenCalled();
|
|
expect(transaction.reopenIssue).toHaveBeenCalledTimes(1);
|
|
expect(transaction.finalizePromotedWake).toHaveBeenCalledTimes(1);
|
|
expect(result.outcome.kind).toBe("promoted");
|
|
});
|
|
|
|
it("never reopens the issue when the promotion claim loses the race, and moves on to the next wake", async () => {
|
|
const doneIssue: IssueSnapshot = { ...ISSUE, status: "done" };
|
|
const queue = [
|
|
// Carries a comment that would reopen the done issue, but the
|
|
// promotion claim below loses the race before that reopen can run.
|
|
wakeCandidate({
|
|
id: "wake-lost-race",
|
|
deferredCommentIds: ["c1"],
|
|
requestedByActorType: "user",
|
|
}),
|
|
wakeCandidate({ id: "wake-promotes" }),
|
|
];
|
|
const findNextDeferredWake = vi.fn(async () => queue.shift() ?? null);
|
|
const claimDeferredWakeForPromotion = vi.fn(async ({ wakeId }: { wakeId: string }) => wakeId !== "wake-lost-race");
|
|
const reopenIssue = vi.fn(async () => null);
|
|
const transaction = createFakeTransaction({ findNextDeferredWake, claimDeferredWakeForPromotion, reopenIssue });
|
|
const host = createFakeHost();
|
|
const issueLock: IssueLockWriter = {
|
|
withIssueExecutionLock: vi.fn(async (_input, fn) => {
|
|
const result = await fn({ primaryIssue: doneIssue, run: RUN }, { host, transaction });
|
|
return { ...result, run: RUN };
|
|
}),
|
|
};
|
|
const releaseIssueExecution = createReleaseIssueExecution({ issueLock, recovery: createFakeRecovery() });
|
|
|
|
const result = await releaseIssueExecution({ companyId: "company-1", runId: "run-1", now: new Date() });
|
|
|
|
expect(reopenIssue).not.toHaveBeenCalled();
|
|
expect(claimDeferredWakeForPromotion).toHaveBeenCalledTimes(2);
|
|
expect(result.outcome.kind).toBe("promoted");
|
|
expect(result.postCommitEffects).toEqual([{ kind: "run_queued", run: runSummary("wake-promotes") }]);
|
|
});
|
|
|
|
it("throws WakeQueueApplicationError with code responsible_user_unresolved when the responsible user cannot resolve", async () => {
|
|
const transaction = createFakeTransaction({ findNextDeferredWake: vi.fn(async () => wakeCandidate()) });
|
|
const host = createFakeHost({ resolveResponsibleUserId: vi.fn(async () => null) });
|
|
const issueLock = createFakeIssueLock(host, transaction);
|
|
const releaseIssueExecution = createReleaseIssueExecution({ issueLock, recovery: createFakeRecovery() });
|
|
|
|
await expect(
|
|
releaseIssueExecution({ companyId: "company-1", runId: "run-1", now: new Date() }),
|
|
).rejects.toMatchObject({
|
|
constructor: WakeQueueApplicationError,
|
|
code: "responsible_user_unresolved",
|
|
});
|
|
});
|
|
|
|
it("resolves the responsible user for an immediate recovery run before queuing it", async () => {
|
|
const resolveResponsibleUserId = vi.fn(
|
|
async (_input: Parameters<WakeQueueHost["resolveResponsibleUserId"]>[0]) => "resolved-user",
|
|
);
|
|
const queueImmediateRecoveryRun = vi.fn(
|
|
async (input: Parameters<WakeQueueTransaction["queueImmediateRecoveryRun"]>[0]) => runSummary("immediate-recovery"),
|
|
);
|
|
const transaction = createFakeTransaction({ queueImmediateRecoveryRun });
|
|
const host = createFakeHost({ resolveResponsibleUserId });
|
|
const issueLock = createFakeIssueLock(host, transaction);
|
|
const releaseIssueExecution = createReleaseIssueExecution({ issueLock, recovery: createFakeRecovery() });
|
|
|
|
const result = await releaseIssueExecution({ companyId: "company-1", runId: "run-1", now: new Date() });
|
|
|
|
expect(result.outcome.kind).toBe("queued_recovery");
|
|
expect(resolveResponsibleUserId).toHaveBeenCalledTimes(1);
|
|
const resolveCall = resolveResponsibleUserId.mock.calls[0]![0];
|
|
expect(resolveCall.requestedByActorType).toBe("system");
|
|
expect(resolveCall.requestedByActorId).toBeNull();
|
|
expect(resolveCall.source).toBe("automation");
|
|
expect(resolveCall.triggerDetail).toBe("system");
|
|
expect(resolveCall.existingRunResponsibleUserId).toBe(RUN.responsibleUserId);
|
|
// ISSUE.status is "in_progress", so the stalled-continuation labels apply.
|
|
expect(resolveCall.contextSnapshot).toEqual({
|
|
issueId: ISSUE.id,
|
|
taskId: ISSUE.id,
|
|
wakeReason: "issue_continuation_needed",
|
|
retryReason: "issue_continuation_needed",
|
|
source: "issue.continuation_recovery",
|
|
retryOfRunId: RUN.id,
|
|
});
|
|
|
|
expect(queueImmediateRecoveryRun).toHaveBeenCalledTimes(1);
|
|
const queueCall = queueImmediateRecoveryRun.mock.calls[0]![0];
|
|
expect(queueCall.reason).toBe("issue_continuation_needed");
|
|
expect(queueCall.responsibleUserId).toBe("resolved-user");
|
|
expect(queueCall.contextSnapshot).toBe(resolveCall.contextSnapshot);
|
|
});
|
|
|
|
it("throws WakeQueueApplicationError with code responsible_user_unresolved for a recovery run, without queuing it", async () => {
|
|
const transaction = createFakeTransaction();
|
|
const host = createFakeHost({ resolveResponsibleUserId: vi.fn(async () => null) });
|
|
const issueLock = createFakeIssueLock(host, transaction);
|
|
const releaseIssueExecution = createReleaseIssueExecution({ issueLock, recovery: createFakeRecovery() });
|
|
|
|
await expect(
|
|
releaseIssueExecution({ companyId: "company-1", runId: "run-1", now: new Date() }),
|
|
).rejects.toMatchObject({
|
|
constructor: WakeQueueApplicationError,
|
|
code: "responsible_user_unresolved",
|
|
});
|
|
expect(transaction.queueImmediateRecoveryRun).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it("escalates through the recovery port for a blocked outcome, after the transaction resolves", async () => {
|
|
const transaction = createFakeTransaction({
|
|
findNextDeferredWake: vi.fn(async () => null),
|
|
hasExistingExecutionPath: vi.fn(async () => false),
|
|
isAutomaticRecoverySuppressedByPauseHold: vi.fn(async () => false),
|
|
// The recovery agent (the finishing run's own agent) is not invokable, which forces "blocked".
|
|
findInvokableAgent: vi.fn(async () => null),
|
|
});
|
|
const host = createFakeHost();
|
|
const issueLock = createFakeIssueLock(host, transaction);
|
|
const recovery = createFakeRecovery();
|
|
const releaseIssueExecution = createReleaseIssueExecution({ issueLock, recovery });
|
|
|
|
const result = await releaseIssueExecution({ companyId: "company-1", runId: "run-1", now: new Date() });
|
|
|
|
expect(result.outcome.kind).toBe("blocked");
|
|
expect(result.outcome.kind === "blocked" && result.outcome.noticeKind).toBe("immediate_execution_path");
|
|
expect(recovery.escalateStrandedAssignedIssue).toHaveBeenCalledTimes(1);
|
|
});
|
|
});
|
|
|
|
const ACTIVE_EXECUTION_RUN: WakeAdmissionActiveExecutionRun = {
|
|
id: "active-run-1",
|
|
agentId: "execution-agent",
|
|
status: "running",
|
|
contextSnapshot: { taskKey: "issue-1" },
|
|
};
|
|
|
|
// The scope is opaque to the use case; the fakes below never inspect it.
|
|
const SCOPE = {} as TransactionScope;
|
|
|
|
function admissionInput(
|
|
overrides: Partial<AdmitWakeBehindIssueExecutionInput> = {},
|
|
): AdmitWakeBehindIssueExecutionInput {
|
|
return {
|
|
companyId: "company-1",
|
|
issueId: "issue-1",
|
|
agentId: "wake-agent",
|
|
agentNameKey: "codexcoder",
|
|
issueExecutionAgentNameKey: null,
|
|
activeExecutionRun: ACTIVE_EXECUTION_RUN,
|
|
liveRunExecutions: { has: () => true },
|
|
wakeCommentId: null,
|
|
forceFreshSession: false,
|
|
contextSnapshot: { wakeReason: "issue_commented" },
|
|
source: "on_demand",
|
|
triggerDetail: null,
|
|
payload: { issueId: "issue-1" },
|
|
requestedByActorType: "user",
|
|
requestedByActorId: "user-1",
|
|
idempotencyKey: null,
|
|
...overrides,
|
|
};
|
|
}
|
|
|
|
function createFakeAdmissionReader(overrides: Partial<WakeAdmissionReader> = {}): WakeAdmissionReader {
|
|
return {
|
|
isSameExecutionAgent: vi.fn(async () => true),
|
|
matchesActiveWakeActor: vi.fn(async () => true),
|
|
findExistingDeferredWake: vi.fn(async () => null),
|
|
...overrides,
|
|
};
|
|
}
|
|
|
|
function createFakeAdmissionWriter(overrides: Partial<WakeAdmissionWriter> = {}): WakeAdmissionWriter {
|
|
return {
|
|
coalesceIntoActiveExecutionRun: vi.fn(async () => ({ id: "merged-run-1" })),
|
|
mergeIntoExistingDeferredWake: vi.fn(async () => {}),
|
|
insertNewDeferredWake: vi.fn(async () => {}),
|
|
...overrides,
|
|
};
|
|
}
|
|
|
|
// Test doubles for the four heartbeat.ts decision helpers the module
|
|
// receives as a port. The defaults mirror the real helpers' behaviour for
|
|
// the plain wake in `admissionInput()`: no comment id, no forced fresh
|
|
// session, and a live coalesce target when `liveRunExecutions.has` says so.
|
|
function createFakeAdmissionHelpers(
|
|
overrides: Partial<WakeAdmissionHeartbeatHelpers> = {},
|
|
): WakeAdmissionHeartbeatHelpers {
|
|
return {
|
|
filterZombieCoalesceTarget: vi.fn((target, liveRunExecutions) =>
|
|
target && liveRunExecutions.has(target.id) ? target : null,
|
|
),
|
|
mergeCoalescedContextSnapshot: vi.fn((existingRaw, incoming) => ({
|
|
...(existingRaw && typeof existingRaw === "object" ? (existingRaw as Record<string, unknown>) : {}),
|
|
...incoming,
|
|
})),
|
|
shouldDeferFollowupWakeForSameIssue: vi.fn(() => false),
|
|
shouldQueueFollowupForRunningIssueWake: vi.fn(() => false),
|
|
...overrides,
|
|
};
|
|
}
|
|
|
|
describe("admitWakeBehindIssueExecution", () => {
|
|
it.each(["running", "queued"])(
|
|
"keeps a dedicated durable continuation separate from a %s execution and an existing deferred wake",
|
|
async (status) => {
|
|
const durableReceipt = {
|
|
id: "dedicated-receipt",
|
|
requestedAt: new Date("2026-09-10T00:00:00Z"),
|
|
};
|
|
const writer = createFakeAdmissionWriter();
|
|
const reader = createFakeAdmissionReader({
|
|
findExistingDeferredWake: vi.fn(async () => ({
|
|
id: "unrelated-deferred-wake",
|
|
payload: {},
|
|
deferredContext: {},
|
|
coalescedCount: 0,
|
|
})),
|
|
});
|
|
const helpers = createFakeAdmissionHelpers();
|
|
const admit = createAdmitWakeBehindIssueExecution({
|
|
reader,
|
|
writer,
|
|
helpers,
|
|
});
|
|
const contextSnapshot = {
|
|
issueId: "issue-1",
|
|
externalChatContinuation: true,
|
|
interactionId: "exact-interaction",
|
|
sourceRunId: "exact-source-run",
|
|
};
|
|
|
|
const result = await admit(
|
|
SCOPE,
|
|
admissionInput({
|
|
activeExecutionRun: { ...ACTIVE_EXECUTION_RUN, status },
|
|
allowRunCoalescing: false,
|
|
durableReceipt,
|
|
contextSnapshot,
|
|
}),
|
|
);
|
|
|
|
expect(result).toEqual({ kind: "deferred" });
|
|
expect(writer.coalesceIntoActiveExecutionRun).not.toHaveBeenCalled();
|
|
expect(reader.findExistingDeferredWake).not.toHaveBeenCalled();
|
|
expect(writer.mergeIntoExistingDeferredWake).not.toHaveBeenCalled();
|
|
expect(writer.insertNewDeferredWake).toHaveBeenCalledExactlyOnceWith(
|
|
SCOPE,
|
|
expect.objectContaining({
|
|
durableReceipt,
|
|
payload: {
|
|
issueId: "issue-1",
|
|
_paperclipWakeContext: contextSnapshot,
|
|
},
|
|
}),
|
|
);
|
|
},
|
|
);
|
|
|
|
it("partitions durable admission by the exact actor before considering a deferred merge", async () => {
|
|
const durableReceipt = {
|
|
id: "other-actor-receipt",
|
|
requestedAt: new Date("2026-09-10T00:00:00Z"),
|
|
};
|
|
const writer = createFakeAdmissionWriter();
|
|
const reader = createFakeAdmissionReader({
|
|
matchesActiveWakeActor: vi.fn(async () => false),
|
|
});
|
|
const helpers = createFakeAdmissionHelpers();
|
|
const admit = createAdmitWakeBehindIssueExecution({
|
|
reader,
|
|
writer,
|
|
helpers,
|
|
});
|
|
|
|
const result = await admit(
|
|
SCOPE,
|
|
admissionInput({
|
|
activeExecutionRun: {
|
|
...ACTIVE_EXECUTION_RUN,
|
|
wakeupRequestId: "active-wake",
|
|
},
|
|
durableReceipt,
|
|
requestedByActorType: "user",
|
|
requestedByActorId: "other-user",
|
|
}),
|
|
);
|
|
|
|
expect(result).toEqual({ kind: "deferred" });
|
|
expect(reader.matchesActiveWakeActor).toHaveBeenCalledExactlyOnceWith(
|
|
SCOPE,
|
|
{
|
|
companyId: "company-1",
|
|
wakeupRequestId: "active-wake",
|
|
requestedByActorType: "user",
|
|
requestedByActorId: "other-user",
|
|
},
|
|
);
|
|
expect(writer.coalesceIntoActiveExecutionRun).not.toHaveBeenCalled();
|
|
expect(reader.findExistingDeferredWake).toHaveBeenCalledExactlyOnceWith(
|
|
SCOPE,
|
|
{
|
|
companyId: "company-1",
|
|
agentId: "wake-agent",
|
|
issueId: "issue-1",
|
|
durableActor: { type: "user", id: "other-user" },
|
|
},
|
|
);
|
|
expect(writer.insertNewDeferredWake).toHaveBeenCalledExactlyOnceWith(
|
|
SCOPE,
|
|
expect.objectContaining({ durableReceipt }),
|
|
);
|
|
});
|
|
|
|
it("retains the durable receipt when the exact actor coalesces into the active execution", async () => {
|
|
const durableReceipt = {
|
|
id: "coalesced-receipt",
|
|
requestedAt: new Date("2026-09-10T00:00:00Z"),
|
|
};
|
|
const writer = createFakeAdmissionWriter();
|
|
const reader = createFakeAdmissionReader();
|
|
const helpers = createFakeAdmissionHelpers();
|
|
const admit = createAdmitWakeBehindIssueExecution({
|
|
reader,
|
|
writer,
|
|
helpers,
|
|
});
|
|
|
|
const result = await admit(
|
|
SCOPE,
|
|
admissionInput({
|
|
activeExecutionRun: {
|
|
...ACTIVE_EXECUTION_RUN,
|
|
wakeupRequestId: "active-wake",
|
|
},
|
|
durableReceipt,
|
|
}),
|
|
);
|
|
|
|
expect(result).toEqual({ kind: "coalesced", run: { id: "merged-run-1" } });
|
|
expect(reader.matchesActiveWakeActor).toHaveBeenCalledExactlyOnceWith(
|
|
SCOPE,
|
|
{
|
|
companyId: "company-1",
|
|
wakeupRequestId: "active-wake",
|
|
requestedByActorType: "user",
|
|
requestedByActorId: "user-1",
|
|
},
|
|
);
|
|
expect(
|
|
writer.coalesceIntoActiveExecutionRun,
|
|
).toHaveBeenCalledExactlyOnceWith(
|
|
SCOPE,
|
|
expect.objectContaining({ durableReceipt }),
|
|
);
|
|
expect(reader.findExistingDeferredWake).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it("retains an independent receipt when durable input merges into an existing deferred wake", async () => {
|
|
const durableReceipt = {
|
|
id: "merged-deferred-receipt",
|
|
requestedAt: new Date("2026-09-10T00:00:00Z"),
|
|
};
|
|
const writer = createFakeAdmissionWriter();
|
|
const reader = createFakeAdmissionReader({
|
|
isSameExecutionAgent: vi.fn(async () => false),
|
|
findExistingDeferredWake: vi.fn(async () => ({
|
|
id: "existing-deferred-wake",
|
|
runId: "existing-deferred-run",
|
|
payload: { issueId: "issue-1", preserved: true },
|
|
deferredContext: { preservedContext: true },
|
|
coalescedCount: 2,
|
|
})),
|
|
});
|
|
const helpers = createFakeAdmissionHelpers();
|
|
const admit = createAdmitWakeBehindIssueExecution({
|
|
reader,
|
|
writer,
|
|
helpers,
|
|
});
|
|
|
|
const result = await admit(
|
|
SCOPE,
|
|
admissionInput({
|
|
durableReceipt,
|
|
reason: "question_response",
|
|
idempotencyKey: "exact-receipt-key",
|
|
}),
|
|
);
|
|
|
|
expect(result).toEqual({ kind: "deferred" });
|
|
expect(
|
|
writer.mergeIntoExistingDeferredWake,
|
|
).toHaveBeenCalledExactlyOnceWith(
|
|
SCOPE,
|
|
expect.objectContaining({
|
|
existingDeferredWakeId: "existing-deferred-wake",
|
|
nextCoalescedCount: 3,
|
|
mergedPayload: {
|
|
issueId: "issue-1",
|
|
preserved: true,
|
|
_paperclipWakeContext: {
|
|
preservedContext: true,
|
|
wakeReason: "issue_commented",
|
|
},
|
|
},
|
|
coalescedReceipt: {
|
|
...durableReceipt,
|
|
agentId: "wake-agent",
|
|
source: "on_demand",
|
|
triggerDetail: null,
|
|
reason: "question_response",
|
|
payload: {
|
|
issueId: "issue-1",
|
|
coalescedIntoWakeupRequestId: "existing-deferred-wake",
|
|
},
|
|
requestedByActorType: "user",
|
|
requestedByActorId: "user-1",
|
|
idempotencyKey: "exact-receipt-key",
|
|
runId: "existing-deferred-run",
|
|
},
|
|
}),
|
|
);
|
|
expect(writer.insertNewDeferredWake).not.toHaveBeenCalled();
|
|
expect(writer.coalesceIntoActiveExecutionRun).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it("gives manual input its own run boundary even when the active receipt has the same requester", async () => {
|
|
const writer = createFakeAdmissionWriter();
|
|
const admit = createAdmitWakeBehindIssueExecution({
|
|
reader: createFakeAdmissionReader(), writer, helpers: createFakeAdmissionHelpers(),
|
|
});
|
|
expect(await admit(SCOPE, admissionInput({ payload: { issueId: "issue-1", manualUserWake: true } })))
|
|
.toEqual({ kind: "deferred" });
|
|
expect(writer.coalesceIntoActiveExecutionRun).not.toHaveBeenCalled();
|
|
expect(writer.insertNewDeferredWake).toHaveBeenCalledTimes(1);
|
|
});
|
|
|
|
it("keeps ordinary non-durable coalescing independent of durable actor lookup", async () => {
|
|
const writer = createFakeAdmissionWriter();
|
|
const reader = createFakeAdmissionReader({
|
|
matchesActiveWakeActor: vi.fn(async () => false),
|
|
});
|
|
const helpers = createFakeAdmissionHelpers();
|
|
const admit = createAdmitWakeBehindIssueExecution({
|
|
reader,
|
|
writer,
|
|
helpers,
|
|
});
|
|
|
|
expect(await admit(SCOPE, admissionInput())).toEqual({
|
|
kind: "coalesced",
|
|
run: { id: "merged-run-1" },
|
|
});
|
|
expect(reader.matchesActiveWakeActor).not.toHaveBeenCalled();
|
|
expect(writer.coalesceIntoActiveExecutionRun).toHaveBeenCalledTimes(1);
|
|
});
|
|
|
|
it("returns the coalesce outcome and calls the writer one time when the same agent's run absorbs the wake", async () => {
|
|
const writer = createFakeAdmissionWriter();
|
|
const reader = createFakeAdmissionReader();
|
|
const helpers = createFakeAdmissionHelpers();
|
|
const admit = createAdmitWakeBehindIssueExecution({ reader, writer, helpers });
|
|
|
|
const result = await admit(SCOPE, admissionInput());
|
|
|
|
expect(result).toEqual({ kind: "coalesced", run: { id: "merged-run-1" } });
|
|
expect(writer.coalesceIntoActiveExecutionRun).toHaveBeenCalledTimes(1);
|
|
expect(writer.mergeIntoExistingDeferredWake).not.toHaveBeenCalled();
|
|
expect(writer.insertNewDeferredWake).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it("never reads for an existing deferred wake on the coalesce path", async () => {
|
|
const writer = createFakeAdmissionWriter();
|
|
const reader = createFakeAdmissionReader();
|
|
const helpers = createFakeAdmissionHelpers();
|
|
const admit = createAdmitWakeBehindIssueExecution({ reader, writer, helpers });
|
|
|
|
const result = await admit(SCOPE, admissionInput());
|
|
|
|
expect(result.kind).toBe("coalesced");
|
|
expect(reader.findExistingDeferredWake).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it("merges into the existing deferred wake when the policy returns a merge target", async () => {
|
|
const mergeIntoExistingDeferredWake = vi.fn(
|
|
async (_scope: TransactionScope, _input: Parameters<WakeAdmissionWriter["mergeIntoExistingDeferredWake"]>[1]) => {},
|
|
);
|
|
const writer = createFakeAdmissionWriter({ mergeIntoExistingDeferredWake });
|
|
const reader = createFakeAdmissionReader({
|
|
isSameExecutionAgent: vi.fn(async () => false),
|
|
findExistingDeferredWake: vi.fn(async () => ({
|
|
id: "deferred-1",
|
|
payload: { issueId: "issue-1", foo: "bar" },
|
|
deferredContext: { wakeReason: "issue_commented" },
|
|
coalescedCount: 2,
|
|
})),
|
|
});
|
|
const helpers = createFakeAdmissionHelpers();
|
|
const admit = createAdmitWakeBehindIssueExecution({ reader, writer, helpers });
|
|
|
|
const result = await admit(SCOPE, admissionInput());
|
|
|
|
expect(result).toEqual({ kind: "deferred" });
|
|
expect(mergeIntoExistingDeferredWake).toHaveBeenCalledTimes(1);
|
|
const call = mergeIntoExistingDeferredWake.mock.calls[0]![1];
|
|
expect(call.existingDeferredWakeId).toBe("deferred-1");
|
|
expect(call.nextCoalescedCount).toBe(3);
|
|
expect(call.mergedPayload.foo).toBe("bar");
|
|
expect(writer.coalesceIntoActiveExecutionRun).not.toHaveBeenCalled();
|
|
expect(writer.insertNewDeferredWake).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it("inserts a new deferred wake when a different agent holds the lock and none is queued yet", async () => {
|
|
const writer = createFakeAdmissionWriter();
|
|
const reader = createFakeAdmissionReader({ isSameExecutionAgent: vi.fn(async () => false) });
|
|
const helpers = createFakeAdmissionHelpers();
|
|
const admit = createAdmitWakeBehindIssueExecution({ reader, writer, helpers });
|
|
|
|
const result = await admit(SCOPE, admissionInput());
|
|
|
|
expect(result).toEqual({ kind: "deferred" });
|
|
expect(writer.insertNewDeferredWake).toHaveBeenCalledTimes(1);
|
|
expect(writer.coalesceIntoActiveExecutionRun).not.toHaveBeenCalled();
|
|
expect(writer.mergeIntoExistingDeferredWake).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it("proceeds, and never reads for an existing deferred wake, when the zombie-run filter leaves no live coalesce target", async () => {
|
|
const writer = createFakeAdmissionWriter();
|
|
const reader = createFakeAdmissionReader();
|
|
const helpers = createFakeAdmissionHelpers();
|
|
const admit = createAdmitWakeBehindIssueExecution({ reader, writer, helpers });
|
|
|
|
const result = await admit(SCOPE, admissionInput({ liveRunExecutions: { has: () => false } }));
|
|
|
|
expect(result).toEqual({ kind: "proceed" });
|
|
expect(reader.findExistingDeferredWake).not.toHaveBeenCalled();
|
|
expect(writer.coalesceIntoActiveExecutionRun).not.toHaveBeenCalled();
|
|
expect(writer.mergeIntoExistingDeferredWake).not.toHaveBeenCalled();
|
|
expect(writer.insertNewDeferredWake).not.toHaveBeenCalled();
|
|
});
|
|
});
|