Files
PaperClipAI/ui/src/pages/SkillStudio.tsx
T
39279aa34f feat(ui): shared error, connectivity and query foundation for disconnects (#15754)
## Thinking Path

> - Paperclip is the open source app people use to manage AI agents for
work.
> - The board reads API data and keeps the current task on screen.
> - A restart or temporary network failure can interrupt those reads.
> - Separate page error handlers can hide cached data or expose raw
server codes.
> - The app needs one connection state, readable error copy and a
consistent read policy.
> - This change provides that foundation and moves affected read
surfaces onto it.
> - The dependent write layer in #17960 preserves edits and submissions
across the same failures.

## Linked Issues or Issue Description

**What happened?**

Temporary API failures could replace loaded content with errors.
Different surfaces handled the same outage differently. Some showed raw
server codes. A successful query to an unrelated service could also
falsely report that Paperclip had recovered.

**Expected behavior**

Keep cached content visible. Show one connection banner during sustained
trouble. Confirm recovery through the Paperclip health probe or its
WebSocket. Retry transient reads and show readable errors for permanent
failures.

**Steps to reproduce**

1. Open a populated task or workspace page.
2. Interrupt API requests with a 503 or a dropped connection.
3. Keep an unrelated external request in flight.
4. Confirm that cached content remains and that the external result
cannot clear the outage.
5. Restore the API and check that reads refresh.

The write layer first merged into this feature branch in #15769 now has
its own dependent PR, #17960. This PR contains the shared foundation and
read changes. Merge this PR first.

## What Changed

- Classify API errors and provide readable error copy, including
non-JSON proxy responses and Retry-After handling.
- Use one connection store and health probe with bounded backoff.
Confirm recovery from the server health probe or live-updates WebSocket.
- Pause reads while disconnected, retry transient errors, and refresh
active reads after recovery.
- Keep cached data visible through shared query views and affected page,
panel and plugin read surfaces.
- Add one app-level connection banner and support the pending-write
count consumed by the dependent write layer.
- Add a query-error rendering guard. Call it directly from the existing
CI step. Update development documentation.

## Verification

- Historical-chat lookup now follows the same ready/stale roster state
as rendering. Three regressions fail before the fix; the six new cases
pass after it, including working Retry, fresh data, no-cache error,
permanent 403 and company isolation. All six focused query/recovery
suites pass 200 tests. Final-commit CI passes and Apex is 5/5 with no
unresolved findings. Canary Dry Run initially refused a preview version
that was already on npm. It passed after one rerun with fresh registry
metadata; no check was disabled.

- Integrated current master and retained both transcript interest
registration and connectivity reporting on socket open. The seven
focused recovery/query suites pass 288 tests, and UI typecheck and
production build pass. All 9,451 UI tests across 799 files pass on the
merge commit. Final-commit CI passes and Apex is 5/5 with no unresolved
findings.

- Current head `70d9335d732219352ef0f98414439766bbcb33df`: all hosted CI
checks pass. Apex is **5/5** on that head with no unresolved findings.
The branch has no merge conflict. GitHub still requires code-owner
approval.

- The foundation passes 9,430 UI tests in 804 files. After integrating
current master page paths, 190 focused page tests pass.
- Two unrelated-success regressions fail before the latest fix. With the
fix, 62 focused UI tests, all six guard tests and UI TypeScript pass.
- The composed foundation and write layer pass **9,505 UI tests in 808
files**, UI TypeScript, a production UI build, and query-error, token
and map guards.
- A real Chromium journey on the composed source injects a 503 during
title save. The loaded task stays visible; one reconnect banner appears;
the edit saves after recovery; another task stays unchanged; the saved
title survives reload.
- Full recursive local checks were not repeated because Runner
compilation exhausted local disk during another repair. Hosted checks
must pass before merge. No new staging deployment is claimed.

- Latest review follow-up: a cached CaseDetail now survives a failed
HTTP 429 refresh. Its page regression fails before the fix and passes
after it. Eighty focused foundation tests, UI TypeScript, build and
guards pass after that change.
- Earlier CI evidence is retained: several foundation jobs received a
runner shutdown signal together. The write-layer head also failed an
unchanged Runner descriptor close test with `provider_transport_failed`.
The same Runner source passed that suite in the foundation run. New CI
runs cover the updated heads; no check or assertion was weakened.

## Risks

- Shared retry defaults change the time before transient read errors
appear. Permanent errors still fail promptly.
- ApiError.message now contains readable copy. Callers that compare raw
codes must use ApiError.code.
- Cache success can come from another service or local data. It must not
confirm Paperclip recovery.
- Durable writes are reviewed separately in #17960. This PR does not
change database or mutation contracts.

## Model Used

Anthropic Claude Opus 5.5 (`claude-opus-5-5`) produced the original work
with tool use. OpenAI Codex, GPT-6 family, assisted with restoration,
integration, tests and review fixes. The Codex session does not expose
its exact serving model ID or context window size.

## Checklist

- [x] I have included a thinking path that traces from project context
to this change
- [x] I have specified the model used (with version and capability
details)
- [x] I have checked ROADMAP.md and confirmed this PR does not duplicate
planned core work
- [x] I have searched GitHub for duplicate or related PRs and linked
them above
- [x] I have either (a) linked existing issues with `Fixes: #` / `Closes
#` / `Refs #` OR (b) described the issue in-PR following the relevant
issue template
- [x] I have not referenced internal/instance-local Paperclip issues or
links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip`
URLs)
- [x] My branch name describes the change (e.g. `docs/...`, `fix/...`)
and contains no internal Paperclip ticket id or instance-derived details
- [x] I have run tests locally and they pass
- [x] I have added or updated tests where applicable
- [x] I have updated relevant documentation to reflect my changes
- [x] I have considered and documented any risks above
- [x] All Paperclip CI gates are green
- [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups
- [x] I will address all Greptile and reviewer comments before
requesting merge

---------

Co-authored-by: devinfoley <139239+devinfoley@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Paperclip <noreply@paperclip.ing>
Co-authored-by: Amy (Opus) <claude@users.noreply.github.com>
2026-10-27 21:22:07 -07:00

3634 lines
125 KiB
TypeScript

import { SkillsPageNavigation } from "@/components/skill-studio/SkillsNavigationTabs";
import { interactionReadinessRefetchInterval } from "@/lib/issue-thread-interactions";
import { SkillBinaryFile } from "../components/SkillBinaryFile";
import { SkillSourceProvenance } from "../components/SkillSourceProvenance";
import { AgentIdentity } from "@/components/AgentIdentity";
import { QueryErrorState, useQueryView } from "@/components/QueryView";
import { useCallback, useEffect, useMemo, useRef, useState } from "react";
import { useMutation, useQuery, useQueryClient } from "@tanstack/react-query";
import {
AlertTriangle,
ArrowLeft,
ChevronDown,
ChevronRight,
Clock,
Copy,
FileCode,
FilePlus,
FileText,
FolderMinus,
FolderPlus,
FlaskConical,
GitFork,
History,
MoreHorizontal,
Pencil,
Play,
Plus,
RotateCcw,
Share2,
Trash2,
} from "lucide-react";
import type {
Agent,
CompanySkillDetail,
CompanySkillListItem,
CompanySkillTestInput,
CompanySkillTestRun,
CompanySkillTestRunDetail,
CompanySkillTestRunTemplate,
CompanySkillTestRunTemplateCreateRequest,
CompanySkillTestRunTemplateUpdateRequest,
CompanySkillVersion,
IssueDocument,
IssueThreadInteraction,
AskUserQuestionsInteraction,
AskUserQuestionsAnswer,
} from "@paperclipai/shared";
import { Link, useLocation, useNavigate, useParams, useSearchParams } from "@/lib/router";
import {
SearchableSelect,
type SearchableSelectGroup,
type SearchableSelectOption,
} from "@/components/SearchableSelect";
import { useBreadcrumbs } from "@/context/BreadcrumbContext";
import { useCompany } from "../context/CompanyContext";
import { useOptionalToastActions } from "../context/ToastContext";
import { classifySkillDenial } from "@/lib/skill-policy-denial";
import { agentsApi } from "@/api/agents";
import { companySkillsApi } from "@/api/companySkills";
import { issuesApi } from "@/api/issues";
import { queryKeys } from "@/lib/queryKeys";
import { copyTextToClipboard } from "@/lib/clipboard";
import { useCopyToast } from "@/lib/use-copy-action";
import { skillStudioNewRoute, skillStudioRoute } from "@/lib/company-skill-routes";
import {
buildBlankSkillDraft,
buildForkSkillDraft,
defaultSkillMarkdown,
normalizeSkillDraftSlug,
SKILL_CREATE_ACCENTS,
skillAccentColor,
skillCreateDraftToPayload,
splitCategoryDraft,
type SkillCreateDraft,
} from "@/lib/skill-create";
import { getRecentStudioSkillIds, trackRecentStudioSkill } from "@/lib/recent-skills";
import { AgentsUsingSkillBadge } from "@/components/skill-studio/AgentsUsingSkillDialog";
import { ForkSkillDialog } from "@/components/skill-studio/ForkSkillDialog";
import {
ProjectScanNotice,
SkillLineageChip,
} from "@/components/skill-studio/SkillProvenance";
import { isProjectScanSkill } from "@/lib/skill-fork";
import { cn, formatCents, relativeTime } from "@/lib/utils";
import { SkillCardIcon, type DiscoveryCard } from "./CompanySkills";
import {
ResizableHandle,
ResizablePanel,
ResizablePanelGroup,
} from "@/components/ui/resizable-panels";
import { Button } from "@/components/ui/button";
import { Badge } from "@/components/ui/badge";
import { Input } from "@/components/ui/input";
import { Textarea } from "@/components/ui/textarea";
import { Label } from "@/components/ui/label";
import { Card, CardContent, CardHeader } from "@/components/ui/card";
import { Tabs, TabsContent, TabsList, TabsTrigger } from "@/components/ui/tabs";
import {
Tooltip,
TooltipContent,
TooltipProvider,
TooltipTrigger,
} from "@/components/ui/tooltip";
import {
Dialog,
DialogContent,
DialogDescription,
DialogFooter,
DialogHeader,
DialogTitle,
} from "@/components/ui/dialog";
import { Sheet, SheetContent, SheetHeader, SheetTitle } from "@/components/ui/sheet";
import {
Popover,
PopoverContent,
PopoverTrigger,
} from "@/components/ui/popover";
import {
Command,
CommandEmpty,
CommandGroup,
CommandInput,
CommandItem,
CommandList,
} from "@/components/ui/command";
import {
DropdownMenu,
DropdownMenuContent,
DropdownMenuItem,
DropdownMenuSeparator,
DropdownMenuTrigger,
} from "@/components/ui/dropdown-menu";
import { FileTree, buildFileTree, type FileTreeNode } from "@/components/FileTree";
import { MarkdownEditor } from "@/components/MarkdownEditor";
import { FrontmatterPanel } from "@/components/FrontmatterPanel";
import { joinFrontmatterBlock, splitFrontmatterBlock } from "@paperclipai/shared";
import { MarkdownBody } from "@/components/MarkdownBody";
import { StatusBadge } from "@/components/StatusBadge";
import { EmptyState } from "@/components/EmptyState";
import { EntityRow } from "@/components/EntityRow";
import { FilterBar } from "@/components/FilterBar";
import { Identity } from "@/components/Identity";
import { IssueThreadInteractionCard } from "@/components/IssueThreadInteractionCard";
import { IssueAttachmentsSection } from "@/components/IssueAttachmentsSection";
import { ImageGalleryModal, type GalleryMediaItem } from "@/components/ImageGalleryModal";
import { Avatar, AvatarFallback, AvatarImage } from "@/components/ui/avatar";
import { IssueOutputSection } from "@/components/issue-output/IssueOutputSection";
import { buildLineDiff } from "@/lib/line-diff";
import {
buildCreateRunRequest,
buildReRunRequest,
DEFAULT_TEST_RUN_TEMPLATE_ID,
EMPTY_SAVED_INPUT_DRAFT_STATE,
evaluateRunGate,
getRunAdditionalDocuments,
getRunMediaGalleryItems,
getRunRawAttachments,
isAgentSelectable,
isInteractionAnswerable,
isTerminalRunStatus,
orderRecentlyUpdatedSkills,
orderRecentlyVisitedSkills,
skillEditorAvatar,
NO_TEST_RUN_TEMPLATE_STORAGE_VALUE,
parseRunTemplateSelection,
routeInteraction,
runBadgeStatus,
runHarnessUnavailableCopy,
runOutputMode,
runShortId,
resolveRunTemplateSelection,
serializeRunTemplateSelection,
savedInputDraftDirty,
selectedSavedInputDraft,
shouldPollRun,
showRunErrorCard,
syncSavedInputDraftState,
testTaskLinkState,
type RunTemplateSelection,
type SavedInputDraftState,
} from "@/lib/skill-studio";
const PANE_STORAGE_KEY = "skillStudio.paneSizes";
const RUN_TEMPLATE_STORAGE_KEY_PREFIX = "skillStudio.runTemplate";
const MOBILE_BREAKPOINT = 900;
const POLL_MS = 2000;
const EMPTY_RUN_TEMPLATES: CompanySkillTestRunTemplate[] = [];
/**
* Surface a mutation rejection as an error toast. Every Studio mutation routes
* failures through here so server rejections (409 agent_not_assignable, 422
* read-only, …) never get silently swallowed (PAP-13001).
*/
function useMutationErrorToast() {
const toast = useOptionalToastActions();
return useCallback(
(title: string) => (error: unknown) => {
// Under the open default there is no permission chrome. When an action is
// actually denied — by an explicit company policy (State B) or a platform
// safety invariant (State C) — show the actionable denial title/remediation
// instead of a generic "try again" error (§9.10, PAP-13865). Transient
// failures keep the plain error toast.
const denial = classifySkillDenial(error);
if (denial) {
toast?.pushToast({ tone: "warn", title: denial.title, body: denial.remediation });
return;
}
const body =
error instanceof Error && error.message ? error.message : "Please try again.";
toast?.pushToast({ tone: "error", title, body });
},
[toast],
);
}
// ---------------------------------------------------------------------------
// Pane-size persistence (contract: persist per user `skillStudio.paneSizes`)
// ---------------------------------------------------------------------------
type PaneLayout = { skill: number; input: number; runs: number };
const DEFAULT_LAYOUT: PaneLayout = { skill: 37.5, input: 25, runs: 37.5 };
function loadPaneLayout(): PaneLayout {
try {
const raw = localStorage.getItem(PANE_STORAGE_KEY);
if (!raw) return DEFAULT_LAYOUT;
const parsed = JSON.parse(raw) as Partial<PaneLayout>;
if (
typeof parsed?.skill === "number"
&& typeof parsed?.input === "number"
&& typeof parsed?.runs === "number"
) {
return { skill: parsed.skill, input: parsed.input, runs: parsed.runs };
}
} catch {
/* ignore malformed persisted layout */
}
return DEFAULT_LAYOUT;
}
function runTemplateStorageKey(companyId: string) {
return `${RUN_TEMPLATE_STORAGE_KEY_PREFIX}.${companyId}`;
}
function loadRunTemplateSelection(companyId: string): RunTemplateSelection {
try {
return parseRunTemplateSelection(localStorage.getItem(runTemplateStorageKey(companyId)));
} catch {
return DEFAULT_TEST_RUN_TEMPLATE_ID;
}
}
function persistRunTemplateSelection(companyId: string, selection: RunTemplateSelection) {
try {
localStorage.setItem(runTemplateStorageKey(companyId), serializeRunTemplateSelection(selection));
} catch {
/* storage may be unavailable (private mode) — non-fatal */
}
}
function useIsMobile() {
const [isMobile, setIsMobile] = useState(
() => typeof window !== "undefined" && window.innerWidth < MOBILE_BREAKPOINT,
);
useEffect(() => {
const onResize = () => setIsMobile(window.innerWidth < MOBILE_BREAKPOINT);
window.addEventListener("resize", onResize);
return () => window.removeEventListener("resize", onResize);
}, []);
return isMobile;
}
// ---------------------------------------------------------------------------
// Root
// ---------------------------------------------------------------------------
export function SkillStudio() {
const { skillId = "" } = useParams<{ skillId: string }>();
const location = useLocation();
const [searchParams] = useSearchParams();
const { selectedCompanyId } = useCompany();
const { setBreadcrumbs } = useBreadcrumbs();
const navigate = useNavigate();
const companyId = selectedCompanyId ?? "";
const isCreateMode = location.pathname.replace(/\/+$/, "").endsWith("/skills/studio/new");
const forkFromSkillId = isCreateMode ? searchParams.get("forkFrom")?.trim() || null : null;
// New skills created from a folder context (e.g. My Skills) carry their
// destination folder through this query param; without it the created skill
// silently lands in Unfiled (PAP-14086).
const newSkillFolderId = isCreateMode ? searchParams.get("folderId")?.trim() || null : null;
const skillsQuery = useQuery({
queryKey: queryKeys.companySkills.list(companyId),
queryFn: () => companySkillsApi.list(companyId, { sort: "alphabetical" }),
enabled: Boolean(companyId),
});
const detailQuery = useQuery({
queryKey: queryKeys.companySkills.detail(companyId, skillId),
queryFn: () => companySkillsApi.detail(companyId, skillId),
enabled: Boolean(companyId && skillId && !isCreateMode),
});
const detailView = useQueryView(detailQuery);
const forkDetailQuery = useQuery({
queryKey: queryKeys.companySkills.detail(companyId, forkFromSkillId ?? ""),
queryFn: () => companySkillsApi.detail(companyId, forkFromSkillId!),
enabled: Boolean(companyId && forkFromSkillId),
});
const skill = detailQuery.data ?? null;
useEffect(() => {
setBreadcrumbs(
isCreateMode
? [
{ label: "Skills", href: "/skills" },
{ label: "Studio", href: "/skills/studio" },
{ label: "New skill" },
]
: skill
? [
{ label: "Skills", href: "/skills" },
{ label: "Studio", href: "/skills/studio" },
{ label: skill.name },
]
: [
{ label: "Skills", href: "/skills" },
{ label: "Studio" },
],
);
}, [isCreateMode, setBreadcrumbs, skill]);
// Record a per-browser visit whenever a skill successfully opens, powering the
// landing's "Recently visited" section (PAP-13150).
useEffect(() => {
if (skill?.id) trackRecentStudioSkill(skill.id);
}, [skill?.id]);
if (!companyId) {
return <StudioMessage message="Select an organization to open Skill Studio." />;
}
if (isCreateMode) {
return (
<StudioCreateMode
companyId={companyId}
skills={skillsQuery.data ?? []}
skillsLoading={skillsQuery.isLoading}
forkFromSkillId={forkFromSkillId}
folderId={newSkillFolderId}
forkSkill={forkDetailQuery.data ?? null}
forkLoading={forkDetailQuery.isLoading}
forkError={forkDetailQuery.isError}
onSelectSkill={(nextSkillId) => navigate(skillStudioRoute(nextSkillId))}
/>
);
}
if (!skillId) {
return (
<StudioLanding
companyId={companyId}
skills={skillsQuery.data ?? []}
skillsLoading={skillsQuery.isLoading}
onSelectSkill={(nextSkillId) => navigate(skillStudioRoute(nextSkillId))}
onCreateNew={() => navigate(skillStudioNewRoute())}
/>
);
}
if (detailQuery.isLoading || detailView.kind === "reconnecting") {
return <StudioMessage message="Loading skill…" />;
}
// "Not found" only for a real 404; an outage never looks like a missing skill.
if (detailView.kind === "error" && detailView.errorKind !== "not_found") {
return (
<QueryErrorState
size="page"
error={detailQuery.error}
action="load this skill"
onRetry={detailView.retry}
retrying={detailView.isFetching}
/>
);
}
if (detailView.kind === "error" || !detailQuery.data) {
return <StudioMessage message="Skill not found." />;
}
return (
<StudioShell
companyId={companyId}
skill={detailQuery.data}
skills={skillsQuery.data ?? []}
skillsLoading={skillsQuery.isLoading}
/>
);
}
function StudioCreateMode({
companyId,
skills,
skillsLoading,
forkFromSkillId,
folderId,
forkSkill,
forkLoading,
forkError,
onSelectSkill,
}: {
companyId: string;
skills: CompanySkillListItem[];
skillsLoading: boolean;
forkFromSkillId: string | null;
folderId: string | null;
forkSkill: CompanySkillDetail | null;
forkLoading: boolean;
forkError: boolean;
onSelectSkill: (skillId: string) => void;
}) {
return (
<TooltipProvider delayDuration={200}>
<div className="flex h-full min-h-0 flex-col">
<header className="flex items-center gap-3 border-b border-border px-3 py-2">
<SkillSwitcher
skill={null}
skills={skills}
loading={skillsLoading}
onSelectSkill={onSelectSkill}
emptyLabel="New skill"
/>
</header>
<SkillsPageNavigation activeView="authored" />
<div className="min-h-0 flex-1 overflow-y-auto">
<StudioNewSkillPanel
companyId={companyId}
forkFromSkillId={forkFromSkillId}
folderId={folderId}
forkSkill={forkSkill}
forkLoading={forkLoading}
forkError={forkError}
/>
</div>
</div>
</TooltipProvider>
);
}
function StudioNewSkillPanel({
companyId,
forkFromSkillId,
folderId,
forkSkill,
forkLoading,
forkError,
}: {
companyId: string;
forkFromSkillId: string | null;
folderId: string | null;
forkSkill: CompanySkillDetail | null;
forkLoading: boolean;
forkError: boolean;
}) {
const navigate = useNavigate();
const queryClient = useQueryClient();
const toast = useOptionalToastActions();
const initialDraft = useMemo(() => {
const base = forkSkill ? buildForkSkillDraft(forkSkill) : buildBlankSkillDraft();
// An explicit folder context from the URL wins over a fork source's folder
// so the new skill is filed where the user launched creation (PAP-14086).
return folderId ? { ...base, folderId } : base;
}, [forkSkill, folderId]);
const [draft, setDraft] = useState<SkillCreateDraft>(initialDraft);
const [slugDirty, setSlugDirty] = useState(initialDraft.slug.trim().length > 0);
const [categoryDraft, setCategoryDraft] = useState(initialDraft.categories.join(", "));
const parsedCategories = splitCategoryDraft(categoryDraft);
const effectiveSlug = draft.slug.trim() || normalizeSkillDraftSlug(draft.name);
const nameValid = draft.name.trim().length > 0;
useEffect(() => {
setDraft(initialDraft);
setSlugDirty(initialDraft.slug.trim().length > 0);
setCategoryDraft(initialDraft.categories.join(", "));
}, [initialDraft]);
function patchDraft(patch: Partial<SkillCreateDraft>) {
setDraft((current) => ({ ...current, ...patch }));
}
const createSkill = useMutation({
mutationFn: () => companySkillsApi.create(companyId, skillCreateDraftToPayload({
...draft,
categories: parsedCategories,
})),
onSuccess: async (skill) => {
await queryClient.invalidateQueries({ queryKey: queryKeys.companySkills.list(companyId) });
toast?.pushToast({
tone: "success",
title: skill.forkedFromSkillId ? "Skill fork created" : "Skill created",
body: `${skill.name} is now editable in the Paperclip workspace.`,
});
navigate(skillStudioRoute(skill.id));
},
onError: (error) => {
toast?.pushToast({
tone: "error",
title: "Skill creation failed",
body: error instanceof Error ? error.message : "Failed to create skill.",
});
},
});
if (forkFromSkillId && forkLoading) {
return <StudioMessage message="Loading fork source..." />;
}
const previewCard: DiscoveryCard = {
key: effectiveSlug || draft.name || "new-skill",
skillId: null,
catalogRef: null,
name: draft.name || "New Skill",
slug: effectiveSlug || "skill",
author: "you",
version: null,
tagline: draft.tagline || null,
description: draft.tagline,
categories: parsedCategories,
iconUrl: null,
color: draft.color,
starCount: 0,
agentCount: 0,
forkCount: 0,
installed: false,
required: false,
forkedFrom: Boolean(draft.forkedFromSkillId),
updatedAt: Date.now(),
};
return (
<div className="mx-auto flex w-full max-w-4xl flex-col gap-6 px-4 py-6">
<div className="space-y-1">
<h1 className="text-lg font-semibold text-foreground">
{draft.forkedFromSkillId ? "Fork skill" : "Create a new skill"}
</h1>
<p className="text-sm text-muted-foreground">
Create an editable organization skill and open it directly in Studio.
</p>
</div>
{draft.forkedFromName ? (
<div className="flex items-center gap-2 rounded-md border border-border bg-muted/30 px-3 py-2 text-sm text-muted-foreground">
<GitFork className="h-4 w-4" />
Forking {draft.forkedFromName}
</div>
) : forkError ? (
<div className="flex items-center gap-2 rounded-md border border-destructive/40 bg-destructive/10 px-3 py-2 text-sm text-destructive">
<AlertTriangle className="h-4 w-4" />
Fork source not found. You can still create a blank skill.
</div>
) : null}
<section className="space-y-3">
<div>
<h2 className="text-sm font-medium text-foreground">Basics</h2>
<p className="text-xs text-muted-foreground">Name the skill and set the route-safe slug.</p>
</div>
<div className="grid gap-3 md:grid-cols-2">
<div className="space-y-1.5">
<Label htmlFor="skill-name">Name</Label>
<Input
id="skill-name"
value={draft.name}
onChange={(event) => {
const nextName = event.target.value;
patchDraft({
name: nextName,
slug: slugDirty ? draft.slug : normalizeSkillDraftSlug(nextName),
markdown: draft.markdown === defaultSkillMarkdown(draft.name, draft.tagline)
? defaultSkillMarkdown(nextName, draft.tagline)
: draft.markdown,
});
}}
placeholder="Code review"
/>
</div>
<div className="space-y-1.5">
<Label htmlFor="skill-slug">Slug</Label>
<Input
id="skill-slug"
value={draft.slug}
onChange={(event) => {
const nextSlug = normalizeSkillDraftSlug(event.target.value);
setSlugDirty(nextSlug.length > 0);
patchDraft({ slug: nextSlug });
}}
placeholder="code-review"
className="font-mono"
/>
</div>
</div>
<div className="space-y-1.5">
<Label htmlFor="skill-tagline">Tagline</Label>
<Textarea
id="skill-tagline"
value={draft.tagline}
onChange={(event) => {
const nextTagline = event.target.value;
patchDraft({
tagline: nextTagline,
description: draft.description ? draft.description : nextTagline,
markdown: draft.markdown === defaultSkillMarkdown(draft.name, draft.tagline)
? defaultSkillMarkdown(draft.name, nextTagline)
: draft.markdown,
});
}}
placeholder="Review repository changes for correctness, tests, and maintainability."
className="min-h-20"
/>
</div>
</section>
<section className="space-y-3">
<div>
<h2 className="text-sm font-medium text-foreground">Appearance</h2>
<p className="text-xs text-muted-foreground">Tune how the skill appears in the store and Studio switcher.</p>
</div>
<div className="flex items-center gap-3">
<SkillCardIcon card={previewCard} size={48} />
<div className="min-w-0">
<div className="truncate text-sm font-medium">{previewCard.name}</div>
<div className="truncate text-xs text-muted-foreground">{draft.tagline || "No tagline yet."}</div>
</div>
</div>
<div className="space-y-2">
<Label>Color</Label>
<div className="flex flex-wrap items-center gap-2">
{SKILL_CREATE_ACCENTS.map((color) => (
<button
key={color}
type="button"
onClick={() => patchDraft({ color })}
className={cn(
"h-7 w-7 rounded-md border",
draft.color === color ? "border-foreground" : "border-border",
)}
style={{ backgroundColor: color }}
aria-label={`Use ${color}`}
/>
))}
<Input
aria-label="Hex color"
value={draft.color}
onChange={(event) => patchDraft({ color: event.target.value })}
className="h-7 w-28 font-mono text-xs"
/>
</div>
</div>
<div className="space-y-1.5">
<Label htmlFor="skill-categories">Categories</Label>
<Input
id="skill-categories"
value={categoryDraft}
onChange={(event) => setCategoryDraft(event.target.value)}
placeholder="engineering, review, memory"
/>
</div>
</section>
<section className="space-y-3">
<div>
<h2 className="text-sm font-medium text-foreground">Sharing</h2>
<p className="text-xs text-muted-foreground">Choose who can discover this skill inside Paperclip.</p>
</div>
<div className="grid gap-2 sm:grid-cols-3">
{(["company", "private"] as const).map((scope) => (
<button
key={scope}
type="button"
onClick={() => patchDraft({ sharingScope: scope })}
className={cn(
"rounded-md border px-3 py-2 text-left text-sm",
draft.sharingScope === scope ? "border-foreground bg-accent/50" : "border-border",
)}
>
<span className="block font-medium">{scope === "company" ? "Organization" : "Private"}</span>
<span className="mt-1 block text-xs text-muted-foreground">
{scope === "company" ? "Visible inside this organization." : "Only visible in your library."}
</span>
</button>
))}
<button
type="button"
disabled
className="rounded-md border border-dashed border-border px-3 py-2 text-left text-sm text-muted-foreground"
>
<span className="block font-medium">Public</span>
<span className="mt-1 block text-xs">Coming later.</span>
</button>
</div>
</section>
<details className="rounded-md border border-border px-3 py-2">
<summary className="cursor-pointer text-sm font-medium text-foreground">Starter content</summary>
<Textarea
value={draft.markdown}
onChange={(event) => patchDraft({ markdown: event.target.value })}
className="mt-3 min-h-(--sz-22rem) resize-y font-mono text-xs"
/>
</details>
<div className="flex items-center justify-end gap-2 border-t border-border pt-4">
<Button variant="ghost" onClick={() => navigate("/skills/studio")} disabled={createSkill.isPending}>
Cancel
</Button>
<Button onClick={() => createSkill.mutate()} disabled={createSkill.isPending || !nameValid}>
<FilePlus className="h-4 w-4" />
{createSkill.isPending ? "Creating..." : draft.forkedFromSkillId ? "Create fork" : "Create skill"}
</Button>
</div>
</div>
);
}
function StudioMessage({ message }: { message: string }) {
return (
<div className="flex h-full min-h-(--sz-60vh) items-center justify-center text-sm text-muted-foreground">
{message}
</div>
);
}
function StudioEmptyState({
skills,
skillsLoading,
onSelectSkill,
onCreateNew,
}: {
skills: CompanySkillListItem[];
skillsLoading: boolean;
onSelectSkill: (skillId: string) => void;
onCreateNew: () => void;
}) {
return (
<TooltipProvider delayDuration={200}>
<div className="flex h-full min-h-0 flex-col">
<header className="flex items-center gap-3 border-b border-border px-3 py-2">
<SkillSwitcher
skill={null}
skills={skills}
loading={skillsLoading}
onSelectSkill={onSelectSkill}
emptyLabel="Select skill"
/>
</header>
<SkillsPageNavigation activeView="authored" />
<div className="flex flex-1 items-center justify-center">
<EmptyState
icon={FileCode}
message={skillsLoading ? "Loading skills..." : "Select a skill to open Studio."}
action="Create a new skill"
onAction={onCreateNew}
/>
</div>
</div>
</TooltipProvider>
);
}
// ---------------------------------------------------------------------------
// Landing — recently visited + recently updated (PAP-13150)
// ---------------------------------------------------------------------------
function StudioLanding({
companyId,
skills,
skillsLoading,
onSelectSkill,
onCreateNew,
}: {
companyId: string;
skills: CompanySkillListItem[];
skillsLoading: boolean;
onSelectSkill: (skillId: string) => void;
onCreateNew: () => void;
}) {
// Recency-sorted list, enriched with the last human editor (PAP-13149) — the
// source for both landing sections. Kept separate from the alphabetical
// switcher list so each cache stays sorted the way its consumer expects.
const recentQuery = useQuery({
queryKey: queryKeys.companySkills.listRecent(companyId),
queryFn: () => companySkillsApi.list(companyId, { sort: "recent", include: ["lastEditor"] }),
enabled: Boolean(companyId),
});
const recentSkills = recentQuery.data ?? [];
const visited = useMemo(
() => orderRecentlyVisitedSkills(recentSkills, getRecentStudioSkillIds()),
[recentSkills],
);
const updated = useMemo(
() => orderRecentlyUpdatedSkills(recentSkills, visited.map((skill) => skill.id)),
[recentSkills, visited],
);
// No skills at all (or still loading) -> today's empty/loading fallback.
if (recentSkills.length === 0) {
return (
<StudioEmptyState
skills={skills}
skillsLoading={skillsLoading || recentQuery.isLoading}
onSelectSkill={onSelectSkill}
onCreateNew={onCreateNew}
/>
);
}
return (
<TooltipProvider delayDuration={200}>
<div className="flex h-full min-h-0 flex-col">
<header className="flex items-center gap-3 border-b border-border px-3 py-2">
<SkillSwitcher
skill={null}
skills={skills}
loading={skillsLoading}
onSelectSkill={onSelectSkill}
emptyLabel="Select skill"
/>
<Button variant="ghost" size="sm" className="ml-auto" onClick={onCreateNew}>
<Plus className="mr-1.5 h-3.5 w-3.5" />
New skill
</Button>
</header>
<SkillsPageNavigation activeView="authored" />
<div className="min-h-0 flex-1 overflow-auto">
<div className="mx-auto w-full max-w-3xl space-y-8 px-4 py-8">
{visited.length > 0 ? (
<StudioLandingSection
title="Recently visited"
skills={visited}
onSelectSkill={onSelectSkill}
/>
) : null}
<StudioLandingSection
title="Recently updated"
skills={updated}
onSelectSkill={onSelectSkill}
/>
</div>
</div>
</div>
</TooltipProvider>
);
}
function StudioLandingSection({
title,
skills,
onSelectSkill,
}: {
title: string;
skills: CompanySkillListItem[];
onSelectSkill: (skillId: string) => void;
}) {
if (skills.length === 0) return null;
return (
<section className="space-y-2">
<h2 className="text-xs font-semibold uppercase tracking-wide text-muted-foreground">
{title}
</h2>
<div className="divide-y divide-border overflow-hidden rounded-md border border-border">
{skills.map((skill) => (
<StudioLandingRow
key={skill.id}
skill={skill}
onSelect={() => onSelectSkill(skill.id)}
/>
))}
</div>
</section>
);
}
function StudioLandingRow({
skill,
onSelect,
}: {
skill: CompanySkillListItem;
onSelect: () => void;
}) {
const editor = skillEditorAvatar(skill.lastEditor);
return (
<button
type="button"
onClick={onSelect}
className="flex w-full items-center gap-3 px-3 py-2.5 text-left hover:bg-accent"
>
<SkillLandingIcon skill={skill} />
<span className="flex min-w-0 flex-1 flex-col">
<span className="truncate text-sm font-medium">{skill.name}</span>
{skill.tagline ? (
<span className="truncate text-xs text-muted-foreground">{skill.tagline}</span>
) : null}
</span>
<span className="shrink-0 text-xs text-muted-foreground">
updated {relativeTime(skill.updatedAt)}
</span>
{editor ? (
<Tooltip>
<TooltipTrigger asChild>
<Avatar size="xs">
{editor.imageUrl ? <AvatarImage src={editor.imageUrl} alt="" /> : null}
<AvatarFallback>{editor.initials}</AvatarFallback>
</Avatar>
</TooltipTrigger>
<TooltipContent>{editor.name}</TooltipContent>
</Tooltip>
) : (
<span className="w-5 shrink-0" aria-hidden="true" />
)}
</button>
);
}
function SkillLandingIcon({ skill }: { skill: CompanySkillListItem }) {
if (skill.iconUrl) {
return (
<img
src={skill.iconUrl}
alt=""
className="h-9 w-9 shrink-0 rounded-md object-cover"
/>
);
}
const accent = skillAccentColor(skill.key, skill.color);
const letter = (skill.slug || skill.name || "?").trim().charAt(0).toUpperCase();
return (
<span
aria-hidden="true"
className="flex h-9 w-9 shrink-0 items-center justify-center rounded-md text-sm font-semibold text-white"
style={{ backgroundColor: accent }}
>
{letter}
</span>
);
}
// ---------------------------------------------------------------------------
// Shell — header + three panes (or mobile tabs)
// ---------------------------------------------------------------------------
function StudioShell({
companyId,
skill,
skills,
skillsLoading,
}: {
companyId: string;
skill: CompanySkillDetail;
skills: CompanySkillListItem[];
skillsLoading: boolean;
}) {
const skillId = skill.id;
const isMobile = useIsMobile();
const [searchParams, setSearchParams] = useSearchParams();
const navigate = useNavigate();
const queryClient = useQueryClient();
// --- selection / cross-pane state ---
const [selectedInputId, setSelectedInputId] = useState<string | null>(
() => searchParams.get("input"),
);
const [selectedRunId, setSelectedRunId] = useState<string | null>(
() => searchParams.get("run"),
);
const [adHocMode, setAdHocMode] = useState(false);
const [adHocContent, setAdHocContent] = useState("");
const [selectedAgentId, setSelectedAgentId] = useState<string | null>(null);
const [skillDirty, setSkillDirty] = useState(false);
const [versionSheetOpen, setVersionSheetOpen] = useState(false);
const [forkDialogOpen, setForkDialogOpen] = useState(false);
const layoutRef = useRef<PaneLayout>(loadPaneLayout());
// Keep deep-link params in sync (?input, ?run).
useEffect(() => {
const next = new URLSearchParams(searchParams);
if (selectedInputId) next.set("input", selectedInputId);
else next.delete("input");
if (selectedRunId) next.set("run", selectedRunId);
else next.delete("run");
if (next.toString() !== searchParams.toString()) {
setSearchParams(next, { replace: true });
}
// eslint-disable-next-line react-hooks/exhaustive-deps
}, [selectedInputId, selectedRunId]);
const inputsQuery = useQuery({
queryKey: queryKeys.companySkills.testInputs(companyId, skillId),
queryFn: () => companySkillsApi.testInputs(companyId, skillId),
enabled: Boolean(companyId && skillId),
});
const persistLayout = useCallback((layout: Record<string, number>) => {
const next: PaneLayout = {
skill: layout.skill ?? layoutRef.current.skill,
input: layout.input ?? layoutRef.current.input,
runs: layout.runs ?? layoutRef.current.runs,
};
layoutRef.current = next;
try {
localStorage.setItem(PANE_STORAGE_KEY, JSON.stringify(next));
} catch {
/* storage may be unavailable (private mode) — non-fatal */
}
}, []);
const inputs = inputsQuery.data ?? [];
const selectedInput = inputs.find((i) => i.id === selectedInputId) ?? null;
const leftPane = (
<SkillPane
companyId={companyId}
skill={skill}
onDirtyChange={setSkillDirty}
onEditACopy={() => setForkDialogOpen(true)}
/>
);
const projectScan = isProjectScanSkill(skill.metadata);
const middlePane = (
<InputPane
companyId={companyId}
skillId={skillId}
inputs={inputs}
loading={inputsQuery.isLoading}
selectedInputId={selectedInputId}
adHocMode={adHocMode}
adHocContent={adHocContent}
onAdHocChange={setAdHocContent}
onSelectInput={(id) => {
setSelectedInputId(id);
setAdHocMode(false);
}}
onSelectAdHoc={() => {
setAdHocContent("");
setAdHocMode(true);
setSelectedInputId(null);
}}
/>
);
const rightPane = (
<RunsPane
companyId={companyId}
skill={skill}
inputs={inputs}
selectedInput={selectedInput}
adHocMode={adHocMode}
adHocContent={adHocContent}
selectedRunId={selectedRunId}
onSelectRun={setSelectedRunId}
selectedAgentId={selectedAgentId}
onSelectAgent={setSelectedAgentId}
skillDirty={skillDirty}
filterInput={selectedInput}
onClearFilter={() => setSelectedInputId(null)}
/>
);
return (
<TooltipProvider delayDuration={200}>
<div className="flex h-full min-h-0 flex-col">
<StudioHeader
companyId={companyId}
skill={skill}
skillDirty={skillDirty}
skills={skills}
skillsLoading={skillsLoading}
onSelectSkill={(nextSkillId) => navigate(skillStudioRoute(nextSkillId))}
onOpenVersions={() => setVersionSheetOpen(true)}
/>
<SkillsPageNavigation activeView="authored" />
{projectScan ? (
<ProjectScanNotice skill={skill} onEditACopy={() => setForkDialogOpen(true)} />
) : null}
{isMobile ? (
<MobileTabs skill={leftPane} input={middlePane} runs={rightPane} />
) : (
<ResizablePanelGroup
className="flex-1 min-h-0"
defaultLayout={{
skill: layoutRef.current.skill,
input: layoutRef.current.input,
runs: layoutRef.current.runs,
}}
onLayoutChanged={persistLayout}
>
<ResizablePanel id="skill" minSize="280px" className="border-r border-border">
{leftPane}
</ResizablePanel>
<ResizableHandle />
<ResizablePanel
id="input"
minSize="240px"
collapsible
collapsedSize="40px"
className="border-r border-border"
>
{middlePane}
</ResizablePanel>
<ResizableHandle />
<ResizablePanel id="runs" minSize="360px">
{rightPane}
</ResizablePanel>
</ResizablePanelGroup>
)}
</div>
<VersionHistorySheet
open={versionSheetOpen}
onOpenChange={setVersionSheetOpen}
companyId={companyId}
skill={skill}
onRestored={() => {
setSkillDirty(false);
queryClient.invalidateQueries({
queryKey: queryKeys.companySkills.detail(companyId, skillId),
});
}}
onFilterRuns={(inputId) => setSelectedInputId(inputId)}
/>
<ForkSkillDialog
companyId={companyId}
skill={skill}
open={forkDialogOpen}
onOpenChange={setForkDialogOpen}
/>
</TooltipProvider>
);
}
// ---------------------------------------------------------------------------
// Header
// ---------------------------------------------------------------------------
function StudioHeader({
companyId,
skill,
skillDirty,
skills,
skillsLoading,
onSelectSkill,
onOpenVersions,
}: {
companyId: string;
skill: CompanySkillDetail;
skillDirty: boolean;
skills: CompanySkillListItem[];
skillsLoading: boolean;
onSelectSkill: (skillId: string) => void;
onOpenVersions: () => void;
}) {
const version = skill.currentVersion?.revisionNumber ?? null;
const toast = useOptionalToastActions();
const copyShareLink = useCallback(() => {
const href = typeof window !== "undefined" ? window.location.href : "";
void copyTextToClipboard(href)
.then(() => toast?.pushToast({ tone: "success", title: "Link copied", body: "Skill Studio link copied to clipboard." }))
.catch((error) => toast?.pushToast({
tone: "error",
title: "Copy failed",
body: error instanceof Error ? error.message : "Could not copy the link.",
}));
}, [toast]);
return (
<header className="flex items-center gap-3 border-b border-border px-3 py-2">
<SkillSwitcher
skill={skill}
skills={skills}
loading={skillsLoading}
onSelectSkill={onSelectSkill}
/>
{version !== null && (
<span className="font-mono text-xs text-muted-foreground">v{version}</span>
)}
{skillDirty ? (
<Badge variant="secondary">Unsaved edits</Badge>
) : null}
{!skill.editable ? (
<Badge variant="secondary">Read-only</Badge>
) : null}
{skill.forkedFromSkillId ? (
<SkillLineageChip
companyId={companyId}
forkedFromSkillId={skill.forkedFromSkillId}
/>
) : null}
<AgentsUsingSkillBadge companyId={companyId} skill={skill} />
<div className="ml-auto flex items-center gap-1">
<Button variant="ghost" size="sm" onClick={onOpenVersions}>
<History className="mr-1.5 h-3.5 w-3.5" />
Version history
</Button>
<DropdownMenu>
<DropdownMenuTrigger asChild>
<Button variant="ghost" size="icon-sm" aria-label="Studio menu">
<MoreHorizontal className="h-4 w-4" />
</Button>
</DropdownMenuTrigger>
<DropdownMenuContent align="end" className="w-52">
<DropdownMenuItem onClick={copyShareLink}>
<Share2 className="mr-2 h-4 w-4" /> Share link
</DropdownMenuItem>
</DropdownMenuContent>
</DropdownMenu>
</div>
</header>
);
}
type SkillSwitcherOption = SearchableSelectOption<string> & {
skill: CompanySkillListItem | CompanySkillDetail;
};
function SkillSwitcher({
skill,
skills,
loading,
onSelectSkill,
emptyLabel = "Select skill",
}: {
skill: CompanySkillDetail | null;
skills: CompanySkillListItem[];
loading: boolean;
onSelectSkill: (skillId: string) => void;
emptyLabel?: string;
}) {
const groups = useMemo<readonly SearchableSelectGroup<string, SkillSwitcherOption>[]>(() => {
const options: SkillSwitcherOption[] = withCurrentSkill(skills, skill).map((item) => ({
key: item.id,
value: item.id,
label: item.name,
title: item.name,
searchText: [item.name, item.slug, item.key, item.description ?? ""].join(" "),
skill: item,
}));
return [{ id: "skills", options }];
}, [skill, skills]);
return (
<SearchableSelect<string, SkillSwitcherOption>
value={skill?.id ?? ""}
groups={groups}
loading={loading}
loadingMessage="Loading skills..."
placeholder={emptyLabel}
searchPlaceholder="Search skills..."
emptyMessage="No matching skills."
onValueChange={(value) => {
if (value !== skill?.id) onSelectSkill(value);
}}
triggerClassName="h-8 w-64 border-0 bg-transparent px-0 text-base font-semibold shadow-none hover:bg-accent md:w-80"
contentClassName="w-80"
contentWidth="auto"
renderValue={(option) => option?.label ?? skill?.name ?? emptyLabel}
renderOption={(option, { selected }) => (
<span className="flex min-w-0 flex-col">
<span className={cn("truncate", selected && "font-medium")}>{option.label}</span>
<span className="truncate text-(length:--text-micro) text-muted-foreground">
{option.skill.slug}
</span>
</span>
)}
/>
);
}
function withCurrentSkill(
skills: CompanySkillListItem[],
skill: CompanySkillDetail | null,
): Array<CompanySkillListItem | CompanySkillDetail> {
if (!skill) return skills;
return skills.some((candidate) => candidate.id === skill.id) ? skills : [skill, ...skills];
}
// ---------------------------------------------------------------------------
// Left — Skill files + editor
// ---------------------------------------------------------------------------
function SkillPane({
companyId,
skill,
onDirtyChange,
onEditACopy,
}: {
companyId: string;
skill: CompanySkillDetail;
onDirtyChange: (dirty: boolean) => void;
onEditACopy: () => void;
}) {
const skillId = skill.id;
const queryClient = useQueryClient();
const onError = useMutationErrorToast();
const paths = useMemo(
() => skill.fileInventory.map((f) => f.path),
[skill.fileInventory],
);
const [selectedFile, setSelectedFile] = useState<string>(
() => paths.find((p) => /skill\.md$/i.test(p)) ?? paths[0] ?? "SKILL.md",
);
const [expandedDirs, setExpandedDirs] = useState<Set<string>>(new Set());
const [draft, setDraft] = useState<string>("");
const [savedContent, setSavedContent] = useState<string>("");
const [createDialog, setCreateDialog] = useState<"file" | "folder" | null>(null);
const [deleteFolderOpen, setDeleteFolderOpen] = useState(false);
// Gate rich-editor onChange until the user actually interacts with the body.
// MDXEditor can emit a normalizing onChange on mount, which would otherwise
// dirty the file on open and break the byte-identity guarantee (PAP-13156).
const bodyInteractedRef = useRef(false);
const markBodyInteracted = useCallback(() => {
bodyInteractedRef.current = true;
}, []);
const nodes: FileTreeNode[] = useMemo(
() => buildFileTree(Object.fromEntries(paths.map((p) => [p, ""]))),
[paths],
);
const fileQuery = useQuery({
queryKey: queryKeys.companySkills.file(companyId, skillId, selectedFile),
queryFn: () => companySkillsApi.file(companyId, skillId, selectedFile),
enabled: Boolean(companyId && skillId && selectedFile),
});
useEffect(() => {
if (fileQuery.data) {
bodyInteractedRef.current = false;
setDraft(fileQuery.data.content);
setSavedContent(fileQuery.data.content);
}
}, [fileQuery.data]);
const dirty = draft !== savedContent;
const currentFolder = parentFolder(selectedFile);
const pathSet = useMemo(() => new Set(paths), [paths]);
useEffect(() => {
onDirtyChange(dirty);
}, [dirty, onDirtyChange]);
const selectFile = useCallback((path: string) => {
if (path === selectedFile) return;
if (
dirty
&& typeof window !== "undefined"
&& !window.confirm("Discard unsaved edits and switch files?")
) {
return;
}
setSelectedFile(path);
}, [dirty, selectedFile]);
const saveMutation = useMutation({
mutationFn: () => companySkillsApi.updateFile(companyId, skillId, selectedFile, draft),
onSuccess: (updated) => {
setSavedContent(updated.content);
queryClient.invalidateQueries({
queryKey: queryKeys.companySkills.detail(companyId, skillId),
});
queryClient.invalidateQueries({
queryKey: queryKeys.companySkills.list(companyId),
});
queryClient.invalidateQueries({
queryKey: queryKeys.companySkills.versions(companyId, skillId),
});
},
onError: onError("Couldn't save file"),
});
const createMutation = useMutation({
mutationFn: ({ path, content }: { path: string; content: string }) =>
companySkillsApi.updateFile(companyId, skillId, path, content),
onSuccess: (created) => {
setSelectedFile(created.path);
setDraft(created.content);
setSavedContent(created.content);
setCreateDialog(null);
queryClient.invalidateQueries({
queryKey: queryKeys.companySkills.detail(companyId, skillId),
});
queryClient.invalidateQueries({
queryKey: queryKeys.companySkills.list(companyId),
});
queryClient.invalidateQueries({
queryKey: queryKeys.companySkills.versions(companyId, skillId),
});
},
onError: onError("Couldn't create file"),
});
const deleteMutation = useMutation({
mutationFn: (input: { path: string; target: "file" | "folder" }) =>
companySkillsApi.deleteFile(companyId, skillId, input),
onSuccess: (result) => {
const deleted = new Set(result.deletedPaths);
const remaining = paths.filter((path) => !deleted.has(path));
setSelectedFile(remaining.find((path) => /skill\.md$/i.test(path)) ?? remaining[0] ?? "SKILL.md");
setDeleteFolderOpen(false);
queryClient.invalidateQueries({
queryKey: queryKeys.companySkills.detail(companyId, skillId),
});
queryClient.invalidateQueries({
queryKey: queryKeys.companySkills.list(companyId),
});
queryClient.invalidateQueries({
queryKey: queryKeys.companySkills.versions(companyId, skillId),
});
},
onError: onError("Couldn't delete file"),
});
// Read-only skills (bundled Paperclip, remote GitHub, URL, skills.sh) reject
// file writes server-side; reflect that up-front instead of letting the user
// type into an editor whose Save silently 422s (PAP-13001 Bug B).
const readOnly = skill.editable === false || fileQuery.data?.editable === false;
if (paths.length === 0) {
return (
<PaneScaffold
title={<SkillPaneTitle skillName={skill.name} folder="root" />}
action={
<SkillFileActions
readOnly={readOnly}
selectedFile={selectedFile}
currentFolder=""
canDeleteFile={false}
pending={createMutation.isPending || deleteMutation.isPending || dirty}
onAddFile={() => setCreateDialog("file")}
onAddFolder={() => setCreateDialog("folder")}
onDeleteFile={() => {}}
onDeleteFolder={() => setDeleteFolderOpen(true)}
/>
}
>
<EmptyState icon={FileCode} message="This skill has no files yet." />
<SkillPathDialog
mode={createDialog}
open={createDialog !== null}
onOpenChange={(open) => {
if (!open) setCreateDialog(null);
}}
currentFolder=""
existingPaths={pathSet}
pending={createMutation.isPending}
onSubmit={(path, content) => createMutation.mutate({ path, content })}
/>
</PaneScaffold>
);
}
const isMarkdown = fileQuery.data?.markdown ?? /\.md$/i.test(selectedFile);
const markdownBlock = isMarkdown ? splitFrontmatterBlock(draft) : null;
return (
<PaneScaffold
title={<SkillPaneTitle skillName={skill.name} folder={currentFolder || "root"} />}
action={
<SkillFileActions
readOnly={readOnly}
selectedFile={selectedFile}
currentFolder={currentFolder}
canDeleteFile={selectedFile !== "SKILL.md"}
pending={createMutation.isPending || deleteMutation.isPending || dirty}
onAddFile={() => setCreateDialog("file")}
onAddFolder={() => setCreateDialog("folder")}
onDeleteFile={() => deleteMutation.mutate({ path: selectedFile, target: "file" })}
onDeleteFolder={() => setDeleteFolderOpen(true)}
/>
}
>
<div className="flex min-h-0 flex-1 flex-col">
{dirty && !readOnly ? (
<div className="flex items-start gap-2 border-b border-border bg-muted/40 px-3 py-2 text-xs text-muted-foreground">
<AlertTriangle className="mt-0.5 h-3.5 w-3.5 shrink-0 text-amber-500" />
<span>Unsaved edits live only in this Studio session. Save to create the next version before running tests or switching files.</span>
</div>
) : null}
<div className="max-h-(--sz-11_75rem) overflow-auto border-b border-border p-1">
<FileTree
nodes={nodes}
selectedFile={selectedFile}
expandedDirs={expandedDirs}
onToggleDir={(path) =>
setExpandedDirs((prev) => {
const next = new Set(prev);
if (next.has(path)) next.delete(path);
else next.add(path);
return next;
})
}
onSelectFile={selectFile}
showCheckboxes={false}
ariaLabel="Skill files"
/>
</div>
<SkillSourceProvenance skill={skill} />
{readOnly && (
<div className="flex items-start gap-3 border-b border-border bg-muted/40 px-3 py-2.5 text-xs text-muted-foreground">
<AlertTriangle className="mt-0.5 h-3.5 w-3.5 shrink-0 text-amber-500" />
<div className="min-w-0 flex-1">
<p>
{skill.metadata?.skillSourceId ? "This skill is synced from GitHub and is read-only." : skill.editableReason ?? "This skill is read-only because it comes from an external source."}
{" "}Make an editable copy to change it — the original stays untouched.
</p>
<Button
type="button"
size="sm"
className="mt-2"
onClick={onEditACopy}
>
<GitFork className="mr-1.5 h-3.5 w-3.5" />
Make a copy
</Button>
</div>
</div>
)}
<div className="flex items-center justify-between gap-2 px-3 py-1.5">
<span className="truncate font-mono text-xs text-muted-foreground">
{selectedFile}
{skill.currentVersion ? ` · v${skill.currentVersion.revisionNumber}` : ""}
</span>
<div className="flex items-center gap-2">
{readOnly ? (
<Badge variant="secondary">Read-only</Badge>
) : (
<>
{dirty && <Badge variant="secondary">Unsaved</Badge>}
<Button
size="sm"
disabled={!dirty || saveMutation.isPending}
onClick={() => saveMutation.mutate()}
>
{saveMutation.isPending ? "Saving…" : "Save"}
</Button>
</>
)}
</div>
</div>
{isMarkdown && markdownBlock?.hasFrontmatter ? (
<FrontmatterPanel
key={`fm:${selectedFile}`}
frontmatterText={markdownBlock.frontmatterText}
hasFrontmatter={markdownBlock.hasFrontmatter}
fileName={selectedFile}
skillSlug={skill.slug}
readOnly={readOnly}
onChange={(change) => {
setDraft((prev) =>
joinFrontmatterBlock({
frontmatterText: change.frontmatterText,
body: splitFrontmatterBlock(prev).body,
hasFrontmatter: change.hasFrontmatter,
}),
);
}}
/>
) : null}
<div
className="min-h-0 flex-1 overflow-auto px-3 pb-3"
onBeforeInputCapture={markBodyInteracted}
onDropCapture={markBodyInteracted}
onInput={markBodyInteracted}
onKeyDownCapture={markBodyInteracted}
onPasteCapture={markBodyInteracted}
onPointerDownCapture={markBodyInteracted}
>
{fileQuery.data?.encoding === "base64" ? <SkillBinaryFile file={fileQuery.data} /> : isMarkdown && markdownBlock ? (
<MarkdownEditor
key={`body:${selectedFile}`}
value={markdownBlock.body}
onChange={(nextBody) => {
// Ignore MDXEditor's on-mount normalization; only apply real edits.
if (!bodyInteractedRef.current) return;
setDraft((prev) => {
const block = splitFrontmatterBlock(prev);
return joinFrontmatterBlock({ ...block, body: nextBody });
});
}}
bordered={false}
readOnly={readOnly}
className="min-h-(--sz-320px)"
/>
) : (
<Textarea
value={draft}
onChange={(e) => setDraft(e.target.value)}
readOnly={readOnly}
className="min-h-(--sz-320px) font-mono text-xs"
spellCheck={false}
/>
)}
</div>
</div>
<SkillPathDialog
mode={createDialog}
open={createDialog !== null}
onOpenChange={(open) => {
if (!open) setCreateDialog(null);
}}
currentFolder={currentFolder}
existingPaths={pathSet}
pending={createMutation.isPending}
onSubmit={(path, content) => createMutation.mutate({ path, content })}
/>
<DeleteFolderDialog
open={deleteFolderOpen}
onOpenChange={setDeleteFolderOpen}
currentFolder={currentFolder}
existingPaths={pathSet}
pending={deleteMutation.isPending}
onSubmit={(path) => deleteMutation.mutate({ path, target: "folder" })}
/>
</PaneScaffold>
);
}
function parentFolder(filePath: string) {
const parts = filePath.split("/").filter(Boolean);
if (parts.length <= 1) return "";
return parts.slice(0, -1).join("/");
}
function normalizeStudioPath(value: string) {
return value
.replace(/\\/g, "/")
.replace(/^\.\/+/, "")
.replace(/^\/+/, "")
.split("/")
.filter((segment) => segment && segment !== ".")
.join("/");
}
function folderSeedFile(folderPath: string) {
return `${folderPath}/README.md`;
}
function folderSeedContent(folderPath: string) {
const label = folderPath.split("/").filter(Boolean).at(-1) ?? "Folder";
return `# ${label}\n`;
}
function SkillPaneTitle({ skillName, folder }: { skillName: string; folder: string }) {
return (
<span className="flex min-w-0 items-center gap-1.5">
<span className="truncate">{skillName}</span>
<ChevronRight className="h-3 w-3 shrink-0" />
<span className="truncate font-mono normal-case tracking-normal">{folder}</span>
</span>
);
}
function SkillFileActions({
readOnly,
selectedFile,
canDeleteFile,
pending,
onAddFile,
onAddFolder,
onDeleteFile,
onDeleteFolder,
}: {
readOnly: boolean;
selectedFile: string;
currentFolder: string;
canDeleteFile: boolean;
pending: boolean;
onAddFile: () => void;
onAddFolder: () => void;
onDeleteFile: () => void;
onDeleteFolder: () => void;
}) {
const disabled = readOnly || pending;
const deleteDisabled = disabled || !canDeleteFile;
return (
<div className="flex items-center gap-1">
<Tooltip>
<TooltipTrigger asChild>
<span>
<Button variant="ghost" size="icon-sm" disabled={disabled} onClick={onAddFile} aria-label="Add file">
<FilePlus className="h-4 w-4" />
</Button>
</span>
</TooltipTrigger>
<TooltipContent>Add file</TooltipContent>
</Tooltip>
<Tooltip>
<TooltipTrigger asChild>
<span>
<Button variant="ghost" size="icon-sm" disabled={disabled} onClick={onAddFolder} aria-label="Add folder">
<FolderPlus className="h-4 w-4" />
</Button>
</span>
</TooltipTrigger>
<TooltipContent>Add folder</TooltipContent>
</Tooltip>
<Tooltip>
<TooltipTrigger asChild>
<span>
<Button
variant="ghost"
size="icon-sm"
disabled={deleteDisabled}
onClick={() => {
if (typeof window === "undefined" || window.confirm(`Delete ${selectedFile}?`)) {
onDeleteFile();
}
}}
aria-label="Delete file"
>
<Trash2 className="h-4 w-4" />
</Button>
</span>
</TooltipTrigger>
<TooltipContent>{canDeleteFile ? "Delete file" : "SKILL.md cannot be deleted"}</TooltipContent>
</Tooltip>
<Tooltip>
<TooltipTrigger asChild>
<span>
<Button variant="ghost" size="icon-sm" disabled={disabled} onClick={onDeleteFolder} aria-label="Delete folder">
<FolderMinus className="h-4 w-4" />
</Button>
</span>
</TooltipTrigger>
<TooltipContent>Delete folder</TooltipContent>
</Tooltip>
</div>
);
}
function SkillPathDialog({
mode,
open,
onOpenChange,
currentFolder,
existingPaths,
pending,
onSubmit,
}: {
mode: "file" | "folder" | null;
open: boolean;
onOpenChange: (open: boolean) => void;
currentFolder: string;
existingPaths: Set<string>;
pending: boolean;
onSubmit: (path: string, content: string) => void;
}) {
const [pathValue, setPathValue] = useState("");
const [error, setError] = useState<string | null>(null);
useEffect(() => {
if (!open || !mode) return;
setPathValue(mode === "folder"
? normalizeStudioPath(currentFolder ? `${currentFolder}/new-folder` : "new-folder")
: normalizeStudioPath(currentFolder ? `${currentFolder}/new-file.md` : "notes.md"));
setError(null);
}, [currentFolder, mode, open]);
const title = mode === "folder" ? "Add folder" : "Add file";
const label = mode === "folder" ? "Folder path" : "File path";
function submit() {
if (!mode) return;
const normalized = normalizeStudioPath(pathValue);
if (!normalized) {
setError(`${label} is required.`);
return;
}
if (mode === "file") {
if (existingPaths.has(normalized)) {
setError("A file already exists at that path.");
return;
}
onSubmit(normalized, "");
return;
}
const folderPath = normalized.replace(/\/+$/, "");
if ([...existingPaths].some((path) => path.startsWith(`${folderPath}/`))) {
setError("A folder already exists at that path.");
return;
}
onSubmit(folderSeedFile(folderPath), folderSeedContent(folderPath));
}
return (
<Dialog open={open} onOpenChange={onOpenChange}>
<DialogContent>
<DialogHeader>
<DialogTitle>{title}</DialogTitle>
<DialogDescription>
Saved changes create a new version immediately. External sources are not updated until you publish or install an update.
</DialogDescription>
</DialogHeader>
<div className="space-y-2">
<Label htmlFor="skill-path-input">{label}</Label>
<Input
id="skill-path-input"
value={pathValue}
onChange={(event) => {
setPathValue(event.target.value);
setError(null);
}}
placeholder={mode === "folder" ? "references/examples" : "references/examples.md"}
/>
{mode === "folder" ? (
<p className="text-xs text-muted-foreground">A README.md seed file is created so the folder appears in the file tree.</p>
) : null}
{error ? <p className="text-xs text-destructive">{error}</p> : null}
</div>
<DialogFooter>
<Button variant="ghost" onClick={() => onOpenChange(false)}>
Cancel
</Button>
<Button disabled={pending} onClick={submit}>
Create
</Button>
</DialogFooter>
</DialogContent>
</Dialog>
);
}
function DeleteFolderDialog({
open,
onOpenChange,
currentFolder,
existingPaths,
pending,
onSubmit,
}: {
open: boolean;
onOpenChange: (open: boolean) => void;
currentFolder: string;
existingPaths: Set<string>;
pending: boolean;
onSubmit: (path: string) => void;
}) {
const [pathValue, setPathValue] = useState("");
const [error, setError] = useState<string | null>(null);
useEffect(() => {
if (!open) return;
setPathValue(currentFolder);
setError(null);
}, [currentFolder, open]);
function submit() {
const normalized = normalizeStudioPath(pathValue).replace(/\/+$/, "");
if (!normalized) {
setError("Folder path is required.");
return;
}
const matchingFiles = [...existingPaths].filter((path) => path.startsWith(`${normalized}/`));
if (matchingFiles.length === 0) {
setError("No files exist under that folder.");
return;
}
if (matchingFiles.includes("SKILL.md")) {
setError("SKILL.md cannot be deleted.");
return;
}
onSubmit(normalized);
}
return (
<Dialog open={open} onOpenChange={onOpenChange}>
<DialogContent>
<DialogHeader>
<DialogTitle>Delete folder</DialogTitle>
<DialogDescription>
This removes every skill file under the folder and saves the result as the next version.
</DialogDescription>
</DialogHeader>
<div className="space-y-2">
<Label htmlFor="skill-folder-delete">Folder path</Label>
<Input
id="skill-folder-delete"
value={pathValue}
onChange={(event) => {
setPathValue(event.target.value);
setError(null);
}}
placeholder="references/examples"
/>
{error ? <p className="text-xs text-destructive">{error}</p> : null}
</div>
<DialogFooter>
<Button variant="ghost" onClick={() => onOpenChange(false)}>
Cancel
</Button>
<Button variant="destructive" disabled={pending} onClick={submit}>
Delete
</Button>
</DialogFooter>
</DialogContent>
</Dialog>
);
}
// ---------------------------------------------------------------------------
// Middle — Inputs (path-foldered) + editor + save-as-input
// ---------------------------------------------------------------------------
function InputPane({
companyId,
skillId,
inputs,
loading,
selectedInputId,
adHocMode,
adHocContent,
onAdHocChange,
onSelectInput,
onSelectAdHoc,
}: {
companyId: string;
skillId: string;
inputs: CompanySkillTestInput[];
loading: boolean;
selectedInputId: string | null;
adHocMode: boolean;
adHocContent: string;
onAdHocChange: (value: string) => void;
onSelectInput: (id: string) => void;
onSelectAdHoc: () => void;
}) {
const queryClient = useQueryClient();
const onError = useMutationErrorToast();
// The row's menu closes on click, so its copy confirmation goes to a toast.
const copyWithToast = useCopyToast();
const [expandedDirs, setExpandedDirs] = useState<Set<string>>(new Set());
const [savedInputDraft, setSavedInputDraft] = useState<SavedInputDraftState>(
EMPTY_SAVED_INPUT_DRAFT_STATE,
);
const [saveDialogOpen, setSaveDialogOpen] = useState(false);
const [collapsed, setCollapsed] = useState(false);
const selectedInput = inputs.find((i) => i.id === selectedInputId) ?? null;
// In ad-hoc mode the editor is controlled by the shared shell state; otherwise
// it edits a local copy of the selected saved input.
const savedDraft = selectedSavedInputDraft(savedInputDraft, selectedInput);
const draft = adHocMode ? adHocContent : savedDraft;
const setDraft = adHocMode
? onAdHocChange
: (value: string) => {
setSavedInputDraft((previous) => ({
inputId: selectedInput?.id ?? previous.inputId,
draft: value,
baselineContent: selectedInput?.content ?? previous.baselineContent,
}));
};
useEffect(() => {
if (adHocMode) return;
setSavedInputDraft((previous) => syncSavedInputDraftState(previous, selectedInput));
}, [adHocMode, selectedInput?.content, selectedInput?.id]);
useEffect(() => {
if (!loading && inputs.length === 0 && !adHocMode && !selectedInputId) {
onSelectAdHoc();
}
}, [adHocMode, inputs.length, loading, onSelectAdHoc, selectedInputId]);
const nameToId = useMemo(
() => new Map(inputs.map((i) => [i.name, i.id])),
[inputs],
);
const nodes: FileTreeNode[] = useMemo(
() => buildFileTree(Object.fromEntries(inputs.map((i) => [i.name, i.content]))),
[inputs],
);
const selectedName = selectedInput?.name ?? null;
const dirty = !adHocMode && savedInputDraftDirty(savedInputDraft, selectedInput);
const canSaveSelectedInput = Boolean(selectedInput && dirty && draft.trim());
const confirmDiscardDirtyInput = useCallback(() => {
if (!dirty) return true;
return (
typeof window === "undefined"
|| window.confirm("Discard unsaved changes to this input?")
);
}, [dirty]);
const selectSavedInput = useCallback((id: string) => {
if (!adHocMode && id === selectedInputId) return;
if (!confirmDiscardDirtyInput()) return;
onSelectInput(id);
}, [adHocMode, confirmDiscardDirtyInput, onSelectInput, selectedInputId]);
const selectAdHocInput = useCallback(() => {
if (!adHocMode && !confirmDiscardDirtyInput()) return;
onSelectAdHoc();
}, [adHocMode, confirmDiscardDirtyInput, onSelectAdHoc]);
const updateMutation = useMutation({
mutationFn: (payload: { content: string }) =>
companySkillsApi.updateTestInput(companyId, skillId, selectedInput!.id, payload),
onSuccess: (updated) => {
setSavedInputDraft({
inputId: updated.id,
draft: updated.content,
baselineContent: updated.content,
});
queryClient.setQueryData<CompanySkillTestInput[]>(
queryKeys.companySkills.testInputs(companyId, skillId),
(current) => current?.map((input) => input.id === updated.id ? updated : input),
);
queryClient.invalidateQueries({
queryKey: queryKeys.companySkills.testInputs(companyId, skillId),
});
},
onError: onError("Couldn't save input"),
});
const deleteMutation = useMutation({
mutationFn: (inputId: string) => companySkillsApi.deleteTestInput(companyId, skillId, inputId),
onSuccess: (deleted) => {
if (deleted.id === selectedInputId) {
onSelectAdHoc();
}
queryClient.invalidateQueries({
queryKey: queryKeys.companySkills.testInputs(companyId, skillId),
});
},
onError: onError("Couldn't delete input"),
});
return (
<PaneScaffold
title={
<span className="flex min-w-0 items-center gap-1">
<Tooltip>
<TooltipTrigger asChild>
<Button
type="button"
variant="ghost"
size="icon-xs"
aria-label={collapsed ? "Expand input" : "Collapse input"}
onClick={() => setCollapsed((current) => !current)}
>
{collapsed ? (
<ChevronRight className="h-3.5 w-3.5" />
) : (
<ChevronDown className="h-3.5 w-3.5" />
)}
</Button>
</TooltipTrigger>
<TooltipContent>{collapsed ? "Expand input" : "Collapse input"}</TooltipContent>
</Tooltip>
<span>Input</span>
</span>
}
action={
<div className="flex items-center gap-1">
<Tooltip>
<TooltipTrigger asChild>
<Button variant="ghost" size="icon-sm" onClick={selectAdHocInput} aria-label="New input">
<Plus className="h-4 w-4" />
</Button>
</TooltipTrigger>
<TooltipContent>New input</TooltipContent>
</Tooltip>
</div>
}
>
{collapsed ? (
<button
type="button"
className="flex min-h-(--sz-32px) items-center gap-2 border-b border-border px-3 py-2 text-left text-xs text-muted-foreground hover:bg-accent hover:text-foreground"
onClick={() => setCollapsed(false)}
>
<ChevronRight className="h-3.5 w-3.5" />
<span>Input folded</span>
</button>
) : (
<div className="flex min-h-0 flex-1 flex-col">
{loading || inputs.length > 0 ? (
<div className="max-h-(--sz-11_75rem) overflow-auto border-b border-border p-1">
{loading ? (
<div className="p-3 text-xs text-muted-foreground">Loading inputs…</div>
) : (
<>
{adHocMode && (
<div className="flex items-center gap-2 rounded px-2 py-1.5 text-sm italic text-muted-foreground">
<FilePlus className="h-3.5 w-3.5" /> New input (not saved)
</div>
)}
<FileTree
nodes={nodes}
selectedFile={selectedName}
expandedDirs={expandedDirs}
onToggleDir={(path) =>
setExpandedDirs((prev) => {
const next = new Set(prev);
if (next.has(path)) next.delete(path);
else next.add(path);
return next;
})
}
onSelectFile={(name) => {
const id = nameToId.get(name);
if (id) selectSavedInput(id);
}}
showCheckboxes={false}
renderFileExtra={(node) => {
const id = nameToId.get(node.path);
if (!id) return null;
return (
<DropdownMenu>
<DropdownMenuTrigger asChild>
<button
className="rounded p-0.5 text-muted-foreground hover:bg-accent hover:text-foreground"
aria-label={`Input actions for ${node.name}`}
onClick={(e) => e.stopPropagation()}
>
<MoreHorizontal className="h-3.5 w-3.5" />
</button>
</DropdownMenuTrigger>
<DropdownMenuContent align="end" className="w-44">
<DropdownMenuItem
onClick={() => {
const input = inputs.find((i) => i.id === id);
if (input) void copyWithToast(input.content, "Input content copied");
}}
>
<Copy className="mr-2 h-4 w-4" /> Copy content
</DropdownMenuItem>
<DropdownMenuSeparator />
<DropdownMenuItem
variant="destructive"
onClick={() => deleteMutation.mutate(id)}
>
<Trash2 className="mr-2 h-4 w-4" /> Delete
</DropdownMenuItem>
</DropdownMenuContent>
</DropdownMenu>
);
}}
ariaLabel="Test inputs"
/>
</>
)}
</div>
) : null}
<div className="flex min-h-0 flex-1">
<textarea
value={draft}
onChange={(event) => setDraft(event.target.value)}
placeholder="Paste text - treated as a new issue description."
aria-label="Skill test input"
className="min-h-0 flex-1 resize-none border-0 bg-transparent px-3 py-3 text-sm leading-6 outline-none placeholder:text-muted-foreground focus-visible:ring-0"
/>
</div>
<div className="flex items-center gap-2 border-t border-border px-3 py-2">
<div className="mr-auto flex min-w-0 items-center gap-2 text-xs text-muted-foreground">
<span className="truncate">
{selectedInput ? selectedInput.name : adHocMode ? "New input" : "No input selected"}
</span>
{dirty ? <Badge variant="secondary">Unsaved</Badge> : null}
</div>
{selectedInput && dirty ? (
<>
<Button
variant="ghost"
size="sm"
disabled={updateMutation.isPending}
onClick={() => setSavedInputDraft({
inputId: selectedInput.id,
draft: selectedInput.content,
baselineContent: selectedInput.content,
})}
>
Revert
</Button>
<Button
variant="outline"
size="sm"
disabled={!canSaveSelectedInput || updateMutation.isPending}
onClick={() => updateMutation.mutate({ content: draft })}
>
{updateMutation.isPending ? "Saving..." : "Save changes"}
</Button>
</>
) : null}
<Button
size="sm"
disabled={!draft.trim()}
onClick={() => setSaveDialogOpen(true)}
>
Save as input
</Button>
</div>
</div>
)}
<SaveInputDialog
open={saveDialogOpen}
onOpenChange={setSaveDialogOpen}
companyId={companyId}
skillId={skillId}
initialContent={draft}
onSaved={(input) => {
setSaveDialogOpen(false);
onSelectInput(input.id);
}}
/>
</PaneScaffold>
);
}
function SaveInputDialog({
open,
onOpenChange,
companyId,
skillId,
initialContent,
onSaved,
}: {
open: boolean;
onOpenChange: (open: boolean) => void;
companyId: string;
skillId: string;
initialContent: string;
onSaved: (input: CompanySkillTestInput) => void;
}) {
const queryClient = useQueryClient();
const [name, setName] = useState("");
const [content, setContent] = useState(initialContent);
useEffect(() => {
if (open) {
setContent(initialContent);
setName("");
}
}, [open, initialContent]);
const createMutation = useMutation({
mutationFn: () => companySkillsApi.createTestInput(companyId, skillId, { name: name.trim(), content }),
onSuccess: (input) => {
queryClient.setQueryData<CompanySkillTestInput[]>(
queryKeys.companySkills.testInputs(companyId, skillId),
(current) => {
const withoutDuplicate = (current ?? []).filter((item) => item.id !== input.id);
return [...withoutDuplicate, input].sort((a, b) =>
a.name.localeCompare(b.name) || Number(new Date(a.createdAt)) - Number(new Date(b.createdAt)),
);
},
);
queryClient.invalidateQueries({
queryKey: queryKeys.companySkills.testInputs(companyId, skillId),
});
onSaved(input);
},
});
return (
<Dialog open={open} onOpenChange={onOpenChange}>
<DialogContent>
<DialogHeader>
<DialogTitle>Save test input</DialogTitle>
<DialogDescription>
Runs snapshot input at run time — editing later won't change past runs.
</DialogDescription>
</DialogHeader>
<div className="space-y-3">
<div className="space-y-1">
<Label htmlFor="input-name">Name</Label>
<Input
id="input-name"
value={name}
onChange={(e) => setName(e.target.value)}
placeholder="onboarding/happy-path"
/>
<p className="text-xs text-muted-foreground">Use “/” for folders, e.g. onboarding/happy-path</p>
</div>
<div className="space-y-1">
<Label htmlFor="input-content">Content</Label>
<Textarea
id="input-content"
value={content}
onChange={(e) => setContent(e.target.value)}
className="min-h-(--sz-160px)"
/>
</div>
</div>
<DialogFooter>
<Button variant="ghost" onClick={() => onOpenChange(false)}>
Cancel
</Button>
<Button
disabled={!name.trim() || !content.trim() || createMutation.isPending}
onClick={() => createMutation.mutate()}
>
Save
</Button>
</DialogFooter>
</DialogContent>
</Dialog>
);
}
// ---------------------------------------------------------------------------
// Right — agent picker + Run + history + detail
// ---------------------------------------------------------------------------
type RunTemplateDialogState =
| { mode: "create"; source?: CompanySkillTestRunTemplate | null }
| { mode: "edit"; source: CompanySkillTestRunTemplate }
| null;
function RunsPane({
companyId,
skill,
inputs,
selectedInput,
adHocMode,
adHocContent,
selectedRunId,
onSelectRun,
selectedAgentId,
onSelectAgent,
skillDirty,
filterInput,
onClearFilter,
}: {
companyId: string;
skill: CompanySkillDetail;
inputs: CompanySkillTestInput[];
selectedInput: CompanySkillTestInput | null;
adHocMode: boolean;
adHocContent: string;
selectedRunId: string | null;
onSelectRun: (id: string | null) => void;
selectedAgentId: string | null;
onSelectAgent: (id: string | null) => void;
skillDirty: boolean;
filterInput: CompanySkillTestInput | null;
onClearFilter: () => void;
}) {
const skillId = skill.id;
const queryClient = useQueryClient();
const onError = useMutationErrorToast();
const toast = useOptionalToastActions();
const [advancedOpen, setAdvancedOpen] = useState(false);
const [selectedTemplateId, setSelectedTemplateId] = useState<RunTemplateSelection>(
() => loadRunTemplateSelection(companyId),
);
const [templateDialog, setTemplateDialog] = useState<RunTemplateDialogState>(null);
const agentsQuery = useQuery({
queryKey: queryKeys.agents.list(companyId),
queryFn: () => agentsApi.list(companyId),
enabled: Boolean(companyId),
});
const agents = agentsQuery.data ?? [];
const selectedAgent = agents.find((a) => a.id === selectedAgentId) ?? null;
useEffect(() => {
setSelectedTemplateId(loadRunTemplateSelection(companyId));
}, [companyId]);
const updateTemplateSelection = useCallback((selection: RunTemplateSelection) => {
setSelectedTemplateId(selection);
persistRunTemplateSelection(companyId, selection);
}, [companyId]);
const templatesQuery = useQuery({
queryKey: queryKeys.companySkills.testRunTemplates(companyId),
queryFn: () => companySkillsApi.testRunTemplates(companyId),
enabled: Boolean(companyId),
});
const templates = templatesQuery.data ?? EMPTY_RUN_TEMPLATES;
useEffect(() => {
if (!templatesQuery.isSuccess) return;
const resolution = resolveRunTemplateSelection(selectedTemplateId, templates);
if (!resolution.recovered) return;
updateTemplateSelection(resolution.selection);
toast?.pushToast({
tone: "warn",
title: "Run template reset",
body: "The saved run template is no longer available. Default test template is selected.",
dedupeKey: `skill-studio-template-reset:${companyId}`,
});
}, [
companyId,
selectedTemplateId,
templates,
templatesQuery.isSuccess,
toast,
updateTemplateSelection,
]);
const filterInputId = filterInput?.id ?? null;
const runsQuery = useQuery({
queryKey: queryKeys.companySkills.testRuns(companyId, skillId, filterInputId),
queryFn: () =>
companySkillsApi.testRuns(companyId, skillId, filterInputId ? { inputId: filterInputId } : {}),
enabled: Boolean(companyId && skillId),
refetchInterval: (query) => {
const data = query.state.data as CompanySkillTestRun[] | undefined;
return data?.some((r) => shouldPollRun(r.status)) ? POLL_MS : false;
},
});
const runs = runsQuery.data ?? [];
const hasInput = adHocMode ? adHocContent.trim().length > 0 : Boolean(selectedInput?.content.trim());
const gate = evaluateRunGate({
hasAgent: Boolean(selectedAgent),
hasInput,
skillFileCount: skill.fileInventory.length,
hasUnsavedSkillEdits: skillDirty,
});
const templateGateReason = templatesQuery.isLoading
? "Loading run templates"
: templatesQuery.isError
? "Run templates couldn't load"
: null;
const createTemplateMutation = useMutation({
mutationFn: (payload: CompanySkillTestRunTemplateCreateRequest) =>
companySkillsApi.createTestRunTemplate(companyId, payload),
onSuccess: (template) => {
setTemplateDialog(null);
updateTemplateSelection(template.id);
queryClient.invalidateQueries({
queryKey: queryKeys.companySkills.testRunTemplates(companyId),
});
toast?.pushToast({
tone: "success",
title: "Template saved",
body: `${template.name} is ready for Skills Studio runs.`,
});
},
onError: onError("Couldn't save template"),
});
const updateTemplateMutation = useMutation({
mutationFn: ({ templateId, payload }: {
templateId: string;
payload: CompanySkillTestRunTemplateUpdateRequest;
}) => companySkillsApi.updateTestRunTemplate(companyId, templateId, payload),
onSuccess: (template) => {
setTemplateDialog(null);
updateTemplateSelection(template.id);
queryClient.invalidateQueries({
queryKey: queryKeys.companySkills.testRunTemplates(companyId),
});
toast?.pushToast({
tone: "success",
title: "Template updated",
body: `${template.name} is ready for Skills Studio runs.`,
});
},
onError: onError("Couldn't update template"),
});
const deleteTemplateMutation = useMutation({
mutationFn: (templateId: string) => companySkillsApi.deleteTestRunTemplate(companyId, templateId),
onSuccess: (template) => {
const fallback = resolveRunTemplateSelection(selectedTemplateId, templates.filter((entry) => entry.id !== template.id));
if (selectedTemplateId === template.id || fallback.recovered) {
updateTemplateSelection(fallback.selection);
}
queryClient.invalidateQueries({
queryKey: queryKeys.companySkills.testRunTemplates(companyId),
});
toast?.pushToast({
tone: "success",
title: "Template deleted",
body: `${template.name} was removed from Skills Studio runs.`,
});
},
onError: onError("Couldn't delete template"),
});
const selectedTemplate = selectedTemplateId === null
? null
: templates.find((template) => template.id === selectedTemplateId) ?? null;
const selectedTemplateName = selectedTemplateId === null
? "No template"
: selectedTemplate?.name ?? "Default test template";
const runDisabledReason = gate.reason ?? templateGateReason;
const createRunMutation = useMutation({
mutationFn: () => {
if (!templatesQuery.isSuccess) {
throw new Error(templateGateReason ?? "Run templates are not ready.");
}
const resolution = resolveRunTemplateSelection(selectedTemplateId, templates);
if (resolution.recovered) {
updateTemplateSelection(resolution.selection);
throw new Error("Selected run template is no longer available. The selection was reset.");
}
return companySkillsApi.createTestRun(companyId, skillId, buildCreateRunRequest({
agentId: selectedAgentId!,
inputId: adHocMode ? null : selectedInput?.id ?? null,
content: adHocMode ? adHocContent : selectedInput ? null : adHocContent,
templateId: resolution.selection,
}));
},
onSuccess: (run) => {
queryClient.invalidateQueries({
queryKey: queryKeys.companySkills.testRuns(companyId, skillId, filterInputId),
});
onSelectRun(run.id);
},
onError: onError("Couldn't start run"),
});
if (selectedRunId) {
return (
<RunDetailView
companyId={companyId}
skill={skill}
runId={selectedRunId}
agents={agents}
onBack={() => onSelectRun(null)}
onSelectRun={onSelectRun}
/>
);
}
return (
<PaneScaffold
title="Test runs"
action={
<div className="flex items-center gap-2">
<AgentPicker
agents={agents}
selectedAgent={selectedAgent}
onSelect={onSelectAgent}
/>
<Tooltip>
<TooltipTrigger asChild>
{/* span wrapper keeps the tooltip reachable while the button is disabled */}
<span>
<Button
size="sm"
disabled={gate.disabled || Boolean(templateGateReason) || createRunMutation.isPending}
onClick={() => createRunMutation.mutate()}
>
<Play className="mr-1.5 h-3.5 w-3.5" /> Run
</Button>
</span>
</TooltipTrigger>
{runDisabledReason && <TooltipContent side="bottom">{runDisabledReason}</TooltipContent>}
</Tooltip>
</div>
}
>
<div className="flex min-h-0 flex-1 flex-col">
<RunTemplateAdvancedPanel
open={advancedOpen}
onOpenChange={setAdvancedOpen}
templates={templates}
templatesLoading={templatesQuery.isLoading}
templatesError={templatesQuery.isError}
selectedTemplateId={selectedTemplateId}
selectedTemplate={selectedTemplate}
selectedTemplateName={selectedTemplateName}
onSelectTemplate={updateTemplateSelection}
onCreateTemplate={() => setTemplateDialog({ mode: "create" })}
onEditTemplate={(template) => setTemplateDialog({ mode: "edit", source: template })}
onDuplicateTemplate={(template) => setTemplateDialog({ mode: "create", source: template })}
onDeleteTemplate={(template) => {
if (
typeof window !== "undefined"
&& !window.confirm(`Delete run template "${template.name}"?`)
) {
return;
}
deleteTemplateMutation.mutate(template.id);
}}
deletingTemplateId={deleteTemplateMutation.variables ?? null}
actionPending={
createTemplateMutation.isPending
|| updateTemplateMutation.isPending
|| deleteTemplateMutation.isPending
}
/>
{filterInput && (
<div className="px-3 pt-2">
<FilterBar
filters={[{ key: "input", label: "Input", value: filterInput.name }]}
onRemove={onClearFilter}
onClear={onClearFilter}
/>
</div>
)}
<div className="min-h-0 flex-1 overflow-auto p-3">
{runsQuery.isLoading ? (
<div className="text-xs text-muted-foreground">Loading runs…</div>
) : runs.length === 0 ? (
<EmptyState icon={FlaskConical} message="No test runs yet. Pick an agent and Run." />
) : (
<div className="space-y-1 rounded-md border border-border p-1">
{runs.map((run) => (
<RunHistoryRow
key={run.id}
run={run}
agents={agents}
onSelect={() => onSelectRun(run.id)}
/>
))}
</div>
)}
</div>
</div>
<RunTemplateDialog
state={templateDialog}
pending={createTemplateMutation.isPending || updateTemplateMutation.isPending}
onOpenChange={(open) => {
if (!open) setTemplateDialog(null);
}}
onSubmit={(payload) => {
if (templateDialog?.mode === "edit") {
updateTemplateMutation.mutate({ templateId: templateDialog.source.id, payload });
} else {
createTemplateMutation.mutate(payload);
}
}}
/>
</PaneScaffold>
);
}
type RunTemplateOption = SearchableSelectOption<string> & {
description: string | null;
builtIn: boolean;
};
function runTemplateOptionValue(selection: RunTemplateSelection) {
return selection ?? NO_TEST_RUN_TEMPLATE_STORAGE_VALUE;
}
function runTemplateSelectionFromOption(value: string): RunTemplateSelection {
return value === NO_TEST_RUN_TEMPLATE_STORAGE_VALUE ? null : value;
}
function RunTemplateAdvancedPanel({
open,
onOpenChange,
templates,
templatesLoading,
templatesError,
selectedTemplateId,
selectedTemplate,
selectedTemplateName,
onSelectTemplate,
onCreateTemplate,
onEditTemplate,
onDuplicateTemplate,
onDeleteTemplate,
deletingTemplateId,
actionPending,
}: {
open: boolean;
onOpenChange: (open: boolean) => void;
templates: CompanySkillTestRunTemplate[];
templatesLoading: boolean;
templatesError: boolean;
selectedTemplateId: RunTemplateSelection;
selectedTemplate: CompanySkillTestRunTemplate | null;
selectedTemplateName: string;
onSelectTemplate: (selection: RunTemplateSelection) => void;
onCreateTemplate: () => void;
onEditTemplate: (template: CompanySkillTestRunTemplate) => void;
onDuplicateTemplate: (template: CompanySkillTestRunTemplate) => void;
onDeleteTemplate: (template: CompanySkillTestRunTemplate) => void;
deletingTemplateId: string | null;
actionPending: boolean;
}) {
const templateGroups = useMemo<readonly SearchableSelectGroup<string, RunTemplateOption>[]>(() => {
const noTemplateOption: RunTemplateOption = {
key: "no-template",
value: NO_TEST_RUN_TEMPLATE_STORAGE_VALUE,
label: "No template",
title: "No template",
description: "Run only the input text.",
builtIn: true,
searchText: "no template plain input",
};
const toOption = (template: CompanySkillTestRunTemplate): RunTemplateOption => ({
key: template.id,
value: template.id,
label: template.name,
title: template.name,
description: template.description,
builtIn: template.builtIn,
searchText: [template.name, template.description ?? "", template.builtIn ? "built in" : "custom"].join(" "),
});
const builtIn = templates.filter((template) => template.builtIn).map(toOption);
const custom = templates.filter((template) => !template.builtIn).map(toOption);
return [
{ id: "built-in", label: "Built in", options: [noTemplateOption, ...builtIn] },
...(custom.length > 0 ? [{ id: "custom", label: "Custom", options: custom }] : []),
];
}, [templates]);
const selectedValue = runTemplateOptionValue(selectedTemplateId);
const selectedMissing = selectedTemplateId !== null && !selectedTemplate && !templatesLoading;
const canEdit = Boolean(selectedTemplate && !selectedTemplate.builtIn);
const canDuplicate = Boolean(selectedTemplate);
const canDelete = Boolean(selectedTemplate && !selectedTemplate.builtIn);
return (
<div className="border-b border-border">
<button
type="button"
className="flex min-h-(--sz-32px) w-full items-center gap-2 px-3 py-2 text-left text-xs text-muted-foreground hover:bg-accent hover:text-foreground"
onClick={() => onOpenChange(!open)}
>
{open ? (
<ChevronDown className="h-3.5 w-3.5" />
) : (
<ChevronRight className="h-3.5 w-3.5" />
)}
<span className="font-semibold uppercase tracking-wide">Advanced</span>
<span className="ml-auto truncate">{selectedTemplateName}</span>
</button>
{open ? (
<div className="space-y-3 px-3 pb-3 pt-1">
<div className="flex items-end gap-2">
<div className="min-w-0 flex-1 space-y-1">
<Label>Run template</Label>
<SearchableSelect<string, RunTemplateOption>
value={selectedValue}
groups={templateGroups}
loading={templatesLoading}
disabled={templatesLoading || templatesError}
loadingMessage="Loading templates..."
placeholder="Select template"
searchPlaceholder="Search templates..."
emptyMessage="No templates."
contentClassName="w-(--sz-320px)"
onValueChange={(value) => onSelectTemplate(runTemplateSelectionFromOption(value))}
renderValue={(option) => option?.label ?? selectedTemplateName}
renderOption={(option, { selected }) => (
<span className="flex min-w-0 flex-col">
<span className={cn("truncate", selected && "font-medium")}>{option.label}</span>
<span className="truncate text-(length:--text-micro) text-muted-foreground">
{option.description ?? (option.builtIn ? "Built in" : "Custom")}
</span>
</span>
)}
/>
</div>
<Tooltip>
<TooltipTrigger asChild>
<Button
type="button"
variant="outline"
size="icon-sm"
aria-label="Create run template"
disabled={actionPending}
onClick={onCreateTemplate}
>
<Plus />
</Button>
</TooltipTrigger>
<TooltipContent>Create run template</TooltipContent>
</Tooltip>
<Tooltip>
<TooltipTrigger asChild>
<span>
<Button
type="button"
variant="ghost"
size="icon-sm"
aria-label="Edit run template"
disabled={!canEdit || actionPending}
onClick={() => selectedTemplate && onEditTemplate(selectedTemplate)}
>
<Pencil />
</Button>
</span>
</TooltipTrigger>
<TooltipContent>Edit custom template</TooltipContent>
</Tooltip>
<Tooltip>
<TooltipTrigger asChild>
<span>
<Button
type="button"
variant="ghost"
size="icon-sm"
aria-label="Duplicate run template"
disabled={!canDuplicate || actionPending}
onClick={() => selectedTemplate && onDuplicateTemplate(selectedTemplate)}
>
<Copy />
</Button>
</span>
</TooltipTrigger>
<TooltipContent>
{selectedTemplate?.builtIn ? "Duplicate built-in template" : "Duplicate template"}
</TooltipContent>
</Tooltip>
<Tooltip>
<TooltipTrigger asChild>
<span>
<Button
type="button"
variant="ghost"
size="icon-sm"
aria-label="Delete run template"
className="text-destructive hover:text-destructive"
disabled={!canDelete || actionPending || deletingTemplateId === selectedTemplate?.id}
onClick={() => selectedTemplate && onDeleteTemplate(selectedTemplate)}
>
<Trash2 />
</Button>
</span>
</TooltipTrigger>
<TooltipContent>Delete custom template</TooltipContent>
</Tooltip>
</div>
{templatesError ? (
<p className="text-xs text-destructive">Run templates could not load.</p>
) : selectedTemplateId === null ? (
<p className="text-xs text-muted-foreground">Runs will use only the input text.</p>
) : selectedMissing ? (
<p className="text-xs text-destructive">Selected template is no longer available.</p>
) : selectedTemplate ? (
<div className="space-y-2">
{selectedTemplate.description ? (
<p className="text-xs text-muted-foreground">{selectedTemplate.description}</p>
) : null}
<pre className="max-h-(--sz-240px) overflow-auto whitespace-pre-wrap rounded-md border border-border bg-muted/30 p-3 text-xs leading-5 text-muted-foreground">
{selectedTemplate.body}
</pre>
</div>
) : (
<p className="text-xs text-muted-foreground">Loading template...</p>
)}
</div>
) : null}
</div>
);
}
function RunTemplateDialog({
state,
pending,
onOpenChange,
onSubmit,
}: {
state: RunTemplateDialogState;
pending: boolean;
onOpenChange: (open: boolean) => void;
onSubmit: (payload: CompanySkillTestRunTemplateCreateRequest) => void;
}) {
const source = state?.source ?? null;
const [name, setName] = useState("");
const [description, setDescription] = useState("");
const [body, setBody] = useState("");
useEffect(() => {
if (!state) return;
setName(state.mode === "edit" ? source?.name ?? "" : source ? `${source.name} copy` : "");
setDescription(source?.description ?? "");
setBody(source?.body ?? "");
}, [source, state]);
const title = state?.mode === "edit"
? "Edit run template"
: source?.builtIn
? "Duplicate built-in template"
: "Create run template";
const descriptionText = state?.mode === "edit"
? "Update the custom run instructions used by Skills Studio."
: "Save reusable run instructions for Skills Studio.";
return (
<Dialog open={Boolean(state)} onOpenChange={onOpenChange}>
<DialogContent>
<DialogHeader>
<DialogTitle>{title}</DialogTitle>
<DialogDescription>{descriptionText}</DialogDescription>
</DialogHeader>
<div className="space-y-3">
<div className="space-y-1">
<Label htmlFor="run-template-name">Name</Label>
<Input
id="run-template-name"
value={name}
onChange={(event) => setName(event.target.value)}
placeholder="Focused smoke"
/>
</div>
<div className="space-y-1">
<Label htmlFor="run-template-description">Description</Label>
<Input
id="run-template-description"
value={description}
onChange={(event) => setDescription(event.target.value)}
placeholder="Short instructions for common skill checks"
/>
</div>
<div className="space-y-1">
<Label htmlFor="run-template-body">Body</Label>
<Textarea
id="run-template-body"
value={body}
onChange={(event) => setBody(event.target.value)}
className="min-h-(--sz-240px) font-mono text-xs leading-5"
/>
<p className="text-xs text-muted-foreground">
Placeholders: {"{{skillName}}"}, {"{{skillKey}}"}, {"{{skillInvocation}}"}, {"{{skillVersion}}"}, {"{{runId}}"}, {"{{issueId}}"}, {"{{outputDocumentKey}}"}.
</p>
</div>
</div>
<DialogFooter>
<Button variant="ghost" onClick={() => onOpenChange(false)}>
Cancel
</Button>
<Button
disabled={!name.trim() || !body.trim() || pending}
onClick={() =>
onSubmit({
name: name.trim(),
description: description.trim() || null,
body,
})
}
>
{pending ? "Saving..." : "Save template"}
</Button>
</DialogFooter>
</DialogContent>
</Dialog>
);
}
function RunHistoryRow({
run,
agents,
onSelect,
}: {
run: CompanySkillTestRun;
agents: Agent[];
onSelect: () => void;
}) {
const agent = agents.find((a) => a.id === run.agentId) ?? null;
const removed = !agent;
const snapshotName =
(run.agentConfigSnapshot?.name as string | undefined) ?? "Agent";
const name = agent?.name ?? snapshotName;
return (
<EntityRow
leading={<StatusBadge status={runBadgeStatus(run.status)} />}
identifier={runShortId(run)}
title={removed ? `${name} (removed)` : name}
subtitle={relativeTime(run.createdAt)}
trailing={
<span className="font-mono text-xs text-muted-foreground">
{formatCents(run.cost.costCents)}
</span>
}
onClick={onSelect}
/>
);
}
function AgentPicker({
agents,
selectedAgent,
onSelect,
}: {
agents: Agent[];
selectedAgent: Agent | null;
onSelect: (id: string) => void;
}) {
const [open, setOpen] = useState(false);
return (
<Popover open={open} onOpenChange={setOpen}>
<PopoverTrigger asChild>
<Button variant="outline" size="sm">
{selectedAgent ? (
<AgentIdentity agent={selectedAgent} size="xs" />
) : (
<span className="text-muted-foreground">Pick an agent</span>
)}
</Button>
</PopoverTrigger>
<PopoverContent align="end" className="w-64 p-0">
<Command>
<CommandInput placeholder="Search agents…" />
<CommandList>
<CommandEmpty>No agents.</CommandEmpty>
<CommandGroup>
{agents.map((agent) => {
const selectable = isAgentSelectable(agent);
return (
<CommandItem
key={agent.id}
value={agent.name}
disabled={!selectable}
onSelect={() => {
if (!selectable) return;
onSelect(agent.id);
setOpen(false);
}}
className={cn("flex items-center gap-2", !selectable && "opacity-50")}
>
<span
className={cn(
"h-2 w-2 rounded-full",
selectable ? "bg-green-500" : "bg-orange-400",
)}
aria-hidden
/>
<AgentIdentity agent={agent} size="xs" />
{!selectable && (
<Badge variant="secondary" className="ml-auto">
Paused
</Badge>
)}
</CommandItem>
);
})}
</CommandGroup>
</CommandList>
</Command>
</PopoverContent>
</Popover>
);
}
// ---------------------------------------------------------------------------
// Run detail
// ---------------------------------------------------------------------------
function RunDetailView({
companyId,
skill,
runId,
agents,
onBack,
onSelectRun,
}: {
companyId: string;
skill: CompanySkillDetail;
runId: string;
agents: Agent[];
onBack: () => void;
onSelectRun: (id: string | null) => void;
}) {
const skillId = skill.id;
const queryClient = useQueryClient();
const onError = useMutationErrorToast();
const detailQuery = useQuery({
queryKey: queryKeys.companySkills.testRunDetail(companyId, skillId, runId),
queryFn: () => companySkillsApi.testRunDetail(companyId, skillId, runId),
enabled: Boolean(companyId && skillId && runId),
refetchInterval: (query) => {
const data = query.state.data as CompanySkillTestRunDetail | undefined;
return data && shouldPollRun(data.status) ? POLL_MS : false;
},
});
const cancelMutation = useMutation({
mutationFn: () => companySkillsApi.cancelTestRun(companyId, skillId, runId),
onSuccess: () =>
queryClient.invalidateQueries({
queryKey: queryKeys.companySkills.testRunDetail(companyId, skillId, runId),
}),
onError: onError("Couldn't cancel run"),
});
// Re-run reproduces the VIEWED run's snapshots — pinned skill version, saved
// input (or the ad-hoc snapshot), and agent — rather than whatever the picker
// happens to hold this session (PAP-13001 Bug A). Reading detailQuery.data at
// mutate() time keeps the hook order stable across the loading guards below.
const reRunMutation = useMutation({
mutationFn: () => {
const d = detailQuery.data;
if (!d) throw new Error("Run details are still loading.");
return companySkillsApi.createTestRun(companyId, skillId, buildReRunRequest(d));
},
onSuccess: (run) => {
queryClient.invalidateQueries({
queryKey: ["company-skills", companyId, skillId, "test-runs"],
});
onSelectRun(run.id);
},
onError: onError("Couldn't re-run"),
});
const deleteMutation = useMutation({
mutationFn: () => companySkillsApi.deleteTestRun(companyId, skillId, runId),
onSuccess: () => {
queryClient.invalidateQueries({
queryKey: ["company-skills", companyId, skillId, "test-runs"],
});
onSelectRun(null);
},
onError: onError("Couldn't delete run"),
});
const detail = detailQuery.data ?? null;
const additionalDocuments = useMemo(() => detail ? getRunAdditionalDocuments(detail) : [], [detail]);
const rawAttachments = useMemo(() => detail ? getRunRawAttachments(detail) : [], [detail]);
const unavailableCopy = useMemo(() => detail ? runHarnessUnavailableCopy(detail) : null, [detail]);
const mediaGalleryItems = useMemo<GalleryMediaItem[]>(
() => detail ? getRunMediaGalleryItems(detail) : [],
[detail],
);
const [galleryOpen, setGalleryOpen] = useState(false);
const [galleryIndex, setGalleryIndex] = useState(0);
if (detailQuery.isLoading) {
return (
<PaneScaffold title="Run" action={<BackButton onBack={onBack} />}>
<div className="p-3 text-xs text-muted-foreground">Loading run…</div>
</PaneScaffold>
);
}
if (!detail) {
return (
<PaneScaffold title="Run" action={<BackButton onBack={onBack} />}>
<div className="p-3 text-xs text-muted-foreground">Run not found.</div>
</PaneScaffold>
);
}
const agent = agents.find((a) => a.id === detail.agentId) ?? null;
const agentName =
agent?.name ?? (detail.agentConfigSnapshot?.name as string | undefined) ?? "Agent";
const removed = !agent;
const outputMode = runOutputMode(detail);
const nonTerminal = !isTerminalRunStatus(detail.status);
const taskLink = testTaskLinkState(detail);
return (
<PaneScaffold title="Run" action={<BackButton onBack={onBack} />}>
<div className="min-h-0 flex-1 space-y-3 overflow-auto p-3">
<div className="flex flex-wrap items-center gap-2">
<StatusBadge status={runBadgeStatus(detail.status)} />
<AgentIdentity agent={agent ?? { id: detail.agentId, name: agentName }} size="xs" />
{removed && <Badge variant="secondary">removed</Badge>}
<span className="font-mono text-xs text-muted-foreground">
v{detail.skillVersion.revisionNumber}
</span>
<span className="ml-auto font-mono text-xs text-muted-foreground">
{formatCents(detail.cost.costCents)}
</span>
</div>
{/* snapshot property block */}
<div className="rounded-md border border-border text-xs">
<PropRow label="Input" value={detail.inputId ? "saved input" : "ad-hoc paste"} />
<PropRow label="Template" value={detail.templateName ?? "No template"} />
<PropRow label="Skill version" value={`v${detail.skillVersion.revisionNumber}`} />
<PropRow label="Created" value={relativeTime(detail.createdAt)} />
</div>
{showRunErrorCard(detail.status) && (
<Card className="border-destructive/50">
<CardHeader className="flex-row items-center gap-2 space-y-0 pb-2">
<AlertTriangle className="h-3.5 w-3.5 text-destructive" />
<span className="text-sm font-medium">Run failed</span>
</CardHeader>
<CardContent className="text-sm text-muted-foreground">
{detail.error ?? "The test task ended with an error."}
</CardContent>
</Card>
)}
{/* Output snapshot / draft-at-failure */}
{outputMode === "output" || outputMode === "draft" ? (
<section className="space-y-2">
<h3 className="mb-1 text-xs font-semibold uppercase tracking-wide text-muted-foreground">
{outputMode === "draft" ? "Draft at failure" : "Output snapshot"}
</h3>
<div className="rounded-md border border-border p-3">
<MarkdownBody>{detail.outputBody || "_No output_"}</MarkdownBody>
</div>
</section>
) : outputMode === "pending" ? (
<div className="flex items-center gap-2 text-xs text-muted-foreground">
<Clock className="h-3.5 w-3.5" /> Working… output will appear here.
</div>
) : null}
{unavailableCopy ? (
<RunHarnessUnavailableNotice copy={unavailableCopy} />
) : null}
{additionalDocuments.length > 0 ? (
<RunDocumentsSection documents={additionalDocuments} />
) : null}
<IssueOutputSection
workProducts={detail.harnessContent.workProducts}
onMediaClick={(item) => {
const meta = item.metadata;
if (!meta) return;
const idx = mediaGalleryItems.findIndex((galleryItem) => (
galleryItem.contentPath === meta.contentPath ||
galleryItem.id === `work-product-${item.id}` ||
galleryItem.id === meta.attachmentId
));
setGalleryIndex(idx >= 0 ? idx : 0);
setGalleryOpen(true);
}}
/>
{rawAttachments.length > 0 ? (
<IssueAttachmentsSection
attachments={rawAttachments}
onImageClick={(attachment) => {
const idx = mediaGalleryItems.findIndex((item) => (
item.id === attachment.id || item.contentPath === attachment.contentPath
));
setGalleryIndex(idx >= 0 ? idx : 0);
setGalleryOpen(true);
}}
/>
) : null}
{/* Interactions */}
<InteractionSection
companyId={companyId}
detail={detail}
agents={agents}
onAnswered={() =>
queryClient.invalidateQueries({
queryKey: queryKeys.companySkills.testRunDetail(companyId, skillId, runId),
})
}
/>
{/* Actions */}
<div className="flex flex-wrap items-center gap-2 border-t border-border pt-3">
<Button
variant="outline"
size="sm"
disabled={reRunMutation.isPending}
onClick={() => reRunMutation.mutate()}
>
<RotateCcw className="mr-1.5 h-3.5 w-3.5" /> Re-run
</Button>
{nonTerminal ? (
<Button
variant="ghost"
size="sm"
disabled={cancelMutation.isPending}
onClick={() => cancelMutation.mutate()}
>
Cancel
</Button>
) : (
<Button
variant="ghost"
size="sm"
className="text-destructive hover:text-destructive"
disabled={deleteMutation.isPending}
onClick={() => deleteMutation.mutate()}
>
<Trash2 className="mr-1.5 h-3.5 w-3.5" /> Delete
</Button>
)}
{taskLink.enabled && detail.harnessIssue ? (
<Button variant="link" size="sm" asChild>
<Link to={`/issues/${detail.harnessIssue.id}`}>Open test task ↗</Link>
</Button>
) : (
<Tooltip>
<TooltipTrigger asChild>
<span className="cursor-not-allowed text-xs text-muted-foreground">
Open test task ↗
</span>
</TooltipTrigger>
<TooltipContent>{taskLink.reason}</TooltipContent>
</Tooltip>
)}
</div>
<ImageGalleryModal
items={mediaGalleryItems}
initialIndex={galleryIndex}
open={galleryOpen}
onOpenChange={setGalleryOpen}
/>
</div>
</PaneScaffold>
);
}
function RunHarnessUnavailableNotice({
copy,
}: {
copy: NonNullable<ReturnType<typeof runHarnessUnavailableCopy>>;
}) {
return (
<div className="flex items-start gap-2 rounded-md border border-border bg-muted/30 p-3 text-xs">
<AlertTriangle className="mt-0.5 h-3.5 w-3.5 shrink-0 text-muted-foreground" />
<div className="min-w-0 space-y-1">
<p className="font-medium text-foreground">{copy.title}</p>
<p className="text-muted-foreground">{copy.body}</p>
</div>
</div>
);
}
function RunDocumentsSection({ documents }: { documents: IssueDocument[] }) {
return (
<section className="space-y-2">
<div className="flex items-center gap-2">
<FileText className="h-3.5 w-3.5 text-muted-foreground" aria-hidden="true" />
<h3 className="text-sm font-medium text-muted-foreground">Documents</h3>
<span className="text-xs text-muted-foreground">{documents.length}</span>
</div>
<div className="space-y-2">
{documents.map((document) => (
<article key={document.id} className="rounded-md border border-border p-3">
<div className="mb-2 flex min-w-0 items-center gap-2 text-xs text-muted-foreground">
<span className="truncate font-medium text-foreground">
{document.title ?? document.key}
</span>
<span className="ml-auto shrink-0">{relativeTime(document.updatedAt)}</span>
</div>
<MarkdownBody className="paperclip-edit-in-place-content text-sm leading-7" softBreaks={false}>
{document.body}
</MarkdownBody>
</article>
))}
</div>
</section>
);
}
function InteractionSection({
companyId,
detail,
agents,
onAnswered,
}: {
companyId: string;
detail: CompanySkillTestRunDetail;
agents: Agent[];
onAnswered: () => void;
}) {
const harnessIssueId = detail.harnessIssue?.id ?? null;
const hasInlineAnswerable = detail.interactions.some((i) => isInteractionAnswerable(i));
// Only fetch the full interaction objects (needed to render answerable cards)
// when there is at least one pending inline interaction on a live harness issue.
const fullQuery = useQuery({
queryKey: ["skill-studio", "interactions", harnessIssueId],
queryFn: () => issuesApi.listInteractions(harnessIssueId!),
enabled: Boolean(harnessIssueId && hasInlineAnswerable),
refetchInterval: (query) => interactionReadinessRefetchInterval(query.state.data, hasInlineAnswerable ? POLL_MS : false),
});
const fullById = useMemo(
() => new Map((fullQuery.data ?? []).map((i) => [i.id, i])),
[fullQuery.data],
);
const agentMap = useMemo(() => new Map(agents.map((a) => [a.id, a])), [agents]);
const accept = useMutation({
mutationFn: (vars: { interaction: IssueThreadInteraction; optionIds?: string[] }) =>
issuesApi.acceptInteraction(harnessIssueId!, vars.interaction.id, {
selectedOptionIds: vars.optionIds,
}),
onSuccess: onAnswered,
});
const respond = useMutation({
mutationFn: (vars: { interaction: AskUserQuestionsInteraction; answers: AskUserQuestionsAnswer[] }) =>
issuesApi.respondToInteraction(harnessIssueId!, vars.interaction.id, { answers: vars.answers }),
onSuccess: onAnswered,
});
const reject = useMutation({
mutationFn: (vars: { interaction: IssueThreadInteraction; reason?: string }) =>
issuesApi.rejectInteraction(harnessIssueId!, vars.interaction.id, vars.reason),
onSuccess: onAnswered,
});
if (detail.interactions.length === 0) return null;
return (
<section>
<h3 className="mb-1 text-xs font-semibold uppercase tracking-wide text-muted-foreground">
Interactions
</h3>
<div className="space-y-2">
{detail.interactions.map((summary) => {
const inline = routeInteraction(summary.kind) === "inline";
const full = fullById.get(summary.id);
if (inline && full) {
return (
<IssueThreadInteractionCard
key={summary.id}
interaction={full}
agentMap={agentMap}
onAcceptInteraction={async (interaction, _keys, optionIds) => {
await accept.mutateAsync({ interaction, optionIds });
}}
onRejectInteraction={async (interaction, reason) => {
await reject.mutateAsync({ interaction, reason });
}}
onSubmitInteractionAnswers={async (interaction, answers) => {
await respond.mutateAsync({ interaction, answers });
}}
/>
);
}
// Fallback: summary row + open-test-task link (never dropped).
return (
<EntityRow
key={summary.id}
title={summary.title}
subtitle={`${summary.kind} · ${summary.status}`}
trailing={
harnessIssueId ? (
<Button variant="link" size="xs" asChild>
<Link to={`/issues/${harnessIssueId}`}>Open test task ↗</Link>
</Button>
) : null
}
/>
);
})}
</div>
</section>
);
}
// ---------------------------------------------------------------------------
// Version history drawer
// ---------------------------------------------------------------------------
function VersionHistorySheet({
open,
onOpenChange,
companyId,
skill,
onRestored,
onFilterRuns,
}: {
open: boolean;
onOpenChange: (open: boolean) => void;
companyId: string;
skill: CompanySkillDetail;
onRestored: () => void;
onFilterRuns: (inputId: string) => void;
}) {
const skillId = skill.id;
const queryClient = useQueryClient();
const versionsQuery = useQuery({
queryKey: queryKeys.companySkills.versions(companyId, skillId),
queryFn: () => companySkillsApi.versions(companyId, skillId),
enabled: open && Boolean(companyId && skillId),
});
const versions = versionsQuery.data ?? [];
const [leftId, setLeftId] = useState<string | null>(null);
const [rightId, setRightId] = useState<string | null>(null);
const restore = useMutation({
mutationFn: async (version: CompanySkillVersion) => {
// Restore = write each file from the chosen version back, then cut a new
// head version (immutability: never rewrites history).
for (const file of version.fileInventory) {
await companySkillsApi.updateFile(companyId, skillId, file.path, file.content, { encoding: file.encoding, executable: file.executable ?? false });
}
return companySkillsApi.createVersion(companyId, skillId, {
label: `Restore of v${version.revisionNumber}`,
});
},
onSuccess: () => {
queryClient.invalidateQueries({ queryKey: queryKeys.companySkills.versions(companyId, skillId) });
onRestored();
},
});
const left = versions.find((v) => v.id === leftId) ?? null;
const right = versions.find((v) => v.id === rightId) ?? null;
const diff = left && right ? buildLineDiff(
left.fileInventory.map((f) => `# ${f.path}${f.executable ? " (executable)" : ""}\n${f.encoding === "base64" ? "[Binary asset]" : f.content}`).join("\n\n"),
right.fileInventory.map((f) => `# ${f.path}${f.executable ? " (executable)" : ""}\n${f.encoding === "base64" ? "[Binary asset]" : f.content}`).join("\n\n"),
) : null;
return (
<Sheet open={open} onOpenChange={onOpenChange}>
<SheetContent side="left" className="w-full sm:max-w-(--sz-560px)">
<SheetHeader>
<SheetTitle>Version history</SheetTitle>
</SheetHeader>
<div className="mt-3 space-y-2 overflow-auto">
{versionsQuery.isLoading ? (
<div className="text-xs text-muted-foreground">Loading versions…</div>
) : versions.length === 0 ? (
<EmptyState icon={History} message="No versions yet. Save changes to create the first." />
) : (
<div className="space-y-1 rounded-md border border-border p-1">
{versions.map((v) => (
<EntityRow
key={v.id}
identifier={`v${v.revisionNumber}`}
title={v.label ?? `Version ${v.revisionNumber}`}
subtitle={relativeTime(v.createdAt)}
selected={v.id === leftId || v.id === rightId}
onClick={() => {
// click to build a two-version diff selection
if (!leftId) setLeftId(v.id);
else if (!rightId && v.id !== leftId) setRightId(v.id);
else {
setLeftId(v.id);
setRightId(null);
}
}}
trailing={
<Button
variant="outline"
size="xs"
disabled={restore.isPending || skill.editable === false}
onClick={(e) => {
e.stopPropagation();
restore.mutate(v);
}}
>
Restore as v{(skill.currentVersion?.revisionNumber ?? v.revisionNumber) + 1}
</Button>
}
/>
))}
</div>
)}
{diff && (
<div className="rounded-md border border-border">
<div className="border-b border-border px-3 py-1.5 text-xs text-muted-foreground">
Diff v{left?.revisionNumber} → v{right?.revisionNumber}
</div>
<pre className="max-h-64 overflow-auto p-2 text-xs">
{diff.map((row, i) => (
<div
key={i}
className={cn(
"whitespace-pre-wrap",
row.kind === "added" && "bg-green-500/10 text-green-700 dark:text-green-300",
row.kind === "removed" && "bg-red-500/10 text-red-700 dark:text-red-300",
)}
>
{row.kind === "added" ? "+" : row.kind === "removed" ? "-" : " "}
{row.text}
</div>
))}
</pre>
</div>
)}
</div>
</SheetContent>
</Sheet>
);
}
// ---------------------------------------------------------------------------
// Shared bits
// ---------------------------------------------------------------------------
function PaneScaffold({
title,
action,
children,
}: {
title: React.ReactNode;
action?: React.ReactNode;
children: React.ReactNode;
}) {
return (
<div className="flex h-full min-h-0 flex-col">
<div className="flex items-center justify-between gap-2 border-b border-border px-3 py-2">
<span className="text-xs font-semibold uppercase tracking-wide text-muted-foreground">
{title}
</span>
{action}
</div>
<div className="flex min-h-0 flex-1 flex-col">{children}</div>
</div>
);
}
function PropRow({ label, value }: { label: string; value: string }) {
return (
<div className="flex items-center justify-between gap-2 border-b border-border px-3 py-1.5 last:border-b-0">
<span className="text-muted-foreground">{label}</span>
<span className="truncate">{value}</span>
</div>
);
}
function BackButton({ onBack }: { onBack: () => void }) {
return (
<Button variant="ghost" size="sm" onClick={onBack}>
<ArrowLeft className="mr-1.5 h-3.5 w-3.5" /> Back
</Button>
);
}
function MobileTabs({
skill,
input,
runs,
}: {
skill: React.ReactNode;
input: React.ReactNode;
runs: React.ReactNode;
}) {
return (
<Tabs defaultValue="skill" className="flex flex-1 flex-col">
<TabsList variant="line" className="px-3">
<TabsTrigger value="skill">Skill</TabsTrigger>
<TabsTrigger value="input">Input</TabsTrigger>
<TabsTrigger value="runs">Runs</TabsTrigger>
</TabsList>
<TabsContent value="skill" className="min-h-0 flex-1">
{skill}
</TabsContent>
<TabsContent value="input" className="min-h-0 flex-1">
{input}
</TabsContent>
<TabsContent value="runs" className="min-h-0 flex-1">
{runs}
</TabsContent>
</Tabs>
);
}