Files
PaperClipAI/server/src/services/native-runtime/native-safe-replacement.test.ts
T
DottaandPaperclip 992f720262 fix: make runner task context ownership explicit (#13753)
<!-- Write all pull request text in Simplified Technical English
(ASD-STE100). -->

## Thinking Path

> - Paperclip is the open source app people use to manage AI agents for
work.
> - Task descriptions, comments, continuation data, skills, and
execution rules enter several agent adapters.
> - The same source can be rendered by more than one automatic input
carrier.
> - Failed resumes can also rebuild input from stale or compact context.
> - This pull request gives each Paperclip-owned source one delivery
owner and preserves the required transport boundaries.
> - It adds deterministic adapter, interaction, runner, and browser
tests for these boundaries.
> - The benefit is more predictable context delivery with explicit
evidence for later live qualification.

## Linked Issues or Issue Description

Related: #13144 removes a duplicate environment payload and bounds wake
lists. Related: #11360 addresses Hermes resume behavior. This pull
request preserves compatible active-session formats while repairing
context ownership and stale question creation.

**What happened?**

Task descriptions and comments could enter more than one automatic
context block. Native transports could wrap a complete model input in a
second task envelope. Some legacy and gateway adapters could omit the
owned assignment on ordinary tasks or rebuild a failed resume with stale
compact context. A continuation could also request a question after
newer human comments had arrived.

**Expected behavior**

Each task or comment source has one automatic model-facing owner.
Distinct comment IDs and repeated wording remain distinct. Fresh
fallback attempts rebuild the required full context. A question request
is rejected when newer queued human direction makes it stale. Harness
access policy remains owned by execution configuration.

**Steps to reproduce**

1. Build a task with a description and current comments.
2. Capture the actual adapter or runner input.
3. Compare source ownership and task-envelope nesting.
4. Queue a human comment before a continuation requests a question.
5. Trigger a failed resume and inspect the fresh retry input.
6. Run the focused adapter, interaction, runner, and browser checks.

## What Changed

- Add shared prompt-section selection at the provider-attempt boundary.
- Deliver owned assignment context through native, legacy CLI, ACP,
gateway, cloud, Pi, Kimi, Grok, Gemini, OpenCode, Cursor, OpenClaw, and
Hermes paths.
- Rebuild full or compact context after resume recovery changes the
attempt. Add native and Claude ACP tests of actual recovery requests.
- Preserve custom templates, loaded instruction files, execution
policies, and older active-session formats.
- Record continuation source metadata and reject stale question creation
under the issue-row lock.
- Add explicit Product E2E context-integrity profiles, prerequisite
gates, credential-isolation checks, and report fixtures.
- Bypass service-worker forwarding for same-origin Vite development
modules. A real Chromium test fails with resource exhaustion before the
repair and passes after it. Production asset caching keeps its existing
policy.
- Add browser diagnostics and service-worker module-loading regressions.
- Add an explicit zero-retry eval option. The default retry behavior
remains unchanged. Each campaign records its effective policy.
- Remove the model-facing working-directory sentence from four prompt
builders. Existing workspace, sandbox, permission, and custom-template
configuration remains unchanged.
- Align the everyday workflow assertion with the current 47-entry
catalog.

Compared with current upstream master, the branch carries the
context-ownership implementation and its tests, the explicit
context-integrity catalog and evidence harness, and the focused browser
regression checks.

## Verification

**Merge assessment:** focused regression evidence supports merge. This
is not full completion of the original broad qualification matrix. The
maintainer has authorized merge after fresh verification of the master
integration.

- Current head: `bbd52f82114eabf09bc7b1a7e97d54a5b43bbc00`. This
integrates current master `2f585ef26a1814fa209715242d1ca791b63e4c4e`.
All 14 conflicts are resolved. Cancellation checks, workspace
finalization, native Grok support, and both sets of tests are retained.
- Current-head Greptile: **5/5**, with no blocking findings. The review
names this exact commit. All **59 reported checks are terminal: 55
successful, 4 skipped, zero pending or failing**. This includes the full
root general and serialized suites, separate runner checks, typecheck,
build, canary, browser E2E, Docker, and security checks. The successful
legacy security status is included in that total.
- After integration: workspace typecheck and full build passed. Separate
runner checks passed: **2,160 TypeScript tests (10 skipped), 582 Rust
tests, and 39 preparation checks**. Other passing checks include 621
Product E2E harness units, 376 focused shared/adapter tests, 160
real-database/API tests, 86 Hermes tests, 18 browser-support checks, and
Product E2E typechecking. The complete root suite passed in CI. The
duplicate local monolithic root run was stopped after that CI result; it
is not counted as a completed local pass.
- New native recovery coverage retains full assignment, completion
contract, and explicit skill selection after safe replacement, for old
and prepared input formats. Full native session test file: **136/136
passed**.
- New Claude ACP coverage captures actual fresh, resumed, and
missing-session fallback requests. It verifies one assignment copy,
comment order, identical text under distinct comment IDs, and full
fallback context. Full file: **33/33 passed**. Both affected TypeScript
checks passed.
- Existing deterministic tests cover source revisions, approval and
trust boundaries, completion validation, custom templates, compatible
sessions, standalone driver wrapping, and maintained adapter transport
requests.
- Provider-free browser support: **17/17 passed** after the master
merge. Service-worker unit tests: **33/33 passed**. The module-overload
regression failed before the repair and passed after it in real
Chromium.

### Fresh live comparisons

The new batch ran exactly four Product E2E attempts. **All four passed
on the first attempt; no retries.** Each has six terminal matchers plus
the existing browser lifecycle and invariant checks.

| Exact case ID | Control | Candidate |
|---|---|---|
| `core-compatibility.runner-codex.local.plan-revise-accept` | Passed |
Passed |
|
`local-session-integrity.runner-acpx-claude.local.structured-question-restart-resume`
| Passed | Passed |

The plan case checks a revised canonical plan and revision-bound
approval before completion. The question case restarts the server before
submitting the answer, then verifies the continuation completes.

Control source is `dfa4e1bda8d50a1a01746603251a9128dbe9d0d6`. Candidate
source is `79fcdb5dece501d28064ea9da306603881b46f0c`. They use identical
frozen definitions and provider versions: Codex `0.156.0` with
`gpt-5.6-sol`; ACPX `0.13.1` / Claude ACP `0.73.0` with
`claude-sonnet-5`. The September 24 head added master browser recovery
and test-only changes. The September 28 head also integrates newer
master changes, including cancellation, workspace finalization, and
native Grok. These are frozen-source live results, not exact-head live
runs.

The candidate received one description copy where the control initially
received three. The submitted initial plan envelopes were 7,969 versus
19,097 characters. Question envelopes were 7,592 versus 18,919. These
are structural measurements, not whole-provider token or dollar savings.

### Earlier evidence and failed attempts

- The preceding fresh batch has four effective passing pairs: OpenCode
comment continuation and assigned skill, native Codex comment
continuation, and native Claude comment continuation. It retains **11
attempts: eight passed and three failed**.
- Original failures remain recorded: missing local PostgreSQL library
links before task creation; host-sleep cleanup after task/page checks
passed; and a Claude **control** session-open rejection before a model
turn. Setup was repaired identically on both worktrees. The permitted
unchanged infrastructure retries passed. The underlying Claude provider
startup error was not retained and remains unknown.
- Older R2 retains **17 passes and one failure** across 18 attempts,
including eight both-pass native/legacy Codex/Claude pairs. Its OpenCode
blank-page failure led to the service-worker repair. R2 is historical
evidence: master changed the native fixed prompt and removed duplicate
wake environment data afterward.
- The September 24 CI run initially failed one unrelated preview
readiness test (`ECONNREFUSED` on its local fixture). Its test and
production code match master. Isolated local verification passed **28
tests, 3 skipped**. One unchanged CI retry passed the full shard: **831
passed, 1 skipped**, including all **31 preview-exposure tests**. The
aggregate CI gate passed afterward. The precise startup cause remains
unknown; a port race is a hypothesis, not a proved cause.

### Limits

The original wider profile/workflow matrix, repeated trials, and remote
Daytona qualification are incomplete. These results support a focused
merge recommendation, not statistical equivalence or universal harness
qualification. Some usage receipts are missing in both variants, so no
token or dollar savings are claimed. The $500 ceiling was preserved
using conservative allowances; failed attempts and unknown charges
remain in the ledger.

Reproduce the focused additions with `pnpm exec vitest run
packages/adapters/claude-local/src/server/acp.test.ts` and `pnpm
--filter @paperclipai/paperclip-runner exec vitest run
src/native-session-runtime.test.ts`. Full checks use `pnpm -r
typecheck`, `pnpm test:run`, `pnpm build`, and the separate runner
checks. Paid evals require the frozen definitions, profiles, and
credentials; do not use `--all` as a substitute for the selected cases.

## Risks

- Context placement changes can affect model behavior. Deterministic
checks cover the selected paths, but live qualification remains
incomplete.
- The stale-question guard can reject a request when queued human
comments arrived during the run. This is intended.
- New stored inputs and model envelopes retain compatibility readers for
older active sessions.
- Custom templates may intentionally repeat content.
- Removing a model-facing working-directory sentence does not change
filesystem, command, sandbox, or permission configuration.
- The worker bypass applies only to same-origin development module
paths. Cache-policy tests preserve private-response handling and
production asset caching. Mounted HTTP fixture changes remain test-only.
- This PR does not claim measured token savings or statistical
equivalence across every harness.

## Model Used

OpenAI Codex, exact model gpt-6-astra, with repository tools and code
execution. Bounded supporting work used gpt-5.6-luna and gpt-6-luna. The
serving context-window size is not exposed in this task.

## Checklist

- [x] I have included a thinking path that traces from project context
to this change
- [x] I have specified the model used (with version and capability
details)
- [x] I have checked ROADMAP.md and confirmed this PR does not duplicate
planned core work
- [x] I have searched GitHub for duplicate or related PRs and linked
them above
- [x] I have described the issue in-PR using the required issue fields
- [x] I have not referenced internal/instance-local Paperclip issues or
links
- [x] My branch name describes the change and contains no internal
ticket id
- [x] I have run the focused local checks and they pass
- [x] I have added or updated tests where applicable
- [x] I have updated relevant documentation to reflect these changes
- [x] I have considered and documented risks above
- [x] All current-head Paperclip CI gates are green
- [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups
for the current head
- [x] I will address all Greptile and reviewer comments before
requesting merge

---------

Co-authored-by: Paperclip <noreply@paperclip.ing>
2026-09-28 14:49:14 -05:00

1213 lines
62 KiB
TypeScript

import { getExecutionBlocker } from "../execution-blocker.js";
import { createRunDispatch, deriveCommentId } from "../../modules/run-dispatch/index.js";
import { buildExecutionContinuation } from "../execution-continuation.js";
import { issueService } from "../issues.js";
import { activityService } from "../activity.js";
import { instanceSettingsService } from "../instance-settings.js";
import { buildPaperclipWakePayload, heartbeatService } from "../heartbeat.js";
import { legacyExecutionNeedsReconciliation, terminalizeLegacyExecution } from "../legacy-execution-recovery.js";
import { deliverExecutionStatuses } from "../execution-status-delivery.js";
import { publishLiveEvent } from "../live-events.js";
import {
settleUnrecoverableExecutions,
validateExecutionReconciliation,
markExecutionReconciliation,
deliverReconciledExecutions,
} from "../execution-recovery-resolution.js";
import { randomUUID } from "node:crypto";
import { appendHeartbeatRunEvent } from "../heartbeat-run-events.js";
import { tmpdir } from "node:os";
import { mkdtemp, readFile, rm, writeFile } from "node:fs/promises";
import { join } from "node:path";
import { and, eq, inArray, sql } from "drizzle-orm";
import { afterAll, afterEach, beforeAll, describe, expect, it, vi } from "vitest";
import {
agents,
companies,
createDb,
heartbeatRunEvents,
heartbeatRuns,
issueRecoveryActions,
issueComments,
issueThreadInteractions,
issueDocuments,
documents,
documentRevisions,
issues,
nativeRunFinalizations,
} from "@paperclipai/db";
import {
getEmbeddedPostgresTestSupport,
startEmbeddedPostgresTestDatabase,
} from "../../__tests__/helpers/embedded-postgres.js";
import { reconcileSafeNativeReplacements } from "./native-safe-replacement.js";
import { reconcileAbandonedExecutionControl } from "../execution-control-reconciliation.js";
const externalDatabaseUrl = process.env.PAPERCLIP_TEST_DATABASE_URL;
const support = externalDatabaseUrl
? { supported: true }
: await getEmbeddedPostgresTestSupport();
(support.supported ? describe : describe.skip)(
"durable replacement and control recovery",
() => {
let database: Awaited<ReturnType<typeof startEmbeddedPostgresTestDatabase>>;
let db: ReturnType<typeof createDb>;
beforeAll(async () => {
if (externalDatabaseUrl) {
// The caller owns this fresh, already-migrated database.
db = createDb(externalDatabaseUrl);
return;
}
database = await startEmbeddedPostgresTestDatabase(
"paperclip-safe-replacement-",
);
db = createDb(database.connectionString);
}, 30_000);
afterEach(async () => {
// Each sweep scans all companies. Keep earlier tests' unresolved runs out
// of later tests so every case exercises only its own recovery fixtures.
await db.execute(sql`TRUNCATE companies CASCADE`);
});
afterAll(async () => {
if (externalDatabaseUrl) await db?.$client.end();
else await database?.cleanup();
});
async function seed(attempt = 1) {
const companyId = randomUUID(),
agentId = randomUUID(),
issueId = randomUUID(),
runId = randomUUID();
await db.insert(companies).values({
id: companyId,
name: "Recovery",
issuePrefix: `R${companyId.slice(0, 6)}`,
});
await db.insert(agents).values({
id: agentId,
companyId,
name: "Executor",
role: "engineer",
adapterType: "paperclip_runner",
});
await db.insert(issues).values({
id: issueId,
companyId,
title: "Read fixture",
status: "in_progress",
assigneeAgentId: agentId,
});
await db.insert(heartbeatRuns).values({
id: runId,
companyId,
agentId,
nativeIssueId: issueId,
runtimeMode: "native",
status: "failed",
contextSnapshot: {
issueId,
preservedRecoveryContext: true,
paperclipWake: { comments: [{ id: "stale-comment" }] },
paperclipWakeComment: { id: "stale-comment" },
paperclipTaskMarkdown: "stale historical task",
paperclipTaskMarkdownCompact: "stale historical compact task",
paperclipTaskMarkdownAssignment: "stale assignment task",
paperclipTaskMarkdownAssignmentCompact: "stale assignment compact task",
paperclipTurnContext: {
version: 1,
assignment: { owner: "task_markdown" },
events: { owner: "wake_prompt", comments: [{ id: "stale-comment" }] },
},
},
runnerProfileJson: {
recoveryEventInventoryVersion: 1,
nativeExecutionInput: {
provider: { kind: "codex" },
workspace: { cwd: tmpdir() },
},
},
});
await db.insert(nativeRunFinalizations).values({
runId,
companyId,
issueId,
phase: "terminal_failure",
attempt,
failureCode: "native_provider_terminal_failed",
failureDetail: { originalFailureCode: "fixture_checkpoint_unusable" },
});
return { companyId, agentId, issueId, runId };
}
it.each(["verified", "unproven", "unknown_action"] as const)(
"preserves saved work and a queued request at a controlled recovery boundary (%s)",
async (mode) => {
// The stopped-session verifier is the injected boundary here. These are
// scheduler/database tests, not evidence that SIGKILL is a safe boundary.
const workspace = await mkdtemp(join(tmpdir(), "paperclip-recovery-work-"));
try {
const file = join(workspace, "saved.txt");
const saved = "Completed work from before the interruption.\n";
await writeFile(file, saved);
const source = await seed(2);
await db.update(heartbeatRuns).set({ runnerProfileJson: {
recoveryEventInventoryVersion: 1,
nativeExecutionInput: { provider: { kind: "codex" }, workspace: { cwd: workspace } },
} }).where(eq(heartbeatRuns.id, source.runId));
await db.update(nativeRunFinalizations).set({ failureCode: "native_session_cleanup_quarantined" })
.where(eq(nativeRunFinalizations.runId, source.runId));
const projected = await issueService(db).update(source.issueId, { status: "blocked" });
await db.insert(issueRecoveryActions).values({
companyId: source.companyId, sourceIssueId: source.issueId,
kind: "active_run_watchdog", cause: "native_session_cleanup_quarantined", fingerprint: source.runId,
ownerType: "board", returnOwnerAgentId: source.agentId, status: "resolved", outcome: "blocked",
evidence: { runId: source.runId, nativeFailureBlock: { runId: source.runId, statusVersion: projected!.statusVersion } },
nextAction: "Verify the stopped execution before restarting.",
});
const body = "Keep the saved work and explain the result.";
const comment = await issueService(db).addComment(source.issueId, body, { userId: "operator" });
if (mode === "unknown_action") await appendHeartbeatRunEvent(db, {
companyId: source.companyId, runId: source.runId, agentId: source.agentId,
eventType: "tool.execution.started", stream: "system",
payload: { name: "send_email", executionId: "unconfirmed-write", transport: "process" },
});
const retire = vi.fn(() => true);
const verifyStoppedSession = vi.fn(async (run: typeof heartbeatRuns.$inferSelect) =>
run.id === source.runId && mode !== "unproven" ? { evidence: {}, retire } : null);
// Repeated sweeps must not create duplicate successors or user messages.
await reconcileSafeNativeReplacements(db, new Date(), { verifyStoppedSession });
await reconcileSafeNativeReplacements(db, new Date(), { verifyStoppedSession });
const successors = await db.select().from(heartbeatRuns).where(eq(heartbeatRuns.retryOfRunId, source.runId));
expect(successors).toHaveLength(mode === "verified" ? 1 : 0);
expect(await readFile(file, "utf8")).toBe(saved);
const comments = await db.select().from(issueComments).where(eq(issueComments.issueId, source.issueId));
expect(comments.filter((row) => row.id === comment.id)).toMatchObject([{ body }]);
expect(comments.filter((row) => row.body === body)).toHaveLength(1);
const [task] = await db.select().from(issues).where(eq(issues.id, source.issueId));
if (mode === "verified") {
expect(retire).toHaveBeenCalledOnce();
expect(task!.status).toBe("in_progress");
expect(successors[0]!.contextSnapshot).toMatchObject({
issueId: source.issueId,
preservedRecoveryContext: true,
});
for (const key of [
"paperclipWake",
"paperclipWakeComment",
"paperclipTaskMarkdown",
"paperclipTaskMarkdownCompact",
"paperclipTaskMarkdownAssignment",
"paperclipTaskMarkdownAssignmentCompact",
"paperclipTurnContext",
]) {
expect(successors[0]!.contextSnapshot).not.toHaveProperty(key);
}
const continuation = await buildExecutionContinuation({
db, companyId: source.companyId, issueId: source.issueId, agentId: source.agentId,
context: successors[0]!.contextSnapshot!, summary: null, exposeLowTrustRaw: false,
});
expect(continuation.messages.filter((message) => message.id === comment.id)).toHaveLength(1);
expect(continuation.objective).toBe(body);
} else {
expect(retire).not.toHaveBeenCalled();
expect(task!.status).toBe("blocked");
if (mode === "unknown_action") {
const [decision] = await db.select().from(nativeRunFinalizations).where(eq(nativeRunFinalizations.runId, source.runId));
expect(decision!.failureDetail?.replacementDenied).toBe("uncertain_provider_action");
}
}
} finally {
await rm(workspace, { recursive: true, force: true });
}
},
);
it.each(["unproven", "changed", "verified"] as const)("requires stopped-session proof through commit (%s)", async (mode) => {
const source = await seed(2);
await db.update(nativeRunFinalizations).set({ failureCode: "native_session_cleanup_quarantined" }).where(eq(nativeRunFinalizations.runId, source.runId));
const [projected] = await db.update(issues).set({ status: "blocked" }).where(eq(issues.id, source.issueId)).returning();
await db.insert(issueRecoveryActions).values({ companyId: source.companyId, sourceIssueId: source.issueId,
kind: "active_run_watchdog", cause: "native_session_cleanup_quarantined", fingerprint: source.runId,
ownerType: "board", returnOwnerAgentId: source.agentId, status: "resolved", outcome: "blocked",
evidence: { runId: source.runId, nativeFailureBlock: { runId: source.runId, statusVersion: projected!.statusVersion }, automaticRecovery: { replay: "blocked" } }, nextAction: "Automatic recovery stopped.",
});
const retire = vi.fn(() => mode === "verified");
const verifyStoppedSession = vi.fn(async (run: typeof heartbeatRuns.$inferSelect) =>
run.id === source.runId && mode !== "unproven" ? { evidence: { completedTaskControlCallIds: ["completion"] }, retire } : null);
await appendHeartbeatRunEvent(db, { companyId: source.companyId, runId: source.runId, agentId: source.agentId,
eventType: "tool.execution.started", stream: "system",
payload: { name: "paperclip_finish", executionId: "completion", transport: "process" },
});
await reconcileSafeNativeReplacements(db, new Date(), { verifyStoppedSession });
await reconcileSafeNativeReplacements(db, new Date(), { verifyStoppedSession });
const successors = await db.select().from(heartbeatRuns).where(eq(heartbeatRuns.retryOfRunId, source.runId));
expect(successors).toHaveLength(mode === "verified" ? 1 : 0);
const [hold] = await db.select().from(issueRecoveryActions).where(eq(issueRecoveryActions.sourceIssueId, source.issueId));
if (mode === "verified") {
expect(retire).toHaveBeenCalledOnce();
expect(hold).toMatchObject({ status: "resolved", outcome: "handed_back", evidence: { automaticRecovery: { replay: "verified_safe_replacement" } } });
// Prove that the real dispatch gate accepts the successor, not only that a row exists.
const dispatch = createRunDispatch(db);
await db.update(heartbeatRuns).set({ status: "queued" }).where(eq(heartbeatRuns.id, successors[0]!.id));
const result = await dispatch.cancelStaleQueuedRun({ companyId: source.companyId, runId: successors[0]!.id, expectedStatus: "queued", now: new Date() });
expect(result.outcome).toBe("not_stale");
} else {
expect(hold!.evidence.automaticRecovery).toEqual({ replay: "blocked" });
}
});
it.each(["missing_receipt", "other_run", "other_cause", "manual_reblock", "dependency_edit", "queued_comment"] as const)("honors blocking intent before safe replacement (%s)", async (mode) => {
const source = await seed(2);
await db.update(nativeRunFinalizations).set({ failureCode: "native_session_cleanup_quarantined" }).where(eq(nativeRunFinalizations.runId, source.runId));
const projected = await issueService(db).update(source.issueId, { status: "blocked" });
const evidence = { runId: source.runId, ...(mode === "missing_receipt" ? {} : {
nativeFailureBlock: { runId: mode === "other_run" ? randomUUID() : source.runId, statusVersion: projected!.statusVersion },
}) };
const [hold] = await db.insert(issueRecoveryActions).values({ companyId: source.companyId, sourceIssueId: source.issueId,
kind: "active_run_watchdog", cause: mode === "other_cause" ? "native_event_replay_conflict" : "native_session_cleanup_quarantined",
fingerprint: source.runId, ownerType: "board", returnOwnerAgentId: source.agentId,
status: "resolved", outcome: "blocked", evidence, nextAction: "Preserve this hold.",
}).returning();
if (mode === "manual_reblock") await issueService(db).update(source.issueId, { status: "blocked", actorUserId: "operator" });
if (mode === "dependency_edit") {
const blockerId = randomUUID();
await db.insert(issues).values({ id: blockerId, companyId: source.companyId, title: "Human dependency", status: "todo" });
await issueService(db).update(source.issueId, { blockedByIssueIds: [blockerId], actorUserId: "operator" });
}
const comment = mode === "queued_comment" ? await issueService(db).addComment(source.issueId, "Also explain the result", { userId: "operator" }) : null;
const retire = vi.fn(() => true);
await reconcileSafeNativeReplacements(db, new Date(), { verifyStoppedSession: async run =>
run.id === source.runId ? { evidence: {}, retire } : null });
const successors = await db.select().from(heartbeatRuns).where(eq(heartbeatRuns.retryOfRunId, source.runId));
const [after] = await db.select().from(issues).where(eq(issues.id, source.issueId));
const [afterHold] = await db.select().from(issueRecoveryActions).where(eq(issueRecoveryActions.id, hold!.id));
if (mode === "queued_comment") {
expect(successors).toHaveLength(1);
expect(after!.status).toBe("in_progress");
expect(afterHold!.outcome).toBe("handed_back");
expect((await db.select().from(issueComments).where(eq(issueComments.id, comment!.id)))[0]!.body).toBe("Also explain the result");
} else {
expect(successors).toHaveLength(0);
expect(retire).not.toHaveBeenCalled();
expect(after!.status).toBe("blocked");
expect(afterHold!.evidence).toEqual(evidence);
expect(afterHold!.outcome).toBe("blocked");
}
});
it("automatically closes an exhausted incident once, preserves ownership, and records no replay", async () => {
const source = await seed(3);
await reconcileSafeNativeReplacements(db);
await Promise.all([settleUnrecoverableExecutions(db), settleUnrecoverableExecutions(db)]);
await settleUnrecoverableExecutions(db);
const [task] = await db.select().from(issues).where(eq(issues.id, source.issueId));
expect(task).toMatchObject({ status: "blocked", assigneeAgentId: source.agentId, executionRunId: null, checkoutRunId: null });
const actions = await db.select().from(issueRecoveryActions).where(eq(issueRecoveryActions.sourceIssueId, source.issueId));
expect(actions).toHaveLength(1);
expect(actions[0]).toMatchObject({ status: "resolved", outcome: "blocked", evidence: {
automaticRecovery: { policy: "preserve_without_replay_v1", actionOutcome: "unknown", replay: "blocked", runId: source.runId },
} });
const logs = await db.select().from(heartbeatRunEvents).where(eq(heartbeatRunEvents.runId, source.runId));
expect(logs.filter(log => log.payload?.automaticRecovery === "preserve_without_replay_v1")).toHaveLength(1);
const history = await activityService(db).runsForIssue(source.companyId, source.issueId);
expect(history.find(run => run.runId === source.runId)).toMatchObject({ execution: { phase: "recovery_needed", label: "Stopped" } });
expect(await db.select().from(heartbeatRuns).where(eq(heartbeatRuns.companyId, source.companyId))).toHaveLength(1);
});
it("does not let a full batch awaiting replacement starve an eligible disposition", async () => {
const sources: Awaited<ReturnType<typeof seed>>[] = [];
for (let index = 0; index < 26; index += 1) {
const source = await seed();
sources.push(source);
await db.insert(issueRecoveryActions).values({ companyId: source.companyId, sourceIssueId: source.issueId,
kind: "active_run_watchdog", ownerType: "board", returnOwnerAgentId: source.agentId,
cause: "native_provider_terminal_failed", fingerprint: source.runId, evidence: { runId: source.runId }, nextAction: "Checking recovery" });
if (index === 25) {
await db.update(nativeRunFinalizations).set({ failureDetail: { replacementDenied: "uncertain_external_action" } }).where(eq(nativeRunFinalizations.runId, source.runId));
await settleUnrecoverableExecutions(db);
const [task] = await db.select().from(issues).where(eq(issues.id, source.issueId));
expect(task.status).toBe("blocked");
}
}
await db.update(issueRecoveryActions).set({ status: "resolved" }).where(inArray(issueRecoveryActions.sourceIssueId, sources.map(source => source.issueId)));
await db.update(nativeRunFinalizations).set({ failureDetail: { replacementDenied: "fixture_closed" } }).where(inArray(nativeRunFinalizations.runId, sources.map(source => source.runId)));
});
it("rolls back a crashed automatic disposition and completes it on the next sweep", async () => {
const source = await seed(3);
await reconcileSafeNativeReplacements(db);
await expect(settleUnrecoverableExecutions(db, new Date(), { failpoint: () => { throw new Error("crash before commit"); } })).rejects.toThrow("crash before commit");
const [before] = await db.select().from(issues).where(eq(issues.id, source.issueId));
expect(before.status).toBe("in_progress");
const [pending] = await db.select().from(issueRecoveryActions).where(eq(issueRecoveryActions.sourceIssueId, source.issueId));
expect(pending.status).toBe("active");
await settleUnrecoverableExecutions(db);
const [after] = await db.select().from(issues).where(eq(issues.id, source.issueId));
expect(after.status).toBe("blocked");
const logs = await db.select().from(heartbeatRunEvents).where(eq(heartbeatRunEvents.runId, source.runId));
expect(logs.filter(log => log.payload?.automaticRecovery === "preserve_without_replay_v1")).toHaveLength(1);
});
it("does not let the automatic fallback preempt a safe replacement", async () => {
const source = await seed();
await db.insert(issueRecoveryActions).values({ companyId: source.companyId, sourceIssueId: source.issueId,
kind: "active_run_watchdog", ownerType: "board", returnOwnerAgentId: source.agentId,
cause: "native_provider_terminal_failed", fingerprint: source.runId, evidence: { runId: source.runId }, nextAction: "Checking recovery" });
await settleUnrecoverableExecutions(db);
const [task] = await db.select().from(issues).where(eq(issues.id, source.issueId));
expect(task.status).toBe("in_progress");
const [action] = await db.select().from(issueRecoveryActions).where(eq(issueRecoveryActions.sourceIssueId, source.issueId));
expect(action.status).toBe("active");
});
it.each(["closed", "reassigned", "new_execution"])("closes stale recovery after %s without changing task state or granting replay", async change => {
const source = await seed(3);
await reconcileSafeNativeReplacements(db);
const nextRun = randomUUID();
if (change === "new_execution") await db.insert(heartbeatRuns).values({ id: nextRun, companyId: source.companyId, agentId: source.agentId, status: "running" });
const patch = change === "closed" ? { status: "done" } : change === "reassigned" ? { assigneeAgentId: null } : { executionRunId: nextRun };
await db.update(issues).set(patch).where(eq(issues.id, source.issueId));
await settleUnrecoverableExecutions(db);
const [task] = await db.select().from(issues).where(eq(issues.id, source.issueId));
expect(task).toMatchObject(patch);
const [action] = await db.select().from(issueRecoveryActions).where(eq(issueRecoveryActions.sourceIssueId, source.issueId));
expect(action).toMatchObject({ status: "resolved", outcome: "cancelled", evidence: { automaticRecovery: { replay: "blocked" } } });
});
it("cancels a durable native retry even when its previous provider is already failed", async () => {
const source = await seed();
await db.update(nativeRunFinalizations).set({ phase: "retryable_failure", nextAttemptAt: new Date(Date.now() + 30_000) }).where(eq(nativeRunFinalizations.runId, source.runId));
await db.update(issues).set({ executionRunId: source.runId }).where(eq(issues.id, source.issueId));
const heartbeat = heartbeatService(db);
expect(await heartbeat.cancelRun(source.runId)).toMatchObject({ status: "cancelled" });
expect(await heartbeat.cancelRun(source.runId)).toMatchObject({ status: "cancelled" });
const [coordinator] = await db.select().from(nativeRunFinalizations).where(eq(nativeRunFinalizations.runId, source.runId));
expect(coordinator).toMatchObject({ phase: "terminal_failure", nextAttemptAt: null, leaseOwner: null });
expect(await db.select().from(heartbeatRuns).where(eq(heartbeatRuns.retryOfRunId, source.runId))).toHaveLength(0);
});
it("atomically terminalizes unsupported legacy recovery and preserves its owner", async () => {
const source = await seed();
await db.update(heartbeatRuns).set({ runtimeMode: "legacy", status: "running" }).where(eq(heartbeatRuns.id, source.runId));
await db.update(issues).set({ executionRunId: source.runId, checkoutRunId: source.runId }).where(eq(issues.id, source.issueId));
const [run] = await db.select().from(heartbeatRuns).where(eq(heartbeatRuns.id, source.runId));
const results = await Promise.all([1, 2].map(() => terminalizeLegacyExecution({ db, run, status: "failed", fromStatuses: ["running"], patch: { errorCode: "provider_quota", finishedAt: new Date() } })));
expect(results.filter(Boolean)).toHaveLength(1);
const [task] = await db.select().from(issues).where(eq(issues.id, source.issueId));
expect(task).toMatchObject({ assigneeAgentId: source.agentId, executionRunId: null, checkoutRunId: null });
const actions = await db.select().from(issueRecoveryActions).where(eq(issueRecoveryActions.sourceIssueId, source.issueId));
expect(actions).toHaveLength(1);
expect(actions[0]).toMatchObject({ ownerType: "board", cause: "legacy_execution_requires_reconciliation" });
await db.delete(nativeRunFinalizations).where(eq(nativeRunFinalizations.runId, source.runId));
await settleUnrecoverableExecutions(db);
const [settled] = await db.select().from(issueRecoveryActions).where(eq(issueRecoveryActions.id, actions[0]!.id));
expect(settled).toMatchObject({ status: "resolved", outcome: "blocked", evidence: { automaticRecovery: { replay: "blocked" } } });
expect(legacyExecutionNeedsReconciliation({ ...run, status: "failed", resultJson: { errorFamily: "provider_quota" } })).toBe(true);
expect(legacyExecutionNeedsReconciliation({ ...run, status: "failed", resultJson: { executionRecovery: { kind: "bootstrap", providerWorkStarted: false } } })).toBe(false);
expect(legacyExecutionNeedsReconciliation({ ...run, status: "failed", scheduledRetryAttempt: 2, resultJson: { executionRecovery: { kind: "bootstrap", providerWorkStarted: false } } })).toBe(true);
});
it.each(["pending", "accepted", "rejected", "expired"] as const)("preserves %s approval and saved work while unsafe restore recovery is repeated", async (status) => {
const source = await seed();
const documentId = randomUUID(), revisionId = randomUUID(), interactionId = randomUUID();
await db.insert(documents).values({ id: documentId, companyId: source.companyId, title: "Plan", latestBody: "Only the two approved changes.", latestRevisionId: revisionId });
await db.insert(documentRevisions).values({ id: revisionId, companyId: source.companyId, documentId, revisionNumber: 1, body: "Only the two approved changes.", createdByRunId: source.runId });
await db.insert(issueDocuments).values({ companyId: source.companyId, issueId: source.issueId, documentId, key: "plan" });
await db.insert(issueComments).values({ companyId: source.companyId, issueId: source.issueId, authorAgentId: source.agentId, createdByRunId: source.runId, body: "The plan is saved." });
await db.insert(issueThreadInteractions).values({
id: interactionId, companyId: source.companyId, issueId: source.issueId, kind: "request_confirmation", status,
sourceRunId: source.runId, createdByAgentId: source.agentId,
resolvedByUserId: status === "accepted" || status === "rejected" ? "board-user" : null,
resolvedAt: status === "pending" ? null : new Date(),
payload: { version: 1, prompt: "Review the scoped plan.", target: { type: "issue_document", key: "plan", revisionId } },
result: status === "pending" ? null : { version: 1, outcome: status === "expired" ? "superseded_by_comment" : status },
});
const [run] = await db.update(heartbeatRuns).set({
runtimeMode: "legacy", errorCode: "workspace_restore_failed", scheduledRetryAttempt: 1, scheduledRetryReason: "transient_failure",
runnerProfileJson: { adapterDispatch: { adapterType: "grok_local" } },
resultJson: { workspaceRestoreFailure: "restore_unsafe_archive", conversationContinuation: "continue_conversation_v1", summary: "The plan is saved.", workspaceRestorePath: "/tmp/private-clone/file", savedPlanRevisionId: randomUUID() },
}).where(eq(heartbeatRuns.id, source.runId)).returning();
const [resetComment] = await db.insert(issueComments).values({ companyId: source.companyId, issueId: source.issueId, authorUserId: "board-user", body: "/new" }).returning();
await db.update(issues).set({ conversationAgentId: source.agentId, conversationUserId: "board-user", conversationState: "active", conversationBoundaryCommentId: resetComment.id }).where(eq(issues.id, source.issueId));
const activityRuns = await activityService(db).runsForIssue(source.companyId, source.issueId);
expect(activityRuns.find((row) => row.runId === source.runId)?.resultJson).toMatchObject({ workspaceRestoreFailure: "restore_unsafe_archive", savedPlanRevisionId: revisionId, workspaceRestorePath: null });
const before = await db.select().from(issueThreadInteractions).where(eq(issueThreadInteractions.id, interactionId));
const savedComments = await db.select().from(issueComments).where(eq(issueComments.issueId, source.issueId));
for (let attempt = 0; attempt < 2; attempt++) {
await terminalizeLegacyExecution({ db, run, status: "failed" });
await settleUnrecoverableExecutions(db);
}
const [task] = await db.select().from(issues).where(eq(issues.id, source.issueId));
expect(task.status).toBe("blocked");
const actions = await db.select().from(issueRecoveryActions).where(eq(issueRecoveryActions.sourceIssueId, source.issueId));
expect(actions).toHaveLength(1);
const [action] = actions;
expect(action).toMatchObject({ outcome: "blocked", evidence: { automaticRecovery: { replay: "blocked" }, workspaceRestoreFailure: "restore_unsafe_archive" } });
expect(action.nextAction).toContain("Workspace repair required");
expect(await getExecutionBlocker(db, source.companyId, source.issueId, { conversationResetCommentId: resetComment.id })).toMatchObject({ runId: source.runId });
const decision = { runId: source.runId, providerStopped: true as const, actionOutcome: "mixed" as const, outcomeEvidence: "Verified saved plan and comment. Workspace copy-back failed." };
const input = { db, companyId: source.companyId, issueId: source.issueId, agentId: source.agentId, sourceRunId: source.runId, decision };
await expect(validateExecutionReconciliation(input)).rejects.toThrow("workspaceRepairEvidence");
const verified = { ...decision, workspaceRepairEvidence: "Verified fresh confined staging after repairing the unsafe fixture link." };
await expect(validateExecutionReconciliation({ ...input, decision: verified })).resolves.toMatchObject({ id: source.runId });
await markExecutionReconciliation(db, action, verified, "operator");
// Occupy the only agent slot. Exercise real admission without a provider.
await instanceSettingsService(db).updateExperimental({ enableAgentChat: true });
await db.update(agents).set({ status: "active", adapterType: "grok_local", runtimeConfig: { heartbeat: { wakeOnDemand: true, maxConcurrentRuns: 1 } } }).where(eq(agents.id, source.agentId));
await db.update(issues).set({ responsibleUserId: "board-user" }).where(eq(issues.id, source.issueId));
await db.insert(heartbeatRuns).values({ companyId: source.companyId, agentId: source.agentId, status: "running" });
const heartbeat = heartbeatService(db);
const wake = vi.fn(heartbeat.wakeup);
await deliverReconciledExecutions(db, wake as unknown as Parameters<typeof deliverReconciledExecutions>[1]);
await deliverReconciledExecutions(db, wake as unknown as Parameters<typeof deliverReconciledExecutions>[1]);
expect(wake).toHaveBeenCalledTimes(1);
const [successor] = await db.select().from(heartbeatRuns).where(eq(heartbeatRuns.retryOfRunId, source.runId));
expect(successor).toMatchObject({ status: "queued", scheduledRetryAttempt: 1, scheduledRetryReason: "transient_failure" });
await db.update(heartbeatRuns).set({ status: "succeeded" }).where(eq(heartbeatRuns.id, successor.id));
const [original] = await db.select().from(heartbeatRuns).where(eq(heartbeatRuns.id, source.runId));
expect(original).toMatchObject({ status: "failed", errorCode: "workspace_restore_failed", resultJson: run.resultJson });
const continuation = await buildExecutionContinuation({ db, companyId: source.companyId, issueId: source.issueId, agentId: source.agentId, context: { previousRunId: source.runId }, summary: null, exposeLowTrustRaw: false });
if (status === "accepted" || status === "rejected") expect(continuation.humanResponses).toContainEqual(expect.objectContaining({ id: interactionId, status }));
else expect(continuation.humanResponses).not.toContainEqual(expect.objectContaining({ id: interactionId }));
expect(await db.select().from(issueThreadInteractions).where(eq(issueThreadInteractions.issueId, source.issueId))).toEqual(before);
expect(await db.select().from(issueComments).where(eq(issueComments.issueId, source.issueId))).toEqual(savedComments);
expect(await db.select().from(documentRevisions).where(eq(documentRevisions.documentId, documentId))).toHaveLength(1);
const [savedDocument] = await db.select().from(documents).where(eq(documents.id, documentId));
expect(savedDocument).toMatchObject({ latestBody: "Only the two approved changes.", latestRevisionId: revisionId });
});
it("does not reopen a reconciled legacy run while continuation is pending", async () => {
const source = await seed();
const [run] = await db.update(heartbeatRuns).set({ runtimeMode: "legacy", status: "cancelled" }).where(eq(heartbeatRuns.id, source.runId)).returning();
await terminalizeLegacyExecution({ db, run, status: "cancelled" });
const [action] = await db.select().from(issueRecoveryActions).where(eq(issueRecoveryActions.sourceIssueId, source.issueId));
await markExecutionReconciliation(db, action!, { runId: source.runId, providerStopped: true, actionOutcome: "not_performed", outcomeEvidence: "The deterministic fixture has stopped and only printed output." }, "board");
await db.update(issueRecoveryActions).set({ status: "resolved" }).where(eq(issueRecoveryActions.id, action!.id));
await terminalizeLegacyExecution({ db, run, status: "cancelled" });
const actions = await db.select().from(issueRecoveryActions).where(eq(issueRecoveryActions.sourceIssueId, source.issueId));
expect(actions).toHaveLength(1);
expect(actions[0]).toMatchObject({ status: "resolved", evidence: { continuationDelivery: "pending", executionReconciliation: { runId: source.runId } } });
await db.update(issueRecoveryActions).set({ evidence: { ...actions[0]!.evidence, continuationDelivery: "invalidated" } }).where(eq(issueRecoveryActions.id, action!.id));
});
it("surfaces a failed current reviewer without transferring the original assignment", async () => {
const source = await seed();
const reviewerId = randomUUID();
await db.insert(agents).values({ id: reviewerId, companyId: source.companyId, name: "Reviewer", role: "engineer", adapterType: "process" });
await db.update(issues).set({ status: "in_review", executionState: {
status: "pending", currentStageId: randomUUID(), currentStageIndex: 0, currentStageType: "review",
currentParticipant: { type: "agent", agentId: reviewerId, userId: null },
returnAssignee: { type: "agent", agentId: source.agentId, userId: null },
completedStageIds: [], lastDecisionId: null, lastDecisionOutcome: null,
} }).where(eq(issues.id, source.issueId));
const [run] = await db.update(heartbeatRuns).set({ agentId: reviewerId, runtimeMode: "legacy", status: "running" }).where(eq(heartbeatRuns.id, source.runId)).returning();
await terminalizeLegacyExecution({ db, run, status: "failed", patch: { finishedAt: new Date() } });
const [action] = await db.select().from(issueRecoveryActions).where(eq(issueRecoveryActions.sourceIssueId, source.issueId));
expect(action).toMatchObject({ ownerType: "board", returnOwnerAgentId: source.agentId, evidence: { reviewParticipantAgentId: reviewerId } });
const input = { db, companyId: source.companyId, issueId: source.issueId, agentId: source.agentId, sourceRunId: source.runId,
decision: { runId: source.runId, providerStopped: true as const, actionOutcome: "not_performed" as const, outcomeEvidence: "Inspected reviewer process and verified no actions occurred." } };
await expect(validateExecutionReconciliation(input)).resolves.toMatchObject({ id: source.runId });
await db.update(issues).set({ executionState: null }).where(eq(issues.id, source.issueId));
await expect(validateExecutionReconciliation(input)).rejects.toThrow("source or task owner changed");
});
it("does not turn an already reconciled continuation into a recovery assignment", async () => {
const source = await seed();
const [action] = await db.insert(issueRecoveryActions).values({ companyId: source.companyId, sourceIssueId: source.issueId, kind: "active_run_watchdog", status: "resolved", ownerType: "board", returnOwnerAgentId: source.agentId, cause: "native_event_replay_conflict", fingerprint: source.runId, nextAction: "Old recovery instruction", evidence: { executionReconciliation: { runId: source.runId } } }).returning();
const wake = await buildPaperclipWakePayload({ db, companyId: source.companyId, contextSnapshot: { issueId: source.issueId, recoveryActionId: action.id, wakeReason: "issue_recovery_action_restored" } });
expect(wake?.recovery).toBeNull();
expect(wake?.reason).toBe("issue_recovery_action_restored");
});
it("keeps an unclassified transport terminal operator-owned", async () => {
const source = await seed();
await db
.update(nativeRunFinalizations)
.set({
failureDetail: {
originalFailureCode: "notification_transport_failed",
},
})
.where(eq(nativeRunFinalizations.runId, source.runId));
await reconcileSafeNativeReplacements(db);
expect(
await db
.select()
.from(heartbeatRuns)
.where(eq(heartbeatRuns.retryOfRunId, source.runId)),
).toHaveLength(0);
const [coordinator] = await db
.select()
.from(nativeRunFinalizations)
.where(eq(nativeRunFinalizations.runId, source.runId));
expect(coordinator?.failureDetail?.replacementDenied).toBe(
"provider_failure_meaning_unverified",
);
});
it.each(["done", "cancelled", "review"])("does not reuse consumed wake authority after a later %s transition", async transition => {
const source = await seed();
const previousRunId = randomUUID(), commentId = randomUUID();
await db.insert(heartbeatRuns).values({ id: previousRunId, companyId: source.companyId,
agentId: source.agentId, runtimeMode: "native", status: "failed", contextSnapshot: { issueId: source.issueId } });
await db.insert(issueComments).values({ id: commentId, companyId: source.companyId,
issueId: source.issueId, authorType: "user", authorUserId: "board", body: "Continue" });
await db.insert(issueRecoveryActions).values({ companyId: source.companyId, sourceIssueId: source.issueId,
kind: "active_run_watchdog", cause: "native_provider_terminal_failed", fingerprint: previousRunId,
status: "resolved", outcome: "cancelled", nextAction: "User continued", evidence: {
explicitUserContinuation: { previousRunId, commentId, actorId: "board", runId: source.runId },
} });
await db.update(heartbeatRuns).set({ contextSnapshot: {
issueId: source.issueId, previousRunId,
wakeCommentId: commentId, wakeCommentIds: [commentId], commentId,
resumeIntent: true, followUpRequested: true,
explicitUserContinuation: { previousRunId, commentId },
} }).where(eq(heartbeatRuns.id, source.runId));
await reconcileSafeNativeReplacements(db);
const [successor] = await db.select().from(heartbeatRuns).where(eq(heartbeatRuns.retryOfRunId, source.runId));
expect(successor.contextSnapshot?.explicitUserContinuation).toBeUndefined();
expect(deriveCommentId(successor.contextSnapshot)).toBeNull();
expect(successor.contextSnapshot?.resumeIntent).toBeUndefined();
expect(successor.contextSnapshot?.followUpRequested).toBeUndefined();
const envelope = await buildExecutionContinuation({ db, companyId: source.companyId,
issueId: source.issueId, agentId: source.agentId, context: successor.contextSnapshot!,
summary: null, exposeLowTrustRaw: false });
expect(envelope.trigger.sourceRunId).toBe(source.runId);
expect(envelope.objective).toBe("Continue");
if (transition === "review") {
await db.update(issues).set({ status: "in_review", executionState: {
status: "pending", currentStageId: randomUUID(), currentStageIndex: 0, currentStageType: "review",
currentParticipant: { type: "agent", agentId: randomUUID(), userId: null },
returnAssignee: { type: "agent", agentId: source.agentId, userId: null },
reviewRequest: null, completedStageIds: [], lastDecisionId: null, lastDecisionOutcome: null,
} }).where(eq(issues.id, source.issueId));
} else {
await db.update(issues).set({ status: transition }).where(eq(issues.id, source.issueId));
}
await db.update(heartbeatRuns).set({ status: "queued" }).where(eq(heartbeatRuns.id, successor.id));
expect(await createRunDispatch(db).cancelStaleQueuedRun({ companyId: source.companyId,
runId: successor.id, expectedStatus: "queued" })).toMatchObject({ outcome: "cancelled",
errorCode: transition === "review" ? "issue_review_participant_changed" : "issue_terminal_status" });
});
it("persists exactly one linked successor under competing sweepers and restarts", async () => {
const source = await seed(2);
const now = new Date();
await Promise.all([
reconcileSafeNativeReplacements(db, now),
reconcileSafeNativeReplacements(db, now),
]);
await reconcileSafeNativeReplacements(db, now);
const children = await db
.select()
.from(heartbeatRuns)
.where(eq(heartbeatRuns.retryOfRunId, source.runId));
expect(children).toHaveLength(1);
expect(children[0]).toMatchObject({
agentId: source.agentId,
status: "scheduled_retry",
scheduledRetryAttempt: 2,
contextSnapshot: {
forceFreshSession: true,
recoveryIncidentRootRunId: source.runId,
},
});
expect(children[0]!.scheduledRetryAt!.getTime()).toBe(
now.getTime() + 30_000,
);
expect(
(
await db
.select()
.from(nativeRunFinalizations)
.where(eq(nativeRunFinalizations.runId, source.runId))
)[0]?.failureDetail?.successorRunId,
).toBe(children[0]!.id);
});
it("retries status publication after a crash without dispatching provider work", async () => {
await deliverExecutionStatuses(db);
const source = await seed();
const deliveryId = randomUUID();
await db
.update(heartbeatRuns)
.set({
executionStatusDeliveryId: deliveryId,
error: "credential-in-provider-error",
errorCode: "credential-in-provider-code",
triggerDetail: "credential-in-trigger-detail",
contextSnapshot: {
issueId: source.issueId,
secret: "credential-in-context",
nested: { provider: "credential-in-nested-context" },
},
resultJson: {
summary: "credential-in-provider-summary",
toolResult: "credential-in-tool-result",
},
})
.where(eq(heartbeatRuns.id, source.runId));
await deliverExecutionStatuses(db, {
publish: () => {
throw new Error("publication unavailable");
},
});
expect(
(
await db
.select()
.from(heartbeatRuns)
.where(eq(heartbeatRuns.id, source.runId))
)[0]?.executionStatusDeliveryId,
).toBe(deliveryId);
const observed: unknown[] = [];
const publish: typeof publishLiveEvent = (event) => {
observed.push(event);
return publishLiveEvent(event);
};
await expect(
deliverExecutionStatuses(db, {
publish,
failpoint: () => {
throw new Error("crash after publication");
},
}),
).rejects.toThrow("crash after publication");
await deliverExecutionStatuses(db, { publish });
expect(JSON.stringify(observed)).not.toContain("credential-in-");
expect(
Object.keys(
(observed[0] as { payload: Record<string, unknown> }).payload,
).sort(),
).toEqual(
[
"runId",
"agentId",
"issueId",
"status",
"startedAt",
"finishedAt",
"deliveryId",
].sort(),
);
expect(observed).toEqual([
expect.objectContaining({
companyId: source.companyId,
payload: expect.objectContaining({
runId: source.runId,
issueId: source.issueId,
deliveryId,
status: "failed",
}),
}),
expect.objectContaining({
companyId: source.companyId,
payload: expect.objectContaining({
runId: source.runId,
issueId: source.issueId,
deliveryId,
status: "failed",
}),
}),
]);
expect(
(
await db
.select()
.from(heartbeatRuns)
.where(eq(heartbeatRuns.id, source.runId))
)[0]?.executionStatusDeliveryId,
).toBeNull();
expect(
await db
.select()
.from(heartbeatRuns)
.where(eq(heartbeatRuns.retryOfRunId, source.runId)),
).toHaveLength(0);
});
it.each([
"native",
"legacy",
"native_precedes_context",
"missing",
"nonexistent",
"deleted",
"foreign",
"malformed",
"object",
"array",
"number",
"json_null",
"native_foreign",
"native_nonexistent",
] as const)(
"routes status delivery only through a proven same-company task: %s",
async (association) => {
await deliverExecutionStatuses(db);
const source = await seed();
const otherIssueId = randomUUID();
await db.insert(issues).values({
id: otherIssueId,
companyId: source.companyId,
title: "Other task",
status: "backlog",
});
const foreign =
association === "foreign" || association === "native_foreign"
? await seed()
: null;
const runId = randomUUID();
const deliveryId = randomUUID();
let nativeIssueId: string | null = null;
let contextSnapshot: Record<string, unknown> = {
issueId: source.issueId,
};
let expectedIssueId: string | null = null;
switch (association) {
case "native":
nativeIssueId = source.issueId;
contextSnapshot = {};
expectedIssueId = source.issueId;
break;
case "legacy":
expectedIssueId = source.issueId;
break;
case "native_precedes_context":
nativeIssueId = source.issueId;
contextSnapshot = { issueId: otherIssueId };
expectedIssueId = source.issueId;
break;
case "missing":
contextSnapshot = {};
break;
case "nonexistent":
contextSnapshot = { issueId: randomUUID() };
break;
case "deleted":
contextSnapshot = { issueId: otherIssueId };
await db.delete(issues).where(eq(issues.id, otherIssueId));
break;
case "foreign":
contextSnapshot = { issueId: foreign!.issueId };
break;
case "malformed":
contextSnapshot = { issueId: "credential-in-invalid-issue-id" };
break;
case "object":
contextSnapshot = { issueId: { secret: "credential-in-object" } };
break;
case "array":
contextSnapshot = {
issueId: [source.issueId, "credential-in-array"],
};
break;
case "number":
contextSnapshot = { issueId: 42 };
break;
case "json_null":
contextSnapshot = { issueId: null };
break;
case "native_foreign":
nativeIssueId = foreign!.issueId;
break;
case "native_nonexistent":
nativeIssueId = randomUUID();
break;
}
await db.insert(heartbeatRuns).values({
id: runId,
companyId: source.companyId,
agentId: source.agentId,
runtimeMode: nativeIssueId ? "native" : "legacy",
nativeIssueId,
contextSnapshot: {
...contextSnapshot,
secret: "credential-in-context",
},
status: "cancelled",
executionStatusDeliveryId: deliveryId,
error: "credential-in-error",
resultJson: { output: "credential-in-output" },
});
const beforeRunIds = (
await db
.select({ id: heartbeatRuns.id })
.from(heartbeatRuns)
.where(eq(heartbeatRuns.companyId, source.companyId))
)
.map((row) => row.id)
.sort();
const observed: Parameters<typeof publishLiveEvent>[0][] = [];
await deliverExecutionStatuses(db, {
publish: (event) => {
observed.push(event);
return publishLiveEvent(event);
},
});
expect(observed).toEqual([
{
companyId: source.companyId,
type: "heartbeat.run.status",
payload: {
runId,
agentId: source.agentId,
issueId: expectedIssueId,
status: "cancelled",
startedAt: null,
finishedAt: null,
deliveryId,
},
},
]);
expect(JSON.stringify(observed)).not.toContain("credential-in-");
if (foreign)
expect(JSON.stringify(observed)).not.toContain(foreign.issueId);
expect(
(
await db
.select({ id: heartbeatRuns.id })
.from(heartbeatRuns)
.where(eq(heartbeatRuns.companyId, source.companyId))
)
.map((row) => row.id)
.sort(),
).toEqual(beforeRunIds);
expect(
(
await db
.select()
.from(heartbeatRuns)
.where(eq(heartbeatRuns.id, runId))
)[0],
).toMatchObject({
status: "cancelled",
executionStatusDeliveryId: null,
processPid: null,
});
},
);
it("never resets an exhausted incident by assigning another run id", async () => {
const source = await seed(3);
await reconcileSafeNativeReplacements(db);
expect(
await db
.select()
.from(heartbeatRuns)
.where(eq(heartbeatRuns.retryOfRunId, source.runId)),
).toHaveLength(0);
expect(
(
await db
.select()
.from(issueRecoveryActions)
.where(eq(issueRecoveryActions.sourceIssueId, source.issueId))
)[0],
).toMatchObject({
ownerType: "board",
cause: "execution_recovery_budget_exhausted",
});
});
it.each(["successor_inserted", "lineage_committed"] as const)(
"recovers a crash at %s without duplicate successors",
async (phase) => {
const source = await seed();
await expect(
reconcileSafeNativeReplacements(db, new Date(), {
failpoint: (point) => {
if (point === phase)
throw new Error("simulated coordinator crash");
},
}),
).rejects.toThrow("simulated coordinator crash");
await reconcileSafeNativeReplacements(db);
expect(
await db
.select()
.from(heartbeatRuns)
.where(eq(heartbeatRuns.retryOfRunId, source.runId)),
).toHaveLength(1);
},
);
it.each([false, true])(
"does not replay a provider-native command with unknown effects (PRP envelope: %s)",
async (wrapped) => {
const source = await seed();
await db.insert(heartbeatRunEvents).values({
companyId: source.companyId,
runId: source.runId,
agentId: source.agentId,
seq: 1,
eventType: "tool.execution.started",
stream: "system",
payload: wrapped
? {
prpEvent: {
payload: {
transport: "process",
executionId: "shell-write-1",
name: "send_email",
},
},
}
: {
transport: "process",
executionId: "shell-write-1",
name: "send_email",
},
});
await reconcileSafeNativeReplacements(db);
expect(
await db
.select()
.from(heartbeatRuns)
.where(eq(heartbeatRuns.retryOfRunId, source.runId)),
).toHaveLength(0);
expect(
(
await db
.select()
.from(issueRecoveryActions)
.where(eq(issueRecoveryActions.sourceIssueId, source.issueId))
)[0]?.nextAction,
).toContain("shell-write-1");
},
);
it("surfaces a reviewer's abandoned control transition for the operator", async () => {
const source = await seed();
const reviewerId = randomUUID();
await db.insert(agents).values({ id: reviewerId, companyId: source.companyId, name: "Reviewer", role: "engineer", adapterType: "process" });
await db.update(issues).set({ status: "in_review", executionRunId: source.runId, executionState: {
status: "pending", currentStageId: randomUUID(), currentStageIndex: 0, currentStageType: "review",
currentParticipant: { type: "agent", agentId: reviewerId, userId: null },
returnAssignee: { type: "agent", agentId: source.agentId, userId: null },
completedStageIds: [], lastDecisionId: null, lastDecisionOutcome: null,
} }).where(eq(issues.id, source.issueId));
await db.update(heartbeatRuns).set({ agentId: reviewerId, status: "running", executionControlDeadlineAt: new Date(Date.now() - 1_000) }).where(eq(heartbeatRuns.id, source.runId));
await reconcileAbandonedExecutionControl(db);
expect(await db.select().from(issueRecoveryActions).where(eq(issueRecoveryActions.sourceIssueId, source.issueId))).toMatchObject([
{ ownerType: "board", returnOwnerAgentId: source.agentId, evidence: { reviewParticipantAgentId: reviewerId } },
]);
expect((await db.select().from(issues).where(eq(issues.id, source.issueId)))[0]).toMatchObject({ assigneeAgentId: source.agentId, executionRunId: null });
});
it("fences a stranded finalization and surfaces one operator action after its deadline", async () => {
const source = await seed();
const deadline = new Date("2026-09-08T10:00:00Z");
await db
.update(heartbeatRuns)
.set({ status: "running" })
.where(eq(heartbeatRuns.id, source.runId));
await db
.update(nativeRunFinalizations)
.set({
phase: "observed",
leaseOwner: "dead-controller",
controlDeadlineAt: deadline,
})
.where(eq(nativeRunFinalizations.runId, source.runId));
await reconcileAbandonedExecutionControl(
db,
new Date(deadline.getTime() + 15_000),
);
await reconcileAbandonedExecutionControl(
db,
new Date(deadline.getTime() + 30_000),
);
expect(
(
await db
.select()
.from(heartbeatRuns)
.where(eq(heartbeatRuns.id, source.runId))
)[0],
).toMatchObject({
status: "failed",
errorCode: "execution_finalization_deadline_exceeded",
});
expect(
(
await db
.select()
.from(nativeRunFinalizations)
.where(eq(nativeRunFinalizations.runId, source.runId))
)[0],
).toMatchObject({
leaseOwner: null,
controlDeadlineAt: null,
phase: "terminal_failure",
});
expect(
await db
.select()
.from(issueRecoveryActions)
.where(
and(
eq(issueRecoveryActions.sourceIssueId, source.issueId),
eq(
issueRecoveryActions.cause,
"execution_finalization_deadline_exceeded",
),
),
),
).toHaveLength(1);
});
it("bounds legacy finalization without adding a deadline to healthy provider execution", async () => {
const source = await seed();
await db
.delete(nativeRunFinalizations)
.where(eq(nativeRunFinalizations.runId, source.runId));
await db
.update(heartbeatRuns)
.set({
runtimeMode: "legacy",
status: "running",
executionControlDeadlineAt: null,
})
.where(eq(heartbeatRuns.id, source.runId));
await reconcileAbandonedExecutionControl(db);
expect(
(
await db
.select()
.from(heartbeatRuns)
.where(eq(heartbeatRuns.id, source.runId))
)[0]?.status,
).toBe("running");
await db
.update(heartbeatRuns)
.set({ executionControlDeadlineAt: new Date(Date.now() - 1000) })
.where(eq(heartbeatRuns.id, source.runId));
await reconcileAbandonedExecutionControl(db);
expect(
(
await db
.select()
.from(heartbeatRuns)
.where(eq(heartbeatRuns.id, source.runId))
)[0],
).toMatchObject({ status: "failed", executionControlDeadlineAt: null });
expect(
(
await db
.select()
.from(issueRecoveryActions)
.where(eq(issueRecoveryActions.sourceIssueId, source.issueId))
)[0]?.ownerType,
).toBe("board");
});
it("does not release another run's checkout or replace a reassigned task", async () => {
const source = await seed();
const otherRunId = randomUUID();
await db.insert(heartbeatRuns).values({
id: otherRunId,
companyId: source.companyId,
agentId: source.agentId,
status: "running",
});
await db
.update(issues)
.set({ checkoutRunId: otherRunId })
.where(eq(issues.id, source.issueId));
await reconcileSafeNativeReplacements(db);
expect(
await db
.select()
.from(heartbeatRuns)
.where(eq(heartbeatRuns.retryOfRunId, source.runId)),
).toHaveLength(0);
await db
.update(issues)
.set({ assigneeAgentId: null })
.where(eq(issues.id, source.issueId));
await reconcileSafeNativeReplacements(db);
expect(
await db
.select()
.from(heartbeatRuns)
.where(eq(heartbeatRuns.retryOfRunId, source.runId)),
).toHaveLength(0);
});
it("requires explicit reconciled outcomes and rejects a still-running provider", async () => {
const source = await seed();
const input = {
db,
companyId: source.companyId,
issueId: source.issueId,
agentId: source.agentId,
sourceRunId: source.runId,
decision: undefined,
};
await expect(validateExecutionReconciliation(input)).rejects.toThrow(
"Reconcile the recorded execution",
);
const decision = {
runId: source.runId,
providerStopped: true as const,
actionOutcome: "not_performed" as const,
outcomeEvidence:
"Verified that the fixture emitted an event only; no external action happened.",
};
await db
.update(heartbeatRuns)
.set({ processPid: process.pid })
.where(eq(heartbeatRuns.id, source.runId));
await expect(
validateExecutionReconciliation({ ...input, decision }),
).rejects.toThrow("still running");
await db
.update(heartbeatRuns)
.set({ processPid: null })
.where(eq(heartbeatRuns.id, source.runId));
await expect(
validateExecutionReconciliation({ ...input, decision }),
).resolves.toMatchObject({ id: source.runId });
await expect(
validateExecutionReconciliation({
...input,
companyId: randomUUID(),
decision,
}),
).rejects.toThrow("source or task owner changed");
});
it("retains a reconciliation delivery across dispatch failure and invalidates stale ownership", async () => {
const source = await seed();
const [action] = await db
.insert(issueRecoveryActions)
.values({
companyId: source.companyId,
sourceIssueId: source.issueId,
kind: "active_run_watchdog",
status: "resolved",
ownerType: "board",
returnOwnerAgentId: source.agentId,
cause: "uncertain_provider_action",
fingerprint: source.runId,
evidence: { runId: source.runId },
nextAction: "Reconcile fixture action",
})
.returning();
const decision = {
runId: source.runId,
providerStopped: true as const,
actionOutcome: "not_performed" as const,
outcomeEvidence:
"The fixture was inspected and no command was executed.",
};
await markExecutionReconciliation(db, action!, decision, "operator");
await deliverReconciledExecutions(db, async () => {
throw new Error("dispatch unavailable");
});
expect(
(
await db
.select()
.from(issueRecoveryActions)
.where(eq(issueRecoveryActions.id, action!.id))
)[0]?.evidence.continuationDelivery,
).toBe("pending");
await db
.update(issues)
.set({ assigneeAgentId: null })
.where(eq(issues.id, source.issueId));
let woke = false;
await deliverReconciledExecutions(db, async () => {
woke = true;
return null;
});
expect(woke).toBe(false);
expect(
(
await db
.select()
.from(issueRecoveryActions)
.where(eq(issueRecoveryActions.id, action!.id))
)[0]?.evidence.continuationDelivery,
).toBe("invalidated");
});
},
);