mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-21 08:22:20 +02:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work > - The web UI has keyboard shortcuts for the inbox, task lists, cases, and task detail, plus global shortcuts such as `c`, `/`, `?`, `[`, and `]` > - Shortcut enablement was an instance-wide General setting until #14141 moved it to a per-user preference that defaults to off > - The move did not carry the old instance value over, so every existing user lost shortcuts on upgrade and had to find a new toggle under Profile settings > - A toggle that only turns off a standard, input-safe feature costs a setting, a database column, two API routes, and a React context for little benefit > - This pull request removes both the instance setting and the personal preference and enables keyboard shortcuts for every signed-in user > - The benefit is one less thing to configure, no silent loss of shortcuts on upgrade, and less code to maintain ## Linked Issues or Issue Description Refs #14141 (the change that introduced the personal preference). **What existing behavior does this improve?** Keyboard shortcuts in the web UI stay off unless each user turns them on in Profile settings. **Subsystem affected** Web UI shortcuts, Profile settings, instance general settings, the `/api/auth/preferences` routes, and the `user` table. **Current behavior** Shortcuts default to off per user. #14141 moved the toggle from Instance settings → General to Profile settings and did not carry the old instance value over. Users who had shortcuts on lost them after the upgrade and had to find the new toggle. **Proposed behavior** Keyboard shortcuts are always enabled for every signed-in user. There is no instance setting and no personal preference. Shortcuts already ignore key presses inside text inputs and modal dialogs, so an opt-out is not needed. **Reason and benefit** Fewer settings, no silent loss of shortcuts on upgrade, and removal of a database column, two API routes, a query hook, and a React context that existed only to gate this feature. **Breaking changes** `GET` and `PATCH /api/auth/preferences` are removed. `PATCH /api/instance/settings/general` no longer accepts `keyboardShortcuts`; that schema is strict, so the key now returns 400. `instance.general.keyboardShortcuts` is no longer a valid `PAPERCLIP_HIDDEN_SETTINGS` key; the parser ignores unknown keys with a warning. ## What Changed - Removed the Keyboard shortcuts section from Profile settings, the `useUserPreferences` hook, `queryKeys.auth.preferences`, and `authApi.getPreferences` / `authApi.updatePreferences`. - Removed `GeneralSettingsContext`. The inbox, legacy inbox, task list, legacy task list, cases, and task detail pages no longer gate their key handlers. - Removed the `enabled` option from `useKeyboardShortcuts`. The app shell always registers the global shortcuts. - Removed `GET` and `PATCH /api/auth/preferences`, their OpenAPI entries, and the `currentUserPreferencesSchema` / `updateCurrentUserPreferencesSchema` validators. - Removed `keyboardShortcuts` from `InstanceGeneralSettings`, the general settings zod schema, the settings service defaults, and `HIDEABLE_GENERAL_SECTIONS`. - Added migration `0289_drop_user_keyboard_shortcuts`, which drops `user.keyboard_shortcuts`. - Updated `AGENTS.md`, `doc/SPEC.md`, `doc/SPEC-implementation.md`, and `docs/deploy/environment-variables.md`. - Parsed the stored general settings row with `instanceGeneralSettingsSchema.strip()` in the feedback vote path, so a retired key left in the row cannot reset the sharing preference to `prompt` and overwrite the stored choice. - Kept every bare global shortcut (`c`, `?`, `[`, `]`, `/`) out of open modal dialogs in `useKeyboardShortcuts`; only `/` had that guard before. - Updated the affected tests and added a Profile settings test that asserts the toggle is gone, a hook test for the modal dialog guard, and a feedback service regression test for the retired-key case. ## Verification - Typecheck passes for `@paperclipai/shared`, `@paperclipai/db` (including the migration numbering and safety checks), `@paperclipai/server`, and `ui`. - `pnpm exec vitest run server/src/__tests__/instance-settings-routes.test.ts server/src/__tests__/openapi-routes.test.ts server/src/__tests__/auth-routes.test.ts server/src/__tests__/sentry.test.ts` → 119 passed. - `pnpm exec vitest run ui/src/components/Layout.test.tsx ui/src/pages/ProfileSettings.test.tsx ui/src/pages/IssueDetail.test.tsx ui/src/pages/Inbox.test.tsx ui/src/pages/Cases.test.tsx ui/src/hooks/useKeyboardShortcuts.test.tsx ui/src/pages/Agents.test.tsx ui/src/pages/InstanceGeneralSettings.test.tsx` → 286 passed. - `pnpm exec vitest run packages/shared/src/settings-visibility.test.ts` → 16 passed. - `pnpm exec vitest run ui/src/hooks/useKeyboardShortcuts.test.tsx` → 7 passed. - `pnpm exec vitest run server/src/__tests__/feedback-service.test.ts` (embedded Postgres) → the new retired-key test passes with the fix and fails without it. - Manual: sign in with no settings changed, open the inbox, press `j` and `k` to move the selection, press `?` to open the cheatsheet. Open Settings → Profile and confirm there is no Keyboard shortcuts section. ## Risks - The migration drops a column. It uses `DROP COLUMN IF EXISTS`, and the column has no readers after this change. If you roll back to a build from before this PR after the migration has run, re-add the column first: `ALTER TABLE "user" ADD COLUMN "keyboard_shortcuts" boolean DEFAULT false NOT NULL;`. The older build's ORM selects that column when it loads users. - Any external client that still sends `keyboardShortcuts` to `PATCH /api/instance/settings/general` receives a 400. No in-repo client does. - Stored `instance_settings.general.keyboardShortcuts` values are stripped on read and ignored. - Users who never turned the toggle on now get shortcuts. The handlers skip text inputs, contenteditable regions, and modal dialogs, so typing is unaffected. ## Model Used Claude Fable 5.1 (`claude-fable-5-1`) in Claude Code, with extended thinking and tool use. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge
595 lines
20 KiB
TypeScript
595 lines
20 KiB
TypeScript
// @vitest-environment jsdom
|
|
|
|
import { flushSync } from "react-dom";
|
|
import { createRoot } from "react-dom/client";
|
|
import type { AnchorHTMLAttributes } from "react";
|
|
import { QueryClient, QueryClientProvider } from "@tanstack/react-query";
|
|
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
|
|
import type { CaseSummary } from "@/api/cases";
|
|
import { Cases } from "./Cases";
|
|
|
|
function act(callback: () => void) {
|
|
flushSync(callback);
|
|
}
|
|
|
|
const companyState = vi.hoisted(() => ({ selectedCompanyId: "company-1" }));
|
|
const mockCasesApi = vi.hoisted(() => ({ list: vi.fn() }));
|
|
const mockProjectsApi = vi.hoisted(() => ({ list: vi.fn() }));
|
|
const mockIssuesApi = vi.hoisted(() => ({ listLabels: vi.fn() }));
|
|
const mockCopyTextToClipboard = vi.hoisted(() => vi.fn(() => Promise.resolve()));
|
|
const mockNavigate = vi.hoisted(() => vi.fn());
|
|
|
|
vi.mock("@/context/CompanyContext", () => ({ useCompany: () => companyState }));
|
|
vi.mock("@/context/BreadcrumbContext", () => ({ useBreadcrumbs: () => ({ setBreadcrumbs: vi.fn() }) }));
|
|
vi.mock("@/api/cases", async (importOriginal) => ({
|
|
...(await importOriginal<typeof import("@/api/cases")>()),
|
|
casesApi: mockCasesApi,
|
|
}));
|
|
vi.mock("@/api/projects", () => ({ projectsApi: mockProjectsApi }));
|
|
vi.mock("@/api/issues", () => ({ issuesApi: mockIssuesApi }));
|
|
vi.mock("@/lib/clipboard", () => ({ copyTextToClipboard: mockCopyTextToClipboard }));
|
|
vi.mock("@/lib/router", () => ({
|
|
Link: ({ children, to, ...props }: AnchorHTMLAttributes<HTMLAnchorElement> & { to: string }) => (
|
|
<a href={to} {...props}>{children}</a>
|
|
),
|
|
useNavigate: () => mockNavigate,
|
|
useCaseHref: () => (...segments: string[]) =>
|
|
`/PAP/${["cases", ...segments].filter(Boolean).join("/")}`,
|
|
}));
|
|
|
|
(globalThis as unknown as { IS_REACT_ACT_ENVIRONMENT: boolean }).IS_REACT_ACT_ENVIRONMENT = true;
|
|
|
|
async function flush() {
|
|
for (let i = 0; i < 5; i += 1) {
|
|
await Promise.resolve();
|
|
await new Promise((r) => setTimeout(r, 0));
|
|
}
|
|
flushSync(() => {});
|
|
}
|
|
async function waitForAssertion(assertion: () => void, attempts = 20) {
|
|
let lastError: unknown;
|
|
for (let i = 0; i < attempts; i += 1) {
|
|
try {
|
|
assertion();
|
|
return;
|
|
} catch (e) {
|
|
lastError = e;
|
|
await flush();
|
|
}
|
|
}
|
|
throw lastError;
|
|
}
|
|
function dispatchShortcut(key: string) {
|
|
act(() => {
|
|
document.body.dispatchEvent(new KeyboardEvent("keydown", { key, bubbles: true, cancelable: true }));
|
|
});
|
|
}
|
|
|
|
function createCase(overrides: Partial<CaseSummary>): CaseSummary {
|
|
return {
|
|
id: overrides.id ?? "case-1",
|
|
companyId: "company-1",
|
|
projectId: null,
|
|
caseNumber: 1,
|
|
identifier: overrides.identifier ?? "PAP-C1",
|
|
caseType: overrides.caseType ?? "blog_post",
|
|
key: null,
|
|
title: overrides.title ?? "A case",
|
|
summary: null,
|
|
status: overrides.status ?? "in_progress",
|
|
fields: {},
|
|
parentCaseId: null,
|
|
createdByAgentId: null,
|
|
createdByUserId: null,
|
|
completedAt: null,
|
|
createdAt: "2026-07-07T00:00:00.000Z",
|
|
updatedAt: "2026-07-07T00:00:00.000Z",
|
|
...overrides,
|
|
};
|
|
}
|
|
|
|
function renderPage(container: HTMLDivElement) {
|
|
const root = createRoot(container);
|
|
const queryClient = new QueryClient({ defaultOptions: { queries: { retry: false } } });
|
|
act(() => {
|
|
root.render(
|
|
<QueryClientProvider client={queryClient}>
|
|
<Cases />
|
|
</QueryClientProvider>,
|
|
);
|
|
});
|
|
return root;
|
|
}
|
|
|
|
describe("Cases list", () => {
|
|
let container: HTMLDivElement;
|
|
beforeEach(() => {
|
|
window.localStorage.clear();
|
|
container = document.createElement("div");
|
|
document.body.appendChild(container);
|
|
mockCasesApi.list.mockReset();
|
|
mockProjectsApi.list.mockReset().mockResolvedValue([]);
|
|
mockIssuesApi.listLabels.mockReset().mockResolvedValue([]);
|
|
mockCopyTextToClipboard.mockClear();
|
|
mockNavigate.mockClear();
|
|
HTMLElement.prototype.scrollIntoView = vi.fn();
|
|
});
|
|
afterEach(() => {
|
|
container.remove();
|
|
});
|
|
|
|
it("loads cases by default and hides terminal cases client-side", async () => {
|
|
mockCasesApi.list.mockResolvedValue([
|
|
createCase({ id: "a", identifier: "PAP-C1", title: "Active post", status: "in_progress" }),
|
|
createCase({ id: "b", identifier: "PAP-C2", title: "Done post", status: "done" }),
|
|
]);
|
|
|
|
const root = renderPage(container);
|
|
|
|
await waitForAssertion(() => {
|
|
expect(container.textContent).toContain("Active post");
|
|
expect(container.textContent).not.toContain("Done post");
|
|
expect(container.textContent).not.toContain("active ·");
|
|
expect(mockCasesApi.list).toHaveBeenCalledWith("company-1", expect.objectContaining({
|
|
limit: 200,
|
|
}));
|
|
});
|
|
|
|
act(() => root.unmount());
|
|
});
|
|
|
|
it("sends search filters to the cases API instead of filtering a fetched page locally", async () => {
|
|
mockCasesApi.list.mockResolvedValue([
|
|
createCase({ id: "a", identifier: "PAP-C1", title: "Active post", status: "in_progress" }),
|
|
]);
|
|
const root = renderPage(container);
|
|
|
|
await waitForAssertion(() => {
|
|
expect(container.textContent).toContain("Active post");
|
|
});
|
|
|
|
const input = container.querySelector<HTMLInputElement>("input[placeholder='Search cases...']");
|
|
expect(input).toBeTruthy();
|
|
act(() => {
|
|
const valueSetter = Object.getOwnPropertyDescriptor(HTMLInputElement.prototype, "value")?.set;
|
|
valueSetter?.call(input, "launch");
|
|
input!.dispatchEvent(new Event("input", { bubbles: true }));
|
|
});
|
|
|
|
await waitForAssertion(() => {
|
|
expect(mockCasesApi.list).toHaveBeenLastCalledWith("company-1", expect.objectContaining({
|
|
q: "launch",
|
|
limit: 200,
|
|
}));
|
|
});
|
|
|
|
act(() => root.unmount());
|
|
});
|
|
|
|
it("renders the onboarding hero when there are no cases at all", async () => {
|
|
mockCasesApi.list.mockResolvedValue([]);
|
|
const root = renderPage(container);
|
|
|
|
await waitForAssertion(() => {
|
|
expect(container.textContent).toContain("No cases yet");
|
|
expect(container.textContent).toContain("references/cases.md");
|
|
});
|
|
|
|
// No create-case UI anywhere (agent-only v1).
|
|
expect(container.textContent).not.toContain("New case");
|
|
expect(container.textContent).not.toContain("Create case");
|
|
|
|
act(() => root.unmount());
|
|
});
|
|
|
|
it("shows default columns in id, title, status, updated order grouped by type without keys", async () => {
|
|
mockCasesApi.list.mockResolvedValue([
|
|
createCase({ id: "a", identifier: "PAP-C1", key: "launch/post-one", title: "Post one", caseType: "blog_post" }),
|
|
createCase({ id: "b", identifier: "PAP-C2", title: "Storm one", caseType: "tweet_storm" }),
|
|
]);
|
|
|
|
const root = renderPage(container);
|
|
|
|
await waitForAssertion(() => {
|
|
expect(container.textContent).toContain("blog_post");
|
|
expect(container.textContent).toContain("tweet_storm");
|
|
expect(container.textContent).toContain("Post one");
|
|
expect(container.textContent).not.toContain("launch/post-one");
|
|
expect(container.textContent).toContain("Storm one");
|
|
});
|
|
|
|
const text = container.textContent ?? "";
|
|
expect(text.indexOf("ID")).toBeGreaterThanOrEqual(0);
|
|
expect(text.indexOf("Title")).toBeGreaterThan(text.indexOf("ID"));
|
|
expect(text.indexOf("Status")).toBeGreaterThan(text.indexOf("Title"));
|
|
expect(text.indexOf("Updated")).toBeGreaterThan(text.indexOf("Status"));
|
|
expect(text).not.toContain("Key");
|
|
expect(text).not.toContain("Project");
|
|
const headerGrid = Array.from(container.querySelectorAll<HTMLElement>("div > span[style*='grid-template-columns']")).find((element) =>
|
|
element.textContent?.includes("ID")
|
|
&& element.textContent.includes("Title")
|
|
&& element.textContent.includes("Status")
|
|
);
|
|
expect(headerGrid?.style.gridTemplateColumns).toBe(
|
|
"max-content minmax(12rem, 1fr) minmax(6rem, 7rem) minmax(5rem, 6rem)",
|
|
);
|
|
|
|
const blogGroupIndex = text.indexOf("blog_post");
|
|
const tweetGroupIndex = text.indexOf("tweet_storm");
|
|
expect(blogGroupIndex).toBeGreaterThanOrEqual(0);
|
|
expect(tweetGroupIndex).toBeGreaterThan(blogGroupIndex);
|
|
|
|
act(() => root.unmount());
|
|
});
|
|
|
|
it("copies case list identifiers with feedback without following the row link", async () => {
|
|
mockCasesApi.list.mockResolvedValue([
|
|
createCase({ id: "a", identifier: "PAP-C1", key: "launch/post-one", title: "Post one", caseType: "blog_post" }),
|
|
]);
|
|
|
|
const root = renderPage(container);
|
|
|
|
await waitForAssertion(() => {
|
|
expect(container.textContent).toContain("PAP-C1");
|
|
expect(container.textContent).not.toContain("launch/post-one");
|
|
});
|
|
|
|
const idButton = Array.from(container.querySelectorAll("button")).find((button) =>
|
|
button.textContent === "PAP-C1"
|
|
);
|
|
expect(idButton).toBeTruthy();
|
|
const click = new MouseEvent("click", { bubbles: true, cancelable: true });
|
|
act(() => {
|
|
idButton!.dispatchEvent(click);
|
|
});
|
|
|
|
await waitForAssertion(() => {
|
|
expect(click.defaultPrevented).toBe(true);
|
|
expect(mockCopyTextToClipboard).toHaveBeenCalledWith("PAP-C1");
|
|
expect(idButton!.parentElement?.textContent).toContain("Copied");
|
|
});
|
|
|
|
act(() => root.unmount());
|
|
});
|
|
|
|
it("shows and copies keys only when the key column is enabled", async () => {
|
|
window.localStorage.setItem(
|
|
"paperclip:cases:company-1:view",
|
|
JSON.stringify({
|
|
columns: ["id", "key", "title", "status", "updated"],
|
|
}),
|
|
);
|
|
mockCasesApi.list.mockResolvedValue([
|
|
createCase({ id: "a", identifier: "PAP-C1", key: "launch/post-one", title: "Post one", caseType: "blog_post" }),
|
|
]);
|
|
|
|
const root = renderPage(container);
|
|
|
|
await waitForAssertion(() => {
|
|
expect(container.textContent).toContain("Key");
|
|
expect(container.textContent).toContain("launch/post-one");
|
|
});
|
|
|
|
const keyButton = Array.from(container.querySelectorAll("button")).find((button) =>
|
|
button.textContent === "launch/post-one"
|
|
);
|
|
expect(keyButton).toBeTruthy();
|
|
const click = new MouseEvent("click", { bubbles: true, cancelable: true });
|
|
act(() => {
|
|
keyButton!.dispatchEvent(click);
|
|
});
|
|
|
|
await waitForAssertion(() => {
|
|
expect(click.defaultPrevented).toBe(true);
|
|
expect(mockCopyTextToClipboard).toHaveBeenCalledWith("launch/post-one");
|
|
expect(keyButton!.parentElement?.textContent).toContain("Copied");
|
|
});
|
|
|
|
act(() => root.unmount());
|
|
});
|
|
|
|
it("tree mode forces an ungrouped parent-child order and adds the type column", async () => {
|
|
window.localStorage.setItem(
|
|
"paperclip:cases:company-1:view",
|
|
JSON.stringify({
|
|
treeView: true,
|
|
groupBy: "type",
|
|
columns: ["id", "title", "status", "updated"],
|
|
sortField: "updated",
|
|
sortDir: "desc",
|
|
}),
|
|
);
|
|
mockCasesApi.list.mockResolvedValue([
|
|
createCase({
|
|
id: "child",
|
|
identifier: "PAP-C2",
|
|
title: "Child case",
|
|
parentCaseId: "parent",
|
|
caseType: "asset",
|
|
updatedAt: "2026-07-08T00:00:00.000Z",
|
|
}),
|
|
createCase({
|
|
id: "parent",
|
|
identifier: "PAP-C1",
|
|
title: "Parent case",
|
|
caseType: "brief",
|
|
updatedAt: "2026-07-07T00:00:00.000Z",
|
|
}),
|
|
createCase({
|
|
id: "sibling",
|
|
identifier: "PAP-C3",
|
|
title: "Sibling case",
|
|
caseType: "brief",
|
|
updatedAt: "2026-07-06T00:00:00.000Z",
|
|
}),
|
|
]);
|
|
|
|
const root = renderPage(container);
|
|
|
|
await waitForAssertion(() => {
|
|
expect(container.textContent).toContain("Type");
|
|
expect(container.textContent).toContain("brief");
|
|
expect(container.textContent).toContain("asset");
|
|
expect(container.querySelector('button[title="Show flat case list"]')).not.toBeNull();
|
|
expect(mockCasesApi.list).toHaveBeenCalledWith("company-1", expect.objectContaining({
|
|
includeAncestors: true,
|
|
limit: 200,
|
|
}));
|
|
});
|
|
|
|
const text = container.textContent ?? "";
|
|
expect(text.indexOf("Type")).toBeGreaterThan(text.indexOf("Title"));
|
|
expect(text.indexOf("Status")).toBeGreaterThan(text.indexOf("Type"));
|
|
expect(text.indexOf("Parent case")).toBeGreaterThanOrEqual(0);
|
|
expect(text.indexOf("Child case")).toBeGreaterThan(text.indexOf("Parent case"));
|
|
expect(text.indexOf("Sibling case")).toBeGreaterThan(text.indexOf("Child case"));
|
|
expect(text).not.toContain("1 child");
|
|
|
|
const collapseParent = container.querySelector<HTMLButtonElement>('button[aria-label="Collapse Parent case"]');
|
|
expect(collapseParent).toBeTruthy();
|
|
expect(collapseParent?.getAttribute("aria-expanded")).toBe("true");
|
|
act(() => {
|
|
collapseParent!.dispatchEvent(new MouseEvent("click", { bubbles: true, cancelable: true }));
|
|
});
|
|
|
|
await waitForAssertion(() => {
|
|
expect(container.textContent).toContain("Parent case");
|
|
expect(container.textContent).not.toContain("Child case");
|
|
expect(container.querySelector<HTMLButtonElement>('button[aria-label="Expand Parent case"]')?.getAttribute("aria-expanded")).toBe("false");
|
|
});
|
|
|
|
act(() => root.unmount());
|
|
});
|
|
|
|
it("keeps filtered-out ancestors visible in tree mode when descendants match", async () => {
|
|
window.localStorage.setItem(
|
|
"paperclip:cases:company-1:view",
|
|
JSON.stringify({
|
|
treeView: true,
|
|
columns: ["id", "title", "type", "status", "updated"],
|
|
}),
|
|
);
|
|
mockCasesApi.list.mockResolvedValue([
|
|
createCase({
|
|
id: "child",
|
|
identifier: "PAP-C2",
|
|
title: "Active child",
|
|
parentCaseId: "parent",
|
|
status: "in_progress",
|
|
updatedAt: "2026-07-08T00:00:00.000Z",
|
|
}),
|
|
createCase({
|
|
id: "done-sibling",
|
|
identifier: "PAP-C3",
|
|
title: "Done sibling",
|
|
status: "done",
|
|
updatedAt: "2026-07-09T00:00:00.000Z",
|
|
}),
|
|
createCase({
|
|
id: "parent",
|
|
identifier: "PAP-C1",
|
|
title: "Done parent",
|
|
status: "done",
|
|
updatedAt: "2026-07-07T00:00:00.000Z",
|
|
}),
|
|
]);
|
|
|
|
const root = renderPage(container);
|
|
|
|
await waitForAssertion(() => {
|
|
expect(container.textContent).toContain("Done parent");
|
|
expect(container.textContent).toContain("Active child");
|
|
expect(container.textContent).not.toContain("Done sibling");
|
|
});
|
|
|
|
const text = container.textContent ?? "";
|
|
expect(text.indexOf("Done parent")).toBeGreaterThanOrEqual(0);
|
|
expect(text.indexOf("Active child")).toBeGreaterThan(text.indexOf("Done parent"));
|
|
|
|
act(() => root.unmount());
|
|
});
|
|
|
|
it("supports inbox-style keyboard navigation, group folding, and opening on grouped case rows", async () => {
|
|
mockCasesApi.list.mockResolvedValue([
|
|
createCase({
|
|
id: "blog",
|
|
identifier: "PAP-C1",
|
|
title: "Blog active",
|
|
caseType: "blog_post",
|
|
updatedAt: "2026-07-08T00:00:00.000Z",
|
|
}),
|
|
createCase({
|
|
id: "docs",
|
|
identifier: "PAP-C2",
|
|
title: "Docs active",
|
|
caseType: "docs_page",
|
|
updatedAt: "2026-07-07T00:00:00.000Z",
|
|
}),
|
|
]);
|
|
|
|
const root = renderPage(container);
|
|
|
|
await waitForAssertion(() => {
|
|
expect(container.textContent).toContain("Blog active");
|
|
expect(container.textContent).toContain("Docs active");
|
|
});
|
|
|
|
dispatchShortcut("j");
|
|
await flush();
|
|
dispatchShortcut("ArrowLeft");
|
|
|
|
await waitForAssertion(() => {
|
|
expect(container.textContent).toContain("blog_post");
|
|
expect(container.textContent).not.toContain("Blog active");
|
|
});
|
|
|
|
dispatchShortcut("ArrowRight");
|
|
await waitForAssertion(() => {
|
|
expect(container.textContent).toContain("Blog active");
|
|
});
|
|
|
|
dispatchShortcut("j");
|
|
await flush();
|
|
dispatchShortcut("Enter");
|
|
|
|
expect(mockNavigate).toHaveBeenCalledWith("/PAP/cases/PAP-C1");
|
|
|
|
act(() => root.unmount());
|
|
});
|
|
|
|
it("supports keyboard tree folding and opening parent case rows", async () => {
|
|
window.localStorage.setItem(
|
|
"paperclip:cases:company-1:view",
|
|
JSON.stringify({
|
|
treeView: true,
|
|
columns: ["id", "title", "type", "status", "updated"],
|
|
}),
|
|
);
|
|
mockCasesApi.list.mockResolvedValue([
|
|
createCase({
|
|
id: "child",
|
|
identifier: "PAP-C2",
|
|
title: "Child case",
|
|
parentCaseId: "parent",
|
|
caseType: "asset",
|
|
updatedAt: "2026-07-08T00:00:00.000Z",
|
|
}),
|
|
createCase({
|
|
id: "parent",
|
|
identifier: "PAP-C1",
|
|
title: "Parent case",
|
|
caseType: "brief",
|
|
updatedAt: "2026-07-07T00:00:00.000Z",
|
|
}),
|
|
]);
|
|
|
|
const root = renderPage(container);
|
|
|
|
await waitForAssertion(() => {
|
|
expect(container.textContent).toContain("Parent case");
|
|
expect(container.textContent).toContain("Child case");
|
|
});
|
|
|
|
dispatchShortcut("j");
|
|
await flush();
|
|
dispatchShortcut("ArrowLeft");
|
|
|
|
await waitForAssertion(() => {
|
|
expect(container.textContent).toContain("Parent case");
|
|
expect(container.textContent).not.toContain("Child case");
|
|
});
|
|
|
|
dispatchShortcut("ArrowRight");
|
|
await waitForAssertion(() => {
|
|
expect(container.textContent).toContain("Child case");
|
|
});
|
|
|
|
dispatchShortcut("Enter");
|
|
|
|
expect(mockNavigate).toHaveBeenCalledWith("/PAP/cases/PAP-C1");
|
|
|
|
act(() => root.unmount());
|
|
});
|
|
|
|
it("restores persisted search, filters, group, sort, and columns", async () => {
|
|
window.localStorage.setItem(
|
|
"paperclip:cases:company-1:view",
|
|
JSON.stringify({
|
|
search: "launch",
|
|
statusFilters: ["done"],
|
|
typeFilters: ["blog_post"],
|
|
projectFilters: [],
|
|
labelFilter: "__all__",
|
|
groupBy: "status",
|
|
sortField: "created",
|
|
sortDir: "asc",
|
|
columns: ["id", "title", "status", "updated", "created"],
|
|
}),
|
|
);
|
|
mockCasesApi.list.mockResolvedValue([
|
|
createCase({
|
|
id: "a",
|
|
identifier: "PAP-C1",
|
|
title: "Active launch",
|
|
status: "in_progress",
|
|
caseType: "blog_post",
|
|
}),
|
|
createCase({
|
|
id: "b",
|
|
identifier: "PAP-C2",
|
|
title: "Done launch",
|
|
status: "done",
|
|
caseType: "blog_post",
|
|
}),
|
|
]);
|
|
|
|
const root = renderPage(container);
|
|
|
|
await waitForAssertion(() => {
|
|
expect(mockCasesApi.list).toHaveBeenLastCalledWith("company-1", expect.objectContaining({
|
|
q: "launch",
|
|
limit: 200,
|
|
}));
|
|
expect(container.textContent).toContain("Done launch");
|
|
expect(container.textContent).not.toContain("Active launch");
|
|
expect(container.textContent).toContain("Created at");
|
|
});
|
|
|
|
act(() => root.unmount());
|
|
});
|
|
|
|
it("applies multi-select type and status filters from persisted state", async () => {
|
|
window.localStorage.setItem(
|
|
"paperclip:cases:company-1:view",
|
|
JSON.stringify({
|
|
statusFilters: ["in_progress", "done"],
|
|
typeFilters: ["blog_post", "docs_page"],
|
|
projectFilters: ["project-1", "__all__"],
|
|
}),
|
|
);
|
|
mockCasesApi.list.mockResolvedValue([
|
|
createCase({ id: "a", identifier: "PAP-C1", title: "Blog active", status: "in_progress", caseType: "blog_post" }),
|
|
createCase({ id: "b", identifier: "PAP-C2", title: "Docs done", status: "done", caseType: "docs_page" }),
|
|
createCase({ id: "c", identifier: "PAP-C3", title: "Tweet active", status: "in_progress", caseType: "tweet_storm" }),
|
|
createCase({ id: "d", identifier: "PAP-C4", title: "Blog cancelled", status: "cancelled", caseType: "blog_post" }),
|
|
]);
|
|
|
|
const root = renderPage(container);
|
|
|
|
await waitForAssertion(() => {
|
|
expect(mockCasesApi.list).toHaveBeenCalledWith("company-1", expect.objectContaining({
|
|
types: ["blog_post", "docs_page"],
|
|
statuses: ["in_progress", "done"],
|
|
projectIds: ["project-1"],
|
|
includeNoProject: true,
|
|
}));
|
|
expect(container.textContent).toContain("Blog active");
|
|
expect(container.textContent).toContain("Docs done");
|
|
expect(container.textContent).not.toContain("Tweet active");
|
|
expect(container.textContent).not.toContain("Blog cancelled");
|
|
});
|
|
|
|
act(() => root.unmount());
|
|
});
|
|
});
|