mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-25 02:26:12 +02:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work. > - The board UI is the operator surface where users create, assign, monitor, and review work items. > - The product language is moving toward "tasks" for user-facing work items while the internal API and database still use "issues". > - PR #7543 bundled this copy migration with broader information-architecture work, which made the branch too large for Greptile review. > - This pull request peels the Issue-to-Task copy migration into a smaller, independently reviewable change. > - The benefit is clearer user-facing terminology, less agent confusion via the Paperclip skill note, and a smaller PR that Greptile can review. ## Linked Issues or Issue Description Refs #7645 Refs #7543 Refs PAP-10430 This PR was split out of #7543 so the Issue-to-Task copy migration can be reviewed separately and the remaining IA PR can fall under Greptile's file limit. ## What Changed - Preserves Scott Tong's original `PAP-57` copy-only commit, with author and co-author credit intact, to rename user-facing "Issues" copy to "Tasks" across the UI while keeping routes/API/internal symbols as `issue`. - Updates onboarding and release-smoke browser selectors from `Create & Open Issue` to `Create & Open Task`. - Adds a terminology note to `skills/paperclip/SKILL.md` clarifying that task and issue refer to the same Paperclip work item. - Resolves the only cherry-pick conflict by keeping current search artifacts support and changing visible search copy to "tasks". ## Verification - `pnpm --filter @paperclipai/ui build` passed. - `NODE_ENV=test pnpm exec vitest run ui/src/components/IssuesList.test.tsx ui/src/components/Sidebar.test.tsx ui/src/components/NewIssueDialog.test.tsx ui/src/pages/IssueDetail.test.tsx` passed: 4 files, 66 tests. - `git diff --check origin/master...HEAD` passed. - Diff is 80 files, below Greptile's 100-file limit. - Before/after UI copy examples: "Issues" -> "Tasks", "New Issue" -> "New Task", "Create & Open Issue" -> "Create & Open Task". ## Risks - Medium copy-risk: this intentionally changes user-facing terminology broadly while keeping internal issue identifiers and routes unchanged. - Some docs and APIs still say `issue`; the skill note clarifies this so agents do not treat task and issue as separate entities. - Browser-level visual validation is expected from CI because this local container is missing usable browser dependencies. > For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and discuss it in `#dev` before opening the PR. Feature PRs that overlap with planned core work may need to be redirected — check the roadmap first. See `CONTRIBUTING.md`. ## Model Used Scott Tong authored the original `PAP-57` copy migration, assisted by Claude Opus 4.8 and Paperclip agents per the preserved commit metadata. Codex / GPT-5-class coding agent with shell, GitHub CLI, and repository access performed the PR split, conflict resolution, skill note, and verification. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] If this change affects the UI, I have included before/after screenshots - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: scotttong <scott.tong@gmail.com> Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com> Co-authored-by: Paperclip <noreply@paperclip.ing>
100 lines
3.6 KiB
TypeScript
100 lines
3.6 KiB
TypeScript
import { formatDateTime } from "./utils";
|
|
|
|
type RetryAwareRun = {
|
|
status: string;
|
|
retryOfRunId?: string | null;
|
|
scheduledRetryAt?: string | Date | null;
|
|
scheduledRetryAttempt?: number | null;
|
|
scheduledRetryReason?: string | null;
|
|
retryExhaustedReason?: string | null;
|
|
};
|
|
|
|
export type RunRetryStateSummary = {
|
|
kind: "scheduled" | "exhausted" | "attempted";
|
|
badgeLabel: string;
|
|
tone: string;
|
|
detail: string | null;
|
|
secondary: string | null;
|
|
retryOfRunId: string | null;
|
|
};
|
|
|
|
const RETRY_REASON_LABELS: Record<string, string> = {
|
|
transient_failure: "Transient failure",
|
|
missing_issue_comment: "Missing task comment",
|
|
process_lost: "Process lost",
|
|
assignment_recovery: "Assignment recovery",
|
|
issue_continuation_needed: "Continuation needed",
|
|
max_turns_continuation: "Max-turn continuation",
|
|
};
|
|
|
|
function readNonEmptyString(value: unknown) {
|
|
return typeof value === "string" && value.trim().length > 0 ? value.trim() : null;
|
|
}
|
|
|
|
function joinFragments(parts: Array<string | null>) {
|
|
const filtered = parts.filter((part): part is string => Boolean(part));
|
|
return filtered.length > 0 ? filtered.join(" · ") : null;
|
|
}
|
|
|
|
export function formatRetryReason(reason: string | null | undefined) {
|
|
const normalized = readNonEmptyString(reason);
|
|
if (!normalized) return null;
|
|
return RETRY_REASON_LABELS[normalized] ?? normalized.replace(/_/g, " ");
|
|
}
|
|
|
|
export function describeRunRetryState(run: RetryAwareRun): RunRetryStateSummary | null {
|
|
const attempt =
|
|
typeof run.scheduledRetryAttempt === "number" && Number.isFinite(run.scheduledRetryAttempt) && run.scheduledRetryAttempt > 0
|
|
? run.scheduledRetryAttempt
|
|
: null;
|
|
const attemptLabel = attempt ? `Attempt ${attempt}` : null;
|
|
const reasonLabel = formatRetryReason(run.scheduledRetryReason);
|
|
const retryOfRunId = readNonEmptyString(run.retryOfRunId);
|
|
const exhaustedReason = readNonEmptyString(run.retryExhaustedReason);
|
|
const dueAt = run.scheduledRetryAt ? formatDateTime(run.scheduledRetryAt) : null;
|
|
const isMaxTurnContinuation = run.scheduledRetryReason === "max_turns_continuation";
|
|
const hasRetryMetadata =
|
|
Boolean(retryOfRunId)
|
|
|| Boolean(reasonLabel)
|
|
|| Boolean(dueAt)
|
|
|| Boolean(attemptLabel)
|
|
|| Boolean(exhaustedReason);
|
|
|
|
if (!hasRetryMetadata) return null;
|
|
|
|
if (run.status === "scheduled_retry") {
|
|
return {
|
|
kind: "scheduled",
|
|
badgeLabel: isMaxTurnContinuation ? "Continuation scheduled" : "Retry scheduled",
|
|
tone: "border-cyan-500/30 bg-cyan-500/10 text-cyan-700 dark:text-cyan-300",
|
|
detail: joinFragments([attemptLabel, reasonLabel]),
|
|
secondary: dueAt
|
|
? `${isMaxTurnContinuation ? "Next continuation" : "Next retry"} ${dueAt}`
|
|
: `${isMaxTurnContinuation ? "Next continuation" : "Next retry"} pending schedule`,
|
|
retryOfRunId,
|
|
};
|
|
}
|
|
|
|
if (exhaustedReason) {
|
|
return {
|
|
kind: "exhausted",
|
|
badgeLabel: isMaxTurnContinuation ? "Continuation exhausted" : "Retry exhausted",
|
|
tone: "border-amber-500/30 bg-amber-500/10 text-amber-700 dark:text-amber-300",
|
|
detail: joinFragments([attemptLabel, reasonLabel, "Automatic retries exhausted"]),
|
|
secondary: exhaustedReason.includes("Manual intervention required")
|
|
? exhaustedReason
|
|
: `${exhaustedReason} Manual intervention required.`,
|
|
retryOfRunId,
|
|
};
|
|
}
|
|
|
|
return {
|
|
kind: "attempted",
|
|
badgeLabel: isMaxTurnContinuation ? "Continued run" : "Retried run",
|
|
tone: "border-slate-500/20 bg-slate-500/10 text-slate-700 dark:text-slate-300",
|
|
detail: joinFragments([attemptLabel, reasonLabel]),
|
|
secondary: null,
|
|
retryOfRunId,
|
|
};
|
|
}
|