mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-11-21 02:43:25 +01:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work > - Routines start agent work on a schedule, from a webhook, or on demand > - The routine detail page split one routine across eight sections behind a section sidebar (overview, triggers, variables, secrets, delivery, runs, activity, history) > - People had to hunt through sections to see what a routine does and to change it, and a finished webhook could not be tested again without starting the routine > - This pull request makes the approved two-column routine page, one Edit dialog and one Webhook dialog the real routed page, and lets a live webhook go back into test mode > - The benefit is one page that answers what the routine does, when it runs, who runs it and what it made, with every change in one dialog ## Linked Issues or Issue Description **Problem** The routine detail page spreads one routine over eight sections and a section sidebar. Changing a routine means visiting several sections, each with its own save bar. A webhook that is already live cannot be tested again: the API only accepts `setupPending: false`, so testing a live webhook starts the routine. **Proposed solution** Ship the reviewed design (stories `routine-page-design`, `routine-edit-dialog-design`, `routine-webhook-dialog-design`) as the routed page in both UI shells, wired to the real API. Let `PATCH /api/routine-triggers/:id` accept `setupPending: true` for a live webhook so the next events are checked but never start the routine. **Alternatives considered** Keep the sections and restyle them. The owner rejected this: the section sidebar should go. ## What Changed - `/routines/:id` renders `RoutinePage` in both shells (`RoutineDetail.production.tsx` is removed). Status switch, Repeats rows, default agent, responsible user, project, Asks for, Secrets, Run rules, Managed by plugin, Instructions with Show all, copy and the comment count, and History. - History is paged: 20 tasks per page from `GET /companies/:id/issues?originKind=routine_execution&originId=…&sortField=created&sortDir=desc&limit=21&offset=…`, with a real Load more. Coalesced runs show as "folded into a task". - A failed refetch keeps the loaded page on screen (`useQueryView`); a History failure shows `QueryErrorState` in place. - Header: Edit, "…" (Version history, Audit log, Archive / Restore) and Run now. In the streamlined desktop shell they sit in the breadcrumb toolbar; elsewhere above the page. - Version history (`/routines/:id/history`, restore and restored-webhook keys kept) and Audit log (`/routines/:id/activity`, `RoutineAuditActivity`) open as sub-views with a way back. Old section addresses and `?tab=` redirect to `/routines/:id`. - Edit dialog saves title, instructions, variables, secrets, agent, project and responsible user in one request against the revision the dialog opened with (save conflict shows "changed while you were editing"). The first schedule is created, changed or removed after that. Priority and delivery settings are never sent, so saved values stay. - Webhooks are created, changed, tested and removed (with Undo) right away from the Edit dialog, with the Webhook dialog nested inside it. Closing the Webhook dialog ends setup or test mode. A webhook left in test mode shows "Testing · events don’t run" on the page and offers Finish testing. - Responsibility (only with `enableResponsibilities`): the page shows direct and through-project responsibilities from the link lookup; the dialog links or unlinks the direct one. With the flag off nothing is fetched or shown. - The routines list creates routines with the same dialog in create mode, filed in the open folder, and opens the new routine page. - Server: `setupPending: true` on a live webhook enters test mode (planned by a pure `planTriggerUpdate`, which also gives the activity action) (422 for other trigger kinds; 409 for a disabled or removed webhook or an archived routine). Test deliveries keep the last real delivery as `lastWebhookDelivery.previous`, and finishing testing restores it. Activity `routine.trigger_test_started`. - Additions to the reviewed design, from review, so no capability is lost: the schedule popover has Pause/Resume; standing-check and API rows open a small popover with Pause/Resume and Remove; removing a trigger from the page leaves a "… removed. Undo" line under Repeats. Stories: `StandingCheckOpened`, `ScheduleTriggerPaused(Opened)`, `RemovedWithUndo`. - Save is several requests (routine, schedule, responsibility). It changes only the schedule the form opened with, records each finished step, and a partial failure says what was saved and that saving again finishes it. The dialog cannot be dismissed while saving. Failed reads show a Retry state, never empty choices. - Removed: the routine section sidebar and contextual sidebar, the trigger wizard, trigger cards, save bar, section components and their tests. - Storybook: the three routine stories moved to `stories/routines` as current production stories, a new story mounts the routed page against a fixture API, and stories that used the old page were updated or removed. ## Verification - `pnpm --filter @paperclipai/server exec vitest run src/__tests__/routines-e2e.test.ts` (17/17) and `src/__tests__/routines-service.test.ts` (105/105). - `pnpm exec vitest run` on the routine page, routines list, routine form, webhook instructions, Layout, shell navigation, audit and editor tests: 275 tests pass. - `cd ui && npx tsc -p tsconfig.json --noEmit`, `node scripts/check-token-gates.mjs`, `node scripts/check-maps.mjs`, `node scripts/storybook-catalog.mjs --check`: pass. - `pnpm verify` exits 2 (global CI input changed); required CI supplies the broad coverage. - Manual: an isolated worktree instance (`pnpm paperclipai worktree init --empty`, `pnpm dev`) with a seeded routine. Headless Playwright: an old `/triggers` address redirects, no section sidebar, History shows 20 then 23 after Load more, the schedule popover opens, pause and resume, Edit → Add webhook → created key → Finish, title save, Test webhook → Finish testing, Version history, Audit log shows "Started testing a webhook", phone width has no horizontal overflow, and Create routine from the list opens the new page. No console errors or failed API calls. ## Risks - Behaviour change: the section pages are gone. Old links redirect to the single page. - The delivery-setting editors (concurrency, catch-up, activity gate) and priority are removed from the UI. Saved values stay, and the API still accepts them. - The create dialog no longer offers a folder picker or delivery settings. A new routine goes into the folder the list is showing and takes the default settings. - Replace key in the Webhook dialog acts at once, as in the reviewed design. The old confirmation is gone. - No migration. `lastWebhookDelivery.previous` is an optional field inside the existing jsonb column. ## Model Used - Claude Opus 5.5 (`claude-opus-5-5`), Anthropic, in Claude Code with tool use (shell, file edits, headless browser) and subagents for the server change and the Storybook move. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [ ] All Paperclip CI gates are green - [ ] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Fable 5.2 <noreply@anthropic.com>
544 lines
24 KiB
TypeScript
544 lines
24 KiB
TypeScript
import { useEffect, useId, useMemo, useRef, useState, type ReactNode } from "react";
|
|
import type { CompanySecret, EnvBinding, RoutineEnvConfig, RoutineTrigger, RoutineVariable } from "@paperclipai/shared";
|
|
import { GitBranch, Plus, Webhook, X } from "lucide-react";
|
|
import { AgentAvatar } from "@/components/AgentAvatar";
|
|
import { InlineEntitySelector } from "@/components/InlineEntitySelector";
|
|
import { MarkdownEditor, type MarkdownEditorRef, type MentionOption } from "@/components/MarkdownEditor";
|
|
import { RoutineVariablesEditor } from "@/components/RoutineVariablesEditor";
|
|
import { ScheduleEditor } from "@/components/ScheduleEditor";
|
|
import { EnvironmentVariablesEditor, type EnvironmentVariablesEditorHandle } from "@/components/environment-variables-editor";
|
|
import { Avatar, AvatarFallback, AvatarImage } from "@/components/ui/avatar";
|
|
import { Button } from "@/components/ui/button";
|
|
import { Dialog, DialogContent, DialogDescription, DialogHeader, DialogTitle } from "@/components/ui/dialog";
|
|
import { Input } from "@/components/ui/input";
|
|
import { Label } from "@/components/ui/label";
|
|
import { Select, SelectContent, SelectItem, SelectTrigger, SelectValue } from "@/components/ui/select";
|
|
import { deriveInitials } from "@/components/Identity";
|
|
import { cn } from "@/lib/utils";
|
|
import type { RoutinePageAgent, RoutinePageProject, RoutinePerson } from "./RoutinePage";
|
|
import { WEBHOOK_HEALTH_LABELS, webhookHealth, webhookTitle } from "./routine-summary";
|
|
|
|
export type RoutineFormDraft = {
|
|
title: string;
|
|
description: string;
|
|
projectId: string;
|
|
assigneeAgentId: string;
|
|
responsibleUserId: string;
|
|
/** The responsibility this routine is filed under itself; empty for none. */
|
|
responsibilityId: string;
|
|
variables: RoutineVariable[];
|
|
env: RoutineEnvConfig | null;
|
|
schedule: { cronExpression: string; timezone: string } | null;
|
|
};
|
|
|
|
export const EMPTY_ROUTINE_FORM_DRAFT: RoutineFormDraft = {
|
|
title: "",
|
|
description: "",
|
|
projectId: "",
|
|
assigneeAgentId: "",
|
|
responsibleUserId: "",
|
|
responsibilityId: "",
|
|
variables: [],
|
|
env: null,
|
|
schedule: null,
|
|
};
|
|
|
|
export type RoutineResponsibilityOption = {
|
|
id: string;
|
|
title: string;
|
|
areaTitle?: string | null;
|
|
/** Projects filed under it. A routine in one of them is already under this responsibility. */
|
|
projectIds?: readonly string[];
|
|
};
|
|
|
|
export type RoutineEditDialogProps = {
|
|
open: boolean;
|
|
onOpenChange: (open: boolean) => void;
|
|
mode?: "edit" | "create";
|
|
initial: RoutineFormDraft;
|
|
agents: readonly RoutinePageAgent[];
|
|
projects: readonly RoutinePageProject[];
|
|
people: readonly RoutinePerson[];
|
|
secrets: readonly CompanySecret[];
|
|
/** Leave undefined while areas of responsibility are switched off; the field is then hidden. */
|
|
responsibilities?: readonly RoutineResponsibilityOption[];
|
|
mentions?: MentionOption[];
|
|
/** False when this person may not reassign responsibility. */
|
|
canChangeResponsibleUser?: boolean;
|
|
saving?: boolean;
|
|
/** Someone else saved this routine while the form was open. */
|
|
saveConflict?: boolean;
|
|
error?: string | null;
|
|
onSave: (draft: RoutineFormDraft) => void;
|
|
onReloadLatest?: () => void;
|
|
onCreateSecret: (name: string, value: string) => Promise<CompanySecret>;
|
|
/** Saved webhooks. They are created and changed right away, apart from the form's Save. */
|
|
webhooks?: readonly RoutineTrigger[];
|
|
/** Opens the webhook dialog; `null` starts a new webhook. Omit while creating a routine. */
|
|
onOpenWebhook?: (trigger: RoutineTrigger | null) => void;
|
|
onRemoveWebhook?: (trigger: RoutineTrigger) => void;
|
|
/** Webhooks removed while this form is open, offered back with Undo. */
|
|
removedWebhooks?: readonly RoutineTrigger[];
|
|
onRestoreWebhook?: (trigger: RoutineTrigger) => void;
|
|
/** The webhook dialog, rendered inside this one so both stay open together. */
|
|
children?: ReactNode;
|
|
};
|
|
|
|
const SCHEDULE_TIMEZONES = ["America/Los_Angeles", "America/Chicago", "America/New_York", "Europe/London", "UTC"];
|
|
|
|
function localTimezone(): string {
|
|
try {
|
|
return Intl.DateTimeFormat().resolvedOptions().timeZone;
|
|
} catch {
|
|
return "UTC";
|
|
}
|
|
}
|
|
|
|
export function RoutineEditDialog({
|
|
open,
|
|
onOpenChange,
|
|
mode = "edit",
|
|
initial,
|
|
agents,
|
|
projects,
|
|
people,
|
|
secrets,
|
|
responsibilities,
|
|
mentions,
|
|
canChangeResponsibleUser = true,
|
|
saving = false,
|
|
saveConflict = false,
|
|
error = null,
|
|
onSave,
|
|
onReloadLatest,
|
|
onCreateSecret,
|
|
webhooks = [],
|
|
onOpenWebhook,
|
|
onRemoveWebhook,
|
|
removedWebhooks = [],
|
|
onRestoreWebhook,
|
|
children,
|
|
}: RoutineEditDialogProps) {
|
|
const [draft, setDraft] = useState(initial);
|
|
const [secretsOpen, setSecretsOpen] = useState(() => Object.keys(initial.env ?? {}).length > 0);
|
|
const [scheduleValid, setScheduleValid] = useState(true);
|
|
const [confirmingDiscard, setConfirmingDiscard] = useState(false);
|
|
const editorRef = useRef<MarkdownEditorRef>(null);
|
|
const secretsRef = useRef<EnvironmentVariablesEditorHandle>(null);
|
|
/** Secrets rows being typed that the secrets editor has not promoted into the draft yet. */
|
|
const [secretsDirty, setSecretsDirty] = useState(false);
|
|
const titleId = useId();
|
|
|
|
useEffect(() => {
|
|
if (!open) return;
|
|
setDraft(initial);
|
|
setSecretsOpen(Object.keys(initial.env ?? {}).length > 0);
|
|
setConfirmingDiscard(false);
|
|
setSecretsDirty(false);
|
|
}, [initial, open]);
|
|
|
|
const dirty = useMemo(() => JSON.stringify(draft) !== JSON.stringify(initial), [draft, initial]) || secretsDirty;
|
|
const patch = (change: Partial<RoutineFormDraft>) => setDraft((current) => ({ ...current, ...change }));
|
|
const agentById = useMemo(() => new Map(agents.map((agent) => [agent.id, agent])), [agents]);
|
|
const projectById = useMemo(() => new Map(projects.map((project) => [project.id, project])), [projects]);
|
|
const personById = useMemo(() => new Map(people.map((person) => [person.id, person])), [people]);
|
|
const responsibilityById = useMemo(
|
|
() => new Map((responsibilities ?? []).map((responsibility) => [responsibility.id, responsibility])),
|
|
[responsibilities],
|
|
);
|
|
const throughProject = draft.projectId
|
|
? (responsibilities ?? []).find(
|
|
(responsibility) => responsibility.id !== draft.responsibilityId && responsibility.projectIds?.includes(draft.projectId),
|
|
) ?? null
|
|
: null;
|
|
const canSave = draft.title.trim().length > 0 && scheduleValid && !saving && !saveConflict && (mode === "create" || dirty);
|
|
|
|
/** Saves the draft, including secrets rows still being typed. */
|
|
const submit = () => {
|
|
if (!canSave) return;
|
|
const flushed = secretsRef.current?.flushPendingDraft() ?? null;
|
|
onSave(flushed ? { ...draft, env: Object.keys(flushed).length > 0 ? flushed : null } : draft);
|
|
};
|
|
|
|
/** Escape, the close button and Cancel all come here. Nothing closes while a save is running, so a failed save keeps the draft and its error. */
|
|
const requestClose = () => {
|
|
if (saving) return;
|
|
if (dirty) setConfirmingDiscard(true);
|
|
else onOpenChange(false);
|
|
};
|
|
|
|
const personOption = (id: string) => {
|
|
const person = personById.get(id);
|
|
if (!person) return null;
|
|
return (
|
|
<>
|
|
<Avatar size="xs" aria-hidden="true">
|
|
{person.avatarUrl ? <AvatarImage src={person.avatarUrl} alt="" /> : null}
|
|
<AvatarFallback>{deriveInitials(person.name)}</AvatarFallback>
|
|
</Avatar>
|
|
<span className="truncate">{person.name}</span>
|
|
</>
|
|
);
|
|
};
|
|
|
|
return (
|
|
<Dialog open={open} onOpenChange={(next) => (next ? onOpenChange(true) : requestClose())}>
|
|
<DialogContent className="flex max-h-(--sz-calc-18) flex-col gap-0 overflow-hidden p-0 sm:max-w-3xl">
|
|
<DialogHeader className="px-6 pb-4 pt-6">
|
|
<DialogTitle>{mode === "create" ? "New routine" : "Edit routine"}</DialogTitle>
|
|
<DialogDescription className="sr-only">
|
|
{mode === "create" ? "Describe the work, then choose who does it and when." : "Change what this routine does, who does it, and when."}
|
|
</DialogDescription>
|
|
</DialogHeader>
|
|
|
|
<form
|
|
id={`${titleId}-form`}
|
|
className="flex min-h-0 flex-1 flex-col gap-6 overflow-y-auto px-6 pb-6 [&>*]:shrink-0"
|
|
onSubmit={(event) => {
|
|
event.preventDefault();
|
|
submit();
|
|
}}
|
|
>
|
|
<div className="flex flex-col gap-2">
|
|
<Label htmlFor={titleId}>Title</Label>
|
|
<Input
|
|
id={titleId}
|
|
value={draft.title}
|
|
autoFocus={mode === "create"}
|
|
placeholder="Send the weekly digest"
|
|
onChange={(event) => patch({ title: event.target.value })}
|
|
/>
|
|
</div>
|
|
|
|
<div className="flex flex-col gap-2">
|
|
<Label>Instructions</Label>
|
|
{/* The frame owns the border and the drag handle; the editor scrolls inside it. */}
|
|
<div
|
|
className="h-48 min-h-32 resize-y overflow-y-auto rounded-md border border-border px-3 py-2 focus-within:border-ring"
|
|
onClick={(event) => {
|
|
if (event.target === event.currentTarget) editorRef.current?.focus();
|
|
}}
|
|
>
|
|
<MarkdownEditor
|
|
ref={editorRef}
|
|
bordered={false}
|
|
ariaLabel="Instructions"
|
|
value={draft.description}
|
|
onChange={(description) => patch({ description })}
|
|
placeholder="What should the agent do each time? Type / for skills and routines, @ to mention, {{name}} to ask for a value."
|
|
contentClassName="text-sm leading-6"
|
|
mentions={mentions}
|
|
submitKey="mod-enter"
|
|
onSubmit={submit}
|
|
/>
|
|
</div>
|
|
</div>
|
|
|
|
<RoutineVariablesEditor
|
|
title={draft.title}
|
|
description={draft.description}
|
|
value={draft.variables}
|
|
onChange={(variables) => patch({ variables })}
|
|
variant="compact"
|
|
/>
|
|
|
|
<div className="flex flex-col gap-2">
|
|
<Label>Repeats</Label>
|
|
{draft.schedule ? (
|
|
<div className="flex flex-col gap-3">
|
|
<ScheduleEditor
|
|
inline
|
|
value={draft.schedule.cronExpression}
|
|
onChange={(cronExpression) =>
|
|
setDraft((current) => (current.schedule ? { ...current, schedule: { ...current.schedule, cronExpression } } : current))
|
|
}
|
|
onValidityChange={setScheduleValid}
|
|
trailing={(
|
|
<Select
|
|
value={draft.schedule.timezone}
|
|
onValueChange={(timezone) =>
|
|
setDraft((current) => (current.schedule ? { ...current, schedule: { ...current.schedule, timezone } } : current))
|
|
}
|
|
>
|
|
<SelectTrigger className="w-48" aria-label="Time zone">
|
|
<SelectValue />
|
|
</SelectTrigger>
|
|
<SelectContent>
|
|
{Array.from(new Set([draft.schedule.timezone, localTimezone(), ...SCHEDULE_TIMEZONES])).map((zone) => (
|
|
<SelectItem key={zone} value={zone}>{zone}</SelectItem>
|
|
))}
|
|
</SelectContent>
|
|
</Select>
|
|
)}
|
|
/>
|
|
<Button
|
|
type="button"
|
|
variant="ghost"
|
|
size="sm"
|
|
className="-mx-2 w-fit text-muted-foreground"
|
|
onClick={() => {
|
|
setScheduleValid(true);
|
|
patch({ schedule: null });
|
|
}}
|
|
>
|
|
Remove schedule
|
|
</Button>
|
|
</div>
|
|
) : (
|
|
<Button
|
|
type="button"
|
|
variant="outline"
|
|
size="sm"
|
|
className="w-fit"
|
|
onClick={() => patch({ schedule: { cronExpression: "0 9 * * 1-5", timezone: localTimezone() } })}
|
|
>
|
|
<Plus className="h-3.5 w-3.5" />
|
|
Add schedule
|
|
</Button>
|
|
)}
|
|
</div>
|
|
|
|
{onOpenWebhook ? (
|
|
<div className="flex flex-col gap-2">
|
|
<Label>Webhooks</Label>
|
|
{removedWebhooks.map((trigger) => (
|
|
<p key={trigger.id} role="status" className="flex max-w-md items-center gap-2 text-sm text-muted-foreground">
|
|
<span className="min-w-0 flex-1 truncate">{webhookTitle(trigger)} removed.</span>
|
|
<Button type="button" variant="ghost" size="xs" onClick={() => onRestoreWebhook?.(trigger)}>Undo</Button>
|
|
</p>
|
|
))}
|
|
{webhooks.length > 0 ? (
|
|
<ul className="flex max-w-md flex-col">
|
|
{webhooks.map((trigger) => {
|
|
const health = webhookHealth(trigger);
|
|
const Icon = trigger.signingMode === "github_hmac" ? GitBranch : Webhook;
|
|
return (
|
|
<li key={trigger.id} className="group/webhook -mx-2 flex items-center rounded-md hover:bg-accent/50 focus-within:bg-accent/50">
|
|
<button
|
|
type="button"
|
|
aria-label={`Configure ${webhookTitle(trigger)}`}
|
|
className="flex min-w-0 flex-1 items-center gap-2 rounded-md px-2 py-1.5 text-left text-sm focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring"
|
|
onClick={() => onOpenWebhook(trigger)}
|
|
>
|
|
<Icon className="h-4 w-4 shrink-0 text-muted-foreground" aria-hidden="true" />
|
|
<span className="min-w-0 flex-1 truncate font-medium">{webhookTitle(trigger)}</span>
|
|
<span className={cn("shrink-0 text-xs", health === "rejected" ? "text-destructive" : "text-muted-foreground")}>
|
|
{WEBHOOK_HEALTH_LABELS[health]}
|
|
</span>
|
|
</button>
|
|
{onRemoveWebhook ? (
|
|
<Button
|
|
type="button"
|
|
variant="ghost"
|
|
size="icon-xs"
|
|
aria-label={`Remove ${webhookTitle(trigger)}`}
|
|
className="mr-1 text-muted-foreground opacity-0 hover:text-destructive focus-visible:opacity-100 group-hover/webhook:opacity-100 group-focus-within/webhook:opacity-100"
|
|
onClick={() => onRemoveWebhook(trigger)}
|
|
>
|
|
<X />
|
|
</Button>
|
|
) : null}
|
|
</li>
|
|
);
|
|
})}
|
|
</ul>
|
|
) : null}
|
|
<Button type="button" variant="outline" size="sm" className="w-fit" onClick={() => onOpenWebhook(null)}>
|
|
<Plus className="h-3.5 w-3.5" />
|
|
Add webhook
|
|
</Button>
|
|
</div>
|
|
) : null}
|
|
|
|
<div className="flex max-w-xs flex-col gap-6">
|
|
<div className="flex min-w-0 flex-col gap-2">
|
|
<Label>Default agent</Label>
|
|
<InlineEntitySelector
|
|
value={draft.assigneeAgentId}
|
|
options={agents.map((agent) => ({ id: agent.id, label: agent.name }))}
|
|
placeholder="Choose an agent"
|
|
noneLabel="No default agent"
|
|
searchPlaceholder="Search agents…"
|
|
emptyMessage="No agents found."
|
|
disablePortal
|
|
className="h-9 w-full justify-start"
|
|
onChange={(assigneeAgentId) => patch({ assigneeAgentId })}
|
|
renderTriggerValue={(option) => {
|
|
const agent = option ? agentById.get(option.id) : null;
|
|
return agent ? (
|
|
<>
|
|
<AgentAvatar agent={agent} size={20} className="shrink-0" />
|
|
<span className="truncate">{agent.name}</span>
|
|
</>
|
|
) : (
|
|
<span className="text-muted-foreground">Choose an agent</span>
|
|
);
|
|
}}
|
|
renderOption={(option) => {
|
|
const agent = agentById.get(option.id);
|
|
return (
|
|
<>
|
|
{agent ? <AgentAvatar agent={agent} size={20} className="shrink-0" /> : null}
|
|
<span className="truncate">{option.label}</span>
|
|
</>
|
|
);
|
|
}}
|
|
/>
|
|
</div>
|
|
|
|
<div className="flex min-w-0 flex-col gap-2">
|
|
<Label>Project</Label>
|
|
<InlineEntitySelector
|
|
value={draft.projectId}
|
|
options={projects.map((project) => ({ id: project.id, label: project.name }))}
|
|
placeholder="No project"
|
|
noneLabel="No project"
|
|
searchPlaceholder="Search projects…"
|
|
emptyMessage="No projects found."
|
|
disablePortal
|
|
className="h-9 w-full justify-start"
|
|
onChange={(projectId) => patch({ projectId })}
|
|
renderTriggerValue={(option) => {
|
|
const project = option ? projectById.get(option.id) : null;
|
|
return project ? (
|
|
<>
|
|
<span className="h-3.5 w-3.5 shrink-0 rounded-sm" style={{ backgroundColor: project.color ?? "var(--project-none)" }} />
|
|
<span className="truncate">{project.name}</span>
|
|
</>
|
|
) : (
|
|
<span className="text-muted-foreground">No project</span>
|
|
);
|
|
}}
|
|
renderOption={(option) => {
|
|
const project = projectById.get(option.id);
|
|
return (
|
|
<>
|
|
{project ? (
|
|
<span className="h-3.5 w-3.5 shrink-0 rounded-sm" style={{ backgroundColor: project.color ?? "var(--project-none)" }} />
|
|
) : null}
|
|
<span className="truncate">{option.label}</span>
|
|
</>
|
|
);
|
|
}}
|
|
/>
|
|
</div>
|
|
|
|
{responsibilities ? (
|
|
<div className="flex min-w-0 flex-col gap-2">
|
|
<Label>Responsibility</Label>
|
|
<InlineEntitySelector
|
|
value={draft.responsibilityId}
|
|
options={responsibilities.map((responsibility) => ({
|
|
id: responsibility.id,
|
|
label: responsibility.title,
|
|
searchText: responsibility.areaTitle ?? "",
|
|
}))}
|
|
placeholder="No responsibility"
|
|
noneLabel="No responsibility"
|
|
searchPlaceholder="Search responsibilities…"
|
|
emptyMessage="No responsibilities found."
|
|
disablePortal
|
|
className="h-9 w-full justify-start"
|
|
onChange={(responsibilityId) => patch({ responsibilityId })}
|
|
renderTriggerValue={(option) =>
|
|
option?.id ? <span className="truncate">{option.label}</span> : <span className="text-muted-foreground">No responsibility</span>
|
|
}
|
|
renderOption={(option) => {
|
|
const areaTitle = responsibilityById.get(option.id)?.areaTitle;
|
|
return (
|
|
<>
|
|
<span className="min-w-0 flex-1 truncate">{option.label}</span>
|
|
{areaTitle ? <span className="shrink-0 text-xs text-muted-foreground">{areaTitle}</span> : null}
|
|
</>
|
|
);
|
|
}}
|
|
/>
|
|
{throughProject ? (
|
|
<p className="text-xs text-muted-foreground">
|
|
Already under {throughProject.title} through {projectById.get(draft.projectId)?.name ?? "its project"}.
|
|
</p>
|
|
) : null}
|
|
</div>
|
|
) : null}
|
|
|
|
<div className="flex min-w-0 flex-col gap-2">
|
|
<Label>Default responsible user</Label>
|
|
<InlineEntitySelector
|
|
value={draft.responsibleUserId}
|
|
options={people.map((person) => ({ id: person.id, label: person.name }))}
|
|
placeholder="Choose a person"
|
|
noneLabel="No one"
|
|
// A responsible user can be changed but not cleared; "No one" only shows while there is none.
|
|
hideNone={Boolean(initial.responsibleUserId)}
|
|
searchPlaceholder="Find a person…"
|
|
emptyMessage="No people found."
|
|
disablePortal
|
|
disabled={!canChangeResponsibleUser}
|
|
className="h-9 w-full justify-start"
|
|
onChange={(responsibleUserId) => patch({ responsibleUserId })}
|
|
renderTriggerValue={(option) =>
|
|
(option && personOption(option.id)) || <span className="text-muted-foreground">Choose a person</span>
|
|
}
|
|
renderOption={(option) => personOption(option.id) ?? <span className="truncate">{option.label}</span>}
|
|
/>
|
|
</div>
|
|
</div>
|
|
|
|
<div className="flex flex-col gap-2">
|
|
<Label>Secrets</Label>
|
|
{secretsOpen ? (
|
|
<EnvironmentVariablesEditor
|
|
ref={secretsRef}
|
|
onDirtyChange={setSecretsDirty}
|
|
value={(draft.env ?? {}) as Record<string, EnvBinding>}
|
|
secrets={secrets}
|
|
onCreateSecret={onCreateSecret}
|
|
onChange={(env) => patch({ env: env && Object.keys(env).length > 0 ? env : null })}
|
|
footerHint={null}
|
|
hideDraftActions
|
|
startWithEmptyRow
|
|
addLabel="Add secret"
|
|
/>
|
|
) : (
|
|
<Button type="button" variant="outline" size="sm" className="w-fit" onClick={() => setSecretsOpen(true)}>
|
|
<Plus className="h-3.5 w-3.5" />
|
|
Add secret
|
|
</Button>
|
|
)}
|
|
</div>
|
|
</form>
|
|
|
|
<footer className="flex flex-wrap items-center justify-between gap-3 border-t border-border px-6 py-4">
|
|
{confirmingDiscard ? (
|
|
<>
|
|
<p className="text-sm" role="alert">Discard your changes?</p>
|
|
<div className="flex items-center gap-2">
|
|
<Button variant="ghost" onClick={() => setConfirmingDiscard(false)}>Keep editing</Button>
|
|
<Button variant="destructive" onClick={() => onOpenChange(false)}>Discard</Button>
|
|
</div>
|
|
</>
|
|
) : saveConflict ? (
|
|
<>
|
|
<p className="min-w-0 flex-1 text-sm" role="alert">
|
|
This routine changed while you were editing. Reload to see the latest version.
|
|
</p>
|
|
<Button variant="outline" onClick={onReloadLatest}>Reload latest</Button>
|
|
</>
|
|
) : (
|
|
<>
|
|
<Button variant="ghost" onClick={requestClose} disabled={saving}>Cancel</Button>
|
|
<div className="flex min-w-0 items-center gap-3">
|
|
{error ? <p className="min-w-0 text-sm text-destructive" role="alert">{error}</p> : null}
|
|
<Button type="submit" form={`${titleId}-form`} disabled={!canSave}>
|
|
{saving ? "Saving…" : mode === "create" ? "Create routine" : "Save changes"}
|
|
</Button>
|
|
</div>
|
|
</>
|
|
)}
|
|
</footer>
|
|
{children}
|
|
</DialogContent>
|
|
</Dialog>
|
|
);
|
|
}
|