mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-11-03 09:37:19 +01:00
## Thinking Path > - Paperclip helps people manage AI agents and their work. > - People need consistent UI patterns to review and control that work. > - The current board uses related layouts and controls with different spacing, type, and behavior. > - That drift makes it hard for a designer or an agent to build a new page from a reliable reference. > - Storybook can show the shared patterns and the states they need to support. > - This pull request adds design proposals, a local sandbox, and reusable UI controls so people can compare the patterns in context. > - The benefit is a clearer design system that agents can use to build consistent UI. ## Linked Issues or Issue Description **Subsystem affected** `ui/` — React board UI and Storybook. **Problem or motivation** Board pages repeat visual and interaction decisions. Storybook did not provide a complete reference for task views, conversation states, typography, toolbars, tabs, and light/dark colors. People could not compare a proposed pattern with the running board in one place. **Proposed solution** Add a staged Design Proposals catalog with foundations, components, layouts, and page specimens. Add an opt-in sandbox. Reuse production components where possible. Include synthetic conversation states and shared controls so reviewers can compare and refine them. **Alternatives considered** Separate static mockups would not show keyboard behavior, responsive layout, or real component states. Rebuilding each page only in Storybook would allow the reference to drift from the board. **Roadmap alignment** This improves existing board UI and Skills Manager surfaces. It does not add a new control-plane capability. ## What Changed - Added dark and light color references, typography and conversation specimens, and component stories for buttons, tabs, toolbars, sidebar, popovers, activity, and task lists. - Added a local design sandbox with synthetic task conversation playback and representative states. - Shared collection toolbars and navigation patterns across task, agent, project, routine, skill, connector, and artifact pages. - Added the streamlined Skills tabs and a My Skills collection that uses the shared skill cards. - Restored saved-thread access during synthetic playback, kept connector searchbox semantics, and updated reproduction checks after moving trial stories. - Documented the proposed patterns and added focused UI, catalog, and browser checks. ## Verification - `pnpm check:token-gates`, `node scripts/check-maps.mjs`, and `node scripts/storybook-catalog.mjs --check` passed. - Full workspace `pnpm -r typecheck` and `pnpm build` passed after merging master. After the review fixes, focused UI typecheck, `pnpm build-storybook`, 23 Skills Sources tests, and all 15 Storybook typography browser tests passed. - Focused task-thread and system-notice suites passed: 251 tests. Connector Browse passed 84 tests; the connector, attachment, recovery, and Storybook flyout browser journeys passed locally. - A local full Vitest run hit one intermittent chat-channels integration failure; that test passed in isolation. GitHub CI [39347996059](https://github.com/paperclipai/paperclip/actions/runs/39347996059) passed on the exact latest commit: 55 successful checks and two skipped draft-only Storybook jobs. - Greptile reviewed the exact latest commit at 5/5 with no new comments or open review threads. GitHub reports the branch as cleanly mergeable. ## Risks - This PR changes 206 files and exceeds the repository's 100-file review target. Review by commit and consider a scoped split before merge. - Design Proposals are staged references. Fixture interactions do not prove API behavior, permissions, or provider execution. - UI changes to shared controls may affect pages outside the proposal sandbox. Focused browser checks and the full CI matrix passed. ## Model Used - OpenAI Codex, GPT-6 family. The exact runtime model ID and context window are not exposed in this session. The model used reasoning, code execution, browser inspection, and local tests. Earlier branch commits were also AI-assisted in this Codex conversation. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details available in this session) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above where applicable - [x] I have either linked existing issues or described the issue in-PR following the relevant issue template - [x] I have not referenced internal or instance-local Paperclip issues or links - [x] My branch name describes the change and contains no internal ticket id - [x] I have run focused tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Scott Tong <scott@scotts-mbp-m5-max.local> Co-authored-by: Paperclip <noreply@paperclip.ing>
81 lines
5.5 KiB
TypeScript
81 lines
5.5 KiB
TypeScript
import { expect, test, type Page } from "@playwright/test";
|
||
|
||
test.use({ viewport: { width: 1600, height: 1000 } });
|
||
async function openButtons(page: Page, story = "playground") {
|
||
await page.goto(`/iframe.html?id=design-buttons--${story}&viewMode=story&globals=theme:dark`);
|
||
await expect(page.getByTestId("buttons-playground")).toBeVisible();
|
||
return page.getByTestId("proposal-button-samples");
|
||
}
|
||
|
||
test("the playground uses a single sandbox inventory and proposal theme", async ({ page }) => {
|
||
const samples = await openButtons(page);
|
||
await expect(samples.locator("[data-button-variant]")).toHaveCount(7);
|
||
await expect(samples.locator("[data-button-size]")).toHaveCount(8);
|
||
await expect(page.locator(".design-proposal-theme")).toBeVisible();
|
||
await expect(page.locator("iframe")).toHaveCount(0);
|
||
await expect(page.getByRole("region", { name: "Button usage inventory", exact: true })).toHaveCount(0);
|
||
await expect(page.getByLabel("Comparison layout", { exact: true })).toHaveCount(0);
|
||
await expect(page.getByRole("group", { name: "Button playground controls", exact: true })).toHaveCount(1);
|
||
await expect(samples.getByRole("region", { name: "All button variants", exact: true }).locator('[aria-busy="true"]')).toHaveCount(7);
|
||
});
|
||
|
||
test("on-canvas controls update the live sandbox specimen and reset it", async ({ page }) => {
|
||
const samples = await openButtons(page);
|
||
await page.getByLabel("Button label", { exact: true }).fill("Review changes");
|
||
await page.getByLabel("Button variant", { exact: true }).selectOption("cta");
|
||
await page.getByLabel("Button size", { exact: true }).selectOption("sm");
|
||
await page.getByLabel("Button icon", { exact: true }).selectOption("trailing");
|
||
await page.getByLabel("Button state", { exact: true }).selectOption("loading");
|
||
const specimen = samples.getByRole("region", { name: "Live specimen", exact: true });
|
||
const button = specimen.getByRole("button", { name: "Review changes", exact: true });
|
||
await expect(button).toBeDisabled();
|
||
await expect(button).toHaveAttribute("aria-busy", "true");
|
||
await expect(button).toHaveAttribute("data-variant", "cta");
|
||
await expect(button).toHaveAttribute("data-size", "sm");
|
||
await page.getByRole("button", { name: "Reset controls", exact: true }).click();
|
||
await expect(page.getByLabel("Button label", { exact: true })).toHaveValue("Create task");
|
||
await expect(specimen.getByRole("button", { name: "Create task", exact: true })).toBeEnabled();
|
||
});
|
||
|
||
test("sandbox context actions use local state and menus inherit the same theme", async ({ page }) => {
|
||
await openButtons(page);
|
||
const toolbar = page.getByRole("toolbar", { name: "Task list controls" });
|
||
await toolbar.getByRole("button", { name: "Board view", exact: true }).click();
|
||
await expect(toolbar.getByRole("button", { name: "Board view", exact: true })).toHaveAttribute("aria-pressed", "true");
|
||
await toolbar.getByRole("button", { name: "Task view: All tasks", exact: true }).click();
|
||
await page.getByRole("menuitemradio", { name: "Needs attention", exact: true }).click();
|
||
await expect(toolbar.getByRole("button", { name: "Task view: Needs attention", exact: true })).toBeVisible();
|
||
await page.getByRole("button", { name: "Star preview", exact: true }).click();
|
||
await expect(page.getByRole("button", { name: "Unstar preview", exact: true })).toHaveAttribute("aria-pressed", "true");
|
||
await toolbar.getByRole("button", { name: "Filter", exact: true }).click();
|
||
const filters = page.getByRole("dialog", { name: "Filters", exact: true });
|
||
await expect(filters).toHaveCSS("background-color", "rgb(26, 26, 26)");
|
||
const pageBackground = await page.getByTestId("buttons-playground").evaluate(element => getComputedStyle(element).backgroundColor);
|
||
await expect(filters).toHaveCSS("background-color", pageBackground);
|
||
});
|
||
|
||
test("specimens retain real dimensions, state previews and surface controls", async ({ page }, testInfo) => {
|
||
const errors: string[] = [];
|
||
page.on("pageerror", error => errors.push(error.message));
|
||
const samples = await openButtons(page);
|
||
const specimen = samples.getByRole("region", { name: "Live specimen", exact: true });
|
||
await expect(page.getByLabel("Button size", { exact: true }).locator('option[value="sm"]')).toHaveText("Small · 36px high");
|
||
await page.getByLabel("Button variant", { exact: true }).selectOption("cta");
|
||
const button = specimen.getByRole("button", { name: "Create task", exact: true });
|
||
await button.hover();
|
||
await button.evaluate(async element => { await Promise.all(element.getAnimations().map(animation => animation.finished)); });
|
||
const hoveredBackground = await button.evaluate(element => getComputedStyle(element).backgroundColor);
|
||
await page.getByLabel("Button state", { exact: true }).selectOption("hover");
|
||
await expect(button).toHaveCSS("background-color", hoveredBackground);
|
||
await page.getByLabel("Button state", { exact: true }).selectOption("focus-visible");
|
||
await expect(button).not.toHaveCSS("box-shadow", "none");
|
||
await page.getByLabel("Button size", { exact: true }).selectOption("icon-xs");
|
||
await expect(specimen.getByTestId("button-pixel-size")).toHaveText("24 × 24px");
|
||
await expect(button).toHaveAttribute("aria-label", "Create task");
|
||
await page.getByLabel("Button surface", { exact: true }).selectOption("muted");
|
||
await expect(specimen.locator(".bg-muted").first()).toHaveCSS("background-color", "oklch(0.269 0 0)");
|
||
await page.evaluate(() => window.scrollTo(0, 0));
|
||
await page.screenshot({ path: testInfo.outputPath("sandbox-button-workbench.png") });
|
||
expect(errors).toEqual([]);
|
||
});
|