mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-10 20:50:08 +02:00
Nicky LeachandPaperclip
9574cad3e8
## Thinking Path > - Paperclip manages AI work through tasks, comments, and heartbeats > - A heartbeat wake can register after a test body ends > - The low-trust red-team route suite tears down data while that wake can still run > - Teardown can then lock `issues` and `heartbeat_runs` in opposite order and deadlock > - This pull request adds a drain that waits for heartbeat runs to reach quiescence before teardown > - The benefit is stable test teardown without removing coverage ## Linked Issues or Issue Description The serialized low-trust red-team route suite can deadlock in `afterEach` teardown. A heartbeat wake can register after the test body ends. Teardown can then delete `heartbeat_runs` while the wake still writes issue tables. This change waits until no run is queued or running before any delete. ## What Changed - Added `drainHeartbeatRunsToQuiescence` for test teardown. - Called the drain first in the low-trust red-team route suite `afterEach` path. - Kept the change test-teardown only. ## Verification - The author handoff reports `tsc -p server/tsconfig.json --noEmit` as clean. - The author handoff reports 60 of 60 stress-loop runs with zero deadlocks. - `pnpm --filter @paperclipai/server typecheck` could not run here because this workspace lacks `node_modules/typescript/bin/tsc`. ## Risks - Low risk. - The change only affects test teardown. - If a wake never reaches registration, the drain can wait longer than expected. - The loop re-checks the run table until no run is queued or running. ## Model Used OpenAI GPT-5, tool-use, 256k context. ## Checklist - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>