mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-28 04:02:18 +01:00
## Thinking Path > - Paperclip is the open source control plane people use to manage AI agents for work > - Agent runs depend on adapters translating Paperclip configuration into each agent runtime's native configuration > - The OpenCode local adapter passes configured models through the `--model provider/model` argument > - OpenCode only resolves that argument when the model id exists in the provider's runtime `models` map > - Valid provider-served model ids missing from OpenCode's bundled catalog therefore fail locally with `Model not found` > - This pull request registers the configured model in the injected runtime configuration without overwriting explicit provider definitions > - The benefit is that uncataloged routing variants and newly released models resolve while cataloged models retain their metadata ## Linked Issues or Issue Description ### Pre-submission checklist - [x] I have searched existing open and closed issues and this is not a duplicate. - [x] I can reproduce this on current `master`. - [x] I have confirmed the error originates in Paperclip's OpenCode adapter rather than the provider or local configuration. ### What happened? OpenCode local runs failed with `Model not found` when a configured `provider/model` id was valid at the provider but absent from OpenCode's bundled model catalog. OpenRouter routing variants such as model ids ending in `:nitro` are one example. ### Expected behavior Any configured provider-served model id should resolve when Paperclip starts OpenCode, including ids not yet present in the bundled catalog. ### Steps to reproduce 1. Configure the OpenCode local adapter with a valid provider/model id that is absent from OpenCode's bundled catalog. 2. Start an agent run. 3. Observe that OpenCode rejects the `--model` value with `Model not found` before the session starts. ### Paperclip version or commit Current `master` before this change. ### Deployment mode Local dev using the OpenCode local adapter and an existing provider API key. ### Installation method Built from source. ### Agent adapter(s) involved OpenCode local. ### Database mode Not database-related. ### Relevant logs or output `Model not found` ### Additional context Reproduced with OpenCode 1.15.5. No duplicate or related public GitHub issues or pull requests were found. ### Privacy checklist - [x] I have reviewed all pasted output for sensitive information and no secrets or PII are included. ## What Changed - Register the configured `provider/model` id as an empty custom model entry in the injected `opencode.json` provider configuration. - Preserve explicit model definitions from user configuration and `PAPERCLIP_OPENCODE_PROVIDERS`. - Skip registration for model strings that do not use the `provider/model` form. - Add focused coverage for uncataloged models, explicit definitions, and invalid model strings. ## Verification - `cd packages/adapters/opencode-local && pnpm exec vitest run src/server/runtime-config.test.ts` — 14 tests passed. - `cd packages/adapters/opencode-local && pnpm exec tsc --noEmit` — passed. - Manual reproduction with OpenCode 1.15.5: the uncataloged OpenRouter routing variant fails without the injected model entry and resolves with it. ## Risks - Low risk: the empty entry deep-merges with catalog metadata for known models, and existing explicit model definitions take precedence. - The behavior is limited to syntactically valid `provider/model` configuration values in the OpenCode local adapter. > For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and discuss it in `#dev` before opening the PR. Feature PRs that overlap with planned core work may need to be redirected — check the roadmap first. See `CONTRIBUTING.md`. ## Model Used - OpenAI Codex, exact runtime model `gpt-5.6-sol` (context-window size not exposed by the runtime), with reasoning, tool use, terminal execution, and code-editing capabilities. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge Co-authored-by: Paperclip <noreply@paperclip.ing>
243 lines
9.6 KiB
TypeScript
243 lines
9.6 KiB
TypeScript
import fs from "node:fs/promises";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
import { asBoolean } from "@paperclipai/adapter-utils/server-utils";
|
|
|
|
type PreparedOpenCodeRuntimeConfig = {
|
|
env: Record<string, string>;
|
|
notes: string[];
|
|
cleanup: () => Promise<void>;
|
|
};
|
|
|
|
function resolveXdgConfigHome(env: Record<string, string>): string {
|
|
return (
|
|
(typeof env.XDG_CONFIG_HOME === "string" && env.XDG_CONFIG_HOME.trim()) ||
|
|
(typeof process.env.XDG_CONFIG_HOME === "string" && process.env.XDG_CONFIG_HOME.trim()) ||
|
|
path.join(os.homedir(), ".config")
|
|
);
|
|
}
|
|
|
|
function isPlainObject(value: unknown): value is Record<string, unknown> {
|
|
return typeof value === "object" && value !== null && !Array.isArray(value);
|
|
}
|
|
|
|
// Recursively replace {env:VAR} placeholders with the resolved value. Used to bake
|
|
// gateway provider secrets (e.g. the LLM-gateway virtual key) into opencode.json
|
|
// SERVER-SIDE, where the value is reliably present. OpenCode's own {env:...}
|
|
// resolution happens inside the (possibly sandboxed) run process, whose env
|
|
// plumbing is not guaranteed to carry the key to OpenCode's spawned server -- so
|
|
// we resolve it here. Unresolvable placeholders are left intact for OpenCode to try.
|
|
function expandEnvPlaceholders<T>(value: T, resolve: (name: string) => string | undefined): T {
|
|
if (typeof value === "string") {
|
|
return value.replace(/\{env:([A-Za-z_][A-Za-z0-9_]*)\}/g, (match, name: string) => {
|
|
const resolved = resolve(name);
|
|
return resolved !== undefined && resolved.length > 0 ? resolved : match;
|
|
}) as unknown as T;
|
|
}
|
|
if (Array.isArray(value)) {
|
|
return value.map((entry) => expandEnvPlaceholders(entry, resolve)) as unknown as T;
|
|
}
|
|
if (isPlainObject(value)) {
|
|
const out: Record<string, unknown> = {};
|
|
for (const [key, entry] of Object.entries(value)) {
|
|
out[key] = expandEnvPlaceholders(entry, resolve);
|
|
}
|
|
return out as unknown as T;
|
|
}
|
|
return value;
|
|
}
|
|
|
|
function parseProviderConfig(
|
|
raw: unknown,
|
|
resolveEnv: (name: string) => string | undefined,
|
|
notes: string[],
|
|
): Record<string, unknown> | null {
|
|
if (typeof raw !== "string" || raw.trim().length === 0) return null;
|
|
let parsed: unknown;
|
|
try {
|
|
parsed = JSON.parse(raw);
|
|
} catch {
|
|
// Surface the misconfiguration instead of silently dropping the provider
|
|
// block; an unparseable value would otherwise be undiagnosable.
|
|
notes.push("PAPERCLIP_OPENCODE_PROVIDERS contains invalid JSON; custom providers ignored.");
|
|
return null;
|
|
}
|
|
if (!isPlainObject(parsed)) {
|
|
notes.push(
|
|
"PAPERCLIP_OPENCODE_PROVIDERS is set but is not a JSON object; custom providers ignored.",
|
|
);
|
|
return null;
|
|
}
|
|
// Only keep provider entries that are themselves objects; surface the ones
|
|
// we drop so a malformed entry is just as diagnosable as malformed JSON.
|
|
const providers: Record<string, unknown> = {};
|
|
const skipped: string[] = [];
|
|
for (const [key, value] of Object.entries(parsed)) {
|
|
if (isPlainObject(value)) providers[key] = expandEnvPlaceholders(value, resolveEnv);
|
|
else skipped.push(key);
|
|
}
|
|
if (skipped.length > 0) {
|
|
notes.push(
|
|
`PAPERCLIP_OPENCODE_PROVIDERS: skipped provider(s) with non-object values: ${skipped.join(", ")}.`,
|
|
);
|
|
}
|
|
return Object.keys(providers).length > 0 ? providers : null;
|
|
}
|
|
|
|
function parseConfiguredModelRef(raw: unknown): { provider: string; model: string } | null {
|
|
if (typeof raw !== "string") return null;
|
|
const trimmed = raw.trim();
|
|
const slash = trimmed.indexOf("/");
|
|
if (slash <= 0 || slash === trimmed.length - 1) return null;
|
|
return { provider: trimmed.slice(0, slash), model: trimmed.slice(slash + 1) };
|
|
}
|
|
|
|
async function readJsonObject(filepath: string): Promise<Record<string, unknown>> {
|
|
try {
|
|
const raw = await fs.readFile(filepath, "utf8");
|
|
const parsed = JSON.parse(raw);
|
|
return isPlainObject(parsed) ? parsed : {};
|
|
} catch {
|
|
return {};
|
|
}
|
|
}
|
|
|
|
export async function prepareOpenCodeRuntimeConfig(input: {
|
|
env: Record<string, string>;
|
|
config: Record<string, unknown>;
|
|
targetIsRemote?: boolean;
|
|
}): Promise<PreparedOpenCodeRuntimeConfig> {
|
|
const skipPermissions = asBoolean(input.config.dangerouslySkipPermissions, true);
|
|
if (!skipPermissions) {
|
|
return {
|
|
env: input.env,
|
|
notes: [],
|
|
cleanup: async () => {},
|
|
};
|
|
}
|
|
|
|
// For remote execution targets the host XDG_CONFIG_HOME path is meaningless
|
|
// (and actively harmful — it leaks a macOS-only path into the remote Linux
|
|
// env). Callers that need to ship a runtime opencode config to the remote
|
|
// box do that via prepareAdapterExecutionTargetRuntime in execute.ts; this
|
|
// host-fs helper is local-only.
|
|
if (input.targetIsRemote) {
|
|
return {
|
|
env: input.env,
|
|
notes: [],
|
|
cleanup: async () => {},
|
|
};
|
|
}
|
|
|
|
const sourceConfigDir = path.join(resolveXdgConfigHome(input.env), "opencode");
|
|
const runtimeConfigHome = await fs.mkdtemp(path.join(os.tmpdir(), "paperclip-opencode-config-"));
|
|
const runtimeConfigDir = path.join(runtimeConfigHome, "opencode");
|
|
const runtimeConfigPath = path.join(runtimeConfigDir, "opencode.json");
|
|
|
|
await fs.mkdir(runtimeConfigDir, { recursive: true });
|
|
try {
|
|
await fs.cp(sourceConfigDir, runtimeConfigDir, {
|
|
recursive: true,
|
|
force: true,
|
|
errorOnExist: false,
|
|
dereference: false,
|
|
});
|
|
} catch (err) {
|
|
if ((err as NodeJS.ErrnoException | null)?.code !== "ENOENT") {
|
|
throw err;
|
|
}
|
|
}
|
|
|
|
const existingConfig = await readJsonObject(runtimeConfigPath);
|
|
const existingPermission = isPlainObject(existingConfig.permission)
|
|
? existingConfig.permission
|
|
: {};
|
|
const notes = [
|
|
"Injected runtime OpenCode config with permission.external_directory=allow to avoid headless approval prompts.",
|
|
];
|
|
|
|
// Merge gateway/custom provider definitions supplied via PAPERCLIP_OPENCODE_PROVIDERS
|
|
// (a JSON object in OpenCode's `provider` shape). OpenCode resolves a `--model
|
|
// provider/model` only when that model exists in a provider's `models` map, and
|
|
// OPENCODE_ALLOW_ALL_MODELS does NOT bypass its internal getModel(). So routing a
|
|
// gateway model (e.g. an EU LLM gateway exposing OpenAI-compatible /v1) requires a
|
|
// custom provider with an explicit models map. We accept it as config (not
|
|
// hard-coded) so the gateway URL, key env, and model list stay declarative.
|
|
const resolveEnv = (name: string): string | undefined => input.env[name] ?? process.env[name];
|
|
const gatewayProviders = parseProviderConfig(
|
|
input.env.PAPERCLIP_OPENCODE_PROVIDERS ?? process.env.PAPERCLIP_OPENCODE_PROVIDERS,
|
|
resolveEnv,
|
|
notes,
|
|
);
|
|
const existingProvider = isPlainObject(existingConfig.provider) ? existingConfig.provider : {};
|
|
let nextProvider = gatewayProviders
|
|
? { ...existingProvider, ...gatewayProviders }
|
|
: existingProvider;
|
|
if (gatewayProviders) {
|
|
notes.push(
|
|
`Injected ${Object.keys(gatewayProviders).length} custom OpenCode provider(s) from PAPERCLIP_OPENCODE_PROVIDERS: ${Object.keys(gatewayProviders).join(", ")}.`,
|
|
);
|
|
}
|
|
|
|
// Register the configured model on its provider's models map. OpenCode resolves
|
|
// `--model provider/model` only when the model id exists in that map, so ids the
|
|
// models.dev catalog does not carry — OpenRouter routing variants such as
|
|
// `openai/gpt-oss-120b:nitro`, or models newer than the bundled catalog — are
|
|
// otherwise rejected with "Model not found" even though the provider serves them.
|
|
// An empty entry deep-merges with catalog metadata, so this is a no-op for models
|
|
// the catalog already knows, and we never clobber an explicit definition from the
|
|
// user config or PAPERCLIP_OPENCODE_PROVIDERS.
|
|
const configuredModel = parseConfiguredModelRef(input.config.model);
|
|
if (configuredModel) {
|
|
const providerEntry = isPlainObject(nextProvider[configuredModel.provider])
|
|
? { ...(nextProvider[configuredModel.provider] as Record<string, unknown>) }
|
|
: {};
|
|
const providerModels = isPlainObject(providerEntry.models)
|
|
? { ...(providerEntry.models as Record<string, unknown>) }
|
|
: {};
|
|
if (!isPlainObject(providerModels[configuredModel.model])) {
|
|
providerModels[configuredModel.model] = {};
|
|
providerEntry.models = providerModels;
|
|
nextProvider = { ...nextProvider, [configuredModel.provider]: providerEntry };
|
|
notes.push(
|
|
`Registered configured model ${configuredModel.provider}/${configuredModel.model} in the runtime OpenCode config.`,
|
|
);
|
|
}
|
|
}
|
|
|
|
const nextConfig: Record<string, unknown> = {
|
|
...existingConfig,
|
|
permission: {
|
|
...existingPermission,
|
|
external_directory: "allow",
|
|
},
|
|
};
|
|
if (Object.keys(nextProvider).length > 0) {
|
|
nextConfig.provider = nextProvider;
|
|
}
|
|
|
|
// Pin OpenCode's auxiliary "small" model (used for session-title generation and
|
|
// other helper tasks) via PAPERCLIP_OPENCODE_SMALL_MODEL. OpenCode otherwise
|
|
// defaults the small model to a built-in provider default (e.g. a claude-* model
|
|
// for the anthropic provider); when that provider is repointed at a gateway that
|
|
// does not serve that exact model, the title-gen call fails and aborts the run.
|
|
// Setting small_model to a gateway-served model keeps every call on supported models.
|
|
const smallModel = (input.env.PAPERCLIP_OPENCODE_SMALL_MODEL ?? process.env.PAPERCLIP_OPENCODE_SMALL_MODEL)?.trim();
|
|
if (smallModel) {
|
|
nextConfig.small_model = smallModel;
|
|
notes.push(`Pinned OpenCode small_model to ${smallModel}.`);
|
|
}
|
|
await fs.writeFile(runtimeConfigPath, `${JSON.stringify(nextConfig, null, 2)}\n`, "utf8");
|
|
|
|
return {
|
|
env: {
|
|
...input.env,
|
|
XDG_CONFIG_HOME: runtimeConfigHome,
|
|
},
|
|
notes,
|
|
cleanup: async () => {
|
|
await fs.rm(runtimeConfigHome, { recursive: true, force: true });
|
|
},
|
|
};
|
|
}
|