Files
PaperClipAI/packages/adapters/codex-local/src/server/codex-auth-copyback.ts
T
Nicky LeachandPaperclip 7e592c33fa feat(codex): add identity-keyed host credential cache (#10853)
## Thinking Path

> - Paperclip manages agent work as issues and pull requests.
> - This change lives in the Codex local adapter path.
> - The host auth flow needs a stable cache per identity.
> - The cache must not change the copy-back path or the default store
overwrite.
> - This pull request adds that cache and keeps the existing flow
intact.
> - The benefit is repeatable host auth with safer identity scoping.

## Linked Issues or Issue Description

**Subsystem affected**
- packages/adapters: Codex local adapter and host auth flow

**Problem or motivation**
- The host auth flow needs one usable credential per identity.
- The current flow does not keep that identity state in a separate
cache.

**Proposed solution**
- Add an identity-keyed host credential cache.
- Keep the cache company scoped.
- Add an opt-in seed mode for the merge decision helper.
- Write the cache at copy-back time without changing the default store
overwrite.

**Alternatives considered**
- Store the cache in the instance-global root.
- Seed the host default store through an environment flag.
- Both choices weaken isolation or caller control, so I did not use
them.

**Roadmap alignment**
- I checked `ROADMAP.md`.
- I found no direct overlap with an active roadmap item.
- The change fits the core auth and secrets direction.

**Additional context**
- Local tests passed before I opened this pull request.
- I found no direct duplicate pull request for this branch.

## What Changed

- Added `codex-auth-cache.ts` for company scoped cache storage and
identity anchored vending.
- Added `codex-auth-merge-decision.cjs` support for a leading
`--seed-if-dest-absent` flag.
- Updated `codex-auth-copyback.ts` to write the cache at teardown under
the merge lock.
- Wired `execute.ts` to use the identity anchored vend before the
managed home seed step.
- Added `CODEX-AUTH-CACHE.md` for the cache rules, directions, state
matrix, off switch, and clear action.
- Added and updated tests for cache behavior, merge decision flow, and
copy-back flow.

## Verification

- `pnpm --filter @paperclipai/adapter-codex-local exec vitest run`.
- `node_modules/.bin/vitest run --project @paperclipai/adapter-utils
workspace-restore-merge`.
- `tsc --noEmit` in `packages/adapters/codex-local`.
- `git log --oneline
origin/master..origin/feat/codex-auth-identity-cache` shows the expected
commits.

## Risks

- This change touches credential storage.
- A mistake in the cache path could break host auth for one identity.
- The tests reduce this risk, but the surface stays sensitive.

## Model Used

- OpenAI Codex, GPT-5, tool use enabled.

## Checklist

- [x] I have included a thinking path that traces from project context
to this change
- [x] I have specified the model used with version and capability
details
- [x] I have checked ROADMAP.md and confirmed this PR does not duplicate
planned core work
- [x] I have searched GitHub for duplicate or related PRs and linked
them above
- [x] I have either linked existing issues with `Fixes:` / `Closes:` /
`Refs:` or described the issue in the pull request body
- [x] I have not referenced internal or instance-local Paperclip issues
or links
- [x] My branch name describes the change and contains no internal
Paperclip ticket id or instance-derived details
- [x] I have run tests locally and they pass
- [x] I have added or updated tests where applicable
- [x] I have updated relevant documentation to reflect my changes
- [x] I have considered and documented any risks above
- [x] All Paperclip CI gates are green
- [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups
- [x] I will address all Greptile and reviewer comments before
requesting merge

---------

Co-authored-by: Paperclip <noreply@paperclip.ing>
2026-08-04 16:33:54 -07:00

212 lines
10 KiB
TypeScript

import { execFile as execFileCallback } from "node:child_process";
import { mkdir, open, rename, rm } from "node:fs/promises";
import path from "node:path";
import { fileURLToPath } from "node:url";
import { promisify } from "node:util";
import { randomUUID } from "node:crypto";
import { withDirectoryMergeLock } from "@paperclipai/adapter-utils/workspace-restore-merge";
import {
isCodexAuthCacheEnabled,
readSubscriptionAccountId,
writeCodexAuthCacheEntry,
} from "./codex-auth-cache.js";
const execFile = promisify(execFileCallback);
// The outbound copy-back reuses the exact same direction-agnostic decision
// predicate the inbound restore runs (`codex-auth-merge-decision.cjs`). The
// predicate answers one question — "should the caller replace `destination`
// with `source`?" — purely by argument order (first = source, second =
// destination). For the copy-back the sandbox credential is the `source` and
// the shared host credential is the `destination`, so exit 10 (use source)
// means "install the sandbox copy onto the host" and exit 20 (keep destination)
// means "leave the host copy untouched". The predicate only ever reads the two
// files and exits with a code; it never prints token bytes.
const DECISION_SCRIPT_PATH = fileURLToPath(
new URL("./codex-auth-merge-decision.cjs", import.meta.url),
);
const USE_SOURCE_EXIT = 10;
const KEEP_DESTINATION_EXIT = 20;
/** Outcome of a copy-back attempt. No token material is ever surfaced. */
export type CopyBackCodexAuthOutcome = "copied" | "kept-host";
export interface CopyBackCodexAuthInput {
/**
* Reads the sandbox `auth.json` bytes back from the (about-to-be-destroyed)
* sandbox. In production this is bound to the managed-runtime restore
* context's `readFile` for `${assetDir}/auth.json`.
*/
readSandboxAuth: () => Promise<Buffer>;
/**
* Absolute path of the shared host credential to (maybe) overwrite — the
* symlink *source* the managed Codex homes point their `auth.json` at, never
* an in-sandbox or per-agent symlink.
*/
hostAuthPath: string;
/** Non-leaking progress sink: receives decision/outcome lines only. */
log: (line: string) => void | Promise<void>;
/**
* Resolves and ensures the per-identity cache slot path for a sandbox
* `account_id`. When this is provided AND the cache off-switch is on, the
* copy-back also writes the fresher, usable subscription credential into its
* per-identity cache slot as a second, additive write, keyed by the real
* `account_id`. This is independent of the host default overwrite: it can
* write a cache slot for a different identity than the host holds (matrix rows
* 1b, 3), and it never touches the host default store. When absent, no cache
* write happens.
*/
resolveCacheEntryPath?: (accountId: string) => Promise<string>;
/** Environment for the cache off-switch read. Defaults to `process.env`. */
env?: NodeJS.ProcessEnv;
}
async function decideExitCode(sourcePath: string, destinationPath: string): Promise<number> {
try {
await execFile("node", [DECISION_SCRIPT_PATH, sourcePath, destinationPath]);
} catch (error) {
const code = (error as { code?: unknown }).code;
if (code === USE_SOURCE_EXIT || code === KEEP_DESTINATION_EXIT) {
return code;
}
// A non-numeric `code` (e.g. "ENOENT" when node is not on PATH) or any exit
// code other than 10/20 is a hard failure — fail loud so a broken predicate
// is never mistaken for a "keep host" decision.
const detail =
typeof code === "string"
? `node could not be executed (${code})`
: typeof code === "number"
? `unexpected predicate exit code ${code}`
: error instanceof Error
? error.message
: String(error);
throw new Error(`codex auth copy-back decision predicate failed: ${detail}`);
}
// Reached only when `execFile` resolved — i.e. the predicate exited 0. The
// predicate always exits 10 or 20, so a clean exit 0 is unexpected; throw
// directly here, outside the try/catch, so this already self-explanatory
// message is not re-wrapped by the catch's "...failed:" prefix.
throw new Error("codex auth copy-back decision predicate exited 0 (expected 10 or 20)");
}
/**
* Guards, locks, and atomically installs a strictly-newer sandbox Codex
* `auth.json` onto the shared host credential at teardown.
*
* Sequence, all under `withDirectoryMergeLock` on the host target's directory
* so a concurrent inbound restore or another copy-back can't interleave:
* 1. Read the sandbox credential bytes. A genuinely absent sandbox
* `auth.json` (ENOENT) means there is simply nothing to copy back, so it
* resolves to `kept-host` (benign no-op, host untouched); every other read
* error stays fail-loud.
* 2. Stage them to a `0600` temp file on the **same filesystem** as the host
* target (its directory), which doubles as the predicate `source`.
* 3. Run the Phase-3 decision predicate (`source` = sandbox temp, `destination`
* = host). Exit 10 → adopt the sandbox copy; exit 20 → keep the host copy.
* 4. On exit 10, `rename` the staged temp over the host target — an atomic
* same-directory swap that preserves mode `0600`. On exit 20, discard it.
* The staged temp is always removed (rename consumes it on the copy path; the
* finally cleans it up otherwise), so a failure never leaves a partial file.
* Never logs token bytes — only the decision outcome.
*/
export async function copyBackCodexAuth(input: CopyBackCodexAuthInput): Promise<CopyBackCodexAuthOutcome> {
const { readSandboxAuth, hostAuthPath, log, resolveCacheEntryPath, env } = input;
// Read first (outside the lock) — a read never mutates the host, so there is
// nothing to serialize yet. A genuinely absent sandbox `auth.json` (ENOENT —
// e.g. Codex removed it mid-run, or a non-provisioned edge) is a "nothing to
// copy back" no-op, not a teardown failure: return `kept-host` and log the
// benign outcome. Every other read error stays fail-loud so a real read fault
// is never silently mistaken for "nothing to copy back".
let sandboxAuthBytes: Buffer;
try {
sandboxAuthBytes = await readSandboxAuth();
} catch (error) {
if ((error as NodeJS.ErrnoException | null)?.code === "ENOENT") {
await log(
"[paperclip] Codex auth copy-back: no sandbox credential to copy back (absent auth.json); host credential kept.",
);
return "kept-host";
}
throw error;
}
const hostDir = path.dirname(hostAuthPath);
await mkdir(hostDir, { recursive: true });
const hostOutcome = await withDirectoryMergeLock(hostDir, async () => {
// Stage on the same filesystem as the host target so both the predicate read
// and the final rename stay device-local (rename across devices is not
// atomic and would fail with EXDEV).
const stagedTempPath = path.join(hostDir, `.auth.json.copyback-${process.pid}-${randomUUID()}.tmp`);
// `wx` + explicit mode create the temp private (0600) and fail if it somehow
// already exists, so we never write through a pre-existing symlink.
const handle = await open(stagedTempPath, "wx", 0o600);
try {
await handle.writeFile(sandboxAuthBytes);
await handle.close();
const decision = await decideExitCode(stagedTempPath, hostAuthPath);
if (decision === USE_SOURCE_EXIT) {
// Atomic same-directory swap; rename preserves the temp's 0600 mode.
await rename(stagedTempPath, hostAuthPath);
await log(
"[paperclip] Codex auth copy-back: sandbox credential is strictly newer for the same subscription identity; installed to the host at mode 0600.",
);
return "copied";
}
await log(
"[paperclip] Codex auth copy-back: host credential kept (sandbox copy is not a strictly-newer same-identity subscription credential).",
);
return "kept-host";
} finally {
// Close is idempotent-safe to skip after an explicit close; the temp is the
// thing that must never linger. On the copy path rename already consumed it
// (force makes the removal a no-op); on every other path this deletes the
// staged credential bytes.
await handle.close().catch(() => undefined);
await rm(stagedTempPath, { force: true }).catch(() => undefined);
}
});
// Additive cache write. Independent of the host default overwrite above: it
// runs on its own directory lock, keys the slot by the real sandbox
// `account_id`, and can write a slot for a different identity than the host
// holds. It never touches the host default store. The off-switch (default on)
// makes this a no-op when disabled. Only a usable subscription credential has
// an identity to key; an api-key or unusable sandbox credential is skipped.
//
// The cache write is best-effort. The host copy-back above already finished
// and set `hostOutcome`, so a failure of this additive write must not replace
// that successful result. Catch the error, log it, and return `hostOutcome`.
// The cache stays a hint: the next teardown re-attempts the write.
if (resolveCacheEntryPath && isCodexAuthCacheEnabled(env)) {
try {
const sandboxAccountId = readSubscriptionAccountId(sandboxAuthBytes);
if (sandboxAccountId) {
const cacheEntryPath = await resolveCacheEntryPath(sandboxAccountId);
await writeCodexAuthCacheEntry({ sandboxAuthBytes, cacheEntryPath, log });
}
} catch (error) {
// Log only the errno code, never the error message. The message embeds the
// cache slot path, and the slot path embeds the raw `account_id`; the code
// (for example EACCES or ENOSPC) makes the failure diagnosable without a
// leak. Token bytes never reach the log.
const code = (error as NodeJS.ErrnoException | null)?.code ?? "unknown";
// The host copy-back above already finished and set `hostOutcome`. This
// diagnostic log is the last step, so a rejecting logger must not throw
// and turn that successful result into a failed copy-back. Guard the log:
// a rejection here is swallowed, and the function still returns
// `hostOutcome` below.
await Promise.resolve(
log(
`[paperclip] Codex auth cache: additive cache write failed (${code}); host copy-back result kept.`,
),
).catch(() => undefined);
}
}
return hostOutcome;
}