mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-11-05 12:29:37 +01:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work. > - The feature map describes product areas and verification entry points. > - Storybook has 223 story suites that show production components, proposals, and retained history. > - The parent PR maps those suites to features, but their folders and sidebar still use unrelated groups. > - This pull request puts the existing suites under feature folders and uses the feature map's names and order in the sidebar. > - Explicit meta IDs preserve existing story links while the titles change. > - Contributors can find stories through the same product structure without losing examples. ## Linked Issues or Issue Description Refs #16046. This is the requested follow-up. Parent #16046 is merged. This PR now targets master, with its single follow-up commit rebased onto the parent squash merge. The Storybook implementation is unchanged by that rebase. Related open Storybook PRs were checked; this change organizes existing suites and adds no product capability. ## What Changed - Move all 223 story files into folders named for their primary feature area. Keep useful scenario groups below the feature's sidebar label. - Order the sidebar by the eight feature-map sections. Put Overview first and shared Foundations last. Leave areas with no stories out of the sidebar. - Move 19 support files into `ui/storybook/support/` and update relative imports and active documentation. - Preserve all 2,210 story IDs and the single docs ID through explicit CSF meta IDs. Keep all entry names and story exports. - Record stable IDs and sidebar titles in the downstream catalog. Validate feature folders, title prefixes, and IDs. Update the maintenance skill and review evidence. ## Verification - Storybook build passed. Built index comparison against parent `75bd3c977cd828d5222823850339e8204f40eb47` found the same 2,211 entries, IDs, and names. - UI typecheck passed (`ui/node_modules/.bin/tsc -b` from `ui`, invoked as `./node_modules/.bin/tsc -b`). - UI Vitest project: 728 files and 8,176 tests passed. - Catalog checker and its nine tests passed. Feature-map checks, token gates, and the maintenance-skill validator passed. - Chromium: nine existing play cases and one render case reached `storyFinished: success` with no page exceptions. The guide rendered, sidebar sections followed map order, and a search for `steering/queue` opened its preserved story link. - Source comparison found only meta title/ID changes, rebased relative references, and updated fixture path text in story files. - To inspect: build Storybook, start `node scripts/serve-storybook-static.mjs --port 6136`, and open the Overview guide. Expand feature folders and use existing story links. - The complete repository suite was not repeated for this organization change. The parent records a backend timeout that passed in isolation, without a complete broad-suite pass. Visual comparisons remain blocked by the unpublished empty baseline. The separate fixture-server story was not run. ## Risks - Open branches that add stories under old paths will need to choose a feature folder and update the catalog. Cross-feature suites have one primary home and retain related capability references. - Sidebar paths change; story and docs IDs remain stable. Automated references to source paths may need the new location. - This is one requested follow-up with 258 changed files, mostly moves. It exceeds the usual review-size guideline because splitting it would leave the sidebar and folder convention partly migrated. - Browser verification samples ten stories, not all 2,210. Existing production/prototype classifications and review gaps remain unchanged. - Required CI gates and a 5/5 review passed on the original head. Fresh checks and review are running for the rebased head. Catalog validation and all nine checker tests passed after rebase; UI, map, skill, and checker contents are identical to the original reviewed head. ## Model Used - OpenAI Codex, GPT-6. The exact runtime model ID and context-window size are not exposed in this session. Used reasoning, repository inspection, code execution, and local browser automation. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [ ] All Paperclip CI gates are green - [ ] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge Co-authored-by: Paperclip <noreply@paperclip.ing>
185 lines
8.6 KiB
TypeScript
185 lines
8.6 KiB
TypeScript
import { useLayoutEffect, useState, type ReactNode } from "react";
|
|
import { QueryClient, QueryClientProvider } from "@tanstack/react-query";
|
|
import { queryKeys } from "@/lib/queryKeys";
|
|
import { buildSkillMentionHref } from "@paperclipai/shared";
|
|
import { EditorAutocompleteProvider } from "@/context/EditorAutocompleteContext";
|
|
import {
|
|
endpoint,
|
|
agent,
|
|
configuration,
|
|
resources,
|
|
reviews,
|
|
conversations,
|
|
links,
|
|
members,
|
|
} from "./fixtures";
|
|
|
|
export type FixtureState = "populated" | "empty" | "loading" | "error" | "long" | "many" | "setup" | "skills" | "guests" | "mentions";
|
|
const reviewSkill = {
|
|
id: "11111111-1111-4111-8111-111111111111", slug: "code-review", name: "Code review",
|
|
key: "company/company-storybook/code-review", description: "Follow the team's review playbook.",
|
|
};
|
|
/** Only fixture IDs are intercepted. All shell requests use Storybook's shared API fixtures. */
|
|
export function FixtureApi({
|
|
state = "populated",
|
|
children,
|
|
}: {
|
|
state?: FixtureState;
|
|
children: ReactNode;
|
|
}) {
|
|
const [client] = useState(() => {
|
|
const client = new QueryClient({
|
|
defaultOptions: { queries: { retry: false, staleTime: Infinity } },
|
|
});
|
|
client.setQueryData(queryKeys.chatEndpoints.detail(endpoint.id), endpoint);
|
|
client.setQueryData(queryKeys.agents.detail(agent.id), agent);
|
|
client.setQueryData(["github-setup", endpoint.id], state === "setup"
|
|
? { ...endpoint, status: "draft", setup: { github: { stage: "setup" } } } : endpoint);
|
|
client.setQueryData(["github-wizard", endpoint.id], { endpointId: endpoint.id, state: state === "setup" ? "create" : "connected" });
|
|
client.setQueryData(queryKeys.chatEndpoints.list(endpoint.companyId), [endpoint]);
|
|
client.setQueryData(["project-repositories", endpoint.companyId], {
|
|
repositories: [
|
|
{ id: "100", fullName: "acme/web", ownerType: "organization", url: "https://github.com/acme/web", connections: ["GitHub"] },
|
|
{ id: "101", fullName: "paperclipai/api", ownerType: "organization", url: "https://github.com/paperclipai/api", connections: ["GitHub"] },
|
|
{ id: "102", fullName: "mayacoder/site", ownerType: "personal", url: "https://github.com/mayacoder/site", connections: ["GitHub"] },
|
|
], connectionCount: 1, failedConnectionCount: 0,
|
|
});
|
|
client.setQueryData(["github-members", endpoint.companyId], members);
|
|
client.setQueryData(queryKeys.companySkills.list(endpoint.companyId), [reviewSkill]);
|
|
return client;
|
|
});
|
|
const [ready, setReady] = useState(false);
|
|
useLayoutEffect(() => {
|
|
const original = window.fetch;
|
|
let saved = { revision: 2, configuration: structuredClone(configuration) };
|
|
if (state === "skills") saved.configuration.defaults = {
|
|
...saved.configuration.defaults,
|
|
instructions: `Use [/code-review](${buildSkillMentionHref(reviewSkill.id, reviewSkill.slug)}) when reviewing pull requests.`,
|
|
invocation: "linked_authors",
|
|
};
|
|
if (state === "guests") saved.configuration.people.push({ kind: "guest", githubUserId: "99", login: "community-contributor", sponsorUserId: "user-board", permissionProfile: "restricted", automaticReviews: true });
|
|
if (state === "mentions") { saved.configuration.memberAccess = "all_linked"; saved.configuration.defaults.invocation = "mentions_only"; }
|
|
let repos = structuredClone(resources);
|
|
if (state === "many") repos = Array.from({ length: 1000 }, (_, index) => ({
|
|
...repos[0], id: `repository-${index}`, providerResourceId: `acme/repository-${String(index).padStart(4, "0")}`,
|
|
label: `acme/repository-${String(index).padStart(4, "0")}`, enabled: true,
|
|
}));
|
|
let identities = structuredClone(links);
|
|
const failedPaths = new Set<string>();
|
|
window.fetch = async (input, init) => {
|
|
const raw =
|
|
typeof input === "string"
|
|
? input
|
|
: input instanceof URL
|
|
? input.href
|
|
: input.url;
|
|
const url = new URL(raw, window.location.origin);
|
|
const path = url.pathname;
|
|
if (!path.includes(`/chat-endpoints/${endpoint.id}`))
|
|
return original(input, init);
|
|
if (state === "loading") return new Promise<Response>(() => {});
|
|
if (
|
|
state === "error" &&
|
|
(path.endsWith("/configuration") || path.endsWith("/resources") || path.endsWith("/github/repositories")) &&
|
|
!failedPaths.has(path)
|
|
) {
|
|
failedPaths.add(path);
|
|
return Response.json(
|
|
{ error: "Could not reach GitHub. Try again." },
|
|
{ status: 503 },
|
|
);
|
|
}
|
|
const body = init?.body ? JSON.parse(String(init.body)) : {};
|
|
if (path.endsWith("/github/setup")) return Response.json({ endpointId: endpoint.id, state: state === "setup" ? "create" : "connected" });
|
|
if (path.endsWith("/repositories/access")) {
|
|
repos = repos.map((r) => (!body.enabled || r.availability === "available") ? { ...r, enabled: body.enabled } : r);
|
|
return Response.json({ success: true });
|
|
}
|
|
if (path.endsWith("/github/repositories")) {
|
|
const offset = Number(url.searchParams.get("offset") ?? 0);
|
|
const limit = Number(url.searchParams.get("limit") ?? 20);
|
|
const search = (url.searchParams.get("search") ?? "").toLowerCase();
|
|
const all = state === "empty" ? [] : state === "long" ? repos.map((r) => ({ ...r,
|
|
label: `acme/platform-services-production-web-${r.id}-accessibility-improvements` })) : repos;
|
|
const filtered = all.filter((r) => r.label.toLowerCase().includes(search));
|
|
return Response.json({ items: filtered.slice(offset, offset + limit),
|
|
nextOffset: offset + limit < filtered.length ? offset + limit : null,
|
|
totalCount: all.length, enabledCount: all.filter((r) => r.enabled).length,
|
|
availableCount: all.filter((r) => r.availability === "available").length });
|
|
}
|
|
if (path.endsWith("/configuration")) {
|
|
if (init?.method === "PUT")
|
|
saved = {
|
|
revision: saved.revision + 1,
|
|
configuration: body.configuration,
|
|
};
|
|
return Response.json(saved);
|
|
}
|
|
if (path.endsWith("/repositories/refresh")) return Response.json(repos);
|
|
if (path.endsWith("/resources")) {
|
|
if (init?.method === "PUT")
|
|
repos = repos.map((r) => ({
|
|
...r,
|
|
enabled:
|
|
body.resources?.find(
|
|
(change: { id: string; enabled: boolean }) =>
|
|
change.id === r.id,
|
|
)?.enabled ?? r.enabled,
|
|
}));
|
|
const rows =
|
|
state === "empty"
|
|
? []
|
|
: state === "long"
|
|
? repos.map((r) => ({
|
|
...r,
|
|
label: `acme/platform-services-production-web-${r.id}-accessibility-improvements`,
|
|
}))
|
|
: repos;
|
|
return Response.json({ items: rows });
|
|
}
|
|
const reviewDetail = /^\/api\/chat-endpoints\/[^/]+\/github\/reviews\/([^/]+)$/.exec(path);
|
|
if (reviewDetail) {
|
|
const review = state === "empty" ? undefined : reviews.find((r) => r.id === decodeURIComponent(reviewDetail[1]));
|
|
return review ? Response.json(review) : Response.json({ error: "Review not found" }, { status: 404 });
|
|
}
|
|
if (path.endsWith("/reviews"))
|
|
return Response.json(state === "empty" ? [] : reviews);
|
|
if (path.endsWith("/activity"))
|
|
return Response.json({ items: [], nextCursor: null });
|
|
if (path.endsWith("/conversations"))
|
|
return Response.json({
|
|
items:
|
|
state === "empty"
|
|
? []
|
|
: state === "long"
|
|
? conversations.map((r) => ({
|
|
...r,
|
|
issueTitle: `${r.issueTitle} for every keyboard, screen reader, and narrow screen entry point`,
|
|
}))
|
|
: conversations,
|
|
});
|
|
if (path.endsWith("/principals"))
|
|
return Response.json({ items: state === "empty" ? [] : identities });
|
|
if (path.endsWith("/link") && init?.method === "DELETE") {
|
|
identities = identities.filter(
|
|
(link) => !path.includes(link.principalId),
|
|
);
|
|
return Response.json({ success: true });
|
|
}
|
|
if (path.endsWith("/people/lookup"))
|
|
return Response.json({ githubUserId: "44", login: body.login });
|
|
return Response.json(state === "setup" ? { ...endpoint, status: "draft", setup: { github: { stage: "setup" } } } : endpoint);
|
|
};
|
|
setReady(true);
|
|
return () => {
|
|
window.fetch = original;
|
|
client.clear();
|
|
};
|
|
}, [client, state]);
|
|
return ready ? (
|
|
<QueryClientProvider client={client}>
|
|
<EditorAutocompleteProvider>{children}</EditorAutocompleteProvider>
|
|
</QueryClientProvider>
|
|
) : null;
|
|
}
|