mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-11-07 16:35:48 +01:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work. > - The feature map describes product areas and verification entry points. > - Storybook has 223 story suites that show production components, proposals, and retained history. > - The parent PR maps those suites to features, but their folders and sidebar still use unrelated groups. > - This pull request puts the existing suites under feature folders and uses the feature map's names and order in the sidebar. > - Explicit meta IDs preserve existing story links while the titles change. > - Contributors can find stories through the same product structure without losing examples. ## Linked Issues or Issue Description Refs #16046. This is the requested follow-up. Parent #16046 is merged. This PR now targets master, with its single follow-up commit rebased onto the parent squash merge. The Storybook implementation is unchanged by that rebase. Related open Storybook PRs were checked; this change organizes existing suites and adds no product capability. ## What Changed - Move all 223 story files into folders named for their primary feature area. Keep useful scenario groups below the feature's sidebar label. - Order the sidebar by the eight feature-map sections. Put Overview first and shared Foundations last. Leave areas with no stories out of the sidebar. - Move 19 support files into `ui/storybook/support/` and update relative imports and active documentation. - Preserve all 2,210 story IDs and the single docs ID through explicit CSF meta IDs. Keep all entry names and story exports. - Record stable IDs and sidebar titles in the downstream catalog. Validate feature folders, title prefixes, and IDs. Update the maintenance skill and review evidence. ## Verification - Storybook build passed. Built index comparison against parent `75bd3c977cd828d5222823850339e8204f40eb47` found the same 2,211 entries, IDs, and names. - UI typecheck passed (`ui/node_modules/.bin/tsc -b` from `ui`, invoked as `./node_modules/.bin/tsc -b`). - UI Vitest project: 728 files and 8,176 tests passed. - Catalog checker and its nine tests passed. Feature-map checks, token gates, and the maintenance-skill validator passed. - Chromium: nine existing play cases and one render case reached `storyFinished: success` with no page exceptions. The guide rendered, sidebar sections followed map order, and a search for `steering/queue` opened its preserved story link. - Source comparison found only meta title/ID changes, rebased relative references, and updated fixture path text in story files. - To inspect: build Storybook, start `node scripts/serve-storybook-static.mjs --port 6136`, and open the Overview guide. Expand feature folders and use existing story links. - The complete repository suite was not repeated for this organization change. The parent records a backend timeout that passed in isolation, without a complete broad-suite pass. Visual comparisons remain blocked by the unpublished empty baseline. The separate fixture-server story was not run. ## Risks - Open branches that add stories under old paths will need to choose a feature folder and update the catalog. Cross-feature suites have one primary home and retain related capability references. - Sidebar paths change; story and docs IDs remain stable. Automated references to source paths may need the new location. - This is one requested follow-up with 258 changed files, mostly moves. It exceeds the usual review-size guideline because splitting it would leave the sidebar and folder convention partly migrated. - Browser verification samples ten stories, not all 2,210. Existing production/prototype classifications and review gaps remain unchanged. - Required CI gates and a 5/5 review passed on the original head. Fresh checks and review are running for the rebased head. Catalog validation and all nine checker tests passed after rebase; UI, map, skill, and checker contents are identical to the original reviewed head. ## Model Used - OpenAI Codex, GPT-6. The exact runtime model ID and context-window size are not exposed in this session. Used reasoning, repository inspection, code execution, and local browser automation. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [ ] All Paperclip CI gates are green - [ ] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge Co-authored-by: Paperclip <noreply@paperclip.ing>
70 lines
3.9 KiB
TypeScript
70 lines
3.9 KiB
TypeScript
import { useEffect, useState } from "react";
|
|
import { Route, Routes } from "@/lib/router";
|
|
import { Layout } from "@/components/Layout";
|
|
import { Agents } from "@/pages/Agents";
|
|
import { PluginLauncherProvider } from "@/plugins/launchers";
|
|
import { AgentBasicsDialog } from "@/components/new-agent/AgentBasicsDialog";
|
|
import { ExternalAgentInviteContent, type DotConnectionState, type ExternalAgentPreset } from "@/components/new-agent/ExternalAgentInviteContent";
|
|
import { Dialog } from "@/components/ui/dialog";
|
|
import { AnimatedDialogContent } from "@/components/AnimatedDialogContent";
|
|
import { Button } from "@/components/ui/button";
|
|
import { dotInvitePrompt, externalInvitePrompt } from "./fixtures";
|
|
|
|
export interface ExternalAgentInvitePreviewProps {
|
|
initialScreen?: "entry" | "picker" | "setup";
|
|
initialPreset?: ExternalAgentPreset;
|
|
initialConnection?: DotConnectionState;
|
|
companyName?: string;
|
|
simulate?: boolean;
|
|
failTest?: boolean;
|
|
stepDelayMs?: number;
|
|
shell?: boolean;
|
|
preparing?: boolean;
|
|
}
|
|
|
|
/** Storybook owns simulation. No timer, fixture code, or fake status ships in the UI component. */
|
|
export function ExternalAgentInvitePreview({
|
|
initialScreen = "entry", initialPreset = "dot", initialConnection = { phase: "waiting" },
|
|
companyName = "Paperclip", simulate = true, failTest = false, stepDelayMs = 2000, shell = true, preparing = false,
|
|
}: ExternalAgentInvitePreviewProps) {
|
|
const [screen, setScreen] = useState<"entry" | "picker" | "setup" | "closed">(initialScreen);
|
|
const [preset, setPreset] = useState<ExternalAgentPreset>(initialPreset);
|
|
const [connection, setConnection] = useState(initialConnection);
|
|
const [watching, setWatching] = useState(false);
|
|
const [retrying, setRetrying] = useState(false);
|
|
const [generation, setGeneration] = useState(1);
|
|
useEffect(() => {
|
|
if (!simulate || !watching || connection.problem || connection.phase === "ready") return;
|
|
const phase = connection.phase;
|
|
const next = { waiting: "connected", connected: "subscribed", subscribed: "testing", testing: "finishing", finishing: "ready" } as const;
|
|
const timer = window.setTimeout(() => {
|
|
setConnection(phase === "testing" && failTest && !retrying
|
|
? { phase, problem: "event_timeout" } : { phase: next[phase] });
|
|
}, stepDelayMs);
|
|
return () => window.clearTimeout(timer);
|
|
}, [connection, watching, simulate, stepDelayMs, failTest, retrying]);
|
|
return <>
|
|
{shell ? <PluginLauncherProvider>
|
|
<Routes><Route path="/:companyPrefix" element={<Layout />}><Route path="agents" element={<Agents />} /></Route></Routes>
|
|
</PluginLauncherProvider> : <div className="p-6"><Button onClick={() => setScreen("picker")}>Invite an external agent</Button></div>}
|
|
<AgentBasicsDialog open={screen === "entry"} onClose={() => setScreen("closed")} onContinue={() => setScreen("closed")} onInvite={() => setScreen("picker")} />
|
|
<Dialog open={screen === "picker" || screen === "setup"} onOpenChange={open => { if (!open) setScreen("closed"); }}>
|
|
<AnimatedDialogContent className="flex max-h-(--sz-calc-18) flex-col gap-0 overflow-hidden p-0 sm:max-w-(--sz-560px)">
|
|
<ExternalAgentInviteContent
|
|
preset={screen === "picker" ? null : preset}
|
|
companyName={companyName}
|
|
busy={preparing}
|
|
prompt={preparing ? "" : preset === "dot" ? dotInvitePrompt(generation) : externalInvitePrompt}
|
|
connection={connection}
|
|
onSelect={value => { setPreset(value); setScreen("setup"); }}
|
|
onBack={() => setScreen("picker")}
|
|
onClose={() => setScreen("closed")}
|
|
onCopied={() => { if (preset === "dot") setWatching(true); }}
|
|
onRetry={() => { setConnection(previous => ({ phase: previous.phase })); setRetrying(true); setWatching(true); }}
|
|
onNewPrompt={() => { setGeneration(value => value + 1); setConnection({ phase: "waiting" }); setWatching(false); }}
|
|
/>
|
|
</AnimatedDialogContent>
|
|
</Dialog>
|
|
</>;
|
|
}
|