mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-11-01 06:42:06 +01:00
## Thinking Path > - Paperclip is a control plane for AI-agent companies, so execution policy and trust boundaries are part of the product's safety contract. > - Low-trust review work needs narrower authority than normal same-company agents because hostile PRs, comments, attachments, and generated output can carry prompt-injection payloads. > - The current V1 shape gives trusted workers broad company context, which is useful for normal execution but too permissive for a reviewer assigned to hostile content. > - This branch adds a `low_trust_review` preset, source-trust tagging, route-level containment, and quarantine handling so low-trust output does not automatically flow into higher-trust wake context. > - The branch has been rebased onto current `origin/master`, and the low-trust migration was renumbered to `0097_low_trust_source_trust.sql` to avoid collisions with existing `0091` through `0096` migrations. > - Greptile feedback was addressed by tightening low-trust detection, preserving project-level trust policy checks, fixing issue-kind promotion lookup, removing duplicate post-lease isolation assertion, documenting fail-closed source-trust behavior, bounding ancestry checks, enforcing runtime issue context for CEOs, awaiting accepted-plan monitor authorization, and making low-trust issue source-trust tagging atomic. > - The benefit is a first production slice of deny-by-default review containment with regression coverage for the main control-plane pivot surfaces. Fixes #7531. ## What Changed - Added shared trust-policy types and validators, plus database/source-trust fields for issues, comments, documents, and work products. - Implemented server enforcement for low-trust issue scope, agent self-view redaction, secret/plugin/runtime denial paths, promotion checks, and quarantined continuation/wake context. - Added focused low-trust regression tests for resolver behavior, source trust, route authorization, heartbeat preflight ordering, runtime containment, and quarantine redaction. - Added board UI affordances for selecting/reviewing the low-trust preset and surfacing source-trust badges in relevant issue views. - Added `doc/LOW-TRUST-PRESETS.md`, updated `doc/SPEC-implementation.md`, and committed the low-trust review contract plan under `doc/plans/`. - Rebasing note: the original `0097_low_trust_source_trust.sql` migration was renamed to `0097_low_trust_source_trust.sql`; the SQL uses `ADD COLUMN IF NOT EXISTS` so users who already applied the old-numbered migration are not broken by the renumbered migration. ## Verification - Rebased branch onto current `origin/master` and force-pushed with lease to `origin/PAP-10211-low-trust-agent` at head `2719f31e3`. - Confirmed the PR diff does not include `pnpm-lock.yaml` or `.github/workflows` changes. - Resolved upstream UI/comment conflicts by preserving deleted-comment tombstone behavior and low-trust source-trust badges/metadata. - Renumbered the low-trust source-trust migration to `0097_low_trust_source_trust.sql`; the SQL uses `ADD COLUMN IF NOT EXISTS` so users who already applied an old-numbered copy are not broken. - `pnpm exec vitest run ui/src/lib/issue-chat-messages.test.ts server/src/__tests__/heartbeat-workspace-session.test.ts` - `pnpm exec vitest run server/src/__tests__/source-trust.test.ts server/src/__tests__/workspace-runtime-service-authz.test.ts ui/src/lib/trust-policy-ui.test.ts ui/src/components/TrustPresetSection.test.tsx` - `pnpm run typecheck:build-gaps` - `git diff --check` - GitHub checks pass on head `2719f31e3`: build, typecheck/release registry, general tests, serialized server suites, e2e, canary, verify, policy/review, Socket, and Snyk. - Greptile Review passes with Confidence Score 5/5 and zero unresolved Greptile review threads. - No design screenshots/images were added because the task explicitly says not to add them unless they are specifically part of the work. ## Risks - Medium risk: this touches shared trust-policy contracts, server authorization paths, heartbeat context generation, migration metadata, and UI preset controls. - Low-trust containment is intentionally deny-by-default; legitimate future review workflows may need explicit allowlisted exceptions. - Plugin/runtime/security surfaces are broad, so regression tests cover the current known routes but future integrations must route through the same containment layer. - The PR is ready for review; GitHub checks are green and Greptile is 5/5. > For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and discuss it in `#dev` before opening the PR. Feature PRs that overlap with planned core work may need to be redirected — check the roadmap first. See `CONTRIBUTING.md`. ## Model Used - OpenAI Codex, GPT-5 coding agent, tool-enabled shell and GitHub CLI workflow. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] UI changes are covered by focused tests; no screenshots were added per task instruction not to add design images unless specifically required - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
392 lines
12 KiB
TypeScript
392 lines
12 KiB
TypeScript
import express from "express";
|
|
import request from "supertest";
|
|
import { beforeEach, describe, expect, it, vi } from "vitest";
|
|
import { errorHandler } from "../middleware/index.js";
|
|
import { issueRoutes } from "../routes/issues.js";
|
|
|
|
const mockIssueService = vi.hoisted(() => ({
|
|
getById: vi.fn(),
|
|
getAncestors: vi.fn(),
|
|
getRelationSummaries: vi.fn(),
|
|
findMentionedProjectIds: vi.fn(),
|
|
getCommentCursor: vi.fn(),
|
|
getComment: vi.fn(),
|
|
listBlockerAttention: vi.fn(),
|
|
listProductivityReviews: vi.fn(),
|
|
getCurrentScheduledRetry: vi.fn(),
|
|
listAttachments: vi.fn(),
|
|
}));
|
|
|
|
const mockProjectService = vi.hoisted(() => ({
|
|
getById: vi.fn(),
|
|
listByIds: vi.fn(),
|
|
}));
|
|
|
|
const mockGoalService = vi.hoisted(() => ({
|
|
getById: vi.fn(),
|
|
getDefaultCompanyGoal: vi.fn(),
|
|
}));
|
|
|
|
const mockDocumentsService = vi.hoisted(() => ({
|
|
getIssueDocumentPayload: vi.fn(),
|
|
getIssueDocumentByKey: vi.fn(),
|
|
}));
|
|
|
|
const mockExecutionWorkspaceService = vi.hoisted(() => ({
|
|
getById: vi.fn(),
|
|
}));
|
|
|
|
const mockAccessService = vi.hoisted(() => ({
|
|
canUser: vi.fn(),
|
|
decide: vi.fn(),
|
|
hasPermission: vi.fn(),
|
|
}));
|
|
|
|
const mockAgentService = vi.hoisted(() => ({
|
|
getById: vi.fn(),
|
|
}));
|
|
|
|
const mockFeedbackService = vi.hoisted(() => ({
|
|
listIssueVotesForUser: vi.fn(async () => []),
|
|
saveIssueVote: vi.fn(async () => ({ vote: null, consentEnabledNow: false, sharingEnabled: false })),
|
|
}));
|
|
|
|
const mockHeartbeatService = vi.hoisted(() => ({
|
|
wakeup: vi.fn(async () => undefined),
|
|
reportRunActivity: vi.fn(async () => undefined),
|
|
}));
|
|
|
|
const mockInstanceSettingsService = vi.hoisted(() => ({
|
|
get: vi.fn(async () => ({
|
|
id: "instance-settings-1",
|
|
general: {
|
|
censorUsernameInLogs: false,
|
|
feedbackDataSharingPreference: "prompt",
|
|
},
|
|
})),
|
|
listCompanyIds: vi.fn(async () => ["company-1"]),
|
|
}));
|
|
|
|
const mockIssueReferenceService = vi.hoisted(() => ({
|
|
deleteDocumentSource: vi.fn(async () => undefined),
|
|
diffIssueReferenceSummary: vi.fn(() => ({
|
|
addedReferencedIssues: [],
|
|
removedReferencedIssues: [],
|
|
currentReferencedIssues: [],
|
|
})),
|
|
emptySummary: vi.fn(() => ({ outbound: [], inbound: [] })),
|
|
listIssueReferenceSummary: vi.fn(async () => ({ outbound: [], inbound: [] })),
|
|
syncComment: vi.fn(async () => undefined),
|
|
syncDocument: vi.fn(async () => undefined),
|
|
syncIssue: vi.fn(async () => undefined),
|
|
}));
|
|
|
|
const mockLogActivity = vi.hoisted(() => vi.fn(async () => undefined));
|
|
|
|
const mockRoutineService = vi.hoisted(() => ({
|
|
syncRunStatusForIssue: vi.fn(async () => undefined),
|
|
}));
|
|
|
|
const mockWorkProductService = vi.hoisted(() => ({
|
|
listForIssue: vi.fn(async () => []),
|
|
}));
|
|
|
|
const mockEnvironmentService = vi.hoisted(() => ({}));
|
|
|
|
const mockDb = vi.hoisted(() => ({
|
|
select: vi.fn(),
|
|
execute: vi.fn(),
|
|
}));
|
|
|
|
vi.mock("../services/index.js", () => ({
|
|
companyService: () => ({
|
|
getById: vi.fn(async () => ({ id: "company-1", attachmentMaxBytes: 10 * 1024 * 1024 })),
|
|
}),
|
|
accessService: () => mockAccessService,
|
|
agentService: () => mockAgentService,
|
|
documentAnnotationService: () => ({ remapOpenThreadsForDocument: async () => [] }),
|
|
documentService: () => mockDocumentsService,
|
|
environmentService: () => mockEnvironmentService,
|
|
executionWorkspaceService: () => mockExecutionWorkspaceService,
|
|
feedbackService: () => mockFeedbackService,
|
|
goalService: () => mockGoalService,
|
|
heartbeatService: () => mockHeartbeatService,
|
|
instanceSettingsService: () => mockInstanceSettingsService,
|
|
issueApprovalService: () => ({}),
|
|
issueRecoveryActionService: () => ({
|
|
getActiveForIssue: vi.fn(async () => null),
|
|
listActiveForIssues: vi.fn(async () => new Map()),
|
|
}),
|
|
issueThreadInteractionService: () => ({
|
|
listForIssue: vi.fn(async () => []),
|
|
expireRequestConfirmationsSupersededByComment: vi.fn(async () => []),
|
|
expireStaleRequestConfirmationsForIssueDocument: vi.fn(async () => []),
|
|
}),
|
|
issueReferenceService: () => mockIssueReferenceService,
|
|
issueService: () => mockIssueService,
|
|
logActivity: mockLogActivity,
|
|
projectService: () => mockProjectService,
|
|
routineService: () => mockRoutineService,
|
|
workProductService: () => mockWorkProductService,
|
|
}));
|
|
|
|
vi.mock("../services/execution-workspaces.js", () => ({
|
|
executionWorkspaceService: () => mockExecutionWorkspaceService,
|
|
}));
|
|
|
|
function createApp() {
|
|
const app = express();
|
|
app.use(express.json());
|
|
app.use((req, _res, next) => {
|
|
(req as any).actor = {
|
|
type: "board",
|
|
userId: "local-board",
|
|
companyIds: ["company-1"],
|
|
source: "local_implicit",
|
|
isInstanceAdmin: false,
|
|
};
|
|
next();
|
|
});
|
|
app.use("/api", issueRoutes(mockDb as any, {} as any));
|
|
app.use(errorHandler);
|
|
return app;
|
|
}
|
|
|
|
const legacyProjectLinkedIssue = {
|
|
id: "11111111-1111-4111-8111-111111111111",
|
|
companyId: "company-1",
|
|
identifier: "PAP-581",
|
|
title: "Legacy onboarding task",
|
|
description: "Seed the first CEO task",
|
|
status: "todo",
|
|
workMode: "planning",
|
|
priority: "medium",
|
|
projectId: "22222222-2222-4222-8222-222222222222",
|
|
goalId: null,
|
|
parentId: null,
|
|
assigneeAgentId: "33333333-3333-4333-8333-333333333333",
|
|
assigneeUserId: null,
|
|
updatedAt: new Date("2026-03-24T12:00:00Z"),
|
|
executionWorkspaceId: null,
|
|
labels: [],
|
|
labelIds: [],
|
|
};
|
|
|
|
const projectGoal = {
|
|
id: "44444444-4444-4444-8444-444444444444",
|
|
companyId: "company-1",
|
|
title: "Launch the company",
|
|
description: null,
|
|
level: "company",
|
|
status: "active",
|
|
parentId: null,
|
|
ownerAgentId: null,
|
|
createdAt: new Date("2026-03-20T00:00:00Z"),
|
|
updatedAt: new Date("2026-03-20T00:00:00Z"),
|
|
};
|
|
|
|
describe.sequential("issue goal context routes", () => {
|
|
beforeEach(() => {
|
|
vi.clearAllMocks();
|
|
mockAccessService.decide.mockResolvedValue({
|
|
allowed: true,
|
|
action: "issue:read",
|
|
reason: "allow_test",
|
|
explanation: "Allowed by test mock.",
|
|
});
|
|
mockIssueService.getById.mockResolvedValue(legacyProjectLinkedIssue);
|
|
mockIssueService.getAncestors.mockResolvedValue([]);
|
|
mockIssueService.getRelationSummaries.mockResolvedValue({ blockedBy: [], blocks: [] });
|
|
mockIssueService.findMentionedProjectIds.mockResolvedValue([]);
|
|
mockIssueService.getCommentCursor.mockResolvedValue({
|
|
totalComments: 0,
|
|
latestCommentId: null,
|
|
latestCommentAt: null,
|
|
});
|
|
mockIssueService.getComment.mockResolvedValue(null);
|
|
mockIssueService.listBlockerAttention.mockResolvedValue(new Map());
|
|
mockIssueService.listProductivityReviews.mockResolvedValue(new Map());
|
|
mockIssueService.getCurrentScheduledRetry.mockResolvedValue(null);
|
|
mockIssueService.listAttachments.mockResolvedValue([]);
|
|
mockDocumentsService.getIssueDocumentPayload.mockResolvedValue({});
|
|
mockDocumentsService.getIssueDocumentByKey.mockResolvedValue(null);
|
|
mockExecutionWorkspaceService.getById.mockResolvedValue(null);
|
|
mockDb.select.mockReturnValue({
|
|
from: vi.fn(() => ({
|
|
where: vi.fn(() => ({
|
|
orderBy: vi.fn(async () => []),
|
|
})),
|
|
})),
|
|
});
|
|
mockDb.execute.mockResolvedValue([]);
|
|
mockProjectService.getById.mockResolvedValue({
|
|
id: legacyProjectLinkedIssue.projectId,
|
|
companyId: "company-1",
|
|
urlKey: "onboarding",
|
|
goalId: projectGoal.id,
|
|
goalIds: [projectGoal.id],
|
|
goals: [{ id: projectGoal.id, title: projectGoal.title }],
|
|
name: "Onboarding",
|
|
description: null,
|
|
status: "in_progress",
|
|
leadAgentId: null,
|
|
targetDate: null,
|
|
color: null,
|
|
pauseReason: null,
|
|
pausedAt: null,
|
|
executionWorkspacePolicy: null,
|
|
codebase: {
|
|
workspaceId: null,
|
|
repoUrl: null,
|
|
repoRef: null,
|
|
defaultRef: null,
|
|
repoName: null,
|
|
localFolder: null,
|
|
managedFolder: "/tmp/company-1/project-1",
|
|
effectiveLocalFolder: "/tmp/company-1/project-1",
|
|
origin: "managed_checkout",
|
|
},
|
|
workspaces: [],
|
|
primaryWorkspace: null,
|
|
archivedAt: null,
|
|
createdAt: new Date("2026-03-20T00:00:00Z"),
|
|
updatedAt: new Date("2026-03-20T00:00:00Z"),
|
|
});
|
|
mockProjectService.listByIds.mockResolvedValue([]);
|
|
mockGoalService.getById.mockImplementation(async (id: string) =>
|
|
id === projectGoal.id ? projectGoal : null,
|
|
);
|
|
mockGoalService.getDefaultCompanyGoal.mockResolvedValue(null);
|
|
});
|
|
|
|
it("surfaces the project goal from GET /issues/:id when the issue has no direct goal", async () => {
|
|
const res = await request(createApp()).get("/api/issues/11111111-1111-4111-8111-111111111111");
|
|
|
|
expect(res.status).toBe(200);
|
|
expect(res.body.goalId).toBe(projectGoal.id);
|
|
expect(res.body.goal).toEqual(
|
|
expect.objectContaining({
|
|
id: projectGoal.id,
|
|
title: projectGoal.title,
|
|
}),
|
|
);
|
|
expect(mockIssueService.findMentionedProjectIds).toHaveBeenCalledWith(
|
|
"11111111-1111-4111-8111-111111111111",
|
|
{ includeCommentBodies: false },
|
|
);
|
|
expect(mockGoalService.getDefaultCompanyGoal).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it("surfaces the project goal from GET /issues/:id/heartbeat-context", async () => {
|
|
const res = await request(createApp()).get(
|
|
"/api/issues/11111111-1111-4111-8111-111111111111/heartbeat-context",
|
|
);
|
|
|
|
expect(res.status).toBe(200);
|
|
expect(res.body.issue.goalId).toBe(projectGoal.id);
|
|
expect(res.body.issue.workMode).toBe("planning");
|
|
expect(res.body.goal).toEqual(
|
|
expect.objectContaining({
|
|
id: projectGoal.id,
|
|
title: projectGoal.title,
|
|
}),
|
|
);
|
|
expect(mockGoalService.getDefaultCompanyGoal).not.toHaveBeenCalled();
|
|
expect(res.body.attachments).toEqual([]);
|
|
});
|
|
|
|
it("preserves direct continuation summary lookup in GET /issues/:id/heartbeat-context", async () => {
|
|
mockDocumentsService.getIssueDocumentByKey.mockResolvedValue({
|
|
key: "continuation-summary",
|
|
title: "Continuation Summary",
|
|
body: "# Handoff",
|
|
latestRevisionId: "revision-1",
|
|
latestRevisionNumber: 1,
|
|
updatedAt: new Date("2026-04-19T12:00:00.000Z"),
|
|
});
|
|
|
|
const res = await request(createApp()).get(
|
|
"/api/issues/11111111-1111-4111-8111-111111111111/heartbeat-context",
|
|
);
|
|
|
|
expect(res.status).toBe(200);
|
|
expect(mockDocumentsService.getIssueDocumentByKey).toHaveBeenCalledWith(
|
|
"11111111-1111-4111-8111-111111111111",
|
|
"continuation-summary",
|
|
);
|
|
expect(res.body.continuationSummary).toEqual(expect.objectContaining({
|
|
key: "continuation-summary",
|
|
body: "# Handoff",
|
|
}));
|
|
});
|
|
|
|
it("surfaces blocker summaries on GET /issues/:id/heartbeat-context", async () => {
|
|
mockIssueService.getRelationSummaries.mockResolvedValue({
|
|
blockedBy: [
|
|
{
|
|
id: "55555555-5555-4555-8555-555555555555",
|
|
identifier: "PAP-580",
|
|
title: "Finish wakeup plumbing",
|
|
status: "done",
|
|
priority: "medium",
|
|
assigneeAgentId: null,
|
|
assigneeUserId: null,
|
|
},
|
|
],
|
|
blocks: [],
|
|
});
|
|
|
|
const res = await request(createApp()).get(
|
|
"/api/issues/11111111-1111-4111-8111-111111111111/heartbeat-context",
|
|
);
|
|
|
|
expect(res.status).toBe(200);
|
|
expect(res.body.issue.blockedBy).toEqual([
|
|
expect.objectContaining({
|
|
id: "55555555-5555-4555-8555-555555555555",
|
|
identifier: "PAP-580",
|
|
}),
|
|
]);
|
|
});
|
|
|
|
it("surfaces the current execution workspace from GET /issues/:id/heartbeat-context", async () => {
|
|
mockIssueService.getById.mockResolvedValue({
|
|
...legacyProjectLinkedIssue,
|
|
executionWorkspaceId: "55555555-5555-4555-8555-555555555555",
|
|
});
|
|
mockExecutionWorkspaceService.getById.mockResolvedValue({
|
|
id: "55555555-5555-4555-8555-555555555555",
|
|
name: "PAP-581 workspace",
|
|
mode: "isolated_workspace",
|
|
status: "active",
|
|
cwd: "/tmp/pap-581",
|
|
runtimeServices: [
|
|
{
|
|
id: "service-1",
|
|
serviceName: "web",
|
|
status: "running",
|
|
url: "http://127.0.0.1:5173",
|
|
healthStatus: "healthy",
|
|
},
|
|
],
|
|
});
|
|
|
|
const res = await request(createApp()).get(
|
|
"/api/issues/11111111-1111-4111-8111-111111111111/heartbeat-context",
|
|
);
|
|
|
|
expect(res.status).toBe(200);
|
|
expect(mockExecutionWorkspaceService.getById).toHaveBeenCalledWith("55555555-5555-4555-8555-555555555555");
|
|
expect(res.body.currentExecutionWorkspace).toEqual(expect.objectContaining({
|
|
id: "55555555-5555-4555-8555-555555555555",
|
|
mode: "isolated_workspace",
|
|
runtimeServices: [
|
|
expect.objectContaining({
|
|
serviceName: "web",
|
|
url: "http://127.0.0.1:5173",
|
|
}),
|
|
],
|
|
}));
|
|
});
|
|
});
|