Files
PaperClipAI/server/src/services/native-runtime/runtime-mode.test.ts
T
Dotta fdf8c8464d feat(runner): add managed provider backends (#12699)
## Thinking Path

> - Paperclip is the open source app people use to manage AI agents for
work.
> - The Paperclip Runner provides durable, provider-neutral agent
execution.
> - The current stack supports qualified local providers but omits the
managed provider paths from the integration branch.
> - Claude Managed Agents and AWS AgentCore need explicit profile
qualification, durable recovery, usage accounting, and cleanup controls.
> - This pull request adds those managed backends as the third part of
the Runner parity stack.
> - The benefit is managed execution without weakening the default-off
Runner rollout gate.

## Linked Issues or Issue Description

**Subsystem affected**

Cross-cutting: Runner, server orchestration, database profiles, CLI, and
adapter configuration UI.

**Problem or motivation**

The current Runner stack cannot select or execute the managed Claude
Agents API or AWS Bedrock AgentCore Harness backends. It also lacks
qualified profile storage and recovery checks for those remote
resources.

**Proposed solution**

Add qualified managed and remote profiles, API and CLI management, exact
provider selection, durable lifecycle handling, cumulative usage
accounting, bounded cleanup, and retention acknowledgement. Keep
`enableNativeRunner` default-off.

**Alternatives considered**

A direct copy of the old integration branch was rejected because its
provider contracts, model values, credential flow, and migration history
no longer match the current base. A single large parity pull request was
also rejected because stacked review keeps each subsystem bounded.

**Roadmap alignment**

This continues the existing Runner architecture and rollout work. It
does not introduce a separate execution system.

**Additional context**

This pull request is based on the merged #12691 and #12685 stack. It
also closes the delayed security-review findings reported on #12691 by
binding qualified ACPX and OpenCode launch artifacts to the bytes
actually executed. A GitHub search for managed agent, AgentCore, and
Claude managed work found no duplicate public issue or pull request.

## What Changed

- Add Claude Managed Agents and AWS AgentCore provider executors to
runnerd.
- Add qualified managed and remote profile storage, routes, OpenAPI
contracts, CLI commands, and migration 0237.
- Validate profile ownership, enabled state, exact qualified revision,
model, agent version, and secret binding before persistence and
recovery.
- Persist durable provider session and owned skill state for
restart-safe cleanup.
- Reconcile uncertain create responses and delete remote sessions before
owned skills.
- Track cumulative provider usage and enforce positive session spend
caps.
- Recover interrupted AgentCore usage at the next turn boundary by
charging the prior invocation ceiling exactly once; keep the session
gated until an explicit monotonic budget raise.
- Isolate AgentCore AWS configuration from host profiles and
credential-process/SSO configuration while preserving workload identity.
- Require OpenCode 1.18.17 and fixed build-owned provider-pack artifact
paths; remove the ambient executable override.
- Snapshot and content-verify ACPX and OpenCode commands, scripts, and
provider executables before launch. Linux executes sealed inherited
descriptors; macOS uses authenticated private snapshots with retry-safe
rematerialization at the spawn boundary.
- Persist canonical ACPX and OpenCode launch-profile digests, reject
drift across fresh recovery, and make recovery failures sticky.
- Close and journal unsafe ACPX active-turn recovery before any provider
bootstrap or reconnect.
- Add managed provider fields to the Runner configuration UI and
permission projection.
- Preserve the default-off `enableNativeRunner` experimental flag.

## Verification

- `pnpm -r typecheck`
- `pnpm build`
- Focused managed server, database, CLI, Runner TypeScript, Rust,
Claude, AgentCore, ACPX, OpenCode, process-supervisor, and
durable-recovery tests passed.
- `cargo test -p paperclip-runner-core --lib --locked` (160 tests)
- `cargo check --workspace --all-targets --locked`
- Native Codex integration tests passed (60 tests); native provider
tests passed (7 tests); server native-runtime tests passed (87 tests).
- Verified-launch replacement, nested-spawn retry, exact-version,
profile-drift, sticky-failure, and no-bootstrap active-recovery tests
passed.
- `git diff --check`
- The PR changes 91 files. `pnpm-lock.yaml` is unchanged. The Rust
workspace lockfile adds the approved `rustix` dependency used for safe
descriptor handling while `#![forbid(unsafe_code)]` remains enabled.

## Risks

- The provider APIs can change while they are in beta. Exact
qualification and fail-closed recovery checks limit drift.
- Remote cleanup can fail after a partial create. Durable ownership
inventories and retry-safe deletion preserve recovery state.
- Migration 0237 adds profile tables. The generated migration and
snapshot pass the repository migration checks.
- Managed execution can incur provider cost. Positive default spend caps
and explicit retention acknowledgement limit accidental use.
- An interrupted AgentCore invocation without final metadata is
conservatively charged to its active session ceiling. This can overstate
cost, but cannot undercount it; later work requires an explicit budget
increase.
- Linux qualified launches use sealed memory descriptors. macOS lacks
executable-descriptor APIs, so the runner uses owner-only private
snapshots and minimizes linked-path lifetime; hostile same-UID processes
remain outside the documented local-host trust boundary.
- The global Runner feature remains default-off.

> For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and
discuss it in `#dev` before opening the PR. Feature PRs that overlap
with planned core work may need to be redirected — check the roadmap
first. See `CONTRIBUTING.md`.

## Model Used

OpenAI Codex, GPT-5, with tool use, code execution, and subagent review.

## Checklist

- [x] I have included a thinking path that traces from project context
to this change
- [x] I have specified the model used (with version and capability
details)
- [x] I have checked ROADMAP.md and confirmed this PR does not duplicate
planned core work
- [x] I have searched GitHub for duplicate or related PRs and linked
them above
- [x] I have either (a) linked existing issues with `Fixes: #` / `Closes
#` / `Refs #` OR (b) described the issue in-PR following the relevant
issue template
- [x] I have not referenced internal/instance-local Paperclip issues or
links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip`
URLs)
- [x] My branch name describes the change and contains no internal
Paperclip ticket id or instance-derived details
- [x] I have run tests locally and they pass
- [x] I have added or updated tests where applicable
- [x] I have updated relevant documentation to reflect my changes
- [x] I have considered and documented any risks above
- [x] All Paperclip CI gates are green
- [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups
- [x] I will address all Greptile and reviewer comments before
requesting merge
2026-09-02 00:48:30 -05:00

468 lines
15 KiB
TypeScript

import { describe, expect, it } from "vitest";
import { BUILTIN_ADAPTER_TYPES } from "../../adapters/builtin-adapter-types.js";
import {
NativeRunnerSelectionError,
NativeRuntimeEligibilityError,
isRunnerIngressAuthorized,
resolveHeartbeatNativeRuntimeMode,
resolveHeartbeatRuntimeMode,
resolveNativeRuntimeMode,
} from "./runtime-mode.js";
const eligible = {
enabled: true,
runtimeConfig: {},
adapterConfig: { provider: "codex" },
agent: { status: "running", adapterType: "paperclip_runner" },
issue: { id: "issue", workMode: "standard" },
target: { kind: "local" },
workspaceId: "workspace",
} as const;
describe("resolveNativeRuntimeMode", () => {
it("keeps every direct built-in adapter outside native arbitration", () => {
for (const adapterType of BUILTIN_ADAPTER_TYPES) {
if (adapterType === "paperclip_runner") continue;
expect(resolveNativeRuntimeMode({
...eligible,
enabled: false,
runtimeConfig: {
nativeRunner: {
mode: "native",
backend: "codex_app_server",
protocolVersion: 1,
},
},
agent: { ...eligible.agent, adapterType },
})).toEqual({
kind: "legacy",
resolverVersion: "phase6-v1",
reason: "direct_adapter",
});
}
});
it("rejects a fresh Paperclip Runner start while the rollout flag is disabled", () => {
expect(() => resolveNativeRuntimeMode({
...eligible,
enabled: false,
})).toThrow(expect.objectContaining({
code: "paperclip_runner_rollout_disabled",
}));
});
it("rejects unknown Paperclip Runner providers", () => {
expect(() => resolveNativeRuntimeMode({
...eligible,
runtimeConfig: {},
adapterConfig: { provider: "claude" },
agent: { ...eligible.agent, adapterType: "paperclip_runner" },
})).toThrow(expect.objectContaining({
code: "paperclip_runner_provider_unsupported",
}));
});
it("admits fresh local, managed, and qualified ACPX profiles", () => {
expect(resolveNativeRuntimeMode({
...eligible,
adapterConfig: { provider: "opencode", model: "openrouter/deepseek/deepseek-v4-flash-0731" },
})).toMatchObject({
kind: "native",
profile: { backend: "opencode_server" },
});
expect(resolveNativeRuntimeMode({
...eligible,
adapterConfig: {
provider: "claude_managed",
managedProfileId: "managed-primary",
managedAgentsRetentionAcknowledged: true,
},
})).toMatchObject({
kind: "native",
profile: { backend: "claude_managed_agents_api" },
});
expect(resolveNativeRuntimeMode({
...eligible,
adapterConfig: {
provider: "aws_agentcore",
agentCoreProfileId: "agentcore-primary",
agentCoreRetentionAcknowledged: true,
},
})).toMatchObject({
kind: "native",
profile: { backend: "aws_agentcore_harness_api" },
});
expect(resolveNativeRuntimeMode({
...eligible,
adapterConfig: { provider: "acpx", acpxAgent: "claude", model: "claude-sonnet-5" },
})).toMatchObject({
kind: "native",
profile: { backend: "acpx_runtime" },
});
expect(resolveNativeRuntimeMode({
...eligible,
adapterConfig: { provider: "acpx", acpxAgent: "codex", model: "gpt-5.6-sol" },
})).toMatchObject({
kind: "native",
profile: { backend: "acpx_runtime" },
});
});
it("rejects malformed OpenCode and unqualified ACPX profiles", () => {
expect(() => resolveNativeRuntimeMode({
...eligible,
adapterConfig: { provider: "opencode", model: "gpt-5.6-sol" },
})).toThrow(expect.objectContaining({
code: "paperclip_runner_opencode_model_invalid",
}));
expect(() => resolveNativeRuntimeMode({
...eligible,
adapterConfig: {
provider: "acpx",
acpxAgent: "pi",
model: "openrouter/deepseek/deepseek-v4-flash-0731",
},
})).toThrow(expect.objectContaining({
code: "paperclip_runner_acpx_agent_unavailable",
}));
expect(() => resolveNativeRuntimeMode({
...eligible,
adapterConfig: { provider: "acpx", acpxAgent: "claude", model: "claude-opus-5" },
})).toThrow(expect.objectContaining({
code: "paperclip_runner_acpx_model_unqualified",
}));
});
it("rejects incomplete managed-provider selections before a run is persisted", () => {
expect(() => resolveNativeRuntimeMode({
...eligible,
adapterConfig: {
provider: "claude_managed",
managedProfileId: "managed-primary",
},
})).toThrow(expect.objectContaining({
code: "paperclip_runner_claude_managed_retention_required",
}));
expect(() => resolveNativeRuntimeMode({
...eligible,
adapterConfig: {
provider: "aws_agentcore",
agentCoreRetentionAcknowledged: true,
},
})).toThrow(expect.objectContaining({
code: "paperclip_runner_aws_agentcore_profile_required",
}));
});
it("uses adapterConfig as the fresh provider authority", () => {
expect(resolveNativeRuntimeMode({
...eligible,
runtimeConfig: {
nativeRunner: { provider: "opencode" },
},
adapterConfig: { provider: "codex" },
})).toMatchObject({
kind: "native",
profile: { backend: "codex_app_server" },
});
});
it("preserves legacy as the default and as the kill-switch behavior", () => {
const direct = {
...eligible,
agent: { ...eligible.agent, adapterType: "codex_local" },
runtimeConfig: { nativeRunner: { mode: "native", backend: "codex_app_server", protocolVersion: 1 } },
};
expect(resolveNativeRuntimeMode(direct)).toEqual(expect.objectContaining({
kind: "legacy",
reason: "direct_adapter",
}));
expect(resolveNativeRuntimeMode({ ...direct, enabled: false })).toEqual(expect.objectContaining({
kind: "legacy",
reason: "direct_adapter",
}));
});
it("selects native only for an eligible explicit profile", () => {
expect(resolveNativeRuntimeMode(eligible)).toEqual(expect.objectContaining({
kind: "native",
reason: "eligible_opt_in",
}));
});
it("keeps a persisted active run native while the global flag rejects a fresh runner start", () => {
const disabled = { ...eligible, enabled: false };
expect(resolveHeartbeatNativeRuntimeMode({
...disabled,
persisted: {
runtimeMode: "native",
runtimeModeReason: "eligible_opt_in",
runtimeModeResolvedAt: new Date(),
},
})).toEqual(expect.objectContaining({
kind: "native",
reason: "eligible_opt_in",
authorityDecision: expect.objectContaining({ reasonCode: "live_continuation_registered" }),
}));
expect(() => resolveHeartbeatNativeRuntimeMode({
...disabled,
persisted: { runtimeMode: null, runtimeModeReason: null, runtimeModeResolvedAt: null },
})).toThrow(expect.objectContaining({
code: "paperclip_runner_rollout_disabled",
}));
});
it("authorizes ingress from the native runtime decision without a second flag", () => {
const freshNative = resolveHeartbeatNativeRuntimeMode({
...eligible,
persisted: {
runtimeMode: null,
runtimeModeReason: null,
runtimeModeResolvedAt: null,
},
});
const persistedNative = resolveHeartbeatNativeRuntimeMode({
...eligible,
enabled: false,
persisted: {
runtimeMode: "native",
runtimeModeReason: "eligible_opt_in",
runtimeModeResolvedAt: new Date(),
},
});
const directLegacy = resolveHeartbeatNativeRuntimeMode({
...eligible,
enabled: false,
agent: { ...eligible.agent, adapterType: "codex_local" },
persisted: {
runtimeMode: null,
runtimeModeReason: null,
runtimeModeResolvedAt: null,
},
});
expect(isRunnerIngressAuthorized(freshNative)).toBe(true);
expect(isRunnerIngressAuthorized(persistedNative)).toBe(true);
expect(isRunnerIngressAuthorized(directLegacy)).toBe(false);
});
it.each(["paused", "terminated", "pending_approval"])(
"refuses persisted native recovery for a %s agent",
(status) => {
expect(() => resolveHeartbeatNativeRuntimeMode({
...eligible,
enabled: false,
agent: { ...eligible.agent, status },
persisted: {
runtimeMode: "native",
runtimeModeReason: "eligible_opt_in",
runtimeModeResolvedAt: new Date(),
driverKind: "codex_app_server",
},
})).toThrow(expect.objectContaining({
code: "paperclip_runner_agent_ineligible",
}));
},
);
it("fails closed for an unknown persisted driver", () => {
expect(() => resolveHeartbeatNativeRuntimeMode({
...eligible,
enabled: false,
persisted: {
runtimeMode: "native",
runtimeModeReason: "eligible_opt_in",
runtimeModeResolvedAt: new Date(),
driverKind: "unknown_driver",
},
})).toThrow(expect.objectContaining({
code: "paperclip_runner_driver_unsupported",
}));
});
it("does not recover a native run through a direct adapter", () => {
expect(() => resolveHeartbeatNativeRuntimeMode({
...eligible,
enabled: false,
agent: { ...eligible.agent, adapterType: "codex_local" },
persisted: {
runtimeMode: "native",
runtimeModeReason: "eligible_opt_in",
runtimeModeResolvedAt: new Date(),
driverKind: "codex_app_server",
},
})).toThrow(expect.objectContaining({
code: "paperclip_runner_adapter_binding_mismatch",
}));
});
it("keeps a persisted OpenCode recovery on its immutable driver", () => {
expect(resolveHeartbeatNativeRuntimeMode({
...eligible,
enabled: false,
persisted: {
runtimeMode: "native",
runtimeModeReason: "eligible_opt_in",
runtimeModeResolvedAt: new Date(),
driverKind: "opencode_server",
},
})).toEqual(expect.objectContaining({
profile: { mode: "native", backend: "opencode_server", protocolVersion: 1 },
}));
});
it.each([
"claude_managed_agents_api",
"aws_agentcore_harness_api",
] as const)("keeps a persisted %s recovery on its immutable driver", (driverKind) => {
expect(resolveHeartbeatNativeRuntimeMode({
...eligible,
enabled: false,
persisted: {
runtimeMode: "native",
runtimeModeReason: "eligible_opt_in",
runtimeModeResolvedAt: new Date(),
driverKind,
},
})).toEqual(expect.objectContaining({
profile: { mode: "native", backend: driverKind, protocolVersion: 1 },
}));
});
it("keeps a persisted ACPX recovery even when fresh selection is disabled", () => {
expect(resolveHeartbeatNativeRuntimeMode({
...eligible,
enabled: false,
adapterConfig: {
provider: "acpx",
acpxAgent: "pi",
model: "historical",
},
persisted: {
runtimeMode: "native",
runtimeModeReason: "eligible_opt_in",
runtimeModeResolvedAt: new Date(),
driverKind: "acpx_runtime",
},
})).toEqual(expect.objectContaining({
profile: { mode: "native", backend: "acpx_runtime", protocolVersion: 1 },
}));
});
it("rejects an explicit native profile outside the approved boundary", () => {
expect(resolveNativeRuntimeMode({ ...eligible, agent: { ...eligible.agent, adapterType: "claude_local" } }))
.toEqual(expect.objectContaining({ kind: "legacy", reason: "direct_adapter" }));
expect(() => resolveNativeRuntimeMode({ ...eligible, issue: { id: "issue", workMode: "skill_test" } }))
.toThrow(NativeRuntimeEligibilityError);
});
it("admits remote targets only through paperclip_runner", () => {
expect(resolveNativeRuntimeMode({
...eligible,
target: { kind: "remote" },
runtimeConfig: {},
adapterConfig: { provider: "codex" },
agent: { ...eligible.agent, adapterType: "paperclip_runner" },
})).toMatchObject({ kind: "native" });
expect(resolveNativeRuntimeMode({
...eligible,
target: { kind: "remote" },
agent: { ...eligible.agent, adapterType: "codex_local" },
})).toMatchObject({ kind: "legacy", reason: "direct_adapter" });
});
it("allows paperclip_runner to use a transient local workspace for projectless issues", () => {
expect(resolveNativeRuntimeMode({
...eligible,
workspaceId: null,
agent: { ...eligible.agent, adapterType: "paperclip_runner" },
runtimeConfig: {},
adapterConfig: { provider: "codex" },
})).toEqual(expect.objectContaining({ kind: "native" }));
});
it("admits planning only through paperclip_runner", () => {
expect(resolveNativeRuntimeMode({
...eligible,
issue: { id: "plan-issue", workMode: "planning" },
runtimeConfig: {},
adapterConfig: { provider: "codex" },
agent: { ...eligible.agent, adapterType: "paperclip_runner" },
})).toMatchObject({ kind: "native", profile: { backend: "codex_app_server" } });
expect(resolveNativeRuntimeMode({
...eligible,
issue: { id: "plan-issue", workMode: "planning" },
agent: { ...eligible.agent, adapterType: "codex_local" },
})).toEqual(expect.objectContaining({ kind: "legacy", reason: "direct_adapter" }));
});
it("admits ask mode through paperclip_runner while preserving the legacy native boundary", () => {
expect(resolveNativeRuntimeMode({
...eligible,
issue: { id: "ask-issue", workMode: "ask" },
runtimeConfig: {},
adapterConfig: { provider: "codex" },
agent: { ...eligible.agent, adapterType: "paperclip_runner" },
})).toMatchObject({ kind: "native", profile: { backend: "codex_app_server" } });
expect(resolveNativeRuntimeMode({
...eligible,
issue: { id: "ask-issue", workMode: "ask" },
agent: { ...eligible.agent, adapterType: "codex_local" },
})).toEqual(expect.objectContaining({ kind: "legacy", reason: "direct_adapter" }));
});
});
const compatibilityInput = {
persisted: { runtimeMode: "legacy", runtimeModeResolvedAt: null },
enabled: true,
adapterConfig: { provider: "codex" },
agentStatus: "running",
issue: { workMode: "standard" },
executionTarget: { kind: "local" },
} as const;
describe("resolveHeartbeatRuntimeMode compatibility", () => {
it("keeps every direct built-in adapter on the legacy path", () => {
for (const adapterType of BUILTIN_ADAPTER_TYPES) {
if (adapterType === "paperclip_runner") continue;
expect(resolveHeartbeatRuntimeMode({
...compatibilityInput,
adapterType,
})).toEqual({
kind: "legacy",
resolverVersion: "paperclip-runner-v1",
reason: "direct_adapter",
});
}
});
it("preserves the original public result and error contracts", () => {
expect(resolveHeartbeatRuntimeMode({
...compatibilityInput,
adapterType: "paperclip_runner",
})).toEqual({
kind: "native",
resolverVersion: "paperclip-runner-v1",
reason: "explicit_paperclip_runner",
provider: "codex",
});
expect(resolveHeartbeatRuntimeMode({
...compatibilityInput,
enabled: false,
adapterType: "paperclip_runner",
persisted: { runtimeMode: "native", runtimeModeResolvedAt: new Date() },
})).toEqual({
kind: "native",
resolverVersion: "paperclip-runner-v1",
reason: "persisted_native_selection",
provider: "codex",
});
expect(() => resolveHeartbeatRuntimeMode({
...compatibilityInput,
enabled: false,
adapterType: "paperclip_runner",
})).toThrow(NativeRunnerSelectionError);
});
});