mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-11-20 09:50:48 +01:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work > - Routines start agent work on a schedule, from a webhook, or on demand > - The routine detail page split one routine across eight sections behind a section sidebar (overview, triggers, variables, secrets, delivery, runs, activity, history) > - People had to hunt through sections to see what a routine does and to change it, and a finished webhook could not be tested again without starting the routine > - This pull request makes the approved two-column routine page, one Edit dialog and one Webhook dialog the real routed page, and lets a live webhook go back into test mode > - The benefit is one page that answers what the routine does, when it runs, who runs it and what it made, with every change in one dialog ## Linked Issues or Issue Description **Problem** The routine detail page spreads one routine over eight sections and a section sidebar. Changing a routine means visiting several sections, each with its own save bar. A webhook that is already live cannot be tested again: the API only accepts `setupPending: false`, so testing a live webhook starts the routine. **Proposed solution** Ship the reviewed design (stories `routine-page-design`, `routine-edit-dialog-design`, `routine-webhook-dialog-design`) as the routed page in both UI shells, wired to the real API. Let `PATCH /api/routine-triggers/:id` accept `setupPending: true` for a live webhook so the next events are checked but never start the routine. **Alternatives considered** Keep the sections and restyle them. The owner rejected this: the section sidebar should go. ## What Changed - `/routines/:id` renders `RoutinePage` in both shells (`RoutineDetail.production.tsx` is removed). Status switch, Repeats rows, default agent, responsible user, project, Asks for, Secrets, Run rules, Managed by plugin, Instructions with Show all, copy and the comment count, and History. - History is paged: 20 tasks per page from `GET /companies/:id/issues?originKind=routine_execution&originId=…&sortField=created&sortDir=desc&limit=21&offset=…`, with a real Load more. Coalesced runs show as "folded into a task". - A failed refetch keeps the loaded page on screen (`useQueryView`); a History failure shows `QueryErrorState` in place. - Header: Edit, "…" (Version history, Audit log, Archive / Restore) and Run now. In the streamlined desktop shell they sit in the breadcrumb toolbar; elsewhere above the page. - Version history (`/routines/:id/history`, restore and restored-webhook keys kept) and Audit log (`/routines/:id/activity`, `RoutineAuditActivity`) open as sub-views with a way back. Old section addresses and `?tab=` redirect to `/routines/:id`. - Edit dialog saves title, instructions, variables, secrets, agent, project and responsible user in one request against the revision the dialog opened with (save conflict shows "changed while you were editing"). The first schedule is created, changed or removed after that. Priority and delivery settings are never sent, so saved values stay. - Webhooks are created, changed, tested and removed (with Undo) right away from the Edit dialog, with the Webhook dialog nested inside it. Closing the Webhook dialog ends setup or test mode. A webhook left in test mode shows "Testing · events don’t run" on the page and offers Finish testing. - Responsibility (only with `enableResponsibilities`): the page shows direct and through-project responsibilities from the link lookup; the dialog links or unlinks the direct one. With the flag off nothing is fetched or shown. - The routines list creates routines with the same dialog in create mode, filed in the open folder, and opens the new routine page. - Server: `setupPending: true` on a live webhook enters test mode (planned by a pure `planTriggerUpdate`, which also gives the activity action) (422 for other trigger kinds; 409 for a disabled or removed webhook or an archived routine). Test deliveries keep the last real delivery as `lastWebhookDelivery.previous`, and finishing testing restores it. Activity `routine.trigger_test_started`. - Additions to the reviewed design, from review, so no capability is lost: the schedule popover has Pause/Resume; standing-check and API rows open a small popover with Pause/Resume and Remove; removing a trigger from the page leaves a "… removed. Undo" line under Repeats. Stories: `StandingCheckOpened`, `ScheduleTriggerPaused(Opened)`, `RemovedWithUndo`. - Save is several requests (routine, schedule, responsibility). It changes only the schedule the form opened with, records each finished step, and a partial failure says what was saved and that saving again finishes it. The dialog cannot be dismissed while saving. Failed reads show a Retry state, never empty choices. - Removed: the routine section sidebar and contextual sidebar, the trigger wizard, trigger cards, save bar, section components and their tests. - Storybook: the three routine stories moved to `stories/routines` as current production stories, a new story mounts the routed page against a fixture API, and stories that used the old page were updated or removed. ## Verification - `pnpm --filter @paperclipai/server exec vitest run src/__tests__/routines-e2e.test.ts` (17/17) and `src/__tests__/routines-service.test.ts` (105/105). - `pnpm exec vitest run` on the routine page, routines list, routine form, webhook instructions, Layout, shell navigation, audit and editor tests: 275 tests pass. - `cd ui && npx tsc -p tsconfig.json --noEmit`, `node scripts/check-token-gates.mjs`, `node scripts/check-maps.mjs`, `node scripts/storybook-catalog.mjs --check`: pass. - `pnpm verify` exits 2 (global CI input changed); required CI supplies the broad coverage. - Manual: an isolated worktree instance (`pnpm paperclipai worktree init --empty`, `pnpm dev`) with a seeded routine. Headless Playwright: an old `/triggers` address redirects, no section sidebar, History shows 20 then 23 after Load more, the schedule popover opens, pause and resume, Edit → Add webhook → created key → Finish, title save, Test webhook → Finish testing, Version history, Audit log shows "Started testing a webhook", phone width has no horizontal overflow, and Create routine from the list opens the new page. No console errors or failed API calls. ## Risks - Behaviour change: the section pages are gone. Old links redirect to the single page. - The delivery-setting editors (concurrency, catch-up, activity gate) and priority are removed from the UI. Saved values stay, and the API still accepts them. - The create dialog no longer offers a folder picker or delivery settings. A new routine goes into the folder the list is showing and takes the default settings. - Replace key in the Webhook dialog acts at once, as in the reviewed design. The old confirmation is gone. - No migration. `lastWebhookDelivery.previous` is an optional field inside the existing jsonb column. ## Model Used - Claude Opus 5.5 (`claude-opus-5-5`), Anthropic, in Claude Code with tool use (shell, file edits, headless browser) and subagents for the server change and the Storybook move. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [ ] All Paperclip CI gates are green - [ ] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Fable 5.2 <noreply@anthropic.com>
318 lines
13 KiB
TypeScript
318 lines
13 KiB
TypeScript
import { forwardRef, useCallback, useEffect, useMemo, useRef, useState, type CSSProperties, type ReactNode } from "react";
|
|
import { Check, Search, X } from "lucide-react";
|
|
import { Popover, PopoverContent, PopoverTrigger } from "@/components/ui/popover";
|
|
import { orderItemsBySelectedAndRecent } from "../lib/recent-selections";
|
|
import { cn } from "../lib/utils";
|
|
import { useMobileEntityPickerViewportStyle } from "../hooks/useMobileEntityPickerViewportStyle";
|
|
|
|
export interface InlineEntityOption {
|
|
id: string;
|
|
label: string;
|
|
searchText?: string;
|
|
}
|
|
|
|
interface InlineEntitySelectorProps {
|
|
value: string;
|
|
options: InlineEntityOption[];
|
|
placeholder: string;
|
|
noneLabel: string;
|
|
/** Keep the no-selection action before the selected and recent choices. */
|
|
noneAtTop?: boolean;
|
|
/** Keep the no-selection action after the project choices. */
|
|
noneAtEnd?: boolean;
|
|
/** Leave out the no-selection action, for a value that can be changed but not cleared. */
|
|
hideNone?: boolean;
|
|
searchPlaceholder: string;
|
|
emptyMessage: string;
|
|
onChange: (id: string) => void;
|
|
onConfirm?: () => void;
|
|
className?: string;
|
|
renderTriggerValue?: (option: InlineEntityOption | null) => ReactNode;
|
|
renderOption?: (option: InlineEntityOption, isSelected: boolean) => ReactNode;
|
|
recentOptionIds?: string[];
|
|
/** Skip the Portal so the popover stays in the DOM tree (fixes scroll inside Dialogs). */
|
|
disablePortal?: boolean;
|
|
/** Open the popover when the trigger receives keyboard/programmatic focus. */
|
|
openOnFocus?: boolean;
|
|
/** Disable the trigger and prevent the popover from opening. */
|
|
disabled?: boolean;
|
|
/** Optional test id forwarded to the trigger button. */
|
|
triggerTestId?: string;
|
|
/** Optional slot name used by consuming surfaces for scoped presentation rules. */
|
|
triggerDataSlot?: string;
|
|
/** Runtime geometry variables for the portalled mobile picker sheet. */
|
|
contentStyle?: CSSProperties;
|
|
/** Heading for the large mobile selector modal. Defaults to the placeholder. */
|
|
mobileTitle?: string;
|
|
/** Own the scroll lock when this picker portals outside a parent dialog. */
|
|
modal?: boolean;
|
|
}
|
|
|
|
const EMPTY_RECENT_OPTION_IDS: string[] = [];
|
|
|
|
function useMobileSelectorModal() {
|
|
const [mobile, setMobile] = useState(() =>
|
|
typeof window !== "undefined"
|
|
&& typeof window.matchMedia === "function"
|
|
&& window.matchMedia("(max-width: 40rem)").matches,
|
|
);
|
|
|
|
useEffect(() => {
|
|
if (typeof window.matchMedia !== "function") return;
|
|
const media = window.matchMedia("(max-width: 40rem)");
|
|
const update = () => setMobile(media.matches);
|
|
update();
|
|
media.addEventListener("change", update);
|
|
return () => media.removeEventListener("change", update);
|
|
}, []);
|
|
|
|
return mobile;
|
|
}
|
|
|
|
export const InlineEntitySelector = forwardRef<HTMLButtonElement, InlineEntitySelectorProps>(
|
|
function InlineEntitySelector(
|
|
{
|
|
value,
|
|
options,
|
|
placeholder,
|
|
noneLabel,
|
|
noneAtTop = false,
|
|
noneAtEnd = false,
|
|
hideNone = false,
|
|
searchPlaceholder,
|
|
emptyMessage,
|
|
onChange,
|
|
onConfirm,
|
|
className,
|
|
renderTriggerValue,
|
|
renderOption,
|
|
recentOptionIds = EMPTY_RECENT_OPTION_IDS,
|
|
disablePortal,
|
|
openOnFocus = true,
|
|
disabled = false,
|
|
triggerTestId,
|
|
triggerDataSlot,
|
|
contentStyle,
|
|
mobileTitle,
|
|
modal = false,
|
|
},
|
|
ref,
|
|
) {
|
|
const [open, setOpen] = useState(false);
|
|
const [query, setQuery] = useState("");
|
|
const [highlightedIndex, setHighlightedIndex] = useState(0);
|
|
const mobileSelectorModal = useMobileSelectorModal();
|
|
const mobileViewportStyle = useMobileEntityPickerViewportStyle();
|
|
const highlightedIndexRef = useRef(0);
|
|
const inputRef = useRef<HTMLInputElement>(null);
|
|
const shouldPreventCloseAutoFocusRef = useRef(false);
|
|
const suppressNextTriggerFocusRef = useRef(false);
|
|
const isPointerDownRef = useRef(false);
|
|
|
|
const allOptions = useMemo<InlineEntityOption[]>(() => {
|
|
if (hideNone) return orderItemsBySelectedAndRecent([...options], value, recentOptionIds);
|
|
const baseOptions = [{ id: "", label: noneLabel, searchText: noneLabel }, ...options];
|
|
const ordered = orderItemsBySelectedAndRecent(baseOptions, value, recentOptionIds);
|
|
if (noneAtTop) return [baseOptions[0]!, ...ordered.filter((option) => option.id)];
|
|
return noneAtEnd ? [...ordered.filter((option) => option.id), baseOptions[0]!] : ordered;
|
|
}, [hideNone, noneAtEnd, noneAtTop, noneLabel, options, recentOptionIds, value]);
|
|
|
|
const filteredOptions = useMemo(() => {
|
|
const term = query.trim().toLowerCase();
|
|
if (!term) return allOptions;
|
|
return allOptions.filter((option) => {
|
|
if (noneAtTop && !option.id) return true;
|
|
const haystack = `${option.label} ${option.searchText ?? ""}`.toLowerCase();
|
|
return haystack.includes(term);
|
|
});
|
|
}, [allOptions, noneAtTop, query]);
|
|
|
|
const currentOption = options.find((option) => option.id === value) ?? null;
|
|
|
|
const setHighlightedIndexValue = useCallback((next: number | ((current: number) => number)) => {
|
|
const resolved = typeof next === "function" ? next(highlightedIndexRef.current) : next;
|
|
highlightedIndexRef.current = resolved;
|
|
setHighlightedIndex(resolved);
|
|
}, []);
|
|
|
|
useEffect(() => {
|
|
if (!open) return;
|
|
const firstSearchResultIndex = noneAtTop && query.trim()
|
|
? filteredOptions.findIndex((option) => option.id)
|
|
: -1;
|
|
const selectedIndex = filteredOptions.findIndex((option) => option.id === value);
|
|
setHighlightedIndexValue(
|
|
firstSearchResultIndex >= 0 ? firstSearchResultIndex : selectedIndex >= 0 ? selectedIndex : 0,
|
|
);
|
|
}, [filteredOptions, noneAtTop, open, query, setHighlightedIndexValue, value]);
|
|
|
|
const commitSelection = (index: number, moveNext: boolean) => {
|
|
const option = filteredOptions[index] ?? filteredOptions[0];
|
|
if (option) onChange(option.id);
|
|
shouldPreventCloseAutoFocusRef.current = moveNext;
|
|
setOpen(false);
|
|
setQuery("");
|
|
if (moveNext && onConfirm) {
|
|
requestAnimationFrame(() => {
|
|
onConfirm();
|
|
});
|
|
}
|
|
};
|
|
|
|
return (
|
|
<Popover
|
|
// Portalled mobile sheets and modal callers need their own scroll lock
|
|
// so a parent dialog does not cancel wheel or touch events in the list.
|
|
modal={mobileSelectorModal || modal}
|
|
open={open}
|
|
onOpenChange={(next) => {
|
|
if (disabled) return;
|
|
setOpen(next);
|
|
if (!next) setQuery("");
|
|
}}
|
|
>
|
|
<PopoverTrigger asChild>
|
|
<button
|
|
ref={ref}
|
|
type="button"
|
|
disabled={disabled}
|
|
data-testid={triggerTestId}
|
|
data-slot={triggerDataSlot}
|
|
className={cn(
|
|
"inline-flex min-w-0 items-center gap-1 rounded-md border border-border bg-muted/40 px-2 py-1 text-sm font-medium text-foreground transition-colors hover:bg-accent/50 focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring disabled:opacity-50 disabled:pointer-events-none",
|
|
className,
|
|
)}
|
|
onPointerDown={() => { isPointerDownRef.current = true; }}
|
|
onFocus={() => {
|
|
if (disabled) return;
|
|
if (openOnFocus && !isPointerDownRef.current && !suppressNextTriggerFocusRef.current) setOpen(true);
|
|
isPointerDownRef.current = false;
|
|
suppressNextTriggerFocusRef.current = false;
|
|
}}
|
|
>
|
|
{renderTriggerValue
|
|
? renderTriggerValue(currentOption)
|
|
: (currentOption?.label ?? <span className="text-muted-foreground">{placeholder}</span>)}
|
|
</button>
|
|
</PopoverTrigger>
|
|
<PopoverContent
|
|
data-mobile-entity-picker=""
|
|
aria-label={mobileTitle ?? placeholder}
|
|
align="start"
|
|
side="bottom"
|
|
collisionPadding={16}
|
|
className="w-(--sz-calc-6) p-1"
|
|
disablePortal={disablePortal && !mobileSelectorModal}
|
|
style={{ ...mobileViewportStyle, ...contentStyle }}
|
|
onOpenAutoFocus={(event) => {
|
|
event.preventDefault();
|
|
inputRef.current?.focus();
|
|
}}
|
|
onCloseAutoFocus={(event) => {
|
|
if (!shouldPreventCloseAutoFocusRef.current) {
|
|
// Radix returns focus to the trigger on Escape/outside dismissal.
|
|
// That focus must not immediately reopen the picker.
|
|
suppressNextTriggerFocusRef.current = true;
|
|
// Non-modal outside dismissal may keep focus on the clicked
|
|
// element instead. Limit suppression to Radix's synchronous restore.
|
|
queueMicrotask(() => { suppressNextTriggerFocusRef.current = false; });
|
|
return;
|
|
}
|
|
event.preventDefault();
|
|
shouldPreventCloseAutoFocusRef.current = false;
|
|
}}
|
|
>
|
|
<div data-mobile-entity-picker-header="" className="hidden items-center justify-between border-b border-border px-4 py-3">
|
|
<span className="text-base font-semibold text-foreground">{mobileTitle ?? placeholder}</span>
|
|
<button
|
|
type="button"
|
|
className="inline-flex size-9 items-center justify-center rounded-md text-muted-foreground hover:bg-accent hover:text-foreground"
|
|
aria-label="Close selector"
|
|
onClick={() => {
|
|
shouldPreventCloseAutoFocusRef.current = true;
|
|
setOpen(false);
|
|
}}
|
|
>
|
|
<X className="size-5" />
|
|
</button>
|
|
</div>
|
|
<div className="flex items-center gap-2 border-b border-border px-2">
|
|
<Search className="size-4 shrink-0 text-muted-foreground" aria-hidden />
|
|
<input
|
|
ref={inputRef}
|
|
className="min-w-0 flex-1 bg-transparent py-2 text-base outline-none placeholder:text-muted-foreground/60 md:text-sm"
|
|
placeholder={searchPlaceholder}
|
|
value={query}
|
|
onChange={(event) => {
|
|
setQuery(event.target.value);
|
|
}}
|
|
onKeyDown={(event) => {
|
|
if (event.key === "ArrowDown") {
|
|
event.preventDefault();
|
|
event.stopPropagation();
|
|
setHighlightedIndexValue((current) =>
|
|
filteredOptions.length === 0 ? 0 : (current + 1) % filteredOptions.length,
|
|
);
|
|
return;
|
|
}
|
|
if (event.key === "ArrowUp") {
|
|
event.preventDefault();
|
|
event.stopPropagation();
|
|
setHighlightedIndexValue((current) => {
|
|
if (filteredOptions.length === 0) return 0;
|
|
return current <= 0 ? filteredOptions.length - 1 : current - 1;
|
|
});
|
|
return;
|
|
}
|
|
if (event.key === "Enter") {
|
|
event.preventDefault();
|
|
event.stopPropagation();
|
|
commitSelection(highlightedIndexRef.current, true);
|
|
return;
|
|
}
|
|
if (event.key === "Tab" && !event.shiftKey) {
|
|
event.preventDefault();
|
|
event.stopPropagation();
|
|
commitSelection(highlightedIndexRef.current, true);
|
|
return;
|
|
}
|
|
if (event.key === "Escape") {
|
|
event.preventDefault();
|
|
event.stopPropagation();
|
|
setOpen(false);
|
|
}
|
|
}}
|
|
/>
|
|
</div>
|
|
<div data-mobile-entity-picker-list="" className="max-h-56 overflow-y-auto overscroll-contain py-1 touch-pan-y">
|
|
{filteredOptions.length === 0 ? (
|
|
<p className="px-2 py-2 text-xs text-muted-foreground">{emptyMessage}</p>
|
|
) : (
|
|
filteredOptions.map((option, index) => {
|
|
const isSelected = option.id === value;
|
|
const isHighlighted = index === highlightedIndex;
|
|
return (
|
|
<button
|
|
key={option.id || "__none__"}
|
|
type="button"
|
|
className={cn(
|
|
"flex w-full items-center gap-2 rounded px-2 py-1.5 text-left text-sm touch-manipulation",
|
|
noneAtEnd && !option.id && "mt-1 rounded-none border-t border-border",
|
|
isHighlighted && "bg-accent",
|
|
)}
|
|
onMouseEnter={() => setHighlightedIndexValue(index)}
|
|
onClick={() => commitSelection(index, true)}
|
|
>
|
|
{renderOption ? renderOption(option, isSelected) : <span className="truncate">{option.label}</span>}
|
|
<Check className={cn("ml-auto h-3.5 w-3.5 text-muted-foreground", isSelected ? "opacity-100" : "opacity-0")} />
|
|
</button>
|
|
);
|
|
})
|
|
)}
|
|
</div>
|
|
</PopoverContent>
|
|
</Popover>
|
|
);
|
|
},
|
|
);
|