mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-26 10:26:26 +01:00
## Thinking Path
> - Paperclip is the open source app people use to manage AI agents for
work
> - The app can run self-hosted or as a cloud-managed instance, where a
hosting platform provisions the instance with its company already
materialized (the existing `isCloudManagedInstance()` predicate and
`cloud_managed` floors)
> - The company Import/Export surface lets an operator materialize whole
companies from an export bundle; on a cloud-managed instance this
bypasses the existing `cloud_managed` company-creation floor and
conflicts with platform-owned provisioning
> - Importing should be disabled on cloud-managed instances, while
export stays open as the data-portability escape hatch
> - This pull request floors every import route with 403
`code=cloud_managed` on cloud-managed instances and hides the Import UI
there, using the existing predicate and the established floor pattern
> - It also extends the operator-hidden settings registry with keys for
every top-level company settings page, so a hosting operator can hide
any of them with `PAPERCLIP_HIDDEN_SETTINGS` alone next time
> - The benefit is one consistent managed-instance policy: cloud-managed
instances cannot import companies, self-hosted installs keep the full
import surface unchanged
## Linked Issues or Issue Description
No public issue exists; the underlying problem follows the enhancement
template.
**What existing behavior does this improve?**
The company import surface (`/api/companies/import*`,
`/api/companies/:companyId/imports/*`) and its UI entry points on
cloud-managed instances.
**Subsystem affected**
Server routes (`server/src/routes/companies.ts`) and UI navigation/pages
(settings sidebar, settings tabs, org chart, `/company/import` route).
**Current behavior**
A cloud-managed instance floors direct company creation (`POST
/api/companies` answers 403 `cloud_managed`), but the import routes
still accept company bundles, so an import can materialize companies the
hosting platform did not provision. The UI offers Import entry points
that lead to a surface that is not available on cloud-managed instances.
**Proposed behavior**
On instances where `isCloudManagedInstance()` is true, every import
route answers 403 `code=cloud_managed` before auth and body work, and
the Import UI (sidebar entry, settings tab, org-chart button,
`/company/import` route) is hidden or redirected. Export remains fully
available. Self-hosted instances are unchanged.
**Reason and benefit**
Cloud-managed instances keep one consistent provisioning authority, and
users do not see an Import surface that dead-ends in a 403.
## What Changed
- `server/src/routes/companies.ts`: a router-level floor mounted at the
`/import` and `/:companyId/imports` prefixes. It covers the single-shot
upload, preview, job polling, chunked transfer
declare/part-upload/status/preview/apply, and the agent-safe per-company
import routes. It throws `forbidden(..., { code: "cloud_managed" })` on
cloud-managed instances, or `403 settings_operator_managed` when the
operator hides `company.import` — both before auth and body validation,
mirroring the company-creation floor.
- `packages/shared/src/settings-visibility.ts`: new
`HIDEABLE_COMPANY_PAGES` registry group — `company.members`,
`company.invites`, `company.secrets`, `company.export`, `company.import`
— with a `hidesCompanyPage` helper. The company General page stays
non-hideable (settings root). `company.import` floors its API; the other
keys are UI-visibility only, as documented in the registry, so
membership/invite/secret/export APIs stay live for agents.
- `ui/src/components/CloudManagedPageGate.tsx` (new): route gate that
redirects cloud-managed instances to `/company/settings`, modeled on
`HiddenSettingsPageGate`.
- `ui/src/App.tsx`: wraps the `company/import` route in
`CloudManagedPageGate`.
- `ui/src/components/CompanySettingsSidebar.tsx`,
`ui/src/components/access/CompanySettingsNav.tsx`,
`ui/src/pages/OrgChart.tsx`: hide the Import entry points when
`useCloudInstance()` reports a managed instance, and honor the new
`company.*` hidden-settings keys for every company page entry (sidebar
item, tab, org-chart buttons).
- `ui/src/App.tsx`: `HiddenSettingsPageGate` route gates for the members
(incl. the legacy access route), invites, secrets, export, and import
pages under their `company.*` keys.
- `docs/deploy/environment-variables.md`: documents the new keys and
their semantics; the CLI and board-operator guides note that import is
unavailable on cloud-managed instances.
- Tests: new `server/src/__tests__/company-import-cloud-floor.test.ts`
and `ui/src/components/CloudManagedPageGate.test.tsx`, registry cases in
`packages/shared/src/settings-visibility.test.ts`, plus cloud and
hidden-key cases in the sidebar, settings-nav, and org-chart suites.
## Verification
- TypeScript typechecks pass for every workspace package (`tsc` in
shared, server, ui; the runner's Rust leg needs a local cargo toolchain
and is covered by CI).
- `pnpm test` on this branch fails only in 9 files that also fail on a
clean `origin/master` checkout on the same machine
(environment-dependent suites: live-listener probes,
workspace/native-runtime spawns, skill materialization). Zero
branch-only failures against that baseline; every suite touched by this
change passes.
- `server/src/__tests__/company-import-cloud-floor.test.ts` asserts:
every import route answers 403 `cloud_managed` under the server-token
signal; the managed-config signal alone also floors; every import route
answers 403 `settings_operator_managed` when `company.import` is hidden;
hiding other company pages leaves import open; the floor applies before
auth and body validation; export stays open on cloud-managed instances;
self-hosted import preview and job polling still work.
- `packages/shared/src/settings-visibility.test.ts` covers the new
`company.*` keys and `hidesCompanyPage`.
- UI suites assert the Import tab, sidebar entry, and org-chart button
disappear on a cloud-managed instance while Export stays, that
`/company/import` redirects through the gate, and that the `company.*`
keys hide their sidebar entries and tabs.
## Risks
- Low risk for self-hosted installs: the floor is inert unless a cloud
signal (`PAPERCLIP_CLOUD_TENANT_SERVER_TOKEN` or
`PAPERCLIP_MANAGED_CONFIG`) is present, and the self-hosted paths are
regression-tested.
- On cloud-managed instances this is a deliberate behavioral removal:
import (including agent-driven safe imports and resumable transfers)
stops working the moment an instance runs this build. In-flight chunked
transfers on such instances cannot be applied afterward; they answer
403.
- CLI import commands against a cloud-managed instance now fail with the
`cloud_managed` error; the message names the reason.
- The new `company.*` keys change nothing unless an operator sets them:
`PAPERCLIP_HIDDEN_SETTINGS` unset keeps behavior identical, and older
images ignore unknown keys by design. The four non-import company keys
hide UI only; their APIs stay live, which the registry documents
explicitly.
## Model Used
Claude Fable 5 (`claude-fable-5`, Anthropic) via Claude Code — agentic
coding session with tool use (code search, editing, local test
execution).
## Checklist
- [x] I have included a thinking path that traces from project context
to this change
- [x] I have specified the model used (with version and capability
details)
- [x] I have checked ROADMAP.md and confirmed this PR does not duplicate
planned core work
- [x] I have searched GitHub for duplicate or related PRs and linked
them above
- [x] I have either (a) linked existing issues with `Fixes: #` / `Closes
#` / `Refs #` OR (b) described the issue in-PR following the relevant
issue template
- [x] I have not referenced internal/instance-local Paperclip issues or
links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip`
URLs)
- [x] My branch name describes the change (e.g. `docs/...`, `fix/...`)
and contains no internal Paperclip ticket id or instance-derived details
- [x] I have run tests locally and they pass
- [x] I have added or updated tests where applicable
- [x] I have updated relevant documentation to reflect my changes
- [x] I have considered and documented any risks above
- [ ] All Paperclip CI gates are green
- [ ] Greptile is 5/5 with no open P2s, recommendations, or follow-ups
- [x] I will address all Greptile and reviewer comments before
requesting merge
165 lines
5.6 KiB
TypeScript
165 lines
5.6 KiB
TypeScript
import { INSTANCE_FEATURE_KEYS, type InstanceFeatureKey } from "./feature-catalog.js";
|
|
|
|
/**
|
|
* Operator-configurable settings visibility.
|
|
*
|
|
* A hosting operator (a managed cloud, an internal shared server) can hide
|
|
* settings surfaces that do not apply to their deployment by setting the
|
|
* `PAPERCLIP_HIDDEN_SETTINGS` environment variable to a comma-separated
|
|
* list of keys from this registry. Hiding a surface removes it from the UI
|
|
* (nav, routes, page sections). Surfaces backed by instance-level mutation
|
|
* routes are also floored with a 403 carrying
|
|
* `SETTINGS_OPERATOR_MANAGED_ERROR_CODE`: the Access, Plugins, and Adapters
|
|
* pages, every field-backed General section, every experimental toggle
|
|
* (individually or via the whole Experimental page), and the company Import
|
|
* page (whose whole route surface is floored). The other company pages are
|
|
* UI-visibility keys only: their APIs (memberships, invites, secrets,
|
|
* exports) stay live for agents and integrations.
|
|
*
|
|
* Nothing is hidden by default: with the variable unset, UI and API behave
|
|
* exactly as before this mechanism existed.
|
|
*
|
|
* Unknown keys are ignored (with a server-side warning) rather than rejected,
|
|
* so an operator may roll one list across a fleet of mixed app versions: an
|
|
* image that predates a key simply keeps that surface visible instead of
|
|
* refusing to boot.
|
|
*/
|
|
|
|
/**
|
|
* Instance settings pages that can be hidden (nav entry + route). The General
|
|
* page is deliberately not hideable: it is the settings root and the redirect
|
|
* target for hidden pages. Individual General sections are hideable below.
|
|
*/
|
|
export const HIDEABLE_INSTANCE_PAGES = [
|
|
"instance.profile",
|
|
"instance.environments",
|
|
"instance.access",
|
|
"instance.heartbeats",
|
|
"instance.experimental",
|
|
"instance.plugins",
|
|
"instance.adapters",
|
|
] as const;
|
|
|
|
export type HideableInstancePage = (typeof HIDEABLE_INSTANCE_PAGES)[number];
|
|
|
|
/**
|
|
* Company-level settings pages that can be hidden (nav entry + tab + route).
|
|
* The company General page is deliberately not hideable: it is the settings
|
|
* root and the redirect target for hidden pages. `company.import` also floors
|
|
* the import API routes; the rest only hide UI surfaces.
|
|
*/
|
|
export const HIDEABLE_COMPANY_PAGES = [
|
|
"company.members",
|
|
"company.invites",
|
|
"company.secrets",
|
|
"company.export",
|
|
"company.import",
|
|
] as const;
|
|
|
|
export type HideableCompanyPage = (typeof HIDEABLE_COMPANY_PAGES)[number];
|
|
|
|
/**
|
|
* Sections of Instance → General that can be hidden. Field-backed sections
|
|
* (their suffix names a general-settings field) also floor writes to that
|
|
* field; `deploymentStatus` and `signOut` are read-only UI with no field.
|
|
*/
|
|
export const HIDEABLE_GENERAL_SECTIONS = [
|
|
"instance.general.deploymentStatus",
|
|
"instance.general.censorUsernameInLogs",
|
|
"instance.general.keyboardShortcuts",
|
|
"instance.general.backupRetention",
|
|
"instance.general.feedbackDataSharingPreference",
|
|
"instance.general.signOut",
|
|
] as const;
|
|
|
|
export type HideableGeneralSection = (typeof HIDEABLE_GENERAL_SECTIONS)[number];
|
|
|
|
/** General sections that are informational UI only, with no settings field. */
|
|
export const UI_ONLY_GENERAL_SECTIONS = [
|
|
"instance.general.deploymentStatus",
|
|
"instance.general.signOut",
|
|
] as const satisfies readonly HideableGeneralSection[];
|
|
|
|
export type HideableExperimentalSetting = `instance.experimental.${InstanceFeatureKey}`;
|
|
|
|
/** The visibility key for an experimental toggle; every boolean flag is hideable. */
|
|
export function experimentalSettingKey(key: InstanceFeatureKey): HideableExperimentalSetting {
|
|
return `instance.experimental.${key}`;
|
|
}
|
|
|
|
export type HideableSettingKey =
|
|
| HideableInstancePage
|
|
| HideableCompanyPage
|
|
| HideableGeneralSection
|
|
| HideableExperimentalSetting;
|
|
|
|
/** Every key `PAPERCLIP_HIDDEN_SETTINGS` accepts. */
|
|
export const HIDEABLE_SETTING_KEYS: readonly HideableSettingKey[] = [
|
|
...HIDEABLE_INSTANCE_PAGES,
|
|
...HIDEABLE_COMPANY_PAGES,
|
|
...HIDEABLE_GENERAL_SECTIONS,
|
|
...INSTANCE_FEATURE_KEYS.map(experimentalSettingKey),
|
|
];
|
|
|
|
/** Stable 403 code for writes to operator-hidden settings. */
|
|
export const SETTINGS_OPERATOR_MANAGED_ERROR_CODE = "settings_operator_managed";
|
|
|
|
export interface ParsedHiddenSettings {
|
|
/** Recognized keys, deduplicated, in input order. */
|
|
hidden: HideableSettingKey[];
|
|
/** Unrecognized entries, for the caller to warn about. */
|
|
unknown: string[];
|
|
}
|
|
|
|
/** Parse a `PAPERCLIP_HIDDEN_SETTINGS`-style comma-separated list. */
|
|
export function parseHiddenSettingsList(raw: string | undefined): ParsedHiddenSettings {
|
|
const hidden: HideableSettingKey[] = [];
|
|
const unknown: string[] = [];
|
|
if (!raw) return { hidden, unknown };
|
|
const known = new Set<string>(HIDEABLE_SETTING_KEYS);
|
|
const seen = new Set<string>();
|
|
for (const part of raw.split(",")) {
|
|
const key = part.trim();
|
|
if (!key || seen.has(key)) continue;
|
|
seen.add(key);
|
|
if (known.has(key)) {
|
|
hidden.push(key as HideableSettingKey);
|
|
} else {
|
|
unknown.push(key);
|
|
}
|
|
}
|
|
return { hidden, unknown };
|
|
}
|
|
|
|
export function hidesInstancePage(
|
|
hidden: ReadonlySet<string>,
|
|
page: HideableInstancePage,
|
|
): boolean {
|
|
return hidden.has(page);
|
|
}
|
|
|
|
export function hidesCompanyPage(
|
|
hidden: ReadonlySet<string>,
|
|
page: HideableCompanyPage,
|
|
): boolean {
|
|
return hidden.has(page);
|
|
}
|
|
|
|
export function hidesGeneralSection(
|
|
hidden: ReadonlySet<string>,
|
|
section: HideableGeneralSection,
|
|
): boolean {
|
|
return hidden.has(section);
|
|
}
|
|
|
|
/**
|
|
* Whether a toggle is hidden, either individually or because the whole
|
|
* Experimental page is hidden.
|
|
*/
|
|
export function hidesExperimentalSetting(
|
|
hidden: ReadonlySet<string>,
|
|
key: InstanceFeatureKey,
|
|
): boolean {
|
|
return hidden.has("instance.experimental") || hidden.has(experimentalSettingKey(key));
|
|
}
|