mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-27 11:20:42 +01:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work. > - The control plane must keep each active issue on a clear execution or recovery path. > - A missing issue disposition can require more than one bounded repair attempt. > - A server restart could lose that repair path or move source ownership to the recovery owner. > - A parked or expired retry could also make the user interface show a false healthy state. > - Concurrent recovery loops must not schedule the same repair attempt twice. > - This pull request keeps retry state durable, makes scheduling atomic, and keeps source ownership stable. > - The benefit is that recovery continues after a restart and operators see the correct state. ## Linked Issues or Issue Description **What happened?** A run that ended without a valid issue disposition could lose its repair path after a server restart. Manager recovery could also change the source owner. In addition, a parked or expired retry could make the issue look healthy when no active work existed. Concurrent reconciliation could also schedule the same repair attempt twice. **Expected behavior** Paperclip must keep bounded source and manager repair attempts across restarts. Recovery ownership must stay separate from source issue ownership. The server and user interface must report only a live retry as active work. Each repair attempt must be scheduled at most once per company. **Steps to reproduce** 1. Start an agent run on an issue. 2. End the run without a valid issue disposition. 3. Let the first repair attempt schedule a retry. 4. Restart the server, let the retry time pass without a live run, or start two reconciliation loops together. 5. Observe that the repair path can stop, the issue can show a false healthy state, or duplicate retries can be created. **Paperclip version or commit** The problem existed on `master` before candidate head `d8e620fe86bade7df18decac332007f5821ae04f`. **Deployment mode** The problem affects self-hosted servers and local builds that use automatic recovery. ## What Changed - Persist bounded source-owner and manager repair lineages with stable fingerprints and retry limits. - Resume incomplete disposition repairs after a server restart. - Keep recovery ownership separate from source issue ownership and enforce source mutation authority. - Project live retry evidence into issue and blocker summaries. - Show recovery owner, return owner, attempt count, and retry state in the board user interface. - Treat expired or parked retries as attention states unless a queued or running attempt exists. - Atomically deduplicate disposition-repair wake requests with a company-scoped partial unique index. - Reuse the winning run when concurrent reconciliation loses the uniqueness race, without duplicate scheduling activity. - Honor disabled on-demand wake policy before recovery scheduling and again before delayed retry promotion. - Keep the new index migration safe for lagging seeded databases that already contain the index. - Add server and user interface tests for recovery, restart, ownership, retry, concurrency, and blocker states. - Update the implementation and execution semantics documents. ## Verification - Focused server recovery and ownership suites: 282 tests passed on the repaired base candidate. - Focused user interface recovery suites: 128 tests passed on the repaired base candidate. - Atomic-deduplication schema and recovery suites: 111 tests passed on the first Greptile repair. - Recovery and scheduled-retry wake-policy suites: 126 tests passed at `d8e620fe86bade7df18decac332007f5821ae04f`. - The exact lagging-source migration-order test passed after the index migration became idempotent: 1 test passed and 62 unrelated tests were skipped. - `@paperclipai/db` and `@paperclipai/server` typechecks passed at the current head. - Migration generation and migration safety checks passed for migration `0226_tan_colossus.sql`. - `pnpm check:token-gates` passed on the repaired base candidate. - `pnpm -r typecheck` passed on the repaired base candidate. - `pnpm build` passed on the repaired base candidate. - `pnpm test:run` passed 4,540 tests on the repaired base candidate. Four fixed-port cases met listeners that already existed on the host. - The two unchanged fixed-port files passed in an isolated network namespace: 129 tests passed and 27 tests were skipped. - Independent Security and QA reviews approved `63c0423aab54c66f2293a20b0fb3f3b013ee3ba8`; exact-head re-review is required after automated checks settle on `d8e620fe86bade7df18decac332007f5821ae04f`. ## Risks - Recovery orchestration affects issue liveness and ownership. The new paths use bounded attempts, stable fingerprints, row locks, authority checks, and database uniqueness. - A conservative attention state can show more warnings when a scheduled retry has no queued or running attempt. It does not hide stopped work. - Migration `0226_tan_colossus.sql` creates a partial unique index on a known-large table. Migrations run transactionally, so `CONCURRENTLY` is unavailable. The matching disposition-repair key namespace is introduced by this release, so deployed databases have no matching rows before the index is added. > For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and discuss it in `#dev` before opening the PR. Feature PRs that overlap with planned core work may need to be redirected — check the roadmap first. See `CONTRIBUTING.md`. ## Model Used - OpenAI Codex from the GPT-5 model family used agentic reasoning, tool use, and code execution. The runtime did not expose the exact model ID or context window. - Anthropic Claude Opus 5 used a 1M context window, tool use, and code execution for part of the user interface repair, as recorded in the commit history. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing> Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
1007 lines
37 KiB
TypeScript
1007 lines
37 KiB
TypeScript
import { randomUUID } from "node:crypto";
|
|
import { eq } from "drizzle-orm";
|
|
import { afterAll, afterEach, beforeAll, describe, expect, it } from "vitest";
|
|
import {
|
|
activityLog,
|
|
agents,
|
|
agentWakeupRequests,
|
|
approvals,
|
|
companies,
|
|
createDb,
|
|
heartbeatRuns,
|
|
issueApprovals,
|
|
issueRelations,
|
|
issueThreadInteractions,
|
|
issues,
|
|
} from "@paperclipai/db";
|
|
import {
|
|
getEmbeddedPostgresTestSupport,
|
|
startEmbeddedPostgresTestDatabase,
|
|
} from "./helpers/embedded-postgres.js";
|
|
import { issueService } from "../services/issues.js";
|
|
import { buildIssueGraphLivenessIncidentKey } from "../services/recovery/origins.js";
|
|
|
|
const embeddedPostgresSupport = await getEmbeddedPostgresTestSupport();
|
|
const describeEmbeddedPostgres = embeddedPostgresSupport.supported ? describe : describe.skip;
|
|
|
|
if (!embeddedPostgresSupport.supported) {
|
|
console.warn(
|
|
`Skipping embedded Postgres issue blocker attention tests on this host: ${embeddedPostgresSupport.reason ?? "unsupported environment"}`,
|
|
);
|
|
}
|
|
|
|
describeEmbeddedPostgres("issue blocker attention", () => {
|
|
let db!: ReturnType<typeof createDb>;
|
|
let svc!: ReturnType<typeof issueService>;
|
|
let tempDb: Awaited<ReturnType<typeof startEmbeddedPostgresTestDatabase>> | null = null;
|
|
|
|
beforeAll(async () => {
|
|
tempDb = await startEmbeddedPostgresTestDatabase("paperclip-issue-blocker-attention-");
|
|
db = createDb(tempDb.connectionString);
|
|
svc = issueService(db);
|
|
}, 20_000);
|
|
|
|
afterEach(async () => {
|
|
await db.delete(issueThreadInteractions);
|
|
await db.delete(issueApprovals);
|
|
await db.delete(approvals);
|
|
await db.delete(activityLog);
|
|
await db.delete(heartbeatRuns);
|
|
await db.delete(agentWakeupRequests);
|
|
await db.delete(issueRelations);
|
|
await db.delete(issues);
|
|
await db.delete(agents);
|
|
await db.delete(companies);
|
|
});
|
|
|
|
afterAll(async () => {
|
|
await tempDb?.cleanup();
|
|
});
|
|
|
|
async function createCompany(prefix = "PBA") {
|
|
const companyId = randomUUID();
|
|
const agentId = randomUUID();
|
|
const pausedAgentId = randomUUID();
|
|
await db.insert(companies).values({
|
|
id: companyId,
|
|
name: `Company ${prefix}`,
|
|
issuePrefix: prefix,
|
|
requireBoardApprovalForNewAgents: false,
|
|
});
|
|
await db.insert(agents).values([
|
|
{
|
|
id: agentId,
|
|
companyId,
|
|
name: `${prefix} Agent`,
|
|
role: "engineer",
|
|
status: "idle",
|
|
},
|
|
{
|
|
id: pausedAgentId,
|
|
companyId,
|
|
name: `${prefix} Paused`,
|
|
role: "engineer",
|
|
status: "paused",
|
|
},
|
|
]);
|
|
return { companyId, agentId, pausedAgentId };
|
|
}
|
|
|
|
async function insertIssue(input: {
|
|
companyId: string;
|
|
id?: string;
|
|
identifier: string;
|
|
title: string;
|
|
status: string;
|
|
parentId?: string | null;
|
|
assigneeAgentId?: string | null;
|
|
assigneeUserId?: string | null;
|
|
originKind?: string | null;
|
|
originId?: string | null;
|
|
originFingerprint?: string | null;
|
|
executionState?: Record<string, unknown> | null;
|
|
description?: string | null;
|
|
}) {
|
|
const id = input.id ?? randomUUID();
|
|
await db.insert(issues).values({
|
|
id,
|
|
companyId: input.companyId,
|
|
identifier: input.identifier,
|
|
title: input.title,
|
|
status: input.status,
|
|
priority: "medium",
|
|
parentId: input.parentId ?? null,
|
|
assigneeAgentId: input.assigneeAgentId ?? null,
|
|
assigneeUserId: input.assigneeUserId ?? null,
|
|
originKind: input.originKind ?? "manual",
|
|
originId: input.originId ?? null,
|
|
originFingerprint: input.originFingerprint ?? "default",
|
|
executionState: input.executionState ?? null,
|
|
description: input.description ?? null,
|
|
});
|
|
return id;
|
|
}
|
|
|
|
async function block(input: { companyId: string; blockerIssueId: string; blockedIssueId: string }) {
|
|
await db.insert(issueRelations).values({
|
|
companyId: input.companyId,
|
|
issueId: input.blockerIssueId,
|
|
relatedIssueId: input.blockedIssueId,
|
|
type: "blocks",
|
|
});
|
|
}
|
|
|
|
async function activeRun(input: {
|
|
companyId: string;
|
|
agentId: string;
|
|
issueId: string;
|
|
status?: string;
|
|
current?: boolean;
|
|
scheduledRetryAt?: Date;
|
|
}) {
|
|
const runId = randomUUID();
|
|
await db.insert(heartbeatRuns).values({
|
|
id: runId,
|
|
companyId: input.companyId,
|
|
agentId: input.agentId,
|
|
status: input.status ?? "running",
|
|
contextSnapshot: { issueId: input.issueId },
|
|
scheduledRetryAt: input.scheduledRetryAt,
|
|
});
|
|
if (input.current !== false) {
|
|
await db.update(issues).set({ executionRunId: runId }).where(eq(issues.id, input.issueId));
|
|
}
|
|
return runId;
|
|
}
|
|
|
|
it("classifies a blocked parent as covered when its child has a running execution path", async () => {
|
|
const { companyId, agentId } = await createCompany("PBC");
|
|
const parentId = await insertIssue({ companyId, identifier: "PBC-1", title: "Parent", status: "blocked" });
|
|
const childId = await insertIssue({
|
|
companyId,
|
|
identifier: "PBC-2",
|
|
title: "Running child",
|
|
status: "todo",
|
|
parentId,
|
|
assigneeAgentId: agentId,
|
|
});
|
|
await block({ companyId, blockerIssueId: childId, blockedIssueId: parentId });
|
|
await activeRun({ companyId, agentId, issueId: childId });
|
|
|
|
const parent = (await svc.list(companyId, { status: "blocked" })).find((issue) => issue.id === parentId);
|
|
|
|
expect(parent?.blockerAttention).toMatchObject({
|
|
state: "covered",
|
|
reason: "active_child",
|
|
unresolvedBlockerCount: 1,
|
|
coveredBlockerCount: 1,
|
|
attentionBlockerCount: 0,
|
|
sampleBlockerIdentifier: "PBC-2",
|
|
});
|
|
});
|
|
|
|
it("classifies an assigned backlog blocker leaf without a waiting path as attention-needed", async () => {
|
|
const { companyId, agentId } = await createCompany("PBB");
|
|
const parentId = await insertIssue({ companyId, identifier: "PBB-1", title: "Parent", status: "blocked" });
|
|
const blockerId = await insertIssue({
|
|
companyId,
|
|
identifier: "PBB-2",
|
|
title: "Parked assigned blocker",
|
|
status: "backlog",
|
|
assigneeAgentId: agentId,
|
|
});
|
|
await block({ companyId, blockerIssueId: blockerId, blockedIssueId: parentId });
|
|
|
|
const parent = (await svc.list(companyId, { status: "blocked" })).find((issue) => issue.id === parentId);
|
|
|
|
expect(parent?.blockerAttention).toMatchObject({
|
|
state: "needs_attention",
|
|
reason: "attention_required",
|
|
unresolvedBlockerCount: 1,
|
|
coveredBlockerCount: 0,
|
|
stalledBlockerCount: 0,
|
|
attentionBlockerCount: 1,
|
|
sampleBlockerIdentifier: "PBB-2",
|
|
});
|
|
});
|
|
|
|
it("treats a human-owned backlog blocker as a covered waiting path", async () => {
|
|
const { companyId } = await createCompany("PBU");
|
|
const parentId = await insertIssue({ companyId, identifier: "PBU-1", title: "Parent", status: "blocked" });
|
|
const blockerId = await insertIssue({
|
|
companyId,
|
|
identifier: "PBU-2",
|
|
title: "Human-owned parked blocker",
|
|
status: "backlog",
|
|
assigneeUserId: "board-user-1",
|
|
});
|
|
await block({ companyId, blockerIssueId: blockerId, blockedIssueId: parentId });
|
|
|
|
const parent = (await svc.list(companyId, { status: "blocked" })).find((issue) => issue.id === parentId);
|
|
|
|
expect(parent?.blockerAttention).toMatchObject({
|
|
state: "covered",
|
|
reason: "active_dependency",
|
|
unresolvedBlockerCount: 1,
|
|
coveredBlockerCount: 1,
|
|
attentionBlockerCount: 0,
|
|
sampleBlockerIdentifier: "PBU-2",
|
|
});
|
|
});
|
|
|
|
it("keeps mixed blockers attention-required when any path lacks active work", async () => {
|
|
const { companyId, agentId } = await createCompany("PBM");
|
|
const parentId = await insertIssue({ companyId, identifier: "PBM-1", title: "Parent", status: "blocked" });
|
|
const activeChildId = await insertIssue({
|
|
companyId,
|
|
identifier: "PBM-2",
|
|
title: "Running child",
|
|
status: "todo",
|
|
parentId,
|
|
assigneeAgentId: agentId,
|
|
});
|
|
const idleBlockerId = await insertIssue({
|
|
companyId,
|
|
identifier: "PBM-3",
|
|
title: "Idle blocker",
|
|
status: "todo",
|
|
assigneeAgentId: agentId,
|
|
});
|
|
await block({ companyId, blockerIssueId: activeChildId, blockedIssueId: parentId });
|
|
await block({ companyId, blockerIssueId: idleBlockerId, blockedIssueId: parentId });
|
|
await activeRun({ companyId, agentId, issueId: activeChildId });
|
|
|
|
const parent = (await svc.list(companyId, { status: "blocked" })).find((issue) => issue.id === parentId);
|
|
|
|
expect(parent?.blockerAttention).toMatchObject({
|
|
state: "needs_attention",
|
|
reason: "attention_required",
|
|
unresolvedBlockerCount: 2,
|
|
coveredBlockerCount: 1,
|
|
attentionBlockerCount: 1,
|
|
sampleBlockerIdentifier: "PBM-3",
|
|
});
|
|
});
|
|
|
|
it("ignores cancelled direct children when counting unresolved blocker attention", async () => {
|
|
const { companyId, agentId } = await createCompany("PBD");
|
|
const parentId = await insertIssue({ companyId, identifier: "PBD-1", title: "Parent", status: "blocked" });
|
|
const activeBlockerOneId = await insertIssue({
|
|
companyId,
|
|
identifier: "PBD-2",
|
|
title: "Running dependency one",
|
|
status: "todo",
|
|
assigneeAgentId: agentId,
|
|
});
|
|
const activeBlockerTwoId = await insertIssue({
|
|
companyId,
|
|
identifier: "PBD-3",
|
|
title: "Running dependency two",
|
|
status: "todo",
|
|
assigneeAgentId: agentId,
|
|
});
|
|
await insertIssue({
|
|
companyId,
|
|
identifier: "PBD-4",
|
|
title: "Cancelled child",
|
|
status: "cancelled",
|
|
parentId,
|
|
assigneeAgentId: agentId,
|
|
});
|
|
await block({ companyId, blockerIssueId: activeBlockerOneId, blockedIssueId: parentId });
|
|
await block({ companyId, blockerIssueId: activeBlockerTwoId, blockedIssueId: parentId });
|
|
await activeRun({ companyId, agentId, issueId: activeBlockerOneId });
|
|
await activeRun({ companyId, agentId, issueId: activeBlockerTwoId });
|
|
|
|
const parent = (await svc.list(companyId, { status: "blocked" })).find((issue) => issue.id === parentId);
|
|
|
|
expect(parent?.blockerAttention).toMatchObject({
|
|
state: "covered",
|
|
reason: "active_dependency",
|
|
unresolvedBlockerCount: 2,
|
|
coveredBlockerCount: 2,
|
|
stalledBlockerCount: 0,
|
|
attentionBlockerCount: 0,
|
|
});
|
|
expect(parent?.blockerAttention?.sampleBlockerIdentifier).not.toBe("PBD-4");
|
|
});
|
|
|
|
it("covers recursive blocker chains when the downstream leaf has active work", async () => {
|
|
const { companyId, agentId } = await createCompany("PBR");
|
|
const parentId = await insertIssue({ companyId, identifier: "PBR-1", title: "Parent", status: "blocked" });
|
|
const blockerId = await insertIssue({ companyId, identifier: "PBR-2", title: "Blocked dependency", status: "blocked" });
|
|
const leafId = await insertIssue({
|
|
companyId,
|
|
identifier: "PBR-3",
|
|
title: "Running leaf",
|
|
status: "todo",
|
|
assigneeAgentId: agentId,
|
|
});
|
|
await block({ companyId, blockerIssueId: blockerId, blockedIssueId: parentId });
|
|
await block({ companyId, blockerIssueId: leafId, blockedIssueId: blockerId });
|
|
await activeRun({ companyId, agentId, issueId: leafId });
|
|
|
|
const parent = (await svc.list(companyId, { status: "blocked" })).find((issue) => issue.id === parentId);
|
|
|
|
expect(parent?.blockerAttention).toMatchObject({
|
|
state: "covered",
|
|
reason: "active_dependency",
|
|
unresolvedBlockerCount: 1,
|
|
coveredBlockerCount: 1,
|
|
attentionBlockerCount: 0,
|
|
sampleBlockerIdentifier: "PBR-3",
|
|
});
|
|
});
|
|
|
|
it("does not let another company's active run cover the blocker", async () => {
|
|
const { companyId, agentId } = await createCompany("PBS");
|
|
const other = await createCompany("PBT");
|
|
const parentId = await insertIssue({ companyId, identifier: "PBS-1", title: "Parent", status: "blocked" });
|
|
const blockerId = await insertIssue({
|
|
companyId,
|
|
identifier: "PBS-2",
|
|
title: "Same-company blocker",
|
|
status: "todo",
|
|
assigneeAgentId: agentId,
|
|
});
|
|
await block({ companyId, blockerIssueId: blockerId, blockedIssueId: parentId });
|
|
await activeRun({ companyId: other.companyId, agentId: other.agentId, issueId: blockerId });
|
|
|
|
const parent = (await svc.list(companyId, { status: "blocked" })).find((issue) => issue.id === parentId);
|
|
|
|
expect(parent?.blockerAttention).toMatchObject({
|
|
state: "needs_attention",
|
|
reason: "attention_required",
|
|
unresolvedBlockerCount: 1,
|
|
coveredBlockerCount: 0,
|
|
attentionBlockerCount: 1,
|
|
sampleBlockerIdentifier: "PBS-2",
|
|
});
|
|
});
|
|
|
|
it("does not cover a blocker from a stale run the issue no longer owns", async () => {
|
|
const { companyId, agentId } = await createCompany("PBX");
|
|
const parentId = await insertIssue({ companyId, identifier: "PBX-1", title: "Parent", status: "blocked" });
|
|
const blockerId = await insertIssue({
|
|
companyId,
|
|
identifier: "PBX-2",
|
|
title: "Previously running blocker",
|
|
status: "blocked",
|
|
assigneeAgentId: agentId,
|
|
});
|
|
await block({ companyId, blockerIssueId: blockerId, blockedIssueId: parentId });
|
|
await activeRun({ companyId, agentId, issueId: blockerId, current: false });
|
|
|
|
const parent = (await svc.list(companyId, { status: "blocked" })).find((issue) => issue.id === parentId);
|
|
|
|
expect(parent?.blockerAttention).toMatchObject({
|
|
state: "needs_attention",
|
|
reason: "attention_required",
|
|
unresolvedBlockerCount: 1,
|
|
coveredBlockerCount: 0,
|
|
attentionBlockerCount: 1,
|
|
sampleBlockerIdentifier: "PBX-2",
|
|
});
|
|
});
|
|
|
|
it("flags a chain whose leaf is in_review without an action path as stalled", async () => {
|
|
const { companyId, agentId } = await createCompany("PBV");
|
|
const parentId = await insertIssue({ companyId, identifier: "PBV-1", title: "Parent", status: "blocked" });
|
|
const reviewLeafId = await insertIssue({
|
|
companyId,
|
|
identifier: "PBV-2",
|
|
title: "Stalled review leaf",
|
|
status: "in_review",
|
|
assigneeAgentId: agentId,
|
|
});
|
|
await block({ companyId, blockerIssueId: reviewLeafId, blockedIssueId: parentId });
|
|
|
|
const parent = (await svc.list(companyId, { status: "blocked" })).find((issue) => issue.id === parentId);
|
|
|
|
expect(parent?.blockerAttention).toMatchObject({
|
|
state: "stalled",
|
|
reason: "stalled_review",
|
|
unresolvedBlockerCount: 1,
|
|
coveredBlockerCount: 0,
|
|
stalledBlockerCount: 1,
|
|
attentionBlockerCount: 0,
|
|
sampleBlockerIdentifier: "PBV-2",
|
|
sampleStalledBlockerIdentifier: "PBV-2",
|
|
});
|
|
});
|
|
|
|
it("does not flag an in_review leaf as stalled when an active run is still progressing it", async () => {
|
|
const { companyId, agentId } = await createCompany("PBW");
|
|
const parentId = await insertIssue({ companyId, identifier: "PBW-1", title: "Parent", status: "blocked" });
|
|
const reviewLeafId = await insertIssue({
|
|
companyId,
|
|
identifier: "PBW-2",
|
|
title: "Active review leaf",
|
|
status: "in_review",
|
|
assigneeAgentId: agentId,
|
|
});
|
|
await block({ companyId, blockerIssueId: reviewLeafId, blockedIssueId: parentId });
|
|
await activeRun({ companyId, agentId, issueId: reviewLeafId });
|
|
|
|
const parent = (await svc.list(companyId, { status: "blocked" })).find((issue) => issue.id === parentId);
|
|
|
|
expect(parent?.blockerAttention).toMatchObject({
|
|
state: "covered",
|
|
stalledBlockerCount: 0,
|
|
});
|
|
});
|
|
|
|
it("flags a deep chain whose leaf is stalled in_review through multiple layers", async () => {
|
|
const { companyId, agentId } = await createCompany("PBZ");
|
|
const rootId = await insertIssue({ companyId, identifier: "PBZ-1", title: "Root", status: "blocked" });
|
|
const midId = await insertIssue({ companyId, identifier: "PBZ-2", title: "Mid blocker", status: "blocked" });
|
|
const leafId = await insertIssue({
|
|
companyId,
|
|
identifier: "PBZ-3",
|
|
title: "Stalled leaf",
|
|
status: "in_review",
|
|
assigneeAgentId: agentId,
|
|
});
|
|
await block({ companyId, blockerIssueId: midId, blockedIssueId: rootId });
|
|
await block({ companyId, blockerIssueId: leafId, blockedIssueId: midId });
|
|
|
|
const root = (await svc.list(companyId, { status: "blocked" })).find((issue) => issue.id === rootId);
|
|
|
|
expect(root?.blockerAttention).toMatchObject({
|
|
state: "stalled",
|
|
reason: "stalled_review",
|
|
stalledBlockerCount: 1,
|
|
sampleStalledBlockerIdentifier: "PBZ-3",
|
|
});
|
|
});
|
|
|
|
it("returns the direct path and link details when an intermediate blocker is selected", async () => {
|
|
const { companyId, agentId } = await createCompany("PBI");
|
|
const rootId = await insertIssue({ companyId, identifier: "PBI-1", title: "Root", status: "blocked" });
|
|
const directId = await insertIssue({
|
|
companyId,
|
|
identifier: "PBI-2",
|
|
title: "Direct blocker",
|
|
status: "blocked",
|
|
});
|
|
const intermediateId = await insertIssue({
|
|
companyId,
|
|
identifier: "PBI-3",
|
|
title: "Stalled intermediate review",
|
|
status: "in_review",
|
|
assigneeAgentId: agentId,
|
|
});
|
|
const leafId = await insertIssue({
|
|
companyId,
|
|
identifier: "PBI-4",
|
|
title: "Downstream leaf",
|
|
status: "todo",
|
|
assigneeAgentId: agentId,
|
|
});
|
|
await block({ companyId, blockerIssueId: directId, blockedIssueId: rootId });
|
|
await block({ companyId, blockerIssueId: intermediateId, blockedIssueId: directId });
|
|
await block({ companyId, blockerIssueId: leafId, blockedIssueId: intermediateId });
|
|
|
|
const root = (await svc.list(companyId, { status: "blocked" })).find((issue) => issue.id === rootId);
|
|
|
|
expect(root?.blockerAttention).toMatchObject({
|
|
state: "stalled",
|
|
directBlockerIssueId: directId,
|
|
terminalBlockerIssueId: intermediateId,
|
|
terminalBlocker: {
|
|
id: intermediateId,
|
|
identifier: "PBI-3",
|
|
title: "Stalled intermediate review",
|
|
},
|
|
});
|
|
});
|
|
|
|
it("prefers needs_attention over stalled when the chain also has a hard attention case", async () => {
|
|
const { companyId, agentId } = await createCompany("PBQ");
|
|
const parentId = await insertIssue({ companyId, identifier: "PBQ-1", title: "Parent", status: "blocked" });
|
|
const reviewLeafId = await insertIssue({
|
|
companyId,
|
|
identifier: "PBQ-2",
|
|
title: "Stalled review leaf",
|
|
status: "in_review",
|
|
assigneeAgentId: agentId,
|
|
});
|
|
const cancelledLeafId = await insertIssue({
|
|
companyId,
|
|
identifier: "PBQ-3",
|
|
title: "Cancelled blocker",
|
|
status: "cancelled",
|
|
assigneeAgentId: agentId,
|
|
});
|
|
await block({ companyId, blockerIssueId: reviewLeafId, blockedIssueId: parentId });
|
|
await block({ companyId, blockerIssueId: cancelledLeafId, blockedIssueId: parentId });
|
|
|
|
const parent = (await svc.list(companyId, { status: "blocked" })).find((issue) => issue.id === parentId);
|
|
|
|
expect(parent?.blockerAttention).toMatchObject({
|
|
state: "needs_attention",
|
|
reason: "attention_required",
|
|
coveredBlockerCount: 0,
|
|
stalledBlockerCount: 1,
|
|
attentionBlockerCount: 1,
|
|
sampleStalledBlockerIdentifier: "PBQ-2",
|
|
});
|
|
});
|
|
|
|
it("treats open liveness escalation blockers as covered waiting paths", async () => {
|
|
const { companyId, agentId } = await createCompany("PBL");
|
|
const parentId = await insertIssue({ companyId, identifier: "PBL-1", title: "Parent", status: "blocked" });
|
|
const cancelledLeafId = await insertIssue({
|
|
companyId,
|
|
identifier: "PBL-2",
|
|
title: "Cancelled blocker",
|
|
status: "cancelled",
|
|
assigneeAgentId: agentId,
|
|
});
|
|
const incidentKey = [
|
|
"harness_liveness",
|
|
companyId,
|
|
parentId,
|
|
"blocked_by_cancelled_issue",
|
|
cancelledLeafId,
|
|
].join(":");
|
|
const escalationId = await insertIssue({
|
|
companyId,
|
|
identifier: "PBL-3",
|
|
title: "Liveness escalation",
|
|
status: "todo",
|
|
assigneeAgentId: agentId,
|
|
originKind: "harness_liveness_escalation",
|
|
originId: incidentKey,
|
|
originFingerprint: [
|
|
"harness_liveness_leaf",
|
|
companyId,
|
|
"blocked_by_cancelled_issue",
|
|
cancelledLeafId,
|
|
].join(":"),
|
|
});
|
|
await block({ companyId, blockerIssueId: cancelledLeafId, blockedIssueId: parentId });
|
|
await block({ companyId, blockerIssueId: escalationId, blockedIssueId: parentId });
|
|
|
|
const parent = (await svc.list(companyId, { status: "blocked,todo" })).find((issue) => issue.id === parentId);
|
|
|
|
expect(parent?.blockerAttention).toMatchObject({
|
|
state: "covered",
|
|
reason: "active_dependency",
|
|
unresolvedBlockerCount: 2,
|
|
coveredBlockerCount: 2,
|
|
attentionBlockerCount: 0,
|
|
});
|
|
});
|
|
|
|
it("does not treat cancelled liveness escalation issues as covered waiting paths", async () => {
|
|
const { companyId, agentId } = await createCompany("PBLX");
|
|
const parentId = await insertIssue({ companyId, identifier: "PBLX-1", title: "Parent", status: "blocked" });
|
|
const cancelledLeafId = await insertIssue({
|
|
companyId,
|
|
identifier: "PBLX-2",
|
|
title: "Cancelled blocker",
|
|
status: "cancelled",
|
|
assigneeAgentId: agentId,
|
|
});
|
|
await insertIssue({
|
|
companyId,
|
|
identifier: "PBLX-3",
|
|
title: "Cancelled liveness escalation",
|
|
status: "cancelled",
|
|
assigneeAgentId: agentId,
|
|
originKind: "harness_liveness_escalation",
|
|
originId: [
|
|
"harness_liveness",
|
|
companyId,
|
|
parentId,
|
|
"blocked_by_cancelled_issue",
|
|
cancelledLeafId,
|
|
].join(":"),
|
|
});
|
|
await block({ companyId, blockerIssueId: cancelledLeafId, blockedIssueId: parentId });
|
|
|
|
const parent = (await svc.list(companyId, { attention: "blocked" })).find((issue) => issue.id === parentId);
|
|
|
|
expect(parent?.blockedInboxAttention).toMatchObject({
|
|
state: "needs_attention",
|
|
reason: "blocked_by_cancelled_issue",
|
|
leafIssue: { id: cancelledLeafId, identifier: "PBLX-2" },
|
|
});
|
|
});
|
|
|
|
it("does not treat an expired scheduled retry as actively covered work", async () => {
|
|
const pinnedNow = new Date("2026-08-20T12:00:00.000Z");
|
|
const expiredRetryAt = new Date(pinnedNow.getTime() - 60_000);
|
|
const { companyId, agentId } = await createCompany("PBY");
|
|
const parentId = await insertIssue({ companyId, identifier: "PBY-1", title: "Parent", status: "blocked" });
|
|
const blockerId = await insertIssue({
|
|
companyId,
|
|
identifier: "PBY-2",
|
|
title: "Retrying blocker",
|
|
status: "blocked",
|
|
assigneeAgentId: agentId,
|
|
});
|
|
await block({ companyId, blockerIssueId: blockerId, blockedIssueId: parentId });
|
|
await activeRun({
|
|
companyId,
|
|
agentId,
|
|
issueId: blockerId,
|
|
status: "scheduled_retry",
|
|
scheduledRetryAt: expiredRetryAt,
|
|
});
|
|
|
|
const parent = (await svc.list(companyId, { status: "blocked" })).find((issue) => issue.id === parentId);
|
|
|
|
expect(parent?.blockerAttention).toMatchObject({
|
|
state: "needs_attention",
|
|
reason: "attention_required",
|
|
unresolvedBlockerCount: 1,
|
|
coveredBlockerCount: 0,
|
|
attentionBlockerCount: 1,
|
|
sampleBlockerIdentifier: "PBY-2",
|
|
});
|
|
});
|
|
|
|
it("returns blocked inbox attention for an unassigned blocker leaf and supports count/search", async () => {
|
|
const { companyId } = await createCompany("BIA");
|
|
const parentId = await insertIssue({ companyId, identifier: "BIA-1", title: "Blocked source", status: "blocked" });
|
|
const blockerId = await insertIssue({
|
|
companyId,
|
|
identifier: "BIA-2",
|
|
title: "Unassigned leaf",
|
|
status: "todo",
|
|
});
|
|
await block({ companyId, blockerIssueId: blockerId, blockedIssueId: parentId });
|
|
|
|
const rows = await svc.list(companyId, { attention: "blocked", q: "BIA-2" });
|
|
|
|
expect(rows).toHaveLength(1);
|
|
expect(rows[0]?.id).toBe(parentId);
|
|
expect(rows[0]?.blockedBy).toEqual([
|
|
expect.objectContaining({ id: blockerId, identifier: "BIA-2" }),
|
|
]);
|
|
expect(rows[0]?.blockedInboxAttention).toMatchObject({
|
|
kind: "blocked",
|
|
state: "needs_attention",
|
|
reason: "blocked_by_unassigned_issue",
|
|
severity: "critical",
|
|
owner: { type: "unknown", agentId: null, userId: null },
|
|
action: { label: "Assign blocker" },
|
|
leafIssue: { id: blockerId, identifier: "BIA-2" },
|
|
redaction: { secretFieldsOmitted: true },
|
|
});
|
|
await expect(svc.count(companyId, { attention: "blocked" })).resolves.toBe(1);
|
|
});
|
|
|
|
it("surfaces cancelled-blocker attention on an assigned todo source", async () => {
|
|
const { companyId, agentId } = await createCompany("BICX");
|
|
const sourceId = await insertIssue({
|
|
companyId,
|
|
identifier: "BICX-1",
|
|
title: "Dispatch-suppressed source",
|
|
status: "todo",
|
|
assigneeAgentId: agentId,
|
|
});
|
|
const blockerId = await insertIssue({
|
|
companyId,
|
|
identifier: "BICX-2",
|
|
title: "Cancelled dependency",
|
|
status: "cancelled",
|
|
assigneeAgentId: agentId,
|
|
});
|
|
await block({ companyId, blockerIssueId: blockerId, blockedIssueId: sourceId });
|
|
|
|
const rows = await svc.list(companyId, { attention: "blocked" });
|
|
const source = rows.find((issue) => issue.id === sourceId);
|
|
|
|
expect(source?.blockedInboxAttention).toMatchObject({
|
|
kind: "blocked",
|
|
state: "needs_attention",
|
|
reason: "blocked_by_cancelled_issue",
|
|
owner: { type: "agent", agentId },
|
|
action: { label: "Replace blocker" },
|
|
leafIssue: { id: blockerId, identifier: "BICX-2" },
|
|
});
|
|
});
|
|
|
|
it("redacts external wait details from blocked inbox payloads and search", async () => {
|
|
const { companyId } = await createCompany("BIX");
|
|
const owner = "Private Vendor Security Team";
|
|
const action = "Send the confidential access token for customer Alpha";
|
|
const issueId = await insertIssue({
|
|
companyId,
|
|
identifier: "BIX-1",
|
|
title: "Blocked on vendor",
|
|
status: "blocked",
|
|
description: [
|
|
"Public context stays visible.",
|
|
`external owner: ${owner}`,
|
|
`external action: ${action}`,
|
|
"Continue after the vendor confirms receipt.",
|
|
].join("\n"),
|
|
});
|
|
|
|
const rows = await svc.list(companyId, { attention: "blocked" });
|
|
const issue = rows.find((row) => row.id === issueId);
|
|
|
|
expect(issue?.description).toContain("Public context stays visible.");
|
|
expect(issue?.description).toContain("Continue after the vendor confirms receipt.");
|
|
expect(issue?.description).not.toContain(owner);
|
|
expect(issue?.description).not.toContain(action);
|
|
expect(issue?.blockedInboxAttention).toMatchObject({
|
|
state: "external_wait",
|
|
reason: "external_owner_action",
|
|
owner: { type: "external", label: null },
|
|
action: { label: "External owner action", detail: null },
|
|
redaction: { externalDetailsRedacted: true, secretFieldsOmitted: true },
|
|
});
|
|
expect(JSON.stringify(issue?.blockedInboxAttention)).not.toContain(owner);
|
|
expect(JSON.stringify(issue?.blockedInboxAttention)).not.toContain(action);
|
|
|
|
await expect(svc.list(companyId, { attention: "blocked", q: owner })).resolves.toEqual([]);
|
|
await expect(svc.count(companyId, { attention: "blocked", q: action })).resolves.toBe(0);
|
|
await expect(svc.count(companyId, { attention: "blocked", q: "Public context" })).resolves.toBe(1);
|
|
});
|
|
|
|
it("excludes healthy active blockers from blocked inbox attention", async () => {
|
|
const { companyId, agentId } = await createCompany("BIB");
|
|
const parentId = await insertIssue({ companyId, identifier: "BIB-1", title: "Blocked source", status: "blocked" });
|
|
const blockerId = await insertIssue({
|
|
companyId,
|
|
identifier: "BIB-2",
|
|
title: "Running leaf",
|
|
status: "todo",
|
|
assigneeAgentId: agentId,
|
|
});
|
|
await block({ companyId, blockerIssueId: blockerId, blockedIssueId: parentId });
|
|
await activeRun({ companyId, agentId, issueId: blockerId });
|
|
|
|
expect(await svc.list(companyId, { attention: "blocked" })).toEqual([]);
|
|
});
|
|
|
|
it("classifies assigned backlog and invalid review leaves for blocked inbox attention", async () => {
|
|
const { companyId, agentId, pausedAgentId } = await createCompany("BIC");
|
|
const backlogParentId = await insertIssue({ companyId, identifier: "BIC-1", title: "Blocked by parked work", status: "blocked" });
|
|
const backlogLeafId = await insertIssue({
|
|
companyId,
|
|
identifier: "BIC-2",
|
|
title: "Parked blocker",
|
|
status: "backlog",
|
|
assigneeAgentId: agentId,
|
|
});
|
|
await block({ companyId, blockerIssueId: backlogLeafId, blockedIssueId: backlogParentId });
|
|
|
|
const reviewId = await insertIssue({
|
|
companyId,
|
|
identifier: "BIC-3",
|
|
title: "Invalid review",
|
|
status: "in_review",
|
|
assigneeAgentId: agentId,
|
|
executionState: {
|
|
status: "pending",
|
|
currentStageId: null,
|
|
currentStageIndex: null,
|
|
currentStageType: "review",
|
|
currentParticipant: { type: "agent", agentId: pausedAgentId },
|
|
returnAssignee: null,
|
|
reviewRequest: null,
|
|
completedStageIds: [],
|
|
lastDecisionId: null,
|
|
lastDecisionOutcome: null,
|
|
},
|
|
});
|
|
|
|
const rows = await svc.list(companyId, { attention: "blocked" });
|
|
const byId = new Map(rows.map((row) => [row.id, row]));
|
|
|
|
expect(byId.get(backlogParentId)?.blockedInboxAttention).toMatchObject({
|
|
reason: "blocked_by_assigned_backlog_issue",
|
|
severity: "high",
|
|
owner: { type: "agent", agentId },
|
|
leafIssue: { id: backlogLeafId },
|
|
});
|
|
expect(byId.get(reviewId)?.blockedInboxAttention).toMatchObject({
|
|
reason: "invalid_review_participant",
|
|
severity: "critical",
|
|
action: { label: "Repair review participant" },
|
|
});
|
|
});
|
|
|
|
it("classifies recovery issues and missing successful-run dispositions", async () => {
|
|
const { companyId, agentId } = await createCompany("BID");
|
|
const sourceId = await insertIssue({ companyId, identifier: "BID-1", title: "Stopped source", status: "blocked" });
|
|
const leafId = await insertIssue({ companyId, identifier: "BID-2", title: "Stopped leaf", status: "todo" });
|
|
const recoveryId = await insertIssue({
|
|
companyId,
|
|
identifier: "BID-3",
|
|
title: "Recovery issue",
|
|
status: "todo",
|
|
assigneeAgentId: agentId,
|
|
originKind: "harness_liveness_escalation",
|
|
originId: buildIssueGraphLivenessIncidentKey({
|
|
companyId,
|
|
issueId: sourceId,
|
|
state: "blocked_by_unassigned_issue",
|
|
blockerIssueId: leafId,
|
|
}),
|
|
});
|
|
const handoffId = await insertIssue({
|
|
companyId,
|
|
identifier: "BID-4",
|
|
title: "Needs disposition",
|
|
status: "in_progress",
|
|
assigneeAgentId: agentId,
|
|
});
|
|
await db.insert(activityLog).values({
|
|
companyId,
|
|
actorType: "system",
|
|
actorId: "system",
|
|
action: "issue.successful_run_handoff_required",
|
|
entityType: "issue",
|
|
entityId: handoffId,
|
|
agentId,
|
|
details: { sourceRunId: randomUUID(), detectedProgressSummary: "Progress was made" },
|
|
});
|
|
|
|
const rows = await svc.list(companyId, { attention: "blocked" });
|
|
const byId = new Map(rows.map((row) => [row.id, row]));
|
|
|
|
expect(byId.get(recoveryId)?.blockedInboxAttention).toMatchObject({
|
|
state: "recovery_open",
|
|
reason: "open_recovery_issue",
|
|
sourceIssue: { id: sourceId },
|
|
leafIssue: { id: leafId },
|
|
recoveryIssue: { id: recoveryId },
|
|
});
|
|
expect(byId.get(handoffId)?.blockedInboxAttention).toMatchObject({
|
|
state: "missing_disposition",
|
|
reason: "missing_successful_run_disposition",
|
|
owner: { type: "agent", agentId },
|
|
action: { label: "Choose disposition" },
|
|
});
|
|
|
|
const handoffRunId = await activeRun({ companyId, agentId, issueId: handoffId, current: false });
|
|
const liveRows = await svc.list(companyId, { attention: "blocked" });
|
|
expect(liveRows.some((row) => row.id === handoffId)).toBe(false);
|
|
|
|
await db.update(heartbeatRuns).set({ status: "succeeded" }).where(eq(heartbeatRuns.id, handoffRunId));
|
|
const stoppedRows = await svc.list(companyId, { attention: "blocked" });
|
|
expect(stoppedRows.find((row) => row.id === handoffId)?.blockedInboxAttention).toMatchObject({
|
|
state: "missing_disposition",
|
|
reason: "missing_successful_run_disposition",
|
|
});
|
|
|
|
const scheduledRetryRunId = randomUUID();
|
|
await db.insert(heartbeatRuns).values({
|
|
id: scheduledRetryRunId,
|
|
companyId,
|
|
agentId,
|
|
status: "scheduled_retry",
|
|
contextSnapshot: { taskId: handoffId },
|
|
scheduledRetryAt: new Date(Date.now() + 60_000),
|
|
scheduledRetryAttempt: 1,
|
|
});
|
|
const scheduledRows = await svc.list(companyId, { attention: "blocked" });
|
|
expect(scheduledRows.some((row) => row.id === handoffId)).toBe(false);
|
|
|
|
await db.update(heartbeatRuns).set({ status: "succeeded" }).where(eq(heartbeatRuns.id, scheduledRetryRunId));
|
|
const exhaustedRows = await svc.list(companyId, { attention: "blocked" });
|
|
expect(exhaustedRows.find((row) => row.id === handoffId)?.blockedInboxAttention).toMatchObject({
|
|
state: "missing_disposition",
|
|
reason: "missing_successful_run_disposition",
|
|
});
|
|
|
|
await db.insert(activityLog).values({
|
|
companyId,
|
|
actorType: "system",
|
|
actorId: "system",
|
|
action: "issue.successful_run_handoff_escalated",
|
|
entityType: "issue",
|
|
entityId: handoffId,
|
|
agentId,
|
|
details: { sourceRunId: randomUUID() },
|
|
});
|
|
const escalatedRows = await svc.list(companyId, { attention: "blocked" });
|
|
expect(escalatedRows.find((row) => row.id === handoffId)?.blockedInboxAttention).toMatchObject({
|
|
state: "missing_disposition",
|
|
reason: "missing_successful_run_disposition",
|
|
});
|
|
|
|
const escalatedLiveRunId = await activeRun({ companyId, agentId, issueId: handoffId, current: false });
|
|
const escalatedLiveRows = await svc.list(companyId, { attention: "blocked" });
|
|
expect(escalatedLiveRows.some((row) => row.id === handoffId)).toBe(false);
|
|
|
|
await db.update(heartbeatRuns).set({ status: "succeeded" }).where(eq(heartbeatRuns.id, escalatedLiveRunId));
|
|
const escalatedStoppedRows = await svc.list(companyId, { attention: "blocked" });
|
|
expect(escalatedStoppedRows.find((row) => row.id === handoffId)?.blockedInboxAttention).toMatchObject({
|
|
state: "missing_disposition",
|
|
reason: "missing_successful_run_disposition",
|
|
});
|
|
});
|
|
|
|
it("applies assigneeAgentId='null' as an IS NULL filter on the blocked-inbox path", async () => {
|
|
const { companyId, agentId } = await createCompany("BAN");
|
|
const unassignedParentId = await insertIssue({
|
|
companyId,
|
|
identifier: "BAN-1",
|
|
title: "Unassigned blocked parent",
|
|
status: "blocked",
|
|
});
|
|
const unassignedLeafId = await insertIssue({
|
|
companyId,
|
|
identifier: "BAN-2",
|
|
title: "Unassigned leaf",
|
|
status: "todo",
|
|
});
|
|
await block({ companyId, blockerIssueId: unassignedLeafId, blockedIssueId: unassignedParentId });
|
|
|
|
const assignedParentId = await insertIssue({
|
|
companyId,
|
|
identifier: "BAN-3",
|
|
title: "Assigned blocked parent",
|
|
status: "blocked",
|
|
assigneeAgentId: agentId,
|
|
});
|
|
const assignedLeafId = await insertIssue({
|
|
companyId,
|
|
identifier: "BAN-4",
|
|
title: "Unassigned leaf for assigned parent",
|
|
status: "todo",
|
|
});
|
|
await block({ companyId, blockerIssueId: assignedLeafId, blockedIssueId: assignedParentId });
|
|
|
|
const rows = await svc.list(companyId, { attention: "blocked", assigneeAgentId: "null" });
|
|
expect(rows.map((row) => row.id)).toEqual([unassignedParentId]);
|
|
|
|
await expect(svc.count(companyId, { attention: "blocked", assigneeAgentId: "null" })).resolves.toBe(1);
|
|
});
|
|
|
|
it("applies a UUID assigneeAgentId filter on the blocked-inbox path", async () => {
|
|
const { companyId, agentId } = await createCompany("BAU");
|
|
const unassignedParentId = await insertIssue({
|
|
companyId,
|
|
identifier: "BAU-1",
|
|
title: "Unassigned blocked parent",
|
|
status: "blocked",
|
|
});
|
|
const unassignedLeafId = await insertIssue({
|
|
companyId,
|
|
identifier: "BAU-2",
|
|
title: "Unassigned leaf",
|
|
status: "todo",
|
|
});
|
|
await block({ companyId, blockerIssueId: unassignedLeafId, blockedIssueId: unassignedParentId });
|
|
|
|
const assignedParentId = await insertIssue({
|
|
companyId,
|
|
identifier: "BAU-3",
|
|
title: "Assigned blocked parent",
|
|
status: "blocked",
|
|
assigneeAgentId: agentId,
|
|
});
|
|
const assignedLeafId = await insertIssue({
|
|
companyId,
|
|
identifier: "BAU-4",
|
|
title: "Unassigned leaf for assigned parent",
|
|
status: "todo",
|
|
});
|
|
await block({ companyId, blockerIssueId: assignedLeafId, blockedIssueId: assignedParentId });
|
|
|
|
const rows = await svc.list(companyId, { attention: "blocked", assigneeAgentId: agentId });
|
|
expect(rows.map((row) => row.id)).toEqual([assignedParentId]);
|
|
|
|
await expect(svc.count(companyId, { attention: "blocked", assigneeAgentId: agentId })).resolves.toBe(1);
|
|
});
|
|
|
|
it("rejects malformed assigneeAgentId filter values on the blocked-inbox path", async () => {
|
|
const { companyId } = await createCompany("BAM");
|
|
await expect(
|
|
svc.list(companyId, { attention: "blocked", assigneeAgentId: "not-a-uuid" }),
|
|
).rejects.toThrow(/assigneeAgentId/i);
|
|
await expect(
|
|
svc.count(companyId, { attention: "blocked", assigneeAgentId: "not-a-uuid" }),
|
|
).rejects.toThrow(/assigneeAgentId/i);
|
|
});
|
|
});
|