mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-27 11:20:42 +01:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work. > - App connections must work in both the operator UI and agent tool gateway. > - The first stack layer adds secure remote connections. > - Operators still need clear setup, test, and recovery states. > - This pull request adds the gateway behavior and the workspace connection experience. > - The benefit is a connection flow that is easier to understand and recover. ## Linked Issues or Issue Description Refs #11965 This is stack 2 of 11. It depends on stack 1 and replaces another reviewable part of #11965. ## What Changed - Improve remote tool gateway connection behavior. - Add clearer app setup, test, and recovery states. - Add focused server and UI tests for the new paths. - Keep the diff isolated from later identity and catalog work. - Stabilize DNS-pinned remote HTTP protocol fixtures and the managed-runtime public-origin fixture for this independently tested layer. ## Verification - `pnpm -r typecheck` - `pnpm --filter @paperclipai/server exec vitest run src/__tests__/tool-access-service.test.ts` (150 passed) - `pnpm test:run` - `pnpm check:token-gates` - `pnpm build` ## Risks - Gateway errors now surface through new user-facing states. - A stale connection can require a new setup attempt. - The change does not add a database migration. - The injected HTTP transport and public URL are test-only fixtures; production DNS pinning and runtime behavior are unchanged. > I checked `ROADMAP.md`. This stack continues the existing app connection work from #11965 and does not duplicate another planned item. ## Model Used OpenAI Codex, GPT-5. The runtime model ID and context window were not exposed. The model used reasoning, tool use, and code execution. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links - [x] My branch name describes the change and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
145 lines
4.1 KiB
TypeScript
145 lines
4.1 KiB
TypeScript
import { describe, expect, it } from "vitest";
|
|
import {
|
|
agentJoinGrantsFromDefaults,
|
|
humanJoinGrantsFromDefaults,
|
|
} from "../services/invite-grants.js";
|
|
import {
|
|
grantsForHumanRole,
|
|
normalizeHumanRole,
|
|
resolveHumanInviteRole,
|
|
} from "../services/company-member-roles.js";
|
|
|
|
describe("agentJoinGrantsFromDefaults", () => {
|
|
it("adds tasks:assign when invite defaults do not specify agent grants", () => {
|
|
expect(agentJoinGrantsFromDefaults(null)).toEqual([
|
|
{
|
|
permissionKey: "tasks:assign",
|
|
scope: null,
|
|
},
|
|
]);
|
|
});
|
|
|
|
it("preserves invite agent grants and appends tasks:assign", () => {
|
|
expect(
|
|
agentJoinGrantsFromDefaults({
|
|
agent: {
|
|
grants: [
|
|
{
|
|
permissionKey: "agents:create",
|
|
scope: null,
|
|
},
|
|
],
|
|
},
|
|
}),
|
|
).toEqual([
|
|
{
|
|
permissionKey: "agents:create",
|
|
scope: null,
|
|
},
|
|
{
|
|
permissionKey: "tasks:assign",
|
|
scope: null,
|
|
},
|
|
]);
|
|
});
|
|
|
|
it("does not duplicate tasks:assign when invite defaults already include it", () => {
|
|
expect(
|
|
agentJoinGrantsFromDefaults({
|
|
agent: {
|
|
grants: [
|
|
{
|
|
permissionKey: "tasks:assign",
|
|
scope: { projectId: "project-1" },
|
|
},
|
|
],
|
|
},
|
|
}),
|
|
).toEqual([
|
|
{
|
|
permissionKey: "tasks:assign",
|
|
scope: { projectId: "project-1" },
|
|
},
|
|
]);
|
|
});
|
|
});
|
|
|
|
describe("human invite roles", () => {
|
|
it("maps owner to the full management grant set", () => {
|
|
expect(grantsForHumanRole("owner")).toEqual([
|
|
{ permissionKey: "agents:create", scope: null },
|
|
{ permissionKey: "agents:configure", scope: null },
|
|
{ permissionKey: "skills:create", scope: null },
|
|
{ permissionKey: "environments:manage", scope: null },
|
|
{ permissionKey: "users:invite", scope: null },
|
|
{ permissionKey: "users:manage_permissions", scope: null },
|
|
{ permissionKey: "tasks:assign", scope: null },
|
|
{ permissionKey: "joins:approve", scope: null },
|
|
{ permissionKey: "tools:manage_connections", scope: null },
|
|
{ permissionKey: "tools:manage_runtime", scope: null },
|
|
{ permissionKey: "tools:use", scope: null },
|
|
{ permissionKey: "tools:admin", scope: null },
|
|
]);
|
|
});
|
|
|
|
it("maps admin to management grants including environment management", () => {
|
|
expect(grantsForHumanRole("admin")).toEqual([
|
|
{ permissionKey: "agents:create", scope: null },
|
|
{ permissionKey: "agents:configure", scope: null },
|
|
{ permissionKey: "skills:create", scope: null },
|
|
{ permissionKey: "environments:manage", scope: null },
|
|
{ permissionKey: "users:invite", scope: null },
|
|
{ permissionKey: "tasks:assign", scope: null },
|
|
{ permissionKey: "joins:approve", scope: null },
|
|
{ permissionKey: "tools:manage_connections", scope: null },
|
|
{ permissionKey: "tools:manage_runtime", scope: null },
|
|
{ permissionKey: "tools:use", scope: null },
|
|
{ permissionKey: "tools:admin", scope: null },
|
|
]);
|
|
});
|
|
|
|
it("defaults legacy or missing roles to operator", () => {
|
|
expect(normalizeHumanRole("member")).toBe("operator");
|
|
expect(resolveHumanInviteRole(null)).toBe("operator");
|
|
});
|
|
|
|
it("reads the configured human invite role from defaults", () => {
|
|
expect(
|
|
resolveHumanInviteRole({
|
|
human: {
|
|
role: "viewer",
|
|
},
|
|
}),
|
|
).toBe("viewer");
|
|
});
|
|
|
|
it("falls back to role grants when human invite defaults omit explicit grants", () => {
|
|
expect(humanJoinGrantsFromDefaults(null, "operator")).toEqual([
|
|
{ permissionKey: "tasks:assign", scope: null },
|
|
]);
|
|
});
|
|
|
|
it("preserves explicit human invite grants", () => {
|
|
expect(
|
|
humanJoinGrantsFromDefaults(
|
|
{
|
|
human: {
|
|
grants: [
|
|
{
|
|
permissionKey: "users:invite",
|
|
scope: { companyId: "company-1" },
|
|
},
|
|
],
|
|
},
|
|
},
|
|
"operator",
|
|
),
|
|
).toEqual([
|
|
{
|
|
permissionKey: "users:invite",
|
|
scope: { companyId: "company-1" },
|
|
},
|
|
]);
|
|
});
|
|
});
|