mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-23 00:53:38 +02:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work. > - The feature map describes product areas and verification entry points. > - Storybook has 223 story suites that show production components, proposals, and retained history. > - The parent PR maps those suites to features, but their folders and sidebar still use unrelated groups. > - This pull request puts the existing suites under feature folders and uses the feature map's names and order in the sidebar. > - Explicit meta IDs preserve existing story links while the titles change. > - Contributors can find stories through the same product structure without losing examples. ## Linked Issues or Issue Description Refs #16046. This is the requested follow-up. Parent #16046 is merged. This PR now targets master, with its single follow-up commit rebased onto the parent squash merge. The Storybook implementation is unchanged by that rebase. Related open Storybook PRs were checked; this change organizes existing suites and adds no product capability. ## What Changed - Move all 223 story files into folders named for their primary feature area. Keep useful scenario groups below the feature's sidebar label. - Order the sidebar by the eight feature-map sections. Put Overview first and shared Foundations last. Leave areas with no stories out of the sidebar. - Move 19 support files into `ui/storybook/support/` and update relative imports and active documentation. - Preserve all 2,210 story IDs and the single docs ID through explicit CSF meta IDs. Keep all entry names and story exports. - Record stable IDs and sidebar titles in the downstream catalog. Validate feature folders, title prefixes, and IDs. Update the maintenance skill and review evidence. ## Verification - Storybook build passed. Built index comparison against parent `75bd3c977cd828d5222823850339e8204f40eb47` found the same 2,211 entries, IDs, and names. - UI typecheck passed (`ui/node_modules/.bin/tsc -b` from `ui`, invoked as `./node_modules/.bin/tsc -b`). - UI Vitest project: 728 files and 8,176 tests passed. - Catalog checker and its nine tests passed. Feature-map checks, token gates, and the maintenance-skill validator passed. - Chromium: nine existing play cases and one render case reached `storyFinished: success` with no page exceptions. The guide rendered, sidebar sections followed map order, and a search for `steering/queue` opened its preserved story link. - Source comparison found only meta title/ID changes, rebased relative references, and updated fixture path text in story files. - To inspect: build Storybook, start `node scripts/serve-storybook-static.mjs --port 6136`, and open the Overview guide. Expand feature folders and use existing story links. - The complete repository suite was not repeated for this organization change. The parent records a backend timeout that passed in isolation, without a complete broad-suite pass. Visual comparisons remain blocked by the unpublished empty baseline. The separate fixture-server story was not run. ## Risks - Open branches that add stories under old paths will need to choose a feature folder and update the catalog. Cross-feature suites have one primary home and retain related capability references. - Sidebar paths change; story and docs IDs remain stable. Automated references to source paths may need the new location. - This is one requested follow-up with 258 changed files, mostly moves. It exceeds the usual review-size guideline because splitting it would leave the sidebar and folder convention partly migrated. - Browser verification samples ten stories, not all 2,210. Existing production/prototype classifications and review gaps remain unchanged. - Required CI gates and a 5/5 review passed on the original head. Fresh checks and review are running for the rebased head. Catalog validation and all nine checker tests passed after rebase; UI, map, skill, and checker contents are identical to the original reviewed head. ## Model Used - OpenAI Codex, GPT-6. The exact runtime model ID and context-window size are not exposed in this session. Used reasoning, repository inspection, code execution, and local browser automation. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [ ] All Paperclip CI gates are green - [ ] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge Co-authored-by: Paperclip <noreply@paperclip.ing>
209 lines
5.3 KiB
TypeScript
209 lines
5.3 KiB
TypeScript
import {
|
||
defaultGitHubReviewPolicy,
|
||
type GitHubChatConfiguration,
|
||
type GitHubTaskReview,
|
||
} from "@paperclipai/shared";
|
||
import type {
|
||
ChatEndpoint,
|
||
ChatEndpointResource,
|
||
ChatConversation,
|
||
ChatIdentityLink,
|
||
} from "@/api/chatEndpoints";
|
||
import { STORYBOOK_COMPANY_ID } from "../../fixtures/onboardingDraft";
|
||
import { storybookAgents } from "../../fixtures/paperclipData";
|
||
|
||
export const agent = { ...storybookAgents[0], name: "Maya" };
|
||
export const endpoint: ChatEndpoint = {
|
||
id: "story-github-bot",
|
||
companyId: STORYBOOK_COMPANY_ID,
|
||
provider: "github",
|
||
status: "active",
|
||
assignedAgentId: agent.id,
|
||
assignedAgentName: agent.name,
|
||
connectionId: "story-github-tools",
|
||
botLabel: "Maya Reviews",
|
||
botUsername: "maya-reviews[bot]",
|
||
providerAccountLabel: "acme",
|
||
allowUnlinkedPeople: false,
|
||
setup: {
|
||
step: "complete",
|
||
github: {
|
||
stage: "verify",
|
||
appSlug: "maya-reviews",
|
||
ownerType: "organization",
|
||
ownerLogin: "acme",
|
||
},
|
||
},
|
||
};
|
||
export const configuration: GitHubChatConfiguration = {
|
||
version: 1,
|
||
toolsEnabled: true,
|
||
responsibleUserId: "user-board",
|
||
memberAccess: "selected",
|
||
people: [
|
||
{
|
||
kind: "member",
|
||
userId: "user-board",
|
||
githubUserId: "42",
|
||
login: "mayacoder",
|
||
automaticReviews: true,
|
||
},
|
||
],
|
||
defaults: {
|
||
...defaultGitHubReviewPolicy(),
|
||
invocation: "allowed_authors",
|
||
events: ["opened", "synchronize"],
|
||
issueOpened: true,
|
||
instructions:
|
||
"Review for correctness and security. Explain important findings clearly, and suggest a focused fix. For issues, help the author understand the next step.",
|
||
},
|
||
repositories: {},
|
||
};
|
||
export const resources: ChatEndpointResource[] = [
|
||
{
|
||
id: "web",
|
||
type: "repository",
|
||
providerResourceId: "acme/web",
|
||
label: "acme/web",
|
||
availability: "available",
|
||
enabled: true,
|
||
metadata: { providerRepositoryId: "100" },
|
||
},
|
||
{
|
||
id: "api",
|
||
type: "repository",
|
||
providerResourceId: "acme/api",
|
||
label: "acme/api",
|
||
availability: "available",
|
||
enabled: false,
|
||
metadata: { providerRepositoryId: "101" },
|
||
},
|
||
];
|
||
export const links: ChatIdentityLink[] = [
|
||
{
|
||
id: "maya",
|
||
principalId: "maya",
|
||
githubUserId: "42",
|
||
githubLogin: "mayacoder",
|
||
externalLabel: "mayacoder",
|
||
paperclipUserId: "user-board",
|
||
paperclipUserLabel: "Maya Chen",
|
||
status: "linked",
|
||
},
|
||
{
|
||
id: "vin",
|
||
principalId: "vin",
|
||
githubUserId: "43",
|
||
githubLogin: "vin-dev",
|
||
externalLabel: "vin-dev",
|
||
paperclipUserId: "vin-member",
|
||
paperclipUserLabel: "Vin Patel",
|
||
status: "linked",
|
||
},
|
||
];
|
||
export const members = {
|
||
members: [
|
||
{
|
||
principalId: "user-board",
|
||
status: "active",
|
||
membershipRole: "owner",
|
||
user: { name: "Maya Chen" },
|
||
},
|
||
{
|
||
principalId: "vin-member",
|
||
status: "active",
|
||
membershipRole: "operator",
|
||
user: { name: "Vin Patel" },
|
||
},
|
||
],
|
||
};
|
||
export function review(
|
||
id: string,
|
||
headSha: string,
|
||
createdAt: string,
|
||
): GitHubTaskReview {
|
||
return {
|
||
id,
|
||
companyId: endpoint.companyId,
|
||
endpointId: endpoint.id,
|
||
issueId: `task-${id}`,
|
||
runId: null,
|
||
repositoryId: "100",
|
||
repository: "acme/web",
|
||
pullNumber: 24,
|
||
headSha,
|
||
configurationRevision: 2,
|
||
event: {
|
||
event: "opened",
|
||
deliveryId: `delivery-${id}`,
|
||
repositoryId: "100",
|
||
repository: "acme/web",
|
||
pullNumber: 24,
|
||
title: "Fix keyboard focus in the account picker",
|
||
body: "",
|
||
baseSha: "0000000",
|
||
headSha,
|
||
baseBranch: "main",
|
||
author: { id: "42", login: "mayacoder", isBot: false },
|
||
sender: { id: "42", login: "mayacoder" },
|
||
draft: false,
|
||
labels: [],
|
||
},
|
||
state: "completed",
|
||
assessment: {
|
||
reviewedCommit: headSha,
|
||
score: 5,
|
||
complete: true,
|
||
summary:
|
||
"**5/5** — Focus returns to the trigger after dismissal. Keyboard navigation and the loading state are covered.\n\n```text\n /\\_/\\\n( o.o )\n > ^ <\n```",
|
||
rationale:
|
||
"The change preserves the picker’s existing access rules and handles dismissal without losing focus.",
|
||
coverage: {
|
||
reviewedPaths: ["ui/AccountPicker.tsx", "ui/AccountPicker.test.tsx"],
|
||
omittedPaths: [],
|
||
limitations: [],
|
||
},
|
||
findings: [],
|
||
},
|
||
conclusion: "success",
|
||
checkUrl: "https://github.com/acme/web/pull/24/checks",
|
||
summaryUrl: "https://github.com/acme/web/pull/24#issuecomment-123",
|
||
createdAt,
|
||
updatedAt: createdAt,
|
||
};
|
||
}
|
||
export const reviews = [
|
||
review(
|
||
"latest",
|
||
"b046e7e18bdda6208515088540aee438091ab120",
|
||
"2026-10-07T12:43:00Z",
|
||
),
|
||
review(
|
||
"previous",
|
||
"c1525d7a904142590babb421971e7590d0a03b26",
|
||
"2026-10-07T12:33:00Z",
|
||
),
|
||
];
|
||
export const conversations: ChatConversation[] = [
|
||
{
|
||
id: "pr",
|
||
externalLabel: "acme/web",
|
||
externalUrl: "https://github.com/acme/web/pull/24",
|
||
issueId: "task-latest",
|
||
issueIdentifier: "PAP-24",
|
||
issueTitle: "Fix keyboard focus in the account picker",
|
||
state: "completed",
|
||
updatedAt: "2026-10-07T12:43:00Z",
|
||
},
|
||
{
|
||
id: "issue",
|
||
externalLabel: "acme/web",
|
||
externalUrl: "https://github.com/acme/web/issues/25",
|
||
issueId: "task-issue",
|
||
issueIdentifier: "PAP-25",
|
||
issueTitle: "Investigate the sign-in error after an invitation",
|
||
state: "active",
|
||
updatedAt: "2026-10-07T12:50:00Z",
|
||
},
|
||
];
|