mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-18 05:23:39 +02:00
## Thinking Path > - Paperclip manages AI agents and their work. > - The experimental Runner owns provider processes and durable sessions. > - Pi needs working task execution and human controls. > - The five-PR stack must preserve changes already on master. > - Each layer now carries the complete integrated source for a safe sequential fallback. > - This PR belongs to native GitHub stack #15602, ending at #14956. ## Linked Issues or Issue Description Refs #14436, #14631, #14743 and #14956. Ship Pi 1.0 through the experimental Paperclip Runner. The five PRs are #14921, #14922, #14923, #14924 and #14956. The user authorized the complete merge after checks pass. Existing `pi_local` execution is unchanged. Accounting and wider provider/platform qualification remain deferred. ## What Changed - Recover missing final replies after workspace finalization changes owners, using accepted-turn evidence without rerunning work or granting external-chat publication. - Preserve the admitted Pi instruction root across warm runs, while retaining changed-root rejection. - Give Pi a bounded 15-second default shutdown grace so stop, drain acknowledgement and durable suspension can complete. Explicit deadlines and other providers retain their existing behavior. - Integrate the Pi 1.0 runtime and master contracts. - Use Pi profile 22. Preserve explicit caller-selected models and exact native thinking levels. Keep Pi's wrapper, helper, extension and question/control behavior unchanged from the qualified profile-19 runtime. - Preserve master's Dot lifecycle and consent fields, configured task environment, status guards and current Codex/Claude dependency versions. Cursor stays qualified. Copilot stays pending; profile 17 binds the changed shared protocol validation sources. - Exclude general AWS IAM credentials from Pi static/custom provider bindings and selected task projections; preserve the provider-scoped Bedrock bearer key. Profile 21 is retained as historical provenance. Rust and cloud install probes use the current declaration. - Patch bundled brace-expansion 5.0.9 to the exact official 5.0.12 payload. Pin the patch and complete runtime closures. Include the patch in normal installed setup tooling. Keep the upstream Pi shrinkwrap as provenance and permit only this exact security correction. - Include current attestation files in the Docker build context. Keep the repository lockfile unchanged from master. CI and private image builds resolve manifest changes before their frozen installation. ## Verification - Full local `pnpm -r typecheck` passes, including Runner Rust, server and UI. Focused integration checks pass: 194 Runner admission/environment tests, 63 profile/credential tests with one expected skip, 152 Dot/UI configuration tests, and Pi transcript/notice tests. - Full local `pnpm build` passes on the final source. - Fresh final-source checks pass: all 698 Rust workspace tests (32 binaries), 156 credential/profile/controller tests with one expected skip, Runner TypeScript typecheck, and 20 package/setup/sandbox tests. - The profile-21 Pi materializer passes on the native host with the official pinned Node 24.21.0 and its npm. It verifies all 150 locked packages, the patched dependency and the exact closure. Setup/package bundle tests and UI token gates pass. - The old hashes were reproduced for all three supported targets before calculating the patched graph. New closure hashes are darwin-arm64 `282022db10150c6632b3444df421342e7d534bdf5d5fb1097a2e79d0625a2bcf`, darwin-x64 `64e251e19009f755c0b04f73ce2138246faab71a961b0f13d75ebfcc34bef12e`, and linux-x64 `713b1fdff42fb56a1518bdc084f181d70bee8ebadc3e4b1d76321ed9108c8410`. Independent native platform execution is separate from graph identity reproduction. - Historical cloud qualification remains unchanged: all seven core cases pass on shipping source `10dc43c9ec65d88c2f782d62afb296d09494f215`, harness `1a4408a48cfb5a1f094a311141c257c92cd7a893`, image `sha256:5b3a775b383591bda1b0c1889e509acc70ce7f37c53f09733c81d59037f02280`, and accepted Sonnet 4.6/low fixture. All 215 canonical files and all seven cleanup checks pass independent verification. These are profile-19 results and are not relabeled as fresh profile-22 runs. - Current Pi digest: `sha256:e92078bee3c23bec4100aa589013a44613d054cd686826534025d8019e9f39a9`. [The readiness plan](https://github.com/paperclipai/paperclip/blob/codex/pi-production-readiness/doc/plans/2026-10-02-pi-production-readiness.md) preserves campaign and failed-attempt provenance. - Merge only after every PR's current-head CI and fresh review pass. Linux CI covers the full suites, build and browser tests. The local embedded Postgres API-authority suite cannot start on this macOS/Node 26 host, so Linux CI must confirm that suite. ### Fresh profile-22 core qualification — 2026-10-08 All seven accepted core cases pass canonically on Pi profile 22, with `openrouter/anthropic/claude-sonnet-4.6` and native-confirmed low thinking. This model is a fixture; production accepts the caller's explicit Pi provider/model. Runtime/install source: `3241a992f2a7703e59e97ed0fd3e5d6405de4401`. Frozen accepted harness: `1a4408a48cfb5a1f094a311141c257c92cd7a893`. Immutable cloud image: `ghcr.io/paperclipai/paperclip-daytona-runner@sha256:506f22db7edd78f37c0c40bec1cc084af1850455026dbf467194bfbb8fcef141`. Pi digest: `sha256:e92078bee3c23bec4100aa589013a44613d054cd686826534025d8019e9f39a9`. [Hosted Linux image and clean-install verification](https://github.com/paperclipai/paperclip/actions/runs/37868328023) passes, including all 20 source-bound archives, normal CLI/Pi setup, companion import and the production pack reader. This exact installation source includes the latest master integration and the corrected Pi warm instruction-root fence. Full local typecheck/build and current-head hosted CI verify the final stack. All 13 focused real-root regressions pass. The full local executor suite passed 662 tests; 15 database tests could not start the Mac embedded PostgreSQL service. Hosted Linux CI passes the full required verification and E2E checks. These fresh results keep their own source identity; profile-19 results remain historical. | Core path | Canonical campaign | Retained archive SHA-256 | | --- | --- | --- | | File edit, validation, download and Done | `pi-core22-replyfix-0-1791511228` | 23 files; `a473e8603a3dd4737863291f8d3d1e392391f0b16d433c3e0e0e9d8baf7a97b0` | | Pending question and controller restart | `pi-core22-replyfix-1-1791511376` | 33 files; `6b829c4eb74e1f32a89c692a4ae7130dbfc1c6d3cf13915effe2103d9e242c8e` | | Three-turn session/process/workspace continuity | `pi-core22-replyfix-2-1791511587` | 23 files; `7a87021f8f9a3fdd3c58bb4467f8d82c635e3ea4795d6e75f144d9aa14818df8` | | Four typed questions and browser reconnects | `pi-core22-replyfix-3-1791511881` | 42 files; `9e31755252be1f4f9cb0626c984c142d4d1ae5f5bee3a7af08444db8d12c280a` | | Plan approval and completion | `pi-core22-replyfix-4-1791512031` | 22 files; `a0383ce1aab38e7b5a25ce0e9dd3bebea5c037ebd96ae6b29dae19015da2ae2c` | | Same-turn steering and permission denial | `pi-core22-replyfix-5-1791512261` | 39 files; `c929b8c7070f0b66aedc17e65ca46e6beab1e363926ac9f7e2a75fb250f05949` | | Stop during pending permission | `pi-core22-replyfix-6-1791512390` | 33 files; `7f0a58ae0f4d5bfc76149435f4e322537089c5bd16e7ffe9b5ad71f10a621a07` | All 215 canonical files (28714587 bytes) are independently hash-verified. All seven cleanup grades pass, with no owned runtime process or temporary root after each case. Automatic retries are zero. The owned cloud host stopped normally after retention. The prior profile-22 warm attempt remains failed and separately retained: archive SHA-256 `1e54eba5ec72b50cee1534b23d1d1d4f21a090006b8a64501ba70db972abfde5`. Its original canonical classification is preserved. Diagnosis reproduced a product bug comparing an agent-files root against an unset checkpoint-only field. The fix stores the admitted physical root separately from the adopted per-run collection capability. The real-root regression fails before the fix and passes afterward, including rejection of a changed physical root. Fixture, grader, model and all seven accepted case IDs are unchanged; this fresh campaign tests final-reply publication after file registration first. The intermediate restart attempt also remains failed and retained: archive SHA-256 `5dcaefdf1d17cf4cd54fd4cf810f45e736667392339b8ce7caf08bb4e225277f`. Its original canonical classification is preserved. Pi resumed, wrote the verified answer and completed its task; exact runner suspension was proven, but idle stop consumed about 5.2s and left under 3s for the drain acknowledgement. The Pi-only default shutdown grace is now 15s, preserving a full 5s drain round trip and a finite suspension reserve. Explicit caller deadlines, other provider defaults, literal drain receipts and exact suspension identity checks remain unchanged. The timing regression fails before this correction and passes afterward; all 18 focused settlement tests and Runner typecheck pass. The final-source file attempt is also preserved as failed (`candidate_failure`), archive SHA-256 `db6767b6773ea618997927ac77bdb005a5ac81492c7b9c0ffbc900449f829bc9`. Native edit, validation, exact downloadable artifact and Done/succeeded all passed, and the exact final reply was durably recorded. A workspace recovery owner completed before the live heartbeat reached presentation, leaving that reply absent from task chat. Recovery now materializes only a completed final reply from the accepted turn of an ordinary internal Done task, preserving issue/run/contract binding, suppression, external-chat authorization and same-run deduplication. The database regression covers the generated file-preparation receipt, suppression, unapproved external continuation and replay. Server typecheck and all 49 response-selection tests pass; hosted Linux verifies the database regression because embedded PostgreSQL cannot start on this Mac. The delayed-final-answer database regression passes on [the final root-source Linux server shard](https://github.com/paperclipai/paperclip/actions/runs/37868262553/job/113628594152), alongside 1,108 passing tests. The first root Runner shard had one unchanged durable-resume test exceed its 5-second timeout; the identical top-source shard and the isolated exact test passed. One rerun of that failed job and its required aggregate passed without source or test changes. The original failed job log and the single-rerun receipt remain retained. ### October 9 merge verification Current merge head: `5a8fe63512a7166aaef5cf50065a25008aa8b44b`. All current-head checks pass, including `ci / verify` and `ci / e2e`; exact-head Greptile review is 5/5 with no unresolved threads. Current master conflicts are resolved. The user authorized the maintainer override of the code-owner review gate after these checks. The seven retained live core cases remain bound to source `3241a992f2a7703e59e97ed0fd3e5d6405de4401` and its recorded cloud image. ## Risks - The security correction changes the dependency closure and profile identity. Old sessions must reopen on the new profile. Exact identities and credential bindings fail closed. - The runner remains experimental and requires explicit selection. Legacy Pi Local is unchanged. Caller model IDs pass through; the E2E model is a fixture. - Accounting and the broad platform/provider matrix remain deferred. This merge does not publish a release or deploy a service. ## Model Used OpenAI GPT-6 through Codex assisted with reasoning, repository inspection, editing and tool use. The exact serving ID and context window are not exposed in this session. Final live qualification uses Pi 1.0.0 with `openrouter/anthropic/claude-sonnet-4.6` and native-confirmed low thinking. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
223 lines
18 KiB
TypeScript
223 lines
18 KiB
TypeScript
import { createHash } from "node:crypto";
|
|
import { readFile, writeFile } from "node:fs/promises";
|
|
import { join } from "node:path";
|
|
import type { Page } from "@playwright/test";
|
|
import type { RunnerApi } from "./api.js";
|
|
import { isValidNativePrpEnvelope } from "./native-event-envelope.js";
|
|
|
|
type Row = Record<string, any>;
|
|
const rec = (value: unknown): Row => value !== null && typeof value === "object" && !Array.isArray(value) ? value as Row : {};
|
|
const sha = (value: string | Buffer) => createHash("sha256").update(value).digest("hex");
|
|
const requireEvidence = (value: unknown, reason: string) => { if (!value) throw new Error(`Pi file evidence: ${reason}`); };
|
|
export function piFileContract(nonce: string) {
|
|
if (!/^[A-Za-z0-9-]{1,100}$/u.test(nonce)) throw new Error("Invalid file fixture nonce");
|
|
const filename = `extended-${nonce}.txt`, before = `ready-${nonce}\n`, after = `verified-${nonce}\n`;
|
|
const validationMarker = `PI-VALIDATED-${nonce}`;
|
|
const validationCommand = `node -e 'if(require("node:fs").readFileSync(${JSON.stringify(filename)},"utf8")!==${JSON.stringify(after)})throw Error("mismatch");console.log(${JSON.stringify(validationMarker)})'`;
|
|
if ([...validationCommand].length > 240) throw new Error("Validation command exceeds native Rust tool-name bound");
|
|
return { filename, before, after, sha256: sha(after), byteSize: Buffer.byteLength(after), validationMarker, validationCommand };
|
|
}
|
|
export function piFilePrompt(nonce: string) {
|
|
const c = piFileContract(nonce);
|
|
return [
|
|
`The fixture has already created ${c.filename} in your execution workspace with exactly ${JSON.stringify(c.before)}. Read it, then use your native edit tool once to replace those bytes with exactly ${JSON.stringify(c.after)}. Do not substitute write, bash, or an API for the edit.`,
|
|
`Run this exact native bash command exactly once, without an added shell prefix or suffix:\n\`\`\`bash\n${c.validationCommand}\n\`\`\`\nIt independently reads the file, fails on incorrect bytes, and prints the validation marker only after success. This is the only bash call allowed for this task; do not run any other shell commands.`,
|
|
`Deliver the edited text file as a downloadable attachment using the assigned register_deliverable semantic tool, with filename and workspace-relative contentRef ${c.filename}, contentType text/plain, byteSize ${c.byteSize}, sha256 ${c.sha256}, title ${c.filename}, and a fresh idempotencyKey. Use the supplied byteSize and sha256 for the exact validated post-edit bytes; do not run extra commands to obtain metadata. Wait for the real registration receipt. Do not upload a different file or claim publication from a disk path.`,
|
|
`After successful validation and registration, call paperclip_finish with reportedWorkDisposition done, summary EXTENDED-FILE-${nonce}, the current completion contract revision and satisfied objective criterion, no remaining work, the actual validation command/result, and the registered artifact reference.`,
|
|
`Wait for paperclip_finish to succeed, then emit exactly EXTENDED-FILE-${nonce} as your final response. Do not create unrelated files or work.`,
|
|
].join("\n");
|
|
}
|
|
export async function seedPiFile(workspace: string, nonce: string) {
|
|
const c = piFileContract(nonce);
|
|
await writeFile(join(workspace, c.filename), c.before, { flag: "wx" });
|
|
const bytes = await readFile(join(workspace, c.filename));
|
|
requireEvidence(bytes.equals(Buffer.from(c.before)), "seed bytes changed before provider startup");
|
|
return { schema: "paperclip.e2e.pi-file-seed.v1", filename: c.filename, beforeSha256: sha(bytes), byteSize: bytes.length };
|
|
}
|
|
|
|
export function gradePiCopyback(run: Row, lease: Row, companyId: string, environmentId: string) {
|
|
const context = rec(run.contextSnapshot), environment = rec(context.paperclipEnvironment);
|
|
const reference = rec(rec(run.runnerProfileJson).nativeWorkspaceSync);
|
|
const binding = rec(rec(rec(run.runnerProfileJson).nativeExecutionInput).binding);
|
|
requireEvidence(run.companyId === companyId && reference.schema === "paperclip.native-workspace-sync/v2"
|
|
&& reference.state === "finalized" && [reference.baselineSha256, reference.descriptorSha256, reference.finalHostSha256]
|
|
.every(value => typeof value === "string" && /^[a-f0-9]{64}$/u.test(value)), "finalized production copy-back hashes required");
|
|
requireEvidence(typeof reference.workspaceId === "string" && reference.workspaceId.length > 0
|
|
&& reference.workspaceId === context.executionWorkspaceId
|
|
&& (binding.executionWorkspaceId === undefined || binding.executionWorkspaceId === reference.workspaceId)
|
|
&& environment.id === environmentId && environment.driver === "sandbox" && environment.leaseId === reference.leaseId,
|
|
"copy-back workspace and environment must belong to the actual run");
|
|
requireEvidence(lease.id === reference.leaseId && lease.companyId === companyId && lease.environmentId === environmentId
|
|
&& lease.heartbeatRunId === run.id && lease.provider === "daytona" && typeof reference.providerLeaseId === "string"
|
|
&& reference.providerLeaseId.length > 0 && lease.providerLeaseId === reference.providerLeaseId
|
|
&& typeof reference.remoteCwd === "string" && reference.remoteCwd.startsWith("/")
|
|
&& reference.remoteCwd === rec(lease.metadata).remoteCwd, "copy-back must bind the exact run and provider lease");
|
|
return { kind: "product_copyback", reference, lease: { id: lease.id, companyId, environmentId, heartbeatRunId: run.id,
|
|
provider: lease.provider, providerLeaseId: lease.providerLeaseId, remoteCwd: reference.remoteCwd },
|
|
guestObservation: false, hostSnapshotRecomputed: false };
|
|
}
|
|
|
|
/** Only the common public projection is authority here. Native raw arguments,
|
|
* full diff blocks and typed command exit codes are deliberately not invented.
|
|
* The native structured output receipt is distinct from that nullable typed field. */
|
|
export function gradePiFileEvidence(input: {
|
|
nonce: string; companyId: string; issueId: string; agentId: string; run: Row;
|
|
environment: "local" | "daytona"; environmentId: string; lease?: Row;
|
|
events: unknown[]; seed: unknown; workspaceBytes: Buffer; attachments: unknown[];
|
|
attachmentId: string; downloadedBytes: Buffer; activity: unknown[];
|
|
}) {
|
|
const c = piFileContract(input.nonce), run = input.run, seed = rec(input.seed);
|
|
const workspaceProvenance = input.environment === "daytona"
|
|
? gradePiCopyback(run, rec(input.lease), input.companyId, input.environmentId)
|
|
: { kind: "independent_local_workspace" };
|
|
requireEvidence(run.id && run.companyId === input.companyId && run.agentId === input.agentId
|
|
&& run.runtimeMode === "native" && run.status === "succeeded", "actual native run identity");
|
|
requireEvidence(seed.schema === "paperclip.e2e.pi-file-seed.v1" && seed.filename === c.filename
|
|
&& seed.beforeSha256 === sha(c.before) && seed.byteSize === Buffer.byteLength(c.before), "independent pre-edit seed");
|
|
requireEvidence(input.workspaceBytes.equals(Buffer.from(c.after)), "independent final workspace bytes");
|
|
requireEvidence(input.events.length > 0 && input.events.length <= 20_000, "bounded run events");
|
|
const rows = input.events.map(rec).filter(row => rec(row.payload).prpEvent !== undefined);
|
|
const seen = new Set<string>(), seqs = new Set<number>(), sourceSeqs = new Map<string, number>();
|
|
const canonical = rows.map(row => {
|
|
const e = rec(rec(row.payload).prpEvent);
|
|
requireEvidence(row.companyId === input.companyId && row.runId === run.id && e.runId === run.id
|
|
&& isValidNativePrpEnvelope(e, row.protocolSchemaVersion) && row.eventType === e.eventType
|
|
&& Number.isSafeInteger(row.seq) && row.seq > 0 && !seqs.has(row.seq)
|
|
&& typeof e.sourceInstanceId === "string" && e.sourceInstanceId.length > 0
|
|
&& Number.isSafeInteger(e.sourceSeq) && e.sourceSeq > (sourceSeqs.get(e.sourceInstanceId) ?? 0)
|
|
&& row.sourceInstanceId === e.sourceInstanceId && row.sourceSeq === e.sourceSeq && row.sourceEventId === e.sourceEventId
|
|
&& e.sourceEventId === `${e.sourceInstanceId}:${e.runId}:${e.sourceSeq}` && !seen.has(e.sourceEventId), "foreign, duplicated, or reordered durable evidence");
|
|
seqs.add(row.seq); seen.add(e.sourceEventId); sourceSeqs.set(e.sourceInstanceId, e.sourceSeq);
|
|
return { row, e, p: rec(e.payload) };
|
|
});
|
|
const tools = canonical.filter(x => x.e.eventType.startsWith("tool.execution.") && x.p.transport === "builtin");
|
|
const edits = tools.filter(x => x.e.eventType === "tool.execution.completed" && x.p.operation === "edit");
|
|
requireEvidence(edits.length === 1, "one native edit required; final-only writes cannot qualify");
|
|
const edit = edits[0]!;
|
|
requireEvidence(edit.p.name === "edit" && edit.p.target === c.filename, "exact native edit and relative target required");
|
|
function lifecycle(end: typeof edit) {
|
|
const matches = tools.filter(x => x.p.executionId === end.p.executionId);
|
|
const starts = matches.filter(x => x.e.eventType === "tool.execution.started");
|
|
requireEvidence(typeof end.p.executionId === "string" && end.p.executionId.length > 0
|
|
&& end.p.schema === "paperclip.tool.execution.v1" && end.p.status === "completed"
|
|
&& end.e.sourceKind === "runner" && end.e.sourceInstanceId === run.runnerInstanceId
|
|
&& end.e.normalizedSessionId === run.nativeSessionId && typeof end.e.turnId === "string" && end.e.turnId.length > 0
|
|
&& typeof end.e.normalizedSessionId === "string" && end.e.normalizedSessionId.length > 0
|
|
&& starts.length === 1 && starts[0]!.row.seq < end.row.seq
|
|
&& matches.filter(x => x.e.eventType === "tool.execution.completed").length === 1
|
|
&& matches.every(x => x.p.schema === end.p.schema && x.p.name === end.p.name && x.p.operation === end.p.operation
|
|
&& x.row.seq >= starts[0]!.row.seq && x.row.seq <= end.row.seq
|
|
&& x.e.sourceKind === "runner" && x.e.turnId === end.e.turnId
|
|
&& x.e.normalizedSessionId === end.e.normalizedSessionId && x.e.sourceInstanceId === end.e.sourceInstanceId
|
|
&& (x === end || (x.p.status === "running"
|
|
&& ["tool.execution.started", "tool.execution.progressed"].includes(x.e.eventType)))), "incomplete or unsuccessful native tool lifecycle");
|
|
// Native arguments arrive incrementally. An unresolved target is allowed
|
|
// only before the first exact target; conflicting or regressed targets fail.
|
|
let resolved = false;
|
|
for (const x of matches) {
|
|
requireEvidence(x.p.target === end.p.target || (!resolved && x.p.target === null), "conflicting native tool target");
|
|
if (x.p.target !== null) resolved = true;
|
|
}
|
|
return { start: starts[0]!, matches };
|
|
}
|
|
lifecycle(edit);
|
|
const validations = tools.filter(x => x.e.eventType === "tool.execution.completed" && x.p.operation === "execute"
|
|
&& x.p.name === "bash");
|
|
requireEvidence(validations.length === 1, "one observed provider validation execution");
|
|
const validation = validations[0]!, { start, matches } = lifecycle(validation);
|
|
requireEvidence(start.row.seq > edit.row.seq && validation.e.turnId === edit.e.turnId
|
|
&& validation.e.normalizedSessionId === edit.e.normalizedSessionId
|
|
&& validation.e.sourceInstanceId === edit.e.sourceInstanceId && validation.p.outputTruncated === false,
|
|
"validation must follow the edit in the same native turn");
|
|
// The common lifecycle preserves the opening name (bash). ACPX's resolved
|
|
// command is retained as progress, rather than replacing that stable name.
|
|
const commandProgress = `${c.validationCommand} (in_progress): ${c.validationCommand}`;
|
|
const allowedProgress = new Set([`bash (pending): [terminal] ${validation.p.executionId}`,
|
|
`${c.validationCommand} (pending): ${c.validationCommand}`, commandProgress]);
|
|
requireEvidence(matches.some(x => x !== validation && x.p.progress === commandProgress)
|
|
&& matches.every(x => x.p.progress === null || allowedProgress.has(x.p.progress)),
|
|
"exact correlated command progress before completion required");
|
|
requireEvidence(typeof validation.p.output === "string" && Buffer.byteLength(validation.p.output) <= 16_384,
|
|
"bounded native validation receipt required");
|
|
let output: Row = {};
|
|
try { output = rec(JSON.parse(validation.p.output)); } catch { /* Rejected below; plain marker text is insufficient. */ }
|
|
const structured = rec(output.structuredContent), expectedOutput = `${c.validationMarker}\n`;
|
|
requireEvidence(structured.exit_code === 0 && structured.truncated === false && structured.output === expectedOutput
|
|
&& Array.isArray(output.content) && output.content.length === 1
|
|
&& rec(output.content[0]).type === "text" && rec(output.content[0]).text === expectedOutput
|
|
&& (validation.p.exitCode === null || validation.p.exitCode === 0), "successful native structured validation receipt required");
|
|
const attachments = input.attachments.map(rec).filter(a => a.id === input.attachmentId);
|
|
requireEvidence(attachments.length === 1, "one public attachment");
|
|
const a = attachments[0]!;
|
|
requireEvidence(a.companyId === input.companyId && a.issueId === input.issueId && a.originatingRunId === run.id
|
|
&& a.createdByAgentId === input.agentId && a.originalFilename === c.filename && a.contentType === "text/plain"
|
|
&& a.byteSize === c.byteSize && a.sha256 === c.sha256, "attachment bytes and immutable run attribution");
|
|
requireEvidence(input.downloadedBytes.equals(Buffer.from(c.after)), "actual public download bytes");
|
|
const receipts = Object.values(rec(rec(run.resultJson).semanticToolReceipts)).map(rec)
|
|
.filter(r => r.operationId === "register_deliverable" && rec(r.input).filename === c.filename);
|
|
requireEvidence(receipts.length === 1, "one authenticated semantic registration");
|
|
const receipt = receipts[0]!, args = rec(receipt.input), result = rec(receipt.result);
|
|
requireEvidence(args.contentRef === c.filename && args.contentType === "text/plain" && args.byteSize === c.byteSize
|
|
&& args.sha256 === c.sha256 && result.disposition === "applied" && result.commandId === `deliverable-prepared:${a.id}`
|
|
&& Array.isArray(result.entityRefs) && result.entityRefs[0] === a.id, "registered artifact receipt must match downloaded attachment");
|
|
const publications = input.activity.map(rec).filter(row => row.action === "issue.attachment_added"
|
|
&& rec(row.details).attachmentId === a.id);
|
|
requireEvidence(publications.length === 1 && publications[0]!.companyId === input.companyId
|
|
&& publications[0]!.runId === run.id && publications[0]!.actorId === input.agentId
|
|
&& publications[0]!.entityId === input.issueId && rec(publications[0]!.details).source === "paperclip_runner_protocol",
|
|
"publication activity must belong to this run and task");
|
|
return {
|
|
schema: "paperclip.e2e.pi-file-evidence.v1", passed: true, workspaceProvenance,
|
|
runId: run.id, turnId: edit.e.turnId, nativeEditExecutionId: edit.p.executionId,
|
|
validationExecutionId: validation.p.executionId, attachmentId: a.id,
|
|
verification: { kind: "independent_exact_bytes", beforeSha256: sha(c.before), afterSha256: c.sha256,
|
|
downloadedSha256: sha(input.downloadedBytes), byteSize: c.byteSize, providerExecutionStatus: validation.p.status,
|
|
command: c.validationCommand, providerToolName: validation.p.name, commandEvidence: "correlated_native_progress",
|
|
exitEvidence: "native_structured_output_receipt", nativeStructuredExitCode: structured.exit_code,
|
|
typedExitCode: validation.p.exitCode, nativeFileTarget: edit.p.target,
|
|
nativeFileAttribution: "workspace_relative_display_target" },
|
|
diff: { source: "independent_seed_and_workspace_bytes", path: c.filename,
|
|
text: `--- ${c.filename}\n+++ ${c.filename}\n@@ -1 +1 @@\n-${c.before.trimEnd()}\n+${c.after.trimEnd()}\n` },
|
|
limits: ["Exact command progress and the native structured output receipt are checked; raw arguments and nullable typed exitCode are not attested by those distinct fields.",
|
|
"Diff is computed from independently checked workspace bytes; it does not qualify native diff presentation or private invocation metadata."],
|
|
};
|
|
}
|
|
|
|
export async function collectPiFileEvidence(input: {
|
|
page: Page; api: RunnerApi; nonce: string; companyId: string; issueId: string; agentId: string;
|
|
run: Row; events: unknown[]; seed: unknown; workspace: string;
|
|
environment: "local" | "daytona"; environmentId: string;
|
|
evidence(data: unknown): Promise<void>;
|
|
}) {
|
|
const c = piFileContract(input.nonce);
|
|
let run = input.run, lease: Row | undefined;
|
|
if (input.environment === "daytona") {
|
|
run = await input.api.get<Row>(`/api/heartbeat-runs/${input.run.id}`);
|
|
requireEvidence(run.id === input.run.id, "public copy-back run readback changed identity");
|
|
const leaseId = rec(rec(run.runnerProfileJson).nativeWorkspaceSync).leaseId;
|
|
requireEvidence(typeof leaseId === "string" && /^[A-Za-z0-9_-]{1,128}$/u.test(leaseId), "copy-back lease reference missing");
|
|
lease = await input.api.get<Row>(`/api/environment-leases/${leaseId}`);
|
|
}
|
|
const attachments = await input.api.get<Row[]>(`/api/issues/${input.issueId}/attachments`);
|
|
const selected = attachments.filter(a => a.originalFilename === c.filename);
|
|
requireEvidence(selected.length === 1 && /^[a-f0-9-]{36}$/u.test(selected[0]!.id), "exact published file selection");
|
|
requireEvidence(selected[0]!.byteSize === c.byteSize && selected[0]!.sha256 === c.sha256
|
|
&& selected[0]!.contentType === "text/plain", "bounded attachment metadata before download");
|
|
const attachmentId = selected[0]!.id;
|
|
const contentPath = `/api/attachments/${attachmentId}/content`;
|
|
// Exercise the real task surface and the authenticated public download route.
|
|
await input.page.locator(`a[href*="${contentPath}"]`).first().waitFor({ state: "visible", timeout: 15_000 });
|
|
const response = await input.api.request.get(contentPath);
|
|
requireEvidence(response.ok(), "public attachment download failed");
|
|
const downloadedBytes = await response.body();
|
|
requireEvidence(downloadedBytes.length <= 4096, "bounded text attachment");
|
|
const workspaceBytes = await readFile(join(input.workspace, c.filename));
|
|
const activity = await input.api.get<Row[]>(`/api/issues/${input.issueId}/activity`);
|
|
await input.evidence({ schema: "paperclip.e2e.pi-file-observation.v1", attachments, attachmentId, activity,
|
|
workspaceBytes: workspaceBytes.toString("base64"), downloadedBytes: downloadedBytes.toString("base64"),
|
|
encoding: "base64", expectedSha256: c.sha256, copybackReference: rec(run.runnerProfileJson).nativeWorkspaceSync,
|
|
copybackLease: lease && { id: lease.id, companyId: lease.companyId, environmentId: lease.environmentId,
|
|
heartbeatRunId: lease.heartbeatRunId, provider: lease.provider, providerLeaseId: lease.providerLeaseId, remoteCwd: rec(lease.metadata).remoteCwd } });
|
|
return gradePiFileEvidence({ ...input, run, lease, attachments, attachmentId, downloadedBytes, workspaceBytes, activity });
|
|
}
|