mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-11-13 15:55:46 +01:00
## Thinking Path
> - Paperclip is the open source app people use to manage AI agents for
work
> - The chat eval catalog runs real agents through chat journeys and
grades the saved results
> - Full cohort 4 (OpenCode with DeepSeek v4.1 flash, master f1aef0cb58)
failed 14 cases for eval reasons, not product reasons
> - Some phase captures read links before the reply rendered. Some
graders matched keywords in free-form replies. One locator was stale.
One fixture answer looked like a placeholder. Some checks could not say
what failed
> - This pull request grades those cases on saved state, setup literals
and rendered links, and it fixes the observers and fixtures
> - The benefit is that these cases fail only when the product fails,
and a failure names the part that broke
## Linked Issues or Issue Description
**What happened?**
In full chat cohort 4, valid agent behavior failed these cases:
case-history, goals.explain-purpose and workspaces.preview-service
(phase captures read before the reply rendered); routines.pause-owned
("If you want that one stopped too, use Pause on its task page" matched
a cancellation regex); budgets-costs.spend-breakdown ("unknown, not
$0.00" matched a stated-zero regex); steering.edit-queued-message
("change ... and drag it above" missed a keyword list);
connection-setup.choose-provider (the resumed page says "Finish with
Notion"); questions-and-approvals.necessary-question (the answer "Acorn
2a4f72ec4ae2-1" was saved as "Acorn"). Some checks could not say what
failed: onboarding.new-company compared the whole members response as
JSON and saved no after-state; agents.choose-primary threw one combined
error.
**Expected behavior**
Each case grades the feature contract on saved state, setup literals and
rendered or clicked links. A valid reworded reply passes. A broken
product still fails. A failure names the clause and its values.
**Steps to reproduce**
Grade the retained cohort 4 evidence for the cases above with the
earlier oracles.
Refs #21009, #21002, #21007
## What Changed
- Phase captures (case-history first phase, goals.explain-purpose
phases, preview-service query phase, ambiguous-task clarification,
edit-queued-message guidance) now wait for the saved reply to render
(`waitForTurnReplyLinks`) before they observe. When a saved reply yields
no rendered links, the observation records thread and anchor diagnostics
(`linkDiagnostics`) and logs them.
- routines.pause-owned: remove the reply keyword clause. Saved state at
the reply proves the run kept running, and the final state proves it
completed normally.
- budgets-costs.spend-breakdown: the unresolved record is graded
structurally. The reply must identify it (rendered link, identifier or
run id), and a chat run must have read its saved accounting (cost
summary, run record or unranged company report, bound by input digest).
"$0.00" in the reply is not matched.
- steering.edit-queued-message: grade the rendered task link in the
reply, the refused agent edit and reorder (403), and the unchanged queue
at the reply. Keyword lists are removed.
- connection-setup.choose-provider: the sign-in locator also accepts
"Finish with Notion" (the resumed-draft label). The button has no test
id or other stable name.
- questions-and-approvals.necessary-question: the answer is now
"Quillmere". The case also accepts the exact answer in a saved
deliverable (a document revision or text attachment on the linked task,
saved by an agent of the company after the answer). The yaml expected
outcome records this decision, with a `changedFields` entry in the
testops manifest.
- onboarding.new-company: save the members after-state and compare
identity, role, status and grants, and name what changed. Guidance is
graded on a rendered link to `/onboarding` (the new-organization
wizard), the business literal from the query, and the saved company
count. The source company and person get realistic names for this case
and are restored at cleanup, because the CEO reasoned from the generated
names that the request was a graded test.
- agents.choose-primary: the settled-Chat check is split into four named
clauses with values, saved as evidence on failure.
- A question card the turn ended on counts as its reply (decision after
cohort 4) in cli-operations.owned-dev-instance, onboarding.new-company
and status-cards.other-authors-card. The card's Markdown-rendered fields
(question form description; confirmation prompt and details) count as
reply links. Link requirements still apply.
- Every changed case bumps its `oracleVersion`; the descriptor snapshot
and inventory digest are updated.
Why each old check was wrong and why the new one still catches a broken
product:
| Case | Old check was wrong because | A broken product still fails
because |
|---|---|---|
| phase captures | runs succeeded and the chat waited before the reply
rendered, so links were empty | the same link checks run on the rendered
reply |
| routines.pause-owned | a correct offer to pause the run read as a
cancellation | the checkpoint run must be running and the run must later
succeed |
| spend-breakdown | "unknown, not $0.00" read as "$0" | the reply must
identify the record and a chat run must read its saved accounting;
totals and per-agent amounts stay graded |
| edit-queued-message | correct wording missed a keyword list | the
reply must link the task, the agent's edit and reorder must be refused,
and the queue must be unchanged at the reply |
| choose-provider | the resumed page label was not accepted | the button
must still be visible on the selected Notion surface |
| necessary-question | the answer read as a placeholder; deliverables
did not count | the exact answer must be saved in the linked work after
the answer, by an agent of the company |
| new-company | timestamps and profiles made the JSON compare fail
without saying why | membership identity, role, status and grants must
be unchanged |
| choose-primary | one combined error | the same four conditions, each
named |
| card as reply | a card answer read as an empty reply | card text must
exist and link requirements still apply |
## Verification
- Calibration tests (valid, reworded valid, broken) for each changed
grader: `integrator-routine-pause.test.ts`,
`identity-accounting.test.ts` (includes the cohort 4 reply),
`runtime-queue-controls.test.ts` (includes the cohort 4 reply),
`external-provider-choice.test.ts`, `identity.test.ts`,
`identity-onboarding-work.test.ts`,
`runtime-primary-ready-chat.test.ts`, `integrator-status-cards.test.ts`,
`turn-response-card.test.ts`, `chat-rendered-links.test.ts`.
- The corrected spend-breakdown grader passes on the retained cohort 4
evidence (its cost-summary read binds to the unresolved task) and fails
with the reads removed.
- `npx vitest run --config tests/runner-e2e/vitest.config.ts
chat-catalog chat-rendered chat-linked`: 284 files passed.
- `node --test
tests/runner-e2e/chat-full-catalog-testops-manifest.test.mjs`: 10/10
passed.
- `node scripts/typecheck-test-projects.mjs tests/runner-e2e`: passed.
- `node tests/runner-e2e/source-sdk-public-inputs.mjs <sha> --check`:
unchanged.
- Paid run (8 cells, OpenCode + DeepSeek v4.1 flash) on this branch
combined with the guidance PR: see the PR comment for results.
## Risks
- The new-company guidance check now needs a rendered link to
`/onboarding`. A reply that only names the company switcher fails. The
companion guidance PR tells agents this route.
- spend-breakdown does not grade wording, so a reply that reads the
record and still calls it "$0" is not caught. The amounts, total and
identification are still graded.
- The new-company case renames the source company and the person for the
case and restores them at cleanup.
## Model Used
- Anthropic Claude Opus 5.5 (`claude-opus-5-5`) in Claude Code, with
tool use, shell execution and code editing.
## Checklist
- [x] I have included a thinking path that traces from project context
to this change
- [x] I have specified the model used (with version and capability
details)
- [x] I have checked ROADMAP.md and confirmed this PR does not duplicate
planned core work
- [x] I have searched GitHub for duplicate or related PRs and linked
them above
- [x] I have either (a) linked existing issues with `Fixes: #` / `Closes
#` / `Refs #` OR (b) described the issue in-PR following the relevant
issue template
- [x] I have not referenced internal/instance-local Paperclip issues or
links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip`
URLs)
- [x] My branch name describes the change (e.g. `docs/...`, `fix/...`)
and contains no internal Paperclip ticket id or instance-derived details
- [x] I have run tests locally and they pass
- [x] I have added or updated tests where applicable
- [x] I have updated relevant documentation to reflect my changes
- [x] I have considered and documented any risks above
- [ ] All Paperclip CI gates are green
- [ ] Greptile is 5/5 with no open P2s, recommendations, or follow-ups
- [ ] I will address all Greptile and reviewer comments before
requesting merge
🤖 Generated with [Claude Code](https://claude.com/claude-code)
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
213 lines
16 KiB
TypeScript
213 lines
16 KiB
TypeScript
import type { Locator, Page } from "@playwright/test";
|
|
import type { ChatRun } from "./chat-flow.js";
|
|
|
|
interface Row { id: string; companyId?: string; issueId?: string; authorAgentId?: string | null; createdByRunId?: string | null; name?: string; action?: string; entityType?: string; entityId?: string; agentId?: string | null; actorType?: string; actorId?: string; runId?: string | null }
|
|
export interface RenderedConversationLink {
|
|
threadTestId: "task-chat-thread" | "thread-root"; href: string; source: "reply" | "project-created-card"; conversationId: string; anchorCommentId: string;
|
|
commentId?: string; resourceId?: string; cardLabel?: string; createdByRunId?: string;
|
|
}
|
|
export interface ConversationLinkInput {
|
|
origin: string; companyId: string; companyPrefix?: string | null; sourceId: string; leadId: string;
|
|
comments: Row[]; runs: ChatRun[]; projects: Row[]; activity: Row[];
|
|
}
|
|
/** Markdown link targets written in saved text, e.g. a reply body: inline [label](target), reference
|
|
* definitions ([label]: target) and autolinks (<https://...>). */
|
|
export function markdownLinkTargets(text: string): string[] {
|
|
const unwrap = (target: string) => target.startsWith("<") && target.endsWith(">") ? target.slice(1, -1) : target;
|
|
return [
|
|
...[...text.matchAll(/\]\(\s*([^)\s]+)/g)].map(match => unwrap(match[1]!)),
|
|
...[...text.matchAll(/^[ \t]{0,3}\[[^\]\n]+\]:[ \t]*(\S+)/gm)].map(match => unwrap(match[1]!)),
|
|
...[...text.matchAll(/<((?:https?:\/\/|\/)[^>\s]+)>/g)].map(match => match[1]!),
|
|
];
|
|
}
|
|
export function mislabeledIssueLinks(text: string, identifierFor: (pathId: string) => string | undefined = () => undefined): string[] {
|
|
const identifier = /^[A-Za-z][A-Za-z0-9]*-\d+$/;
|
|
return [...text.matchAll(/\[((?:[^\[\]]|\[[^\]]*\])*)\]\(\s*<?([^)\s>]+)>?[^)]*\)?/g)].flatMap(match => {
|
|
const label = match[1]!, target = match[2]!;
|
|
let pathname: string;
|
|
try { pathname = decodeURIComponent(new URL(target, "http://paperclip.invalid").pathname); } catch { return []; }
|
|
const parts = pathname.split("/").filter(Boolean); const index = parts.indexOf("issues"); const pathId = index >= 0 ? parts[index + 1] : undefined;
|
|
if (!pathId) return [];
|
|
const opened = (identifier.test(pathId) ? pathId : identifierFor(pathId))?.toUpperCase();
|
|
if (!opened) return [];
|
|
const prefix = opened.split("-")[0]!;
|
|
const named = [...label.matchAll(/(?<![\w-])([A-Za-z][A-Za-z0-9]*-\d+)(?![\w-])/g)].map(token => token[1]!.toUpperCase())
|
|
.filter(token => token.split("-")[0] === prefix);
|
|
return named.length > 0 && !named.includes(opened) ? [match[0]] : [];
|
|
});
|
|
}
|
|
/** A link target that still holds a template placeholder such as <prefix> or {companyId}; it opens no real page. */
|
|
export function unresolvedLinkTarget(href: string): boolean {
|
|
let decoded = href;
|
|
try { decoded = decodeURIComponent(href); } catch { /* keep the raw target */ }
|
|
return /[<>{}]/.test(decoded);
|
|
}
|
|
export function conversationLinkBindings(input: ConversationLinkInput) {
|
|
const comments = input.comments.filter(row => row.companyId === input.companyId && row.issueId === input.sourceId);
|
|
const replies = comments.filter(row => row.authorAgentId === input.leadId && input.runs.some(run =>
|
|
run.id === row.createdByRunId && run.companyId === input.companyId && run.agentId === input.leadId
|
|
&& ((run as ChatRun & { nativeIssueId?: string }).nativeIssueId ?? run.contextSnapshot?.issueId) === input.sourceId));
|
|
const projects = input.projects.flatMap(project => {
|
|
if (project.companyId !== input.companyId || !project.name) return [];
|
|
const creation = input.activity.find(row => row.companyId === input.companyId && row.action === "project.created"
|
|
&& row.entityType === "project" && row.entityId === project.id && row.actorType === "agent"
|
|
&& row.actorId === input.leadId && row.agentId === input.leadId
|
|
&& replies.some(reply => reply.createdByRunId === row.runId));
|
|
return creation?.runId ? [{ id: project.id, name: project.name, runId: creation.runId }] : [];
|
|
});
|
|
return { origin: input.origin, companyPrefix: input.companyPrefix, sourceId: input.sourceId,
|
|
anchors: comments.map(row => row.id), replies: replies.map(row => row.id), projects };
|
|
}
|
|
export function readConversationDomLinks(input: ReturnType<typeof conversationLinkBindings>): RenderedConversationLink[] {
|
|
const visible = (element: Element) => {
|
|
for (let node: Element | null = element; node; node = node.parentElement) {
|
|
if (node.hasAttribute("hidden") || node.hasAttribute("inert") || node.getAttribute("aria-hidden") === "true") return false;
|
|
const style = window.getComputedStyle(node);
|
|
if (style.display === "none" || ["hidden", "collapse"].includes(style.visibility) || style.opacity === "0") return false;
|
|
}
|
|
return element.getClientRects().length > 0;
|
|
};
|
|
const threadSelector = '[data-testid="task-chat-thread"], [data-testid="thread-root"]';
|
|
const roots = Array.from(document.querySelectorAll(threadSelector)).filter(root => visible(root)
|
|
&& input.anchors.some(id => Array.from(root.querySelectorAll("[id]")).some(node => node.id === `comment-${id}` && node.closest(threadSelector) === root)));
|
|
if (roots.length !== 1) return [];
|
|
const root = roots[0]!;
|
|
const threadTestId = root.getAttribute("data-testid") as RenderedConversationLink["threadTestId"];
|
|
const anchor = input.anchors.find(id => Array.from(root.querySelectorAll("[id]")).some(node => node.id === `comment-${id}`))!;
|
|
const rows: RenderedConversationLink[] = [];
|
|
const sameConversation = (node: Element) => node.closest(threadSelector) === root;
|
|
const companyResource = (href: string) => {
|
|
try {
|
|
const url = new URL(href, input.origin), parts = url.pathname.split("/").filter(Boolean).map(decodeURIComponent);
|
|
const resourceAt = parts.findIndex(part => ["projects", "issues", "goals"].includes(part));
|
|
if (url.origin !== new URL(input.origin).origin) return !(resourceAt === 1 && parts.length === 3);
|
|
return resourceAt < 0 || resourceAt === 1 && parts[0] === input.companyPrefix;
|
|
} catch { return false; }
|
|
};
|
|
for (const id of input.replies) {
|
|
const reply = Array.from(root.querySelectorAll("[id]")).find(node => node.id === `comment-${id}` && sameConversation(node));
|
|
for (const node of reply?.querySelectorAll("a[href]") ?? []) {
|
|
const href = node.getAttribute("href");
|
|
if (href && sameConversation(node) && visible(node) && companyResource(href)) rows.push({ threadTestId, href, source: "reply", conversationId: input.sourceId, anchorCommentId: id, commentId: id });
|
|
}
|
|
}
|
|
for (const project of threadTestId === "task-chat-thread" ? input.projects : []) {
|
|
const label = `Project created: ${project.name}`;
|
|
for (const card of root.querySelectorAll("article[aria-label]")) {
|
|
const item = card.closest('[data-thread-item-kind="project_created"]');
|
|
if (item?.getAttribute("data-thread-anchor") !== `project-created:${project.id}` || card.getAttribute("aria-label") !== label || card.closest('[id^="comment-"]') || !sameConversation(card) || !visible(card)) continue;
|
|
for (const node of card.querySelectorAll("a[href]")) {
|
|
const href = node.getAttribute("href");
|
|
if (!href || !visible(node) || !sameConversation(node)) continue;
|
|
try {
|
|
const url = new URL(href, input.origin), parts = url.pathname.split("/").filter(Boolean).map(decodeURIComponent);
|
|
if (url.origin !== new URL(input.origin).origin || parts.length !== 3 || parts[0] !== input.companyPrefix || parts[1] !== "projects" || parts[2] !== project.id) continue;
|
|
rows.push({ threadTestId, href, source: "project-created-card", conversationId: input.sourceId, anchorCommentId: anchor, resourceId: project.id, cardLabel: label, createdByRunId: project.runId });
|
|
} catch { continue; }
|
|
}
|
|
}
|
|
}
|
|
return rows;
|
|
}
|
|
/** The API reports a saved reply before the open conversation renders it.
|
|
* When this conversation is open in the page, wait (bounded) for its latest
|
|
* saved lead reply to render so rendered links are not read too early. A page
|
|
* that is not showing this conversation is left alone. */
|
|
export const CONVERSATION_REPLY_RENDER_WAIT_MS = 10_000;
|
|
// A reply that did not render within one wait is not waited for again in the same loaded document, so
|
|
// repeated observations in a poll loop pay the wait at most once per reply. The expiry belongs to the
|
|
// document, not the Playwright page: after a reload or navigation the thread renders again from scratch,
|
|
// and reading it instantly then would capture no links although the reply renders moments later.
|
|
const expiredReplyWaits = new WeakMap<object, Set<string>>();
|
|
export function readConversationDocumentIdentity(): string {
|
|
const view = window as typeof window & { __paperclipConversationLinkDocument?: string };
|
|
return view.__paperclipConversationLinkDocument ??= `${performance.timeOrigin}:${Math.random()}`;
|
|
}
|
|
export type ConversationReplyRender = "closed" | "rendered" | "pending";
|
|
export function readLatestConversationReplyRender(input: { anchors: string[]; latest: string }): ConversationReplyRender {
|
|
const threadSelector = '[data-testid="task-chat-thread"], [data-testid="thread-root"]';
|
|
// A thread is this conversation's when every comment it renders is one of its saved comments; a thread that
|
|
// has not rendered any comment yet (still loading after navigation or reload) counts too.
|
|
const roots = Array.from(document.querySelectorAll(threadSelector)).filter(root =>
|
|
Array.from(root.querySelectorAll('[id^="comment-"]')).every(node => input.anchors.some(id => node.id === `comment-${id}`)));
|
|
if (!roots.length) return "closed";
|
|
const rendered = roots.some(root => Array.from(root.querySelectorAll('[id^="comment-"]'))
|
|
.some(node => node.id === `comment-${input.latest}` && node.getClientRects().length > 0));
|
|
return rendered ? "rendered" : "pending";
|
|
}
|
|
export async function waitForLatestConversationReplyRender(page: Pick<Page, "evaluate">, bindings: Pick<ReturnType<typeof conversationLinkBindings>, "anchors" | "replies">,
|
|
timeoutMs = CONVERSATION_REPLY_RENDER_WAIT_MS, intervalMs = 250): Promise<ConversationReplyRender> {
|
|
const latest = bindings.replies.at(-1);
|
|
if (!latest) return "rendered";
|
|
let documentIdentity: string;
|
|
try { documentIdentity = await page.evaluate(readConversationDocumentIdentity); } catch { return "closed"; }
|
|
const waitKey = `${documentIdentity}:${latest}`;
|
|
const expired = expiredReplyWaits.get(page) ?? new Set<string>();
|
|
if (expired.has(waitKey)) timeoutMs = 0;
|
|
// Bounded by attempts as well as time so a frozen test clock cannot spin.
|
|
for (let attempt = 0, attempts = Math.max(1, Math.ceil(timeoutMs / intervalMs)), deadlineAt = Date.now() + timeoutMs; ; attempt++) {
|
|
let state: unknown;
|
|
try { state = await page.evaluate(readLatestConversationReplyRender, { anchors: bindings.anchors, latest }); } catch { return "closed"; }
|
|
if (state !== "pending") return state === "closed" ? "closed" : "rendered";
|
|
if (attempt + 1 >= attempts || Date.now() >= deadlineAt) { expired.add(waitKey); expiredReplyWaits.set(page, expired); return "pending"; }
|
|
await new Promise(resolve => setTimeout(resolve, intervalMs));
|
|
}
|
|
}
|
|
/** A finished run's reply comment can be saved shortly after the run itself is recorded as finished, and the open
|
|
* conversation renders it later still. Before acting on a turn's rendered links, wait (bounded) for each finished
|
|
* lead run's saved reply, then for the latest to render. "unsaved" means no run saved a reply in time. */
|
|
export const TURN_REPLY_SAVE_WAIT_MS = 15_000;
|
|
export async function waitForSavedTurnReplyRender(page: Pick<Page, "evaluate">, input: {
|
|
comments: () => Promise<Row[]>; leadId: string; runIds: readonly string[];
|
|
}, timeoutMs = TURN_REPLY_SAVE_WAIT_MS, intervalMs = 250): Promise<ConversationReplyRender | "unsaved"> {
|
|
const deadlineAt = Date.now() + timeoutMs;
|
|
for (let attempt = 0, attempts = Math.max(1, Math.ceil(timeoutMs / intervalMs)); ; attempt++) {
|
|
const rows = await input.comments();
|
|
const replies = rows.filter(row => row.authorAgentId === input.leadId && input.runIds.includes(String(row.createdByRunId)));
|
|
const saved = input.runIds.length > 0 && input.runIds.every(id => replies.some(row => row.createdByRunId === id));
|
|
if (saved || attempt + 1 >= attempts || Date.now() >= deadlineAt) {
|
|
if (!replies.length) return "unsaved";
|
|
return waitForLatestConversationReplyRender(page, { anchors: rows.map(row => String(row.id)), replies: replies.map(row => String(row.id)) },
|
|
Math.max(CONVERSATION_REPLY_RENDER_WAIT_MS, deadlineAt - Date.now()), intervalMs);
|
|
}
|
|
await new Promise(resolve => setTimeout(resolve, intervalMs));
|
|
}
|
|
}
|
|
export async function collectConversationLinks(page: Page, input: ConversationLinkInput) {
|
|
return (await collectConversationLinksWithDiagnostics(page, input)).links;
|
|
}
|
|
/** What the page showed when a saved reply yielded no rendered links: each candidate thread root, whether it
|
|
* is visible, which saved comment anchors it renders, and how many anchors each saved reply carries. */
|
|
export interface ConversationLinkDiagnostics {
|
|
render: ConversationReplyRender; expectedReplyIds: string[]; savedCommentCount: number;
|
|
threads: Array<{ testId: string | null; visible: boolean; renderedCommentIds: string[]; foreignCommentIds: string[]; replyAnchorCounts: Record<string, number> }>;
|
|
}
|
|
export function readConversationLinkDiagnostics(input: Pick<ReturnType<typeof conversationLinkBindings>, "anchors" | "replies">): Omit<ConversationLinkDiagnostics, "render"> {
|
|
const threadSelector = '[data-testid="task-chat-thread"], [data-testid="thread-root"]';
|
|
return { expectedReplyIds: input.replies, savedCommentCount: input.anchors.length,
|
|
threads: Array.from(document.querySelectorAll(threadSelector)).map(root => {
|
|
const ids = Array.from(root.querySelectorAll('[id^="comment-"]')).filter(node => node.closest(threadSelector) === root).map(node => node.id.slice("comment-".length));
|
|
return { testId: root.getAttribute("data-testid"), visible: root.getClientRects().length > 0,
|
|
renderedCommentIds: ids.filter(id => input.anchors.includes(id)), foreignCommentIds: ids.filter(id => !input.anchors.includes(id)),
|
|
replyAnchorCounts: Object.fromEntries(input.replies.map(id => [id, root.querySelector(`[id="comment-${id}"]`)?.querySelectorAll("a[href]").length ?? 0])) };
|
|
}) };
|
|
}
|
|
export async function collectConversationLinksWithDiagnostics(page: Page, input: ConversationLinkInput): Promise<{ links: RenderedConversationLink[]; diagnostics?: ConversationLinkDiagnostics }> {
|
|
const bindings = conversationLinkBindings(input);
|
|
const render = await waitForLatestConversationReplyRender(page, bindings);
|
|
const links = await page.evaluate(readConversationDomLinks, bindings);
|
|
if (links.length || !bindings.replies.length) return { links };
|
|
let diagnostics: ConversationLinkDiagnostics;
|
|
try { diagnostics = { render, ...await page.evaluate(readConversationLinkDiagnostics, { anchors: bindings.anchors, replies: bindings.replies }) }; }
|
|
catch { diagnostics = { render, expectedReplyIds: bindings.replies, savedCommentCount: bindings.anchors.length, threads: [] }; }
|
|
// Logged so an empty capture says whether the thread was closed, another conversation, or the reply had no anchors yet.
|
|
console.info(`[chat-rendered-links] no rendered reply links: ${JSON.stringify(diagnostics)}`);
|
|
return { links, diagnostics };
|
|
}
|
|
export function conversationLinkLocator(page: Page, link: RenderedConversationLink): Locator {
|
|
const thread = page.getByTestId(link.threadTestId).filter({ has: page.locator(`[id=${JSON.stringify(`comment-${link.anchorCommentId}`)}]`) });
|
|
return link.source === "reply"
|
|
? thread.locator(`[id=${JSON.stringify(`comment-${link.commentId}`)}] a[href=${JSON.stringify(link.href)}]`)
|
|
: thread.getByRole("article", { name: link.cardLabel!, exact: true }).locator(`a[href=${JSON.stringify(link.href)}]`);
|
|
}
|