Files
PaperClipAI/tests/runner-e2e/chat-readiness-observer.test.ts
T
f4337bb5fb test(evals): land the chat catalog eval harness on master (#19614)
## Thinking Path

> - Paperclip is the open source app people use to manage AI agents for
work
> - The chat-feature evals measure whether agents complete real chat
requests through the product
> - The chat catalog eval harness and its repairs live on the
`chat-eval/master-candidate` branch, not on master
> - Today's work made 139 of 242 chat evals pass in verified single-case
live runs. Each product fix landed on master as its own pull request
> - The eval-side changes (setups, graders, fault seams, evidence
capture) still exist only on the candidate
> - This pull request lands the harness on master. Master stays the
source of truth for product behavior
> - The benefit is one tree: evals run against master commits, and
product fixes reach the evals as soon as they merge

## Linked Issues or Issue Description

Refs #19441, Refs #19599, Refs #20270, Refs #20334, Refs #20342, Refs
#20344, Refs #20354, Refs #20360, Refs #20373, Refs #20382, Refs #20409

**What existing behavior does this improve?**
The chat catalog eval harness and the product it evaluates live on a
long-running branch outside master. Eval fixes do not reach master, so
master-based eval runs use old setups and graders.

**Subsystem affected**
`tests/runner-e2e` chat catalog harness, plus a small set of product
changes that exist only on the candidate.

**Proposed change**
Land the harness on master. Every product fix from this eval work
already merged to master as its own pull request. Conflicts keep
master's product behavior.

## What Changed

- Most of the diff (808 of 851 files) is under `tests/runner-e2e/`:
chat-catalog domains, scenarios, descriptors, the TestOps manifest,
private evidence tooling, and their tests.
- Graders now check saved state, setup literals and rendered or clicked
links. Many keyword and regex checks on free-form replies are removed.
Each changed grader has a bumped `oracleVersion` and calibration tests
(a valid reply, a reworded valid reply, and broken variants that must
fail).
- The shared link helper `hasLink` no longer treats a list link (for
example `/COM/issues?view=mine`) as a link to every task without a URL
key.
- Setup fixes build real state through supported product routes: routine
history, agent grants through the board grant route, budget holds with a
real cap, and a storage-layer archive fault for
`inbox-search.archive-partial-failure`.
- Browser boundary journeys (sign-in, chat-disabled, onboarding) now
write the standard pass evidence files.
- Retargeted cases, approved by the maintainer:
`agent-chat.chat-disabled` (Conference Room gate),
`agents.restore-instructions` (no saved instruction history),
`access.manage-membership` (member permission edits stay board-only).
- The private evidence trusted files (`manual-private-handoff.ts`,
`manual-private-retention.ts`, `manual-private-report-assets.ts`) are
byte-identical to master.
- Product files outside `tests/` (43 files, +1,328 −49) carry
candidate-only changes that master does not yet have. Most are tests.
The main code changes are in `request-human-input.ts`,
`heartbeat-run-summary.ts`, `native-completion-feedback.ts`,
`native-run-finalizer.ts`, `openapi.ts`, `secrets.ts` and
`IssueChatLongThreadPerf.tsx`.

## Verification

- `pnpm vitest run chat-catalog-domains chat-catalog-contract.test.ts
chat-catalog-consistency.test.ts unit-launcher.test.mjs
--testTimeout=180000` in `tests/runner-e2e`: 269 files pass, 3,550 tests
pass.
- `node --test chat-full-catalog-testops-manifest.test.mjs`: 10 pass.
- `node tests/runner-e2e/source-sdk-public-inputs.mjs <HEAD> --check`:
no change.
- `tsc` for `server` and `tests/runner-e2e`: clean.
- Live single-case verification: 139 of 242 cases passed on paid runs,
and a person read the saved evidence for each. These are single-case
runs, not one full-cohort run.

## Risks

- Large diff. Most of it is test-only, but the 43 non-test files change
product code paths. Review those files first.
- Some graders are now less strict on reply wording. A person must read
replies for meaning on those cases.
- 42 cases need disposable outside accounts (Notion, Slack, GitHub,
Daytona and others) and stay blocked. `access.invite-teammate` stays
failing until local agent isolation lands, because the runner's durable
state keeps a live invite token.
- The paid workflow compares the trusted private-evidence files with
master. They are unchanged, so this risk is low.

## Model Used

Anthropic Claude Opus 5.5 (`claude-opus-5-5`), with tool use and code
execution, in Claude Code. Subagents used the same model.

## Checklist

- [x] I have included a thinking path that traces from project context
to this change
- [x] I have specified the model used (with version and capability
details)
- [x] I have checked ROADMAP.md and confirmed this PR does not duplicate
planned core work
- [x] I have searched GitHub for duplicate or related PRs and linked
them above
- [x] I have either (a) linked existing issues with `Fixes: #` / `Closes
#` / `Refs #` OR (b) described the issue in-PR following the relevant
issue template
- [x] I have not referenced internal/instance-local Paperclip issues or
links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip`
URLs)
- [x] My branch name describes the change (e.g. `docs/...`, `fix/...`)
and contains no internal Paperclip ticket id or instance-derived details
- [x] I have run tests locally and they pass
- [x] I have added or updated tests where applicable
- [x] I have updated relevant documentation to reflect my changes
- [x] I have considered and documented any risks above
- [ ] All Paperclip CI gates are green
- [ ] Greptile is 5/5 with no open P2s, recommendations, or follow-ups
- [x] I will address all Greptile and reviewer comments before
requesting merge

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Paperclip <noreply@paperclip.ing>
2026-11-10 08:02:11 -06:00

109 lines
8.7 KiB
TypeScript

import { afterEach, describe, expect, it, vi } from "vitest";
import { chmod, mkdir, mkdtemp, readFile, realpath, rm, writeFile } from "node:fs/promises";
import os from "node:os";
import path from "node:path";
import type { ServerAdapterModule } from "../../server/src/adapters/types.js";
import { installChatReadinessObserver, readChatReadinessReceipts, readinessErrorCategory } from "./chat-readiness-observer.js";
const roots: string[] = [];
const companyId = "11111111-1111-4111-8111-111111111111";
const ids = ["chat-features.runner-opencode.local.create-backlog"];
const context = { companyId, adapterType: "paperclip_runner", config: { provider: "opencode", env: { PRIVATE_KEY: "private-config-canary" } } };
const result = () => ({ adapterType: "paperclip_runner", status: "fail" as const, testedAt: "2026-10-27T14:00:00Z",
checks: [{ code: "opencode_hello_probe_failed", level: "error" as const, message: "OpenCode hello probe failed.",
detail: "HTTP 429 private-provider-canary", hint: "private-hint-canary" }] });
async function fixture() {
const temporaryRoot = await realpath(await mkdtemp(path.join(os.tmpdir(), "readiness-observer-"))); roots.push(temporaryRoot);
const testEnvironment = vi.fn(async () => result());
const adapter = { testEnvironment } as Pick<ServerAdapterModule, "testEnvironment">;
await installChatReadinessObserver({ executionIds: ids, temporaryRoot, adapter });
return { temporaryRoot, adapter, testEnvironment, receipts: () => readChatReadinessReceipts(temporaryRoot, companyId) };
}
afterEach(async () => { await Promise.all(roots.splice(0).map(root => rm(root, { recursive: true, force: true }))); });
describe("transparent same-call readiness retention", () => {
it("calls exactly once with the original args/this and returns the identical result", async () => {
const f = await fixture(), original = result(); f.testEnvironment.mockResolvedValue(original);
expect(await f.adapter.testEnvironment(context)).toBe(original);
expect(f.testEnvironment).toHaveBeenCalledExactlyOnceWith(context);
expect(f.testEnvironment.mock.contexts[0]).toBe(f.adapter);
const receipts = await f.receipts();
expect(receipts).toMatchObject([{ companyId, sequence: 1, status: "fail", thrown: false,
checks: [{ code: "opencode_hello_probe_failed", level: "error", category: "rate-limit" }] }]);
const bytes = await readFile(path.join(f.temporaryRoot, "artifacts-private", "chat-readiness-probes.jsonl"), "utf8");
expect(bytes + JSON.stringify(receipts)).not.toMatch(/private-|detail|message|hint|env|config/);
expect(receipts[0]).not.toHaveProperty("agentId");
});
it("accepts the existing launcher directory beneath its private root", async () => {
const temporaryRoot = await realpath(await mkdtemp(path.join(os.tmpdir(), "readiness-observer-"))); roots.push(temporaryRoot);
await mkdir(path.join(temporaryRoot, "artifacts-private"), { mode: 0o755 });
const adapter: Pick<ServerAdapterModule, "testEnvironment"> = { testEnvironment: vi.fn(async () => result()) };
await installChatReadinessObserver({ executionIds: ids, temporaryRoot, adapter });
await adapter.testEnvironment(context);
expect(await readChatReadinessReceipts(temporaryRoot, companyId)).toHaveLength(1);
await chmod(temporaryRoot, 0o755);
await expect(installChatReadinessObserver({ executionIds: ids, temporaryRoot, adapter })).rejects.toThrow("owned private attempt root");
});
it("rethrows the identical error without another call or raw error output", async () => {
const f = await fixture(), error = new Error("Cannot find package private-package-canary");
f.testEnvironment.mockRejectedValue(error);
await expect(f.adapter.testEnvironment(context)).rejects.toBe(error);
expect(f.testEnvironment).toHaveBeenCalledTimes(1);
expect(await f.receipts()).toMatchObject([{ status: "unknown", thrown: true, errorCategory: "module-missing" }]);
expect(JSON.stringify(await f.receipts())).not.toContain("private-package-canary");
});
it("never replaces the original result when diagnostic storage fails", async () => {
const f = await fixture(), original = result(); f.testEnvironment.mockResolvedValue(original);
await writeFile(path.join(f.temporaryRoot, "artifacts-private", "chat-readiness-probes.jsonl"), "", { mode: 0o644 });
expect(await f.adapter.testEnvironment(context)).toBe(original);
expect(f.testEnvironment).toHaveBeenCalledTimes(1);
});
it("keeps sequence only within the attempt and filters foreign companies", async () => {
const f = await fixture(); await f.adapter.testEnvironment(context); await f.adapter.testEnvironment(context);
expect((await f.receipts()).map(row => row.sequence)).toEqual([1, 2]);
expect(await readChatReadinessReceipts(f.temporaryRoot, "22222222-2222-4222-8222-222222222222")).toEqual([]);
});
it("reprojects arbitrary keys, status, codes and categories as unknown", async () => {
const f = await fixture();
await writeFile(path.join(f.temporaryRoot, "artifacts-private", "chat-readiness-probes.jsonl"), JSON.stringify({ schema: "paperclip.chat-readiness-probe/v1", companyId, sequence: 1,
status: "private-status", secret: "private-extra", checks: [{ code: "private-code", level: "private-level", category: "private-category", detail: "private-detail" }] }));
const receipts = await f.receipts();
expect(receipts).toMatchObject([{ status: "unknown", checks: [{ code: "unknown", level: "unknown", category: "unknown" }] }]);
expect(JSON.stringify(receipts)).not.toContain("private-");
});
it("does not observe an unrelated provider or execution", async () => {
const f = await fixture(); await f.adapter.testEnvironment({ ...context, config: { provider: "codex" } });
expect(await f.receipts()).toEqual([]);
const original = vi.fn(async () => result()), adapter = { testEnvironment: original };
await installChatReadinessObserver({ executionIds: ["other.runner-opencode.local.case"], temporaryRoot: "", adapter });
expect(adapter.testEnvironment).toBe(original);
});
it.each([
["agent_runner_config_incompatible", "unknown"], ["paperclip_runner_mode_invalid", "unknown"], ["paperclip_runner_opencode_model_invalid", "unknown"],
])("preserves source profile-validation code %s without its message", async (code, category) => {
const f = await fixture(); f.testEnvironment.mockResolvedValue({ ...result(), checks: [{ code, level: "error", message: "private-profile-canary", detail: "private-canary", hint: "private-canary" }] });
await f.adapter.testEnvironment(context);
expect((await f.receipts())[0]!.checks).toEqual([{ code, level: "error", category }]);
expect(JSON.stringify(await f.receipts())).not.toContain("private-");
});
// Actual check.message/detail layouts emitted by opencode-local/server/test.ts:
// summarizeProbeDetail selects parsed error, first stderr or first stdout line.
it.each([
["opencode_command_unresolvable", "Command is not executable: ENOENT", "opencode", "command-missing"],
["opencode_openai_api_key_missing", "OPENAI_API_KEY override is empty.", "", "unknown"],
["opencode_hello_probe_auth_required", "OpenCode is installed, but provider authentication is not ready.", "HTTP 401 Unauthorized private-canary", "authentication"],
["opencode_hello_probe_model_unavailable", "The configured model was not found by the provider.", "ProviderModelNotFoundError private-canary", "model-unavailable"],
["opencode_hello_probe_failed", "OpenCode hello probe failed.", '{"name":"APIError","data":{"statusCode":429,"message":"private-canary"}}', "rate-limit"],
["opencode_hello_probe_failed", "OpenCode hello probe failed.", "fetch failed ECONNREFUSED private-canary", "network"],
["opencode_hello_probe_timed_out", "OpenCode hello probe timed out.", "", "timeout"],
["opencode_hello_probe_failed", "OpenCode hello probe failed.", "private-unknown-canary", "unknown"],
])("retains closed actual-source diagnostic shape %s/%s", async (code, message, detail, category) => {
const f = await fixture(); f.testEnvironment.mockResolvedValue({ ...result(), checks: [{ code, level: "error", message, detail, hint: "private-hint-canary" }] });
await f.adapter.testEnvironment(context);
expect((await f.receipts())[0]!.checks).toEqual([{ code, level: "error", category }]);
expect(JSON.stringify(await f.receipts())).not.toMatch(/private-|APIError|statusCode|detail|message|hint/);
});
it.each([
["HTTP 401 private", "authentication"], ["ECONNREFUSED private", "network"], ["EPERM private", "permission"],
["ENOENT private", "command-missing"], ["timed out private", "timeout"], ["unrecognized private", "unknown"],
])("classifies only a closed category for %s", (value, category) => expect(readinessErrorCategory(value)).toBe(category));
});