Files
PaperClipAI/tests/runner-e2e/everyday-observations.ts
T
DottaandPaperclip d0db8820db fix(connections): repair native baseline and approval continuations (#15420)
## Thinking Path

> - Paperclip manages AI agents and the tools they may use.
> - Connection setup separates provider preference from permission to
use a tool.
> - The first native connection baseline could not exercise its intended
decisions.
> - The browser used mutable task titles, and the provider fixture
already granted access.
> - Native provider-choice instructions also disagreed with the
preferred question format. Schema rejection gave no field guidance.
> - This pull request repairs those test preconditions and native
guidance, then fixes restart/approval defects exposed by the corrected
baseline. It also restores missing OpenCode tool-error evidence.
> - The benefit is an inspectable baseline before any further
instruction reduction.

## Linked Issues or Issue Description

Refs #15407.

The original 15-cell baseline remains 0 PASS / 15 FAIL. Ten cells
stopped on stale titles, two Codex cells had schema denials, two
OpenCode cells used already-granted tools, and one Claude cell returned
no native result. No intended user decisions were submitted. The exact
invalid Codex field and underlying Claude failure cause remain unknown.

[Original
campaign](https://github.com/paperclipai/paperclip/actions/runs/37562577199)
· [Original
report](https://d1p6rlowie26tp.cloudfront.net/runner-e2e/campaigns/gha-37562577199-1/index.html)

## What Changed

- Match the browser's task route and visible identifier instead of a
title the agent can change.
- Start native provider-choice fixtures with no agent tool access.
Verify the public effective-access records.
- In the positive case, select Arcade, then grant its exact HubSpot tool
through the real access card. Require both saved decisions and exactly
one observed call.
- Return a canonical `providerQuestionSet` for native input and retain
the equivalent legacy `providerQuestion`.
- Keep invalid input rejected. Return bounded schema locations and
required field names without submitted values.
- Preserve Claude's exact session/content identity while allowing
authenticated registered instruction-copy paths to rotate on a new run.
- Reject duplicate approval reports for an existing exact tool-action
card before they create another human review.
- Wait for a recorded service-approval continuation within the existing
deadline; retain missing or failed continuation grades.
- Forward OpenCode tool activity through the runner facade, preserving
bounded errors and execution-part identity without inventing host-call
joins or exposing arguments.
- Preserve original grades, costs, scope limits and diagnoses in the
dated repair report.

## Verification

- Eval typecheck passes. Support suite: 1,801 PASS, one intentional
skip; Node checks: 128 PASS.
- Connection/schema tests: 51 PASS. Real-server public fixture setup:
one PASS with zero providers.
- Browser support regression: five PASS, including renamed and wrong
tasks.
- Focused Rust safe-feedback test: one PASS.
- Repository typecheck and build pass before the latest master replay.
Post-replay connection/shared/real-server fixture checks: 52 PASS; eval
typecheck passes. The browser review fix additionally passes all five
browser checks and seven suite checks.
- The full local repository run was interrupted incomplete after about
45 minutes, with five integration failures retained. All five pass in a
separate targeted invocation (1,250 unrelated tests skipped). No full
local-suite pass or root cause for the initial local failures is
claimed.
- Corrected frozen source `162cc90fdabe7f505b88ae095044531b82784c92`:
**10 PASS / 5 FAIL** across the [passing Codex
canary](https://github.com/paperclipai/paperclip/actions/runs/37575158761)
and [remaining 14
cells](https://github.com/paperclipai/paperclip/actions/runs/37576261807).
The canary passes all 17 checks. Claude's two provider-choice
continuations fail on restart, Claude service approval exposes an early
evaluator rejection, Codex service approval creates a duplicate
approval, and OpenCode provider-second times out after both decisions
with no HubSpot call. No original result is regraded.
- Final ledgers count 31 actual runs: 27 succeeded, two failed, two
cancelled during cleanup. All 15 cleanup/budget checks pass. The late
Claude continuation is absent from its earlier workflow snapshot; it
remains in the result/API/final ledger. Original evidence retains 279
hashes. Recorded LLM subtotal $0.04553787 is incomplete billing, not
actual total cost; local runtime is unmetered.
- New repair regressions reproduce the Claude attach failure, duplicate
approval acceptance and dropped OpenCode tool events before their
respective fixes. Nine Rust attachment checks, 127 ACPX host/adapter
tests, 33 completion/control-plane checks, nine eval deadline tests, 59
OpenCode proxy/driver tests, one Rust tool-error/redaction check, and
TypeScript/Rust composer parity pass. Eval typecheck, repository
typecheck and build pass. Existing support coverage is 1,802 PASS plus
128 Node PASS, one intentional support skip; two additional deadline
tests also pass.
- New-source full CI/review and live canaries are pending. The next
bounded selection is Claude provider-decline, Codex service-approve and
one OpenCode provider-second diagnostic with repaired event evidence. No
broader campaign or instruction-reduction qualification is claimed.
- Initial corrected campaign
[37574251834](https://github.com/paperclipai/paperclip/actions/runs/37574251834)
was cancelled during shared build after review found the breadcrumb
whitespace assumption. Its matrix job has zero steps and no provider
execution. The real adjacent-span browser regression now reproduces the
old failure and passes after the fix.

## Risks

- The corrected baseline remains 10/15. The new restart/approval fixes
require live qualification; OpenCode evidence forwarding does not itself
establish or fix its prior behavioral failure.
- The positive provider case now expects three runs, including separate
access approval. Its new results are distinct from the original invalid
fixture.
- The old Claude missing-result cause and rejected Codex field are
unknown. These repairs do not retroactively explain or erase either
failure.
- Path rotation must preserve prompt, custom instruction, skill/content
identity and protected provider settings; regression checks reject stale
or changed content. No connection authorization, JSON schema, budget,
cleanup, or final-result requirement is relaxed. Historical Everyday
prompts and gateway setup remain unchanged.

## Model Used

OpenAI Codex, GPT-6. The exact deployment variant and context window are
not exposed in this session. Used repository inspection, code editing,
test execution and retained-evidence analysis.

## Checklist

- [x] I have included a thinking path that traces from project context
to this change
- [x] I have specified the model used (with version and capability
details)
- [x] I have checked ROADMAP.md and confirmed this PR does not duplicate
planned core work
- [x] I have searched GitHub for duplicate or related PRs and linked
them above
- [x] I have either (a) linked existing issues with `Fixes: #` / `Closes
#` / `Refs #` OR (b) described the issue in-PR following the relevant
issue template
- [x] I have not referenced internal/instance-local Paperclip issues or
links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip`
URLs)
- [x] My branch name describes the change (e.g. `docs/...`, `fix/...`)
and contains no internal Paperclip ticket id or instance-derived details
- [ ] I have run tests locally and they pass
- [x] I have added or updated tests where applicable
- [x] I have updated relevant documentation to reflect my changes
- [x] I have considered and documented any risks above
- [ ] All Paperclip CI gates are green
- [ ] Greptile is 5/5 with no open P2s, recommendations, or follow-ups
- [x] I will address all Greptile and reviewer comments before
requesting merge

---------

Co-authored-by: Paperclip <noreply@paperclip.ing>
2026-10-07 06:18:51 -05:00

638 lines
22 KiB
TypeScript

import type { IssueComment } from "../../packages/shared/src/types/issue.js";
export interface StoryCheck {
id: string;
passed: boolean;
detail: string;
}
export interface StoryIssue {
id: string;
companyId: string;
title: string;
status: string;
identifier?: string | null;
description?: string | null;
createdAt?: string;
updatedAt?: string;
assigneeAgentId?: string | null;
parentId?: string | null;
projectId?: string | null;
executionRunId?: string | null;
scheduledRetry?: unknown;
activeRecoveryAction?: unknown;
comments?: StoryComment[];
interactions?: StoryInteraction[];
activity?: StoryActivityRecord[];
wakeDiagnostics?: StoryWakeDiagnostics;
blockedTransitionAt?: string | null;
}
export interface StoryComment extends Partial<Pick<IssueComment, "authorAgentId" | "createdByRunId">> {
id?: string;
body?: unknown;
createdAt?: string;
}
export interface StoryActivityRecord {
action?: string;
details?: unknown;
createdAt?: string;
}
export interface StoryInteraction {
sourceRunId?: string | null;
createdByAgentId?: string | null;
id?: string;
kind?: string;
issueId?: string | null;
status?: string;
continuationPolicy?: string | null;
resolverPolicy?: string | null;
effectiveResolverPolicy?: string | null;
addresseeAgentId?: string | null;
resolvedByAgentId?: string | null;
resolvedByRunId?: string | null;
resolvedAt?: string | null;
result?: Record<string, unknown> | null;
payload?: Record<string, unknown> | null;
createdAt?: string;
}
/** Select the accepted review card for the same child and lead after the initial handoff boundary. */
export function storyAcceptedAgentReview(
child: StoryIssue | undefined,
initialInteractionId: string | undefined,
leadId: string,
runs: StoryRun[],
): StoryInteraction | undefined {
if (!child?.interactions?.length || !initialInteractionId) return undefined;
const initial = child.interactions.find(
(candidate) => candidate.id === initialInteractionId,
);
if (!initial) return undefined;
const initialCreatedAt = Date.parse(initial.createdAt ?? "");
return child.interactions
.filter((candidate) => {
const result = candidate.result;
const target = candidate.payload?.target as
| Record<string, unknown>
| undefined;
const revisionId = String(target?.revisionId ?? "");
const reviewRun = runs.find(
(run) => run.id === candidate.resolvedByRunId,
);
return (
candidate.kind === "request_confirmation" &&
target?.type === "custom" &&
target?.key === "native_completion_review" &&
candidate.issueId === child.id &&
candidate.addresseeAgentId === leadId &&
candidate.resolvedByAgentId === leadId &&
candidate.status === "accepted" &&
Number.isFinite(initialCreatedAt) &&
Number.isFinite(Date.parse(candidate.createdAt ?? "")) &&
Date.parse(candidate.createdAt ?? "") >= initialCreatedAt &&
result?.version === 1 &&
result?.outcome === "accepted" &&
reviewRun?.status === "succeeded" &&
reviewRun.agentId === leadId &&
reviewRun.contextSnapshot?.nativeReviewInteractionId === candidate.id &&
reviewRun.contextSnapshot?.nativeReviewDecisionId === revisionId &&
revisionId.length > 0
);
})
.sort((a, b) =>
Date.parse(a.resolvedAt ?? "") - Date.parse(b.resolvedAt ?? ""),
)[0];
}
export interface StoryWakeDiagnosticEvent {
kind?: string;
agentId?: string | null;
reason?: string | null;
status?: string;
payload?: Record<string, unknown> | null;
}
export interface StoryWakeDiagnostics {
events?: StoryWakeDiagnosticEvent[];
blockerDiagnostics?: {
readiness?: { unresolvedBlockerCount?: number | null } | null;
blockers?: unknown[];
};
}
export interface StoryRun {
id: string;
companyId: string;
agentId: string;
status: string;
runtimeMode?: string;
runnerInstanceId?: string | null;
processPid?: number | null;
processStartedAt?: string | null;
nativeIssueId?: string | null;
nativeSessionId?: string | null;
contextSnapshot?: Record<string, unknown> | null;
resultJson?: Record<string, unknown> | null;
usageJson?: Record<string, unknown> | null;
runnerProfileJson?: Record<string, unknown> | null;
sessionIdAfter?: string | null;
startedAt?: string | null;
finishedAt?: string | null;
retryOfRunId?: string | null;
scheduledRetryReason?: string | null;
runtimeModeResolvedAt?: string | null;
lastOutputSeq?: number | null;
errorCode?: string | null;
error?: string | null;
}
export type StoryArtifactGradeMode = "base" | "separator" | "max-length";
/** Select the artifact oracle variant required by each workflow's actual case. */
export function artifactGradeModeForPhase(
phase:
| "hired-delivery"
| "reused-delivery"
| "delegated-delivery"
| "reviewed-delivery"
| "recovered-delivery",
): StoryArtifactGradeMode {
switch (phase) {
case "hired-delivery":
case "reviewed-delivery":
return "base";
case "reused-delivery":
return "separator";
case "delegated-delivery":
case "recovered-delivery":
return "max-length";
}
}
/** A review run is valid only after the lead run has completed. */
export function storyParentCompletionPrecedesReview(
parentFinishedAt: string | null | undefined,
reviewStartedAt: string | null | undefined,
parentBlocked: boolean,
): boolean {
if (reviewStartedAt) {
return Boolean(
parentFinishedAt &&
Date.parse(parentFinishedAt) <= Date.parse(reviewStartedAt),
);
}
return parentBlocked;
}
export const isActiveStoryRun = (run: StoryRun) =>
["queued", "running", "scheduled_retry"].includes(run.status);
export function isStoryWorkspaceDeferral(run: StoryRun) {
const recovery = run.resultJson?.executionRecovery as
Record<string, unknown> | undefined;
const startup = run.resultJson?.startupCancellation as
Record<string, unknown> | undefined;
const neverStartedRetry =
run.errorCode === "cancelled" &&
run.scheduledRetryReason === "workspace_busy" &&
typeof run.retryOfRunId === "string" &&
run.retryOfRunId.length > 0 &&
run.startedAt === null &&
run.runtimeModeResolvedAt === null &&
run.lastOutputSeq === 0 &&
!run.processStartedAt &&
!run.sessionIdAfter &&
!run.usageJson &&
!run.runnerProfileJson?.nativeExecutionInput &&
typeof startup?.requestedAt === "string" &&
Number.isFinite(Date.parse(startup.requestedAt));
return (
run.status === "cancelled" &&
((run.errorCode === "workspace_busy" &&
recovery?.providerWorkStarted === false) ||
neverStartedRetry) &&
!run.runnerInstanceId &&
!run.nativeSessionId &&
!run.processPid
);
}
/** Exempt the injected stop itself, never a later recovery/provider failure on that run. */
export function isExpectedStoryInterruption(
run: StoryRun,
allowedRunIds: readonly string[],
): boolean {
if (!allowedRunIds.includes(run.id)) return false;
return (
(run.status === "cancelled" && (!run.errorCode || run.errorCode === "cancelled")) ||
(run.status === "interrupted" && run.errorCode === "server_shutdown_interrupted") ||
(run.status === "failed" && run.errorCode === "process_lost")
);
}
export function storyUnexpectedRunFailure(runs: StoryRun[], allowedRunIds: readonly string[]) {
return runs.find((run) =>
["failed", "timed_out", "cancelled", "interrupted"].includes(run.status) &&
!isStoryWorkspaceDeferral(run) &&
!isExpectedStoryInterruption(run, allowedRunIds),
);
}
/** Called after the boundary matcher; reject only with durable proof of the wrong ordering. */
export function storyUnexercisedReviewBoundary(
issues: StoryIssue[],
runs: StoryRun[],
parentId: string,
leadId: string,
): string | undefined {
if (issues.length === 0 || runs.length === 0) return;
if (!issues.every((issue) =>
issue.status === "done" && !issue.scheduledRetry && !issue.activeRecoveryAction,
)) return;
if (!runs.every((run) => run.status === "succeeded")) return;
const child = issues.find((issue) => issue.parentId === parentId);
const accepted = child?.interactions?.flatMap((interaction) => {
const review = storyAcceptedAgentReview(child, interaction.id, leadId, runs);
return review ? [review] : [];
})[0];
const reviewRun = accepted && runs.find((run) => run.id === accepted.resolvedByRunId);
const reviewStartedAt = Date.parse(reviewRun?.startedAt ?? "");
const parentRuns = runs.filter((run) =>
run.nativeIssueId === parentId ||
run.contextSnapshot?.issueId === parentId ||
run.contextSnapshot?.taskId === parentId,
);
// Snapshots are fetched separately. Missing review evidence is not proof that it
// never happened; wait unless persisted timestamps rule out the required order.
if (!Number.isFinite(reviewStartedAt) || parentRuns.length === 0) return;
if (!parentRuns.every((run) => {
const finishedAt = Date.parse(run.finishedAt ?? "");
return Number.isFinite(finishedAt) && finishedAt > reviewStartedAt;
})) return;
return "Review handoff boundary not exercised: the accepted review started before any parent run finished, so the blocked-parent-before-review ordering was not tested.";
}
export function storyLifecycleChecks(input: {
issues: StoryIssue[];
runs: StoryRun[];
parentId: string;
leadId: string;
allowedInterruptedRuns?: string[];
}): StoryCheck[] {
const executed = input.runs.filter((r) => !isStoryWorkspaceDeferral(r));
const allowed = input.allowedInterruptedRuns ?? [];
const check = (id: string, passed: boolean, detail: string): StoryCheck => ({
id,
passed,
detail,
});
return [
check(
"tasks-done",
input.issues.length > 0 && input.issues.every((i) => i.status === "done"),
"Every story task must reach Done.",
),
check(
"settled",
!input.runs.some(isActiveStoryRun) &&
!input.issues.some((i) => i.scheduledRetry || i.activeRecoveryAction),
"No active runs or scheduled recovery remain.",
),
check(
"native-runtime",
executed.length > 0 &&
executed.every(
(r) => r.runtimeMode === "native" && Boolean(r.runnerInstanceId),
),
"All executions must prove native runtime and runner identity.",
),
check(
"successful-runs",
executed.every((r) => r.status === "succeeded" || isExpectedStoryInterruption(r, allowed)),
"Only the expected stop or process-loss outcome of an injected interruption is exempt.",
),
check(
"bounded-work",
input.runs.length <= 12,
"No more than twelve executions, including child and recovery turns.",
),
check(
"parent-owned-by-lead",
!executed.some(
(r) =>
(r.contextSnapshot?.issueId === input.parentId ||
r.contextSnapshot?.taskId === input.parentId) &&
r.agentId !== input.leadId,
),
"A mentioned worker must not execute on the parent.",
),
];
}
/** A terminal first turn cannot satisfy a later queued request. */
export function storyRepliesConsumed(
runs: StoryRun[],
commentIds: string[],
): boolean {
return commentIds.every((id) =>
runs.some((run) => {
if (run.status !== "succeeded" || isStoryWorkspaceDeferral(run))
return false;
const input = run.runnerProfileJson?.nativeExecutionInput as
{ task?: { prompt?: string } } | undefined;
return input?.task?.prompt?.includes(id) === true;
}),
);
}
/** A terminal task is only ready for response assertions after its agent reply is visible. */
export function storyHasAgentReply(
issue: StoryIssue | undefined,
agentId: string,
expectedText: string,
): boolean {
return (
issue?.comments?.some(
(comment) =>
comment.authorAgentId === agentId &&
String(comment.body ?? "").includes(expectedText),
) ?? false
);
}
const RUNNABLE_WAKE_STATUSES = new Set([
"queued",
"deferred_issue_execution",
"claimed",
]);
/** A durable wake means an agent still has a recorded next action. */
export function storyHasPendingAgentWake(
issue: StoryIssue | undefined,
agentIds: string | readonly string[],
): boolean {
const ids = new Set(typeof agentIds === "string" ? [agentIds] : agentIds);
return (
issue?.wakeDiagnostics?.events?.some(
(event) =>
event.kind === "wake_request" &&
event.agentId != null &&
ids.has(event.agentId) &&
RUNNABLE_WAKE_STATUSES.has(String(event.status)),
) ?? false
);
}
/** Any issue-scoped wake keeps the workflow actionable while it is being dispatched. */
export function storyHasPendingAgentWork(
issues: StoryIssue[],
agentIds: string | readonly string[],
): boolean {
return issues.some((issue) => storyHasPendingAgentWake(issue, agentIds));
}
/** A blocked story is stranded only when no issue has a durable continuation wake. */
export function storyHasStrandedBlockedLeaf(
issues: StoryIssue[],
agentIds: string | readonly string[],
): boolean {
return (
issues.some((issue) => issue.status === "blocked") &&
!storyHasPendingAgentWork(issues, agentIds)
);
}
/**
* A completed native review is a durable continuation trigger even when the
* parent projection has not yet exposed the claimed wake. Keep the existing
* workflow deadline; its timeout diagnostic identifies a missing continuation.
*/
export function storyHasDurableAgentReviewContinuation(
issues: StoryIssue[],
parentId: string,
leadId: string,
runs: StoryRun[],
): boolean {
const parent = issues.find((issue) => issue.id === parentId);
if (parent?.status !== "blocked") return false;
const blockedAt = Date.parse(parent.blockedTransitionAt ?? "");
const terminalWake = parent.wakeDiagnostics?.events?.some(
(event) =>
event.kind === "wake_request" &&
event.agentId === leadId &&
event.reason === "issue_blockers_resolved" &&
["completed", "failed", "cancelled"].includes(String(event.status)),
);
if (terminalWake) return false;
return issues.some((child) =>
child.parentId === parentId &&
child.status === "done" &&
(child.interactions?.some((interaction) => {
const target = interaction.payload?.target as
| Record<string, unknown>
| undefined;
const reviewRun = runs.find((run) => run.id === interaction.resolvedByRunId);
return (
interaction.kind === "request_confirmation" &&
interaction.status === "accepted" &&
interaction.issueId === child.id &&
interaction.addresseeAgentId === leadId &&
interaction.resolvedByAgentId === leadId &&
interaction.result?.version === 1 &&
interaction.result?.outcome === "accepted" &&
Number.isFinite(blockedAt) &&
Date.parse(interaction.resolvedAt ?? "") >= blockedAt &&
target?.type === "custom" &&
target?.key === "native_completion_review" &&
reviewRun?.status === "succeeded" &&
reviewRun.agentId === leadId
);
}) ?? false),
);
}
/** An executed approval may enqueue its wake just after run finalization.
* Wait within the original deadline only for this task/run's recorded response.
* Once a follow-up run has consumed it, a new blocker is a real failure.
*/
export function storyHasDurableServiceContinuation(issues: StoryIssue[], parentId: string, agentId: string, runs: StoryRun[]): boolean {
const issue = issues.find(i => i.id === parentId);
if (issue?.status !== "blocked" || issue.assigneeAgentId !== agentId) return false;
return issue.interactions?.some(interaction => {
const source = runs.find(run => run.id === interaction.sourceRunId);
const action = interaction.payload?.toolAction as Record<string, unknown> | undefined;
const result = interaction.result?.toolAction as Record<string, unknown> | undefined;
if (interaction.issueId !== parentId || interaction.createdByAgentId !== agentId ||
interaction.kind !== "request_confirmation" || interaction.continuationPolicy !== "wake_assignee" ||
interaction.status !== "accepted" || interaction.result?.outcome !== "accepted" ||
action?.version !== 1 || typeof action.actionRequestId !== "string" || result?.status !== "executed" ||
source?.agentId !== agentId || source.companyId !== issue.companyId || source.status !== "succeeded" ||
!(Date.parse(source.finishedAt ?? "") >= Date.parse(interaction.resolvedAt ?? ""))) return false;
return !runs.some(run => {
const input = run.runnerProfileJson?.nativeExecutionInput as
{ interactionResponses?: Array<{ interactionId?: string }> } | undefined;
return run.id !== source.id && run.agentId === agentId &&
input?.interactionResponses?.some(response => response.interactionId === interaction.id);
});
}) ?? false;
}
/** Timeout evidence requires a stranded leaf with durable accepted-review evidence. */
export function storyReviewContinuationTimeoutDetail(
issues: StoryIssue[],
parentId: string,
leadId: string,
runs: StoryRun[],
observableAgentIds: string | readonly string[],
): string | undefined {
return (
storyHasStrandedBlockedLeaf(issues, observableAgentIds) &&
storyHasDurableAgentReviewContinuation(issues, parentId, leadId, runs)
)
? "task is Blocked without an active continuation after accepted review"
: undefined;
}
/** A pending interaction is agent-owned when its wake policy and wake request agree. */
export function storyHasPendingAgentReview(
issue: StoryIssue | undefined,
agentIds: string | readonly string[],
): boolean {
return Boolean(
issue?.interactions?.some((interaction) =>
storyHasPendingAgentReviewForInteraction(issue, interaction, agentIds),
),
);
}
/** Pending review is human-owned only when no matching agent review wake is runnable. */
export function storyHasPendingHumanInteraction(
issue: StoryIssue | undefined,
agentIds: string | readonly string[],
): boolean {
const pendingInteraction = issue?.interactions?.some(
(interaction) =>
interaction.status === "pending" &&
!storyHasPendingAgentReviewForInteraction(issue, interaction, agentIds),
);
return Boolean(
pendingInteraction,
);
}
function storyHasPendingAgentReviewForInteraction(
issue: StoryIssue | undefined,
interaction: StoryInteraction,
agentIds: string | readonly string[],
): boolean {
const ids = new Set(typeof agentIds === "string" ? [agentIds] : agentIds);
if (
interaction.status !== "pending" ||
interaction.continuationPolicy !== "wake_assignee" ||
interaction.resolverPolicy === "human_only" ||
interaction.effectiveResolverPolicy === "human_only" ||
!interaction.addresseeAgentId ||
!ids.has(interaction.addresseeAgentId)
)
return false;
const wakeEvents =
issue?.wakeDiagnostics?.events?.filter(
(event) =>
event.kind === "wake_request" &&
event.agentId === interaction.addresseeAgentId &&
RUNNABLE_WAKE_STATUSES.has(String(event.status)),
) ?? [];
const explicitlyBound = wakeEvents.some(
(event) =>
event.payload?.nativeReviewInteractionId === interaction.id,
);
if (explicitlyBound) return true;
if (
wakeEvents.some(
(event) => event.payload?.nativeReviewInteractionId != null,
)
)
return false;
const sameAgentPendingCards =
issue?.interactions?.filter(
(candidate) =>
candidate.status === "pending" &&
candidate.continuationPolicy === "wake_assignee" &&
candidate.resolverPolicy !== "human_only" &&
candidate.effectiveResolverPolicy !== "human_only" &&
candidate.addresseeAgentId === interaction.addresseeAgentId,
).length ?? 0;
// The public v1 wake projection has no binding payload. With multiple cards
// for one agent, conservatively refuse to attribute an unbound wake.
return wakeEvents.length > 0 && sameAgentPendingCards === 1;
}
/** The public blocker projection is durable evidence of a dependency hold. */
export function storyIssueHasUnresolvedDependency(issue: StoryIssue): boolean {
const readiness = issue.wakeDiagnostics?.blockerDiagnostics?.readiness;
return (
issue.status === "blocked" &&
((readiness?.unresolvedBlockerCount ?? 0) > 0 ||
(issue.wakeDiagnostics?.blockerDiagnostics?.blockers?.length ?? 0) > 0)
);
}
/** Status history remains observable after the scheduler clears the blocker. */
export function storyIssueHasBlockedTimeline(issue: StoryIssue): boolean {
return storyIssueHasBlockedTimelineBefore(issue);
}
/** A blocker timeline entry is useful only when it predates the review card. */
export function storyIssueHasBlockedTimelineBefore(
issue: StoryIssue,
before?: string,
): boolean {
return Boolean(
issue.activity?.some((record) => {
const action = String(record.action ?? "").toLowerCase();
const details = (record.details ?? {}) as Record<string, unknown>;
const changes = (details.changes ?? {}) as Record<string, unknown>;
const statusChange = (changes.status ?? {}) as Record<string, unknown>;
const recordAt = Date.parse(String(record.createdAt ?? ""));
const beforeAt = before ? Date.parse(before) : Number.NaN;
return (
action === "issue.updated" &&
Number.isFinite(recordAt) &&
(!Number.isFinite(beforeAt) || recordAt <= beforeAt) &&
(details.status === "blocked" ||
details.toStatus === "blocked" ||
statusChange.to === "blocked")
);
}),
);
}
/** Native result evidence survives a fast transition past the blocked projection. */
export function storyRunReportsDependencyBlock(run: StoryRun): boolean {
const result = run.resultJson?.nativeResult as
| Record<string, unknown>
| undefined;
if (result?.reportedWorkDisposition !== "blocked") return false;
const blocker = result.blocker as Record<string, unknown> | undefined;
const reason = String(blocker?.reasonCode ?? "").toLowerCase();
return reason.includes("depend");
}
export function storyParentFinishedAfterChildren(
runs: StoryRun[],
parentId: string,
leadId: string,
childIds: string[],
): boolean {
const scope = (r: StoryRun) =>
r.nativeIssueId ?? r.contextSnapshot?.issueId ?? r.contextSnapshot?.taskId;
const completed = runs.filter(
(r) => r.status === "succeeded" && !isStoryWorkspaceDeferral(r),
);
const children = completed.filter((r) => childIds.includes(String(scope(r))));
if (!children.length) return false;
const lastChildFinish = Math.max(
...children.map((r) => Date.parse(r.finishedAt ?? "")),
);
return completed.some(
(r) =>
r.agentId === leadId &&
scope(r) === parentId &&
Date.parse(r.finishedAt ?? "") >= lastChildFinish,
);
}