mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-29 21:07:40 +01:00
DottaandClaude Opus 4.8
ec7adcaf3d
Foundation for opt-in `tailscale_https` exposure of managed branch runtimes, implementing the PAP-17049 plan under the PAP-17050 threat-model verdict. Broker (packages/tailscale-https-broker): root/dedicated-account host broker exposing only idempotent list/expose/remove over a Unix socket. Implements the six required verdict controls: SO_PEERCRED + UID/GID allowlist + unguessable broker-issued lease handles (req #1); dedicated port allowlist + /proc listener ownership/loopback proof before mutation (req #2); per-mutation transaction (strict-parse serve JSON -> verify absence/exact-lease -> verify :443 -> one fixed per-port op -> reread -> require only-intended-changed + :443 identical -> atomic root-owned registry commit, quarantine-on-ambiguity) (req #3); execve/shell=false argv built only from canonical integers + fixed tokens, pinned CLI schema (req #4); versioned length-bounded strict-JSON protocol (req #5); bounded append-only audit events (req #6). Deny-by-default for Funnel/cert/Services/reset/set-config/path-handlers/:443/reserved ports. Shared contract (packages/shared): single source of truth for exposure config, lifecycle state (pending/ready/failed/cleanup_pending/removed), listener ownership, and status, with strict zod validators and deterministic app/HMR port-pair + URL derivation so DB/server/UI/runtime cannot drift. Tests: broker 57/57, shared runtime-exposure 13/13, both typecheck clean. Server/DB/UI lifecycle integration + docs land in follow-on commits. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
41 lines
1.5 KiB
TypeScript
41 lines
1.5 KiB
TypeScript
import { describe, expect, it } from "vitest";
|
|
import { buildExposeArgv, buildRemoveArgv, buildStatusArgv } from "./argv.js";
|
|
|
|
const BIN = "/usr/bin/tailscale";
|
|
|
|
describe("argv construction", () => {
|
|
it("builds an exact status argv with no shell tokens", () => {
|
|
expect(buildStatusArgv(BIN)).toEqual([BIN, "serve", "status", "--json"]);
|
|
});
|
|
|
|
it("builds exact same-number expose/remove argv vectors", () => {
|
|
expect(buildExposeArgv(BIN, 42010)).toEqual([
|
|
BIN,
|
|
"serve",
|
|
"--bg",
|
|
"--https=42010",
|
|
"http://127.0.0.1:42010",
|
|
]);
|
|
expect(buildRemoveArgv(BIN, 42010)).toEqual([BIN, "serve", "--https=42010", "off"]);
|
|
});
|
|
|
|
it("refuses the protected primary port 443 and privileged ports", () => {
|
|
expect(() => buildExposeArgv(BIN, 443)).toThrow(/443/);
|
|
expect(() => buildRemoveArgv(BIN, 443)).toThrow(/443/);
|
|
expect(() => buildExposeArgv(BIN, 80)).toThrow(/privileged/);
|
|
expect(() => buildExposeArgv(BIN, 1023)).toThrow(/privileged/);
|
|
});
|
|
|
|
it("refuses non-canonical ports (string, float, overflow)", () => {
|
|
expect(() => buildExposeArgv(BIN, "42010" as unknown as number)).toThrow();
|
|
expect(() => buildExposeArgv(BIN, 42010.5)).toThrow();
|
|
expect(() => buildExposeArgv(BIN, 70000)).toThrow();
|
|
});
|
|
|
|
it("refuses a non-absolute or shell-metacharacter binary path", () => {
|
|
expect(() => buildStatusArgv("tailscale")).toThrow(/absolute/);
|
|
expect(() => buildStatusArgv("/usr/bin/tailscale; rm -rf /")).toThrow();
|
|
expect(() => buildStatusArgv("/usr/bin/tail scale")).toThrow();
|
|
});
|
|
});
|