PaperClipAI/server/src/services/chat-task-url.test.ts

import { afterEach, describe, expect, it, vi } from "vitest";
import { readConfigFile } from "../config-file.js";
import { publicChatTaskUrl, safeChatTaskUrl } from "./chat-task-url.js";
import { safeMilestoneText } from "./chat-run-publications.js";
import { runtimeCanonicalOrigin } from "./cloud-runtime-identity.js";
import { publicChatInteractionTaskUrl } from "./chat-interaction-publications.js";

vi.mock("../config-file.js", () => ({
  readConfigFile: vi.fn(() => null),
}));

vi.mock("./cloud-runtime-identity.js", () => ({
  runtimeCanonicalOrigin: vi.fn(() => null),
}));

afterEach(() => {
  vi.mocked(runtimeCanonicalOrigin).mockReturnValue(null);
  vi.unstubAllEnvs();
  vi.mocked(readConfigFile).mockReturnValue(null);
});

describe("external Paperclip task links", () => {
  it("resolves a newly claimed Cloud origin at use time ahead of pool configuration", () => {
    vi.stubEnv("PAPERCLIP_AUTH_PUBLIC_BASE_URL", "https://pool.example");
    expect(publicChatTaskUrl("issue-1")).toBe("https://pool.example/issues/issue-1");
    vi.mocked(runtimeCanonicalOrigin).mockReturnValue("https://vanity.example");
    expect(publicChatTaskUrl("issue-1")).toBe("https://vanity.example/issues/issue-1");
    expect(publicChatInteractionTaskUrl("issue-1")).toBe("https://vanity.example/issues/issue-1");
  });

  it("uses only the safe board origin and canonical issue path", () => {
    expect(
      safeChatTaskUrl(
        "https://board.example/path?secret=ignored#fragment",
        "issue-1",
      ),
    ).toBe("https://board.example/issues/issue-1");
    expect(safeChatTaskUrl("https://board.example", "a/b?c")).toBe(
      "https://board.example/issues/a%2Fb%3Fc",
    );
  });

  it.each([
    undefined,
    null,
    "",
    "not a URL",
    "http://board.example",
    "http://127.0.0.1:3103",
    "https://localhost",
    "https://10.0.0.1",
    "https://board.internal",
    "https://user:secret@board.example",
  ])(
    "omits unsafe or private board links before generating recovery copy (%s)",
    (baseUrl) => {
      expect(safeChatTaskUrl(baseUrl, "issue-1")).toBeNull();
      expect(
        safeMilestoneText({
          agentName: "Maya",
          milestone: "failed",
          issueId: "issue-1",
          publicBaseUrl: baseUrl,
        }),
      ).toBe(
        "Maya stopped before completing this turn. Open the task in Paperclip for details.",
      );
    },
  );

  it("does not use webhook ingress as the question or confirmation destination", () => {
    for (const name of [
      "PAPERCLIP_PUBLIC_URL",
      "PAPERCLIP_AUTH_PUBLIC_BASE_URL",
      "BETTER_AUTH_URL",
      "BETTER_AUTH_BASE_URL",
      "PAPERCLIP_MANAGED_RUNTIME_PUBLIC_URL",
    ])
      vi.stubEnv(name, "");
    vi.stubEnv("PAPERCLIP_CHAT_WEBHOOK_PUBLIC_URL", "https://ingress.example");
    expect(publicChatInteractionTaskUrl("issue-1")).toBeNull();
    vi.stubEnv("PAPERCLIP_PUBLIC_URL", "http://127.0.0.1:3103");
    expect(publicChatInteractionTaskUrl("issue-1")).toBeNull();
    vi.stubEnv("PAPERCLIP_PUBLIC_URL", "https://board.example");
    expect(publicChatInteractionTaskUrl("issue-1")).toBe(
      "https://board.example/issues/issue-1",
    );
    vi.stubEnv("PAPERCLIP_AUTH_PUBLIC_BASE_URL", "https://canonical.example");
    expect(publicChatInteractionTaskUrl("issue-1")).toBe(
      "https://canonical.example/issues/issue-1",
    );
  });

  it("uses the configured board origin ahead of the managed-runtime fallback", () => {
    for (const name of [
      "PAPERCLIP_PUBLIC_URL",
      "PAPERCLIP_AUTH_PUBLIC_BASE_URL",
      "BETTER_AUTH_URL",
      "BETTER_AUTH_BASE_URL",
    ])
      vi.stubEnv(name, "");
    vi.stubEnv(
      "PAPERCLIP_MANAGED_RUNTIME_PUBLIC_URL",
      "https://managed.example",
    );
    vi.mocked(readConfigFile).mockReturnValue({
      auth: { publicBaseUrl: "https://configured.example" },
    } as ReturnType<typeof readConfigFile>);

    expect(publicChatInteractionTaskUrl("issue-1")).toBe(
      "https://configured.example/issues/issue-1",
    );

    vi.stubEnv("PAPERCLIP_PUBLIC_URL", "https://environment.example");
    expect(publicChatInteractionTaskUrl("issue-1")).toBe(
      "https://environment.example/issues/issue-1",
    );
  });
});