mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-11-09 07:10:34 +01:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work > - The server has about 1,100 test and helper files in `server/src/__tests__` > - `server/tsconfig.json` excludes that directory, Vitest does not check types, and no script runs the tsconfig in that directory > - So a test can call a function with the wrong arguments and still pass, and no tool reports it > - This gap hid 2,168 real type errors, and some of them hid tests that did not test what they claim > - This pull request fixes all of these errors and adds the directory to the server layers from paperclipai/paperclip#18737 > - The benefit is that a type error in a server test now fails the typecheck, with no baseline and no backlog ## Linked Issues or Issue Description Refs paperclipai/paperclip#18737, which is merged and added the server layers. Refs paperclipai/paperclip#18738, which is merged and checks the test projects outside `pnpm -r`, so it is not a duplicate. Refs paperclipai/paperclip#18137, which records that this directory has no check. **What happened?** No tool checked the types of 1,074 of the 1,101 files in `server/src/__tests__`. I searched `package.json`, the workflows, and all tsconfig files. 27 files are in the program of another tsconfig, and these 27 have 0 errors. 11 of the 27 are in `helpers/maintenance/tsconfig.json`. No script ran that project when I measured this. paperclipai/paperclip#18738 now runs it. **Expected behavior** The server typecheck checks these files, and a type error fails the check. **Steps to reproduce** 1. On the base commit, run `tsc -p server/src/__tests__/tsconfig.json --noEmit`. It reports 6,536 errors and needs 12.3 GiB. 2. Add a type error to any file in `server/src/__tests__`. 3. Run `pnpm --filter @paperclipai/server typecheck`. It passes. **Paperclip version or commit** I measured the error breakdown below on commit `8dfd632452`, with TypeScript 7.0.2. The branch now includes master up to paperclipai/paperclip#18865. **Deployment mode** Not applicable. This issue applies to development and CI. No production source file in the server changes. ### Error breakdown Each row adds one change to the row above. | Step | Total errors | Change | Cause | | --- | --- | --- | --- | | Config as committed | 6,536 | | | | Add `src/types/*.d.ts` | 4,447 | -2,089 | Config. The Express request types were missing. | | Set `rootDir` to the repository root | 2,436 | -2,011 | Config. | | Set `allowImportingTsExtensions` | 2,181 | -255 | Config. Vitest accepts `.ts` imports. | | Add `ES2024.Promise` to `lib` | 2,138 | -43 | Config. Node 24 has `Promise.withResolvers`. | | Set `allowJs` for `.mjs` imports | 2,148 | +10 | Config. It removes 8 `TS7016` errors and shows new real errors. | | Set `declaration` to false | 2,142 | -6 | Config. Tests emit nothing. | | Count only files in `server/src` | 2,058 | -84 | Other packages: 53 Daytona, 29 Runner test, 2 UI. | So 4,478 of the 6,536 errors (69%) came from config or scope, and 2,058 are real type errors in 314 files. The 29 Runner test errors are also real, which gives 2,087 errors. Tests that master added after this measurement had 81 more errors, so this pull request fixes 2,168 errors. This table classifies the first 2,058 errors. | Kind of real error | Errors | | --- | --- | | Wrong argument or assignment type | 1,023 | | Stale or partial fixture objects | 525 | | Property that the type does not have | 317 | | Missing narrowing of null or unknown | 101 | | Implicit any | 60 | | Missing name or module | 16 | | Other | 16 | ### What the type errors hid Most errors were stale fixtures and loose mocks. These errors hid real test problems, and this pull request fixes them: - **A test that never ran.** `instrumentation.test.ts` required `sdk-trace-base`, which is not installed. So 3 span tests were skipped. They now run and pass. - **Assertions that could not fail.** - `issue-thread-interactions-service` used a company ID as an issue ID. - `status-card-evaluation-work` compared `[]` with `[]` in a rollback check. - `slack-conversation-lifecycle` read `item.issueId`, which does not exist. - `email-channels` used a permission key that does not exist. - `heartbeat-project-env` imported `LOW_TRUST_REVIEW_PRESET`, which is not exported. The value was undefined. - **Postgres processes that did not stop.** 11 test files called `stop` on the test database helper. That method does not exist, and the helper method is `cleanup`. - **Arguments that the service ignored.** - `methodKey` is now `connectionMethodKey` in the Daytona, Unikraft, 1Password, and Railway tests. - 108 calls passed `"owner-user"` to a parameter that expects an options object. - 9 chat wizard fixtures passed `managementContext` as `source`, so they ran `existing_app` and not `manifest`. - 2 tests passed a `{ userId }` actor that the function ignores. - Inserts into `environments` passed a `companyId` column that the table does not have. - **Problems in tests that master added during this work.** - `sandbox-creation-operations` read `database.connectionString` when an external test database was set. In that mode `database` is undefined, so the fixture would stop with a TypeError. It now uses the external URL. - `idle-completed-history` set a Dot operation to `dispatched`. That is a Muse status, and the Dot type does not have it. The fixture now uses `admitted`, which is a real in-flight Dot status. ### Possible product problems, not changed These may be real problems in production code or types. I did not change them, because this pull request does not change production behavior: - `decisions-service` `service.create` does not validate the lenient `cancel_issue_tree` input. - `createConnection` ignores `input.connectionPurpose`. - The `createConnection` route schema default stores `{}` for `transportConfig`. - `prepareManagedAiRuntime` accepted the invalid value `mode: "connection"`. - `createBinding` accepts invalid `projectionClass` strings outside class 3. - `ensureManagedProjectWorkspace` forwards an untyped `repoRef` by spread. - `routineVariableSchema.label` is optional, but `RoutineVariable.label` is required. - `ToolRunContext.projectId` may be too strict. - `withdrawInteraction` reads `issue.status`, which its type omits. - `issueService.list` and `reconcileNativeFinalizations` omit fields that they return at runtime. - `createGitHubExternalObjectProvider` handles `tokenProvider: null`, but its type forbids this value. ## What Changed - Fixed the 2,168 type errors. The diff changes 322 test and helper files. - Corrected `server/src/__tests__/tsconfig.json`. Editors and the typecheck now read the same options and report the same errors. - Added three `test-tree` layers to `server/scripts/typecheck-layers.mjs`. They read the server layers as declarations, and any error fails them. A hash of the path selects the shard, so a new file does not move other files. - Added `server/scripts/typecheck-stubs/daytona-sdk.d.ts`. Server tests reach Daytona plugin source, and the root install does not have `@daytonaio/sdk`. - Changed two imports in `ui/src/lib/issue-execution-policy.ts` to use `.js` extensions, because server tests import this file. - Made `declarationsConfig` and `--declarations-only` skip the `test-tree` layers, because these layers emit nothing. Other projects read only the source layers. Added a test for this. - Updated `doc/DEVELOPING.md`. ## Verification Run these commands: ```sh pnpm --filter @paperclipai/server typecheck pnpm exec vitest run server/scripts/typecheck-layers.test.mjs ``` Results on macOS (arm64), Node 24, 16 cores. Each check ran after the merge of paperclipai/paperclip#18738 unless the row says otherwise: | Check | Commit | Result | | --- | --- | --- | | Server typecheck, `PAPERCLIP_TYPECHECK_LOW_MEMORY=1`, all 7 layers | `6e45a08573` | Exit 0, 0 errors, 62 seconds, peak 3.52 GiB | | `node scripts/typecheck-test-projects.mjs --low-memory` | `a3306bd13e` | Exit 0, 0 errors, 42 seconds, peak 3.25 GiB | | The same script with `--reuse-declarations` | `1b878aabc0` | Exit 0, 0 errors | | `typecheck-layers.test.mjs` and `live-recovery-work.test.ts` | `01db5634e4` | 90 passed. These include real compiler runs for a pass, a type error, and an invalid tsconfig. | | `tsconfig.declarations.json` after a full server typecheck | `0fb1e4fb0a` | It references only `below`, `cycle`, and `above`. No generated config names a `tsconfig.layers.json` file. | | Owned runtime test in `idle-completed-history` | `e8f2f448ac` | Passed, with the fix that master later replaced | | `idle-incoming-wake`, `plugin-idle-manager`, and the changed `chat-channels` test | `6e45a08573` | 30 passed | | Runner `native-execution.test.ts` | `eab4dcc1f4` | 114 passed | | The 19 server test files that changed since `eab4dcc1f4`, and `typecheck-layers.test.mjs` | `259737b700` | 4,275 of 4,277 passed. The 2 failures are in `chat-channels` and are in the list of 7 below. | The peak is the largest single process, from `/usr/bin/time -l`. Peaks for the server typecheck were between 3.42 GiB and 3.56 GiB across 8 runs. Peaks for the test projects were 3.25 GiB and 3.37 GiB across 2 runs. I did not measure a cgroup. **Runtime check of the fixes.** Types do not prove that a test still works. So I ran all 309 changed server test files, 11,929 tests, before the rebase onto paperclipai/paperclip#18737: | Result | Tests | Detail | | --- | --- | --- | | Passed | 11,913 | Includes the 2 tests and the 54 `dot-runner` tests that passed in a later run, as described below. | | Failed | 7 | The same 7 tests also fail on the commit before the fixes. | | Skipped | 9 | These tests have their own skip conditions: `sentry` 5, and 1 each in `bundled-plugin-registration`, `customer-success-cloud`, `onepassword-connection`, and `workspace-runtime-https-live-exercise`. | The 7 tests that fail with and without this change, on my machine: - 3 tests in `chat-channels` and `email-channels` stop with `ENOENT` on a `SKILL.md` file. The path is in the parent checkout, above the git worktree that I used, so I expect that the worktree is the cause. I did not prove this. - `workspace-instance-cleanup` compares `/private/var/...` with `/var/...`. This is a macOS symlink difference. - 2 tests in `git-reproducible-managed-checkouts` get `unknown_base_git_files` and expect `unpushed_managed_checkout`. I did not find the cause. - 1 more test in `chat-channels`, `materializes direct external-chat finals once`, gets `undefined`. I did not find the cause. CI is the check for these 7 tests. `ci / verify` passed on `eab4dcc1f4`. Failures during this work: - My fix to `agent-runtime-connector-access` changed an invalid permission key in the setup, but not in the assertion. The runtime check found this. I corrected the assertion, and the file passes. - `heartbeat-plugin-environment` failed one wait in the full run. It passed three times alone, so I think that load caused the failure. It can fail again under load. - `dot-runner` skipped all 54 tests in the full run because `cargo` was not on my `PATH`. It then passed 54 of 54 with the toolchain on the `PATH`. - My first `lib` value removed the default DOM types, and the error count went up by 375. I added the DOM libraries. - My Daytona stub with bare `any` left 48 errors, because generic helpers then inferred `unknown`. I added shapes that return promises. - One fix to `agent-secrets-routes` used `class_3_static_lease`, and the test failed. That class allows only specific paths. I reverted to `unclassified`. - `ci / General tests (server (8/12))` failed on `259737b700` because of the flaky port in `idle-completed-history`. paperclipai/paperclip#18853 fixed this test on master, so this pull request keeps that fix. **Audit of the diff.** I counted these patterns in added and removed lines, to find fixes that only hide an error: | Pattern | Added | Removed | | --- | --- | --- | | `@ts-ignore` | 0 | 0 | | `@ts-expect-error` | 0 | 1 | | `.skip` | 0 | 0 | | `as any` | 9 | 9 | | `: any` | 11 | 2 | | `as never` | 8 | 2 | | `as unknown as` | 35 | 4 | | `Promise<unknown>` | 16 | 5 | | `expect(` | 128 | 113 | No hunk removes more `expect(` calls than it adds. Three removals of test content were intentional, and I checked each one: - `muse-control` removed `signalToken`. Line 1012 already asserts that it is absent. - `merged-pr-confirmation-sweep` removed legacy aliases. Other tests cover them. - `heartbeat-workspace-branch-containment` removed a `finalize` branch that no test row can reach. Some partial fixtures stay unchecked through `as unknown as` and `Promise<unknown>`, mostly in `issue-agent-mutation-ownership-routes` and `issue-comment-reopen-routes`. **Accuracy of the check.** One program over the tree and the three shards reported the same errors at the same positions. Memory, as the peak of the largest process on one thread, was 3.93 GiB for one program and 2.43 GiB for the largest shard. I measured these two values before the fixes. Not run or not proven: - I did not run the full `pnpm test:run`, or a root `pnpm build`. I expect CI to run the full suites. - I did not run the 4 GiB container check, or the full `scripts/typecheck-low-memory.mjs`. The peaks above come from macOS, so they are not a Linux cgroup measurement. - I did not run the UI typecheck after the merges. - `workspace-runtime-https-live-exercise` is skipped, so its `cleanup` fix did not run. ## Risks - **A large diff in test files.** 328 files change. A pull request that edits the same tests can get merge conflicts. New tests on master can also add type errors before this merges. Any such error fails this check and needs a fix here. - **A higher cost for changes to source types.** A change to a type can add errors in test files that the author did not touch. The author must then fix them. This is the purpose of the check, but it is new work. - **Changed test behavior.** Some tests now run paths that they did not run before, such as the 9 chat wizard fixtures and the 3 span tests. They pass here, but they can be more sensitive to timing or to the environment. - **The Daytona stub can go stale.** The stub is written by hand. If the plugin uses a new SDK member, the typecheck reports an error until someone updates the stub. - **The release path.** `release-verify.yml` and `scripts/release.sh` run `pnpm -r typecheck`, so they now run this check. - **The tsconfig change.** The test transform reads `server/src/__tests__/tsconfig.json`. The options that I changed are for type checks, and the runs above passed. - **A gap that remains.** Tsconfigs in `packages/paperclip-runner` and in most sandbox provider plugins exclude `*.test.ts`. This check does not read most of those test files, so they can still drift. That work is separate from this pull request. > For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and discuss it in `#dev` before opening the PR. Feature PRs that overlap with planned core work may need to be redirected — check the roadmap first. See `CONTRIBUTING.md`. ## Model Used Anthropic Claude Opus 5.5 (`claude-opus-5-5`) through Claude Code, with reasoning, tool use, code execution, and subagents. The runtime does not show the context window size. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [ ] I have run tests locally and they pass (7 tests fail locally, with and without this change. See Verification.) - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [ ] All Paperclip CI gates are green - [ ] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
1217 lines
41 KiB
TypeScript
1217 lines
41 KiB
TypeScript
import { resolveExternalTestDatabaseUrl } from "./helpers/external-test-database.js";
|
|
import { randomUUID } from "node:crypto";
|
|
import { afterAll, afterEach, beforeAll, beforeEach, describe, expect, it, vi } from "vitest";
|
|
import { and, eq } from "drizzle-orm";
|
|
import {
|
|
applyPendingMigrations,
|
|
activityLog,
|
|
agentConfigRevisions,
|
|
agents,
|
|
agentWakeupRequests,
|
|
builtInManagedResources,
|
|
cases,
|
|
companies,
|
|
companySkillVersions,
|
|
companySkills,
|
|
companyMemberships,
|
|
createDb,
|
|
heartbeatRunEvents,
|
|
heartbeatRuns,
|
|
issues,
|
|
principalPermissionGrants,
|
|
routines,
|
|
routineTriggers,
|
|
} from "@paperclipai/db";
|
|
import {
|
|
getEmbeddedPostgresTestSupport,
|
|
startEmbeddedPostgresTestDatabase,
|
|
} from "./helpers/embedded-postgres.js";
|
|
// Observe the Cloud lifecycle doorbell without any network: the real
|
|
// implementation is env-gated (a no-op off Cloud), so these tests assert
|
|
// WHEN the service rings it, not what the ring does.
|
|
const notifyCloudSpy = vi.hoisted(() => vi.fn(async () => {}));
|
|
vi.mock("../services/cloud-lifecycle-sync.js", () => ({
|
|
isCloudPinnedPrimaryCompany: () => false,
|
|
notifyCloudOfPrimaryCompanyLifecycleChange: notifyCloudSpy,
|
|
}));
|
|
|
|
import { startAgentLifecycle } from "../services/agent-lifecycle.js";
|
|
import { createLifecycleDriver } from "../services/agent-lifecycle-driver.js";
|
|
import { reserveRunBudget } from "../services/budget-reservations.js";
|
|
import { companyService } from "../services/companies.js";
|
|
import { deriveIssuePrefixBase } from "../services/issue-prefix.js";
|
|
import { readBuiltInAgentMarker } from "../lib/built-in-agent-metadata.js";
|
|
import { builtInAgentService, reconcileBuiltInAgentsOnStartup } from "../services/built-in-agents.js";
|
|
|
|
const externalUrl = resolveExternalTestDatabaseUrl("PAPERCLIP_COMPANIES_TEST_DATABASE_URL");
|
|
const embeddedPostgresSupport = externalUrl ? { supported: true, reason: undefined } : await getEmbeddedPostgresTestSupport();
|
|
const describeEmbeddedPostgres = embeddedPostgresSupport.supported ? describe : describe.skip;
|
|
|
|
if (!embeddedPostgresSupport.supported) {
|
|
console.warn(
|
|
`Skipping embedded Postgres company service tests on this host: ${embeddedPostgresSupport.reason ?? "unsupported environment"}`,
|
|
);
|
|
}
|
|
|
|
describeEmbeddedPostgres("companyService", () => {
|
|
let db!: ReturnType<typeof createDb>;
|
|
let lifecycleWorker: ReturnType<typeof startAgentLifecycle>;
|
|
beforeEach(() => {
|
|
lifecycleWorker = startAgentLifecycle(db, { ...createLifecycleDriver(db, {} as never),
|
|
requiredPluginIds: async () => [], runPlugin: async () => "complete" }, () => true);
|
|
});
|
|
const lifecycleStateFor = (status: typeof agents.$inferInsert["status"]): NonNullable<typeof agents.$inferInsert["lifecycleState"]> =>
|
|
status === "paused" || status === "pending_approval" || status === "terminated" ? status : "ready";
|
|
async function insertAgents(input: typeof agents.$inferInsert | Array<typeof agents.$inferInsert>) {
|
|
const rows = Array.isArray(input) ? input : [input];
|
|
await db.insert(agents).values(rows.map(row => ({ ...row,
|
|
lifecycleState: lifecycleStateFor(row.status),
|
|
lifecycleHolds: row.status === "paused" ? [row.pauseReason ?? "manual"] : [],
|
|
})));
|
|
}
|
|
|
|
let tempDb: Awaited<ReturnType<typeof startEmbeddedPostgresTestDatabase>> | null = null;
|
|
|
|
beforeAll(async () => {
|
|
if (externalUrl) await applyPendingMigrations(externalUrl);
|
|
else tempDb = await startEmbeddedPostgresTestDatabase("paperclip-company-service-");
|
|
db = createDb(externalUrl ?? tempDb!.connectionString);
|
|
}, 20_000);
|
|
|
|
afterEach(async () => {
|
|
await lifecycleWorker.stop();
|
|
await db.delete(routineTriggers);
|
|
await db.delete(routines);
|
|
await db.delete(builtInManagedResources);
|
|
await db.delete(companySkillVersions);
|
|
await db.delete(companySkills);
|
|
await db.delete(heartbeatRunEvents);
|
|
await db.delete(heartbeatRuns);
|
|
await db.delete(agentWakeupRequests);
|
|
await db.delete(agentConfigRevisions);
|
|
await db.delete(activityLog);
|
|
await db.delete(agents);
|
|
await db.delete(principalPermissionGrants);
|
|
await db.delete(companyMemberships);
|
|
await db.delete(cases);
|
|
await db.delete(issues);
|
|
await db.delete(companies);
|
|
});
|
|
|
|
afterAll(async () => {
|
|
await db?.$client.end({ timeout: 1 });
|
|
await tempDb?.cleanup();
|
|
});
|
|
|
|
it("retries generated issue prefixes when Drizzle wraps the unique constraint error", async () => {
|
|
await db.insert(companies).values({
|
|
name: "Aron Existing",
|
|
issuePrefix: "ARO",
|
|
});
|
|
|
|
const created = await companyService(db).create({
|
|
name: "Aron & Sharon",
|
|
});
|
|
|
|
expect(created.issuePrefix).toBe("AROA");
|
|
|
|
const rows = await db.select({ issuePrefix: companies.issuePrefix }).from(companies);
|
|
expect(rows.map((row) => row.issuePrefix).sort()).toEqual(["ARO", "AROA"]);
|
|
});
|
|
|
|
it("leaves unrelated company-hold projection out of name edits", async () => {
|
|
const [company] = await db.insert(companies).values({ name: "Rename only", issuePrefix: "REN" }).returning();
|
|
const [agent] = await db.insert(agents).values({ companyId: company.id, name: "Unrelated agent",
|
|
status: "paused", lifecycleState: "paused", lifecycleHolds: ["manual", "company_paused"], pauseReason: "manual" }).returning();
|
|
await companyService(db).update(company.id, { description: "Updated description" });
|
|
expect((await db.select().from(agents).where(eq(agents.id, agent.id)))[0].lifecycleHolds)
|
|
.toEqual(["manual", "company_paused"]);
|
|
await lifecycleWorker.sweep();
|
|
expect((await db.select().from(agents).where(eq(agents.id, agent.id)))[0].lifecycleHolds).toEqual(["manual"]);
|
|
});
|
|
|
|
it("does not auto-provision bundled built-in agents for a freshly created company", async () => {
|
|
const created = await companyService(db).create({
|
|
name: "Fresh Company",
|
|
});
|
|
|
|
// A new company starts clean: the Reflection Coach and Summarizer are
|
|
// opt-in, not seeded by default for a new user.
|
|
const agentRows = await db.select().from(agents).where(eq(agents.companyId, created.id));
|
|
expect(agentRows.filter((row) => readBuiltInAgentMarker(row.metadata))).toHaveLength(0);
|
|
|
|
// Startup reconcile leaves a fresh company untouched — nothing is created.
|
|
await reconcileBuiltInAgentsOnStartup(db);
|
|
const afterReconcileRows = await db.select().from(agents).where(eq(agents.companyId, created.id));
|
|
expect(afterReconcileRows.filter((row) => readBuiltInAgentMarker(row.metadata))).toHaveLength(0);
|
|
|
|
// The Reflection Coach remains available to enable on demand, and enabling
|
|
// it materializes its bundled skill + paused routine.
|
|
const enabled = await builtInAgentService(db).ensure(created.id, "reflection-coach");
|
|
expect(enabled.agent).toMatchObject({
|
|
name: "Reflection Coach",
|
|
status: "paused",
|
|
budgetMonthlyCents: 0,
|
|
});
|
|
|
|
const [skill] = await db
|
|
.select()
|
|
.from(companySkills)
|
|
.where(and(
|
|
eq(companySkills.companyId, created.id),
|
|
eq(companySkills.key, "paperclipai/bundled/paperclip-operations/reflection-coach"),
|
|
));
|
|
expect(skill).toMatchObject({
|
|
slug: "reflection-coach",
|
|
});
|
|
|
|
const [routine] = await db
|
|
.select()
|
|
.from(routines)
|
|
.where(and(eq(routines.companyId, created.id), eq(routines.assigneeAgentId, enabled.agentId!)));
|
|
expect(routine).toMatchObject({
|
|
status: "paused",
|
|
assigneeAgentId: enabled.agentId,
|
|
originKind: "built_in_agent_bundle",
|
|
originId: "reflection-coach:recent-agent-reflection",
|
|
});
|
|
const [trigger] = await db.select().from(routineTriggers).where(eq(routineTriggers.routineId, routine!.id));
|
|
expect(trigger).toMatchObject({
|
|
kind: "schedule",
|
|
enabled: false,
|
|
});
|
|
});
|
|
|
|
it("archives companies by pausing runnable agents and cancelling active runs", async () => {
|
|
const companyId = randomUUID();
|
|
const runningAgentId = randomUUID();
|
|
const idleAgentId = randomUUID();
|
|
const errorAgentId = randomUUID();
|
|
const pausedAgentId = randomUUID();
|
|
const pendingAgentId = randomUUID();
|
|
const terminatedAgentId = randomUUID();
|
|
const wakeupRequestId = randomUUID();
|
|
const runId = randomUUID();
|
|
|
|
await db.insert(companies).values({
|
|
id: companyId,
|
|
name: "Archive Test Co",
|
|
issuePrefix: `T${companyId.replace(/-/g, "").slice(0, 6).toUpperCase()}`,
|
|
requireBoardApprovalForNewAgents: false,
|
|
});
|
|
|
|
await insertAgents([
|
|
{
|
|
id: runningAgentId,
|
|
companyId,
|
|
name: "Running Agent",
|
|
role: "engineer",
|
|
status: "running",
|
|
adapterType: "codex_local",
|
|
adapterConfig: {},
|
|
runtimeConfig: {},
|
|
permissions: {},
|
|
},
|
|
{
|
|
id: idleAgentId,
|
|
companyId,
|
|
name: "Idle Agent",
|
|
role: "engineer",
|
|
status: "idle",
|
|
adapterType: "codex_local",
|
|
adapterConfig: {},
|
|
runtimeConfig: {},
|
|
permissions: {},
|
|
},
|
|
{
|
|
id: errorAgentId,
|
|
companyId,
|
|
name: "Error Agent",
|
|
role: "engineer",
|
|
status: "error",
|
|
adapterType: "codex_local",
|
|
adapterConfig: {},
|
|
runtimeConfig: {},
|
|
permissions: {},
|
|
},
|
|
{
|
|
id: pausedAgentId,
|
|
companyId,
|
|
name: "Paused Agent",
|
|
role: "engineer",
|
|
status: "paused",
|
|
pauseReason: "manual",
|
|
pausedAt: new Date("2026-06-01T00:00:00Z"),
|
|
adapterType: "codex_local",
|
|
adapterConfig: {},
|
|
runtimeConfig: {},
|
|
permissions: {},
|
|
},
|
|
{
|
|
id: pendingAgentId,
|
|
companyId,
|
|
name: "Pending Agent",
|
|
role: "engineer",
|
|
status: "pending_approval",
|
|
adapterType: "codex_local",
|
|
adapterConfig: {},
|
|
runtimeConfig: {},
|
|
permissions: {},
|
|
},
|
|
{
|
|
id: terminatedAgentId,
|
|
companyId,
|
|
name: "Terminated Agent",
|
|
role: "engineer",
|
|
status: "terminated",
|
|
adapterType: "codex_local",
|
|
adapterConfig: {},
|
|
runtimeConfig: {},
|
|
permissions: {},
|
|
},
|
|
]);
|
|
|
|
await db.insert(agentWakeupRequests).values({
|
|
id: wakeupRequestId,
|
|
companyId,
|
|
agentId: runningAgentId,
|
|
source: "timer",
|
|
status: "queued",
|
|
});
|
|
|
|
await db.insert(heartbeatRuns).values({
|
|
id: runId,
|
|
companyId,
|
|
agentId: runningAgentId,
|
|
invocationSource: "timer",
|
|
status: "running",
|
|
wakeupRequestId,
|
|
});
|
|
|
|
const archived = await companyService(db).archive(companyId, {
|
|
actorType: "user",
|
|
actorId: "test-user",
|
|
agentId: null,
|
|
runId: null,
|
|
});
|
|
|
|
expect(archived?.status).toBe("archived");
|
|
// The request commits the admission block; stopping providers is owed work.
|
|
expect((await db.select().from(heartbeatRuns).where(eq(heartbeatRuns.id, runId)))[0].status).toBe("running");
|
|
expect(await lifecycleWorker.hasPending()).toBe(true);
|
|
await lifecycleWorker.sweep();
|
|
|
|
const archiveActivity = await db
|
|
.select({
|
|
actorType: activityLog.actorType,
|
|
actorId: activityLog.actorId,
|
|
details: activityLog.details,
|
|
})
|
|
.from(activityLog)
|
|
.where(and(
|
|
eq(activityLog.companyId, companyId),
|
|
eq(activityLog.action, "company.archived"),
|
|
));
|
|
expect(archiveActivity).toHaveLength(1);
|
|
expect(archiveActivity[0]).toMatchObject({
|
|
actorType: "user",
|
|
actorId: "test-user",
|
|
details: { agentsPauseRequested: 3, runsCancellationRequested: 1 },
|
|
});
|
|
|
|
const rows = await db
|
|
.select({
|
|
id: agents.id,
|
|
status: agents.status,
|
|
pauseReason: agents.pauseReason,
|
|
})
|
|
.from(agents);
|
|
|
|
const byId = new Map(rows.map((row) => [row.id, row]));
|
|
expect(byId.get(runningAgentId)).toMatchObject({ status: "paused", pauseReason: "company_archived" });
|
|
expect(byId.get(idleAgentId)).toMatchObject({ status: "paused", pauseReason: "company_archived" });
|
|
expect(byId.get(errorAgentId)).toMatchObject({ status: "paused", pauseReason: "company_archived" });
|
|
expect(byId.get(pausedAgentId)).toMatchObject({ status: "paused", pauseReason: "manual" });
|
|
expect(byId.get(pendingAgentId)).toMatchObject({ status: "pending_approval", pauseReason: null });
|
|
expect(byId.get(terminatedAgentId)).toMatchObject({ status: "terminated", pauseReason: null });
|
|
|
|
const run = await db
|
|
.select({
|
|
status: heartbeatRuns.status,
|
|
error: heartbeatRuns.error,
|
|
})
|
|
.from(heartbeatRuns)
|
|
.then((result) => result[0] ?? null);
|
|
expect(run).toMatchObject({
|
|
status: "cancelled",
|
|
error: "Cancelled because the company was archived",
|
|
});
|
|
|
|
const wakeup = await db
|
|
.select({
|
|
status: agentWakeupRequests.status,
|
|
error: agentWakeupRequests.error,
|
|
})
|
|
.from(agentWakeupRequests)
|
|
.then((result) => result[0] ?? null);
|
|
expect(wakeup).toMatchObject({
|
|
status: "cancelled",
|
|
error: "Cancelled because the company was archived",
|
|
});
|
|
});
|
|
|
|
it.each(["archive", "pause"] as const)("preserves owed stops across immediate %s and reactivation", async action => {
|
|
const companyId = randomUUID();
|
|
const agentId = randomUUID();
|
|
await db.insert(companies).values({ id: companyId, name: "Rapid lifecycle", issuePrefix: `R${companyId.slice(0, 6)}` });
|
|
await insertAgents({ id: agentId, companyId, name: "Running target", adapterType: "process", status: "running" });
|
|
const [original] = await db.insert(heartbeatRuns).values({ companyId, agentId, status: "running", invocationSource: "on_demand" }).returning();
|
|
const service = companyService(db);
|
|
if (action === "archive") await service.archive(companyId);
|
|
else await service.update(companyId, { status: "paused" });
|
|
expect((await db.select().from(agents).where(eq(agents.id, agentId)))[0]).toMatchObject({ lifecycleState: "pausing", status: "paused" });
|
|
expect((await db.select().from(heartbeatRuns).where(eq(heartbeatRuns.id, original.id)))[0].status).toBe("running");
|
|
await service.update(companyId, { status: "active" });
|
|
const [waiting] = await db.insert(heartbeatRuns).values({ companyId, agentId, status: "queued", invocationSource: "on_demand" }).returning();
|
|
await expect(reserveRunBudget(db, companyId, waiting.id, null)).rejects.toThrow(/paused|not ready/);
|
|
await lifecycleWorker.sweep();
|
|
expect((await db.select().from(heartbeatRuns).where(eq(heartbeatRuns.id, original.id)))[0].status).toBe("cancelled");
|
|
expect((await db.select().from(agents).where(eq(agents.id, agentId)))[0]).toMatchObject({ lifecycleState: "ready", status: "idle" });
|
|
const [fresh] = await db.insert(heartbeatRuns).values({ companyId, agentId, status: "queued", invocationSource: "on_demand" }).returning();
|
|
await expect(reserveRunBudget(db, companyId, fresh.id, null)).resolves.toMatchObject({ runId: fresh.id, reused: false });
|
|
});
|
|
|
|
it("reactivates only agents paused because the company was archived", async () => {
|
|
const companyId = randomUUID();
|
|
const archivedPausedAgentId = randomUUID();
|
|
const manualPausedAgentId = randomUUID();
|
|
const pendingAgentId = randomUUID();
|
|
|
|
await db.insert(companies).values({
|
|
id: companyId,
|
|
name: "Reactivate Test Co",
|
|
status: "archived",
|
|
issuePrefix: `T${companyId.replace(/-/g, "").slice(0, 6).toUpperCase()}`,
|
|
requireBoardApprovalForNewAgents: false,
|
|
});
|
|
|
|
await insertAgents([
|
|
{
|
|
id: archivedPausedAgentId,
|
|
companyId,
|
|
name: "Archived Paused Agent",
|
|
role: "engineer",
|
|
status: "paused",
|
|
pauseReason: "company_archived",
|
|
pausedAt: new Date("2026-06-01T00:00:00Z"),
|
|
adapterType: "codex_local",
|
|
adapterConfig: {},
|
|
runtimeConfig: {},
|
|
permissions: {},
|
|
},
|
|
{
|
|
id: manualPausedAgentId,
|
|
companyId,
|
|
name: "Manual Paused Agent",
|
|
role: "engineer",
|
|
status: "paused",
|
|
pauseReason: "manual",
|
|
pausedAt: new Date("2026-06-01T00:00:00Z"),
|
|
adapterType: "codex_local",
|
|
adapterConfig: {},
|
|
runtimeConfig: {},
|
|
permissions: {},
|
|
},
|
|
{
|
|
id: pendingAgentId,
|
|
companyId,
|
|
name: "Pending Approval Agent",
|
|
role: "engineer",
|
|
status: "pending_approval",
|
|
adapterType: "codex_local",
|
|
adapterConfig: {},
|
|
runtimeConfig: {},
|
|
permissions: {},
|
|
},
|
|
]);
|
|
|
|
const reactivated = await companyService(db).update(
|
|
companyId,
|
|
{ status: "active" },
|
|
{ actorType: "user", actorId: "test-user", agentId: null, runId: null },
|
|
);
|
|
|
|
expect(reactivated?.status).toBe("active");
|
|
await lifecycleWorker.sweep();
|
|
|
|
const reactivateActivity = await db
|
|
.select({
|
|
actorType: activityLog.actorType,
|
|
actorId: activityLog.actorId,
|
|
details: activityLog.details,
|
|
})
|
|
.from(activityLog)
|
|
.where(and(
|
|
eq(activityLog.companyId, companyId),
|
|
eq(activityLog.action, "company.reactivated"),
|
|
));
|
|
expect(reactivateActivity).toHaveLength(1);
|
|
expect(reactivateActivity[0]).toMatchObject({
|
|
actorType: "user",
|
|
actorId: "test-user",
|
|
details: { agentsRestored: 1 },
|
|
});
|
|
|
|
const rows = await db
|
|
.select({
|
|
id: agents.id,
|
|
status: agents.status,
|
|
pauseReason: agents.pauseReason,
|
|
pausedAt: agents.pausedAt,
|
|
})
|
|
.from(agents);
|
|
|
|
const byId = new Map(rows.map((row) => [row.id, row]));
|
|
expect(byId.get(archivedPausedAgentId)).toMatchObject({
|
|
status: "idle",
|
|
pauseReason: null,
|
|
pausedAt: null,
|
|
});
|
|
expect(byId.get(manualPausedAgentId)).toMatchObject({
|
|
status: "paused",
|
|
pauseReason: "manual",
|
|
});
|
|
expect(byId.get(pendingAgentId)).toMatchObject({
|
|
status: "pending_approval",
|
|
pauseReason: null,
|
|
});
|
|
});
|
|
|
|
it("runs the archive cascade when update() transitions a company to archived", async () => {
|
|
const companyId = randomUUID();
|
|
const runningAgentId = randomUUID();
|
|
const idleAgentId = randomUUID();
|
|
const pendingAgentId = randomUUID();
|
|
const wakeupRequestId = randomUUID();
|
|
const runId = randomUUID();
|
|
|
|
await db.insert(companies).values({
|
|
id: companyId,
|
|
name: "Update Archive Test Co",
|
|
issuePrefix: `T${companyId.replace(/-/g, "").slice(0, 6).toUpperCase()}`,
|
|
requireBoardApprovalForNewAgents: false,
|
|
});
|
|
|
|
await insertAgents([
|
|
{
|
|
id: runningAgentId,
|
|
companyId,
|
|
name: "Running Agent",
|
|
role: "engineer",
|
|
status: "running",
|
|
adapterType: "codex_local",
|
|
adapterConfig: {},
|
|
runtimeConfig: {},
|
|
permissions: {},
|
|
},
|
|
{
|
|
id: idleAgentId,
|
|
companyId,
|
|
name: "Idle Agent",
|
|
role: "engineer",
|
|
status: "idle",
|
|
adapterType: "codex_local",
|
|
adapterConfig: {},
|
|
runtimeConfig: {},
|
|
permissions: {},
|
|
},
|
|
{
|
|
id: pendingAgentId,
|
|
companyId,
|
|
name: "Pending Agent",
|
|
role: "engineer",
|
|
status: "pending_approval",
|
|
adapterType: "codex_local",
|
|
adapterConfig: {},
|
|
runtimeConfig: {},
|
|
permissions: {},
|
|
},
|
|
]);
|
|
|
|
await db.insert(agentWakeupRequests).values({
|
|
id: wakeupRequestId,
|
|
companyId,
|
|
agentId: runningAgentId,
|
|
source: "timer",
|
|
status: "queued",
|
|
});
|
|
|
|
await db.insert(heartbeatRuns).values({
|
|
id: runId,
|
|
companyId,
|
|
agentId: runningAgentId,
|
|
invocationSource: "timer",
|
|
status: "running",
|
|
wakeupRequestId,
|
|
});
|
|
|
|
const archived = await companyService(db).update(
|
|
companyId,
|
|
{ status: "archived" },
|
|
{ actorType: "user", actorId: "test-user", agentId: null, runId: null },
|
|
);
|
|
|
|
expect(archived?.status).toBe("archived");
|
|
await lifecycleWorker.sweep();
|
|
|
|
const rows = await db
|
|
.select({ id: agents.id, status: agents.status, pauseReason: agents.pauseReason })
|
|
.from(agents);
|
|
const byId = new Map(rows.map((row) => [row.id, row]));
|
|
expect(byId.get(runningAgentId)).toMatchObject({ status: "paused", pauseReason: "company_archived" });
|
|
expect(byId.get(idleAgentId)).toMatchObject({ status: "paused", pauseReason: "company_archived" });
|
|
expect(byId.get(pendingAgentId)).toMatchObject({ status: "pending_approval", pauseReason: null });
|
|
|
|
const run = await db
|
|
.select({ status: heartbeatRuns.status, error: heartbeatRuns.error })
|
|
.from(heartbeatRuns)
|
|
.then((result) => result[0] ?? null);
|
|
expect(run).toMatchObject({
|
|
status: "cancelled",
|
|
error: "Cancelled because the company was archived",
|
|
});
|
|
|
|
const archiveActivity = await db
|
|
.select({
|
|
actorType: activityLog.actorType,
|
|
actorId: activityLog.actorId,
|
|
details: activityLog.details,
|
|
})
|
|
.from(activityLog)
|
|
.where(and(
|
|
eq(activityLog.companyId, companyId),
|
|
eq(activityLog.action, "company.archived"),
|
|
));
|
|
expect(archiveActivity).toHaveLength(1);
|
|
expect(archiveActivity[0]).toMatchObject({
|
|
actorType: "user",
|
|
actorId: "test-user",
|
|
details: { agentsPauseRequested: 2, runsCancellationRequested: 1 },
|
|
});
|
|
});
|
|
|
|
it("reactivates company_archived agents even when going via paused state (archived → paused → active)", async () => {
|
|
const companyId = randomUUID();
|
|
const archivedPausedAgentId = randomUUID();
|
|
const manualPausedAgentId = randomUUID();
|
|
|
|
await db.insert(companies).values({
|
|
id: companyId,
|
|
name: "Indirect Reactivate Test Co",
|
|
status: "paused",
|
|
issuePrefix: `T${companyId.replace(/-/g, "").slice(0, 6).toUpperCase()}`,
|
|
requireBoardApprovalForNewAgents: false,
|
|
});
|
|
|
|
await insertAgents([
|
|
{
|
|
id: archivedPausedAgentId,
|
|
companyId,
|
|
name: "Archived Paused Agent",
|
|
role: "engineer",
|
|
status: "paused",
|
|
pauseReason: "company_archived",
|
|
pausedAt: new Date("2026-06-01T00:00:00Z"),
|
|
adapterType: "codex_local",
|
|
adapterConfig: {},
|
|
runtimeConfig: {},
|
|
permissions: {},
|
|
},
|
|
{
|
|
id: manualPausedAgentId,
|
|
companyId,
|
|
name: "Manual Paused Agent",
|
|
role: "engineer",
|
|
status: "paused",
|
|
pauseReason: "manual",
|
|
pausedAt: new Date("2026-06-01T00:00:00Z"),
|
|
adapterType: "codex_local",
|
|
adapterConfig: {},
|
|
runtimeConfig: {},
|
|
permissions: {},
|
|
},
|
|
]);
|
|
|
|
const reactivated = await companyService(db).update(
|
|
companyId,
|
|
{ status: "active" },
|
|
{ actorType: "user", actorId: "test-user", agentId: null, runId: null },
|
|
);
|
|
|
|
expect(reactivated?.status).toBe("active");
|
|
await lifecycleWorker.sweep();
|
|
|
|
const rows = await db
|
|
.select({ id: agents.id, status: agents.status, pauseReason: agents.pauseReason })
|
|
.from(agents);
|
|
const byId = new Map(rows.map((row) => [row.id, row]));
|
|
expect(byId.get(archivedPausedAgentId)).toMatchObject({ status: "idle", pauseReason: null });
|
|
expect(byId.get(manualPausedAgentId)).toMatchObject({ status: "paused", pauseReason: "manual" });
|
|
|
|
const reactivateActivity = await db
|
|
.select({ details: activityLog.details })
|
|
.from(activityLog)
|
|
.where(and(
|
|
eq(activityLog.companyId, companyId),
|
|
eq(activityLog.action, "company.reactivated"),
|
|
));
|
|
expect(reactivateActivity).toHaveLength(1);
|
|
expect(reactivateActivity[0]).toMatchObject({ details: { agentsRestored: 1 } });
|
|
});
|
|
|
|
it("emits company.reactivated for archived → active even when no agents need restoring", async () => {
|
|
const companyId = randomUUID();
|
|
const terminatedAgentId = randomUUID();
|
|
|
|
await db.insert(companies).values({
|
|
id: companyId,
|
|
name: "Empty Reactivate Co",
|
|
status: "archived",
|
|
issuePrefix: `T${companyId.replace(/-/g, "").slice(0, 6).toUpperCase()}`,
|
|
requireBoardApprovalForNewAgents: false,
|
|
});
|
|
|
|
await insertAgents({
|
|
id: terminatedAgentId,
|
|
companyId,
|
|
name: "Terminated Agent",
|
|
role: "engineer",
|
|
status: "terminated",
|
|
adapterType: "codex_local",
|
|
adapterConfig: {},
|
|
runtimeConfig: {},
|
|
permissions: {},
|
|
});
|
|
|
|
const reactivated = await companyService(db).update(
|
|
companyId,
|
|
{ status: "active" },
|
|
{ actorType: "user", actorId: "test-user", agentId: null, runId: null },
|
|
);
|
|
|
|
expect(reactivated?.status).toBe("active");
|
|
|
|
const reactivateActivity = await db
|
|
.select({ details: activityLog.details })
|
|
.from(activityLog)
|
|
.where(and(
|
|
eq(activityLog.companyId, companyId),
|
|
eq(activityLog.action, "company.reactivated"),
|
|
));
|
|
expect(reactivateActivity).toHaveLength(1);
|
|
expect(reactivateActivity[0]).toMatchObject({ details: { agentsRestored: 0 } });
|
|
});
|
|
|
|
it("does not emit company.reactivated when paused → active restores no archive-paused agents", async () => {
|
|
const companyId = randomUUID();
|
|
const manualPausedAgentId = randomUUID();
|
|
|
|
await db.insert(companies).values({
|
|
id: companyId,
|
|
name: "Plain Unpause Co",
|
|
status: "paused",
|
|
issuePrefix: `T${companyId.replace(/-/g, "").slice(0, 6).toUpperCase()}`,
|
|
requireBoardApprovalForNewAgents: false,
|
|
});
|
|
|
|
await insertAgents({
|
|
id: manualPausedAgentId,
|
|
companyId,
|
|
name: "Manual Paused Agent",
|
|
role: "engineer",
|
|
status: "paused",
|
|
pauseReason: "manual",
|
|
pausedAt: new Date("2026-06-01T00:00:00Z"),
|
|
adapterType: "codex_local",
|
|
adapterConfig: {},
|
|
runtimeConfig: {},
|
|
permissions: {},
|
|
});
|
|
|
|
const reactivated = await companyService(db).update(
|
|
companyId,
|
|
{ status: "active" },
|
|
{ actorType: "user", actorId: "test-user", agentId: null, runId: null },
|
|
);
|
|
|
|
expect(reactivated?.status).toBe("active");
|
|
|
|
const reactivateActivity = await db
|
|
.select({ id: activityLog.id })
|
|
.from(activityLog)
|
|
.where(and(
|
|
eq(activityLog.companyId, companyId),
|
|
eq(activityLog.action, "company.reactivated"),
|
|
));
|
|
expect(reactivateActivity).toHaveLength(0);
|
|
|
|
const agent = await db
|
|
.select({ status: agents.status, pauseReason: agents.pauseReason })
|
|
.from(agents)
|
|
.then((rows) => rows[0] ?? null);
|
|
expect(agent).toMatchObject({ status: "paused", pauseReason: "manual" });
|
|
});
|
|
|
|
it("cancels orphan queued wakeup requests with no runId during archive", async () => {
|
|
const companyId = randomUUID();
|
|
const agentId = randomUUID();
|
|
const orphanWakeupId = randomUUID();
|
|
const runWakeupId = randomUUID();
|
|
const runId = randomUUID();
|
|
|
|
await db.insert(companies).values({
|
|
id: companyId,
|
|
name: "Orphan Wakeup Co",
|
|
issuePrefix: `T${companyId.replace(/-/g, "").slice(0, 6).toUpperCase()}`,
|
|
requireBoardApprovalForNewAgents: false,
|
|
});
|
|
|
|
await insertAgents({
|
|
id: agentId,
|
|
companyId,
|
|
name: "Idle Agent",
|
|
role: "engineer",
|
|
status: "idle",
|
|
adapterType: "codex_local",
|
|
adapterConfig: {},
|
|
runtimeConfig: {},
|
|
permissions: {},
|
|
});
|
|
|
|
await db.insert(agentWakeupRequests).values([
|
|
{
|
|
id: orphanWakeupId,
|
|
companyId,
|
|
agentId,
|
|
source: "automation",
|
|
status: "queued",
|
|
},
|
|
{
|
|
id: runWakeupId,
|
|
companyId,
|
|
agentId,
|
|
source: "timer",
|
|
status: "queued",
|
|
},
|
|
]);
|
|
|
|
await db.insert(heartbeatRuns).values({
|
|
id: runId,
|
|
companyId,
|
|
agentId,
|
|
invocationSource: "timer",
|
|
status: "running",
|
|
wakeupRequestId: runWakeupId,
|
|
});
|
|
|
|
const archived = await companyService(db).archive(companyId, {
|
|
actorType: "user",
|
|
actorId: "test-user",
|
|
agentId: null,
|
|
runId: null,
|
|
});
|
|
expect(archived?.status).toBe("archived");
|
|
await lifecycleWorker.sweep();
|
|
|
|
const wakeups = await db
|
|
.select({
|
|
id: agentWakeupRequests.id,
|
|
status: agentWakeupRequests.status,
|
|
error: agentWakeupRequests.error,
|
|
})
|
|
.from(agentWakeupRequests);
|
|
const byId = new Map(wakeups.map((row) => [row.id, row]));
|
|
expect(byId.get(orphanWakeupId)).toMatchObject({
|
|
status: "cancelled",
|
|
error: "Cancelled because the company was archived",
|
|
});
|
|
expect(byId.get(runWakeupId)).toMatchObject({
|
|
status: "cancelled",
|
|
error: "Cancelled because the company was archived",
|
|
});
|
|
});
|
|
|
|
it("archive() is idempotent — re-archiving emits no second cascade or activity entry", async () => {
|
|
const companyId = randomUUID();
|
|
const agentId = randomUUID();
|
|
|
|
await db.insert(companies).values({
|
|
id: companyId,
|
|
name: "Idempotent Archive Test Co",
|
|
issuePrefix: `T${companyId.replace(/-/g, "").slice(0, 6).toUpperCase()}`,
|
|
requireBoardApprovalForNewAgents: false,
|
|
});
|
|
|
|
await insertAgents({
|
|
id: agentId,
|
|
companyId,
|
|
name: "Idle Agent",
|
|
role: "engineer",
|
|
status: "idle",
|
|
adapterType: "codex_local",
|
|
adapterConfig: {},
|
|
runtimeConfig: {},
|
|
permissions: {},
|
|
});
|
|
|
|
const actor = { actorType: "user" as const, actorId: "test-user", agentId: null, runId: null };
|
|
const first = await companyService(db).archive(companyId, actor);
|
|
expect(first?.status).toBe("archived");
|
|
|
|
const second = await companyService(db).archive(companyId, actor);
|
|
expect(second?.status).toBe("archived");
|
|
|
|
const archiveActivity = await db
|
|
.select({ details: activityLog.details })
|
|
.from(activityLog)
|
|
.where(and(
|
|
eq(activityLog.companyId, companyId),
|
|
eq(activityLog.action, "company.archived"),
|
|
));
|
|
expect(archiveActivity).toHaveLength(1);
|
|
expect(archiveActivity[0]).toMatchObject({ details: { agentsPauseRequested: 1, runsCancellationRequested: 0 } });
|
|
});
|
|
|
|
it("rings the Cloud lifecycle doorbell exactly on archived-boundary transitions", async () => {
|
|
notifyCloudSpy.mockClear();
|
|
const companyId = randomUUID();
|
|
await db.insert(companies).values({
|
|
id: companyId,
|
|
name: "Doorbell Test Co",
|
|
issuePrefix: `T${companyId.replace(/-/g, "").slice(0, 6).toUpperCase()}`,
|
|
requireBoardApprovalForNewAgents: false,
|
|
});
|
|
const svc = companyService(db);
|
|
const actor = { actorType: "user" as const, actorId: "test-user", agentId: null, runId: null };
|
|
|
|
// A plain edit never rings.
|
|
await svc.update(companyId, { name: "Doorbell Test Co (renamed)" }, actor);
|
|
expect(notifyCloudSpy).not.toHaveBeenCalled();
|
|
|
|
// archive() rings once; re-archiving (no transition) does not.
|
|
await svc.archive(companyId, actor);
|
|
expect(notifyCloudSpy).toHaveBeenCalledTimes(1);
|
|
expect(notifyCloudSpy).toHaveBeenLastCalledWith(companyId);
|
|
await svc.archive(companyId, actor);
|
|
expect(notifyCloudSpy).toHaveBeenCalledTimes(1);
|
|
|
|
// Unarchiving through update() rings again.
|
|
await svc.update(companyId, { status: "active" }, actor);
|
|
expect(notifyCloudSpy).toHaveBeenCalledTimes(2);
|
|
|
|
// update() into archived rings too (the status-patch archive path).
|
|
await svc.update(companyId, { status: "archived" }, actor);
|
|
expect(notifyCloudSpy).toHaveBeenCalledTimes(3);
|
|
});
|
|
|
|
it("runs the archive cascade when update() transitions a paused company to archived", async () => {
|
|
const companyId = randomUUID();
|
|
const idleAgentId = randomUUID();
|
|
const runId = randomUUID();
|
|
|
|
await db.insert(companies).values({
|
|
id: companyId,
|
|
name: "Paused To Archived Test Co",
|
|
status: "paused",
|
|
issuePrefix: `T${companyId.replace(/-/g, "").slice(0, 6).toUpperCase()}`,
|
|
requireBoardApprovalForNewAgents: false,
|
|
});
|
|
|
|
await insertAgents({
|
|
id: idleAgentId,
|
|
companyId,
|
|
name: "Idle Agent",
|
|
role: "engineer",
|
|
status: "idle",
|
|
adapterType: "codex_local",
|
|
adapterConfig: {},
|
|
runtimeConfig: {},
|
|
permissions: {},
|
|
});
|
|
|
|
await db.insert(heartbeatRuns).values({
|
|
id: runId,
|
|
companyId,
|
|
agentId: idleAgentId,
|
|
invocationSource: "timer",
|
|
status: "queued",
|
|
});
|
|
|
|
const archived = await companyService(db).update(
|
|
companyId,
|
|
{ status: "archived" },
|
|
{ actorType: "user", actorId: "test-user", agentId: null, runId: null },
|
|
);
|
|
|
|
expect(archived?.status).toBe("archived");
|
|
await lifecycleWorker.sweep();
|
|
|
|
const agent = await db
|
|
.select({ status: agents.status, pauseReason: agents.pauseReason })
|
|
.from(agents)
|
|
.then((rows) => rows[0] ?? null);
|
|
expect(agent).toMatchObject({ status: "paused", pauseReason: "company_archived" });
|
|
|
|
const run = await db
|
|
.select({ status: heartbeatRuns.status })
|
|
.from(heartbeatRuns)
|
|
.then((rows) => rows[0] ?? null);
|
|
expect(run?.status).toBe("cancelled");
|
|
|
|
const archiveActivity = await db
|
|
.select({ details: activityLog.details })
|
|
.from(activityLog)
|
|
.where(and(
|
|
eq(activityLog.companyId, companyId),
|
|
eq(activityLog.action, "company.archived"),
|
|
));
|
|
expect(archiveActivity).toHaveLength(1);
|
|
expect(archiveActivity[0]).toMatchObject({
|
|
details: { agentsPauseRequested: 1, runsCancellationRequested: 1 },
|
|
});
|
|
});
|
|
|
|
it("getById returns null (not a query error) for non-UUID refs", async () => {
|
|
const svc = companyService(db);
|
|
await expect(svc.getById("tumbly-haus-creative")).resolves.toBeNull();
|
|
await expect(svc.getById("not-a-uuid")).resolves.toBeNull();
|
|
await expect(svc.getById("")).resolves.toBeNull();
|
|
});
|
|
|
|
describe("issue prefix re-derivation on rename", () => {
|
|
const TEST_ACTOR = {
|
|
actorType: "user" as const,
|
|
actorId: "test-user",
|
|
agentId: null,
|
|
runId: null,
|
|
};
|
|
|
|
beforeEach(() => {
|
|
// The tenant server token is the managed-instance signal the prefix
|
|
// re-derivation gates on.
|
|
process.env.PAPERCLIP_CLOUD_TENANT_SERVER_TOKEN = "test-server-token";
|
|
});
|
|
|
|
afterEach(() => {
|
|
delete process.env.PAPERCLIP_CLOUD_TENANT_SERVER_TOKEN;
|
|
});
|
|
|
|
async function seedCompanyWithWork(name: string, issuePrefix: string) {
|
|
const [company] = await db
|
|
.insert(companies)
|
|
.values({ name, issuePrefix })
|
|
.returning({ id: companies.id });
|
|
const companyId = company!.id;
|
|
await db.insert(issues).values([
|
|
{ companyId, title: "First", issueNumber: 1, identifier: `${issuePrefix}-1` },
|
|
{ companyId, title: "Second", issueNumber: 12, identifier: `${issuePrefix}-12` },
|
|
// A pre-identifier issue must survive the re-key untouched.
|
|
{ companyId, title: "Unnumbered", issueNumber: null, identifier: null },
|
|
]);
|
|
await db.insert(cases).values({
|
|
companyId,
|
|
caseNumber: 3,
|
|
identifier: `${issuePrefix}-C3`,
|
|
caseType: "decision",
|
|
title: "A case",
|
|
});
|
|
return companyId;
|
|
}
|
|
|
|
// Nulls last, so an issue that never got an identifier stays visible in
|
|
// the assertion instead of sorting unpredictably.
|
|
function sortIdentifiers(values: (string | null)[]) {
|
|
return [...values].sort((a, b) => {
|
|
if (a === null) return b === null ? 0 : 1;
|
|
if (b === null) return -1;
|
|
return a.localeCompare(b);
|
|
});
|
|
}
|
|
|
|
async function readIdentifiers(companyId: string) {
|
|
const issueRows = await db
|
|
.select({ identifier: issues.identifier })
|
|
.from(issues)
|
|
.where(eq(issues.companyId, companyId));
|
|
const caseRows = await db
|
|
.select({ identifier: cases.identifier })
|
|
.from(cases)
|
|
.where(eq(cases.companyId, companyId));
|
|
return {
|
|
issues: sortIdentifiers(issueRows.map((row) => row.identifier)),
|
|
cases: sortIdentifiers(caseRows.map((row) => row.identifier)),
|
|
};
|
|
}
|
|
|
|
it("re-derives the prefix and re-keys both identifier tables on a managed instance", async () => {
|
|
const companyId = await seedCompanyWithWork("Acme Robotics", "ACM");
|
|
|
|
const updated = await companyService(db).update(
|
|
companyId,
|
|
{ name: "Northwind Traders" },
|
|
TEST_ACTOR,
|
|
);
|
|
|
|
expect(updated).toMatchObject({ name: "Northwind Traders", issuePrefix: "NOR" });
|
|
await expect(readIdentifiers(companyId)).resolves.toEqual({
|
|
issues: ["NOR-1", "NOR-12", null],
|
|
cases: ["NOR-C3"],
|
|
});
|
|
|
|
const logged = await db
|
|
.select({ details: activityLog.details })
|
|
.from(activityLog)
|
|
.where(and(
|
|
eq(activityLog.companyId, companyId),
|
|
eq(activityLog.action, "company.updated"),
|
|
));
|
|
expect(logged).toHaveLength(1);
|
|
expect(logged[0]).toMatchObject({
|
|
details: {
|
|
source: "company_rename",
|
|
reason: "issue_prefix_rederived",
|
|
previousIssuePrefix: "ACM",
|
|
issuePrefix: "NOR",
|
|
issuesRekeyed: 2,
|
|
casesRekeyed: 1,
|
|
},
|
|
});
|
|
});
|
|
|
|
it("suffixes the candidate when another company already holds the derived base", async () => {
|
|
await db.insert(companies).values({ name: "Northwind Holdings", issuePrefix: "NOR" });
|
|
const companyId = await seedCompanyWithWork("Acme Robotics", "ACM");
|
|
|
|
const updated = await companyService(db).update(
|
|
companyId,
|
|
{ name: "Northwind Traders" },
|
|
TEST_ACTOR,
|
|
);
|
|
|
|
expect(updated?.issuePrefix).toBe("NORA");
|
|
await expect(readIdentifiers(companyId)).resolves.toEqual({
|
|
issues: ["NORA-1", "NORA-12", null],
|
|
cases: ["NORA-C3"],
|
|
});
|
|
});
|
|
|
|
it("keeps the prefix when the rename derives the same base", async () => {
|
|
const companyId = await seedCompanyWithWork("Acme Robotics", "ACMA");
|
|
|
|
const updated = await companyService(db).update(
|
|
companyId,
|
|
{ name: "Acme Robotics International" },
|
|
TEST_ACTOR,
|
|
);
|
|
|
|
// The suffixed prefix is kept: the base did not move, so nothing needs
|
|
// to be re-keyed and no disambiguating suffix is lost.
|
|
expect(updated?.issuePrefix).toBe("ACMA");
|
|
await expect(readIdentifiers(companyId)).resolves.toEqual({
|
|
issues: ["ACMA-1", "ACMA-12", null],
|
|
cases: ["ACMA-C3"],
|
|
});
|
|
const logged = await db
|
|
.select({ id: activityLog.id })
|
|
.from(activityLog)
|
|
.where(eq(activityLog.companyId, companyId));
|
|
expect(logged).toHaveLength(0);
|
|
});
|
|
|
|
it("keeps identifiers and the company prefix together under concurrent renames", async () => {
|
|
const companyId = await seedCompanyWithWork("Acme Robotics", "ACM");
|
|
const svc = companyService(db);
|
|
|
|
// Both renames read the company before either commits. Without a row
|
|
// lock the loser re-keys from the prefix it read, finds nothing left to
|
|
// move, and strands the identifiers on the winner's prefix while the
|
|
// company row carries its own.
|
|
await Promise.all([
|
|
svc.update(companyId, { name: "Northwind Traders" }, TEST_ACTOR),
|
|
svc.update(companyId, { name: "Zenith Freight" }, TEST_ACTOR),
|
|
]);
|
|
|
|
const [company] = await db
|
|
.select({ issuePrefix: companies.issuePrefix })
|
|
.from(companies)
|
|
.where(eq(companies.id, companyId));
|
|
const prefix = company!.issuePrefix;
|
|
expect(["NOR", "ZEN"]).toContain(prefix);
|
|
await expect(readIdentifiers(companyId)).resolves.toEqual({
|
|
issues: [`${prefix}-1`, `${prefix}-12`, null],
|
|
cases: [`${prefix}-C3`],
|
|
});
|
|
});
|
|
|
|
it("keeps the prefix consistent when a stale form resubmits the old name during a rename", async () => {
|
|
const companyId = await seedCompanyWithWork("Acme Robotics", "ACM");
|
|
const svc = companyService(db);
|
|
|
|
// The second caller submits the name it loaded before the rename. Judged
|
|
// against its own stale read that name looks unchanged, so a pre-lock
|
|
// comparison would skip re-derivation and restore "Acme Robotics" on top
|
|
// of the rename's prefix.
|
|
await Promise.all([
|
|
svc.update(companyId, { name: "Northwind Traders" }, TEST_ACTOR),
|
|
svc.update(companyId, { name: "Acme Robotics" }, TEST_ACTOR),
|
|
]);
|
|
|
|
const [company] = await db
|
|
.select({ name: companies.name, issuePrefix: companies.issuePrefix })
|
|
.from(companies)
|
|
.where(eq(companies.id, companyId));
|
|
// Whichever update commits last, the prefix derives from the name that
|
|
// survived, and the identifiers sit on that prefix.
|
|
expect(company!.issuePrefix.startsWith(deriveIssuePrefixBase(company!.name))).toBe(true);
|
|
await expect(readIdentifiers(companyId)).resolves.toEqual({
|
|
issues: [`${company!.issuePrefix}-1`, `${company!.issuePrefix}-12`, null],
|
|
cases: [`${company!.issuePrefix}-C3`],
|
|
});
|
|
});
|
|
|
|
it("leaves the prefix alone when only non-name fields change", async () => {
|
|
const companyId = await seedCompanyWithWork("Acme Robotics", "ACM");
|
|
|
|
const updated = await companyService(db).update(
|
|
companyId,
|
|
{ description: "Now with rockets" },
|
|
TEST_ACTOR,
|
|
);
|
|
|
|
expect(updated?.issuePrefix).toBe("ACM");
|
|
await expect(readIdentifiers(companyId)).resolves.toEqual({
|
|
issues: ["ACM-1", "ACM-12", null],
|
|
cases: ["ACM-C3"],
|
|
});
|
|
});
|
|
|
|
it("never touches the prefix on a self-hosted instance", async () => {
|
|
delete process.env.PAPERCLIP_CLOUD_TENANT_SERVER_TOKEN;
|
|
const companyId = await seedCompanyWithWork("Acme Robotics", "ACM");
|
|
|
|
const updated = await companyService(db).update(
|
|
companyId,
|
|
{ name: "Northwind Traders" },
|
|
TEST_ACTOR,
|
|
);
|
|
|
|
expect(updated).toMatchObject({ name: "Northwind Traders", issuePrefix: "ACM" });
|
|
await expect(readIdentifiers(companyId)).resolves.toEqual({
|
|
issues: ["ACM-1", "ACM-12", null],
|
|
cases: ["ACM-C3"],
|
|
});
|
|
});
|
|
});
|
|
|
|
});
|