mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-13 04:02:28 +02:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work. > - Chat connections let people start and continue that work from Slack. > - Setup mixed app creation, credentials, URL verification, account linking, and testing on the same screens. > - People also needed a safe way to link their own Slack identity after the first operator finished setup. > - This pull request gives each step a clear place and keeps membership approval separate from identity linking. > - It also makes connection details easier to use and fixes misleading callback health behind HTTPS proxies. ## Linked Issues or Issue Description **Subsystem affected** Cross-cutting: chat routes and services, shared contracts, and the Apps board UI. **Problem or motivation** Slack onboarding made users find settings without enough guidance. A second user needed operator help to link their account. Activity stopped at 100 records, and TLS termination could mark working callbacks as stale. **Proposed solution** Use six setup steps with editable app names, a generated manifest, credential guidance, URL verification, account linking, and an optional message test. Send each Slack user a private, expiring confirmation link. Require company membership or an approved access request before linking. Add cursor pagination and tolerate the internal HTTP hop in callback diagnostics. **Roadmap alignment** This improves the existing connected-app surface and supports CEO Chat without changing the task-and-comments model. The maintainer requested and reviewed the flow during a live Slack test drive. **Additional context** Related work: #7, #3349, #13000, and #13620. Those cover broader chat capabilities, older webhook paths, or plugins. This PR improves the existing native connector's setup and account-linking flow. HTTPS documentation was published separately in paperclipai/paperclip-docs#128. ## What Changed - Split Slack onboarding into six clickable sidebar steps. Keep secondary and primary actions on one row. - Generate the Slack creation link and read-only manifest from editable app, bot, and command names. Add credential prefix validation and direct instructions. - Add live account-link status and an optional mention-based message test. - Add private, single-use Slack account invitations and membership access requests. Retain cloud authentication/bootstrap checks and enforce the chat rollout flag in all identity APIs. Default new Slack connections to linked users only. - Put Settings, Access, Conversations, and Activity in the sidebar. Simplify conversation rows and remove active header badges. - Add 25-item activity pages, stable timestamp/ID cursors, and replay safety across pages. Preserve the legacy array API for clients without pagination parameters. - Fix false callback warnings when HTTPS terminates at a proxy. Keep host, port, and path drift detection. - Document the setup flow, pagination, callback diagnostics, and shared wizard footer rule. ## Verification - Passed: `pnpm -r typecheck`, `pnpm build`, and `pnpm check:token-gates`. - Passed: focused Slack callback and pagination integration tests; UI clipboard, wizard, pagination, and activity tests; OpenAPI route tests. The final access-gate fix also passes 27 focused tests covering cloud authentication/bootstrap, nonmember invitations, token validity, and the server-enforced rollout flag. - Passed: all 1,002 chat integration tests, 6,356 UI tests, and all 11 provider browser scenarios (including mobile light/dark navigation). After rebase, the identity route, sidebar, and 25 clipboard tests pass. - The full local `pnpm test:run` was attempted. The first run found 14 Slack fixtures that needed explicit guest access; those are fixed and the complete chat suite passes. Unrelated embedded PostgreSQL startup/resource failures and timeouts prevented a clean full local run. All CI checks pass on `2d858b036`, including the full chat, server, workspace, build, typecheck, and browser suites. - Live test drive: Slack app creation, credential setup, URL verification, private account confirmation, mention messages, and thread replies. Verified the callback warning clears for the existing proxied connection. - Review: create a Slack connection, follow the six steps, link a second user's account, and browse older activity with Next and Previous. ## Risks - Identity invitations carry a temporary capability. Tokens are hashed, expire after 15 minutes, work once, and require explicit confirmation by a company member. Access requests do not grant membership. - New Slack connections reject unlinked people by default. Existing connection settings remain intact. - Activity is a live ledger. Updated action rows can move forward in time. Older pages do not poll. - Proxy tolerance affects health display only. Slack signature checks and proxy authentication settings remain unchanged. - No database migration or package-lock changes. ## Model Used OpenAI Codex, based on GPT-6, with reasoning, repository tools, code execution, and browser verification. The runtime does not expose an exact model build ID or context-window size. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass (targeted suites; full local-run limitations documented above) - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
73 lines
4.4 KiB
TypeScript
73 lines
4.4 KiB
TypeScript
// @vitest-environment jsdom
|
|
import { flushSync } from "react-dom";
|
|
import { createRoot, type Root } from "react-dom/client";
|
|
import { QueryClient, QueryClientProvider } from "@tanstack/react-query";
|
|
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
|
|
import { ChatIdentityConfirm } from "./ChatIdentityConfirm";
|
|
|
|
const mocks = vi.hoisted(() => ({
|
|
getSession: vi.fn(), previewIdentityLink: vi.fn(), confirmIdentityLink: vi.fn(),
|
|
requestIdentityAccess: vi.fn(), navigate: vi.fn(),
|
|
}));
|
|
vi.mock("@/api/chatEndpoints", () => ({ chatEndpointsApi: mocks }));
|
|
vi.mock("@/api/auth", () => ({ authApi: { getSession: mocks.getSession } }));
|
|
vi.mock("@/api/health", () => ({ healthApi: { get: async () => ({ deploymentMode: "authenticated" }) } }));
|
|
vi.mock("@/lib/router", () => ({
|
|
useSearchParams: () => [new URLSearchParams({ token: "synthetic-token-that-is-at-least-32-characters" })],
|
|
Navigate: (props: { to: string }) => { mocks.navigate(props.to); return null; },
|
|
}));
|
|
|
|
describe("self-service Slack identity confirmation", () => {
|
|
let container: HTMLDivElement;
|
|
let root: Root;
|
|
let client: QueryClient;
|
|
const identity = { provider: "slack", externalLabel: "Dotta", companyName: "Acme", botLabel: "CEO", selfService: true, canConfirm: true };
|
|
beforeEach(() => {
|
|
vi.resetAllMocks();
|
|
mocks.getSession.mockResolvedValue({ user: { id: "user-a", name: "Dotta" } });
|
|
mocks.previewIdentityLink.mockResolvedValue(identity);
|
|
mocks.confirmIdentityLink.mockResolvedValue({ ok: true });
|
|
mocks.requestIdentityAccess.mockResolvedValue({ status: "pending_approval" });
|
|
container = document.createElement("div"); document.body.append(container);
|
|
root = createRoot(container);
|
|
client = new QueryClient({ defaultOptions: { queries: { retry: false }, mutations: { retry: false } } });
|
|
});
|
|
afterEach(() => { flushSync(() => root.unmount()); client.clear(); container.remove(); });
|
|
const render = () => flushSync(() => root.render(<QueryClientProvider client={client}><ChatIdentityConfirm /></QueryClientProvider>));
|
|
const button = (text: string) => Array.from(container.querySelectorAll("button")).find((node) => node.textContent === text)!;
|
|
|
|
it("sends signed-out users to sign in with the confirmation route preserved", async () => {
|
|
mocks.getSession.mockResolvedValue(null); render();
|
|
await vi.waitFor(() => expect(mocks.navigate).toHaveBeenCalledWith(expect.stringContaining("/auth?next=%2Fchat-identity%2Fconfirm%3Ftoken%3D")));
|
|
expect(mocks.previewIdentityLink).not.toHaveBeenCalled();
|
|
});
|
|
it("requires an explicit identity confirmation from members", async () => {
|
|
render(); await vi.waitFor(() => expect(button("Confirm identity")).toBeTruthy());
|
|
expect(mocks.confirmIdentityLink).not.toHaveBeenCalled();
|
|
button("Confirm identity").click();
|
|
await vi.waitFor(() => expect(container.textContent).toContain("Identity linked"));
|
|
expect(container.textContent).toContain("current Paperclip permissions");
|
|
expect(container.querySelector('a')?.textContent).toBe("Return to Slack");
|
|
});
|
|
it("keeps other providers out of the Slack return flow", async () => {
|
|
mocks.previewIdentityLink.mockResolvedValue({ ...identity, provider: "github", selfService: false });
|
|
render(); await vi.waitFor(() => expect(button("Confirm identity")).toBeTruthy());
|
|
button("Confirm identity").click();
|
|
await vi.waitFor(() => expect(container.textContent).toContain("Identity linked"));
|
|
expect(container.querySelector('a[href="https://app.slack.com/"]')).toBeNull();
|
|
});
|
|
it("lets nonmembers request access without confirming the identity", async () => {
|
|
mocks.previewIdentityLink.mockResolvedValue({ ...identity, canConfirm: false });
|
|
render(); await vi.waitFor(() => expect(button("Request access")).toBeTruthy());
|
|
expect(button("Confirm identity")).toBeUndefined(); button("Request access").click();
|
|
await vi.waitFor(() => expect(container.textContent).toContain("Access requested"));
|
|
expect(mocks.confirmIdentityLink).not.toHaveBeenCalled();
|
|
expect(mocks.requestIdentityAccess).toHaveBeenCalledTimes(1);
|
|
});
|
|
it("does not allow requests using an expired or consumed link", async () => {
|
|
mocks.previewIdentityLink.mockRejectedValue(new Error("Expired")); render();
|
|
await vi.waitFor(() => expect(container.textContent).toContain("This identity link is unavailable"));
|
|
expect(container.querySelector("button")).toBeNull();
|
|
});
|
|
});
|