mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-11-22 11:54:35 +01:00
## Thinking Path > - Paperclip lets people manage agent work through the board. > - The board reads task, agent, settings, plugin, and run data from the server. > - A deploy can interrupt those reads after content is already visible. > - Local error branches can replace that content with an error or show raw codes. > - This pull request moves the remaining reads to the shared recovery behavior. > - The query-error guard prevents new local error patterns from returning. ## Linked Issues or Issue Description **What happened?** Loaded lists, settings, task panels, and manual reads could clear their content or show errors during a server restart. Some reads also disabled the shared retry policy. **Expected behavior** Keep loaded content during a temporary failure. Show the shared connection banner. Retry reads after recovery. Replace content after a real access denial or missing resource, with readable copy. **Steps to reproduce** Open a task, settings page, or run log. Return 503 with `tenant_app_unavailable` from the API. Restore the API and check that content refreshes. Repeat with 403 and 404 to check the failure state. Related merged work: Refs #15754, Refs #15772, Refs #17960. This change covers remaining reads and enforcement. Browser persistence and the outage browser suite follow separately. ## What Changed - Repair an existing PostgreSQL deadline fixture at UTC boundaries. A daily cap defers a heartbeat until both its original interval and the next UTC day allow it. Keep the counted run in its seeded day and cover noon, just before midnight and the first second after midnight with explicit clocks and real PostgreSQL. Production scheduling is unchanged. - Integrate the saved list, settings, shell, task, and manual-read recovery changes against current master. Preserve the current task, Inbox, and run-log structure. - Add `useResilientFetch` for component-local reads. Preserve loaded data, cancel stale requests, and retry through the shared connectivity policy. Keep browser and pairing capabilities in memory. - Retain run log chunks across stream changes and catch up after recovery without duplicate chunks or stalled requests. - Keep genuine authorization and missing-resource failures visible. Translate known single-word codes such as `forbidden`. Show known skills and disconnected-app failures before sibling loading states. Keep Retry bound to its failed request. - Make the query-error guard enforce by default and run it in the CI policy job. Document the narrow exceptions and the read recovery contract. - Invalidate pending OAuth discovery when the operator leaves setup or its context changes. Keep reserved-popup cleanup bound to the current attempt. ## Verification - Current read head `09d1db29dea` is merge-ready: all 59 check runs are completed (54 successful, three skipped, two neutral), the legacy Snyk status is successful, and both required `ci / verify` and `ci / e2e` gates pass. Greptile Apex reviewed this exact head at 5/5 with no unresolved threads; the branch has no merge conflicts. The current CI run is `41748339602`. - Current read head `09d1db29dea` includes master `683fa4725e9`. The latest change touches only the existing server deadline test fixture. Application source remains the previously verified `86376fa751e` revision: all 60 affected skills/disconnected-app tests and both application UI typechecks passed, along with token gates and the enforcing query-error guard. Those UI suites were not repeated for this test-only repair. - The fixture repair passes all seven deadline integration cases and the complete server typecheck, including the server test layer. The old assertion deterministically fails at 23:59:06.888 UTC; its one-second-old run also fails the first-second-of-day probe. The corrected fixture passes noon and both midnight probes. The permanent three-case coverage uses seeded 2099 clocks. - Twelve new regressions fail against the previous implementation. Both skills variants and disconnected-app pages show either request's 403 or 429 while the sibling pauses or remains fetching. Permission failures stay visible. Retry stays usable for its failed request and recovers independently. An initial test-fixture query-key typo was corrected before the passing run. The finding is replied to and resolved. Greptile reviewed prior application revision `86376fa751e` at 5/5 with no new actionable findings or unresolved threads. The current test-only head has now received its own Apex 5/5 review with no unresolved threads, and its CI is successful as recorded above. - The preceding OAuth fix passed all 237 setup tests on both application branches. Its ten regressions prove that Back, Cancel, unmount, or context changes retire initial discovery without creating a connection, caching old identities, navigating an abandoned popup, or closing a newer attempt. - Earlier master integration `e992f770339` passed all 309 tests across eight affected Slack, recovery, retry, submission and task files, plus UI typecheck, token gates, enforcing query-error scan and seven guard tests. The integration preserves Slack workspace reconnect and shared recovery, readable execution errors, source-inspection company scoping, and current submission behavior. Newly inherited retained-file recovery controls keep cached data through transient failures and hide it after definitive denial. - The preceding cache head `97c0bc3966f` passed 1,038 focused cache/write/editor/account/task/API tests. All 22 built-UI outage/write/loading cases passed in 4.7 minutes on exact browser head `b7deaaee5da`, with strict checking of all three specs. The latest skills/app rendering fix is covered by its affected component suites; those broader cases were not repeated for this separate read path. - Historical broader UI, CLI and build results and unresolved aggregate server/DB/adapter failures remain in the PR discussion. Interrupted CI runs were audited and recorded separately; they are not counted as passes. Controlled local outages do not prove hosted authentication or a real Cloud restart/deploy. Real hosted acceptance remains required after merge and deployment. Commands for the latest fix: ```sh pnpm --filter @paperclipai/ui exec vitest run src/pages/CompanySkills.test.tsx src/pages/apps/AppNotConnected.test.tsx pnpm --filter @paperclipai/ui typecheck pnpm check:token-gates node scripts/check-query-error-rendering.mjs --enforce --summary ``` ## Risks This migration touches many read surfaces. The main risks are initial loading, request cancellation, retained authorization state, and run-log paging. The tests cover those states. There are no server, schema, dependency, or API contract changes. The follow-up browser suite and hosted deploy acceptance are required before release acceptance. Recovered commits retain their original authors. If squash-merging, preserve `Co-Authored-By: Bender (Fable) <bender@agents.paperclip.ing>` and the Paperclip trailer. ## Model Used OpenAI `gpt-6.1-sol` through Codex, with xhigh reasoning effort, tool use, and code execution. The context window size is not exposed. Saved source commits keep their original authorship. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have described the issue in-PR following the bug report template - [x] I have not referenced internal/instance-local Paperclip issues or links - [x] My branch name describes the change and contains no internal ticket id - [x] The affected local tests pass; broader limitations are recorded above - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: devinfoley <139239+devinfoley@users.noreply.github.com> Co-authored-by: Paperclip <noreply@paperclip.ing> Co-authored-by: Bender (Fable) <bender@agents.paperclip.ing> Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
196 lines
16 KiB
TypeScript
196 lines
16 KiB
TypeScript
import { useQueryView } from "@/components/QueryView";
|
|
import { useEffect, useRef, useState } from "react";
|
|
import { useMutation, useQuery, useQueryClient } from "@tanstack/react-query";
|
|
import {
|
|
DEFAULT_AGENT_OBSERVABILITY_CAPTURE, updateAgentObservabilitySchema, isSameOtlpOrigin,
|
|
type AgentObservabilityCapture, type AgentObservabilitySettings, type AgentObservabilitySettingsResponse,
|
|
type AgentObservabilityTestReceipt, type UpdateAgentObservabilityRequest,
|
|
} from "@paperclipai/shared";
|
|
import { agentObservabilityApi } from "@/api/agent-observability";
|
|
import { ApiError } from "@/api/client";
|
|
import { Button } from "@/components/ui/button";
|
|
import { Input } from "@/components/ui/input";
|
|
import { Label } from "@/components/ui/label";
|
|
import { ToggleField } from "@/components/agent-config-primitives";
|
|
|
|
type HeaderDraft = { id: number; originalName: string | null; name: string; value: string };
|
|
const captureLabels: Array<{ key: keyof AgentObservabilityCapture; label: string }> = [
|
|
{ key: "userPrompts", label: "User prompts" },
|
|
{ key: "assistantResponses", label: "Assistant responses" },
|
|
{ key: "toolContent", label: "Tool output and content" },
|
|
{ key: "toolDetails", label: "Additional tool details (Claude Code)" },
|
|
];
|
|
export interface AgentObservabilitySettingsViewProps {
|
|
companyId: string;
|
|
settings: AgentObservabilitySettings | null;
|
|
canManage?: boolean;
|
|
saving?: boolean;
|
|
testing?: boolean;
|
|
removing?: boolean;
|
|
error?: string | null;
|
|
conflict?: boolean;
|
|
result?: AgentObservabilityTestReceipt | null;
|
|
/** Changes only after an explicit successful mutation, never a background refetch. */
|
|
resetKey?: number;
|
|
onSave: (input: UpdateAgentObservabilityRequest) => void;
|
|
onTest: () => void;
|
|
onRemove: () => void;
|
|
onReload?: () => void;
|
|
}
|
|
|
|
export function AgentObservabilitySettingsView(props: AgentObservabilitySettingsViewProps) {
|
|
const { companyId, settings, canManage = true, saving, testing, removing, error, conflict, onSave, onTest, onRemove, onReload } = props;
|
|
const [provider, setProvider] = useState<"braintrust" | "otlp">("braintrust");
|
|
const [projectId, setProjectId] = useState("");
|
|
const [endpoint, setEndpoint] = useState("");
|
|
const [enabled, setEnabled] = useState(false);
|
|
const [capture, setCapture] = useState<AgentObservabilityCapture>({ ...DEFAULT_AGENT_OBSERVABILITY_CAPTURE });
|
|
const [apiKey, setApiKey] = useState("");
|
|
const [replaceKey, setReplaceKey] = useState(false);
|
|
const [headers, setHeaders] = useState<HeaderDraft[]>([]);
|
|
const [validation, setValidation] = useState<string | null>(null);
|
|
const [applied, setApplied] = useState<AgentObservabilitySettings | null>(settings);
|
|
const nextHeader = useRef(0);
|
|
const revision = settings?.revision ?? null;
|
|
function reset() {
|
|
setApplied(settings);
|
|
setProvider(settings?.destination.provider ?? "braintrust");
|
|
setProjectId(settings?.destination.provider === "braintrust" ? settings.destination.projectId : "");
|
|
setEndpoint(settings?.destination.provider === "otlp" ? settings.destination.endpointBaseUrl : "");
|
|
setEnabled(settings?.enabled ?? false);
|
|
setCapture({ ...(settings?.capture ?? DEFAULT_AGENT_OBSERVABILITY_CAPTURE) });
|
|
setApiKey(""); setReplaceKey(false); setValidation(null);
|
|
setHeaders((settings?.destination.provider === "otlp" ? settings.headerNames : []).map(name => ({ id: nextHeader.current++, originalName: name, name, value: "" })));
|
|
}
|
|
const original = applied;
|
|
const headersChanged = provider === "otlp" && (headers.some(row => row.value || row.originalName !== row.name.toLowerCase())
|
|
|| JSON.stringify(headers.map(row => row.name.toLowerCase()).sort()) !== JSON.stringify(original?.destination.provider === "otlp" ? [...original.headerNames].sort() : []));
|
|
const dirty = !original || provider !== original.destination.provider || enabled !== original.enabled || replaceKey || Boolean(apiKey) || headersChanged
|
|
|| JSON.stringify(capture) !== JSON.stringify(original.capture)
|
|
|| (provider === "braintrust" ? projectId !== (original.destination.provider === "braintrust" ? original.destination.projectId : "")
|
|
: endpoint !== (original.destination.provider === "otlp" ? original.destination.endpointBaseUrl : ""));
|
|
// Explicit mutation success/company changes erase secrets. Background reads
|
|
// may update a clean form, but cannot overwrite an unsaved draft.
|
|
useEffect(() => { reset(); }, [companyId, props.resetKey]);
|
|
useEffect(() => { if (!dirty && !conflict) reset(); }, [revision]);
|
|
const hasConflict = Boolean(conflict || revision !== (original?.revision ?? null));
|
|
const requireFreshHeaders = provider === "otlp" && original?.destination.provider === "otlp"
|
|
&& original.headerNames.length > 0 && !isSameOtlpOrigin(original.destination, { provider: "otlp", endpointBaseUrl: endpoint });
|
|
const busy = saving || testing || removing;
|
|
const providerChanged = !original || original.destination.provider !== provider;
|
|
function save(overrideEnabled?: boolean) {
|
|
if (requireFreshHeaders && headers.some(row => !row.value)) {
|
|
setValidation("Re-enter every header value for the new endpoint, or remove the header."); return;
|
|
}
|
|
const common = { expectedRevision: original?.revision ?? null, enabled: overrideEnabled ?? enabled, capture };
|
|
const input = provider === "braintrust"
|
|
? { ...common, destination: { provider, projectId }, credentials: providerChanged || replaceKey || apiKey || (!original?.credentialsConfigured && common.enabled) ? { mode: "replace", apiKey } : { mode: "keep" } }
|
|
: { ...common, destination: { provider, endpointBaseUrl: endpoint }, credentials: providerChanged || headersChanged || requireFreshHeaders
|
|
? { mode: "replace", headers: headers.map(row => ({ name: row.name, ...(row.value ? { value: row.value } : {}) })) } : { mode: "keep" } };
|
|
const parsed = updateAgentObservabilitySchema.safeParse(input);
|
|
if (!parsed.success) { setValidation(parsed.error.issues[0]?.message ?? "Review the configuration."); return; }
|
|
setValidation(null); onSave(parsed.data);
|
|
}
|
|
const receipt = props.result?.revision === revision ? props.result : settings?.lastTest;
|
|
return <section aria-labelledby="agent-observability-heading" className="max-w-2xl space-y-4">
|
|
<div className="space-y-1">
|
|
<h2 id="agent-observability-heading" className="text-lg font-medium">Agent observability</h2>
|
|
<p className="text-sm text-muted-foreground">Send Codex, Claude Code and native OpenCode execution data to your observability service.</p>
|
|
</div>
|
|
{!canManage ? <p className="text-sm text-muted-foreground">Manage connections permission is required to configure agent observability.</p> : <>
|
|
<fieldset disabled={busy} className="space-y-4">
|
|
<div className="space-y-2">
|
|
<Label htmlFor="agent-observability-provider">Destination</Label>
|
|
<select id="agent-observability-provider" className="h-9 w-full rounded-md border border-input bg-background px-3 text-sm" value={provider}
|
|
onChange={event => { setProvider(event.target.value as "braintrust" | "otlp"); setApiKey(""); setReplaceKey(false); setValidation(null); }}>
|
|
<option value="braintrust">Braintrust</option><option value="otlp">Custom OTLP</option>
|
|
</select>
|
|
</div>
|
|
{provider === "braintrust" ? <>
|
|
<div className="space-y-2"><Label htmlFor="agent-observability-project">Project ID</Label>
|
|
<Input id="agent-observability-project" value={projectId} onChange={event => setProjectId(event.target.value)} placeholder="Braintrust project UUID" autoComplete="off" />
|
|
</div>
|
|
<div className="space-y-2">
|
|
<Label htmlFor="agent-observability-key">API key</Label>
|
|
{!providerChanged && original?.credentialsConfigured && !replaceKey ? <div className="flex items-center justify-between gap-3">
|
|
<span className="text-sm text-muted-foreground">API key configured</span><Button type="button" variant="outline" size="sm" onClick={() => setReplaceKey(true)}>Replace API key</Button>
|
|
</div> : <Input id="agent-observability-key" type="password" value={apiKey} onChange={event => setApiKey(event.target.value)} autoComplete="new-password" />}
|
|
</div>
|
|
</> : <>
|
|
<div className="space-y-2"><Label htmlFor="agent-observability-endpoint">OTLP base URL</Label>
|
|
<Input id="agent-observability-endpoint" value={endpoint} onChange={event => setEndpoint(event.target.value)} placeholder="https://collector.example.com" autoComplete="off" />
|
|
<p className="text-xs text-muted-foreground">Use the base URL without /v1/logs or /v1/traces. It must be reachable from each agent environment.</p>
|
|
</div>
|
|
<div className="space-y-2"><div className="flex items-center justify-between gap-3"><Label>Headers</Label>
|
|
<Button type="button" variant="outline" size="sm" disabled={headers.length >= 16} onClick={() => setHeaders(rows => [...rows, { id: nextHeader.current++, originalName: null, name: "", value: "" }])}>Add header</Button></div>
|
|
{headers.length === 0 && <p className="text-sm text-muted-foreground">No authentication headers.</p>}
|
|
{headers.map(row => <div key={row.id} className="flex flex-wrap items-center gap-2">
|
|
<Input className="min-w-0 flex-1" aria-label="Header name" value={row.name} onChange={event => setHeaders(rows => rows.map(item => item.id === row.id ? { ...item, name: event.target.value } : item))} autoComplete="off" />
|
|
<Input className="min-w-0 flex-1" aria-label={`Value for ${row.name || "header"}`} type="password" value={row.value} placeholder={row.originalName && !requireFreshHeaders ? "Keep saved value" : "Header value"}
|
|
onChange={event => setHeaders(rows => rows.map(item => item.id === row.id ? { ...item, value: event.target.value } : item))} autoComplete="new-password" />
|
|
<Button type="button" size="sm" variant="ghost" aria-label={`Remove ${row.name || "header"}`} onClick={() => setHeaders(rows => rows.filter(item => item.id !== row.id))}>Remove</Button>
|
|
</div>)}
|
|
</div>
|
|
</>}
|
|
<p className="text-xs text-muted-foreground">The agent harness receives these credentials. Use a key limited to telemetry ingestion.</p>
|
|
<ToggleField label="Enable export" checked={enabled} onChange={setEnabled} hint="Applies to executions that start preparation after saving." />
|
|
<details><summary className="cursor-pointer text-sm font-medium">Content capture</summary>
|
|
<div className="space-y-3 pt-3">{captureLabels.map(row => <ToggleField key={row.key} label={row.label} checked={capture[row.key]} onChange={value => setCapture(current => ({ ...current, [row.key]: value }))} />)}
|
|
<p className="text-xs text-muted-foreground">Native limits apply. Exported records can contain task content, including prompts and tool output. A collector can forward records to multiple services.</p>
|
|
</div>
|
|
</details>
|
|
</fieldset>
|
|
{(validation || error || hasConflict) && <p role="alert" className="text-sm text-destructive">{validation || error || "Another administrator changed these settings. Reload the saved settings to continue."}</p>}
|
|
{hasConflict && <Button type="button" size="sm" variant="outline" disabled={busy} onClick={() => { reset(); onReload?.(); }}>Reload saved settings</Button>}
|
|
{!dirty && receipt && <div role="status" className="space-y-1 text-sm">
|
|
<p className="font-medium">{receipt.status === "accepted" ? "Test payload accepted" : receipt.status === "partial" ? "Some test records were rejected" : "Test payload failed"}</p>
|
|
<p className="text-xs text-muted-foreground">{new Date(receipt.finishedAt).toLocaleString()} · Sent from the Paperclip server.</p>
|
|
{(["logs", "traces"] as const).map(signal => receipt.signals[signal].message && <p key={signal}>{signal === "logs" ? "Logs" : "Traces"}: {receipt.signals[signal].message}</p>)}
|
|
</div>}
|
|
<div className="flex items-center justify-between gap-3">
|
|
<Button type="button" variant="ghost" disabled={busy || !dirty} onClick={reset}>Cancel</Button>
|
|
<Button type="button" disabled={busy || !dirty || hasConflict} onClick={() => save()}>{saving ? "Saving…" : "Save changes"}</Button>
|
|
</div>
|
|
{dirty && settings && <p className="text-xs text-muted-foreground">Save changes before testing.</p>}
|
|
{settings && <div className="flex flex-wrap items-center gap-2">
|
|
<Button type="button" variant="outline" disabled={busy || dirty || hasConflict} onClick={onTest}>{testing ? "Testing…" : "Test saved settings"}</Button>
|
|
{settings.enabled && <Button type="button" size="sm" variant="ghost" disabled={busy || dirty || hasConflict} onClick={() => save(false)}>Disable export</Button>}
|
|
<Button type="button" size="sm" variant="ghost" disabled={busy || dirty || hasConflict} onClick={onRemove}>{removing ? "Removing…" : "Remove configuration"}</Button>
|
|
</div>}
|
|
</>}
|
|
</section>;
|
|
}
|
|
|
|
export function AgentObservabilitySettingsSection({ companyId }: { companyId: string }) {
|
|
return <AgentObservabilitySettingsContainer key={companyId} companyId={companyId} />;
|
|
}
|
|
function AgentObservabilitySettingsContainer({ companyId }: { companyId: string }) {
|
|
const client = useQueryClient();
|
|
const queryKey = ["agent-observability", companyId];
|
|
const query = useQuery({ queryKey, queryFn: () => agentObservabilityApi.settings(companyId) });
|
|
const queryView = useQueryView(query);
|
|
const [error, setError] = useState<string | null>(null);
|
|
const [conflict, setConflict] = useState(false);
|
|
const [resetKey, setResetKey] = useState(0);
|
|
const accept = (data: AgentObservabilitySettingsResponse) => { client.setQueryData(queryKey, data); setError(null); setConflict(false); setResetKey(value => value + 1); };
|
|
const reject = (cause: unknown) => {
|
|
const stale = cause instanceof ApiError && cause.status === 409;
|
|
setConflict(stale);
|
|
setError(stale ? "Another administrator changed these settings. Reload the saved settings to continue." : cause instanceof Error ? cause.message : "The observability settings could not be updated.");
|
|
};
|
|
const save = useMutation({ gcTime: 0, mutationFn: (input: UpdateAgentObservabilityRequest) => agentObservabilityApi.update(companyId, input), onSuccess: accept, onError: reject, onSettled: () => queueMicrotask(() => save.reset()) });
|
|
const remove = useMutation({ mutationFn: (revision: string) => agentObservabilityApi.remove(companyId, revision), onSuccess: accept, onError: reject });
|
|
const test = useMutation({ mutationFn: (revision: string) => agentObservabilityApi.test(companyId, revision), onSuccess: receipt => {
|
|
setError(null); client.setQueryData<AgentObservabilitySettingsResponse>(queryKey, current => current?.settings?.revision === receipt.revision
|
|
? { ...current, settings: { ...current.settings, lastTest: receipt } } : current);
|
|
}, onError: reject });
|
|
useEffect(() => { setError(null); setConflict(false); save.reset(); test.reset(); remove.reset(); }, [companyId]);
|
|
if (["loading", "reconnecting"].includes(queryView.kind)) return <p className="text-sm text-muted-foreground">Loading agent observability…</p>;
|
|
if (!query.data) return <div role="alert" className="space-y-2 text-sm"><p>Agent observability settings could not be loaded.</p><Button variant="outline" size="sm" onClick={() => void query.refetch()}>Retry</Button></div>;
|
|
return <AgentObservabilitySettingsView key={companyId} companyId={companyId} settings={query.data.settings} canManage={query.data.canManage}
|
|
saving={save.isPending} removing={remove.isPending} testing={test.isPending} error={error ?? ((queryView.kind === "error") ? "Saved settings could not be refreshed. Your draft is unchanged." : null)} conflict={conflict} resetKey={resetKey}
|
|
onSave={input => save.mutate(input)} onTest={() => { if (query.data.settings) test.mutate(query.data.settings.revision); }}
|
|
onRemove={() => { if (query.data.settings) remove.mutate(query.data.settings.revision); }}
|
|
onReload={() => { setConflict(false); setError(null); void query.refetch(); }} />;
|
|
}
|