mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-13 13:38:01 +02:00
## Thinking Path > - Paperclip is the open source control plane people use to coordinate AI agents, issues, approvals, comments, and work products. > - The involved subsystem is issue context: markdown links, issue properties, related work, lists, filters, inbox/sidebar status, and plugin-provided external context. > - The gap is that URLs to external systems currently remain mostly plain links, so humans and agents must manually open them to understand status, identity, and liveness. > - This matters because external work objects such as GitHub issues and pull requests are part of the operational state of a Paperclip company. > - The implementation keeps core provider-neutral: shared contracts, storage, sync, routes, and UI surfaces live in core while providers can contribute detection and status resolution. > - This pull request adds the external object reference foundation, GitHub provider support, issue-surface rendering, filters, sidebar/list/inbox signals, and test/story coverage. > - The benefit is that linked external work becomes inspectable Paperclip context without hardcoding every provider directly into the UI. ## Linked Issues or Issue Description No public GitHub issue exists for this work. Feature request: - Problem: URLs in Paperclip issues, comments, documents, and related surfaces do not expose provider status or object identity inline. - Proposed behavior: detect supported external object URLs, persist normalized references, refresh provider status, and render concise status-aware links across issue surfaces. - Users affected: board users, agents, and maintainers who triage issues containing external work links. - Acceptance: external object references are company-scoped, provider-extensible, visible in key issue surfaces, filterable where relevant, and covered by focused shared/server/UI tests. Related PR search: - No open duplicate PRs found for `external object references`. - Closed related prior attempt: #4556. ## What Changed - Added shared external-object contracts, validators, status/liveness helpers, and plugin protocol declarations. - Added database schema and additive migrations for external objects, source mentions, and display metadata. - Added server services/routes for detecting, syncing, summarizing, refreshing, and resolving external objects across issues, documents, comments, projects, and plugins. - Added a GitHub external-object provider plus plugin SDK authoring docs. - Wired UI presentation across markdown links, comments, issue chat, documents, properties, related work, issue rows, filters, inbox/sidebar badges, and Storybook stories. - Rebasing cleanup: moved the branch onto current `master`, repaired stale worktree provision config, hardened environment-sensitive tests/mocks, and removed committed screenshot artifacts from the PR branch to keep the reviewable file set below tool limits. ## Verification - `pnpm exec vitest run packages/shared/src/external-objects.test.ts server/src/__tests__/external-object-routes.test.ts server/src/__tests__/external-objects-service.test.ts ui/src/components/ExternalObjectPill.test.tsx ui/src/lib/external-objects.test.ts` passed after rebasing: 5 files, 56 tests. - Historical branch verification before this PR creation included `pnpm test:run`, `pnpm -r typecheck`, and `pnpm build`; this PR body does not claim those were rerun after the final rebase. ## Risks - Medium: this adds a new cross-surface sync path on issue/document/comment writes. The implementation uses safe sync wrappers so external-object failures warn instead of blocking core mutations. - Medium: the migrations introduce new tables and indexes. They are additive and company-scoped. - Medium: provider-specific URL parsing can miss or misclassify edge cases. Shared canonicalization tests and provider tests cover current GitHub shapes. - Low: UI badge/filter behavior could add visual noise for object-heavy issues; component tests and Storybook stories cover the intended surfaces. > Roadmap checked: `ROADMAP.md` references the plugin system as the current extension path and does not list a duplicate core feature. Related long-range docs discuss external references, work products, preview URLs, and plugin extension points; this PR implements the scoped external-object reference foundation. ## Model Used OpenAI Codex, GPT-5 coding-agent runtime, with shell and GitHub CLI tool use. Reasoning mode: medium. Exact deployed runtime model ID and context window were not exposed in the environment. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
78 lines
3.0 KiB
TypeScript
78 lines
3.0 KiB
TypeScript
import {
|
|
boolean,
|
|
index,
|
|
jsonb,
|
|
pgTable,
|
|
text,
|
|
timestamp,
|
|
uniqueIndex,
|
|
uuid,
|
|
} from "drizzle-orm/pg-core";
|
|
import type {
|
|
ExternalObjectLivenessState,
|
|
ExternalObjectStatusCategory,
|
|
ExternalObjectStatusTone,
|
|
} from "@paperclipai/shared";
|
|
import { companies } from "./companies.js";
|
|
import { plugins } from "./plugins.js";
|
|
|
|
export const externalObjects = pgTable(
|
|
"external_objects",
|
|
{
|
|
id: uuid("id").primaryKey().defaultRandom(),
|
|
companyId: uuid("company_id").notNull().references(() => companies.id, { onDelete: "cascade" }),
|
|
providerKey: text("provider_key").notNull(),
|
|
pluginId: uuid("plugin_id").references(() => plugins.id, { onDelete: "set null" }),
|
|
objectType: text("object_type").notNull(),
|
|
externalId: text("external_id").notNull(),
|
|
sanitizedCanonicalUrl: text("sanitized_canonical_url"),
|
|
canonicalIdentityHash: text("canonical_identity_hash"),
|
|
displayKey: text("display_key"),
|
|
iconKey: text("icon_key"),
|
|
displayTitle: text("display_title"),
|
|
statusKey: text("status_key"),
|
|
statusLabel: text("status_label"),
|
|
statusIconKey: text("status_icon_key"),
|
|
statusCategory: text("status_category").$type<ExternalObjectStatusCategory>().notNull().default("unknown"),
|
|
statusTone: text("status_tone").$type<ExternalObjectStatusTone>().notNull().default("neutral"),
|
|
liveness: text("liveness").$type<ExternalObjectLivenessState>().notNull().default("unknown"),
|
|
isTerminal: boolean("is_terminal").notNull().default(false),
|
|
data: jsonb("data").$type<Record<string, unknown>>().notNull().default({}),
|
|
remoteVersion: text("remote_version"),
|
|
etag: text("etag"),
|
|
lastResolvedAt: timestamp("last_resolved_at", { withTimezone: true }),
|
|
lastChangedAt: timestamp("last_changed_at", { withTimezone: true }),
|
|
lastErrorAt: timestamp("last_error_at", { withTimezone: true }),
|
|
nextRefreshAt: timestamp("next_refresh_at", { withTimezone: true }),
|
|
lastErrorCode: text("last_error_code"),
|
|
lastErrorMessage: text("last_error_message"),
|
|
createdAt: timestamp("created_at", { withTimezone: true }).notNull().defaultNow(),
|
|
updatedAt: timestamp("updated_at", { withTimezone: true }).notNull().defaultNow(),
|
|
},
|
|
(table) => ({
|
|
companyProviderObjectIdx: index("external_objects_company_provider_object_idx").on(
|
|
table.companyId,
|
|
table.providerKey,
|
|
table.objectType,
|
|
),
|
|
companyProviderStatusIdx: index("external_objects_company_provider_status_idx").on(
|
|
table.companyId,
|
|
table.providerKey,
|
|
table.statusCategory,
|
|
),
|
|
companyRefreshIdx: index("external_objects_company_refresh_idx").on(table.companyId, table.nextRefreshAt),
|
|
companyExternalIdUq: uniqueIndex("external_objects_company_external_id_uq").on(
|
|
table.companyId,
|
|
table.providerKey,
|
|
table.objectType,
|
|
table.externalId,
|
|
),
|
|
companyCanonicalIdentityUq: uniqueIndex("external_objects_company_identity_uq").on(
|
|
table.companyId,
|
|
table.providerKey,
|
|
table.objectType,
|
|
table.canonicalIdentityHash,
|
|
),
|
|
}),
|
|
);
|