mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-27 11:20:42 +01:00
TonioandClaude Opus 5
bc0b5a1642
The wizard defaults `adapterType` to `claude_local`, and a saved draft can name any adapter. The grid only renders adapters the server has enabled, so on an instance where the held adapter is disabled nothing appears selected while the wizard still holds it — and the first agent is hired on an adapter the deployer turned off, which can never acquire a lease. The selection now snaps to the first enabled, non-coming-soon adapter whenever the held one is not visible, and adapter-specific model defaults follow it. The snap waits for the adapter registry to load. External adapter types are registered into the UI registry only once the adapters query resolves, so before that a saved external adapter is indistinguishable from a disabled one — snapping on that transient list would replace the customer's choice with a built-in and the persist effect would write it down. This gate fails closed, unlike the fail-open gates in onboarding, because the directions of harm are opposite: acting early silently rewrites a saved answer, while waiting merely leaves the selection alone, which is the behaviour that existed before the snap did. The test file is named `OnboardingWizard.adapters.test.tsx` rather than `OnboardingWizard.test.tsx`, which is the name #11370 uses for its restore gate. Both merged cleanly onto master alone but collided with each other on add/add, and nothing in either status showed it. Lands the work from #9900's sibling, #9501, by @stubbi, whose commit is included unchanged with their authorship. The rename and the registry gate are mine. Tested: ui typecheck clean; 51 pass across the adapter, hook, dialog, config-form and wizard-step suites, including the other callers of the adapter hook since that module changed. All CI gates green; Greptile 5/5. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
88 lines
3.3 KiB
TypeScript
88 lines
3.3 KiB
TypeScript
import { useEffect, useMemo } from "react";
|
|
import { useQuery } from "@tanstack/react-query";
|
|
import { adaptersApi } from "@/api/adapters";
|
|
import { setDisabledAdapterTypes } from "@/adapters/disabled-store";
|
|
import { syncExternalAdapters } from "@/adapters/registry";
|
|
import { queryKeys } from "@/lib/queryKeys";
|
|
|
|
/**
|
|
* Fetch adapters and keep the disabled-adapter store + UI adapter registry
|
|
* in sync with the server.
|
|
*
|
|
* - Registers external adapter types in the UI registry so they appear in
|
|
* dropdowns (done eagerly during render — idempotent, no React state).
|
|
* - Syncs the disabled-adapter store for non-React consumers (useEffect).
|
|
*
|
|
* Returns a reactive Set of disabled types for use as useMemo dependencies.
|
|
* Call this at the top of any component that renders adapter menus.
|
|
*/
|
|
export function useDisabledAdaptersSync(options: { enabled?: boolean } = {}): Set<string> {
|
|
const enabled = options.enabled ?? true;
|
|
const { data: adapters } = useQuery({
|
|
queryKey: queryKeys.adapters.all,
|
|
queryFn: () => adaptersApi.list(),
|
|
enabled,
|
|
staleTime: 5 * 60 * 1000,
|
|
});
|
|
|
|
// Eagerly register external adapter types in the UI registry so that
|
|
// consumers calling listUIAdapters() in the same render cycle see them.
|
|
// This is idempotent — already-registered types are skipped.
|
|
if (adapters) {
|
|
syncExternalAdapters(
|
|
adapters
|
|
.filter((a) => a.source === "external")
|
|
.map((a) => ({
|
|
type: a.type,
|
|
label: a.label,
|
|
disabled: a.disabled,
|
|
overrideDisabled: a.overridePaused,
|
|
})),
|
|
);
|
|
}
|
|
|
|
// Sync the disabled set to the global store for non-React code
|
|
useEffect(() => {
|
|
if (!adapters) return;
|
|
setDisabledAdapterTypes(
|
|
adapters.filter((a) => a.disabled).map((a) => a.type),
|
|
);
|
|
}, [adapters]);
|
|
|
|
return useMemo(
|
|
() => new Set(adapters?.filter((a) => a.disabled).map((a) => a.type) ?? []),
|
|
[adapters],
|
|
);
|
|
}
|
|
|
|
/**
|
|
* Whether the adapter list has arrived, so callers can tell "this instance
|
|
* does not offer that adapter" from "the registry has not loaded yet".
|
|
*
|
|
* External adapter types are registered into the UI registry by
|
|
* {@link useDisabledAdaptersSync} only once the query resolves. Until then
|
|
* `listUIAdapters()` returns the built-ins alone, so an external adapter looks
|
|
* exactly like one the deployer has disabled.
|
|
*
|
|
* Deliberately reports arrival rather than settlement, unlike the fail-open
|
|
* gates elsewhere in onboarding. The directions of harm are opposite here. A
|
|
* caller that acts on an unloaded registry replaces the customer's chosen
|
|
* adapter with a built-in and persists that choice; a caller that waits
|
|
* forever simply leaves the selection alone, which is the behaviour that
|
|
* existed before any of this. Silently changing a saved answer is the error
|
|
* worth refusing to make.
|
|
*
|
|
* Reads the same query key as {@link useDisabledAdaptersSync}, so it shares
|
|
* that cache entry rather than adding a request.
|
|
*/
|
|
export function useAdapterRegistryLoaded(options: { enabled?: boolean } = {}): boolean {
|
|
const enabled = options.enabled ?? true;
|
|
const { data: adapters } = useQuery({
|
|
queryKey: queryKeys.adapters.all,
|
|
queryFn: () => adaptersApi.list(),
|
|
enabled,
|
|
staleTime: 5 * 60 * 1000,
|
|
});
|
|
return adapters !== undefined;
|
|
}
|