mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-11-14 00:26:28 +01:00
## Thinking Path > - Paperclip manages agent work and preserves its execution state. > - A server replacement must retain every workspace that depends on the old server disk. > - Runner task environments can own their workspace outside the Core server. > - These environments save an adapter-managed workspace with a runnerTaskWorkspaceOwner binding. > - Readiness and maintenance treated that provider path as a Core filesystem dependency. > - This change validates the saved owner and shares that classification between both paths. > - Local, malformed, and foreign workspace bindings still block enrollment. ## Linked Issues or Issue Description Related enrollment safeguards: #18835. A GitHub search found no duplicate fix for this provider-owned class. **What happened?** Volume-free readiness returned workspaces_require_migration for an adapter-managed Runner workspace owned by a plugin task environment. Maintenance also selected it and failed with workspace_provider_unsupported. The provider owned the path, which did not exist on the Core server. **Expected behavior** A valid provider-owned workspace does not require migration from the Core server disk. Ordinary local workspaces and invalid ownership bindings remain blockers. **Steps to reproduce** 1. Run a paperclip_runner agent in a plugin task environment. 2. Retain its adapter-managed workspace and complete runnerTaskWorkspaceOwner binding. 3. Read startup eligibility for volume-free enrollment. 4. Observe the workspace blocker before this fix. 5. Run workspace maintenance and observe workspace_provider_unsupported for the same row. **Paperclip version or commit** Reproduced on353945c86d. The regression also fails on the branch basea3b34a9d88. **Deployment mode** Docker with external PostgreSQL. Local regression coverage uses disposable PostgreSQL. ## What Changed - Share one metadata predicate between startup eligibility and offline workspace migration selection. - Validate a complete saved owner against a same-company paperclip_runner agent and a plugin environment with matching nonempty keys. Per-run environment overrides remain supported. - Keep ordinary local workspaces and invalid ownership bindings in the migration set. - Add real PostgreSQL coverage for provider-owned readiness, zero-import maintenance selection, unchanged retained rows, and local/foreign/malformed ownership controls. ## Verification - Readiness RED: the provider-owned fixture failed with workspaces_require_migration on unchanged source. - Maintenance RED: the provider-owned fixture failed with workspace_provider_unsupported before the shared selector was applied. - GREEN: 29 selected tests passed across three files. This covers 8 eligibility/configuration tests and 21 migration/offline-admission cases, including eleven invalid/local owner controls inside the eligibility test. The affected migration file has 207 cases; broad coverage remains with required CI. - Commands: `pnpm exec vitest run server/src/__tests__/ephemeral-server-data.test.ts server/src/__tests__/ephemeral-server-contract.test.ts` plus focused selections in `server/src/services/remote-workspace-migration.test.ts` for provider ownership, offline admission, local imports, interrupted-batch resume, and unresolved workspace semantics. - Server layered typecheck passed after the final source change. - Final head `2fb98dbc664da14e6f60d812e1e10877b2b7f00a`: [required CI](https://github.com/paperclipai/paperclip/actions/runs/42920262773) completed with 55 successful checks, 1 neutral review, and 4 intended skips. Greptile and Paperclip Review both rated this head 5/5. No unresolved review threads remain. - No hosted data migration or metadata rewrite was performed. ## Risks - This changes a readiness classification. Incomplete, foreign, non-Runner, or mismatched environment bindings remain conservative blockers. - The check validates saved ownership through current database bindings. It does not inspect provider files or grant execution authority. - Existing saved rows retain their shape. No migration or archive format changes are required. ## Model Used OpenAI Codex, GPT-6 family, with reasoning, repository tools, code editing, and real PostgreSQL tests. The host does not expose the exact model ID or context window size. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
86 lines
5.8 KiB
TypeScript
86 lines
5.8 KiB
TypeScript
import { and, eq, isNotNull, isNull, sql } from "drizzle-orm";
|
|
import { agentFileRoots, agents, executionWorkspaces, heartbeatRuns, providerTraceRecords, type Db } from "@paperclipai/db";
|
|
import type { Config } from "../config.js";
|
|
import { isValidLocalEncryptedMasterKey } from "../secrets/local-encrypted-provider.js";
|
|
import { agentInstructionsBundleMode } from "./agent-instructions.js";
|
|
import { skillInstallationMaintenance } from "./skill-installation-maintenance.js";
|
|
import { hasLocalNativeHarnessObligations } from "./native-runtime/native-harness-backup-migration.js";
|
|
import { hasLocalNativeControllerObligations } from "./native-runtime/native-controller-migration.js";
|
|
import { hasUnsettledLocalInstructionCopies } from "./agent-instruction-copy-preservation.js";
|
|
import { hasLocalRuntimeSkillObligations } from "./native-runtime/runtime-skill-preservation.js";
|
|
import { localWorkspaceDependencyWhere } from "./local-workspace-dependencies.js";
|
|
|
|
import { ephemeralServerEnabled } from "./ephemeral-server-mode.js";
|
|
|
|
export { ephemeralServerEnabled };
|
|
|
|
/** Validate before consumers can generate a replacement local identity. Error
|
|
* messages name settings only, never credential values or connection URLs. */
|
|
export function assertEphemeralServerConfig(config: Pick<Config, "databaseUrl" | "storageProvider">, env = process.env): string | null {
|
|
if (env.PAPERCLIP_EPHEMERAL_SERVER !== "true") return null;
|
|
const refuse = (reason: string): never => { throw new Error(`Volume-free server configuration: ${reason}`); };
|
|
if (config.storageProvider !== "s3" || env.PAPERCLIP_DURABLE_AGENT_FILES !== "true" || env.PAPERCLIP_SHARED_UI_ASSETS !== "true") {
|
|
refuse("shared S3 storage, durable agent files and shared UI assets are required");
|
|
}
|
|
if (!env.PAPERCLIP_SECRETS_MASTER_KEY || !isValidLocalEncryptedMasterKey(env.PAPERCLIP_SECRETS_MASTER_KEY)) {
|
|
refuse("a stable PAPERCLIP_SECRETS_MASTER_KEY is required");
|
|
}
|
|
if ((env.PAPERCLIP_DECISION_SIGNING_SECRET?.trim().length ?? 0) < 32) {
|
|
refuse("a stable PAPERCLIP_DECISION_SIGNING_SECRET of at least 32 characters is required; preserve the existing decision key during migration");
|
|
}
|
|
let runtime: URL, listener: URL;
|
|
try { runtime = new URL(config.databaseUrl ?? ""); listener = new URL(env.PAPERCLIP_DATABASE_LISTEN_URL ?? ""); }
|
|
catch { return refuse("external DATABASE_URL and PAPERCLIP_DATABASE_LISTEN_URL are required"); }
|
|
if (![runtime, listener].every(url => ["postgres:", "postgresql:"].includes(url.protocol))
|
|
|| runtime.username !== listener.username || runtime.password !== listener.password || runtime.pathname !== listener.pathname
|
|
|| runtime.hostname.replace(/-pooler(?=\.)/, "") !== listener.hostname
|
|
|| /pooler|pgbouncer/i.test(listener.hostname)) {
|
|
refuse("PAPERCLIP_DATABASE_LISTEN_URL must be a direct connection to the same database using the runtime role");
|
|
}
|
|
return listener.href;
|
|
}
|
|
|
|
/** A readiness gate, not a periodic scan or an implicit migration. Existing
|
|
* volume data is adopted by the owning maintenance commands before removal. */
|
|
export async function assertEphemeralServerData(db: Db) {
|
|
if (!ephemeralServerEnabled()) return;
|
|
const { blockers } = await readEphemeralServerDataEligibility(db, { purpose: "startup" });
|
|
if (blockers.length) throw new Error(`Volume-free server data is not eligible: ${blockers.join(", ")}`);
|
|
}
|
|
|
|
export async function readEphemeralServerDataEligibility(db: Db, options: { purpose?: "migration" | "startup" } = {}) {
|
|
const blockers: string[] = [];
|
|
const [missingFiles] = await db.select({ id: agents.id }).from(agents).leftJoin(agentFileRoots,
|
|
and(eq(agentFileRoots.companyId, agents.companyId), eq(agentFileRoots.agentId, agents.id)))
|
|
.where(isNull(agentFileRoots.agentId)).limit(1);
|
|
if (missingFiles) blockers.push("agent_files_require_migration");
|
|
if (await hasUnsettledLocalInstructionCopies(db)) blockers.push("local_instruction_copies_require_settlement");
|
|
// Only inspect configuration here; filesystem reads must never adopt an
|
|
// empty directory on the replacement machine as the old server's content.
|
|
const configured = await db.select({ id: agents.id, companyId: agents.companyId, name: agents.name, adapterConfig: agents.adapterConfig }).from(agents);
|
|
if (configured.some(agent => agentInstructionsBundleMode(agent) === "external")) blockers.push("external_agent_instructions");
|
|
const [localWorkspace] = await db.select({ id: executionWorkspaces.id }).from(executionWorkspaces)
|
|
.where(localWorkspaceDependencyWhere(db)).limit(1);
|
|
if (localWorkspace) blockers.push("workspaces_require_migration");
|
|
const [localLog] = await db.select({ id: heartbeatRuns.id }).from(heartbeatRuns).where(and(
|
|
eq(heartbeatRuns.logStore, "local_file"), isNotNull(heartbeatRuns.logRef),
|
|
)).limit(1);
|
|
if (localLog) blockers.push("run_logs_require_migration");
|
|
const [localTrace] = await db.select({ id: providerTraceRecords.id }).from(providerTraceRecords).where(and(
|
|
isNull(providerTraceRecords.deletedAt), sql`${providerTraceRecords.traceRef} not like 's3-segments-v1:%'`,
|
|
)).limit(1);
|
|
if (localTrace) blockers.push("provider_traces_require_migration");
|
|
if (await hasLocalNativeHarnessObligations(db)) blockers.push("native_harness_backups_require_migration");
|
|
if (await hasLocalNativeControllerObligations(db)) blockers.push("native_controllers_require_migration");
|
|
if (await hasLocalRuntimeSkillObligations(db)) blockers.push("runtime_skill_assets_require_migration");
|
|
const skills = skillInstallationMaintenance(db);
|
|
let after: string | undefined;
|
|
for (;;) {
|
|
const page = await skills.eligibility({ after, limit: 50, purpose: options.purpose });
|
|
if (page.results.some(skill => skill.status !== "version_backed")) { blockers.push("skills_require_migration"); break; }
|
|
if (page.inspected < 50 || !page.after) break;
|
|
after = page.after;
|
|
}
|
|
return { eligible: blockers.length === 0, blockers };
|
|
}
|