mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-11-20 09:50:48 +01:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work > - The chat eval catalog checks that agents in chat do the right thing, graded on saved product state and rendered links > - Full cohort 8 (OpenCode, `openrouter/deepseek/deepseek-v4.1-flash-1017`, master7747487ee7) failed six cases after two deliberate product changes and one harness race > - #21135 continues an unfinished run in a fresh run from saved work instead of leaving an exhausted, board-owned recovery action. Three recovery cases still waited for that action. > - #21175 counts a `get_task_history` read of a queued comment's current revision as delivery. Two steering cases still required a continuation run. > - `companies.prompt-injection-guard` read the settings back before its own save finished > - This pull request grades the recovery and steering cases on the new contracts and makes the settings harness verify the saved model before it continues > - The benefit is that the evals accept the intended product behavior and still fail a broken product ## Linked Issues or Issue Description Refs #21135 Refs #21175 **What happened?** Cohort 8 failed `recovery.explain-stall`, `recovery.retry-exhausted` and `recovery.source-action`: the harness waited 30 s for an "exhausted source recovery action with no automatic wake". #21135 now logs "Unfinished run continues in a fresh run from saved work" (`trigger: recovery_refused`, `delivery: recorded`) instead. `steering.edit-queued-message` and `agent-chat.multiple-handoffs` failed their run counts: the running worker turn read the queued comment (current revision) and applied it, so no continuation run was queued. `companies.prompt-injection-guard` read `openai/gpt-oss-safeguard-20b`: the server log shows the harness GET finished before the settings PUT. **Expected behavior** Infrastructure loss continues automatically in one fresh run, the chat explains it, and the continuation finishes the task. A queued comment is consumed once, in the running turn or in one continuation. The settings harness tests only the model it saved. **Steps to reproduce** Run the six `chat-features.runner-opencode.local.*` cases on master after #21135 and #21175. ## What Changed - `runtime-infrastructure.ts` (`recovery.explain-stall`, `recovery.source-action`, oracle `infrastructure-recovery.v6`): after three real Runner losses, the setup waits for one system-owned fresh-continuation record of the failed run (`?inspectSourceRunId`), resolved as `restored`, `replay: "none"`, the failed run marked superseded, and one run with `retryOfRunId` = the failed run that waits for its brief in its own workspace. The chat question is asked while it runs. The harness then releases the brief, and the grade requires the continuation to succeed, save the brief's reference as the latest revision and complete the original task. No person-owned hold and no blocked task at the reply. Three runs: failed 1, succeeded 2. The reply must still come from a run that read the recovery record (now also the continuation run) and link the original task. Setup timing is saved to `runtime-fresh-continuation.json`. - `runtime-infrastructure-retry.ts` (`recovery.retry-exhausted`, oracle `retry-exhausted.v6`): an infrastructure loss no longer offers Retry. The case uses a failure only the person can resolve (`native_provider_model_rejected`, a `PERSON_OWNED_FAILURE_CODES` member) and keeps the Retry-under-budget-hold journey unchanged. The setup proves the task waits blocked with no fresh continuation and no successor run for 45 s. - `runtime-busy-worker.ts`: the Retry listener helpers move here; a listener counts only when its `.waiting` file is newer than the run's start. - `runtime-queue.ts`: `historyReadRevisions`, `readCurrentRevision`, `runHistoryReads` read `task_history.read` events; `settledQueue` needs a 30 s quiet settled state. - `runtime-queue-controls.ts` (`steering.edit-queued-message`, oracle `structural.v5`) and `runtime-multiple-handoffs.ts` (oracle `v5`): accept in-turn consumption only with a worker `task_history.read` of every queued comment's current revision, the change saved as the latest revision (blue; "Launch sooner"), an empty queue, a done task and zero continuations. The continuation path stays: exactly one continuation with the unread comments in order, when the turn did not read the current revision. Run bounds 2–3 and 4–5. The worker brief no longer tells the agent to leave follow-ups for a continuation. - `identity-company-models.ts` (`prompt-injection-guard` oracle `prompt-injection-guard.v2`, `fast-responses` `v4`): before saving, check the model field holds the requested model; wait for the PUT; require 200, the sent model, the saved model, then a matching read-back. - `recovery.yaml`: context and expected outcome for the three recovery cases. Recorded in `chat-full-catalog-testops-manifest.json` `changedFields` and pinned in its test. Descriptors and the inventory digest are updated. `maps/feature-map/recovery.md` exhaustion line corrected. ## Verification - `npx vitest run --config tests/runner-e2e/vitest.config.ts tests/runner-e2e/chat-catalog tests/runner-e2e/chat-catalog-domains`: 283 files, 3895 tests pass. New calibration tests cover valid, reworded-valid and broken cases: no continuation, a person-owned hold, two continuation records or runs, a replayed turn, an unfinished continuation, a missing saved result; an old-revision-only read, a missing outcome, a double application, two continuations; a model field that lost the model, a different sent model, a wrong saved model. - `pnpm test:e2e:runner:typecheck`: pass. - `node --test tests/runner-e2e/chat-full-catalog-testops-manifest.test.mjs`: 10/10 pass. - `node tests/runner-e2e/source-sdk-public-inputs.mjs <head sha> --check`: `changed: false`. - `node scripts/check-maps.mjs`: aligned. - Paid run: Runner Full-Stack E2E 43321773136 at9de2bd5a6f, six cases: prompt-injection-guard passed. The two fresh-continuation cases found a product failure (the continuation never started), fixed in #21217. retry-exhausted showed that a model-rejected failure offers no Retry control. multiple-handoffs failed correctly: the turn read the instruction and did not apply it. edit-queued-message did not reach the new grade (6-minute CEO turn). Details are in a PR comment. ## Risks - The recovery cases depend on the fresh continuation starting within 5 minutes. The paid run showed it did not start; #21217 fixes that. Until #21217 merges, those cases fail on master. - `recovery.retry-exhausted` expects a Retry control that the product does not show for a model-rejected failure. It fails until a product decision is made. - `recovery.retry-exhausted` no longer covers infrastructure exhaustion; the two other recovery cases cover the new automatic path. > For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and discuss it in `#dev` before opening the PR. Feature PRs that overlap with planned core work may need to be redirected — check the roadmap first. See `CONTRIBUTING.md`. ## Model Used - Claude Opus 5.5 (`claude-opus-5-5`), Anthropic, used through Claude Code with tool use and code execution. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [ ] All Paperclip CI gates are green - [ ] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
106 lines
11 KiB
TypeScript
106 lines
11 KiB
TypeScript
import { describe, it, expect } from "vitest";
|
|
import { deflateRawSync } from "node:zlib";
|
|
import { gradeQueuedFollowup, historyReadRevisions, keyboardMoveQueuedMessageUp, promptCarriesComment, readCurrentRevision, zipEntryTexts } from "./runtime-queue.js";
|
|
/** A minimal zip with one deflated and one stored entry, laid out as zip tools write it. */
|
|
function zip(entries: Array<{ name: string; text: string; deflate: boolean }>) {
|
|
const locals: Buffer[] = [], centrals: Buffer[] = []; let offset = 0;
|
|
for (const entry of entries) {
|
|
const name = Buffer.from(entry.name), raw = Buffer.from(entry.text), data = entry.deflate ? deflateRawSync(raw) : raw;
|
|
const local = Buffer.alloc(30); local.writeUInt32LE(0x04034b50, 0); local.writeUInt16LE(entry.deflate ? 8 : 0, 8); local.writeUInt32LE(data.length, 18); local.writeUInt32LE(raw.length, 22); local.writeUInt16LE(name.length, 26);
|
|
const central = Buffer.alloc(46); central.writeUInt32LE(0x02014b50, 0); central.writeUInt16LE(entry.deflate ? 8 : 0, 10); central.writeUInt32LE(data.length, 20); central.writeUInt32LE(raw.length, 24); central.writeUInt16LE(name.length, 28); central.writeUInt32LE(offset, 42);
|
|
locals.push(local, name, data); centrals.push(central, name); offset += 30 + name.length + data.length;
|
|
}
|
|
const directory = Buffer.concat(centrals), end = Buffer.alloc(22); end.writeUInt32LE(0x06054b50, 0); end.writeUInt16LE(entries.length, 8); end.writeUInt16LE(entries.length, 10); end.writeUInt32LE(directory.length, 12); end.writeUInt32LE(offset, 16);
|
|
return Buffer.concat([...locals, directory, end]);
|
|
}
|
|
function valid() { return { scenarioId: "steering.queue-follow-up", origin: "http://fixture.invalid", companyId: "company", leadId: "ceo",
|
|
state: { task: { id: "website", identifier: "PAP-7" }, worker: { id: "morgan" }, workerStatusAtReply: "running", canonicalRunId: "controller",
|
|
queuedAtReply: { issueId: "website", state: "queued", entries: [{ position: 0, comment: { id: "contact", body: "Add a contact section", authorAgentId: "ceo", createdByRunId: "controller" } }] },
|
|
queryReply: "I saved the contact request on [PAP-7](/PAP/issues/PAP-7) for Morgan's next turn.", consumedCommentId: "contact", deliveryNativeInputBound: true,
|
|
consumingRunCount: 1, queueEmptyAfterDelivery: true, initialBriefRevisionRetained: true, contactResultRevision: true },
|
|
agents: [], tasks: [{ id: "website", assigneeAgentId: "morgan", status: "done" }], links: [], activity: [], reply: "", humanQueries: [],
|
|
runs: [{ id: "prior", agentId: "morgan", status: "succeeded" }, { id: "controller", agentId: "ceo", status: "succeeded" }, { id: "successor", agentId: "morgan", status: "succeeded" }] }; }
|
|
it("accepts actual ordered queue admission and one later consuming native turn", () => expect(gradeQueuedFollowup(valid()).passed).toBe(true));
|
|
it("accepts a reworded reply that names the task without queue vocabulary", () => { const o = valid(); o.state.queryReply = "Morgan is mid-turn on PAP-7. Your contact section will reach him once he finishes."; expect(gradeQueuedFollowup(o).passed).toBe(true); });
|
|
it("accepts a requirement worded without the word contact", () => { const o = valid(); o.state.queuedAtReply.entries[0]!.comment.body = "Please add a way for visitors to reach us."; expect(gradeQueuedFollowup(o).passed).toBe(true); });
|
|
it("rejects absent queue evidence", () => expect(gradeQueuedFollowup(undefined).passed).toBe(false));
|
|
it("rejects forwarding to a similarly named task", () => { const o = valid(); o.state.queuedAtReply.issueId = "other"; expect(gradeQueuedFollowup(o).passed).toBe(false); });
|
|
it("rejects a reply that does not identify the affected task", () => { const o = valid(); o.state.queryReply = "Done, I passed it along."; expect(gradeQueuedFollowup(o).passed).toBe(false); });
|
|
it("rejects a different identifier that shares the prefix", () => { const o = valid(); o.state.queryReply = "Saved on PAP-70."; expect(gradeQueuedFollowup(o).passed).toBe(false); });
|
|
it("rejects a requirement written by someone other than the canonical controller turn", () => { const o = valid(); o.state.queuedAtReply.entries[0]!.comment.createdByRunId = "other-run"; expect(gradeQueuedFollowup(o).passed).toBe(false); });
|
|
it("rejects a successor without the actual saved comment in its native input", () => { const o = valid(); o.state.deliveryNativeInputBound = false; expect(gradeQueuedFollowup(o).passed).toBe(false); });
|
|
it("rejects duplicate requirement admission", () => { const o = valid(); o.state.queuedAtReply.entries.push({ ...o.state.queuedAtReply.entries[0]!, position: 1 }); expect(gradeQueuedFollowup(o).passed).toBe(false); });
|
|
it("rejects losing the original worker's saved work", () => { const o = valid(); o.state.initialBriefRevisionRetained = false; expect(gradeQueuedFollowup(o).passed).toBe(false); });
|
|
it("rejects output attributed to the wrong native revision", () => { const o = valid(); o.state.contactResultRevision = false; expect(gradeQueuedFollowup(o).passed).toBe(false); });
|
|
it("accepts the contact section delivered as the successor's registered build instead of a document", () => { const o = valid(); o.state.contactResultRevision = false; Object.assign(o.state, { contactResultDeliverable: true }); expect(gradeQueuedFollowup(o).passed).toBe(true); });
|
|
it("rejects a successor deliverable without the contact section", () => { const o = valid(); o.state.contactResultRevision = false; Object.assign(o.state, { contactResultDeliverable: false }); expect(gradeQueuedFollowup(o).passed).toBe(false); });
|
|
it("reads stored and deflated zip entries and treats other bytes as no entries", () => {
|
|
const bytes = zip([{ name: "site/index.html", text: '<section id="contact"><h2>Contact</h2></section>', deflate: true }, { name: "site/styles.css", text: "body{margin:0}", deflate: false }]);
|
|
expect(zipEntryTexts(bytes)).toEqual(['<section id="contact"><h2>Contact</h2></section>', "body{margin:0}"]);
|
|
expect(zipEntryTexts(Buffer.from("<html>Contact</html>"))).toEqual([]);
|
|
expect(zipEntryTexts(bytes.subarray(0, bytes.length - 30))).toEqual([]);
|
|
});
|
|
it("finds the saved comment in a native prompt raw or JSON-escaped, and only with its id and body", () => {
|
|
const comment = { id: "c-1", body: "Add a \"Contact us\" section\nwith email." };
|
|
const prompt = `{"newComments":[{"id":"c-1","body":${JSON.stringify(comment.body)}}]}`;
|
|
expect(promptCarriesComment(prompt, comment)).toBe(true);
|
|
expect(promptCarriesComment(`plain c-1\n${comment.body}`, comment)).toBe(true);
|
|
expect(promptCarriesComment(prompt.replace("c-1", "c-2"), comment)).toBe(false);
|
|
expect(promptCarriesComment("continue the website task c-1", comment)).toBe(false);
|
|
expect(promptCarriesComment(undefined, comment)).toBe(false);
|
|
});
|
|
it("finds the saved comment when a continuation envelope nests the events JSON as a string", () => {
|
|
const comment = { id: "c-1", body: "Add a \"Contact\" section.\n\n- nav link" };
|
|
const prompt = JSON.stringify({ schema: "paperclip.native-continuation.v1", events: JSON.stringify({ messages: [{ id: "c-1", body: comment.body }, { id: "c-2", body: "Done." }] }) });
|
|
expect(prompt.includes(comment.body) || prompt.includes(JSON.stringify(comment.body).slice(1, -1))).toBe(false);
|
|
expect(promptCarriesComment(prompt, comment)).toBe(true);
|
|
expect(promptCarriesComment(JSON.stringify({ events: JSON.stringify({ messages: [{ id: "c-1", body: "Add a section." }] }) }), comment)).toBe(false);
|
|
expect(promptCarriesComment(JSON.stringify({ events: JSON.stringify({ messages: [{ id: "c-2", body: comment.body }], note: "c-1" }) }), comment)).toBe(false);
|
|
});
|
|
|
|
// Full cohort 5 on 98c18784c6 (steering.approval-delivery, steering.edit-queued-message): the gesture was pressed
|
|
// right after Save while the handle was still disabled, so no PUT /queued-comments/order was sent.
|
|
function reorderPage(enableAfterMs: number) {
|
|
const enabledAt = Date.now() + enableAfterMs, pressed: Array<{ key: string; enabled: boolean }> = [];
|
|
let resolveResponse!: (value: unknown) => void;
|
|
const page = { waitForResponse: (match: (response: unknown) => boolean, options: { timeout: number }) => new Promise((resolve, reject) => {
|
|
resolveResponse = value => { if (match(value)) resolve(value); };
|
|
setTimeout(() => reject(new Error("timeout")), options.timeout);
|
|
}) };
|
|
const handle = { isEnabled: async () => Date.now() >= enabledAt, focus: async () => undefined,
|
|
press: async (key: string) => {
|
|
const enabled = Date.now() >= enabledAt; pressed.push({ key, enabled });
|
|
if (enabled && key === "Space" && pressed.filter(row => row.key === "Space").length === 2)
|
|
resolveResponse({ request: () => ({ method: () => "PUT" }), url: () => "http://127.0.0.1/api/issues/t/queued-comments/order", status: () => 200 });
|
|
} };
|
|
return { page: page as never, handle: handle as never, pressed };
|
|
}
|
|
it("waits for the reorder handle to be enabled before the keyboard gesture, and returns the order request's status", async () => {
|
|
const fake = reorderPage(300);
|
|
const result = await keyboardMoveQueuedMessageUp(fake.page, fake.handle, 3_000, 20);
|
|
expect(result.status).toBe(200); expect(result.waitedForEnabledMs).toBeGreaterThanOrEqual(250);
|
|
expect(fake.pressed.every(row => row.enabled)).toBe(true);
|
|
});
|
|
it("fails when the handle never enables or the gesture sends no order request", async () => {
|
|
await expect(keyboardMoveQueuedMessageUp(reorderPage(10_000).page, reorderPage(10_000).handle, 200, 20)).rejects.toThrow(/stayed disabled/);
|
|
const silent = reorderPage(0);
|
|
const handle = { ...(silent.handle as object), press: async () => undefined };
|
|
await expect(keyboardMoveQueuedMessageUp(silent.page, handle as never, 200, 20)).rejects.toThrow(/sent no queue order request/);
|
|
});
|
|
|
|
describe("task history reads", () => {
|
|
const event = (comments: unknown, eventType = "task_history.read") => ({ eventType, payload: { comments } });
|
|
it("keeps the newest revision each comment was read at, from history-read events only", () => {
|
|
expect(historyReadRevisions([event({ a: "2026-11-12T21:50:00.000Z" }), event({ a: "2026-11-12T21:52:30.494Z", b: "2026-11-12T21:50:24.404Z" }),
|
|
event({ a: "2026-11-12T21:49:00.000Z" }), event({ c: "2026-11-12T21:59:00.000Z" }, "tool.execution.completed"), event(["a"]), event({ d: "not a date" })]))
|
|
.toEqual({ a: "2026-11-12T21:52:30.494Z", b: "2026-11-12T21:50:24.404Z" });
|
|
});
|
|
it("counts a read only at or after the comment's current revision", () => {
|
|
const reads = { a: "2026-11-12T21:52:30.494Z" };
|
|
expect(readCurrentRevision(reads, { id: "a", updatedAt: "2026-11-12T21:52:30.494Z" })).toBe(true);
|
|
expect(readCurrentRevision(reads, { id: "a", updatedAt: "2026-11-12T21:52:31.000Z" })).toBe(false);
|
|
expect(readCurrentRevision(reads, { id: "b", updatedAt: "2026-11-12T21:50:00.000Z" })).toBe(false);
|
|
expect(readCurrentRevision(reads, undefined)).toBe(false);
|
|
});
|
|
});
|