mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-11-16 11:59:26 +01:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work > - The plugin Runner release/resume integration test proves that a released Runner can be resumed by the next run > - The test failed on unrelated PR #21171 in the "Verify Paperclip Runner (vitest native server)" lane > - One slow case caused 5 more cases to fail, and the PR retry could not run > - #21199 fixed the same class of failure in the plugin Runner eviction test > - This pull request applies the same isolation to the release/resume test, and also isolates its shared spies > - The benefit is that one slow case no longer fails the cases after it ## Linked Issues or Issue Description Refs #21199 **What happened?** `server/src/services/native-runtime/plugin-runner-release-resume.integration.test.ts` failed on unrelated PR #21171. "completes codex runs through a retained cached process" timed out at 60s. Then 5 more cases failed, some at 60s and some in under 3s with `RangeError: Maximum call stack size exceeded`. Every retry failed on `duplicate key value violates unique constraint "issues_identifier_idx"`. Root cause: every case changed process-wide state and restored it in its own `finally` block. That state was the default TLS trust, `https.globalAgent`, a `vi.spyOn` on `PaperclipRunnerToolAuthority.prototype.definitions`, and a `vi.spyOn` on `inspectRemoteWarmSessionRecovery`. Vitest continues to the next case when a case times out, but the timed-out function continues to run. While it ran, the next case read the timed-out case's spy as the "original" `definitions`. When the timed-out case restored its spies, the two spies called each other, and the stack overflowed. Its late `finally` also removed the next case's TLS trust, so that case stayed in `connecting` with no wire frames until its own 60s timeout. It also closed the next case's warm sessions with `closeIdleWarmNativeSessionsForRestart()`. The retry could not help, because the issue identifier came only from the case name. **Expected behavior** A case that times out fails alone. Later cases and the PR retry run normally. **Steps to reproduce** 1. Make the `codex cached` case sleep 62s once, after its first run. 2. From `server/`, run `npx vitest run src/services/native-runtime/plugin-runner-release-resume.integration.test.ts -t "codex runs through a retained (cached|adopted|adopted restart) process"`. 3. Before this change, 3 of 3 cases fail, with `Maximum call stack size exceeded`. With `--retry=1`, 3 of 3 still fail. 4. After this change, only the slow case fails. With `--retry=1`, 3 of 3 pass. **Paperclip version or commit** origin/master at the base of this branch (after #21199) **Deployment mode** CI and local test only (embedded Postgres, real `paperclip-runnerd`) **Agent adapter(s) involved** paperclip_runner (codex and claude ACPX harnesses through the plugin task driver) ## What Changed - Create one fixture certificate in `beforeAll`. Set the TLS trust and `https.globalAgent` once for the file, and restore them in `afterAll`. - Read the original `PaperclipRunnerToolAuthority.prototype.definitions` once at module load, before any case spies on it. - Move the per-case teardown into an `afterEach` that is registered before the database fixture. The teardown closes idle warm sessions, the host control, and the TLS proxy, and it restores both spies. Each case binds its own teardown holder before its first await. - Add a random suffix to the issue identifier of each attempt, so the PR retry can run the case again. - Increase the idle timeout of the adopted cases from 5s to 10s. The product limits a release to `min(idleTimeoutMs, 30s)`, and #21199 measured a loaded release that took more than 4.8s. - Probe the Runner port on `0.0.0.0`, the address that the Runner binds. No product code changed. ## Verification - Injection test (one case sleeps 62s): see the steps above. Before: 3 of 3 failed, also with `--retry=1`. After: 1 of 3 failed without retry, and 3 of 3 passed with `--retry=1`. - Before/after loops of the full file (14 cases), run in parallel on the same loaded macOS host: see the loop result comment on this PR. - `tsc --noEmit -p server/tsconfig.json` reports no errors in the changed file. ## Risks Low risk. Only the test changed. The adopted (non-restart) cases take about 5s more each. The file creates one certificate instead of 14. A case that hangs inside Core execution can still leave a busy warm session in module state. ## Model Used Claude Opus 5.5 (`claude-opus-5-5`), Anthropic, used in Claude Code with tool use (shell, file edits) and extended reasoning. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [ ] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [ ] All Paperclip CI gates are green - [ ] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>