mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-27 02:44:50 +01:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work. > - Paperclip runs across the CLI, server, adapters, plugins, CI, and container images. > - These surfaces declared different Node.js versions from 20 through 24. > - A newer `@types/node` major can expose APIs that the supported runtime does not provide. > - Node.js 20 is no longer a suitable project baseline, and Node.js 24 is the current LTS line. > - This pull request sets Node.js 24.11.0 as one repository-wide baseline, adds a drift check, and gives users actionable startup guidance when their runtime is too old. > - The benefit is one clear runtime contract for development, release, installation, and published packages. ## Linked Issues or Issue Description Refs #2734 Refs #11727 Refs #739 ## What Changed - Require Node.js 24.11.0 or newer in all 42 package manifests and runtime checks. - Use Node.js 24 in GitHub Actions, Docker images, smoke images, sandbox setup, portable installs, and esbuild targets. - Align every direct `@types/node` declaration on `^24.0.0`. - Prevent Dependabot from opening major `@types/node` upgrades without a matching runtime decision. - Add `.nvmrc` and a CI policy check for Node version drift. - Update ACP version gates, tests, and user documentation for the new minimum. - Print a non-blocking warning on CLI and server startup when Node is unsupported, with remediation through a version manager or the documented downloaded `install.sh` workflow. - Deduplicate that warning when `paperclipai run` boots the CLI and server in the same process. ## Verification - `node scripts/check-node-version-policy.mjs` - `node --check scripts/check-node-version-policy.mjs` - `node --check cli/esbuild.config.mjs` - `node --check scripts/generate-npm-package-json.mjs` - `bash -n scripts/install.sh scripts/test-install-sh-docker.sh scripts/e2e-install-lifecycle.sh` - Parsed all 42 package manifests and confirmed `engines.node` is `>=24.11.0`. - `git diff --check` - `vitest run packages/adapter-utils/src/sandbox-install-command.test.ts` passed with 3 tests. - `vitest run cli/src/node-version.test.ts` passed with 4 tests. - Directly exercised the shared warning helper for unsupported-version messaging and same-process deduplication. - The focused exe.dev suite could not resolve the locally unbuilt plugin SDK from this isolated worktree. A full offline workspace install was also blocked because the package-manager signature verifier requires registry access. The full suite was not run locally; draft CI performs a clean install and evaluates the wider impact. ## Risks - This is a breaking runtime change for users, plugins, and deployments that still use Node.js 20 or 22. - Published workspace packages will now produce an engine warning or failure in strict package managers on older Node.js releases. - Node.js 24 can reveal dependency, native module, Playwright, or agent CLI compatibility issues in CI. - The bootstrap installer now installs Node.js 24 when the current runtime is older than 24.11.0. - The portable sandbox fallback is pinned to Node.js 24.11.0 and depends on that upstream tarball remaining available. - Unsupported runtimes continue booting after a warning, so a later incompatibility can still fail at its point of use. - The CLI and server share the warning policy through the published `@paperclipai/shared` package; packaging checks must keep that subpath export available. - This PR does not commit `pnpm-lock.yaml` because repository policy assigns lockfile generation to CI. > For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and discuss it in `#dev` before opening the PR. Feature PRs that overlap with planned core work may need to be redirected — check the roadmap first. See `CONTRIBUTING.md`. ## Model Used - OpenAI Codex based on GPT-5. The exact deployment ID and context window are not exposed in this session. Reasoning, repository tools, shell execution, and GitHub tools were enabled. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
871 lines
27 KiB
TypeScript
871 lines
27 KiB
TypeScript
import { EventEmitter } from "node:events";
|
|
import { beforeEach, describe, expect, it, vi } from "vitest";
|
|
|
|
const fetchMock = vi.fn();
|
|
const spawnMock = vi.hoisted(() => vi.fn());
|
|
|
|
vi.stubGlobal("fetch", fetchMock);
|
|
|
|
vi.mock("node:child_process", async () => {
|
|
const actual = await vi.importActual<typeof import("node:child_process")>("node:child_process");
|
|
return {
|
|
...actual,
|
|
spawn: spawnMock,
|
|
};
|
|
});
|
|
|
|
import plugin, { validateSshPrivateKey } from "./plugin.js";
|
|
import manifest from "./manifest.js";
|
|
|
|
class MockChildProcess extends EventEmitter {
|
|
stdout = new EventEmitter();
|
|
stderr = new EventEmitter();
|
|
stdin = {
|
|
written: "" as string,
|
|
ended: false,
|
|
write: (chunk: string) => {
|
|
this.stdin.written += chunk;
|
|
return true;
|
|
},
|
|
end: () => {
|
|
this.stdin.ended = true;
|
|
},
|
|
};
|
|
kill = vi.fn();
|
|
|
|
constructor(input: { code?: number; signal?: string | null; stdout?: string; stderr?: string }) {
|
|
super();
|
|
queueMicrotask(() => {
|
|
if (input.stdout) this.stdout.emit("data", input.stdout);
|
|
if (input.stderr) this.stderr.emit("data", input.stderr);
|
|
this.emit("close", input.code ?? 0, input.signal ?? null);
|
|
});
|
|
}
|
|
}
|
|
|
|
function queueSpawnResult(input: { code?: number; signal?: string | null; stdout?: string; stderr?: string }) {
|
|
spawnMock.mockImplementationOnce(() => new MockChildProcess(input));
|
|
}
|
|
|
|
describe("exe.dev sandbox provider plugin", () => {
|
|
beforeEach(() => {
|
|
fetchMock.mockReset();
|
|
spawnMock.mockReset();
|
|
delete process.env.EXE_API_KEY;
|
|
});
|
|
|
|
it("declares environment lifecycle handlers", async () => {
|
|
expect(await plugin.definition.onHealth?.()).toEqual({
|
|
status: "ok",
|
|
message: "exe.dev sandbox provider plugin healthy",
|
|
});
|
|
expect(plugin.definition.onEnvironmentAcquireLease).toBeTypeOf("function");
|
|
expect(plugin.definition.onEnvironmentExecute).toBeTypeOf("function");
|
|
});
|
|
|
|
it("normalizes config and emits SSH guidance warnings", async () => {
|
|
process.env.EXE_API_KEY = "host-key";
|
|
|
|
const result = await plugin.definition.onEnvironmentValidateConfig?.({
|
|
driverKey: "exe-dev",
|
|
config: {
|
|
apiUrl: "https://exe.dev",
|
|
namePrefix: " Paperclip Sandbox ",
|
|
image: " ubuntu:22.04 ",
|
|
cpu: "4.8",
|
|
memory: " 8GB ",
|
|
disk: " 50GB ",
|
|
env: {
|
|
FOO: " bar ",
|
|
},
|
|
integrations: [" github "],
|
|
tags: "prod, sandbox",
|
|
timeoutMs: "450000.9",
|
|
reuseLease: true,
|
|
sshPort: "2222",
|
|
},
|
|
});
|
|
|
|
expect(result).toEqual({
|
|
ok: true,
|
|
warnings: [
|
|
"The Paperclip host must have SSH access to the created exe.dev VM, and its SSH key must be registered with exe.dev. The API token only covers provisioning.",
|
|
"reuseLease keeps the VM alive between runs; this provider does not suspend retained VMs.",
|
|
],
|
|
normalizedConfig: {
|
|
apiKey: null,
|
|
apiUrl: "https://exe.dev/exec",
|
|
namePrefix: "paperclip-sandbox",
|
|
image: "ubuntu:22.04",
|
|
command: null,
|
|
cpu: 4,
|
|
memory: "8GB",
|
|
disk: "50GB",
|
|
comment: null,
|
|
env: { FOO: "bar" },
|
|
integrations: ["github"],
|
|
tags: ["prod", "sandbox"],
|
|
setupScript: null,
|
|
prompt: null,
|
|
timeoutMs: 450000,
|
|
reuseLease: true,
|
|
sshUser: null,
|
|
sshPrivateKey: null,
|
|
sshIdentityFile: null,
|
|
sshPort: 2222,
|
|
strictHostKeyChecking: "accept-new",
|
|
},
|
|
});
|
|
});
|
|
|
|
it("normalizes trailing /exec apiUrl inputs without duplication", async () => {
|
|
process.env.EXE_API_KEY = "host-key";
|
|
|
|
const result = await plugin.definition.onEnvironmentValidateConfig?.({
|
|
driverKey: "exe-dev",
|
|
config: {
|
|
apiUrl: "https://exe.dev/exec/",
|
|
},
|
|
});
|
|
|
|
expect(result).toMatchObject({
|
|
ok: true,
|
|
normalizedConfig: {
|
|
apiUrl: "https://exe.dev/exec",
|
|
},
|
|
});
|
|
});
|
|
|
|
it("rejects invalid config", async () => {
|
|
await expect(plugin.definition.onEnvironmentValidateConfig?.({
|
|
driverKey: "exe-dev",
|
|
config: {
|
|
apiUrl: "not-a-url",
|
|
cpu: 0,
|
|
env: {
|
|
"BAD-KEY": "value",
|
|
},
|
|
sshPort: 70000,
|
|
strictHostKeyChecking: "",
|
|
timeoutMs: 0,
|
|
},
|
|
})).resolves.toEqual({
|
|
ok: false,
|
|
warnings: [
|
|
"The Paperclip host must have SSH access to the created exe.dev VM, and its SSH key must be registered with exe.dev. The API token only covers provisioning.",
|
|
],
|
|
errors: [
|
|
"apiUrl must be a valid URL.",
|
|
"timeoutMs must be between 1 and 86400000.",
|
|
"cpu must be greater than 0 when provided.",
|
|
"sshPort must be between 1 and 65535.",
|
|
"exe.dev environments require an API key in config or EXE_API_KEY.",
|
|
"env contains an invalid key: BAD-KEY",
|
|
"strictHostKeyChecking cannot be empty.",
|
|
],
|
|
});
|
|
});
|
|
|
|
describe("sshPrivateKey validation", () => {
|
|
const VALID_OPENSSH = [
|
|
"-----BEGIN OPENSSH PRIVATE KEY-----",
|
|
"b3BlbnNzaC1rZXktdjEAAAAABG5vbmUAAAAEbm9uZQAAAAAAAAABAAAAMwAAAAtzc2gt",
|
|
"ZWQyNTUxOQAAACBPzMxQp4Y6XCfDV2t6oWmqHkKx0K7C7w7q9F6gQ3jPbgAAAJjJ8jjE",
|
|
"yfI4xAAAAAtzc2gtZWQyNTUxOQAAACBPzMxQp4Y6XCfDV2t6oWmqHkKx0K7C7w7q9F6g",
|
|
"Q3jPbgAAAEDqLhB4kV1tw8m4gE9oNCkF2cJv0YnHQ8E5sHU3xKnD5k/MzFCnhjpcJ8NX",
|
|
"a3qhaaoeQrHQrsLvDur0XqBDeM9uAAAAFXVzZXJAaG9zdAECAwQ=",
|
|
"-----END OPENSSH PRIVATE KEY-----",
|
|
].join("\n");
|
|
const VALID_RSA_PEM = [
|
|
"-----BEGIN RSA PRIVATE KEY-----",
|
|
"MIIBOgIBAAJBAKj34GkxFhD90vcNLYLInFEX6Ppy1tPf9Cnzj4p4WGeKLs1Pt8Qu",
|
|
"KUpRKfFLfRYC9AIKjbJTWit+CqvjWYzvQwECAwEAAQJAIJLixBy2qpFoS4DSmoEm",
|
|
"o3qGy0t6z5tZbcgvflRslzu1HxXLpwYqQq2gMNw9UQAoHs3rDl+EzBjF6trBV5wF",
|
|
"wQIhANwiwDR7TVlIRk5kbgPMd2dDgY8mAU1cQ8KbWvjVMmKxAiEAxYTUyVjwhfQy",
|
|
"VJoR7T0n4XdR1n+W8Eth7AEPxnHfaQECIB5cNuqB9F1qC2pSyf6e+UAyl9rmKQXp",
|
|
"-----END RSA PRIVATE KEY-----",
|
|
].join("\n");
|
|
|
|
it("accepts a valid OpenSSH PEM block", () => {
|
|
expect(validateSshPrivateKey(VALID_OPENSSH)).toBeNull();
|
|
});
|
|
|
|
it("accepts a valid PKCS#1 RSA PEM block", () => {
|
|
expect(validateSshPrivateKey(VALID_RSA_PEM)).toBeNull();
|
|
});
|
|
|
|
it("accepts UUID-like secret reference values from the save-time schema stage", async () => {
|
|
process.env.EXE_API_KEY = "host-key";
|
|
|
|
const result = await plugin.definition.onEnvironmentValidateConfig?.({
|
|
driverKey: "exe-dev",
|
|
config: {
|
|
apiKey: "api-key",
|
|
sshPrivateKey: "11111111-1111-4111-8111-111111111111",
|
|
},
|
|
});
|
|
|
|
expect(result).toMatchObject({
|
|
ok: true,
|
|
normalizedConfig: {
|
|
sshPrivateKey: "11111111-1111-4111-8111-111111111111",
|
|
},
|
|
});
|
|
expect(result?.errors ?? []).toEqual([]);
|
|
});
|
|
|
|
it("treats empty / whitespace-only input as valid (falls back to on-host key)", () => {
|
|
expect(validateSshPrivateKey("")).toBeNull();
|
|
expect(validateSshPrivateKey(" \n\n ")).toBeNull();
|
|
});
|
|
|
|
it("rejects a pasted public key", () => {
|
|
expect(
|
|
validateSshPrivateKey("ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAIE+gT9 user@host"),
|
|
).toMatch(/looks like a PUBLIC key/);
|
|
});
|
|
|
|
it("rejects a PuTTY PPK file paste", () => {
|
|
const ppk = [
|
|
"PuTTY-User-Key-File-3: ssh-ed25519",
|
|
"Encryption: none",
|
|
"Comment: imported-openssh-key",
|
|
"Public-Lines: 2",
|
|
"AAAAC3NzaC1lZDI1NTE5AAAAIE+gT9zMxQp4Y6XCfDV2t6oWmqHkKx0K7C7w7q9F6g",
|
|
"Q3jP",
|
|
].join("\n");
|
|
expect(validateSshPrivateKey(ppk)).toMatch(/PuTTY \.ppk/);
|
|
});
|
|
|
|
it("rejects a missing END marker (truncated paste)", () => {
|
|
const truncated = VALID_OPENSSH.split("\n").slice(0, -1).join("\n");
|
|
expect(validateSshPrivateKey(truncated)).toMatch(/missing its '-----END/);
|
|
});
|
|
|
|
it("rejects a body with non-base64 characters", () => {
|
|
const garbled = [
|
|
"-----BEGIN OPENSSH PRIVATE KEY-----",
|
|
"this is not base64!!",
|
|
"-----END OPENSSH PRIVATE KEY-----",
|
|
].join("\n");
|
|
expect(validateSshPrivateKey(garbled)).toMatch(/non-base64/);
|
|
});
|
|
|
|
it("rejects a header/footer label mismatch", () => {
|
|
const mismatched = [
|
|
"-----BEGIN OPENSSH PRIVATE KEY-----",
|
|
"Zm9vYmFy",
|
|
"-----END RSA PRIVATE KEY-----",
|
|
].join("\n");
|
|
expect(validateSshPrivateKey(mismatched)).toMatch(/header\/footer mismatch/);
|
|
});
|
|
|
|
it("returns the sshPrivateKey error from onEnvironmentValidateConfig on save", async () => {
|
|
process.env.EXE_API_KEY = "host-key";
|
|
|
|
const result = await plugin.definition.onEnvironmentValidateConfig?.({
|
|
driverKey: "exe-dev",
|
|
config: {
|
|
sshPrivateKey: "ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAIE+gT9 user@host",
|
|
},
|
|
});
|
|
|
|
expect(result?.ok).toBe(false);
|
|
expect(result?.errors ?? []).toEqual(
|
|
expect.arrayContaining([expect.stringMatching(/sshPrivateKey looks like a PUBLIC key/)]),
|
|
);
|
|
});
|
|
});
|
|
|
|
it("acquires a lease by creating a VM and preparing the SSH workspace", async () => {
|
|
fetchMock.mockResolvedValueOnce(
|
|
new Response(JSON.stringify({
|
|
vm_name: "paperclip-env-run",
|
|
ssh_dest: "paperclip-env-run.exe.xyz",
|
|
https_url: "https://paperclip-env-run.exe.xyz",
|
|
status: "running",
|
|
}), { status: 200 }),
|
|
);
|
|
queueSpawnResult({ stdout: "/home/exe\nbash\n" });
|
|
queueSpawnResult({});
|
|
|
|
const lease = await plugin.definition.onEnvironmentAcquireLease?.({
|
|
driverKey: "exe-dev",
|
|
companyId: "company-1",
|
|
environmentId: "env-1",
|
|
runId: "run-1",
|
|
requestedCwd: "/workspace/custom",
|
|
config: {
|
|
apiKey: "api-key",
|
|
namePrefix: "paperclip",
|
|
image: "ubuntu:22.04",
|
|
timeoutMs: 300000,
|
|
},
|
|
});
|
|
|
|
expect(fetchMock).toHaveBeenCalledTimes(1);
|
|
expect(String(fetchMock.mock.calls[0]?.[1]?.body ?? "")).toContain("new --json --no-email");
|
|
expect(spawnMock).toHaveBeenCalledTimes(2);
|
|
expect(lease).toMatchObject({
|
|
providerLeaseId: "paperclip-env-run",
|
|
metadata: {
|
|
provider: "exe-dev",
|
|
vmName: "paperclip-env-run",
|
|
sshDest: "paperclip-env-run.exe.xyz",
|
|
remoteCwd: "/workspace/custom",
|
|
shellCommand: "bash",
|
|
reuseLease: false,
|
|
},
|
|
});
|
|
});
|
|
|
|
it("uses a pasted sshPrivateKey when connecting to the VM", async () => {
|
|
fetchMock.mockResolvedValueOnce(
|
|
new Response(JSON.stringify({
|
|
vm_name: "paperclip-env-run",
|
|
ssh_dest: "paperclip-env-run.exe.xyz",
|
|
https_url: "https://paperclip-env-run.exe.xyz",
|
|
status: "running",
|
|
}), { status: 200 }),
|
|
);
|
|
queueSpawnResult({ stdout: "/home/exe\nbash\n" });
|
|
queueSpawnResult({});
|
|
|
|
await plugin.definition.onEnvironmentAcquireLease?.({
|
|
driverKey: "exe-dev",
|
|
companyId: "company-1",
|
|
environmentId: "env-1",
|
|
runId: "run-1",
|
|
config: {
|
|
apiKey: "api-key",
|
|
sshPrivateKey: "-----BEGIN PRIVATE KEY-----\npretend\n-----END PRIVATE KEY-----",
|
|
},
|
|
});
|
|
|
|
const firstSpawnArgs = spawnMock.mock.calls[0]?.[1] as string[] | undefined;
|
|
expect(firstSpawnArgs).toContain("-i");
|
|
expect(firstSpawnArgs).toContain("-o");
|
|
expect(firstSpawnArgs).toContain("IdentitiesOnly=yes");
|
|
});
|
|
|
|
it("supplies a default Node-install setup script when none is provided", async () => {
|
|
fetchMock.mockResolvedValueOnce(
|
|
new Response(JSON.stringify({
|
|
vm_name: "paperclip-env-run",
|
|
ssh_dest: "paperclip-env-run.exe.xyz",
|
|
https_url: "https://paperclip-env-run.exe.xyz",
|
|
status: "running",
|
|
}), { status: 200 }),
|
|
);
|
|
queueSpawnResult({ stdout: "/home/exedev\nbash\n" });
|
|
queueSpawnResult({});
|
|
|
|
await plugin.definition.onEnvironmentAcquireLease?.({
|
|
driverKey: "exe-dev",
|
|
companyId: "company-1",
|
|
environmentId: "env-1",
|
|
runId: "run-1",
|
|
config: {
|
|
apiKey: "api-key",
|
|
},
|
|
});
|
|
|
|
const body = String(fetchMock.mock.calls[0]?.[1]?.body ?? "");
|
|
expect(body).toContain("--setup-script=");
|
|
expect(body).toContain("process.versions.node");
|
|
expect(body).toContain("v[0]>24||(v[0]===24&&v[1]>=11)");
|
|
expect(body).toContain("nodesource.com/setup_24.x");
|
|
expect(body).toContain("sudo apt-get install -y nodejs");
|
|
});
|
|
|
|
it("preserves an operator-supplied setup script and does not append the default", async () => {
|
|
fetchMock.mockResolvedValueOnce(
|
|
new Response(JSON.stringify({
|
|
vm_name: "paperclip-env-run",
|
|
ssh_dest: "paperclip-env-run.exe.xyz",
|
|
https_url: "https://paperclip-env-run.exe.xyz",
|
|
status: "running",
|
|
}), { status: 200 }),
|
|
);
|
|
queueSpawnResult({ stdout: "/home/exedev\nbash\n" });
|
|
queueSpawnResult({});
|
|
|
|
await plugin.definition.onEnvironmentAcquireLease?.({
|
|
driverKey: "exe-dev",
|
|
companyId: "company-1",
|
|
environmentId: "env-1",
|
|
runId: "run-1",
|
|
config: {
|
|
apiKey: "api-key",
|
|
setupScript: "echo custom",
|
|
},
|
|
});
|
|
|
|
const body = String(fetchMock.mock.calls[0]?.[1]?.body ?? "");
|
|
expect(body).toContain("--setup-script='echo custom'");
|
|
expect(body).not.toContain("nodesource.com");
|
|
});
|
|
|
|
it("does not redact the built-in default setup script in API errors", async () => {
|
|
fetchMock.mockResolvedValueOnce(new Response("upstream boom", { status: 500 }));
|
|
|
|
const acquirePromise = plugin.definition.onEnvironmentAcquireLease?.({
|
|
driverKey: "exe-dev",
|
|
companyId: "company-1",
|
|
environmentId: "env-1",
|
|
runId: "run-1",
|
|
config: {
|
|
apiKey: "api-key",
|
|
},
|
|
});
|
|
|
|
await expect(acquirePromise).rejects.toMatchObject({
|
|
name: "ExeDevApiError",
|
|
status: 500,
|
|
});
|
|
|
|
await acquirePromise?.catch((error: Error) => {
|
|
// Operator did not supply a setupScript, so the visible default install
|
|
// is not a secret and stays in the error for debuggability.
|
|
expect(error.message).toContain("nodesource.com/setup_24.x");
|
|
expect(error.message).not.toContain("[REDACTED]");
|
|
});
|
|
});
|
|
|
|
it("surfaces exe.dev SSH onboarding guidance during lease acquisition", async () => {
|
|
fetchMock.mockResolvedValueOnce(
|
|
new Response(JSON.stringify({
|
|
vm_name: "paperclip-env-run",
|
|
ssh_dest: "paperclip-env-run.exe.xyz",
|
|
https_url: "https://paperclip-env-run.exe.xyz",
|
|
status: "running",
|
|
}), { status: 200 }),
|
|
);
|
|
fetchMock.mockResolvedValueOnce(new Response("{}", { status: 200 }));
|
|
queueSpawnResult({ code: 1, stdout: "Please complete registration by running: ssh exe.dev\n" });
|
|
|
|
await expect(plugin.definition.onEnvironmentAcquireLease?.({
|
|
driverKey: "exe-dev",
|
|
companyId: "company-1",
|
|
environmentId: "env-1",
|
|
runId: "run-1",
|
|
config: {
|
|
apiKey: "api-key",
|
|
timeoutMs: 300000,
|
|
},
|
|
})).rejects.toThrow(
|
|
"the Paperclip host SSH key is not registered with exe.dev",
|
|
);
|
|
|
|
expect(String(fetchMock.mock.calls[1]?.[1]?.body ?? "")).toBe("rm --json 'paperclip-env-run'");
|
|
});
|
|
|
|
it("surfaces invalid SSH key-format guidance during lease acquisition", async () => {
|
|
fetchMock.mockResolvedValueOnce(
|
|
new Response(JSON.stringify({
|
|
vm_name: "paperclip-env-run",
|
|
ssh_dest: "paperclip-env-run.exe.xyz",
|
|
https_url: "https://paperclip-env-run.exe.xyz",
|
|
status: "running",
|
|
}), { status: 200 }),
|
|
);
|
|
fetchMock.mockResolvedValueOnce(new Response("{}", { status: 200 }));
|
|
queueSpawnResult({
|
|
code: 255,
|
|
stderr: 'Load key "/tmp/paperclip-exe-dev-ssh-abc/id_ed25519": invalid format\n',
|
|
});
|
|
|
|
await expect(plugin.definition.onEnvironmentAcquireLease?.({
|
|
driverKey: "exe-dev",
|
|
companyId: "company-1",
|
|
environmentId: "env-1",
|
|
runId: "run-1",
|
|
config: {
|
|
apiKey: "api-key",
|
|
sshPrivateKey: "not-actually-a-key",
|
|
timeoutMs: 300000,
|
|
},
|
|
})).rejects.toThrow(
|
|
"the configured SSH private key isn't an OpenSSH-format private key",
|
|
);
|
|
|
|
expect(String(fetchMock.mock.calls[1]?.[1]?.body ?? "")).toBe("rm --json 'paperclip-env-run'");
|
|
});
|
|
|
|
it("redacts sensitive lifecycle flags in API errors", async () => {
|
|
fetchMock.mockResolvedValueOnce(new Response("upstream boom", { status: 500 }));
|
|
|
|
const acquirePromise = plugin.definition.onEnvironmentAcquireLease?.({
|
|
driverKey: "exe-dev",
|
|
companyId: "company-1",
|
|
environmentId: "env-1",
|
|
runId: "run-1",
|
|
config: {
|
|
apiKey: "api-key",
|
|
env: {
|
|
SECRET: "super-secret",
|
|
},
|
|
prompt: "build me a secret app",
|
|
setupScript: "export TOKEN=super-secret",
|
|
},
|
|
});
|
|
|
|
await expect(acquirePromise).rejects.toMatchObject({
|
|
name: "ExeDevApiError",
|
|
status: 500,
|
|
body: "upstream boom",
|
|
});
|
|
|
|
await acquirePromise?.catch((error: Error) => {
|
|
expect(error.message).toContain("--env='SECRET=[REDACTED]'");
|
|
expect(error.message).toContain("--prompt='[REDACTED]'");
|
|
expect(error.message).toContain("--setup-script='[REDACTED]'");
|
|
expect(error.message).not.toContain("super-secret");
|
|
});
|
|
});
|
|
|
|
it("returns an expired lease when the retained VM no longer exists", async () => {
|
|
fetchMock.mockResolvedValueOnce(
|
|
new Response(JSON.stringify({ vms: [] }), { status: 200 }),
|
|
);
|
|
|
|
const lease = await plugin.definition.onEnvironmentResumeLease?.({
|
|
driverKey: "exe-dev",
|
|
companyId: "company-1",
|
|
environmentId: "env-1",
|
|
providerLeaseId: "missing-vm",
|
|
config: {
|
|
apiKey: "api-key",
|
|
},
|
|
leaseMetadata: {
|
|
sshDest: "missing-vm.exe.xyz",
|
|
},
|
|
});
|
|
|
|
expect(lease).toEqual({
|
|
providerLeaseId: null,
|
|
metadata: {
|
|
expired: true,
|
|
},
|
|
});
|
|
});
|
|
|
|
it("executes commands over SSH with cwd, env, and stdin", async () => {
|
|
queueSpawnResult({ code: 0, stdout: "hello\n", stderr: "" });
|
|
|
|
const result = await plugin.definition.onEnvironmentExecute?.({
|
|
driverKey: "exe-dev",
|
|
companyId: "company-1",
|
|
environmentId: "env-1",
|
|
config: {
|
|
apiKey: "api-key",
|
|
timeoutMs: 300000,
|
|
},
|
|
lease: {
|
|
providerLeaseId: "vm-1",
|
|
metadata: {
|
|
sshDest: "vm-1.exe.xyz",
|
|
},
|
|
},
|
|
command: "node",
|
|
args: ["-e", "process.stdout.write('hello\\n')"],
|
|
cwd: "/workspace",
|
|
env: {
|
|
FOO: "bar",
|
|
},
|
|
stdin: "input-body",
|
|
timeoutMs: 1000,
|
|
});
|
|
|
|
expect(spawnMock).toHaveBeenCalledTimes(1);
|
|
expect(spawnMock.mock.calls[0]?.[0]).toBe("ssh");
|
|
const remoteScript = String(spawnMock.mock.calls[0]?.[1]?.at(-1) ?? "");
|
|
expect(remoteScript).toContain("/workspace");
|
|
expect(remoteScript).toContain("FOO='");
|
|
// The wrapper sources no `nvm.sh`; the sandbox image supplies node on PATH.
|
|
expect(remoteScript).not.toContain("nvm.sh");
|
|
expect(remoteScript).not.toContain("NVM_DIR");
|
|
const child = spawnMock.mock.results[0]?.value as MockChildProcess;
|
|
expect(child.stdin.written).toBe("input-body");
|
|
expect(child.stdin.ended).toBe(true);
|
|
expect(result).toMatchObject({
|
|
exitCode: 0,
|
|
timedOut: false,
|
|
stdout: "hello\n",
|
|
stderr: "",
|
|
metadata: {
|
|
provider: "exe-dev",
|
|
vmName: "vm-1",
|
|
},
|
|
});
|
|
});
|
|
|
|
it("returns exe.dev SSH onboarding guidance for command execution failures", async () => {
|
|
queueSpawnResult({ code: 1, stdout: "Please complete registration by running: ssh exe.dev\n" });
|
|
|
|
const result = await plugin.definition.onEnvironmentExecute?.({
|
|
driverKey: "exe-dev",
|
|
companyId: "company-1",
|
|
environmentId: "env-1",
|
|
config: {
|
|
apiKey: "api-key",
|
|
timeoutMs: 300000,
|
|
},
|
|
lease: {
|
|
providerLeaseId: "vm-1",
|
|
metadata: {
|
|
sshDest: "vm-1.exe.xyz",
|
|
},
|
|
},
|
|
command: "node",
|
|
args: ["-v"],
|
|
});
|
|
|
|
expect(result?.exitCode).toBe(1);
|
|
expect(String(result?.stderr ?? "")).toContain("the Paperclip host SSH key is not registered with exe.dev");
|
|
expect(String(result?.stderr ?? "")).toContain("ssh exe.dev");
|
|
});
|
|
|
|
it("probes by creating and then deleting a VM after SSH verification", async () => {
|
|
fetchMock
|
|
.mockResolvedValueOnce(
|
|
new Response(JSON.stringify({
|
|
vm_name: "paperclip-probe",
|
|
ssh_dest: "paperclip-probe.exe.xyz",
|
|
status: "running",
|
|
}), { status: 200 }),
|
|
)
|
|
.mockResolvedValueOnce(new Response("{}", { status: 200 }));
|
|
queueSpawnResult({ stdout: "/home/exe\nbash\n" });
|
|
queueSpawnResult({});
|
|
|
|
const result = await plugin.definition.onEnvironmentProbe?.({
|
|
driverKey: "exe-dev",
|
|
companyId: "company-1",
|
|
environmentId: "env-1",
|
|
config: {
|
|
apiKey: "api-key",
|
|
},
|
|
});
|
|
|
|
expect(result).toMatchObject({
|
|
ok: true,
|
|
summary: "Connected to exe.dev VM paperclip-probe.",
|
|
metadata: {
|
|
provider: "exe-dev",
|
|
vmName: "paperclip-probe",
|
|
sshDest: "paperclip-probe.exe.xyz",
|
|
shellCommand: "bash",
|
|
},
|
|
});
|
|
expect(String(fetchMock.mock.calls[1]?.[1]?.body ?? "")).toBe("rm --json 'paperclip-probe'");
|
|
});
|
|
|
|
it("cleans up the probe VM when SSH verification fails", async () => {
|
|
fetchMock
|
|
.mockResolvedValueOnce(
|
|
new Response(JSON.stringify({
|
|
vm_name: "paperclip-probe",
|
|
ssh_dest: "paperclip-probe.exe.xyz",
|
|
status: "running",
|
|
}), { status: 200 }),
|
|
)
|
|
.mockResolvedValueOnce(new Response("{}", { status: 200 }));
|
|
queueSpawnResult({ code: 1, stderr: "permission denied" });
|
|
|
|
const result = await plugin.definition.onEnvironmentProbe?.({
|
|
driverKey: "exe-dev",
|
|
companyId: "company-1",
|
|
environmentId: "env-1",
|
|
config: {
|
|
apiKey: "api-key",
|
|
},
|
|
});
|
|
|
|
expect(result).toMatchObject({
|
|
ok: false,
|
|
summary: "exe.dev environment probe failed.",
|
|
metadata: {
|
|
provider: "exe-dev",
|
|
},
|
|
});
|
|
expect(String(result?.metadata?.error ?? "")).toContain("permission denied");
|
|
expect(String(fetchMock.mock.calls[1]?.[1]?.body ?? "")).toBe("rm --json 'paperclip-probe'");
|
|
});
|
|
|
|
it("returns onboarding guidance when probe hits exe.dev SSH registration", async () => {
|
|
fetchMock
|
|
.mockResolvedValueOnce(
|
|
new Response(JSON.stringify({
|
|
vm_name: "paperclip-probe",
|
|
ssh_dest: "paperclip-probe.exe.xyz",
|
|
status: "running",
|
|
}), { status: 200 }),
|
|
)
|
|
.mockResolvedValueOnce(new Response("{}", { status: 200 }));
|
|
queueSpawnResult({ code: 1, stdout: "Please complete registration by running: ssh exe.dev\n" });
|
|
|
|
const result = await plugin.definition.onEnvironmentProbe?.({
|
|
driverKey: "exe-dev",
|
|
companyId: "company-1",
|
|
environmentId: "env-1",
|
|
config: {
|
|
apiKey: "api-key",
|
|
},
|
|
});
|
|
|
|
expect(result).toMatchObject({
|
|
ok: false,
|
|
summary: "exe.dev environment probe failed.",
|
|
});
|
|
expect(String(result?.metadata?.error ?? "")).toContain("the Paperclip host SSH key is not registered with exe.dev");
|
|
expect(String(fetchMock.mock.calls[1]?.[1]?.body ?? "")).toBe("rm --json 'paperclip-probe'");
|
|
});
|
|
|
|
it("deletes non-reusable leases on release", async () => {
|
|
fetchMock.mockResolvedValueOnce(new Response("{}", { status: 200 }));
|
|
|
|
await plugin.definition.onEnvironmentReleaseLease?.({
|
|
driverKey: "exe-dev",
|
|
companyId: "company-1",
|
|
environmentId: "env-1",
|
|
providerLeaseId: "vm-1",
|
|
config: {
|
|
apiKey: "api-key",
|
|
reuseLease: false,
|
|
},
|
|
leaseMetadata: {},
|
|
});
|
|
|
|
expect(String(fetchMock.mock.calls[0]?.[1]?.body ?? "")).toBe("rm --json 'vm-1'");
|
|
});
|
|
|
|
it("destroys leases on demand", async () => {
|
|
fetchMock.mockResolvedValueOnce(new Response("{}", { status: 200 }));
|
|
|
|
await plugin.definition.onEnvironmentDestroyLease?.({
|
|
driverKey: "exe-dev",
|
|
companyId: "company-1",
|
|
environmentId: "env-1",
|
|
providerLeaseId: "vm-2",
|
|
config: {
|
|
apiKey: "api-key",
|
|
},
|
|
leaseMetadata: {},
|
|
});
|
|
|
|
expect(String(fetchMock.mock.calls[0]?.[1]?.body ?? "")).toBe("rm --json 'vm-2'");
|
|
});
|
|
|
|
it("realizes a workspace by mkdir-ing the remote cwd over SSH when VM metadata is present", async () => {
|
|
queueSpawnResult({ code: 0, stdout: "", stderr: "" });
|
|
|
|
const result = await plugin.definition.onEnvironmentRealizeWorkspace?.({
|
|
driverKey: "exe-dev",
|
|
companyId: "company-1",
|
|
environmentId: "env-1",
|
|
config: {
|
|
apiKey: "api-key",
|
|
timeoutMs: 300000,
|
|
},
|
|
lease: {
|
|
providerLeaseId: "vm-1",
|
|
metadata: {
|
|
sshDest: "vm-1.exe.xyz",
|
|
remoteCwd: "/srv/paperclip/run-1",
|
|
},
|
|
},
|
|
workspace: {
|
|
localPath: "/local/paperclip",
|
|
remotePath: undefined,
|
|
},
|
|
});
|
|
|
|
expect(spawnMock).toHaveBeenCalledTimes(1);
|
|
expect(spawnMock.mock.calls[0]?.[0]).toBe("ssh");
|
|
const sshCommand = String(spawnMock.mock.calls[0]?.[1]?.at(-1) ?? "");
|
|
expect(sshCommand).toContain("mkdir -p");
|
|
expect(sshCommand).toContain("/srv/paperclip/run-1");
|
|
expect(result).toMatchObject({
|
|
cwd: "/srv/paperclip/run-1",
|
|
metadata: {
|
|
provider: "exe-dev",
|
|
remoteCwd: "/srv/paperclip/run-1",
|
|
},
|
|
});
|
|
});
|
|
|
|
it("falls back through workspace.remotePath then workspace.localPath when lease.metadata.remoteCwd is missing", async () => {
|
|
queueSpawnResult({ code: 0, stdout: "", stderr: "" });
|
|
|
|
const result = await plugin.definition.onEnvironmentRealizeWorkspace?.({
|
|
driverKey: "exe-dev",
|
|
companyId: "company-1",
|
|
environmentId: "env-1",
|
|
config: {
|
|
apiKey: "api-key",
|
|
timeoutMs: 300000,
|
|
},
|
|
lease: {
|
|
providerLeaseId: "vm-1",
|
|
metadata: {
|
|
sshDest: "vm-1.exe.xyz",
|
|
},
|
|
},
|
|
workspace: {
|
|
localPath: "/local/paperclip",
|
|
remotePath: "/srv/paperclip/remote-fallback",
|
|
},
|
|
});
|
|
|
|
expect(result?.cwd).toBe("/srv/paperclip/remote-fallback");
|
|
});
|
|
|
|
it("skips ensureRemoteWorkspace and returns the resolved cwd when no VM metadata is available", async () => {
|
|
const result = await plugin.definition.onEnvironmentRealizeWorkspace?.({
|
|
driverKey: "exe-dev",
|
|
companyId: "company-1",
|
|
environmentId: "env-1",
|
|
config: {
|
|
apiKey: "api-key",
|
|
timeoutMs: 300000,
|
|
},
|
|
lease: {
|
|
providerLeaseId: null,
|
|
metadata: {
|
|
remoteCwd: "/srv/paperclip/no-vm",
|
|
},
|
|
},
|
|
workspace: {
|
|
localPath: "/local/paperclip",
|
|
},
|
|
});
|
|
|
|
expect(spawnMock).not.toHaveBeenCalled();
|
|
expect(result?.cwd).toBe("/srv/paperclip/no-vm");
|
|
});
|
|
});
|
|
|
|
describe("exe-dev manifest form defaults", () => {
|
|
const configSchema = (
|
|
manifest.environmentDrivers?.[0]?.configSchema as {
|
|
properties?: Record<string, { format?: string; default?: unknown }>;
|
|
}
|
|
);
|
|
const properties = configSchema.properties ?? {};
|
|
|
|
it("pre-fills VM sizing for the environment form", () => {
|
|
expect(properties.cpu?.default).toBe(4);
|
|
expect(properties.memory?.default).toBe("4GB");
|
|
expect(properties.disk?.default).toBe("20GB");
|
|
});
|
|
|
|
it("declares no default on secret-ref fields, which would be persisted as a company secret", () => {
|
|
for (const prop of Object.values(properties)) {
|
|
if (prop.format === "secret-ref") {
|
|
expect(prop.default).toBeUndefined();
|
|
}
|
|
}
|
|
});
|
|
});
|