Files
PaperClipAI/tests/runner-e2e/scheduled-operations.test.ts
T
DottaandPaperclip ed3f067dbd fix(evals): select operating allowance by cadence (#17326)
## Thinking Path

> - Paperclip manages AI agents and their operating budgets.
> - Product E2E runs exercise real agents through a bounded gateway.
> - The daily and weekly selections share one repository configuration
variable.
> - Their different request limits need different operating allowances.
> - The existing parser accepts only one allowance, which cannot
represent both reviewed limits.
> - This change selects the allowance for the actual cadence and retains
all existing validation.

## Linked Issues or Issue Description

Refs #17009.

**What happened?**

The daily selection needs an $11 operating reservation; the weekly
selection needs $21. A shared $21 allowance cannot fit the $20 daily
cap. A shared $11 allowance does not cover the reviewed weekly resource
bound. A configuration containing both allowances was rejected before
paid admission.

**Expected behavior**

Each cadence uses its own reviewed allowance. Missing or malformed
selected allowances stop admission before paid work.

**Steps to reproduce**

Set the operating allowance JSON to an object with daily and weekly
allowances. Prepare either campaign through prepareScheduledCampaign.
Before this change, both calls reject the outer object.

**Paperclip version or commit**

3bd709df8b.

## What Changed

- Accept daily and weekly allowance entries in the existing
configuration variable.
- Select the actual cadence before validating its budget, runner and
expiration.
- Pass only the selected allowance through the existing workflow output.
- Preserve single-allowance compatibility and document the configuration
format.

## Verification

- Reproduced both cadence failures before the fix: 2 failed, 12 passed.
- Focused scheduled operations and operating overhead tests: 20 passed.
- Eval TypeScript check passed.
- Missing selected entries and unknown outer fields fail before creating
a manifest.
- Hosted CI passed at 1c62cc8aeb,
including full typecheck, tests, build and browser shards.
- Greptile and Paperclip reviews both rated the exact commit 5/5 with no
actionable findings.

## Risks

- A map with a missing selected cadence now fails admission. It never
substitutes the other cadence.
- Operators must still provide reviewed rates and resource bounds. This
parser does not prove actual charges.
- This PR does not change limits, credentials, workflow permissions or
enable gates.

## Model Used

- OpenAI GPT-6 in Codex, with reasoning, repository inspection, code
execution and test tools. The exact backend model identifier and
context-window size are not exposed in this session.

## Checklist

- [x] I have included a thinking path that traces from project context
to this change
- [x] I have specified the model used (with version and capability
details)
- [x] I have checked ROADMAP.md and confirmed this PR does not duplicate
planned core work
- [x] I have searched GitHub for duplicate or related PRs and linked
them above
- [x] I have either (a) linked existing issues with `Fixes: #` / `Closes
#` / `Refs #` OR (b) described the issue in-PR following the relevant
issue template
- [x] I have not referenced internal/instance-local Paperclip issues or
links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip`
URLs)
- [x] My branch name describes the change (e.g. `docs/...`, `fix/...`)
and contains no internal Paperclip ticket id or instance-derived details
- [x] I have run tests locally and they pass
- [x] I have added or updated tests where applicable
- [x] I have updated relevant documentation to reflect my changes
- [x] I have considered and documented any risks above
- [x] All Paperclip CI gates are green
- [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups
- [x] I will address all Greptile and reviewer comments before
requesting merge

Co-authored-by: Paperclip <noreply@paperclip.ing>
2026-10-23 07:52:41 -07:00

101 lines
7.0 KiB
TypeScript

import { mkdtemp, readFile, rm } from "node:fs/promises";
import { tmpdir } from "node:os";
import path from "node:path";
import { expect, it } from "vitest";
import { prepareScheduledCampaign, scheduledCadence, scheduledManifest, scheduledMatrix, scheduledSelection, validateScheduledBudget } from "./scheduled-operations.js";
import { parseRunnerSelectors, selectRunnerExecutions } from "./selectors.js";
import { runnerMatrix } from "./catalog.js";
import { evalRequestReservation } from "./eval-gateway.js";
import { EVAL_OVERHEAD_COMPONENTS, type EvalOperatingOverhead } from "./operating-overhead.js";
const overhead: EvalOperatingOverhead = { version: 1, reference: "fixture-only", runner: "github-hosted",
verifiedAt: "2026-10-20T00:00:00Z", expiresAt: "2026-11-19T00:00:00Z",
components: EVAL_OVERHEAD_COMPONENTS.map(component => ({ component, maxUsd: "1", reference: `fixture-${component}` })) };
const input = { cadence: "daily" as const, campaignId: "scheduled-fixture", ledgerPath: "/tmp/scheduled-fixture/ledger.jsonl",
projectId: "11111111-1111-4111-8111-111111111111", now: Date.parse("2026-10-21T00:00:00Z"), runAttempt: "1", overhead };
it.each(["daily", "weekly"] as const)("runs the exact %s selection through one shared budget and catalog job", cadence => {
const manifest = scheduledManifest({ ...input, cadence });
const selected = selectRunnerExecutions(parseRunnerSelectors(manifest.executionIds.flatMap(id => ["--id", id])), runnerMatrix);
expect(selected.map(row => row.id).sort()).toEqual([...scheduledSelection(cadence)].sort());
expect(manifest.limits).toMatchObject({ maxUsd: cadence === "daily" ? "20" : "100", maxConcurrent: 1, maxAttemptsPerExecution: 1 });
expect(Date.parse(manifest.limits.deadlineAt) - input.now).toBe(30 * 60_000);
expect(scheduledMatrix(cadence).include).toHaveLength(1);
expect(manifest.executionIds).toHaveLength(cadence === "daily" ? 2 : 4);
expect(manifest.models.every(model => Number(evalRequestReservation({ ...model, mode: "braintrust", apiKey: "fixture" })) <= Number(manifest.limits.maxUsd))).toBe(true);
});
it("does not reduce Codex's verified context ceiling to fit the daily allowance", () => {
const codex = scheduledManifest({ ...input, cadence: "weekly" }).models.find(row => row.provider === "openai")!;
expect(codex.maximumInputTokens).toBe(1_050_000);
expect(Number(evalRequestReservation({ ...codex, mode: "braintrust", apiKey: "fixture" }))).toBeGreaterThan(20);
expect(scheduledManifest(input).models.map(model => model.provider)).toEqual(["anthropic"]);
});
it.each(["2", "0", "", "01"])("refuses workflow attempt %s before creating a fresh allowance", runAttempt => {
expect(() => scheduledManifest({ ...input, runAttempt })).toThrow("fresh allowance");
});
it.each(["2026-10-19T23:59:59Z", "2026-11-19T00:00:00Z"])("rejects pricing outside its reviewed window at %s", time => {
expect(() => scheduledManifest({ ...input, now: Date.parse(time) })).toThrow("pricing needs review");
});
it("rejects unknown triggers and maps the reviewed schedule expressions", () => {
expect(scheduledCadence("schedule", "47 8 * * *")).toBe("daily");
expect(scheduledCadence("schedule", "47 9 * * 0")).toBe("weekly");
expect(scheduledCadence("workflow_dispatch", "", "manual")).toBeUndefined();
expect(() => scheduledCadence("schedule", "* * * * *")).toThrow();
expect(() => scheduledCadence("pull_request", "", "daily")).toThrow();
});
it("fails closed before paid work if disabled, missing project identity, or preflight is repeated", async () => {
const directory = await mkdtemp(path.join(tmpdir(), "eval-schedule-"));
const env = { EVAL_EVENT: "schedule", EVAL_SCHEDULE: "47 8 * * *", EVAL_OPERATIONS_ENABLED: "true",
GITHUB_RUN_ID: "123", GITHUB_RUN_ATTEMPT: "1", GITHUB_WORKSPACE: directory,
EVAL_OPERATING_OVERHEAD_JSON: JSON.stringify(overhead), EVAL_TEST_RUNNER: "ubuntu-latest",
PAPERCLIP_E2E_BRAINTRUST_PROJECT_ID: input.projectId };
try {
await expect(prepareScheduledCampaign({ ...env, EVAL_OPERATIONS_ENABLED: "false" }, input.now)).rejects.toThrow("not enabled");
await expect(prepareScheduledCampaign({ ...env, EVAL_OPERATING_OVERHEAD_JSON: "" }, input.now)).rejects.toThrow("Missing reviewed");
await expect(prepareScheduledCampaign({ ...env, PAPERCLIP_E2E_BRAINTRUST_PROJECT_ID: "" }, input.now)).rejects.toThrow("UUID");
const prepared = await prepareScheduledCampaign(env, input.now);
expect(prepared.manifest.limits.campaignId).toBe(prepared.campaignId);
const forecast = JSON.parse(await readFile(path.join(path.dirname(prepared.manifestPath), "forecast.json"), "utf8"));
expect(forecast.measurements.historicalSuccessfulSelection).toEqual({ modelUsd: "0.427624800", summedAttemptMs: 72757 });
expect(forecast.measurements.hostedAttemptMs).toBeNull();
expect(forecast.maxUsd).toBe("20");
await expect(prepareScheduledCampaign(env, input.now)).rejects.toThrow("EEXIST");
} finally { await rm(directory, { recursive: true, force: true }); }
});
it("rejects an overhead allowance that cannot leave room for a full selected request before emitting the matrix", () => {
const expensive = structuredClone(overhead);
expensive.components[0]!.maxUsd = "13";
expect(() => validateScheduledBudget({ ...input, overhead: expensive })).toThrow("insufficient allowance");
expect(validateScheduledBudget({ ...input, overhead })).toMatchObject({ executionIds: scheduledSelection("daily") });
});
it.each(["daily", "weekly"] as const)("prepares %s with its own reviewed operating allowance", async cadence => {
const directory = await mkdtemp(path.join(tmpdir(), "eval-cadence-overhead-"));
const allowance = (value: string): EvalOperatingOverhead => ({ ...overhead, reference: `fixture-${value}`,
components: overhead.components.map(component => ({ ...component,
maxUsd: component.component === "observability" ? value : component.component === "artifact_storage" ? "1" : "0" })) });
const allowances = { daily: allowance("10"), weekly: allowance("20") };
const env = { EVAL_EVENT: "workflow_dispatch", EVAL_CADENCE: cadence, EVAL_OPERATIONS_ENABLED: "true",
GITHUB_RUN_ID: "123", GITHUB_RUN_ATTEMPT: "1", GITHUB_WORKSPACE: directory,
EVAL_OPERATING_OVERHEAD_JSON: JSON.stringify(allowances), EVAL_TEST_RUNNER: "ubuntu-latest",
PAPERCLIP_E2E_BRAINTRUST_PROJECT_ID: input.projectId };
try {
await expect(prepareScheduledCampaign({ ...env,
EVAL_OPERATING_OVERHEAD_JSON: JSON.stringify({ ...allowances, [cadence]: undefined }) }, input.now)).rejects.toThrow();
await expect(prepareScheduledCampaign({ ...env,
EVAL_OPERATING_OVERHEAD_JSON: JSON.stringify({ ...allowances, typo: allowances.daily }) }, input.now)).rejects.toThrow();
const prepared = await prepareScheduledCampaign(env, input.now);
expect(prepared.manifest.limits.overhead).toEqual(allowances[cadence]);
expect(prepared.manifest.limits.maxUsd).toBe(cadence === "daily" ? "20" : "100");
expect(prepared.manifest.executionIds).toEqual(scheduledSelection(cadence));
} finally { await rm(directory, { recursive: true, force: true }); }
});