mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-21 08:22:20 +02:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work > - An instance can turn on the `enableManagedSandboxOnly` feature, which hides the local environment and runs every agent in the platform-managed environment > - That feature already gated the environment pickers, the onboarding wizard, and the server-side run selection, but many other screens still showed absolute paths on the execution host and still let the user pick an execution engine > - On such an instance those controls name a filesystem the user cannot reach; a path written there is stored and then ignored, which reads as a broken control > - This pull request hides the remaining host-path and execution-engine surfaces behind the same feature, adds a server rule that refuses a project-workspace path write while the feature is on, and closes a related route gap in the isolated-workspace pages > - The benefit is that a managed instance shows no host path and no folder picker anywhere, and a write that carries a path now fails with a clear message instead of being silently discarded ## Linked Issues or Issue Description No public issue exists. The description below follows `.github/ISSUE_TEMPLATE/enhancement.yml`. **What existing behavior does this improve?** The `enableManagedSandboxOnly` instance feature, and the UI surfaces that show a host filesystem path: project properties, the new-project dialog, the project workspace and execution workspace detail pages, the workspace and task cards, plugin local folders, and the agent configuration form with its per-adapter fields. It also improves route gating for `enableIsolatedWorkspaces`. **Subsystem affected** Cross-cutting (`ui/` and `server/`). **Current behavior** When `enableManagedSandboxOnly` is on, the local environment disappears from the environment pickers and the server refuses to run an agent on the local host. Everything else stays visible. A user still sees: - the project "Local folder" row, its absolute path, and the Set/Change/Clear buttons - the "Local folder" field and its "Choose" folder picker in the new-project dialog - the "Local path" field and fact row on a project workspace - the "Paths" and "Lifecycle commands" groups on an execution workspace - the working directory on workspace cards, task properties, and runtime service rows - the plugin "Local folders" section - "Working directory (deprecated)", "Command", "Execution engine", "ACP server command", "ACP state directory", and "Agent instructions file" in the agent configuration form A path typed into any of these names a filesystem no agent on the instance uses. The project workspace API also accepts a `cwd` write and stores it. Separately, `/workspaces`, `/execution-workspaces/*`, and `/projects/:projectId/workspaces/:workspaceId` render for anyone who types or bookmarks the URL, even with `enableIsolatedWorkspaces` off. Only the sidebar entry reads that flag. **Proposed behavior** With `enableManagedSandboxOnly` on, none of those surfaces render. A project whose codebase came from a managed checkout keeps its one-line "Paperclip-managed folder." label and shows no path. The non-path controls stay: repo URL, branch, service URL, port, command output, ACP session mode, ACP non-interactive permissions, Codex fast mode, and the sandbox toggles. The project-workspace create and patch routes, and the nested workspace on project create, answer `422` with "This instance runs agents only in the platform-managed environment; local folders are not configurable." when the payload carries a non-null `cwd`. A `cwd: null` write still passes, so an instance that just turned the feature on can clear a stale path. With `enableIsolatedWorkspaces` off, the three workspace route groups redirect to the dashboard. **Reason and benefit** A control that cannot do anything is worse than a missing control: the user fills it in, saves, and gets no error and no effect. The server rule turns that silent no-op into a clear refusal. The route gate stops a feature that an instance has turned off from staying reachable by URL, which is the same standard the Cases, Pipelines, and hidden-settings pages already meet. **Breaking changes** None for a default instance: both flags are off by default for self-hosted and managed instances, so nothing changes unless an operator turns them on. Stored `adapterConfig` values are never cleared, so turning the feature off restores every previous value. ## What Changed - Add `ui/src/hooks/useManagedSandboxOnly.ts`, modelled on `useAppsEnabled`, for components that do not already read the experimental settings. It exposes `hideHostPaths`, which fails closed while the settings query is in flight, so a cold cache never flashes a host path before the policy resolves. Components that keep their own settings read compute the same gate from `isFetched`. - Add `managedSandboxOnly` to `AdapterConfigFieldsProps` and populate it where `AgentConfigForm` builds the adapter field props. Resolve the effective instructions-file gate once as `hideInstructionsFile || hideHostPaths`, so every adapter hides that path field with no per-adapter edit. - Hide under the flag: the project "Local folder" block and its absolute-path edit panel (a managed checkout keeps its label, without the path); the new-project "Local folder" field; the project-workspace "Local path" field and fact row; the execution-workspace "Paths" and "Lifecycle commands" groups; the working directory on the workspace summary card, the task workspace card, the task properties "Folder" row, and the runtime service rows; the plugin "Local folders" section; "Working directory (deprecated)" and "Command" in the agent form; and the per-adapter "Execution engine", "ACP server command", and "ACP state directory" for `claude_local`, `codex_local`, and `gemini_local`. - Drop two working-directory fallbacks that had no gate to read: the close-workspace dialog now falls back to "No additional details", and the reuse-existing workspace label and picker subtitle fall back to a neutral phrase. - Refuse a non-null `cwd` with `422` on `POST /projects/:id/workspaces`, `PATCH /projects/:id/workspaces/:workspaceId`, and the nested workspace on `POST /companies/:companyId/projects`, following the `assertNoAgentHostWorkspaceCommandMutation` precedent on those routes. - Add `IsolatedWorkspacesRouteGate` and wrap the `/workspaces`, `/execution-workspaces/*`, and `/projects/:projectId/workspaces/:workspaceId` routes with it. - Leave the SSH "Remote workspace path" and the workspace file browser alone, with a comment explaining why. ## Verification Automated: - `pnpm --filter @paperclipai/ui exec vitest run` — 479 of 480 files pass (4455 of 4456 tests). The one failure is `OnboardingWizard.test.tsx > renders instead of throwing when the browser denies storage access`, which also fails on `origin/master` and is unrelated to this change. - `pnpm --filter @paperclipai/server exec vitest run project workspace instance-settings` — 45 of 50 files pass. Four files fail on macOS for reasons unrelated to this change: `workspace-instance-cleanup`, `workspace-runtime`, `execution-workspace-runtime-control-conflict`, and `workspace-runtime-exposure` compare `/var/...` against the resolved `/private/var/...` or bind real ports. The same files fail on a clean `master` checkout on the same machine. - `pnpm --filter @paperclipai/ui typecheck` - `tsc --noEmit` in `server/` (after `pnpm --filter @paperclipai/plugin-sdk ensure-build-deps`). The package `typecheck` script also builds the Rust runner, which needs `cargo`; it is not installed on the machine that ran this. New and extended tests: - `ui/src/adapters/managed-sandbox-only-config-fields.test.tsx` — the three adapters drop the execution engine, the ACP paths, the instructions-file path, and every "Choose" button when the flag is on, and keep the non-path controls. - `ui/src/components/AgentConfigForm.render.test.tsx` — flag-on and flag-off renders for the working directory, the command, the engine, the ACP paths, and the resolved adapter field props. - `ui/src/components/ProjectProperties.managed-sandbox.test.tsx`, `ui/src/components/NewProjectDialog.managed-sandbox.test.tsx`, `ui/src/pages/ProjectWorkspaceDetail.test.tsx`, `ui/src/components/ProjectWorkspaceSummaryCard.test.tsx`, `ui/src/components/WorkspaceRuntimeControls.test.tsx`. - `ui/src/components/IsolatedWorkspacesRouteGate.test.tsx` — redirect when off, render when on, and render nothing while the flag query is in flight. - "Still loading" cases for the project properties, the new-project dialog, the workspace summary card, the runtime service rows, and the agent configuration form, each asserting that no host path renders before the policy resolves. - `server/src/__tests__/project-workspace-managed-sandbox-routes.test.ts` — the `422` on all three write paths, the `cwd: null` pass-through, and the flag-off pass-through. Manual check to reproduce: turn on Managed Environment Only in instance experimental settings, then open a project, the new-project dialog, an agent's configuration, and a workspace page. No path, folder icon, or "Choose" button appears. Turn the setting off and each control returns with its stored value. No documentation change was needed. The operator-facing text for both settings lives in the feature catalog entry, which already states the contract this pull request now enforces across the UI. ## Risks - Low. Both flags default to off, so a default instance is unchanged. - The hidden fields are presentation only. No stored `adapterConfig` value is cleared, because an import carries adapter configuration written on another instance and clearing it would break that flow. Turning the setting off shows every previous value again. - The `422` is the one behavior change for an API caller, and only while the setting is on. `cwd: null` still passes so a stale path can be cleared. - The route gate renders nothing until the flag query settles, so an instance with isolated workspaces on never flashes a redirect. An instance with the feature off now redirects a bookmarked workspace URL to the dashboard. - Every host-path guard fails closed while the settings query is in flight, so a default instance shows those controls a moment later than before on a cold load. That is the safe direction: the alternative flashes a path a managed instance must never show. - Two path surfaces stay on purpose, each with a comment: the SSH "Remote workspace path" is a path on the user's own remote host, and the workspace file browser shows workspace-relative paths. The instance Adapters page also keeps its "Local path" install option, since that page is an instance-admin surface the hosting operator can already hide through the hidden-settings mechanism. ## Model Used Claude (Anthropic), Claude Opus, 1M context window, extended thinking, agentic tool use through Claude Code. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge
400 lines
14 KiB
TypeScript
400 lines
14 KiB
TypeScript
// @vitest-environment jsdom
|
||
|
||
import { QueryClient, QueryClientProvider } from "@tanstack/react-query";
|
||
import type { Project, ProjectWorkspace } from "@paperclipai/shared";
|
||
import { act, type ReactNode } from "react";
|
||
import { createRoot, type Root } from "react-dom/client";
|
||
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
|
||
import { ProjectWorkspaceDetail } from "./ProjectWorkspaceDetail";
|
||
import { queryKeys } from "../lib/queryKeys";
|
||
|
||
(globalThis as typeof globalThis & { IS_REACT_ACT_ENVIRONMENT?: boolean }).IS_REACT_ACT_ENVIRONMENT = true;
|
||
|
||
const mockProjectsApi = vi.hoisted(() => ({
|
||
get: vi.fn(),
|
||
updateWorkspace: vi.fn(),
|
||
controlWorkspaceCommands: vi.fn(),
|
||
}));
|
||
const mockNavigate = vi.hoisted(() => vi.fn());
|
||
const mockSetBreadcrumbs = vi.hoisted(() => vi.fn());
|
||
const mockSetSelectedCompanyId = vi.hoisted(() => vi.fn());
|
||
const mockUsePluginSlots = vi.hoisted(() => vi.fn());
|
||
const mockPluginSlotMount = vi.hoisted(() => vi.fn());
|
||
const mockRouteSearch = vi.hoisted(() => ({ value: "" }));
|
||
const mockPluginSlotState = vi.hoisted(() => ({
|
||
slots: [] as unknown[],
|
||
isLoading: false,
|
||
errorMessage: null as string | null,
|
||
}));
|
||
|
||
vi.mock("../api/projects", () => ({ projectsApi: mockProjectsApi }));
|
||
|
||
vi.mock("@/lib/router", () => ({
|
||
Link: ({ children, to, className }: { children?: ReactNode; to: string; className?: string }) => (
|
||
<a href={to} className={className}>{children}</a>
|
||
),
|
||
useLocation: () => ({
|
||
pathname: "/PAP/projects/paperclip-app/workspaces/workspace-1",
|
||
search: mockRouteSearch.value,
|
||
hash: "",
|
||
state: null,
|
||
}),
|
||
useNavigate: () => mockNavigate,
|
||
useParams: () => ({ companyPrefix: "PAP", projectId: "paperclip-app", workspaceId: "workspace-1" }),
|
||
}));
|
||
|
||
vi.mock("../context/CompanyContext", () => ({
|
||
useCompany: () => ({
|
||
companies: [{ id: "company-1", issuePrefix: "PAP" }],
|
||
selectedCompanyId: "company-1",
|
||
setSelectedCompanyId: mockSetSelectedCompanyId,
|
||
}),
|
||
}));
|
||
vi.mock("../context/BreadcrumbContext", () => ({ useBreadcrumbs: () => ({ setBreadcrumbs: mockSetBreadcrumbs }) }));
|
||
vi.mock("../components/PathInstructionsModal", () => ({ ChoosePathButton: () => null }));
|
||
vi.mock("../components/WorkspaceRuntimeControls", () => ({
|
||
buildWorkspaceRuntimeControlSections: () => [],
|
||
WorkspaceRuntimeControls: () => <div data-testid="runtime-controls" />,
|
||
}));
|
||
vi.mock("@/plugins/slots", () => ({
|
||
PluginSlotMount: (props: unknown) => {
|
||
mockPluginSlotMount(props);
|
||
return <div data-testid="plugin-slot-mount" />;
|
||
},
|
||
usePluginSlots: (filters: unknown) => {
|
||
mockUsePluginSlots(filters);
|
||
const entityType = (filters as { entityType?: string }).entityType;
|
||
return {
|
||
slots: entityType === "project_workspace" ? mockPluginSlotState.slots : [],
|
||
isLoading: mockPluginSlotState.isLoading,
|
||
errorMessage: mockPluginSlotState.errorMessage,
|
||
};
|
||
},
|
||
}));
|
||
vi.mock("../components/PageTabBar", () => ({
|
||
PageTabBar: ({
|
||
items,
|
||
onValueChange,
|
||
}: {
|
||
items: Array<{ value: string; label: string }>;
|
||
onValueChange?: (value: string) => void;
|
||
}) => (
|
||
<div data-testid="page-tab-bar">
|
||
{items.map((item) => (
|
||
<button
|
||
key={item.value}
|
||
data-tab-value={item.value}
|
||
type="button"
|
||
onClick={() => onValueChange?.(item.value)}
|
||
>
|
||
{item.label}
|
||
</button>
|
||
))}
|
||
</div>
|
||
),
|
||
}));
|
||
|
||
function projectWorkspace(overrides: Partial<ProjectWorkspace> = {}): ProjectWorkspace {
|
||
const now = new Date("2026-05-01T00:00:00Z");
|
||
return {
|
||
id: "workspace-1",
|
||
companyId: "company-1",
|
||
projectId: "project-1",
|
||
name: "Primary checkout",
|
||
sourceType: "local_path",
|
||
cwd: "/tmp/paperclip",
|
||
repoUrl: "https://github.com/paperclipai/paperclip",
|
||
repoRef: "master",
|
||
defaultRef: "origin/main",
|
||
visibility: "default",
|
||
setupCommand: null,
|
||
cleanupCommand: null,
|
||
remoteProvider: null,
|
||
remoteWorkspaceRef: null,
|
||
sharedWorkspaceKey: null,
|
||
metadata: null,
|
||
runtimeConfig: null,
|
||
runtimeServices: [],
|
||
isPrimary: true,
|
||
createdAt: now,
|
||
updatedAt: now,
|
||
...overrides,
|
||
};
|
||
}
|
||
|
||
function project(overrides: Partial<Project> = {}): Project {
|
||
const now = new Date("2026-05-01T00:00:00Z");
|
||
const workspace = projectWorkspace();
|
||
return {
|
||
id: "project-1",
|
||
companyId: "company-1",
|
||
urlKey: "paperclip-app",
|
||
goalId: null,
|
||
goalIds: [],
|
||
goals: [],
|
||
name: "Paperclip App",
|
||
description: null,
|
||
status: "in_progress",
|
||
leadAgentId: null,
|
||
targetDate: null,
|
||
color: "#14b8a6",
|
||
icon: null,
|
||
env: null,
|
||
pauseReason: null,
|
||
pausedAt: null,
|
||
executionWorkspacePolicy: null,
|
||
codebase: {
|
||
workspaceId: workspace.id,
|
||
repoUrl: workspace.repoUrl,
|
||
repoRef: workspace.repoRef,
|
||
defaultRef: workspace.defaultRef,
|
||
repoName: "paperclip",
|
||
localFolder: workspace.cwd,
|
||
managedFolder: workspace.cwd ?? "/tmp/paperclip",
|
||
effectiveLocalFolder: workspace.cwd ?? "/tmp/paperclip",
|
||
origin: "local_folder",
|
||
},
|
||
workspaces: [workspace],
|
||
primaryWorkspace: workspace,
|
||
managedByPlugin: null,
|
||
archivedAt: null,
|
||
createdAt: now,
|
||
updatedAt: now,
|
||
...overrides,
|
||
};
|
||
}
|
||
|
||
async function flush() {
|
||
await new Promise((resolve) => setTimeout(resolve, 0));
|
||
await new Promise((resolve) => setTimeout(resolve, 0));
|
||
}
|
||
|
||
function pluginSlot(overrides: Record<string, unknown> = {}) {
|
||
return {
|
||
id: "quality-tab",
|
||
type: "detailTab",
|
||
displayName: "Quality",
|
||
exportName: "ProjectWorkspaceQualityTab",
|
||
entityTypes: ["project_workspace"],
|
||
pluginId: "plugin-1",
|
||
pluginKey: "paperclip.quality",
|
||
pluginDisplayName: "Quality Plugin",
|
||
pluginVersion: "0.1.0",
|
||
...overrides,
|
||
};
|
||
}
|
||
|
||
describe("ProjectWorkspaceDetail plugin tabs", () => {
|
||
let root: Root | null = null;
|
||
let container: HTMLDivElement;
|
||
|
||
beforeEach(() => {
|
||
container = document.createElement("div");
|
||
document.body.appendChild(container);
|
||
mockProjectsApi.get.mockResolvedValue(project());
|
||
mockPluginSlotState.slots = [];
|
||
mockPluginSlotState.isLoading = false;
|
||
mockPluginSlotState.errorMessage = null;
|
||
});
|
||
|
||
afterEach(() => {
|
||
act(() => root?.unmount());
|
||
root = null;
|
||
container.remove();
|
||
vi.clearAllMocks();
|
||
mockRouteSearch.value = "";
|
||
});
|
||
|
||
async function render() {
|
||
const queryClient = new QueryClient({ defaultOptions: { queries: { retry: false } } });
|
||
await act(async () => {
|
||
root = createRoot(container);
|
||
root.render(
|
||
<QueryClientProvider client={queryClient}>
|
||
<ProjectWorkspaceDetail />
|
||
</QueryClientProvider>,
|
||
);
|
||
});
|
||
await act(async () => {
|
||
await flush();
|
||
});
|
||
}
|
||
|
||
it("scopes plugin detail-tab discovery to project_workspace and the project's company", async () => {
|
||
await render();
|
||
|
||
const enabledDetailTabFilters = mockUsePluginSlots.mock.calls
|
||
.map(([filters]) => filters as { slotTypes: string[]; entityType: string; companyId: string | null; enabled?: boolean })
|
||
.filter((filters) => filters.slotTypes.includes("detailTab") && filters.enabled !== false);
|
||
|
||
expect(enabledDetailTabFilters.length).toBeGreaterThan(0);
|
||
for (const filters of enabledDetailTabFilters) {
|
||
expect(filters.entityType).toBe("project_workspace");
|
||
expect(filters.companyId).toBe("company-1");
|
||
}
|
||
});
|
||
|
||
it("renders an arbitrary project_workspace plugin detail tab from the generic URL value", async () => {
|
||
mockPluginSlotState.slots = [pluginSlot()];
|
||
mockRouteSearch.value = "?tab=plugin%3Apaperclip.quality%3Aquality-tab&diffView=head&baseRef=origin%2Fmaster";
|
||
|
||
await render();
|
||
|
||
expect(container.querySelector('[data-tab-value="configuration"]')?.textContent).toBe("Configuration");
|
||
expect(container.querySelector('[data-tab-value="plugin:paperclip.quality:quality-tab"]')?.textContent).toBe("Quality");
|
||
expect(container.querySelector('[data-tab-value="changes"]')).toBeNull();
|
||
expect(container.querySelector('[data-testid="plugin-slot-mount"]')).not.toBeNull();
|
||
expect(mockPluginSlotMount).toHaveBeenCalledWith(
|
||
expect.objectContaining({
|
||
slot: expect.objectContaining({ pluginKey: "paperclip.quality", id: "quality-tab" }),
|
||
context: expect.objectContaining({ entityType: "project_workspace", entityId: "workspace-1" }),
|
||
}),
|
||
);
|
||
});
|
||
|
||
it("keeps the project workspace heading visible on plugin tabs", async () => {
|
||
mockPluginSlotState.slots = [pluginSlot({ displayName: "Changes" })];
|
||
mockRouteSearch.value = "?tab=plugin%3Apaperclip.quality%3Aquality-tab";
|
||
|
||
await render();
|
||
|
||
expect(container.querySelector("h1")?.textContent).toBe("Primary checkout");
|
||
expect(container.textContent).toContain("Project workspace");
|
||
expect(container.textContent).toContain("This is the project’s primary codebase workspace.");
|
||
expect(container.querySelector('[data-testid="plugin-slot-mount"]')).not.toBeNull();
|
||
expect(container.textContent).not.toContain("Configure the concrete workspace");
|
||
expect(container.textContent).not.toContain("Workspace name");
|
||
});
|
||
|
||
it("orders project workspace plugin tabs against built-in tabs by slot order", async () => {
|
||
mockPluginSlotState.slots = [
|
||
pluginSlot({ id: "late-tab", displayName: "Late", order: 40 }),
|
||
pluginSlot({ id: "early-tab", displayName: "Early", order: 20 }),
|
||
pluginSlot({ id: "default-tab", displayName: "Default" }),
|
||
];
|
||
|
||
await render();
|
||
|
||
const tabLabels = Array.from(container.querySelectorAll("[data-tab-value]")).map((tab) => tab.textContent);
|
||
expect(tabLabels).toEqual(["Early", "Configuration", "Late", "Default"]);
|
||
});
|
||
|
||
it("navigates plugin tabs with only the generic plugin tab parameter", async () => {
|
||
mockPluginSlotState.slots = [pluginSlot()];
|
||
|
||
await render();
|
||
|
||
await act(async () => {
|
||
(container.querySelector('[data-tab-value="plugin:paperclip.quality:quality-tab"]') as HTMLButtonElement).click();
|
||
});
|
||
|
||
expect(mockNavigate).toHaveBeenCalledWith(
|
||
"/projects/paperclip-app/workspaces/workspace-1?tab=plugin%3Apaperclip.quality%3Aquality-tab",
|
||
);
|
||
expect(mockNavigate).not.toHaveBeenCalledWith(expect.stringContaining("diffView"));
|
||
expect(mockNavigate).not.toHaveBeenCalledWith(expect.stringContaining("baseRef"));
|
||
});
|
||
|
||
it("does not treat the old changes tab query as a core plugin tab", async () => {
|
||
mockPluginSlotState.slots = [pluginSlot()];
|
||
mockRouteSearch.value = "?tab=changes&diffView=head&baseRef=origin%2Fmain";
|
||
|
||
await render();
|
||
|
||
expect(container.querySelector('[data-tab-value="changes"]')).toBeNull();
|
||
expect(container.querySelector('[data-testid="plugin-slot-mount"]')).toBeNull();
|
||
expect(container.textContent).toContain("Project workspace");
|
||
});
|
||
|
||
it("shows a missing plugin placeholder instead of configuration for stale plugin tab URLs", async () => {
|
||
mockRouteSearch.value = "?tab=plugin%3Amissing%3Aslot";
|
||
|
||
await render();
|
||
|
||
expect(container.textContent).toContain("Workspace plugin tab is not available.");
|
||
expect(container.querySelector('a[href="/projects/paperclip-app/workspaces/workspace-1?tab=configuration"]')?.textContent).toBe(
|
||
"Back to configuration",
|
||
);
|
||
expect(container.querySelector('[data-testid="plugin-slot-mount"]')).toBeNull();
|
||
expect(container.textContent).not.toContain("Configure the concrete workspace");
|
||
expect(container.textContent).not.toContain("Workspace name");
|
||
});
|
||
|
||
it("shows loading and error states for plugin tab manifests", async () => {
|
||
mockPluginSlotState.isLoading = true;
|
||
mockRouteSearch.value = "?tab=plugin%3Apaperclip.quality%3Aquality-tab";
|
||
|
||
await render();
|
||
|
||
expect(container.textContent).toContain("Loading workspace plugin...");
|
||
|
||
act(() => root?.unmount());
|
||
root = null;
|
||
container.innerHTML = "";
|
||
vi.clearAllMocks();
|
||
mockProjectsApi.get.mockResolvedValue(project());
|
||
mockPluginSlotState.isLoading = false;
|
||
mockPluginSlotState.errorMessage = "Plugin manifest failed";
|
||
|
||
await render();
|
||
|
||
expect(container.textContent).toContain("Plugin manifest failed");
|
||
});
|
||
});
|
||
|
||
describe("ProjectWorkspaceDetail local path under the managed-sandbox-only policy", () => {
|
||
let root: Root | null = null;
|
||
let container: HTMLDivElement;
|
||
|
||
beforeEach(() => {
|
||
container = document.createElement("div");
|
||
document.body.appendChild(container);
|
||
mockProjectsApi.get.mockResolvedValue(project());
|
||
mockPluginSlotState.slots = [];
|
||
mockPluginSlotState.isLoading = false;
|
||
mockPluginSlotState.errorMessage = null;
|
||
});
|
||
|
||
afterEach(() => {
|
||
act(() => root?.unmount());
|
||
root = null;
|
||
container.remove();
|
||
vi.clearAllMocks();
|
||
mockRouteSearch.value = "";
|
||
});
|
||
|
||
async function render(experimentalSettings: Record<string, unknown>) {
|
||
const queryClient = new QueryClient({ defaultOptions: { queries: { retry: false } } });
|
||
queryClient.setQueryData(queryKeys.instance.experimentalSettings, experimentalSettings);
|
||
await act(async () => {
|
||
root = createRoot(container);
|
||
root.render(
|
||
<QueryClientProvider client={queryClient}>
|
||
<ProjectWorkspaceDetail />
|
||
</QueryClientProvider>,
|
||
);
|
||
});
|
||
await act(async () => {
|
||
await flush();
|
||
});
|
||
}
|
||
|
||
it("shows the local path field and fact row when the policy is off", async () => {
|
||
await render({});
|
||
|
||
expect(container.textContent).toContain("Local path");
|
||
expect(container.querySelector('input[placeholder="/absolute/path/to/workspace"]')).not.toBeNull();
|
||
expect(container.textContent).toContain("/tmp/paperclip");
|
||
});
|
||
|
||
it("hides the local path field and fact row when the policy is on", async () => {
|
||
await render({ enableManagedSandboxOnly: true });
|
||
|
||
expect(container.textContent).not.toContain("Local path");
|
||
expect(container.querySelector('input[placeholder="/absolute/path/to/workspace"]')).toBeNull();
|
||
expect(container.textContent).not.toContain("/tmp/paperclip");
|
||
// The repo fact row does not name the host filesystem, so it stays.
|
||
expect(container.textContent).toContain("Repo URL");
|
||
});
|
||
});
|