mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-14 17:40:37 +02:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work > - Routines are the recurring-work surface that lets a company keep operating without a human manually kicking off every task > - The base routine detail Variation C shell already landed in #7848, but the follow-up branch still had polish work for scheduling, section ergonomics, and the list layout > - Operators need routine edit screens to explain trigger behavior clearly, keep long detail pages usable on mobile/touch devices, and make grouped routine lists easier to scan > - This pull request rebases the remaining branch work onto current `master`, drops the duplicate commits already merged through #7848, and keeps only the new routine UI follow-ups > - The benefit is a cleaner routines workflow without reopening the already-merged shell work or carrying unrelated lockfile, workflow, or screenshot changes ## Linked Issues or Issue Description Refs #7848 Feature follow-up: polish the routines UI after the Variation C routine-detail shell landed. Problem / motivation: - Routine trigger configuration needs clearer previews for manual, schedule, API, and webhook execution modes. - Routine detail sections need better responsive spacing and touch ergonomics. - The routines list grouping should scan like grouped records instead of a table with heavy row dividers. - The routine tests need a React 19-compatible render helper so the focused routine suite can run in this workspace. Proposed solution: - Add cron-fire preview helpers and routine-run display helpers with focused tests. - Expand the routine editable and operate sections with richer trigger, variable, run, activity, and history presentation. - Adjust the routine detail shell and sub-sidebar spacing for mobile/touch layout. - Update grouped routine list presentation to use bordered group headers with borderless rows. - Switch affected routine tests to the repo's `flushSync` render-helper pattern. Alternatives considered: - Leaving the duplicate pre-#7848 commits in the branch would recreate conflicts and make the PR review much larger than the remaining change. - Keeping grouped routine rows inside one bordered table was simpler, but made the grouping hierarchy less legible. Roadmap alignment: - ROADMAP.md lists Scheduled Routines as a core shipped capability and Output/Enforced Outcomes as ongoing priorities. This is polish on that existing routines capability, not a new roadmap-level feature. ## What Changed - Added routine scheduling preview helpers and tests for cron/manual/API/webhook fire-policy display. - Added routine run display helpers and tests for deduped trigger labels and run-row subtitles. - Polished routine detail sections, including trigger summaries, operate views, and env/variable editing ergonomics. - Adjusted routine detail page and sub-sidebar spacing so the title/header area is less pinned and touch layouts center better. - Reworked the routines list grouped layout so group headers are bordered cards and routine rows are borderless inside each group. - Added Storybook coverage for the routines list grouped layout and updated the existing routine detail story. - Repaired routine tests to use `flushSync` helpers compatible with the installed React 19 runtime. ## Verification - `pnpm exec vitest run ui/src/lib/cron-fires.test.ts ui/src/lib/routine-run-display.test.ts ui/src/pages/Routines.test.tsx ui/src/components/RoutineSubSidebar.test.tsx ui/src/components/RoutineSaveBar.test.tsx` - Result: 5 test files passed, 37 tests passed. - Confirmed the rebased PR diff does not include `pnpm-lock.yaml`, `.github/workflows/*`, or committed screenshots. - Confirmed `origin/master` is an ancestor of the pushed branch head after rebase. ## Risks - Medium UI risk: this touches the routine detail and routine list surfaces, so visual regressions are possible in edge cases not covered by the focused tests. - Low data risk: no schema, migration, server API, or lockfile changes are included. - Review note: the branch intentionally force-pushed after rebasing because the original first three commits were already merged through #7848. > For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and discuss it in `#dev` before opening the PR. Feature PRs that overlap with planned core work may need to be redirected — check the roadmap first. See `CONTRIBUTING.md`. ## Model Used OpenAI Codex, GPT-5-based coding agent runtime, with repository shell/tool access. Exact hosted runtime model identifier and context-window size were not exposed in the execution environment. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [ ] If this change affects the UI, I have included before/after screenshots - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
118 lines
3.6 KiB
TypeScript
118 lines
3.6 KiB
TypeScript
// @vitest-environment jsdom
|
|
|
|
import type { AnchorHTMLAttributes, ReactNode } from "react";
|
|
import { flushSync } from "react-dom";
|
|
import { createRoot } from "react-dom/client";
|
|
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
|
|
|
|
vi.mock("@/lib/router", () => ({
|
|
Link: ({
|
|
to,
|
|
children,
|
|
...props
|
|
}: AnchorHTMLAttributes<HTMLAnchorElement> & { to: string; children: ReactNode; replace?: boolean }) => {
|
|
const { replace: _replace, ...rest } = props as Record<string, unknown>;
|
|
return (
|
|
<a href={to} {...(rest as AnchorHTMLAttributes<HTMLAnchorElement>)}>
|
|
{children}
|
|
</a>
|
|
);
|
|
},
|
|
}));
|
|
|
|
import { RoutineSubSidebar } from "./RoutineSubSidebar";
|
|
import type { RoutineSectionKey } from "./routine-sections/context";
|
|
|
|
function act(callback: () => void) {
|
|
flushSync(callback);
|
|
}
|
|
|
|
let container: HTMLDivElement;
|
|
let root: ReturnType<typeof createRoot>;
|
|
|
|
beforeEach(() => {
|
|
container = document.createElement("div");
|
|
document.body.appendChild(container);
|
|
root = createRoot(container);
|
|
});
|
|
|
|
afterEach(() => {
|
|
act(() => root.unmount());
|
|
container.remove();
|
|
vi.clearAllMocks();
|
|
});
|
|
|
|
function renderSidebar(overrides?: {
|
|
activeSection?: RoutineSectionKey;
|
|
dirty?: RoutineSectionKey[];
|
|
hasLiveRun?: boolean;
|
|
onNavigate?: (section: RoutineSectionKey) => void;
|
|
}) {
|
|
const dirty = new Set(overrides?.dirty ?? []);
|
|
const onNavigate = overrides?.onNavigate ?? vi.fn();
|
|
act(() => {
|
|
root.render(
|
|
<RoutineSubSidebar
|
|
activeSection={overrides?.activeSection ?? "overview"}
|
|
hrefFor={(section) => `/routines/r1/${section}`}
|
|
isSectionDirty={(section) => dirty.has(section)}
|
|
hasLiveRun={overrides?.hasLiveRun ?? false}
|
|
onNavigate={onNavigate}
|
|
/>,
|
|
);
|
|
});
|
|
return { onNavigate };
|
|
}
|
|
|
|
describe("RoutineSubSidebar", () => {
|
|
it("renders all eight sections grouped under ROUTINE and OPERATE", () => {
|
|
renderSidebar();
|
|
const links = Array.from(container.querySelectorAll("a"));
|
|
const labels = links.map((link) => link.textContent?.trim());
|
|
expect(labels).toEqual([
|
|
"Overview",
|
|
"Triggers",
|
|
"Variables",
|
|
"Secrets",
|
|
"Delivery",
|
|
"Runs",
|
|
"Activity",
|
|
"History",
|
|
]);
|
|
const groupLabels = Array.from(container.querySelectorAll("p")).map((p) => p.textContent);
|
|
expect(groupLabels).toContain("Routine");
|
|
expect(groupLabels).toContain("Operate");
|
|
});
|
|
|
|
it("marks the active section with aria-current=page", () => {
|
|
renderSidebar({ activeSection: "secrets" });
|
|
const active = container.querySelector('a[aria-current="page"]');
|
|
expect(active?.textContent?.trim()).toBe("Secrets");
|
|
});
|
|
|
|
it("links each section to its section URL", () => {
|
|
renderSidebar();
|
|
const variables = Array.from(container.querySelectorAll("a")).find(
|
|
(link) => link.textContent?.trim() === "Variables",
|
|
);
|
|
expect(variables?.getAttribute("href")).toBe("/routines/r1/variables");
|
|
});
|
|
|
|
it("shows a dirty marker only on dirty editable sections", () => {
|
|
renderSidebar({ dirty: ["overview", "delivery"] });
|
|
const dirtyMarkers = container.querySelectorAll('[aria-label="Unsaved changes"]');
|
|
expect(dirtyMarkers.length).toBe(2);
|
|
});
|
|
|
|
it("fires onNavigate when a section is clicked", () => {
|
|
const { onNavigate } = renderSidebar();
|
|
const triggers = Array.from(container.querySelectorAll("a")).find(
|
|
(link) => link.textContent?.trim() === "Triggers",
|
|
) as HTMLAnchorElement;
|
|
act(() => {
|
|
triggers.dispatchEvent(new MouseEvent("click", { bubbles: true }));
|
|
});
|
|
expect(onNavigate).toHaveBeenCalledWith("triggers");
|
|
});
|
|
});
|