Files
PaperClipAI/tests/e2e/disconnect-write-recovery.spec.ts
T
a3313f6944 fix(ui): complete read recovery and enforce query error rendering (#18822)
## Thinking Path

> - Paperclip lets people manage agent work through the board.
> - The board reads task, agent, settings, plugin, and run data from the
server.
> - A deploy can interrupt those reads after content is already visible.
> - Local error branches can replace that content with an error or show
raw codes.
> - This pull request moves the remaining reads to the shared recovery
behavior.
> - The query-error guard prevents new local error patterns from
returning.

## Linked Issues or Issue Description

**What happened?**
Loaded lists, settings, task panels, and manual reads could clear their
content or show errors during a server restart. Some reads also disabled
the shared retry policy.

**Expected behavior**
Keep loaded content during a temporary failure. Show the shared
connection banner. Retry reads after recovery. Replace content after a
real access denial or missing resource, with readable copy.

**Steps to reproduce**
Open a task, settings page, or run log. Return 503 with
`tenant_app_unavailable` from the API. Restore the API and check that
content refreshes. Repeat with 403 and 404 to check the failure state.

Related merged work: Refs #15754, Refs #15772, Refs #17960. This change
covers remaining reads and enforcement. Browser persistence and the
outage browser suite follow separately.

## What Changed

- Repair an existing PostgreSQL deadline fixture at UTC boundaries. A
daily cap defers a heartbeat until both its original interval and the
next UTC day allow it. Keep the counted run in its seeded day and cover
noon, just before midnight and the first second after midnight with
explicit clocks and real PostgreSQL. Production scheduling is unchanged.

- Integrate the saved list, settings, shell, task, and manual-read
recovery changes against current master. Preserve the current task,
Inbox, and run-log structure.
- Add `useResilientFetch` for component-local reads. Preserve loaded
data, cancel stale requests, and retry through the shared connectivity
policy. Keep browser and pairing capabilities in memory.
- Retain run log chunks across stream changes and catch up after
recovery without duplicate chunks or stalled requests.
- Keep genuine authorization and missing-resource failures visible.
Translate known single-word codes such as `forbidden`. Show known skills
and disconnected-app failures before sibling loading states. Keep Retry
bound to its failed request.
- Make the query-error guard enforce by default and run it in the CI
policy job. Document the narrow exceptions and the read recovery
contract.
- Invalidate pending OAuth discovery when the operator leaves setup or
its context changes. Keep reserved-popup cleanup bound to the current
attempt.

## Verification

- Current read head `09d1db29dea` is merge-ready: all 59 check runs are
completed (54 successful, three skipped, two neutral), the legacy Snyk
status is successful, and both required `ci / verify` and `ci / e2e`
gates pass. Greptile Apex reviewed this exact head at 5/5 with no
unresolved threads; the branch has no merge conflicts. The current CI
run is `41748339602`.
- Current read head `09d1db29dea` includes master `683fa4725e9`. The
latest change touches only the existing server deadline test fixture.
Application source remains the previously verified `86376fa751e`
revision: all 60 affected skills/disconnected-app tests and both
application UI typechecks passed, along with token gates and the
enforcing query-error guard. Those UI suites were not repeated for this
test-only repair.
- The fixture repair passes all seven deadline integration cases and the
complete server typecheck, including the server test layer. The old
assertion deterministically fails at 23:59:06.888 UTC; its
one-second-old run also fails the first-second-of-day probe. The
corrected fixture passes noon and both midnight probes. The permanent
three-case coverage uses seeded 2099 clocks.
- Twelve new regressions fail against the previous implementation. Both
skills variants and disconnected-app pages show either request's 403 or
429 while the sibling pauses or remains fetching. Permission failures
stay visible. Retry stays usable for its failed request and recovers
independently. An initial test-fixture query-key typo was corrected
before the passing run. The finding is replied to and resolved. Greptile
reviewed prior application revision `86376fa751e` at 5/5 with no new
actionable findings or unresolved threads. The current test-only head
has now received its own Apex 5/5 review with no unresolved threads, and
its CI is successful as recorded above.
- The preceding OAuth fix passed all 237 setup tests on both application
branches. Its ten regressions prove that Back, Cancel, unmount, or
context changes retire initial discovery without creating a connection,
caching old identities, navigating an abandoned popup, or closing a
newer attempt.
- Earlier master integration `e992f770339` passed all 309 tests across
eight affected Slack, recovery, retry, submission and task files, plus
UI typecheck, token gates, enforcing query-error scan and seven guard
tests. The integration preserves Slack workspace reconnect and shared
recovery, readable execution errors, source-inspection company scoping,
and current submission behavior. Newly inherited retained-file recovery
controls keep cached data through transient failures and hide it after
definitive denial.
- The preceding cache head `97c0bc3966f` passed 1,038 focused
cache/write/editor/account/task/API tests. All 22 built-UI
outage/write/loading cases passed in 4.7 minutes on exact browser head
`b7deaaee5da`, with strict checking of all three specs. The latest
skills/app rendering fix is covered by its affected component suites;
those broader cases were not repeated for this separate read path.
- Historical broader UI, CLI and build results and unresolved aggregate
server/DB/adapter failures remain in the PR discussion. Interrupted CI
runs were audited and recorded separately; they are not counted as
passes. Controlled local outages do not prove hosted authentication or a
real Cloud restart/deploy. Real hosted acceptance remains required after
merge and deployment.

Commands for the latest fix:

```sh
pnpm --filter @paperclipai/ui exec vitest run src/pages/CompanySkills.test.tsx src/pages/apps/AppNotConnected.test.tsx
pnpm --filter @paperclipai/ui typecheck
pnpm check:token-gates
node scripts/check-query-error-rendering.mjs --enforce --summary
```

## Risks

This migration touches many read surfaces. The main risks are initial
loading, request cancellation, retained authorization state, and run-log
paging. The tests cover those states. There are no server, schema,
dependency, or API contract changes. The follow-up browser suite and
hosted deploy acceptance are required before release acceptance.

Recovered commits retain their original authors. If squash-merging,
preserve `Co-Authored-By: Bender (Fable) <bender@agents.paperclip.ing>`
and the Paperclip trailer.

## Model Used

OpenAI `gpt-6.1-sol` through Codex, with xhigh reasoning effort, tool
use, and code execution. The context window size is not exposed. Saved
source commits keep their original authorship.

## Checklist

- [x] I have included a thinking path that traces from project context
to this change
- [x] I have specified the model used (with version and capability
details)
- [x] I have checked ROADMAP.md and confirmed this PR does not duplicate
planned core work
- [x] I have searched GitHub for duplicate or related PRs and linked
them above
- [x] I have described the issue in-PR following the bug report template
- [x] I have not referenced internal/instance-local Paperclip issues or
links
- [x] My branch name describes the change and contains no internal
ticket id
- [x] The affected local tests pass; broader limitations are recorded
above
- [x] I have added or updated tests where applicable
- [x] I have updated relevant documentation to reflect my changes
- [x] I have considered and documented risks above
- [x] All Paperclip CI gates are green
- [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups
- [x] I will address all Greptile and reviewer comments before
requesting merge

---------

Co-authored-by: devinfoley <139239+devinfoley@users.noreply.github.com>
Co-authored-by: Paperclip <noreply@paperclip.ing>
Co-authored-by: Bender (Fable) <bender@agents.paperclip.ing>
Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
2026-11-04 14:07:18 -08:00

248 lines
16 KiB
TypeScript

import { test, expect, type APIResponse } from "@playwright/test";
async function json(response: APIResponse) {
const body = await response.text();
expect(response.ok(), `${response.url()}: ${response.status()} ${body}`).toBe(true);
return JSON.parse(body);
}
test("a task title survives an outage and saves after server recovery", async ({ page, request }) => {
const company = await json(await request.post("/api/companies", { data: { name: `Write recovery ${Date.now()}` } }));
try {
const issue = await json(await request.post(`/api/companies/${company.id}/issues`, {
data: { title: "Original task title", status: "backlog" },
}));
const other = await json(await request.post(`/api/companies/${company.id}/issues`, {
data: { title: "Another task stays unchanged", status: "backlog" },
}));
await page.goto(`/${company.issuePrefix}/issues/${issue.identifier}`);
await expect(page.getByTestId("task-chat-history-content")).toBeVisible({ timeout: 30_000 });
const header = page.getByTestId("issue-detail-header");
await expect(header.getByRole("heading", { name: issue.title, exact: true })).toBeVisible();
let unavailable = true;
let failedWrites = 0;
await page.route("**/api/**", async route => {
if (!unavailable) return route.continue();
if (route.request().method() === "PATCH" && [`/api/issues/${issue.id}`, `/api/issues/${issue.identifier}`].includes(new URL(route.request().url()).pathname)) {
failedWrites += 1;
}
if (!failedWrites) return route.continue();
await route.fulfill({ status: 503, contentType: "application/json", body: JSON.stringify({ error: "tenant_app_unavailable" }) });
});
await header.getByRole("heading", { name: issue.title, exact: true }).click();
const title = header.locator("textarea");
await title.fill("A title retained through the outage");
await title.press("Enter");
await expect.poll(() => failedWrites).toBeGreaterThan(0);
await expect(page.locator('[data-connection-status="reconnecting"]')).toBeVisible();
expect((await json(await request.get(`/api/issues/${issue.id}`))).title).toBe(issue.title);
await expect(header).toBeVisible();
unavailable = false;
await expect.poll(async () => (await json(await request.get(`/api/issues/${issue.id}`))).title,
{ timeout: 30_000 }).toBe("A title retained through the outage");
expect((await json(await request.get(`/api/issues/${other.id}`))).title).toBe(other.title);
await page.reload();
await expect(page.getByTestId("task-chat-history-content")).toBeVisible({ timeout: 30_000 });
await expect(header.getByRole("heading", { name: "A title retained through the outage", exact: true })).toBeVisible();
expect((await json(await request.get(`/api/issues/${issue.id}`))).status).toBe("backlog");
} finally {
await request.patch(`/api/companies/${company.id}`, { data: { status: "archived" } });
}
});
test("two cached tasks keep separate title saves while the browser is offline", async ({ page, request }) => {
test.setTimeout(120_000);
const company = await json(await request.post("/api/companies", { data: { name: `Queued writes ${Date.now()}` } }));
try {
const first = await json(await request.post(`/api/companies/${company.id}/issues`, { data: { title: "First queued task", status: "todo" } }));
const second = await json(await request.post(`/api/companies/${company.id}/issues`, { data: { title: "Second queued task", status: "todo" } }));
await page.goto(`/${company.issuePrefix}/issues/${second.id}`);
await expect(page.getByRole("heading", { name: second.title, exact: true })).toBeVisible();
await page.getByRole("link", { name: "Tasks", exact: true }).first().click();
await page.getByRole("link").filter({ hasText: first.title }).first().click();
await expect(page.getByTestId("task-chat-history-content")).toBeVisible({ timeout: 30_000 });
const header = page.getByTestId("issue-detail-header");
await expect(header.getByRole("heading", { name: first.title, exact: true })).toBeVisible();
const dismissAnnouncement = page.getByRole("button", { name: "Dismiss announcement" });
if (await dismissAnnouncement.isVisible()) await dismissAnnouncement.click();
const secondLink = page.getByRole("link").filter({ hasText: second.title }).first();
await expect(secondLink).toBeVisible();
await page.context().setOffline(true);
await expect(page.locator('[data-connection-status="offline"]')).toBeVisible();
await header.getByRole("heading", { name: first.title, exact: true }).click();
await header.locator("textarea").fill("First title retained offline");
await header.locator("textarea").press("Enter");
await secondLink.focus();
await secondLink.press("Enter", { timeout: 5_000 });
await expect(page).toHaveURL(new RegExp(`${second.id}$`));
await expect(page.getByTestId("task-chat-history-content")).toBeVisible({ timeout: 30_000 });
await expect(header.getByRole("heading", { name: second.title, exact: true })).toBeVisible();
await header.getByRole("heading", { name: second.title, exact: true }).click();
await expect(header.locator("textarea")).toHaveValue(second.title);
await header.locator("textarea").fill("Second title retained offline");
await header.locator("textarea").press("Enter");
expect((await json(await request.get(`/api/issues/${first.id}`))).title).toBe(first.title);
expect((await json(await request.get(`/api/issues/${second.id}`))).title).toBe(second.title);
await page.context().setOffline(false);
await expect.poll(async () => (await json(await request.get(`/api/issues/${first.id}`))).title, { timeout: 30_000 }).toBe("First title retained offline");
await expect.poll(async () => (await json(await request.get(`/api/issues/${second.id}`))).title, { timeout: 30_000 }).toBe("Second title retained offline");
await page.reload();
await expect(page.getByTestId("task-chat-history-content")).toBeVisible({ timeout: 30_000 });
await expect(header.getByRole("heading", { name: "Second title retained offline", exact: true })).toBeVisible();
} finally {
await page.context().setOffline(false).catch(() => {});
await request.patch(`/api/companies/${company.id}`, { data: { status: "archived" } });
}
});
test("a cold task waits for the first session and retains a title saved during an API outage", async ({ page, request }) => {
const company = await json(await request.post("/api/companies", { data: { name: `Startup recovery ${Date.now()}` } }));
const session = await json(await request.get("/api/auth/get-session"));
let releaseSession!: () => void;
const sessionReady = new Promise<void>(resolve => { releaseSession = resolve; });
const savedTitle = "Saved through first session lookup";
let apiUnavailable = false;
try {
const issue = await json(await request.post(`/api/companies/${company.id}/issues`, {
data: { title: "Startup original title", status: "backlog" },
}));
await page.route("**/api/**", async route => {
const path = new URL(route.request().url()).pathname;
if (apiUnavailable && (path === "/api/health" || (route.request().method() === "PATCH" && path.startsWith("/api/issues/")))) {
return route.fulfill({ status: 503, contentType: "application/json", body: JSON.stringify({ error: "tenant_app_unavailable" }) });
}
await route.continue();
});
await page.route("**/api/auth/get-session", async route => {
await sessionReady;
await route.fulfill({ status: 200, contentType: "application/json", body: JSON.stringify(session) });
});
const coreReady = page.waitForResponse(response => {
const url = new URL(response.url());
return url.pathname === `/api/issues/${issue.identifier}` && url.searchParams.get("view") === "core" && response.ok();
});
await page.goto(`/${company.issuePrefix}/issues/${issue.identifier}`);
await coreReady;
const header = page.getByTestId("issue-detail-header");
await expect(page.getByTestId("shell-configuration-loading")).toBeVisible();
await expect(header).toHaveCount(0);
releaseSession();
await expect(page.getByTestId("task-chat-history-content")).toBeVisible({ timeout: 30_000 });
await expect(header.getByRole("heading", { name: issue.title, exact: true })).toBeVisible();
apiUnavailable = true;
await page.evaluate(() => window.dispatchEvent(new Event("offline")));
await expect(page.locator('[data-connection-status="offline"]')).toBeVisible();
await header.getByRole("heading", { name: issue.title, exact: true }).click();
await header.locator("textarea").fill(savedTitle);
await header.locator("textarea").press("Enter");
expect((await json(await request.get(`/api/issues/${issue.id}`))).title).toBe(issue.title);
await expect.poll(() => page.evaluate(({ owner, title }) => Object.keys(localStorage).some(key =>
key.startsWith(`paperclip:inline-draft:v2:${owner}:`) && JSON.parse(localStorage.getItem(key) ?? "null")?.draft === title),
{ owner: session.user.id, title: savedTitle })).toBe(true);
apiUnavailable = false;
await page.evaluate(() => window.dispatchEvent(new Event("online")));
await expect.poll(async () => (await json(await request.get(`/api/issues/${issue.id}`))).title,
{ timeout: 15_000 }).toBe(savedTitle);
await page.reload();
await expect(page.getByTestId("task-chat-history-content")).toBeVisible({ timeout: 30_000 });
await expect(header.getByRole("heading", { name: savedTitle, exact: true })).toBeVisible();
} finally {
releaseSession();
apiUnavailable = false;
await page.evaluate(() => window.dispatchEvent(new Event("online"))).catch(() => {});
await request.patch(`/api/companies/${company.id}`, { data: { status: "archived" } });
}
});
test("replaying an accepted comment does not reopen completed work", async ({ page, request }) => {
const company = await json(await request.post("/api/companies", { data: { name: `Comment recovery ${Date.now()}` } }));
try {
const issue = await json(await request.post(`/api/companies/${company.id}/issues`, {
data: { title: "Completed work stays completed", status: "backlog", assigneeAgentId: null, assigneeUserId: null },
}));
const body = "A comment whose response was lost";
const clientRequestId = crypto.randomUUID();
const first = await json(await request.post(`/api/issues/${issue.id}/comments`, { data: { body, clientRequestId } }));
const agent = await json(await request.post(`/api/companies/${company.id}/agents`, {
data: { name: "Completed comment worker", role: "engineer", adapterType: "process", runner: "legacy",
adapterConfig: { command: "/usr/bin/true" }, runtimeConfig: { heartbeat: { enabled: false } } },
}));
await json(await request.patch(`/api/issues/${issue.id}`, { data: { status: "done", assigneeAgentId: agent.id } }));
const receipt = await json(await request.post(`/api/issues/${issue.id}/comments`, { data: { body, clientRequestId } }));
expect(receipt.id).toBe(first.id);
expect((await json(await request.get(`/api/issues/${issue.id}`))).status).toBe("done");
const conflict = await request.post(`/api/issues/${issue.id}/comments`, { data: { body: "Different request", clientRequestId } });
expect(conflict.status()).toBe(409);
expect((await json(await request.get(`/api/issues/${issue.id}`))).status).toBe("done");
const comments = await json(await request.get(`/api/issues/${issue.id}/comments`));
expect(comments.filter((comment: { clientRequestId?: string }) => comment.clientRequestId === clientRequestId)).toHaveLength(1);
const activity = await json(await request.get(`/api/issues/${issue.id}/activity`));
expect(activity.filter((entry: { action: string; details?: { commentId?: string } }) =>
entry.action === "issue.comment_added" && entry.details?.commentId === first.id)).toHaveLength(1);
await page.goto(`/${company.issuePrefix}/issues/${issue.identifier}`);
await expect(page.getByTestId("task-chat-history-content")).toBeVisible({ timeout: 30_000 });
await expect(page.getByTestId("issue-detail-header").getByRole("heading", { name: issue.title, exact: true })).toBeVisible();
await expect(page.getByText(body, { exact: true })).toBeVisible();
} finally {
await request.patch(`/api/companies/${company.id}`, { data: { status: "archived" } });
}
});
for (const delayWorkspacePreference of [false, true]) test(delayWorkspacePreference
? "startup title survives session recovery while workspace preferences remount the editor"
: "startup work retries a failed session lookup while other APIs stay healthy", async ({ page, request }) => {
const company = await json(await request.post("/api/companies", { data: { name: `Session recovery ${Date.now()}` } }));
const session = await json(await request.get("/api/auth/get-session"));
let healthy = false, saving = false, failedAfterSave = 0;
let releasePreference!: () => void;
const preferenceGate = new Promise<void>(resolve => { releasePreference = resolve; });
let sawPreference!: () => void;
const preferenceRequested = new Promise<void>(resolve => { sawPreference = resolve; });
if (delayWorkspacePreference) await page.route("**/api/workspace-preferences/me", async route => {
sawPreference(); await preferenceGate; await route.continue();
});
try {
const issue = await json(await request.post(`/api/companies/${company.id}/issues`, {
data: { title: "Before session recovery", status: "backlog" },
}));
await page.route("**/api/auth/get-session", async route => {
if (healthy) return route.fulfill({ status: 200, json: session });
if (saving) failedAfterSave += 1;
await route.fulfill({ status: 500, json: { error: "session_lookup_failed" } });
});
await page.goto(`/${company.issuePrefix}/issues/${issue.id}`);
await expect(page.getByTestId("task-chat-history-content")).toBeVisible({ timeout: 30_000 });
const header = page.getByTestId("issue-detail-header");
await header.getByRole("heading", { name: issue.title, exact: true }).click();
await header.locator("textarea").fill("Saved after session recovery");
saving = true;
await header.locator("textarea").press("Enter");
await expect.poll(() => failedAfterSave).toBeGreaterThan(0);
if (delayWorkspacePreference) {
// Identity is still unknown: retain the unowned edit in memory until the
// first verified session, then prove it survives the presentation remount.
await expect(header.locator("textarea")).toHaveValue("Saved after session recovery");
expect((await json(await request.get(`/api/issues/${issue.id}`))).title).toBe(issue.title);
await page.evaluate(() => new Promise(resolve => requestAnimationFrame(() => resolve(null))));
}
healthy = true;
if (delayWorkspacePreference) {
// Returning to the tab retries session lookup while the saved edit waits.
await page.evaluate(() => window.dispatchEvent(new Event("visibilitychange")));
await preferenceRequested;
await expect(page.getByTestId("task-chat-history-content")).toBeHidden();
releasePreference();
}
await expect.poll(async () => (await json(await request.get(`/api/issues/${issue.id}`))).title,
{ timeout: 15_000 }).toBe("Saved after session recovery");
await page.reload();
await expect(page.getByTestId("task-chat-history-content")).toBeVisible({ timeout: 30_000 });
await expect(header.getByRole("heading", { name: "Saved after session recovery", exact: true })).toBeVisible();
} finally {
releasePreference();
await request.patch(`/api/companies/${company.id}`, { data: { status: "archived" } });
}
});