mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-21 08:22:20 +02:00
DottaandPaperclip
20ccf3f476
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work. > - External tools need explicit identity and access boundaries. > - Shared connection credentials cannot represent every user-scoped use case. > - Grants must stay company-scoped and support safe delegation. > - This pull request adds connection grants, identity rules, and their database contract. > - The benefit is durable control over which identity an agent may use. ## Linked Issues or Issue Description Refs #11965 This is stack 3 of 11. It depends on stack 2 and replaces another reviewable part of #11965. ## What Changed - Add company and user connection grants. - Add delegated identity and membership rules. - Synchronize database, shared, server, and UI contracts. - Register the grant-member replacement route in the OpenAPI surface in the same layer that mounts it. - Add migration 0231 with replay-safe guards and coverage. ## Verification - `pnpm -r typecheck` - `pnpm --filter @paperclipai/server exec vitest run src/__tests__/tool-access-service.test.ts` - `pnpm --filter @paperclipai/server exec vitest run src/__tests__/openapi-routes.test.ts` (5 passed) - `pnpm --filter @paperclipai/db check:migrations` - `pnpm build` ## Risks - Incorrect grant selection could expose the wrong credential scope. - The service enforces company and subject boundaries before credential use. - Migration 0231 is generated, ordered after 0230, and safe to replay. > I checked `ROADMAP.md`. This stack continues the existing app connection work from #11965 and does not duplicate another planned item. ## Model Used OpenAI Codex, GPT-5. The runtime model ID and context window were not exposed. The model used reasoning, tool use, and code execution. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either linked a public issue or pull request with `Refs #` - [x] I have not referenced internal or instance-local Paperclip issues or links - [x] My branch name describes the change and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
28 lines
921 B
TypeScript
28 lines
921 B
TypeScript
import { describe, expect, it } from "vitest";
|
|
import { filterVisibleToolConnections } from "../routes/tool-access.js";
|
|
|
|
const connections = [
|
|
{ id: "other-draft", status: "draft", createdByUserId: "other-user" },
|
|
{ id: "own-draft", status: "draft", createdByUserId: "member-user" },
|
|
{ id: "active", status: "active", createdByUserId: "other-user" },
|
|
];
|
|
|
|
describe("tool connection visibility", () => {
|
|
it("keeps foreign drafts out of a regular member's reusable connection candidates", () => {
|
|
expect(filterVisibleToolConnections(connections, {
|
|
userId: "member-user",
|
|
canManageConnections: false,
|
|
})).toEqual([
|
|
connections[1],
|
|
connections[2],
|
|
]);
|
|
});
|
|
|
|
it("keeps every draft visible to a connection manager", () => {
|
|
expect(filterVisibleToolConnections(connections, {
|
|
userId: "owner-user",
|
|
canManageConnections: true,
|
|
})).toEqual(connections);
|
|
});
|
|
});
|