mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-11-04 19:28:46 +01:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work. > - Its web server also owns controller admission and user commands. > - A rolling deployment starts a replacement before the old server exits. > - Shared database state alone does not preserve local agent files, browser chunks, or in-process commands. > - This pull request adds an opt-in ephemeral server contract and a local overlap test. > - The benefit is a web server that can relinquish traffic and local files without losing acknowledged work. ## Linked Issues or Issue Description Refs #18403, #18327, #18335, #18341. **Current behavior** The control-plane web server still has local agent-file authority and local command targets. A new container can miss saved bytes or send a command to the wrong process. An existing browser tab also needs chunks from its original build. **Proposed behavior** Eligible servers share only PostgreSQL, object storage and stable secrets. A replacement waits for readiness. The old server drains admitted requests, keeps owner commands available through handoff, and releases controller leases. Explicit maintenance adopts existing files before the volume is removed. **Reason and benefit** This is the application prerequisite for rolling app-only deployments. Schema migrations and permanent multi-replica operation are outside this change. ## What Changed - Store agent-file manifests in PostgreSQL and immutable bytes in S3. Treat local roots as disposable projections. Preserve existing permission checks and edit conflicts. - Add an explicit migration, eligibility and object-retention command to the production runtime bundle. - Add `/api/ready`, admitted-request drain, browser restart signaling and retained immutable UI chunks. - Carry transaction-aware work hints across controllers during handoff and active execution. Keep listeners closed when idle. - Deliver durable Stop and runtime responses to the execution owner. Recheck request lifecycle and access before response dispatch. - Reject local-only configuration in ephemeral mode. Keep the feature disabled for existing installations by default. - Add an isolated PostgreSQL/S3/proxy/browser deployment harness with independent server homes and retained failure evidence. ## Verification - All CI checks pass on `ce17b95019d3cf1cabd357d19b6d37f96782cc5c`: workspace typecheck, build, Runner checks, server/general tests and browser shards. Greptile reviewed the runtime changes at 5/5 with all findings resolved; the final commit updates maps and the plan. - Local targeted checks passed: coordinator 27; Stop/recovery 33; PostgreSQL command delivery 6; route/workspace regressions 8; bootstrap Stop 1; restart recovery 75. PostgreSQL command tests simulate the provider edge. - Local browser proof passed 91 reads and 19 saves; reconnect took 1,013ms. The tab opened Audit from S3 after deletion of A's whole home/build. This uses compiled workspace code and local-trusted auth, not released containers or live agents. - Local workspace typecheck/build passed; current server and runtime bundle passed. The earlier broad local suite was stopped after three hours and is not a passing receipt. Its retained failures and isolated reruns are documented in the plan. - Stacked #18526 adds stricter graceful-exit proof, an unready replacement control, live Runner qualification and a Stop handoff correction. Hosted enablement remains gated on those results and Cloud #1096. No hosted stack has been enabled. ## Risks - Apply migration 0422 before enabling the feature. Existing data must pass each owner's migration and eligibility checks. Do not discard a volume based on a single migration page. - Durable manifests remain authoritative after the opt-in is disabled. Rolling back to a binary that ignores them is unsupported. - Cold directory restoration and complete shutdown timing still need qualification before enabling a hosted stack. - Retained UI assets must cover the supported browser and rollback window. Cleanup is explicit; no new idle maintenance polling is introduced. - This change does not claim production zero downtime or authorize a fleet-wide enablement. ## Model Used OpenAI Codex, GPT-6 family. The exact serving model ID and context-window limit are not exposed in this session. Used reasoning, code editing, shell execution and browser automation. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
130 lines
6.4 KiB
TypeScript
130 lines
6.4 KiB
TypeScript
import { readFileSync } from "node:fs";
|
|
import express from "express";
|
|
import request from "supertest";
|
|
import { afterEach, describe, expect, it, vi } from "vitest";
|
|
import type { Db } from "@paperclipai/db";
|
|
import { livenessRoutes } from "../routes/liveness.js";
|
|
import { readinessRoutes } from "../routes/ready.js";
|
|
import { healthRoutes } from "../routes/health.js";
|
|
import { privateHostnameGuard } from "../middleware/private-hostname-guard.js";
|
|
import { cloudRuntimeIdentityMiddleware } from "../middleware/cloud-runtime-identity.js";
|
|
import { cloudWarmStandbyMiddleware } from "../middleware/cloud-warm-standby.js";
|
|
import { idleAdmissionMiddleware, trackIdleRequestHandlers } from "../middleware/idle-admission.js";
|
|
import { idleWorkSnapshot, startTaskDrain, stopTaskDrain } from "../services/task-admission.js";
|
|
import { resetStartupRecoveryStateForTests, setStartupRecoveryPhase } from "../startup-recovery-state.js";
|
|
import { getServerInfoSnapshot } from "../server-info.js";
|
|
|
|
afterEach(() => { stopTaskDrain(); resetStartupRecoveryStateForTests(); });
|
|
|
|
function fixture(standby = false) {
|
|
const db = { execute: vi.fn().mockRejectedValue(new Error("database offline")) } as unknown as Db;
|
|
const auth = vi.fn((_req, _res, next) => next());
|
|
const health = healthRoutes(db, {
|
|
deploymentMode: "authenticated", deploymentExposure: "public", authReady: true,
|
|
companyDeletionEnabled: false, runtimeEnv: { PAPERCLIP_CLOUD_TENANT_SERVER_TOKEN: "fixture-token" },
|
|
isWarmStandby: () => standby,
|
|
});
|
|
const app = express();
|
|
app.use(idleAdmissionMiddleware);
|
|
app.use(privateHostnameGuard({ enabled: true, allowedHostnames: ["allowed.example"], bindHost: "0.0.0.0" }));
|
|
app.use(cloudRuntimeIdentityMiddleware(db));
|
|
app.use("/api/liveness", livenessRoutes());
|
|
app.use("/api/ready", readinessRoutes());
|
|
app.use(cloudWarmStandbyMiddleware(() => standby, health));
|
|
app.use(auth);
|
|
app.use("/api/health", health);
|
|
app.get("/api/private", (_req, res) => res.sendStatus(401));
|
|
trackIdleRequestHandlers(app);
|
|
const http = request.agent(app).set("host", "allowed.example");
|
|
return { app, http, db, auth };
|
|
}
|
|
|
|
describe("database-free process liveness", () => {
|
|
it.each([false, true])("gates deployment readiness on bootstrap and drain without waking SQL (standby: %s)", async standby => {
|
|
const f = fixture(standby);
|
|
const before = idleWorkSnapshot();
|
|
startTaskDrain({ purpose: "idle", ttlMs: 60_000 });
|
|
for (const phase of ["starting", "recovering", "ready", "draining"] as const) {
|
|
setStartupRecoveryPhase(phase);
|
|
const status = phase === "ready" ? 200 : 503;
|
|
const response = await f.http.get("/api/ready").set("authorization", "Bearer invalid-fixture").expect(status);
|
|
expect(response.body).toEqual({ status: phase });
|
|
expect(response.headers["cache-control"]).toBe("no-store");
|
|
await f.http.head("/api/ready").expect(status);
|
|
}
|
|
await f.http.post("/api/ready").expect(503);
|
|
await f.http.get("/api/ready/details").expect(503);
|
|
expect(f.auth).not.toHaveBeenCalled();
|
|
expect(f.db.execute).not.toHaveBeenCalled();
|
|
expect(idleWorkSnapshot()).toEqual(before);
|
|
});
|
|
it.each([false, true])("does not resolve auth or query SQL with an unavailable database (standby: %s)", async standby => {
|
|
const f = fixture(standby);
|
|
for (let i = 0; i < 3; i++) {
|
|
const response = await f.http.get("/api/liveness")
|
|
.set("authorization", "Bearer invalid-fixture")
|
|
.set("cookie", "session_token=invalid-fixture")
|
|
.set("x-paperclip-cloud-tenant-token", "invalid-fixture");
|
|
expect(response.status).toBe(200);
|
|
expect(response.headers["cache-control"]).toBe("no-store");
|
|
const serverInfo = getServerInfoSnapshot();
|
|
expect(response.body).toEqual({ status: "ok", commit: serverInfo.git.available ? serverInfo.git.fullSha : null });
|
|
}
|
|
const head = await f.http.head("/api/liveness").expect(200);
|
|
expect(head.text).toBeUndefined();
|
|
expect(f.auth).not.toHaveBeenCalled();
|
|
expect(f.db.execute).not.toHaveBeenCalled();
|
|
expect(idleWorkSnapshot().active).toBe(0);
|
|
if (!standby) {
|
|
await f.http.get("/api/health").expect(503);
|
|
expect(f.db.execute).toHaveBeenCalledOnce();
|
|
await f.http.get("/api/private").expect(401);
|
|
expect(f.auth).toHaveBeenCalledTimes(2);
|
|
}
|
|
});
|
|
|
|
it.each(["starting", "recovering"] as const)("reports %s until startup recovery is complete", async phase => {
|
|
const f = fixture();
|
|
setStartupRecoveryPhase(phase);
|
|
await f.http.get("/api/liveness").expect(503).expect(response => expect(response.body.status).toBe("starting"));
|
|
setStartupRecoveryPhase("ready");
|
|
await f.http.get("/api/liveness").expect(200);
|
|
expect(f.auth).not.toHaveBeenCalled();
|
|
expect(f.db.execute).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it("retains hostname and signed bootstrap endpoint validation", async () => {
|
|
const f = fixture();
|
|
await f.http.get("/api/liveness").set("host", "denied.example").expect(403);
|
|
await f.http.get("/api/liveness").set("x-paperclip-cloud-runtime-identity", "invalid-fixture")
|
|
.expect(400).expect({ error: "cloud_runtime_identity_wrong_endpoint" });
|
|
expect(f.auth).not.toHaveBeenCalled();
|
|
expect(f.db.execute).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it("stays reachable during drain without exempting writes or other paths", async () => {
|
|
const f = fixture();
|
|
const before = idleWorkSnapshot();
|
|
startTaskDrain({ purpose: "idle", ttlMs: 60_000 });
|
|
for (const path of ["/api/liveness", "/api/liveness/"]) {
|
|
await f.http.get(path).expect(200);
|
|
await f.http.head(path).expect(200);
|
|
await f.http.post(path).expect(503);
|
|
}
|
|
await f.http.get("/api/liveness/details").expect(503);
|
|
await f.http.get("/api/private").expect(503);
|
|
expect(idleWorkSnapshot()).toEqual(before);
|
|
expect(f.auth).not.toHaveBeenCalled();
|
|
expect(f.db.execute).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it("mounts the production route after host and bootstrap validation and before standby/auth", () => {
|
|
const source = readFileSync(new URL("../app.ts", import.meta.url), "utf8");
|
|
const route = source.indexOf('app.use("/api/liveness", livenessRoutes())');
|
|
expect(route).toBeGreaterThan(source.indexOf("privateHostnameGuard({"));
|
|
expect(route).toBeGreaterThan(source.indexOf("app.use(cloudRuntimeIdentityMiddleware(db))"));
|
|
expect(route).toBeLessThan(source.indexOf("app.use(cloudWarmStandbyMiddleware("));
|
|
expect(route).toBeLessThan(source.indexOf("actorMiddleware(db,"));
|
|
});
|
|
});
|