mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-16 05:17:41 +02:00
## Thinking Path > - Paperclip is the control plane for autonomous AI companies, where operators need a reliable way to find and act on work awaiting their input. > - The attention and issue-thread interaction subsystems expose those decision points across server APIs and the board UI. > - The previous navigation and interaction presentation left these actions fragmented and did not offer a controlled rollout for the Decisions surface. > - This branch adds the attention feed, richer interaction cards, grouping, dismiss/snooze behavior, and a gated Decisions sidebar entry. > - It also keeps experimental settings and API contracts synchronized, with an idempotent migration for the new dismissal state. > - This pull request delivers the complete, tested attention/Decisions experience as one reviewable unit. ## Linked Issues or Issue Description - Adds an operator-focused attention queue and Decisions experience: grouped decision cards, semantic interaction actions, dismiss/snooze handling, resilient interaction states, and an experimental flag to control the Decisions navigation entry. ## Feature Context ### Problem or Motivation Operators currently have to hunt across approvals, interactions, failed runs, and budget alerts to find decisions that need their action. ### Proposed Solution Provide a gated Decisions attention queue that groups actionable items, supports direct resolution, and preserves operator control through dismiss and snooze actions. ### Alternatives Considered Keep separate, source-specific views only; this leaves cross-cutting operator decisions fragmented and harder to prioritize. ### Roadmap Alignment This improves the V1 control-plane operator workflow by making pending governed actions discoverable in one company-scoped surface. ## What Changed - Added server attention-feed services, routes, interaction handling, dismiss/snooze support, and an idempotent `0145` inbox-dismissal migration. - Added shared attention, inbox-dismissal, and experimental-settings contracts. - Added Decisions/attention UI, interaction-card states, sidebar badge/navigation integration, grouping, keyboard support, and Storybook coverage. - Added tests for attention behavior, thread interactions, settings normalization, dismissals, and API behavior. - Removed generated screenshots from the final PR diff and rebased the branch onto current `master`. ## Verification - `pnpm check:token-gates` — passed. - `pnpm exec vitest run packages/shared/src/issue-thread-interactions.test.ts server/src/__tests__/attention-service.test.ts server/src/__tests__/inbox-dismissals.test.ts server/src/__tests__/issue-thread-interactions-service.test.ts server/src/__tests__/issue-thread-interaction-routes.test.ts ui/src/lib/attention.test.ts ui/src/components/AttentionQueueRow.test.tsx ui/src/components/IssueThreadInteractionCard.test.tsx ui/src/pages/InstanceExperimentalSettings.test.tsx` — passed: 158 tests across 9 focused files. - GitHub Actions for `ad636f560`: build and typecheck/release-registry have passed; remaining general-server and Greptile checks are in progress. ## Risks - Moderate: this is a cross-layer attention/interaction feature with a new migration and navigation behavior. - The `enableDecisions` experimental setting defaults to off, limiting rollout impact. - Existing dismissal data is backfilled to `dismiss`; the migration is idempotent and uses guarded constraint creation. > ROADMAP.md was checked; no duplicate planned core feature was identified. Related open pull requests were searched before opening this PR. ## Model Used - OpenAI GPT-5.5 via Codex CLI, with tool use and local code execution. Context-window size unavailable in this environment. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My public PR branch name describes the change and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally; focused tests pass and the remaining unrelated AWS test failure is documented above - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [ ] All Paperclip CI gates are green - [ ] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing> Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
322 lines
9.2 KiB
TypeScript
322 lines
9.2 KiB
TypeScript
// @vitest-environment jsdom
|
|
|
|
import { describe, expect, it, vi } from "vitest";
|
|
import {
|
|
findPageSearchShortcutTarget,
|
|
focusPageSearchShortcutTarget,
|
|
hasBlockingShortcutDialog,
|
|
isKeyboardShortcutTextInputTarget,
|
|
resolveAttentionQueueKeyAction,
|
|
resolveIssueDetailGoKeyAction,
|
|
resolveInboxQuickArchiveKeyAction,
|
|
resolveInboxUndoArchiveKeyAction,
|
|
shouldBlurPageSearchOnEnter,
|
|
shouldBlurPageSearchOnEscape,
|
|
} from "./keyboardShortcuts";
|
|
|
|
describe("keyboardShortcuts helpers", () => {
|
|
describe("resolveAttentionQueueKeyAction", () => {
|
|
const baseArgs = {
|
|
defaultPrevented: false,
|
|
metaKey: false,
|
|
ctrlKey: false,
|
|
altKey: false,
|
|
target: document.body,
|
|
hasOpenDialog: false,
|
|
hasSelection: true,
|
|
};
|
|
|
|
it.each([
|
|
["j", "next"],
|
|
["ArrowDown", "next"],
|
|
["k", "previous"],
|
|
["ArrowUp", "previous"],
|
|
["Enter", "toggle"],
|
|
["x", "dismiss"],
|
|
] as const)("maps %s to %s", (key, expected) => {
|
|
expect(resolveAttentionQueueKeyAction({ ...baseArgs, key })).toBe(expected);
|
|
});
|
|
|
|
it("does not act while typing, dialog-bound, modified, or unselected", () => {
|
|
const input = document.createElement("input");
|
|
expect(resolveAttentionQueueKeyAction({ ...baseArgs, key: "j", target: input })).toBe("ignore");
|
|
expect(resolveAttentionQueueKeyAction({ ...baseArgs, key: "j", hasOpenDialog: true })).toBe("ignore");
|
|
expect(resolveAttentionQueueKeyAction({ ...baseArgs, key: "j", metaKey: true })).toBe("ignore");
|
|
expect(resolveAttentionQueueKeyAction({ ...baseArgs, key: "Enter", hasSelection: false })).toBe("ignore");
|
|
});
|
|
});
|
|
|
|
it("detects editable shortcut targets", () => {
|
|
const wrapper = document.createElement("div");
|
|
wrapper.innerHTML = `
|
|
<div contenteditable="true"><span id="contenteditable-child">Editable</span></div>
|
|
<div role="textbox"><span id="textbox-child">Textbox</span></div>
|
|
<button id="button">Action</button>
|
|
`;
|
|
|
|
const editableChild = wrapper.querySelector("#contenteditable-child");
|
|
const textboxChild = wrapper.querySelector("#textbox-child");
|
|
const button = wrapper.querySelector("#button");
|
|
|
|
expect(isKeyboardShortcutTextInputTarget(editableChild)).toBe(true);
|
|
expect(isKeyboardShortcutTextInputTarget(textboxChild)).toBe(true);
|
|
expect(isKeyboardShortcutTextInputTarget(button)).toBe(false);
|
|
});
|
|
|
|
it("reports when a modal dialog is open", () => {
|
|
const root = document.createElement("div");
|
|
root.innerHTML = `<div role="dialog" aria-modal="true"></div>`;
|
|
|
|
expect(hasBlockingShortcutDialog(root)).toBe(true);
|
|
expect(hasBlockingShortcutDialog(document.createElement("div"))).toBe(false);
|
|
});
|
|
|
|
it("ignores non-dialog elements that happen to be aria-modal", () => {
|
|
const root = document.createElement("div");
|
|
root.innerHTML = `<section aria-modal="true"></section>`;
|
|
|
|
expect(hasBlockingShortcutDialog(root)).toBe(false);
|
|
});
|
|
|
|
it("finds the visible page search shortcut target", () => {
|
|
const root = document.createElement("div");
|
|
const hidden = document.createElement("input");
|
|
hidden.setAttribute("data-page-search-target", "true");
|
|
vi.spyOn(hidden, "getClientRects").mockReturnValue([] as unknown as DOMRectList);
|
|
|
|
const visible = document.createElement("input");
|
|
visible.setAttribute("data-page-search-target", "true");
|
|
vi.spyOn(visible, "getClientRects").mockReturnValue([{}] as unknown as DOMRectList);
|
|
|
|
root.append(hidden, visible);
|
|
document.body.appendChild(root);
|
|
|
|
expect(findPageSearchShortcutTarget(root)).toBe(visible);
|
|
|
|
root.remove();
|
|
});
|
|
|
|
it("focuses and selects the page search shortcut target", () => {
|
|
const root = document.createElement("div");
|
|
const input = document.createElement("input");
|
|
input.value = "existing query";
|
|
input.setAttribute("data-page-search-target", "true");
|
|
vi.spyOn(input, "getClientRects").mockReturnValue([{}] as unknown as DOMRectList);
|
|
root.appendChild(input);
|
|
document.body.appendChild(root);
|
|
|
|
expect(focusPageSearchShortcutTarget(root)).toBe(true);
|
|
expect(document.activeElement).toBe(input);
|
|
expect(input.selectionStart).toBe(0);
|
|
expect(input.selectionEnd).toBe(input.value.length);
|
|
|
|
root.remove();
|
|
});
|
|
|
|
it("blurs page search on a plain Enter press", () => {
|
|
expect(shouldBlurPageSearchOnEnter({
|
|
key: "Enter",
|
|
isComposing: false,
|
|
})).toBe(true);
|
|
});
|
|
|
|
it("keeps focus while composing with an IME", () => {
|
|
expect(shouldBlurPageSearchOnEnter({
|
|
key: "Enter",
|
|
isComposing: true,
|
|
})).toBe(false);
|
|
});
|
|
|
|
it("blurs page search on Escape when the field is already empty", () => {
|
|
expect(shouldBlurPageSearchOnEscape({
|
|
key: "Escape",
|
|
isComposing: false,
|
|
currentValue: "",
|
|
})).toBe(true);
|
|
});
|
|
|
|
it("keeps focus on the first Escape while the field still has text", () => {
|
|
expect(shouldBlurPageSearchOnEscape({
|
|
key: "Escape",
|
|
isComposing: false,
|
|
currentValue: "query",
|
|
})).toBe(false);
|
|
});
|
|
|
|
it("archives only the first clean y press", () => {
|
|
const button = document.createElement("button");
|
|
|
|
expect(resolveInboxQuickArchiveKeyAction({
|
|
armed: true,
|
|
defaultPrevented: false,
|
|
key: "y",
|
|
metaKey: false,
|
|
ctrlKey: false,
|
|
altKey: false,
|
|
target: button,
|
|
hasOpenDialog: false,
|
|
})).toBe("archive");
|
|
});
|
|
|
|
it("ignores non-y keypresses", () => {
|
|
const button = document.createElement("button");
|
|
|
|
expect(resolveInboxQuickArchiveKeyAction({
|
|
armed: true,
|
|
defaultPrevented: false,
|
|
key: "n",
|
|
metaKey: false,
|
|
ctrlKey: false,
|
|
altKey: false,
|
|
target: button,
|
|
hasOpenDialog: false,
|
|
})).toBe("ignore");
|
|
});
|
|
|
|
it("stays inert for modifier combos before a real keypress", () => {
|
|
const button = document.createElement("button");
|
|
|
|
expect(resolveInboxQuickArchiveKeyAction({
|
|
armed: true,
|
|
defaultPrevented: false,
|
|
key: "Meta",
|
|
metaKey: false,
|
|
ctrlKey: false,
|
|
altKey: false,
|
|
target: button,
|
|
hasOpenDialog: false,
|
|
})).toBe("ignore");
|
|
|
|
expect(resolveInboxQuickArchiveKeyAction({
|
|
armed: true,
|
|
defaultPrevented: false,
|
|
key: "y",
|
|
metaKey: true,
|
|
ctrlKey: false,
|
|
altKey: false,
|
|
target: button,
|
|
hasOpenDialog: false,
|
|
})).toBe("ignore");
|
|
});
|
|
|
|
it("ignores input typing instead of archiving", () => {
|
|
const input = document.createElement("input");
|
|
|
|
expect(resolveInboxQuickArchiveKeyAction({
|
|
armed: true,
|
|
defaultPrevented: false,
|
|
key: "y",
|
|
metaKey: false,
|
|
ctrlKey: false,
|
|
altKey: false,
|
|
target: input,
|
|
hasOpenDialog: false,
|
|
})).toBe("ignore");
|
|
});
|
|
|
|
it("undoes only a clean lowercase u press when an archive is available", () => {
|
|
const button = document.createElement("button");
|
|
|
|
expect(resolveInboxUndoArchiveKeyAction({
|
|
hasUndoableArchive: true,
|
|
defaultPrevented: false,
|
|
key: "u",
|
|
metaKey: false,
|
|
ctrlKey: false,
|
|
altKey: false,
|
|
target: button,
|
|
hasOpenDialog: false,
|
|
})).toBe("undo_archive");
|
|
});
|
|
|
|
it("keeps uppercase U available for mark-unread handling", () => {
|
|
const button = document.createElement("button");
|
|
|
|
expect(resolveInboxUndoArchiveKeyAction({
|
|
hasUndoableArchive: true,
|
|
defaultPrevented: false,
|
|
key: "U",
|
|
metaKey: false,
|
|
ctrlKey: false,
|
|
altKey: false,
|
|
target: button,
|
|
hasOpenDialog: false,
|
|
})).toBe("ignore");
|
|
});
|
|
|
|
it("arms go-to-inbox on a clean g press", () => {
|
|
const button = document.createElement("button");
|
|
|
|
expect(resolveIssueDetailGoKeyAction({
|
|
armed: false,
|
|
defaultPrevented: false,
|
|
key: "g",
|
|
metaKey: false,
|
|
ctrlKey: false,
|
|
altKey: false,
|
|
target: button,
|
|
hasOpenDialog: false,
|
|
})).toBe("arm");
|
|
});
|
|
|
|
it("navigates to inbox on i after g", () => {
|
|
const button = document.createElement("button");
|
|
|
|
expect(resolveIssueDetailGoKeyAction({
|
|
armed: true,
|
|
defaultPrevented: false,
|
|
key: "i",
|
|
metaKey: false,
|
|
ctrlKey: false,
|
|
altKey: false,
|
|
target: button,
|
|
hasOpenDialog: false,
|
|
})).toBe("navigate_inbox");
|
|
});
|
|
|
|
it("focuses the comment composer on c after g", () => {
|
|
const button = document.createElement("button");
|
|
|
|
expect(resolveIssueDetailGoKeyAction({
|
|
armed: true,
|
|
defaultPrevented: false,
|
|
key: "c",
|
|
metaKey: false,
|
|
ctrlKey: false,
|
|
altKey: false,
|
|
target: button,
|
|
hasOpenDialog: false,
|
|
})).toBe("focus_comment");
|
|
});
|
|
|
|
it("opens the file viewer on f after g", () => {
|
|
const button = document.createElement("button");
|
|
|
|
expect(resolveIssueDetailGoKeyAction({
|
|
armed: true,
|
|
defaultPrevented: false,
|
|
key: "f",
|
|
metaKey: false,
|
|
ctrlKey: false,
|
|
altKey: false,
|
|
target: button,
|
|
hasOpenDialog: false,
|
|
})).toBe("open_file_viewer");
|
|
});
|
|
|
|
it("disarms go-to-inbox instead of firing from an editor", () => {
|
|
const input = document.createElement("textarea");
|
|
|
|
expect(resolveIssueDetailGoKeyAction({
|
|
armed: true,
|
|
defaultPrevented: false,
|
|
key: "i",
|
|
metaKey: false,
|
|
ctrlKey: false,
|
|
altKey: false,
|
|
target: input,
|
|
hasOpenDialog: false,
|
|
})).toBe("disarm");
|
|
});
|
|
});
|