mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-11-14 00:26:28 +01:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work > - Agents split work into child tasks, and each task runs in an execution workspace (a checkout, branch, or sandbox folder) > - Since early 2026, a new child task used its parent's realized workspace by default: the same checkout, branch and sandbox > - A parent and its child often run at the same time. Two writers in one folder lose each other's files, the waking parent is cancelled with `workspace_busy`, and sandbox lease ownership crosses from the parent into the child, so retained-file recovery refuses the workspace as ambiguous > - The product rule is simple: a subtask gets its own workspace, independent of the parent's saved files. Paperclip never needs to carry a parent's unmerged changes into a child > - This pull request makes that the only behaviour on every creation path, and moves existing shared children to their own workspace on their next run, with no user or admin action > - The benefit is that parents and children never block or overwrite each other, and recovery ownership stays with one task ## Linked Issues or Issue Description **What happened?** A child task inherited its parent's realized execution workspace by default (`createChild` defaulted to `executionWorkspaceInheritanceMode: "linkage"`, and `issueService.create` fell back from `inheritExecutionWorkspaceFromIssueId` to `parentId`). When the parent woke while the child wrote to the shared workspace, the parent run was cancelled with `workspace_busy`. In sandbox environments, the lease ownership chain crossed from the parent into the child, and retained-file recovery refused the workspace with `allocation_ownership_ambiguous`. **Expected behavior** Every new child task gets its own execution workspace, realized from the project base exactly as a top-level task in that project. It never uses the parent's checkout, branch, saved snapshot or unmerged changes. A parent and its descendant never share a workspace by any route. **Steps to reproduce** 1. Run a parent task in a project with isolated (git worktree) or sandbox workspaces, so the parent has a realized execution workspace. 2. From the parent run, create a child task with only `parentId` (or through the runner `create_task` tool, chat suggestions, decision effects, plugins, or the New sub-task dialog). 3. See that the child's `executionWorkspaceId` is the parent's, with `executionWorkspacePreference: "reuse_existing"`. 4. Wake the parent while the child runs in a sandbox environment. The parent run is cancelled with `workspace_busy`. **Additional context** Refs #9233 (the existing `strategy_only` opt-out). The opt-out `executionWorkspaceInheritanceMode: "strategy_only"` already existed for accepted-plan decomposition. This change makes that behaviour (tightened to drop a pinned existing branch) the only behaviour. ## What Changed - **One rule for every creation path (`server/src/services/issues.ts`).** `issueService.create` still uses the parent (or `inheritExecutionWorkspaceFromIssueId`) as a source for the project, project workspace and workspace *strategy*, but it never copies the source's `executionWorkspaceId`, `reuse_existing` preference, or pinned existing branch. All server paths that create a task go through `create()`/`createChild()`: issue routes (`POST /issues`, `POST /issues/:id/children`, the run-bound default parent and run workspace source), runner `create_task`, chat suggestion acceptance, native status decisions, accepted-plan decomposition, decision effects, plugins (`ctx.issues.create`), external agents, watchdog follow-ups, monitor recovery issues, case handoffs and email channels. - **Explicit ancestor workspaces are dropped.** If a create names an `executionWorkspaceId` (or an `existing` workspace selection) that an ancestor of the new task created or is bound to, `create()` drops it and keeps only the strategy. Older clients and skills that copied the parent's id keep working and get an independent workspace. - **`createChild` no longer has a "linkage" mode.** `executionWorkspaceInheritanceMode` is still accepted from internal callers and is ignored. - **`inheritExecutionWorkspaceFromIssueId` decision.** I kept the field for API compatibility, but it now copies only the source issue's project and workspace strategy. I removed its workspace-sharing behaviour for every pair, not only parent/child: the source task and its follow-up can run at the same time (the runner, watchdog and status-decision callers all create the follow-up while the source run is live), so sharing would again let two tasks write one folder. Explicit sharing between unrelated tasks stays available through an explicit `existing` workspace selection. - **New `server/src/services/task-workspace-lineage.ts`.** `buildIndependentTaskWorkspaceSettings` (strategy only: mode, environment, runtime, network egress, shared-workspace concurrency, base ref, branch template, commands; no `reuse_existing`, no `operator_branch`, no `existingBranch`), `loadTaskLineageIssueIds` (the parent chain plus, for a task that depth placement put beside its requester, the requester's chain via `privacyParentIssueId`) and `isAncestorExecutionWorkspace` (the workspace's `sourceIssueId` is in that lineage, or a lineage issue is bound to it). A child in another project does not take the parent's strategy. - **Upgrade-safe rebind at admission.** `executionWorkspaceService.releaseAncestorWorkspaceBindingAtAdmission` runs at the same admission point as the pending workspace selection (`heartbeat.ts`). For a child (or a flattened task beside its requester) that an older release bound to an ancestor's workspace, it clears the child's binding (keeps the project workspace and strategy, bumps the binding revision) so the run realizes the child's own workspace. It does nothing while another run of the child is running, while the child's earlier run still owns workspace finalization or recovery, for native restart/lease-owner recovery, for a process-loss retry, or for a Retry that keeps the current workspace. The parent and its workspace are never changed. - **Projects without a project workspace (per-task repository acquisition).** A parent with no project workspace worked in its own task files, so its settings (for example `isolated_workspace`) do not describe the project base. A child of such a parent, and an older child released from one, takes the project's defaults exactly like a top-level task, instead of an isolated mode that would resolve to a git worktree with no git base ("needs a project / project workspace"). When the child's new workspace is created at admission, `executionWorkspaceRepositoryService.prepareForAdmission` repeats the parent's (or requester's) repository requests as the child's own pending requests (identity, URL, catalog id and requested ref only; no pinned commit, branch or files). The normal acquisition path then clones a fresh copy into the child's task files with the child's own access checks. This runs only for a workspace created by that admission, so existing tasks never gain repositories. - **UI.** The New sub-task dialog no longer pre-selects the parent's workspace. `buildSubIssueDefaults` drops `executionWorkspaceId` and `reuse_existing`, and derives the parent's independent mode (`shared_workspace`, `isolated_workspace` or `agent_default`) from its preference, saved settings or current workspace. The "This sub-task will no longer use the parent task workspace" warning is removed. - **Contracts and docs.** Shared validator and plugin SDK comments describe the new meaning of `inheritExecutionWorkspaceFromIssueId`. Updated `doc/execution-semantics.md` (new rule in §6 and a wording fix in the retained-sandbox paragraph), `doc/SPEC-implementation.md` (child workspace rule, requester keeps *strategy* inheritance, watchdog follow-ups), `doc/SPEC.md` (task workspace ownership), `docs/specs/external-task-protocol.md`, `skills/paperclip/SKILL.md` (step 9 and the workspace bullet), `skills/paperclip/references/issue-workspaces.md`, the CEO onboarding `HEARTBEAT.md`, and the plugin SDK README. ### Previous-release story (`rules/upgrade-safe-run-state.mdc`) - **Migrated on next admission.** A child that the previous release bound to its parent's (or any ancestor's) execution workspace keeps that binding until its next normal admission. Then the server clears the binding and the run realizes the child's own workspace from the project base. No schema migration is needed. No user or admin action is needed. - **In-flight writers finish first.** A running child is not interrupted. Its current run, its native restart recovery (admitted native input or lease owner), a process-loss retry, and a Retry that keeps the current workspace all finish in the shared workspace. While a child's earlier run is still running or its workspace finalization or recovery is unsettled, the binding stays and a later admission releases it. - **No files are dropped.** The release changes only the child's binding row. The parent keeps its binding, and the shared workspace row, folder, branch and saved snapshots are not touched. Anything the child left there stays in the parent's workspace. - **No new refusal codes.** Saved run identity (native execution input, leases, checkpoints) is not changed or refused; the rebind only affects new admissions. ## Verification - New `server/src/__tests__/subtask-workspace-independence.test.ts` (embedded Postgres): `create` with `parentId`, `createChild` with no mode / `"linkage"` / `"strategy_only"`, `inheritExecutionWorkspaceFromIssueId` pointing at the parent, explicit parent and grandparent `executionWorkspaceId`, a non-child follow-up, and unchanged top-level defaults and explicit top-level reuse. 7 creation cases fail on `master` and pass with this change. Admission cases: an old-release child is rebound while its parent is running and the parent keeps its workspace; a running child is not rebound (deploy lands mid-run); an unrelated explicit share is kept; the parent is never rebound. - New heartbeat case in `server/src/__tests__/heartbeat-workspace-busy.test.ts`: an old-release child bound to its running parent's workspace in a sandbox environment runs to `succeeded` with no `workspace_busy`, gets a new workspace, and the parent run and binding stay unchanged. It fails on `master` (the child waits with `workspace_busy`). - Updated tests that asserted the old inheritance in `issues-service.test.ts`, `task-workspace-binding.test.ts`, `chat-project-tools.test.ts`, `task-workspace-child-trust.test.ts`, `heartbeat-git-restore-point-resume.test.ts` (a child bound to a closed parent's expired workspace now starts from the project base and leaves the parent's restore point alone), and `ui/src/lib/subIssueDefaults.test.ts`. Remote-workspace reservation, continuation and writer-wait suites now seed the older-release shared shape directly (or an unrelated explicit share), so those safety paths stay covered. - `npx vitest run` on the changed suites and about 45 related server suites (heartbeat workspace, recovery admission, issue routes, routines, plugins), `ui` `subIssueDefaults` and `NewIssueDialog` tests, `pnpm check:token-gates`, `pnpm -r typecheck`. - New `server/src/__tests__/heartbeat-subtask-acquired-repository.test.ts`: a project with no project workspace, a parent whose task files hold an acquired repository with an unmerged change, and a child (new, and the older-release shape bound to the parent's workspace) that runs to `succeeded` in its own task files with a fresh clone at the project base and its own ready repository receipt. The parent's checkout keeps its change. Both cases fail on the previous head with "needs a project / project workspace". ## Risks - **Project-level configuration still applies to children exactly as to top-level tasks.** In a project configured for `shared_workspace`, every task (top-level or child) uses the project's one folder under the existing shared-workspace concurrency policy. A branch that the project itself pins applies to every task in the project. This PR removes only the parent-to-child carry-over of the realized workspace; it does not change those project defaults. - **Standalone follow-ups that an older release bound through `inheritExecutionWorkspaceFromIssueId`** are migrated only when the source is in their recorded lineage (parent or privacy parent). Others keep their explicit share and the existing writer-wait serialization. - **Behaviour change for agents that relied on a shared checkout.** A child or follow-up no longer sees the parent's unpushed or uncommitted changes. Agents must push or merge code they want a subtask to build on. The skill and onboarding text now say this. - **Explicit ancestor workspace ids are silently dropped** instead of rejected, so older clients do not break. The task gets an independent workspace. - **First run of a migrated child starts from the project base.** If an older child had uncommitted work in the parent's workspace, that work stays in the parent's workspace and is not copied into the child's new workspace. - **Admission adds one indexed read** for tasks with a parent and a bound workspace; the locking transaction and ancestor query run only when the bound workspace was created by another issue. ## Model Used - Claude Opus 5.5 (Anthropic), model ID `claude-opus-5-5`, used through Claude Code with tool use (file edits, shell, test execution) and extended reasoning. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
647 lines
51 KiB
TypeScript
647 lines
51 KiB
TypeScript
import { measureRunTransaction } from "./execution-transaction-timing.js";
|
|
import { prepareRemoteWorkspaceRepository, saveRemoteWorkspace, readRemoteWorkspaceAuthority } from "./remote-workspaces.js";
|
|
import type { AdapterExecutionTarget } from "@paperclipai/adapter-utils/execution-target";
|
|
import type { EnvironmentLease } from "@paperclipai/shared";
|
|
import { beginRunPhase, measureRunPhase } from "./execution-preparation-timing.js";
|
|
import { createHash, randomUUID } from "node:crypto";
|
|
import { execFile as execFileCallback } from "node:child_process";
|
|
import { promisify } from "node:util";
|
|
import fs from "node:fs/promises";
|
|
import { constants as fsConstants } from "node:fs";
|
|
import path from "node:path";
|
|
import { and, eq, isNull, or, sql } from "drizzle-orm";
|
|
import { activityLog, agents, heartbeatRuns, projects, projectWorkspaces, executionWorkspaceRepositories, executionWorkspaces, issues, type Db } from "@paperclipai/db";
|
|
import { prepareWorkspaceRepositorySchema, type PrepareWorkspaceRepository, type ProjectRepository } from "@paperclipai/shared";
|
|
import { withDirectoryPublicationLock } from "@paperclipai/adapter-utils/workspace-restore-merge";
|
|
import { conflict, forbidden, notFound } from "../errors.js";
|
|
import { parseNativeExecutionInput } from "../vendor/paperclip-runner/index.js";
|
|
import { assertTaskWorkspaceExecutionAccess, assertTaskWorkspaceSourceProjectAccess } from "./task-workspace-access.js";
|
|
import { authorizationService, issueReadSqlCondition, type AuthorizationActor } from "./authorization.js";
|
|
import { taskWorkspaceSelectableCondition } from "./task-workspace-selection.js";
|
|
import { captureRunIdentity } from "./run-identity.js";
|
|
import { toolAccessService } from "./tool-access.js";
|
|
import { normalizeProjectRepositoryUrl } from "./project-repositories.js";
|
|
import { buildGitAuthInvocation, createGitRemoteAuthProvider } from "./git-credentials.js";
|
|
import { materializeManagedProjectWorkspace, ensureManagedRepositoriesIgnored, RepositoryRefNotFoundError } from "./managed-repository-checkout.js";
|
|
import { requiresAnonymousRepositoryAcquisition, taskRepositoryRunColumns } from "./task-repository-acquisition.js";
|
|
|
|
import { canonicalRepositoryRoot } from "./execution-workspace-source-roots.js";
|
|
export { canonicalRepositoryRoot } from "./execution-workspace-source-roots.js";
|
|
|
|
const execFile = promisify(execFileCallback);
|
|
type RepositoryRow = typeof executionWorkspaceRepositories.$inferSelect;
|
|
type DbTransaction = Parameters<Parameters<Db["transaction"]>[0]>[0];
|
|
const controllerAcquisitionMessage = "New controller repository acquisition requires a trusted task. Existing verified public checkouts remain available.";
|
|
const REPOSITORY_REF_NOT_FOUND = "repository_ref_not_found";
|
|
const repositoryRetryConflictMessage = "Repository preparation conflicts with an existing receipt. A different ref requires a separate workspace; existing files are never switched automatically.";
|
|
const lowTrustRepositoryMessage = "Low-trust repository reuse permits anonymous public URLs only; new acquisition is unavailable. Use an authorized configured source for private repositories.";
|
|
|
|
function withRepositoryPublication<T>(cwd: string, work: () => Promise<T>): Promise<T> {
|
|
return measureRunPhase("workspace.repository.publication", async () => {
|
|
const finishWait = beginRunPhase("workspace.repository.lock_wait");
|
|
let finishRelease: ((failed?: boolean) => void) | undefined;
|
|
let bodyFailed = false;
|
|
let bodyError: unknown;
|
|
let failed = false;
|
|
let releaseFailed = false;
|
|
try {
|
|
return await withDirectoryPublicationLock(cwd, async () => {
|
|
finishWait();
|
|
try {
|
|
return await measureRunPhase("workspace.repository.critical_section", work);
|
|
} catch (error) {
|
|
bodyFailed = true;
|
|
bodyError = error;
|
|
throw error;
|
|
} finally {
|
|
// The adapter releases the lock after this callback settles. Keep that
|
|
// interval separate from the callback rather than calling it held time.
|
|
finishRelease = beginRunPhase("workspace.repository.lock_release");
|
|
}
|
|
});
|
|
} catch (error) {
|
|
failed = true;
|
|
releaseFailed = !bodyFailed || error !== bodyError;
|
|
throw error;
|
|
} finally {
|
|
finishWait(failed);
|
|
finishRelease?.(releaseFailed);
|
|
}
|
|
});
|
|
}
|
|
|
|
function resolveAcquisitionSource(request: PrepareWorkspaceRepository["repository"], available: ProjectRepository[], anonymousOnly: boolean) {
|
|
if (anonymousOnly && request.kind === "catalog") throw forbidden(lowTrustRepositoryMessage);
|
|
return resolveTaskRepository(request, anonymousOnly ? [] : available);
|
|
}
|
|
|
|
/**
|
|
* A receipt whose requested ref was proven absent can take a corrected ref only
|
|
* while nothing was ever published for it. Published files are never switched.
|
|
*/
|
|
async function refCorrectionAllowed(row: RepositoryRow, workspace: Pick<typeof executionWorkspaces.$inferSelect, "cwd" | "metadata">) {
|
|
if (row.state !== "needs_repair" || row.failureCode !== REPOSITORY_REF_NOT_FOUND || row.pinnedCommit) return false;
|
|
// A remote checkout cannot be inspected from the control plane; keep it immutable.
|
|
if (!workspace.cwd || readRemoteWorkspaceAuthority(workspace.metadata)) return false;
|
|
// Only proven absence allows correction; an unreadable path keeps the receipt.
|
|
return !await fs.lstat(path.join(workspace.cwd, row.relativePath)).catch((error: NodeJS.ErrnoException) => {
|
|
if (error.code === "ENOENT") return null;
|
|
throw error;
|
|
});
|
|
}
|
|
|
|
function assertAcquisitionReceipt(row: Pick<RepositoryRow, "catalogRepositoryId">, anonymousOnly: boolean) {
|
|
if (anonymousOnly && row.catalogRepositoryId) throw forbidden(lowTrustRepositoryMessage);
|
|
}
|
|
|
|
export function resolveTaskRepository(request: PrepareWorkspaceRepository["repository"], available: ProjectRepository[]) {
|
|
const selected = request.kind === "catalog" ? available.find(repo => repo.id === request.id) : null;
|
|
if (request.kind === "catalog" && !selected) throw forbidden("Repository access is no longer available; refresh the repository catalog");
|
|
const source = normalizeProjectRepositoryUrl(selected?.url ?? (request.kind === "url" ? request.url : ""));
|
|
const match = selected ?? available.find(repo => normalizeProjectRepositoryUrl(repo.url).url.toLowerCase() === source.url.toLowerCase());
|
|
return { repoUrl: source.url, repositoryIdentity: source.url.toLowerCase(), catalogRepositoryId: match?.id ?? null };
|
|
}
|
|
|
|
export function taskRepositoryRelativePath(identity: string) {
|
|
return `.paperclip-repositories/task-repo-${createHash("sha256").update(identity).digest("hex").slice(0, 24)}`;
|
|
}
|
|
|
|
export function assertRepositoryRetryMatches(row: Pick<RepositoryRow, "repositoryIdentity" | "requestedRef">, identity: string, ref: string) {
|
|
if (row.repositoryIdentity !== identity || row.requestedRef !== ref) {
|
|
throw conflict(repositoryRetryConflictMessage);
|
|
}
|
|
}
|
|
|
|
export function executionWorkspaceRepositoryService(db: Db) {
|
|
async function catalog(companyId: string, userId: string | null, localTrusted: boolean, requiredRepositoryIds: string[] = []) {
|
|
return measureRunPhase("workspace.repository.catalog", async () =>
|
|
(await toolAccessService(db).listProjectRepositories(companyId, userId, localTrusted, { requiredRepositoryIds })).repositories);
|
|
}
|
|
async function requiresAnonymousAcquisition(reader: Db | DbTransaction, input: {
|
|
issue: typeof issues.$inferSelect; workspace: Pick<typeof executionWorkspaces.$inferSelect, "projectId"> | null;
|
|
agentId?: string | null; runId?: string | null;
|
|
}) {
|
|
return measureRunPhase("workspace.repository.current_policy", async () => {
|
|
const { issue, workspace } = input;
|
|
const agentId = input.agentId ?? issue.assigneeAgentId;
|
|
const [agent] = agentId ? await measureRunPhase("workspace.repository.db.agent", () => reader.select().from(agents).where(and(eq(agents.id, agentId), eq(agents.companyId, issue.companyId)))) : [];
|
|
if (agentId && !agent) throw forbidden("Task repository agent is unavailable");
|
|
const [project] = issue.projectId ? await measureRunPhase("workspace.repository.db.project", () => reader.select().from(projects).where(and(eq(projects.id, issue.projectId!), eq(projects.companyId, issue.companyId)))) : [];
|
|
const [workspaceSourceProject] = workspace?.projectId ? await measureRunPhase("workspace.repository.db.project", () => reader.select().from(projects).where(and(eq(projects.id, workspace.projectId!), eq(projects.companyId, issue.companyId)))) : [];
|
|
const runId = input.runId ?? issue.executionRunId;
|
|
const [run] = runId ? await measureRunPhase("workspace.repository.db.run", () => reader.select(taskRepositoryRunColumns).from(heartbeatRuns).where(and(eq(heartbeatRuns.id, runId), eq(heartbeatRuns.companyId, issue.companyId)))) : [];
|
|
return requiresAnonymousRepositoryAcquisition({ companyId: issue.companyId, issue, agent, project,
|
|
workspaceSourceProject, run, agentId, runId, explicitRunId: input.runId });
|
|
});
|
|
}
|
|
async function assertCurrentControllerAcquisition(input: { companyId: string; issueId: string; workspaceId: string; agentId: string; runId: string }) {
|
|
return measureRunPhase("workspace.repository.acquisition", async () => {
|
|
const [issue] = await measureRunPhase("workspace.repository.db.issue", () => db.select().from(issues).where(and(eq(issues.id, input.issueId), eq(issues.companyId, input.companyId))));
|
|
const [workspace] = await measureRunPhase("workspace.repository.db.workspace", () => db.select().from(executionWorkspaces).where(and(eq(executionWorkspaces.id, input.workspaceId), eq(executionWorkspaces.companyId, input.companyId))));
|
|
if (!issue || !workspace || issue.executionWorkspaceId !== workspace.id) throw forbidden("Task repository workspace binding is unavailable");
|
|
if (await requiresAnonymousAcquisition(db, { issue, workspace, agentId: input.agentId, runId: input.runId })) throw forbidden(controllerAcquisitionMessage);
|
|
});
|
|
}
|
|
async function request(input: { companyId: string; issueId: string; actor: AuthorizationActor; request: PrepareWorkspaceRepository }) {
|
|
const parsed = prepareWorkspaceRepositorySchema.parse(input.request);
|
|
const [requestedIssue] = await db.select().from(issues).where(and(eq(issues.id, input.issueId), eq(issues.companyId, input.companyId), await issueReadSqlCondition(db, input.actor)));
|
|
if (!requestedIssue) throw notFound("Task not found");
|
|
const issueResource = (issue: typeof issues.$inferSelect) => ({ type: "issue" as const, companyId: issue.companyId, issueId: issue.id,
|
|
status: issue.status, assigneeAgentId: issue.assigneeAgentId, assigneeUserId: issue.assigneeUserId });
|
|
const decision = await authorizationService(db).decide({ actor: input.actor, action: "issue:mutate", resource: issueResource(requestedIssue) });
|
|
if (!decision.allowed) throw forbidden("Task workspace modification is not allowed");
|
|
let userId = input.actor.userId ?? null;
|
|
let localTrusted = input.actor.source === "local_implicit";
|
|
if (input.actor.type === "agent") {
|
|
if (input.actor.source !== "agent_jwt" || !input.actor.agentId || !input.actor.runId || input.actor.companyId !== input.companyId) throw forbidden("Repository preparation requires an authenticated task run");
|
|
const identity = await captureRunIdentity(db, { companyId: input.companyId, agentId: input.actor.agentId, runId: input.actor.runId }, { readScope: "task_authorization" });
|
|
const runIssueId = identity.run.nativeIssueId ?? identity.run.contextSnapshot?.issueId;
|
|
if (runIssueId !== input.issueId) throw forbidden("Repository preparation is scoped to the current task");
|
|
userId = identity.run.responsibleUserId;
|
|
localTrusted = userId === "local-board";
|
|
if (!userId) throw forbidden("Repository access requires a responsible user");
|
|
}
|
|
const available = await catalog(input.companyId, userId, localTrusted);
|
|
const requestedRef = parsed.ref ?? "HEAD";
|
|
const receipt = await measureRunTransaction(db, "workspace", async tx => {
|
|
const [issue] = await measureRunPhase("workspace.sources.inventory", async () => tx.select().from(issues).where(and(eq(issues.id, input.issueId), eq(issues.companyId, input.companyId), await issueReadSqlCondition(tx, input.actor))).for("no key update"));
|
|
if (!issue) throw notFound("Task not found");
|
|
const currentDecision = await authorizationService(tx).decide({ actor: input.actor, action: "issue:mutate", resource: issueResource(issue) });
|
|
if (!currentDecision.allowed) throw forbidden("Task workspace modification is not allowed");
|
|
if (input.actor.type === "agent" && !["standard", "skill_test"].includes(issue.workMode)) throw forbidden("Repository preparation is unavailable in Ask or Plan mode");
|
|
if (!issue.executionWorkspaceId) throw conflict("The task has no admitted workspace yet. Start it once before preparing a repository.");
|
|
const [workspace] = await measureRunPhase("workspace.sources.inventory", async () => tx.select().from(executionWorkspaces).where(and(eq(executionWorkspaces.id, issue.executionWorkspaceId!), eq(executionWorkspaces.companyId, input.companyId), taskWorkspaceSelectableCondition())).for("no key update"));
|
|
if (!workspace) throw conflict("Execution workspace is unavailable");
|
|
await assertTaskWorkspaceExecutionAccess(tx, input.actor, input.companyId, { issueId: input.issueId, workspaceId: workspace.id });
|
|
if (workspace.providerType === "adapter_managed") throw conflict("Repository preparation is unavailable for this environment-owned workspace");
|
|
const anonymousOnly = await requiresAnonymousAcquisition(tx, { issue, workspace,
|
|
agentId: input.actor.agentId, runId: input.actor.runId });
|
|
const source = resolveAcquisitionSource(parsed.repository, available, anonymousOnly);
|
|
if (!workspace.cwd) throw conflict("The task workspace has no directory for repository preparation");
|
|
if (anonymousOnly) throw forbidden(controllerAcquisitionMessage);
|
|
const existing = await measureRunPhase("workspace.sources.inventory", async () => tx.select().from(executionWorkspaceRepositories).where(and(eq(executionWorkspaceRepositories.companyId, input.companyId), eq(executionWorkspaceRepositories.executionWorkspaceId, workspace.id), or(eq(executionWorkspaceRepositories.repositoryIdentity, source.repositoryIdentity), sql`${executionWorkspaceRepositories.requestKeys} ? ${parsed.requestKey}`))));
|
|
for (const row of existing) assertAcquisitionReceipt(row, anonymousOnly);
|
|
if (existing.length === 1 && existing[0].repositoryIdentity === source.repositoryIdentity && existing[0].requestedRef !== requestedRef
|
|
&& await refCorrectionAllowed(existing[0], workspace)) {
|
|
const row = existing[0];
|
|
const [corrected] = await measureRunPhase("workspace.write", () => tx.update(executionWorkspaceRepositories).set({
|
|
requestedRef, state: "pending", failureCode: null, updatedAt: new Date(),
|
|
requestKeys: row.requestKeys.includes(parsed.requestKey) ? row.requestKeys : [...row.requestKeys, parsed.requestKey],
|
|
}).where(and(eq(executionWorkspaceRepositories.id, row.id), eq(executionWorkspaceRepositories.state, "needs_repair"),
|
|
eq(executionWorkspaceRepositories.requestedRef, row.requestedRef), isNull(executionWorkspaceRepositories.pinnedCommit))).returning());
|
|
if (!corrected) throw conflict(repositoryRetryConflictMessage);
|
|
await measureRunPhase("workspace.write", () => tx.insert(activityLog).values({ companyId: input.companyId, actorType: input.actor.type === "agent" ? "agent" : "user", actorId: input.actor.agentId ?? input.actor.userId ?? "local-board", action: "workspace.repository.ref_corrected", entityType: "execution_workspace", entityId: workspace.id, runId: input.actor.runId ?? null, responsibleUserId: userId, details: { repositoryId: row.id, issueId: input.issueId, previousRef: row.requestedRef, requestedRef, applies: "next_normal_admission" } }));
|
|
return corrected;
|
|
}
|
|
for (const row of existing) assertRepositoryRetryMatches(row, source.repositoryIdentity, requestedRef);
|
|
if (existing[0]) {
|
|
const row = existing[0];
|
|
if (!row.requestKeys.includes(parsed.requestKey)) {
|
|
const [updated] = await tx.update(executionWorkspaceRepositories).set({ requestKeys: [...row.requestKeys, parsed.requestKey] }).where(eq(executionWorkspaceRepositories.id, row.id)).returning();
|
|
return updated;
|
|
}
|
|
return row;
|
|
}
|
|
const [row] = await measureRunPhase("workspace.write", () => tx.insert(executionWorkspaceRepositories).values({ companyId: input.companyId, executionWorkspaceId: workspace.id, requestedByIssueId: input.issueId, ...source, relativePath: taskRepositoryRelativePath(source.repositoryIdentity), requestedRef, requestKey: parsed.requestKey, requestKeys: [parsed.requestKey] }).returning());
|
|
await measureRunPhase("workspace.write", () => tx.insert(activityLog).values({ companyId: input.companyId, actorType: input.actor.type === "agent" ? "agent" : "user", actorId: input.actor.agentId ?? input.actor.userId ?? "local-board", action: "workspace.repository.requested", entityType: "execution_workspace", entityId: workspace.id, runId: input.actor.runId ?? null, responsibleUserId: userId, details: { repositoryId: row.id, issueId: input.issueId, applies: "next_normal_admission" } }));
|
|
return row;
|
|
});
|
|
return { kind: "requires_next_admission" as const, applies: "next_normal_admission" as const, operationId: receipt.id, repository: receipt, reason: "immutable_admitted_workspace" };
|
|
}
|
|
/**
|
|
* A task in a project without a project workspace gets its repositories by
|
|
* acquisition into its own task files. A subtask's new workspace repeats its
|
|
* parent's (or requester's) repository requests as its own pending requests,
|
|
* so admission clones a fresh copy at the requested ref through the normal
|
|
* acquisition path, with the subtask's own access checks. Nothing is copied
|
|
* from the parent's checkout: no pinned commit, branch, or files.
|
|
*/
|
|
async function inheritSelections(input: { companyId: string; issueId: string; workspaceId: string }) {
|
|
return db.transaction(async tx => {
|
|
const [workspace] = await tx.select({ id: executionWorkspaces.id, sourceIssueId: executionWorkspaces.sourceIssueId })
|
|
.from(executionWorkspaces).where(and(eq(executionWorkspaces.id, input.workspaceId),
|
|
eq(executionWorkspaces.companyId, input.companyId))).for("update");
|
|
if (!workspace || workspace.sourceIssueId !== input.issueId) return 0;
|
|
const [existing] = await tx.select({ id: executionWorkspaceRepositories.id }).from(executionWorkspaceRepositories)
|
|
.where(and(eq(executionWorkspaceRepositories.companyId, input.companyId),
|
|
eq(executionWorkspaceRepositories.executionWorkspaceId, input.workspaceId))).limit(1);
|
|
if (existing) return 0;
|
|
const [task] = await tx.select({ parentId: issues.parentId, privacyParentIssueId: issues.privacyParentIssueId,
|
|
projectId: issues.projectId })
|
|
.from(issues).where(and(eq(issues.id, input.issueId), eq(issues.companyId, input.companyId)));
|
|
const sourceIssueId = task?.privacyParentIssueId ?? task?.parentId;
|
|
if (!sourceIssueId) return 0;
|
|
const [source] = await tx.select({ executionWorkspaceId: issues.executionWorkspaceId, projectId: issues.projectId })
|
|
.from(issues).where(and(eq(issues.id, sourceIssueId), eq(issues.companyId, input.companyId)));
|
|
if (!source?.executionWorkspaceId || source.executionWorkspaceId === input.workspaceId) return 0;
|
|
// Repositories belong to the source's project. A task in another project
|
|
// takes its own project's defaults instead, like a top-level task there.
|
|
if (task?.projectId !== source.projectId) return 0;
|
|
const requested = await tx.select().from(executionWorkspaceRepositories).where(and(
|
|
eq(executionWorkspaceRepositories.companyId, input.companyId),
|
|
eq(executionWorkspaceRepositories.executionWorkspaceId, source.executionWorkspaceId)));
|
|
if (!requested.length) return 0;
|
|
const rows = await tx.insert(executionWorkspaceRepositories).values(requested.map(row => {
|
|
const requestKey = `inherited:${row.id}`;
|
|
return { companyId: input.companyId, executionWorkspaceId: input.workspaceId, requestedByIssueId: input.issueId,
|
|
repositoryIdentity: row.repositoryIdentity, catalogRepositoryId: row.catalogRepositoryId, repoUrl: row.repoUrl,
|
|
relativePath: row.relativePath, requestedRef: row.requestedRef, requestKey, requestKeys: [requestKey] };
|
|
})).onConflictDoNothing().returning({ id: executionWorkspaceRepositories.id });
|
|
if (rows.length) {
|
|
await tx.insert(activityLog).values({ companyId: input.companyId, actorType: "system", actorId: "workspace-preparation",
|
|
action: "workspace.repository.requested", entityType: "execution_workspace", entityId: input.workspaceId,
|
|
details: { issueId: input.issueId, inheritedFromIssueId: sourceIssueId, repositoryIds: rows.map(row => row.id),
|
|
applies: "current_admission" } });
|
|
}
|
|
return rows.length;
|
|
});
|
|
}
|
|
async function list(companyId: string, workspaceId: string) {
|
|
return measureRunPhase("workspace.repository.receipts", () => db.select().from(executionWorkspaceRepositories).where(and(eq(executionWorkspaceRepositories.companyId, companyId), eq(executionWorkspaceRepositories.executionWorkspaceId, workspaceId))));
|
|
}
|
|
type PublicationInput = { companyId: string; issueId: string; workspaceId: string; cwd: string; agentId: string; runId: string; responsibleUserId?: string | null };
|
|
async function currentRunActor(reader: Db | DbTransaction, input: PublicationInput): Promise<AuthorizationActor> {
|
|
const [run] = await measureRunPhase("workspace.repository.db.run", () => reader.select(taskRepositoryRunColumns).from(heartbeatRuns).where(and(
|
|
eq(heartbeatRuns.id, input.runId), eq(heartbeatRuns.companyId, input.companyId))));
|
|
if (!run || run.agentId !== input.agentId) throw forbidden("Task repository run identity is unavailable");
|
|
if ("responsibleUserId" in input && run.responsibleUserId !== input.responsibleUserId) {
|
|
throw forbidden("Task repository responsible user identity is unavailable");
|
|
}
|
|
return { type: "agent", source: "agent_jwt", companyId: input.companyId, agentId: input.agentId,
|
|
runId: input.runId, onBehalfOfUserId: run.responsibleUserId === "local-board" ? null : run.responsibleUserId };
|
|
}
|
|
async function publicationBinding(reader: Db | DbTransaction, input: PublicationInput, verifyDirectory = true) {
|
|
return measureRunPhase("workspace.repository.binding", async () => {
|
|
const [issue] = await measureRunPhase("workspace.repository.db.issue", () => reader.select().from(issues).where(and(eq(issues.id, input.issueId), eq(issues.companyId, input.companyId))));
|
|
const [workspace] = await measureRunPhase("workspace.repository.db.workspace", () => reader.select().from(executionWorkspaces).where(and(eq(executionWorkspaces.id, input.workspaceId), eq(executionWorkspaces.companyId, input.companyId))));
|
|
const remoteAuthority = readRemoteWorkspaceAuthority(workspace?.metadata);
|
|
if (!issue || !workspace || issue.executionWorkspaceId !== workspace.id || !workspace.cwd
|
|
|| (verifyDirectory && (remoteAuthority
|
|
? workspace.cwd !== input.cwd || remoteAuthority.writerRunId !== input.runId
|
|
: await measureRunPhase("workspace.repository.paths", async () =>
|
|
await canonicalRepositoryRoot(workspace.cwd!) !== await canonicalRepositoryRoot(input.cwd))))) {
|
|
throw forbidden("Task repository publication binding is unavailable");
|
|
}
|
|
const acquisitionRestricted = await requiresAnonymousAcquisition(reader, { issue, workspace, agentId: input.agentId, runId: input.runId });
|
|
const actor = await currentRunActor(reader, input);
|
|
await assertTaskWorkspaceExecutionAccess(reader, actor, input.companyId, { issueId: issue.id, workspaceId: workspace.id });
|
|
return { issue, workspace, actor, acquisitionRestricted };
|
|
});
|
|
}
|
|
async function assertPublicationAllowed(input: PublicationInput) {
|
|
await publicationBinding(db, input);
|
|
}
|
|
async function prepareConfiguredRepositoryCopy(input: PublicationInput & { sourceCwd: string; projectWorkspaceId?: string | null }): Promise<() => Promise<void>> {
|
|
const sourceRoot = await fs.realpath(input.sourceCwd);
|
|
const destinationRoot = await canonicalRepositoryRoot(input.cwd);
|
|
const [selectedIssue] = await db.select().from(issues).where(and(eq(issues.id, input.issueId), eq(issues.companyId, input.companyId)));
|
|
if (!selectedIssue) throw forbidden("Task repository copy identity is unavailable");
|
|
const [selectedWorkspace] = await db.select({ projectId: executionWorkspaces.projectId,
|
|
projectWorkspaceId: executionWorkspaces.projectWorkspaceId }).from(executionWorkspaces).where(and(
|
|
eq(executionWorkspaces.id, input.workspaceId), eq(executionWorkspaces.companyId, input.companyId)));
|
|
const selectionSource = selectedIssue.workspaceSelection?.selection;
|
|
const anchorSourceId = selectedWorkspace?.projectWorkspaceId ?? selectedIssue.projectWorkspaceId
|
|
?? (selectionSource?.kind === "configured_source" ? selectionSource.projectWorkspaceId : null);
|
|
const selectedSourceId = input.projectWorkspaceId ?? anchorSourceId;
|
|
const [selectedSource] = selectedSourceId ? await db.select().from(projectWorkspaces).where(and(
|
|
eq(projectWorkspaces.id, selectedSourceId), eq(projectWorkspaces.companyId, input.companyId))) : [];
|
|
if (selectedSourceId && !selectedSource) throw forbidden("Task repository copy source is unavailable");
|
|
const verify = async () => {
|
|
if (await fs.realpath(input.sourceCwd) !== sourceRoot || await canonicalRepositoryRoot(input.cwd) !== destinationRoot) {
|
|
throw conflict("Repository copy source or destination changed during preparation");
|
|
}
|
|
const [issue] = await db.select().from(issues).where(and(eq(issues.id, input.issueId), eq(issues.companyId, input.companyId)));
|
|
if (!issue || issue.projectWorkspaceId !== selectedIssue.projectWorkspaceId || issue.projectId !== selectedIssue.projectId) {
|
|
throw conflict("Repository copy configuration changed during preparation");
|
|
}
|
|
const [workspace] = await db.select().from(executionWorkspaces).where(and(eq(executionWorkspaces.id, input.workspaceId), eq(executionWorkspaces.companyId, input.companyId)));
|
|
if (selectedWorkspace && (!workspace || workspace.projectId !== selectedWorkspace.projectId
|
|
|| workspace.projectWorkspaceId !== selectedWorkspace.projectWorkspaceId)) {
|
|
throw conflict("Repository copy workspace configuration changed during preparation");
|
|
}
|
|
const currentSelection = issue.workspaceSelection?.selection;
|
|
const currentAnchorSourceId = workspace?.projectWorkspaceId ?? issue.projectWorkspaceId
|
|
?? (currentSelection?.kind === "configured_source" ? currentSelection.projectWorkspaceId : null);
|
|
if (currentAnchorSourceId !== anchorSourceId) throw conflict("Repository copy configuration changed during preparation");
|
|
await requiresAnonymousAcquisition(db, { issue, workspace: workspace ?? null, agentId: input.agentId, runId: input.runId });
|
|
const actor = await currentRunActor(db, input);
|
|
const access = await assertTaskWorkspaceExecutionAccess(db, actor, input.companyId, { issueId: issue.id,
|
|
...(workspace ? { workspaceId: workspace.id } : {}), projectWorkspaceId: anchorSourceId });
|
|
if (selectedSource && selectedSource.projectId !== (access.source?.projectId ?? access.workspace?.projectId ?? access.task.projectId)) {
|
|
throw forbidden("Repository copy source is outside the selected project");
|
|
}
|
|
if (workspace) await publicationBinding(db, input);
|
|
if (selectedSource) {
|
|
const [source] = await db.select().from(projectWorkspaces).where(and(eq(projectWorkspaces.id, selectedSource.id), eq(projectWorkspaces.companyId, input.companyId)));
|
|
if (!source || source.cwd !== selectedSource.cwd || source.repoUrl !== selectedSource.repoUrl || source.repoRef !== selectedSource.repoRef
|
|
|| source.projectId !== selectedSource.projectId || source.sourceType !== selectedSource.sourceType) {
|
|
throw conflict("Repository copy configuration changed during preparation");
|
|
}
|
|
await assertTaskWorkspaceSourceProjectAccess(db, actor, input.companyId, source.projectId);
|
|
}
|
|
};
|
|
await verify();
|
|
return verify;
|
|
}
|
|
async function assertRecoveryBinding(input: PublicationInput) {
|
|
const [issue] = await db.select().from(issues).where(and(eq(issues.id, input.issueId), eq(issues.companyId, input.companyId)));
|
|
const [workspace] = await db.select().from(executionWorkspaces).where(and(eq(executionWorkspaces.id, input.workspaceId), eq(executionWorkspaces.companyId, input.companyId)));
|
|
const [run] = await db.select().from(heartbeatRuns).where(and(eq(heartbeatRuns.id, input.runId), eq(heartbeatRuns.companyId, input.companyId)));
|
|
if (!issue || !run || run.agentId !== input.agentId) throw forbidden("Task repository recovery identity is unavailable");
|
|
let execution;
|
|
try { execution = parseNativeExecutionInput(run.runnerProfileJson?.nativeExecutionInput); } catch { /* Old non-native runs have no native input. */ }
|
|
const binding = execution?.binding;
|
|
if (run.runtimeMode === "native") {
|
|
if (!binding || binding.companyId !== input.companyId || binding.runId !== input.runId
|
|
|| binding.agentId !== input.agentId || binding.issueId !== input.issueId || binding.executionWorkspaceId !== input.workspaceId
|
|
|| (!workspace && input.workspaceId !== input.runId)) {
|
|
throw forbidden("Task repository recovery identity is unavailable");
|
|
}
|
|
} else if (!workspace || issue.executionWorkspaceId !== workspace.id) {
|
|
throw forbidden("Task repository recovery identity is unavailable");
|
|
}
|
|
await requiresAnonymousAcquisition(db, { issue, workspace: workspace ?? null, agentId: input.agentId, runId: input.runId });
|
|
const actor = await currentRunActor(db, input);
|
|
// Recovery uses the native run's immutable binding rather than the task's latest workspace pointer.
|
|
await assertTaskWorkspaceExecutionAccess(db, actor, input.companyId, { issueId: issue.id });
|
|
if (workspace?.projectId) await assertTaskWorkspaceSourceProjectAccess(db, actor, input.companyId, workspace.projectId);
|
|
}
|
|
async function sharedPublicationPin(input: { row: RepositoryRow; root: string; ownership: { repositoryId?: unknown; pinnedCommit?: unknown } | null }) {
|
|
const validPin = (value: unknown): value is string => typeof value === "string" && /^[a-f0-9]{40,64}$/.test(value);
|
|
let pin = input.row.pinnedCommit;
|
|
if (pin && !validPin(pin)) throw conflict("Repository preparation receipt has an invalid pinned commit; repair is required before reuse");
|
|
const ownerId = input.ownership?.repositoryId;
|
|
if (typeof ownerId !== "string" || !/^[a-f0-9]{8}-[a-f0-9]{4}-[a-f0-9]{4}-[a-f0-9]{4}-[a-f0-9]{12}$/i.test(ownerId)) return pin;
|
|
if (ownerId === input.row.id) {
|
|
if (validPin(input.ownership?.pinnedCommit)) {
|
|
if (pin && pin !== input.ownership.pinnedCommit) throw conflict("Shared repository publication receipts disagree; repair is required before reuse");
|
|
pin = input.ownership.pinnedCommit;
|
|
}
|
|
return pin;
|
|
}
|
|
// The checkout marker names at most one other receipt. This is integrity evidence,
|
|
// not authority to disclose its originating workspace or task.
|
|
const [owner] = await measureRunPhase("workspace.repository.receipts", () => db.select({ repository: executionWorkspaceRepositories, workspace: executionWorkspaces })
|
|
.from(executionWorkspaceRepositories).innerJoin(executionWorkspaces, eq(executionWorkspaces.id, executionWorkspaceRepositories.executionWorkspaceId))
|
|
.where(and(eq(executionWorkspaceRepositories.id, ownerId), eq(executionWorkspaceRepositories.companyId, input.row.companyId),
|
|
eq(executionWorkspaces.companyId, input.row.companyId))));
|
|
if (!owner || !owner.workspace.cwd) return pin;
|
|
const { repository, workspace } = owner;
|
|
if (repository.repositoryIdentity !== input.row.repositoryIdentity || repository.relativePath !== input.row.relativePath
|
|
|| await measureRunPhase("workspace.repository.paths", () => fs.realpath(workspace.cwd!).catch(() => null)) !== input.root) return pin;
|
|
assertRepositoryRetryMatches(repository, input.row.repositoryIdentity, input.row.requestedRef);
|
|
const markerPin = validPin(input.ownership?.pinnedCommit) ? input.ownership.pinnedCommit : null;
|
|
if (repository.pinnedCommit && markerPin && repository.pinnedCommit !== markerPin) {
|
|
throw conflict("Shared repository publication receipts disagree; repair is required before reuse");
|
|
}
|
|
const candidatePin = repository.pinnedCommit ?? markerPin;
|
|
if (!validPin(candidatePin)) return pin;
|
|
if (pin && pin !== candidatePin) throw conflict("Shared repository publication receipts disagree; repair is required before reuse");
|
|
return candidatePin;
|
|
}
|
|
async function prepareForAdmission(input: { companyId: string; issueId: string; workspaceId: string; cwd: string; agentId: string; runId: string; responsibleUserId: string | null;
|
|
remoteTarget?: AdapterExecutionTarget | null; remoteLease?: EnvironmentLease; assertOwned?: () => Promise<void>;
|
|
inheritRepositorySelections?: boolean }) {
|
|
const { acquisitionRestricted, workspace } = await publicationBinding(db, input, false);
|
|
if (input.inheritRepositorySelections) await inheritSelections(input);
|
|
const rows = await list(input.companyId, input.workspaceId);
|
|
if (!rows.length) return [];
|
|
await publicationBinding(db, input);
|
|
if (acquisitionRestricted && rows.some(row => row.state !== "ready" || !row.pinnedCommit || !/^[a-f0-9]{40,64}$/.test(row.pinnedCommit))) {
|
|
throw forbidden(controllerAcquisitionMessage);
|
|
}
|
|
if (readRemoteWorkspaceAuthority(workspace.metadata)) {
|
|
if (!input.remoteTarget || !input.remoteLease) throw conflict("Remote repository preparation requires its bound sandbox");
|
|
const available = acquisitionRestricted ? [] : await catalog(input.companyId, input.responsibleUserId, input.responsibleUserId === "local-board",
|
|
rows.flatMap(row => row.catalogRepositoryId ? [row.catalogRepositoryId] : []));
|
|
const resolveAuth = createGitRemoteAuthProvider(db, input.companyId, { issueId: input.issueId, heartbeatRunId: input.runId,
|
|
agentId: input.agentId, responsibleUserId: input.responsibleUserId });
|
|
const prepared: Array<{ id: string; cwd: string; repoUrl: string; relativePath: string; pinnedCommit: string; branchName: string | null }> = [];
|
|
let requiresSave = false;
|
|
const verifications: Array<() => Promise<void>> = [];
|
|
for (const row of rows) {
|
|
assertAcquisitionReceipt(row, acquisitionRestricted);
|
|
const source = resolveAcquisitionSource(row.catalogRepositoryId ? { kind: "catalog", id: row.catalogRepositoryId }
|
|
: { kind: "url", url: row.repoUrl }, available, acquisitionRestricted);
|
|
if (source.repositoryIdentity !== row.repositoryIdentity || row.relativePath !== taskRepositoryRelativePath(row.repositoryIdentity)) {
|
|
throw conflict("Repository preparation receipt does not match its source");
|
|
}
|
|
const verify = async () => {
|
|
await input.assertOwned?.();
|
|
await publicationBinding(db, input);
|
|
if (!acquisitionRestricted) await assertCurrentControllerAcquisition(input);
|
|
if (source.catalogRepositoryId) {
|
|
const current = await catalog(input.companyId, input.responsibleUserId, input.responsibleUserId === "local-board", [source.catalogRepositoryId]);
|
|
const authorized = resolveAcquisitionSource({ kind: "catalog", id: source.catalogRepositoryId }, current, false);
|
|
if (authorized.repositoryIdentity !== row.repositoryIdentity) throw conflict("Repository catalog authorization changed");
|
|
}
|
|
};
|
|
await verify();
|
|
const anonymous = buildGitAuthInvocation({ token: "", source: "managed_connection", secretName: null });
|
|
anonymous.env = { ...anonymous.env, GIT_CONFIG_GLOBAL: "/dev/null", GIT_CONFIG_SYSTEM: "/dev/null" };
|
|
try {
|
|
const result = await prepareRemoteWorkspaceRepository({
|
|
db, workspace, runId: input.runId, lease: input.remoteLease, target: input.remoteTarget,
|
|
repository: { id: row.id, relativePath: row.relativePath, repoUrl: row.repoUrl,
|
|
ref: row.requestedRef === "HEAD" ? null : row.requestedRef,
|
|
...(row.pinnedCommit ? { pinnedCommit: row.pinnedCommit } : {}) },
|
|
assertOwned: verify, verifyOnly: acquisitionRestricted, deferSave: true,
|
|
resolveGitAuth: source.catalogRepositoryId ? resolveAuth : async () => anonymous,
|
|
});
|
|
await verify();
|
|
requiresSave ||= result.requiresSave;
|
|
verifications.push(verify);
|
|
prepared.push({ ...result, id: row.id, repoUrl: row.repoUrl, relativePath: row.relativePath });
|
|
} catch (error) {
|
|
await db.update(executionWorkspaceRepositories).set({ state: "needs_repair", failureCode: "repository_preparation_failed", updatedAt: new Date() })
|
|
.where(and(eq(executionWorkspaceRepositories.id, row.id), eq(executionWorkspaceRepositories.companyId, input.companyId)));
|
|
throw error;
|
|
}
|
|
}
|
|
for (const verify of verifications) await verify();
|
|
if (requiresSave) {
|
|
try {
|
|
await saveRemoteWorkspace({ db, workspace, runId: input.runId, lease: input.remoteLease,
|
|
target: input.remoteTarget, boundary: `repositories:${prepared.map(row => `${row.id}:${row.pinnedCommit}`).sort().join(",")}`,
|
|
repositories: prepared.map(row => ({ id: row.id, relativePath: row.relativePath, repoUrl: row.repoUrl,
|
|
ref: rows.find(source => source.id === row.id)!.requestedRef, pinnedCommit: row.pinnedCommit })),
|
|
assertOwned: async () => { for (const verify of verifications) await verify(); } });
|
|
} catch (error) {
|
|
for (const result of prepared) await db.update(executionWorkspaceRepositories)
|
|
.set({ state: "needs_repair", failureCode: "repository_preparation_failed", updatedAt: new Date() })
|
|
.where(and(eq(executionWorkspaceRepositories.id, result.id), eq(executionWorkspaceRepositories.companyId, input.companyId)));
|
|
throw error;
|
|
}
|
|
}
|
|
for (const result of prepared) {
|
|
await db.update(executionWorkspaceRepositories).set({ state: "ready", pinnedCommit: result.pinnedCommit,
|
|
branchName: result.branchName, failureCode: null, updatedAt: new Date() })
|
|
.where(and(eq(executionWorkspaceRepositories.id, result.id), eq(executionWorkspaceRepositories.companyId, input.companyId)));
|
|
}
|
|
return prepared;
|
|
}
|
|
const root = await measureRunPhase("workspace.repository.paths", () => fs.realpath(input.cwd));
|
|
const available = acquisitionRestricted ? [] : await catalog(input.companyId, input.responsibleUserId, input.responsibleUserId === "local-board",
|
|
rows.flatMap(row => row.catalogRepositoryId ? [row.catalogRepositoryId] : []));
|
|
const resolveAuth = createGitRemoteAuthProvider(db, input.companyId, { issueId: input.issueId, heartbeatRunId: input.runId, agentId: input.agentId, responsibleUserId: input.responsibleUserId });
|
|
const sources = rows.map(row => {
|
|
assertAcquisitionReceipt(row, acquisitionRestricted);
|
|
return resolveAcquisitionSource(row.catalogRepositoryId ? { kind: "catalog", id: row.catalogRepositoryId } : { kind: "url", url: row.repoUrl }, available, acquisitionRestricted);
|
|
});
|
|
const stagingParent = await measureRunPhase("workspace.repository.fs_prepare", async () => {
|
|
const repositoryRoot = path.join(root, ".paperclip-repositories");
|
|
if (!acquisitionRestricted) await fs.mkdir(repositoryRoot, { recursive: true });
|
|
if ((await fs.lstat(repositoryRoot)).isSymbolicLink() || await fs.realpath(repositoryRoot) !== repositoryRoot) throw conflict("Repository directory escapes the task workspace");
|
|
let stagingParent = root;
|
|
if (!acquisitionRestricted) {
|
|
for (const name of [".paperclip-runtime", "repository-staging"]) {
|
|
stagingParent = path.join(stagingParent, name);
|
|
await fs.mkdir(stagingParent, { mode: 0o700 }).catch((error: NodeJS.ErrnoException) => {
|
|
if (error.code !== "EEXIST") throw error;
|
|
});
|
|
const entry = await fs.lstat(stagingParent);
|
|
if (!entry.isDirectory() || entry.isSymbolicLink() || await fs.realpath(stagingParent) !== stagingParent) {
|
|
throw conflict("Repository staging directory escapes the task workspace");
|
|
}
|
|
}
|
|
const ignorePath = path.join(stagingParent, ".gitignore");
|
|
const ignoreEntry = await fs.lstat(ignorePath).catch((error: NodeJS.ErrnoException) => {
|
|
if (error.code === "ENOENT") return null;
|
|
throw error;
|
|
});
|
|
if (ignoreEntry && (!ignoreEntry.isFile() || ignoreEntry.isSymbolicLink())) {
|
|
throw conflict("Repository staging ignore file is not a regular file");
|
|
}
|
|
const ignoreTemporary = path.join(stagingParent, `.ignore-${randomUUID()}.tmp`);
|
|
try {
|
|
await fs.writeFile(ignoreTemporary, "*\n", { flag: "wx", mode: 0o600 });
|
|
await fs.rename(ignoreTemporary, ignorePath);
|
|
} finally { await fs.rm(ignoreTemporary, { force: true }); }
|
|
await measureRunPhase("workspace.repository.ignore_rules", () => ensureManagedRepositoriesIgnored(root, {
|
|
plainTaskDirectory: workspace.strategyType === "project_primary" && workspace.metadata?.source === "task_session"
|
|
&& workspace.sourceIssueId === input.issueId && ["shared_workspace", "isolated_workspace"].includes(workspace.mode)
|
|
&& !workspace.repoUrl && !workspace.projectId && !workspace.projectWorkspaceId,
|
|
}));
|
|
}
|
|
return stagingParent;
|
|
});
|
|
const prepared: Array<{ id: string; cwd: string; repoUrl: string; relativePath: string; pinnedCommit: string; branchName: string | null }> = [];
|
|
for (const [index, listedRow] of rows.entries()) {
|
|
const source = sources[index];
|
|
if (source.repositoryIdentity !== listedRow.repositoryIdentity || listedRow.relativePath !== taskRepositoryRelativePath(listedRow.repositoryIdentity)) throw conflict("Repository preparation receipt does not match its source");
|
|
const cwd = path.join(root, listedRow.relativePath);
|
|
await withRepositoryPublication(cwd, async () => {
|
|
// A ref correction can commit after the receipts were listed. Use the
|
|
// current receipt so admission never checks out a discarded ref.
|
|
const [row] = await measureRunPhase("workspace.repository.receipts", () => db.select().from(executionWorkspaceRepositories)
|
|
.where(and(eq(executionWorkspaceRepositories.id, listedRow.id), eq(executionWorkspaceRepositories.companyId, input.companyId))));
|
|
if (!row || row.repositoryIdentity !== listedRow.repositoryIdentity || row.relativePath !== listedRow.relativePath) {
|
|
throw conflict("Repository preparation receipt changed during admission");
|
|
}
|
|
const existing = await measureRunPhase("workspace.repository.checkout_identity", async () => {
|
|
const existing = await fs.lstat(cwd).catch(() => null);
|
|
if (existing && (!existing.isDirectory() || existing.isSymbolicLink() || await fs.realpath(cwd) !== cwd)) throw conflict("Repository checkout path is not a contained directory");
|
|
if (existing) {
|
|
const gitDir = path.join(cwd, ".git");
|
|
const metadata = await fs.lstat(gitDir).catch(() => null);
|
|
if (!metadata?.isDirectory() || metadata.isSymbolicLink() || await fs.realpath(gitDir) !== gitDir) throw conflict("Repository Git metadata escapes the managed checkout");
|
|
}
|
|
if (acquisitionRestricted && !existing) throw forbidden(controllerAcquisitionMessage);
|
|
return existing;
|
|
});
|
|
const anonymous = buildGitAuthInvocation({ token: "", source: "managed_connection", secretName: null });
|
|
anonymous.env = { ...anonymous.env, GIT_CONFIG_GLOBAL: "/dev/null", GIT_CONFIG_SYSTEM: "/dev/null" };
|
|
if (!acquisitionRestricted) {
|
|
// Claim the receipt at the ref this admission uses. Correction only
|
|
// applies to needs_repair receipts, so it cannot change a claimed ref.
|
|
const [claimed] = await measureRunPhase("workspace.repository.state_write", () => db.update(executionWorkspaceRepositories).set({ state: "preparing", catalogRepositoryId: source.catalogRepositoryId, failureCode: null, updatedAt: new Date() })
|
|
.where(and(eq(executionWorkspaceRepositories.id, row.id), eq(executionWorkspaceRepositories.requestedRef, row.requestedRef))).returning({ id: executionWorkspaceRepositories.id }));
|
|
if (!claimed) throw conflict("Repository preparation receipt changed during admission");
|
|
}
|
|
try {
|
|
const ownershipPath = path.join(cwd, ".git", "paperclip-workspace-owner.json");
|
|
const readOwnership = () => measureRunPhase("workspace.repository.ownership_read", async () => {
|
|
const handle = await fs.open(ownershipPath, fsConstants.O_RDONLY | fsConstants.O_NOFOLLOW | fsConstants.O_NONBLOCK).catch(() => null);
|
|
if (!handle) return null;
|
|
try {
|
|
const stat = await handle.stat();
|
|
if (!stat.isFile() || stat.size > 4096) return null;
|
|
const bytes = Buffer.alloc(4097);
|
|
const { bytesRead } = await handle.read(bytes, 0, bytes.length, 0);
|
|
return bytesRead <= 4096 ? JSON.parse(bytes.subarray(0, bytesRead).toString("utf8")) : null;
|
|
} catch { return null; } finally { await handle.close(); }
|
|
});
|
|
const initialOwnership = await readOwnership();
|
|
const authorizedPin = await measureRunPhase("workspace.repository.ownership_verify", () => sharedPublicationPin({ row, root, ownership: initialOwnership }));
|
|
if (existing && !authorizedPin && initialOwnership?.repositoryId !== row.id) {
|
|
throw conflict("Repository directory has no matching preparation receipt; repair it before retrying");
|
|
}
|
|
if (!acquisitionRestricted) {
|
|
await assertCurrentControllerAcquisition(input);
|
|
const result = await measureRunPhase("workspace.repository.materialize", () => materializeManagedProjectWorkspace(cwd, {
|
|
repoUrl: source.repoUrl,
|
|
stagingParent,
|
|
repoRef: authorizedPin ?? (row.requestedRef === "HEAD" ? null : row.requestedRef),
|
|
resolveGitAuth: source.catalogRepositoryId ? resolveAuth : async () => anonymous,
|
|
beforePublish: async cloneCwd => {
|
|
await assertCurrentControllerAcquisition(input);
|
|
await assertPublicationAllowed(input);
|
|
if (source.catalogRepositoryId) {
|
|
const currentCatalog = await catalog(input.companyId, input.responsibleUserId, input.responsibleUserId === "local-board", [source.catalogRepositoryId]);
|
|
const currentSource = resolveAcquisitionSource({ kind: "catalog", id: source.catalogRepositoryId }, currentCatalog, false);
|
|
if (currentSource.repositoryIdentity !== row.repositoryIdentity) throw conflict("Repository preparation receipt does not match its source");
|
|
}
|
|
const pinnedCommit = await measureRunPhase("workspace.repository.git_commit", async () =>
|
|
(await execFile("git", ["-C", cloneCwd, "rev-parse", "HEAD"], { timeout: 30_000 })).stdout.trim());
|
|
await measureRunPhase("workspace.repository.ownership_write", () => fs.writeFile(path.join(cloneCwd, ".git", "paperclip-workspace-owner.json"), JSON.stringify({ version: 1, repositoryId: row.id, pinnedCommit }), { flag: "wx", mode: 0o600 }));
|
|
},
|
|
}));
|
|
if (result.warning) throw conflict(result.warning);
|
|
}
|
|
const git = async (...args: string[]) => (await execFile("git", ["-C", cwd, ...args], { timeout: 30_000, env: { ...process.env, GIT_NO_LAZY_FETCH: "1" } })).stdout.trim();
|
|
const origin = normalizeProjectRepositoryUrl(await measureRunPhase("workspace.repository.git_origin", () => git("remote", "get-url", "origin")));
|
|
if (origin.url.toLowerCase() !== row.repositoryIdentity) throw conflict("Repository checkout belongs to a different origin");
|
|
const ownership = await readOwnership();
|
|
if (!authorizedPin && (ownership?.repositoryId !== row.id || !/^[a-f0-9]{40,64}$/.test(ownership.pinnedCommit))) throw conflict("Repository publication has no valid preparation receipt");
|
|
const pinnedCommit: string = authorizedPin ?? ownership.pinnedCommit;
|
|
if (acquisitionRestricted) await measureRunPhase("workspace.repository.git_commit", () => git("cat-file", "-e", `${pinnedCommit}^{commit}`));
|
|
const branchName = await measureRunPhase("workspace.repository.git_branch", () => git("symbolic-ref", "--quiet", "--short", "HEAD").catch(() => null));
|
|
await assertPublicationAllowed(input);
|
|
if (!acquisitionRestricted) {
|
|
await assertCurrentControllerAcquisition(input);
|
|
if (source.catalogRepositoryId) {
|
|
const currentCatalog = await catalog(input.companyId, input.responsibleUserId, input.responsibleUserId === "local-board", [source.catalogRepositoryId]);
|
|
const currentSource = resolveAcquisitionSource({ kind: "catalog", id: source.catalogRepositoryId }, currentCatalog, false);
|
|
if (currentSource.repositoryIdentity !== row.repositoryIdentity) throw conflict("Repository preparation receipt does not match its source");
|
|
}
|
|
}
|
|
if (ownership?.repositoryId !== row.id || ownership?.pinnedCommit !== pinnedCommit) {
|
|
await measureRunPhase("workspace.repository.ownership_write", async () => {
|
|
const gitDir = path.join(cwd, ".git");
|
|
const metadata = await fs.lstat(gitDir);
|
|
if (!metadata.isDirectory() || metadata.isSymbolicLink() || await fs.realpath(gitDir) !== gitDir) {
|
|
throw conflict("Repository Git metadata escapes the managed checkout");
|
|
}
|
|
const temporaryOwnershipPath = path.join(gitDir, `.paperclip-workspace-owner-${randomUUID()}.tmp`);
|
|
try {
|
|
await fs.writeFile(temporaryOwnershipPath, JSON.stringify({ version: 1, repositoryId: row.id, pinnedCommit }), { flag: "wx", mode: 0o600 });
|
|
// Keep bounded ownership lookup attached to a receipt for this root,
|
|
// even if the workspace that originally published it later moves.
|
|
await fs.rename(temporaryOwnershipPath, ownershipPath);
|
|
} finally { await fs.rm(temporaryOwnershipPath, { force: true }); }
|
|
});
|
|
}
|
|
await measureRunPhase("workspace.repository.state_write", () => db.update(executionWorkspaceRepositories).set({ state: "ready", pinnedCommit, branchName, failureCode: null, updatedAt: new Date() }).where(eq(executionWorkspaceRepositories.id, row.id)));
|
|
prepared.push({ id: row.id, cwd, repoUrl: row.repoUrl, relativePath: row.relativePath, pinnedCommit, branchName });
|
|
} catch (error) {
|
|
const failureCode = error instanceof RepositoryRefNotFoundError ? REPOSITORY_REF_NOT_FOUND : "repository_preparation_failed";
|
|
await measureRunPhase("workspace.repository.state_write", () => db.update(executionWorkspaceRepositories).set({ state: "needs_repair", failureCode, updatedAt: new Date() }).where(eq(executionWorkspaceRepositories.id, row.id)));
|
|
throw error;
|
|
}
|
|
});
|
|
}
|
|
return prepared;
|
|
}
|
|
return { request, list, prepareForAdmission, assertRecoveryBinding, assertPublicationAllowed, prepareConfiguredRepositoryCopy };
|
|
}
|