mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-26 18:31:34 +01:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work > - Operators scan task state constantly, so the task **status** vocabulary (backlog / todo / in progress / in review / done / blocked / cancelled) has to read instantly > - Those statuses render through one shared component, `StatusGlyph`, whose icons were hand-rolled SVG geometry lifted from an internal spec > - Hand-rolled glyphs are harder to reason about, drift from the rest of the UI (which uses Lucide everywhere else), and mix fill/stroke styles across statuses > - This pull request swaps the hand-rolled geometry for named Lucide icons — one clean, consistent icon family — with no change to colours, sizing, or accessibility > - The benefit is a status icon set that is consistent with the rest of the app's iconography, trivially adjustable (change a mapping, not SVG path math), and simpler to maintain ## Linked Issues or Issue Description No existing public GitHub issue. Describing the change in-PR (feature/polish): **Problem / motivation.** The task status icons in `StatusGlyph` were bespoke inline SVGs (a half-filled disc for *in progress*, a filled disc + knockout check for *done*, ring+bar for *blocked*, ring+slash for *cancelled*, etc.). The rest of the UI uses [Lucide](https://lucide.dev) icons, so the status set was the odd one out — and its mixed fill/stroke shapes were harder to scan and to tweak. **Proposed solution.** Map each status to a Lucide icon and render that instead: | Status | Lucide icon | | --- | --- | | backlog | `circle-dashed` | | todo | `circle` | | in_progress | `rotate-cw` | | in_review | `circle-dot` | | done | `circle-check` | | blocked | `circle-minus` | | cancelled | `ban` | | in_queue (covered-blocked) | `circle-minus`, recoloured blue | Colours (the `--status-task-icon-*` tokens), the `sm/md/lg` size scale, `currentColor` recolouring, and the `role="img"` / `aria-label` behaviour are all unchanged — only the shapes change. **Alternatives considered.** Keeping the bespoke geometry (rejected: inconsistent with the app and harder to maintain). **Related PRs** (linked for reviewer context, not dependencies): - Refs #8580 — the merged PR that established the current hand-rolled status glyphs this PR restyles. - Refs #8838 — open PR forwarding Radix trigger props through `StatusGlyph`; touches the same component (no overlap with this change). - Refs #1760 — open proposal to redesign the *cancelled* status icon specifically; this PR moves cancelled to Lucide `ban`. ## What Changed - `ui/src/components/StatusGlyph.tsx`: replaced the per-status hand-rolled SVG `glyphBody()` geometry with a `status → Lucide icon` map (`circle-dashed`, `circle`, `rotate-cw`, `circle-dot`, `circle-check`, `circle-minus`, `ban`). Kept the token-driven colour wiring, size scale, `currentColor` recolouring, a11y label handling, and the `in_queue` = blocked-icon-recoloured-blue behaviour. - `ui/src/components/StatusGlyph.test.tsx`: updated to lock the new icon mapping (per-status Lucide class, size scale, colour var, `in_queue`, a11y) instead of the old geometry. Net: two files, +74 / −138 (the component got smaller). Because every status surface (list, board, detail header, status picker, sub-task/blocked-by pills, chips) routes through `StatusGlyph`, this single-component edit covers them all. ## Verification - `pnpm check:token-gates` → **3/3 clean** (no hardcoded colour/spacing/font values introduced). - `pnpm typecheck` → clean across all packages. - `cd ui && pnpm vitest run` → **2509/2509 passing**, including the updated `StatusGlyph` test. - Manual: ran the worktree dev server and confirmed the new icons render everywhere (task list, task detail, related-task chips, and the status picker showing all seven). **Storybook visual-regression note:** this is an intentional visual change, so the status-icon stories will diff against the published baseline. The baseline snapshots need to be regenerated and republished by a maintainer (`pnpm test:storybook-visual:update` from a trusted environment) as part of accepting this change — the visual-regression CI check is expected to be red until then. No baseline is published in the environment this PR was authored in, so that step is left to a maintainer. ## Risks - **Low risk / cosmetic.** No logic, data, or API changes — only the rendered icon shapes. Colours, sizes, and accessibility labels are unchanged. - The most noticeable shifts are *in progress* (half-disc → rotating arrow), *done* (solid disc+check → outline circle+check), and *cancelled* (ring+slash → ban). These are deliberate. - The only CI check expected to fail is the Storybook visual-regression job, pending a maintainer baseline update (see Verification). ## Model Used Claude Opus 4.8 (`claude-opus-4-8`), run in Claude Code with extended thinking and tool use (file edits, local test runs, browser-driven visual verification). ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [ ] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [ ] All Paperclip CI gates are green - [ ] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
89 lines
2.8 KiB
TypeScript
89 lines
2.8 KiB
TypeScript
import type { CSSProperties } from "react";
|
|
import {
|
|
Ban,
|
|
Circle,
|
|
CircleCheck,
|
|
CircleDashed,
|
|
CircleDot,
|
|
CircleMinus,
|
|
RotateCw,
|
|
type LucideIcon,
|
|
} from "lucide-react";
|
|
import { cn } from "../lib/utils";
|
|
import { taskStatusIconVar, taskStatusIconVarDefault } from "../lib/status-colors";
|
|
|
|
/**
|
|
* Unified task status glyph — the single source-of-truth icon for every
|
|
* task/issue status. Each status maps to one Lucide icon (all drawn on the same
|
|
* `viewBox="0 0 24 24"` so they scale proportionally at any size), so the whole
|
|
* set reads as one consistent icon family:
|
|
*
|
|
* backlog → circle-dashed · todo → circle · in_progress → rotate-cw ·
|
|
* in_review → circle-dot · done → circle-check · blocked → circle-minus ·
|
|
* cancelled → ban · in_queue → circle-minus (blocked recoloured blue).
|
|
*
|
|
* Colour comes from the `--status-task-icon-*` CSS vars (AA-tuned, mode-aware;
|
|
* see `index.css`). The glyph paints in `currentColor`, and the component
|
|
* defaults `color` to the status' icon var — so it renders correctly
|
|
* standalone, but a call site can recolour it by setting `color` on the SVG or
|
|
* any ancestor (e.g. a chip pointing it at its foreground hue).
|
|
*/
|
|
|
|
export type StatusGlyphSize = "sm" | "md" | "lg";
|
|
|
|
/** sm 14 / md 16 / lg 20 — the only sizes the unified glyph ships at. */
|
|
const SIZE_PX: Record<StatusGlyphSize, number> = { sm: 14, md: 16, lg: 20 };
|
|
|
|
export type StatusGlyphStatus =
|
|
| "backlog"
|
|
| "todo"
|
|
| "in_progress"
|
|
| "in_review"
|
|
| "done"
|
|
| "blocked"
|
|
| "cancelled"
|
|
| "in_queue";
|
|
|
|
/** Status → Lucide icon. `in_queue` borrows the blocked icon; its colour var resolves to blue. */
|
|
const STATUS_ICON: Record<string, LucideIcon> = {
|
|
backlog: CircleDashed,
|
|
todo: Circle,
|
|
in_progress: RotateCw,
|
|
in_review: CircleDot,
|
|
done: CircleCheck,
|
|
blocked: CircleMinus,
|
|
cancelled: Ban,
|
|
in_queue: CircleMinus,
|
|
};
|
|
|
|
/** Unknown statuses fall back to the backlog icon (matches the colour-var fallback). */
|
|
const STATUS_ICON_DEFAULT = CircleDashed;
|
|
|
|
interface StatusGlyphProps {
|
|
status: string;
|
|
/** sm 14 / md 16 / lg 20. Default `md`. */
|
|
size?: StatusGlyphSize;
|
|
className?: string;
|
|
/** Accessible label; when set the SVG gets `role="img"`, else it's decorative. */
|
|
title?: string;
|
|
}
|
|
|
|
export function StatusGlyph({ status, size = "md", className, title }: StatusGlyphProps) {
|
|
const px = SIZE_PX[size];
|
|
const Icon = STATUS_ICON[status] ?? STATUS_ICON_DEFAULT;
|
|
const cssVar = taskStatusIconVar[status] ?? taskStatusIconVarDefault;
|
|
const a11y = title
|
|
? ({ role: "img", "aria-label": title } as const)
|
|
: ({ "aria-hidden": true } as const);
|
|
return (
|
|
<Icon
|
|
size={px}
|
|
className={cn("inline-block shrink-0 align-middle", className)}
|
|
style={{ color: `var(${cssVar})` } as CSSProperties}
|
|
{...a11y}
|
|
>
|
|
{title ? <title>{title}</title> : null}
|
|
</Icon>
|
|
);
|
|
}
|