mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-24 10:13:11 +02:00
## Thinking Path > - Paperclip manages agents and the work they perform. > - Product E2E tests exercise real agents, tools, setup and cleanup. > - Repeated runs need retained costs and traces, including failed attempts. > - A passing retry must not hide earlier spending or feedback. > - Recurring work also needs admission limits, private reports and failure detection. > - This change supplies those controls while keeping paid activation behind existing gates. ## Linked Issues or Issue Description Refs #16996 and #17158. This is the consolidated landing of the reviewed eval operations stack: #17019, #17024, #17025, #17027, #17030, #17033, #17035, #17038, #17043, #17044, #17048, #17050, #17051, #17092, #17096, #17100, #17107, #17109, #17112, #17115, #17117, #17121, #17123, #17127, #17130, #17133, #17134, #17137, #17140, #17143, #17154. The repository permits squash merges only. A local rehearsal showed that squashing each slice into master causes repeated conflicts in dependent slices. This PR preserves their commits and lands their combined implementation in one reviewed integration. Superseded slices will close after this merge. ## What Changed - Retain every attempt's cost receipt, including setup, failures, interruptions and retries. Separate reported amounts, estimates, missing costs and reserved capacity in reports and dashboards. - Add bounded request admission, exact model pricecards, gateway error accounting, cache policy and reconciliation evidence. Refuse unsupported routes and requests that cannot fit the allowance. - Integrate Braintrust gateway traces and OTLP correlation, with secret filtering and experiment imports. Record phase timing, including setup, feedback capture and cleanup. - Collect complaint and suggestion evidence after each attempt, including recovery after failures. Retain explicit review dispositions independently from the product grade. - Add gated daily and weekly selections, measured forecasts, setup/readiness checks, wall-time limits and retained monitor notifications. Include declared non-model overhead in admission while reporting the existing subscription separately. - Keep recurring history private, bound uploads and retention, and use isolated archive environments. Keep public publication an explicit operation. Report and publication jobs install only the committed lockfile, with scripts disabled and isolated stores; stale pins fail closed. - Integrate current master, preserve its Product E2E journey billing and privacy checks, and test that shared setup receipts do not double-count estimated agent usage. Preserve upstream fixture repairs. ## Verification - Complete integration baseline `0649a5ce7544ab20825c2183d2f421157db49f24` includes master `a3e1d915a7110a4e115b46396a3f79e6dfb4d05e` and every original stack head as ancestors. - On that integration baseline, `pnpm test:e2e:runner:unit`: 4,012 Vitest tests passed, two skipped, across 193 files; all 137 Node source-contract tests passed. - Focused billing and Product E2E journey contract checks: 24 tests passed. They cover estimates, unknown receipts, single-owner setup costs, browser-only execution and private publication guards. - Monitor and workflow wiring: all 96 Node tests passed. `node scripts/check-token-gates.mjs`: all gates clean. - `pnpm test:e2e:runner:typecheck` passes after the standard Runner TypeScript build refreshed local declarations. The first attempt rejected the new master `runner_prepared_launch` union member because this checkout retained an older generated declaration; the source union already contained that member. - Current head `492b0708a1c531a023d9ac10f0f3dc6383cc1754` removes dependency re-resolution from archive-authorized reporting jobs after the security scan flagged it. All 15 workflow-security tests pass after updating the old two-install assertion. - Hosted [CI run 39965460180](https://github.com/paperclipai/paperclip/actions/runs/39965460180) passes on the current repaired head, including typecheck, build, general tests, Runner checks, browser shards and canary dry run. Greptile is 5/5 on this exact head with no unresolved threads. The security scan passes after the fixed lockfile-resolution thread was resolved. - Paperclip Review returned a terminal neutral check but an incomplete 0-file assessment on the repaired head: its platform blocked both diff responses as prompt-injection content. This is not a successful code review. No bypass or fabricated pass was attempted; current-head Greptile, security and hosted CI are independent gates. - No paid test, reservation release or recurring-run activation accompanies this landing. Live route qualification and invoice reconciliation remain separate evidence. <details> <summary>Retained earlier validation failures</summary> Earlier broad local runs had two 15-second test timeouts (CLI poll cadence and Retry validation), one embedded-database setup timeout, and later PostgreSQL semaphore exhaustion. The exact timed-out tests passed separately without larger timeouts; the broad-run causes were not established. Those local failures remain distinct from subsequent hosted CI results. The independent #17158 fix records its Muse fixture collision, its UUID correction and hosted verification. Local Muse execution was also blocked by macOS embedded-PostgreSQL startup. No historical failure is treated as a successful paid qualification. </details> ## Risks - Admission is a local control, not a provider invoice cap. Missing provider receipts or resource charges retain unknown amounts and holds; estimates do not become billed dollars. - The bounded path admits only documented local suites and provider routes. Ordinary legacy or separate Runner protocol campaigns have different controls. Merging this code does not qualify additional routes. - Recurrence still needs the existing enable gates and current qualification/allowance evidence. Archive permissions and resources must match the documented private-environment contract. - Legacy reports may lack complete attempt or phase evidence. Reports preserve that limitation and do not infer zero usage from missing data. ## Model Used OpenAI GPT-6 through Codex, with reasoning, repository tools and code execution. The exact deployment variant and context-window size are not exposed by this session. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass (targeted checks; full-suite host limitation disclosed above) - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
369 lines
13 KiB
TypeScript
369 lines
13 KiB
TypeScript
import { cp, mkdir, readFile, readdir, writeFile } from "node:fs/promises";
|
|
import path from "node:path";
|
|
import { pathToFileURL } from "node:url";
|
|
import type { RunnerE2EResult } from "./types.js";
|
|
|
|
interface WorkflowJob {
|
|
name: string;
|
|
run_attempt: number;
|
|
started_at: string;
|
|
status?: string;
|
|
}
|
|
|
|
interface WorkflowJobsResponse {
|
|
jobs: WorkflowJob[];
|
|
attempts: Array<{
|
|
run_attempt: number;
|
|
run_started_at: string;
|
|
}>;
|
|
}
|
|
|
|
export interface SelectRerunArtifactsInput {
|
|
artifactRoot: string;
|
|
selectedRoot: string;
|
|
jobs: WorkflowJobsResponse;
|
|
expectedExecutionIds: readonly string[];
|
|
workflowRunId: string;
|
|
workflowRunAttempt: number;
|
|
sourceSha: string;
|
|
sourceRef: string;
|
|
workflowRunUrl: string;
|
|
}
|
|
|
|
function safeIdentifier(value: string, label: string) {
|
|
if (!value || !/^[A-Za-z0-9_.-]+$/u.test(value)) {
|
|
throw new Error(
|
|
`${label} contains unsafe characters: ${JSON.stringify(value)}`,
|
|
);
|
|
}
|
|
return value;
|
|
}
|
|
|
|
function positiveInteger(value: unknown, label: string) {
|
|
if (typeof value !== "number" || !Number.isSafeInteger(value) || value < 1) {
|
|
throw new Error(`${label} must be a positive integer`);
|
|
}
|
|
return value;
|
|
}
|
|
|
|
function timestamp(value: unknown, label: string) {
|
|
if (typeof value !== "string" || !Number.isFinite(Date.parse(value))) {
|
|
throw new Error(`${label} must be an ISO timestamp`);
|
|
}
|
|
return Date.parse(value);
|
|
}
|
|
|
|
async function walk(root: string): Promise<string[]> {
|
|
const entries = await readdir(root, { withFileTypes: true });
|
|
const files: string[] = [];
|
|
for (const entry of entries) {
|
|
const full = path.join(root, entry.name);
|
|
if (entry.isDirectory()) files.push(...(await walk(full)));
|
|
else if (entry.isFile()) files.push(full);
|
|
}
|
|
return files;
|
|
}
|
|
|
|
/**
|
|
* Selects the artifact produced by the latest workflow job for each execution.
|
|
* GitHub reruns retain earlier-attempt artifacts, so validity or result
|
|
* timestamps must never be used to choose between workflow attempts.
|
|
*/
|
|
export async function selectRerunArtifacts(input: SelectRerunArtifactsInput) {
|
|
const runId = safeIdentifier(input.workflowRunId, "workflow run ID");
|
|
const currentAttempt = positiveInteger(
|
|
input.workflowRunAttempt,
|
|
"workflow run attempt",
|
|
);
|
|
const expected = input.expectedExecutionIds.map((executionId) =>
|
|
safeIdentifier(executionId, "execution ID"),
|
|
);
|
|
if (expected.length === 0 || new Set(expected).size !== expected.length) {
|
|
throw new Error("expected execution IDs must be non-empty and unique");
|
|
}
|
|
const preexistingSelections = await readdir(input.selectedRoot).catch(
|
|
(error: NodeJS.ErrnoException) => {
|
|
if (error.code === "ENOENT") return [];
|
|
throw error;
|
|
},
|
|
);
|
|
if (preexistingSelections.length > 0) {
|
|
throw new Error("selected artifact root must start empty");
|
|
}
|
|
const expectedSet = new Set(expected);
|
|
const attemptStartedAt = new Map<number, number>();
|
|
for (const attemptMetadata of input.jobs.attempts) {
|
|
const attempt = positiveInteger(
|
|
attemptMetadata.run_attempt,
|
|
"workflow metadata attempt",
|
|
);
|
|
if (attempt > currentAttempt || attemptStartedAt.has(attempt)) {
|
|
throw new Error(`invalid workflow metadata for attempt ${attempt}`);
|
|
}
|
|
attemptStartedAt.set(
|
|
attempt,
|
|
timestamp(
|
|
attemptMetadata.run_started_at,
|
|
`workflow attempt ${attempt} start`,
|
|
),
|
|
);
|
|
}
|
|
for (let attempt = 1; attempt <= currentAttempt; attempt += 1) {
|
|
if (!attemptStartedAt.has(attempt)) {
|
|
throw new Error(`workflow metadata omitted attempt ${attempt}`);
|
|
}
|
|
}
|
|
const attemptsByExecution = new Map<string, Map<number, WorkflowJob>>();
|
|
for (const candidate of input.jobs.jobs) {
|
|
if (!expectedSet.has(candidate.name)) continue;
|
|
const attempt = positiveInteger(candidate.run_attempt, "job run attempt");
|
|
if (attempt > currentAttempt) {
|
|
throw new Error(
|
|
`job ${candidate.name} claims future workflow attempt ${attempt}`,
|
|
);
|
|
}
|
|
const jobStartedAt = timestamp(
|
|
candidate.started_at,
|
|
`job ${candidate.name} start`,
|
|
);
|
|
// GitHub's filter=all response synthesizes current-attempt rows for jobs
|
|
// retained from an earlier attempt. Their started_at remains before the
|
|
// current attempt's trusted run_started_at, so they are not real reruns.
|
|
if (jobStartedAt < attemptStartedAt.get(attempt)!) continue;
|
|
const attempts = attemptsByExecution.get(candidate.name) ?? new Map();
|
|
const previous = attempts.get(attempt);
|
|
if (previous) {
|
|
const hasStarted = (job: WorkflowJob) => job.status === "in_progress" || job.status === "completed";
|
|
// GitHub can retain a queued placeholder with a different job ID even
|
|
// after its replacement starts. It has no execution evidence. Keep a
|
|
// lone queued latest attempt, however, so an older pass cannot mask it.
|
|
if (previous.status === "queued" && hasStarted(candidate)) {
|
|
attempts.set(attempt, candidate);
|
|
continue;
|
|
}
|
|
if (hasStarted(previous) && candidate.status === "queued") continue;
|
|
throw new Error(
|
|
`workflow attempt ${attempt} contains duplicate job ${candidate.name}`,
|
|
);
|
|
}
|
|
attempts.set(attempt, candidate);
|
|
attemptsByExecution.set(candidate.name, attempts);
|
|
}
|
|
|
|
const latestAttemptByExecution = new Map<string, number>();
|
|
for (const executionId of expected) {
|
|
const attempts = [...(attemptsByExecution.get(executionId)?.keys() ?? [])];
|
|
if (attempts.length === 0) {
|
|
throw new Error(
|
|
`workflow job history omitted expected execution ${executionId}`,
|
|
);
|
|
}
|
|
latestAttemptByExecution.set(executionId, Math.max(...attempts));
|
|
}
|
|
|
|
const recognizedArtifactNames = new Map<
|
|
string,
|
|
{ executionId: string; workflowAttempt: number }
|
|
>();
|
|
const recognizedCampaignNames = new Map<
|
|
string,
|
|
Array<{
|
|
artifactName: string;
|
|
executionId: string;
|
|
workflowAttempt: number;
|
|
}>
|
|
>();
|
|
for (const executionId of expected) {
|
|
for (const workflowAttempt of attemptsByExecution
|
|
.get(executionId)!
|
|
.keys()) {
|
|
const artifactName = `runner-e2e-${runId}-${workflowAttempt}-${executionId}`;
|
|
recognizedArtifactNames.set(artifactName, {
|
|
executionId,
|
|
workflowAttempt,
|
|
});
|
|
const campaignName = `gha-${runId}-${workflowAttempt}-${executionId}`;
|
|
const identities = recognizedCampaignNames.get(campaignName) ?? [];
|
|
identities.push({ artifactName, executionId, workflowAttempt });
|
|
recognizedCampaignNames.set(campaignName, identities);
|
|
}
|
|
}
|
|
|
|
const artifactEntries = await readdir(input.artifactRoot, {
|
|
withFileTypes: true,
|
|
}).catch((error: NodeJS.ErrnoException) => {
|
|
if (error.code === "ENOENT") return [];
|
|
throw error;
|
|
});
|
|
const artifactDirectories = new Map<
|
|
string,
|
|
| { layout: "wrapped"; directory: string }
|
|
| { layout: "flattened"; directory: string; campaignName: string }
|
|
>();
|
|
const singletonEntry = artifactEntries[0];
|
|
const singletonCampaignIdentities = singletonEntry
|
|
? recognizedCampaignNames.get(singletonEntry.name)
|
|
: undefined;
|
|
// download-artifact v8 flattens a single pattern match into the requested
|
|
// path. Accept that shape only when the expected set and campaign identity
|
|
// make the missing artifact-name wrapper unambiguous.
|
|
if (
|
|
expected.length === 1 &&
|
|
artifactEntries.length === 1 &&
|
|
singletonEntry?.isDirectory() &&
|
|
singletonCampaignIdentities?.length === 1
|
|
) {
|
|
const identity = singletonCampaignIdentities[0]!;
|
|
artifactDirectories.set(identity.artifactName, {
|
|
layout: "flattened",
|
|
directory: path.join(input.artifactRoot, singletonEntry.name),
|
|
campaignName: singletonEntry.name,
|
|
});
|
|
} else {
|
|
for (const entry of artifactEntries) {
|
|
const identity = recognizedArtifactNames.get(entry.name);
|
|
if (!identity || !entry.isDirectory()) {
|
|
throw new Error(`downloaded unexpected runner artifact ${entry.name}`);
|
|
}
|
|
artifactDirectories.set(entry.name, {
|
|
layout: "wrapped",
|
|
directory: path.join(input.artifactRoot, entry.name),
|
|
});
|
|
}
|
|
}
|
|
|
|
const selections: Array<{
|
|
executionId: string;
|
|
workflowAttempt: number;
|
|
artifactName: string;
|
|
}> = [];
|
|
for (const executionId of expected) {
|
|
const workflowAttempt = latestAttemptByExecution.get(executionId)!;
|
|
const artifactName = `runner-e2e-${runId}-${workflowAttempt}-${executionId}`;
|
|
const artifactDirectory = artifactDirectories.get(artifactName);
|
|
// A latest job without an artifact must remain missing. Falling back to an
|
|
// older successful artifact would mask an infrastructure/upload failure.
|
|
if (!artifactDirectory) continue;
|
|
|
|
const campaignName = `gha-${runId}-${workflowAttempt}-${executionId}`;
|
|
let campaignDirectory: string;
|
|
if (artifactDirectory.layout === "flattened") {
|
|
if (artifactDirectory.campaignName !== campaignName) {
|
|
throw new Error(
|
|
`${artifactName} must contain only its exact campaign ${campaignName}`,
|
|
);
|
|
}
|
|
campaignDirectory = artifactDirectory.directory;
|
|
} else {
|
|
const topLevelEntries = await readdir(artifactDirectory.directory, {
|
|
withFileTypes: true,
|
|
});
|
|
if (
|
|
topLevelEntries.length !== 1 ||
|
|
topLevelEntries[0]?.name !== campaignName ||
|
|
!topLevelEntries[0].isDirectory()
|
|
) {
|
|
throw new Error(
|
|
`${artifactName} must contain only its exact campaign ${campaignName}`,
|
|
);
|
|
}
|
|
campaignDirectory = path.join(artifactDirectory.directory, campaignName);
|
|
}
|
|
const resultFiles = (await walk(campaignDirectory)).filter(
|
|
(file) => path.basename(file) === "result.json",
|
|
);
|
|
if (resultFiles.length === 0) {
|
|
throw new Error(`${artifactName} contains no normalized result`);
|
|
}
|
|
for (const resultFile of resultFiles) {
|
|
const result = JSON.parse(
|
|
await readFile(resultFile, "utf8"),
|
|
) as RunnerE2EResult;
|
|
if (result.executionId !== executionId) {
|
|
throw new Error(
|
|
`${artifactName} contains result for ${String(result.executionId)}`,
|
|
);
|
|
}
|
|
const source = result.source;
|
|
if (
|
|
!source ||
|
|
source.sha !== input.sourceSha ||
|
|
source.ref !== input.sourceRef ||
|
|
source.workflowRunUrl !== input.workflowRunUrl
|
|
) {
|
|
throw new Error(`${artifactName} contains result from another source`);
|
|
}
|
|
}
|
|
const destination = path.join(
|
|
input.selectedRoot,
|
|
artifactName,
|
|
campaignName,
|
|
);
|
|
await mkdir(path.dirname(destination), { recursive: true });
|
|
await cp(campaignDirectory, destination, {
|
|
recursive: true,
|
|
force: false,
|
|
errorOnExist: true,
|
|
});
|
|
selections.push({ executionId, workflowAttempt, artifactName });
|
|
}
|
|
await mkdir(input.selectedRoot, { recursive: true });
|
|
await writeFile(path.join(input.selectedRoot, "selected-artifacts.json"), JSON.stringify({
|
|
version: 1, workflowRunId: runId, workflowRunAttempt: currentAttempt,
|
|
sourceSha: input.sourceSha, sourceRef: input.sourceRef, workflowRunUrl: input.workflowRunUrl, selections,
|
|
}));
|
|
return selections;
|
|
}
|
|
|
|
async function main() {
|
|
const required = (name: string) => {
|
|
const value = process.env[name]?.trim();
|
|
if (!value) throw new Error(`${name} is required`);
|
|
return value;
|
|
};
|
|
const expected = JSON.parse(
|
|
required("PAPERCLIP_RUNNER_E2E_EXPECTED_IDS"),
|
|
) as unknown;
|
|
if (
|
|
!Array.isArray(expected) ||
|
|
expected.some((value) => typeof value !== "string")
|
|
) {
|
|
throw new Error(
|
|
"PAPERCLIP_RUNNER_E2E_EXPECTED_IDS must be a JSON string array",
|
|
);
|
|
}
|
|
const jobs = JSON.parse(
|
|
await readFile(required("PAPERCLIP_RUNNER_E2E_JOBS_JSON"), "utf8"),
|
|
) as WorkflowJobsResponse;
|
|
if (!jobs || !Array.isArray(jobs.jobs) || !Array.isArray(jobs.attempts)) {
|
|
throw new Error("workflow jobs JSON must contain jobs and attempts arrays");
|
|
}
|
|
const runId = required("GITHUB_RUN_ID");
|
|
const serverUrl = required("GITHUB_SERVER_URL");
|
|
const repository = required("GITHUB_REPOSITORY");
|
|
const selections = await selectRerunArtifacts({
|
|
artifactRoot: required("PAPERCLIP_RUNNER_E2E_ARTIFACT_ROOT"),
|
|
selectedRoot: required("PAPERCLIP_RUNNER_E2E_SELECTED_ROOT"),
|
|
jobs,
|
|
expectedExecutionIds: expected,
|
|
workflowRunId: runId,
|
|
workflowRunAttempt: Number(required("GITHUB_RUN_ATTEMPT")),
|
|
sourceSha: required("PAPERCLIP_RUNNER_E2E_SOURCE_SHA"),
|
|
sourceRef: required("PAPERCLIP_RUNNER_E2E_SOURCE_REF"),
|
|
workflowRunUrl: `${serverUrl}/${repository}/actions/runs/${runId}`,
|
|
});
|
|
console.log(
|
|
`Selected ${selections.length}/${expected.length} latest cell artifacts`,
|
|
);
|
|
}
|
|
|
|
if (
|
|
process.argv[1] &&
|
|
import.meta.url === pathToFileURL(path.resolve(process.argv[1])).href
|
|
) {
|
|
await main().catch((error) => {
|
|
console.error(error instanceof Error ? error.message : String(error));
|
|
process.exitCode = 1;
|
|
});
|
|
}
|