mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-11-08 01:57:31 +01:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work > - Product E2E journeys drive the real UI and run in the QA staging smoke plan > - Two UI changes landed after the previous QA deployment: the Projects toolbar action is now "Create project" (#18716), and Artifacts V1 is on for every instance (#19164), so attachment rows offer download as an icon link with an `aria-label` > - The journeys still clicked "Add Project" and required a visible "Download" text, so they timed out before reaching the server > - This pull request accepts both the old and the current controls > - The benefit is that project-task-context, build-revise and stop-redirect measure the product again on current deployments ## Linked Issues or Issue Description **What happened?** On the QA deployment ofcb8df178c8, three journeys failed with the generic `journey_operation_failed`: project-task-context, build-revise and stop-redirect. Records on the stack show that build-revise and stop-redirect delivered their ZIP and finished. The user's next interaction never reached the server. **Expected behavior** The journeys use the controls that the current UI shows. **Steps to reproduce** 1. Run the `project-task-context` product journey against a managed local target atcb8df178c8. 2. Playwright waits 30 seconds for `getByRole('button', { name: 'Add Project', exact: true })` and times out. 3. For downloads, an Artifacts V1 row renders `<a href=".../content?download=1" aria-label="Download slugify.zip">` with only an icon. `filter({ hasText: /Download/i })` matches no element. **Paperclip version or commit** master at 03eb49053f; deployed QA appcb8df178c8. ## What Changed - `project-context-flow.ts`: open the new-project dialog with the button named "Add Project" or "Create project". - `story-artifact.ts`: find the attachment download link by "Download" text or by an `aria-label` that starts with "Download". The attachment ID is still required in the link. ## Verification - Local managed target atcb8df178c8: project-task-context failed with the old selector (Playwright timeout on "Add Project") and passed 1/1 with this change. - A Chromium check with Playwright on V1, legacy and no-download markup: the old locator finds 0 elements on V1 markup. The new locator finds the download link on V1 and legacy markup, and finds nothing on markup without a download link. - `npx vitest run --config tests/runner-e2e/vitest.config.ts tests/runner-e2e/product-journeys tests/runner-e2e/story-artifact`: 47 files, 1237 tests passed. - Not run live on QA yet. QA uses the pinned harness (`QA_SMOKE_HARNESS_SHA`), so the pin must move to a commit that contains this change. ## Risks - Low risk. Only the selectors change. All assertions, download checks and artifact checks stay the same. - The download link must still point at the exact attachment's content route. The "Open raw" icon link is not selected. ## Model Used - Claude Opus 5.5 (`claude-opus-5-5`), Anthropic, via Claude Code with tool use (shell, browser, code editing). Extended reasoning was used. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [ ] All Paperclip CI gates are green - [ ] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
32 lines
1.8 KiB
TypeScript
32 lines
1.8 KiB
TypeScript
import { expect, test } from "@playwright/test";
|
|
import { newProjectButton } from "./product-journeys/project-context-flow.js";
|
|
import { storyArtifactDownloadLink } from "./story-artifact.js";
|
|
|
|
const id = "11111111-2222-4333-8444-555555555555";
|
|
|
|
test("finds the attachment download link in legacy and Artifacts V1 markup only", async ({ page }) => {
|
|
const markup = {
|
|
legacy: `<a href="/api/attachments/${id}/content?download=1">Download</a>`,
|
|
// Artifacts V1: an icon-only "Open raw" link precedes the icon-only download link.
|
|
v1: `<span>slugify.zip</span><a href="/api/attachments/${id}/content" aria-label="Open raw slugify.zip"><svg width="8" height="8"></svg></a>`
|
|
+ `<a href="/api/attachments/${id}/content?download=1" download="slugify.zip" aria-label="Download slugify.zip"><svg width="8" height="8"></svg></a>`,
|
|
none: `<a href="/api/attachments/${id}/content" aria-label="Open raw slugify.zip">Open</a>`
|
|
+ `<a href="/api/attachments/other/content?download=1" aria-label="Download other.zip">Download</a>`,
|
|
};
|
|
for (const kind of ["legacy", "v1"] as const) {
|
|
await page.setContent(markup[kind]);
|
|
await expect(storyArtifactDownloadLink(page, id)).toHaveAttribute("href", `/api/attachments/${id}/content?download=1`);
|
|
}
|
|
await page.setContent(markup.none);
|
|
await expect(storyArtifactDownloadLink(page, id)).toHaveCount(0);
|
|
});
|
|
|
|
test("opens new-project creation with the previous or current toolbar label only", async ({ page }) => {
|
|
for (const label of ["Add Project", "Create project"]) {
|
|
await page.setContent(`<button>Create project template</button><button>${label}</button>`);
|
|
await expect(newProjectButton(page)).toHaveText(label);
|
|
}
|
|
await page.setContent(`<button>Create project template</button><button>New issue</button>`);
|
|
await expect(newProjectButton(page)).toHaveCount(0);
|
|
});
|