Files
PaperClipAI/tests/e2e/chat-adapters-ui-messaging.spec.ts
T
Devin FoleyandPaperclip 21bf7ebcee feat(connectors): connect Tailscale networks to SSH environments (#20617)
## Thinking Path

> - Paperclip manages work for AI agents.
> - SSH environments run tasks on computers that users own.
> - A Paperclip server needs network access before it can reach a
private computer.
> - A reusable Tailscale connection belongs in Connectors.
> - Connected machines should become choices in the existing SSH
environment form.
> - This change connects a tailnet and resolves selected machines
through a private network client.
> - Agents retain their choice of harness and AI account.

## Linked Issues or Issue Description

**Subsystem affected**

Connectors, environment settings, SSH execution, company secret storage,
and runtime packaging.

**Problem or motivation**

Entering a Tailscale address in the SSH form does not connect the
Paperclip server to that tailnet. Requiring a separate device key for
every environment also duplicates network setup.

**Proposed solution**

Add a Tailscale Connector with **Connect Tailscale Network**. Use
brokered OAuth consent to enroll one private network client per
connection. Let SSH environments select a connected network and stable
machine identity. Preserve the enrolled node state through the company
vault so a restart does not reuse the one-time token.

**Alternatives considered**

A separate Tailscale environment type would duplicate SSH behavior and
mix network access with harness selection. This change uses the existing
`ssh` driver. Related #15648 adds OAuth client credentials and a health
check; this change uses user consent and supplies outbound task
execution. Related #11743 concerns HTTPS brokering.

**Roadmap alignment**

This extends the existing Connected Apps, environment, and Personal &
Shared AI Accounts capabilities. This PR is stacked on #21248, which
provides SSH account selection independently of Tailscale. The hosted
OAuth broker is a companion control-plane change.

## What Changed

- Preserve Cloud reauthentication in the current browser tab. Explain
canceled or failed consent in the connector and offer a retry of the
same authorized saved connection.
- Record Cloud enrollment starts initiated through the Tailscale
connector in the company activity log.
- Check install-preparation descendant liveness through the kernel
process table in the Runner support test. Keep the direct child’s strict
reaping assertion and reject any non-zombie descendant.
- Align the application image stage contract with the Tailscale client
stage after the upstream Runner-image refactor. Keep the exact stage
list and check every application stage, including `tailscale-client`,
for prohibited Runner compiler commands.
- Group Tailscale consent, discovery, daemon lifecycle, pairing, and
deletion under `server/src/services/connectors/tailscale/`, with their
service tests. Update existing route, runtime, environment, vault, and
company-deletion imports. Keep the existing contracts, authorization,
audit, and transaction owners.
- Handle early stdin closure in the Kubernetes real-shell test helper.
Stop the input stream on `EPIPE`, preserve nonzero child exits, and
reject a zero exit when input was lost. Add two real-process regression
cases. Production transfer code and confinement checks are unchanged.
- Read configured Tailscale executable paths when a client starts, after
supported `.env` loading. Keep explicit command overrides available.
- Discard pending pairing results after switching to Direct SSH or
closing the form. Retain the existing company, connection, machine, and
port checks.
- Store network credentials with an immutable server-owned purpose from
their first vault row. Exclude them from generic catalogs, bindings,
environment projection, and value reads. Use a dedicated audited server
consumer for pinned connector reads. Block unclassified legacy
serialized node state at the same value boundary. Keep SSH private-key
binding separate from connector credentials.
- Gate network queries and setup on verified local-implicit or
instance-admin access. Hide Tailscale catalog rows for other members,
show an admin requirement on direct setup navigation, and avoid device
discovery before management access is known.
- Keep failed-client cleanup in the network manager. A failed request
cannot disconnect a newer retry for the same identity; explicit
connector disconnect and enrollment retirement still stop their
networks.
- Check for readable Ed25519, ECDSA, or RSA host public keys before
pairing edits `authorized_keys`. Print a known-hosts entry for every
available key, or fail before changing authorized keys if none are
available.
- Return self-hosted Cloud enrollment to the Tailscale connector. Save
the unprefixed setup path and let the shared callback add the verified
company prefix. Keep external and unrelated destinations rejected.
- Hide pairing instructions after an SSH port change. Ignore late
key-selection results for the old port. Operators prepare again for
matching known-hosts output.
- Retire connector references before deleting a company or its vault
credential. Stop company daemons after the database commit. Keep failed
secret retirement retryable and prevent late node-state writes from
restoring deleted connections. Discard retired state without blocking
behind the vault deletion lock.
- Reload a mismatched credential before replacing a ready daemon.
Recheck the active entry and manager generation after the read. An older
request cannot stop a newer healthy socket or cross shutdown.
- Pin connector credentials to the exact vault version and SHA-256
digest recorded by trusted enrollment and node-state writes. Ignore
generic secret rotations. Advance both fields with a compare-and-set
guard. Reject unpinned or tampered credentials before network startup.
- Save an explicit Direct SSH selection and clear old Tailscale fields
after config merging. Preserve the operator's entered direct host.
- Route all Tailscale SSH runtime access through the connection service
after SSH-key loading. Pin access to the environment's saved connector
identity and recheck after device discovery. Remove standalone key-based
daemon startup and reject raw enrollment keys or credential-only network
configurations. Align the shared config type and SDK pins.
- Correct two E2E assumptions exposed during connector qualification.
Keep the two-window chat fixture stale until its own mutation. Validate
the original failed run and its permitted write-revocation timestamp in
the legacy recovery browser test.
- Add the Tailscale Connector page, catalog entry, OAuth return flow,
connected-network management, device discovery, and disconnect. Document
all six routes in OpenAPI and the API reference, including their
instance-admin requirement.
- Add company-scoped connection storage in `0480_lazy_lethal_legion`,
trusted credential version/digest fields in `0481_round_pet_avengers`,
and server-owned secret purpose/backfill in
`0482_aberrant_rumiko_fujikawa`. Generate all three migrations through
the maintained command and retain the five newest snapshots.
- Add machine pairing that generates a fresh SSH key per request, stores
its private half in the company vault, and uses the generated public
half in the install command. Do not trust editable saved metadata.
Preserve existing authorized keys, including a file without a final
newline. Keep SSH username, workspace, and trusted host keys explicit.
- Use the existing SSH driver. Resolve the machine's current address
from its stable device ID. Reject disconnected, removed, offline, and
wrong-company selections.
- Hide Network when Direct is the only option. Select a sole connected
tailnet automatically and hide its selector. Remove the requested setup
helper copy. Do not restrict the harness to Claude.
- Run a private userspace Tailscale daemon with a separate socket.
Persist its node state before execution. Restore it after restart, bound
startup, serialize reconnect cleanup, and close it during server
shutdown.
- Guard OAuth completion with a durable attempt marker. Disconnect and
newer authorization invalidate older callbacks. Close replaced daemons
and remove cancelled enrollment secrets without changing newer
connection state.
- Preserve SSH host verification and tailnet-specific session identity.
Honor the configured Tailscale executable path, including spaces and
OpenSSH percent escaping.
- Package checksum-pinned Tailscale clients and their license in the
standard runtime image. Exercise the client build stage in PR CI and
include it in image smoke checks.

## Verification

- Merge status: all CI and image checks pass, and current-head Apex is
5/5 with no unresolved comments. GitHub rejected a direct merge because
the active master ruleset requires code-owner approval for
`.github/workflows/pr-trusted.yml`. The [CODEOWNERS workflow
pattern](https://github.com/paperclipai/paperclip/blob/master/.github/CODEOWNERS#L3)
applies; eligible maintainers already have review requests. Auto-merge
is enabled with the squash method for the verified head. The PR remains
open pending that required approval; no branch policy was bypassed.
- Final revision: `fdb29b2cc366f4945b7f4c3e2b2d25070329a21b`, including
master `999709b0a6dd416af335b5debded13e1de7fcb7a`. [Final CI
verification
passed](https://github.com/paperclipai/paperclip/actions/runs/43518584814/job/132213508320).
All required checks pass, all applicable test/build gates are green, and
the branch is mergeable against master. SSH prerequisite #21248 and
Cloud broker paperclipai/paperclip-cloud#1314 are already merged.
- [Apex reviewed this exact revision at
5/5](https://github.com/paperclipai/paperclip/pull/20617#issuecomment-6776629437).
There are no unresolved review threads. The PR is classified as Critical
impact.
- Final image qualification passes for the [application Runner
path](https://github.com/paperclipai/paperclip/actions/runs/43518584522/job/132206784267),
[amd64 Runner
image](https://github.com/paperclipai/paperclip/actions/runs/43518584544/job/132207296198),
and [arm64 Runner
image](https://github.com/paperclipai/paperclip/actions/runs/43518584544/job/132207296156).
Typechecks, Runner support, native/Rust tests, provider tests,
serialized-server suites, browser shards, and the remaining applicable
CI checks pass. This is source/image CI qualification, not a production
rollout.
- The last master conflict affected only Docker stage declarations and
their boundary test. Both the checksum-pinned Tailscale stage and
upstream `runner-lockfile` guard are retained, including the upstream
`deps` inheritance. The Tailscale client stage is byte-identical. All
180 cases across five Docker/image contract suites pass locally, along
with server and UI typechecks. The maintained 543-input SDK check has no
drift. Runtime and lock pins are unchanged. Secret/PII and whitespace
scans pass.
- Seven OAuth regression cases failed before the fixes. The current-tab
test uses the real handoff helper, checks that the session is stored
before reauthentication navigation, mounts the shared return page,
resumes consent, and verifies handoff cleanup. Callback tests check
trusted saved-connection context, fixed safe outcomes, failure audit
metadata, denied membership and expired-state rejection, JSON API
errors, and no provider text in browser returns. UI retries require a
connection in the current company's catalog. All 80 OAuth
route/service/UI/shared-handoff cases pass; server and UI source/test
typechecks pass.
- [Server shard 4/12 on the prior
refresh](https://github.com/paperclipai/paperclip/actions/runs/43510727031/job/132180301436)
passed 2,784 cases and skipped 21, then failed a reassignment fixture's
`TRUNCATE companies CASCADE` cleanup with PostgreSQL `40P01`. Its
automatic retry found the surviving `REA` prefix. The unchanged test
passes all three cases locally. A controlled reader/cleanup overlap
reproduces the same deadlock, but the exact competing CI query was not
logged. Each case now has a distinct company prefix and identifier; the
owned database is removed at suite end. The three test bodies and
assertions are byte-identical. Eight local reassignment/lock-release
cases pass, and the [final server shard 4/12
passes](https://github.com/paperclipai/paperclip/actions/runs/43518584814/job/132207159392).
Production reassignment logic, deadlines, and retries are unchanged.
- The initial master integration passed 330 cases across 17 suites.
Coverage includes connector state, device discovery, network lifecycle,
pairing, routes, SSH binding and exports, environment persistence, and
connector UI. All three unpublished migrations were regenerated after
master's `0479_short_darkstar`: `0480_lazy_lethal_legion`,
`0481_round_pet_avengers`, and `0482_aberrant_rumiko_fujikawa`. Each SQL
body is byte-identical to its earlier unpublished migration. Generated
snapshots preserve existing master tables and add only the intended
Tailscale table and secret-purpose column. Exactly five snapshots
remain, 0478–0482. Numbering, safety, compatibility, and snapshot-drift
checks pass. The later Docker refresh did not alter this migration
sequence.
- Earlier attempts remain part of the verification record. On `1c020a0`,
Rust cache restoration and server shard 5/12 were interrupted by
shutdown signals, Runner shard 2/3 lost communication with no
retrievable log, and an amd64 provider download failed with npm
`ECONNRESET`. Same-head retries recovered, without establishing the
cause of the communication loss. Later superseded runs also had
cancellations with incomplete logs. These interrupted attempts are not
counted as passes. The final revision has fresh successful CI.
- Local platform limits remain recorded. The Kubernetes suite on macOS
passed 191 cases, failed 12 Linux `/proc/self/fd` transfer cases, and
skipped four Linux-only cases. Unchanged source reproduced the same 12
failures. An initial run also lacked provider dependencies until the
maintained preparation command installed them. Those local attempts are
not green qualification. Final Linux provider CI passes. Local Docker
qualification was unavailable; final image checks passed in CI.
- Before PR separation, a live tailnet/SSH Claude Code task completed on
Ubuntu ARM64 without provider login for the remote user. The selected
Paperclip subscription ran it, wrote the expected file, posted
completion, and marked the task done. File contents and private runtime
cleanup were checked. This is prior live evidence; the final revision
was not live-retested. Other providers have automated coverage only.
Hosted registration for unrelated tailnets and production concurrency
remain qualification limits below.
- The Superagent security and supply-chain reports remain neutral and
inconclusive. Earlier attempts to restart the failed security scan
returned HTTP 404. Supply-chain intelligence lacked coverage for
extracted pinned dependencies and the shared workflow reference. These
reports do not establish successful security qualification. The required
CI and review gates pass; this external coverage gap remains disclosed.

## Risks

- The Superagent security and supply-chain reports are inconclusive. The
security scan re-run request returned HTTP 404, and the supply-chain
scanner lacks coverage for the extracted dependencies and shared
workflow reference. These neutral results are not successful security
qualification.
- The server-owned secret purpose is internal database metadata, not an
HTTP-writable field. The generic secret service owns enforcement so
direct API reads and runtime projection share the same restriction.
Previously copied node state remains valid outside Paperclip until the
enrolled device is revoked in Tailscale; a local disconnect cannot stop
an external copy.
- Tailscale network configurations now require a connected Connector and
selected machine. The unreleased key-only path is removed; any saved
configuration from that path needs Connector setup.
- The connector remains a pilot. The local test used an OAuth app
registered in the consenting user's tailnet. Qualify hosted app
registration for unrelated customer tailnets before general
availability.
- This implementation supports one serving process per instance.
Concurrent replicas need exclusive ownership of the persisted network
identity before production rollout. Preserve the database and company
vault master key across restarts.
- Each machine-pairing preparation creates a new vault secret. Unused
generated keys follow the existing secret deletion lifecycle. A saved
SSH key remains available as an explicit choice.
- Apply additive migrations `0480_lazy_lethal_legion`,
`0481_round_pet_avengers`, and `0482_aberrant_rumiko_fujikawa` before
application rollout. The new credential version and digest columns are
nullable. Existing unpinned connections require fresh OAuth consent; the
migration deliberately does not trust or backfill a generic secret
value. Regenerate or renumber migrations if master advances the sequence
before merge.
- The target needs an SSH server, its chosen harness, and allowed
tailnet access. A reachable network does not grant SSH or provider
authorization. Pairing reads standard `/etc/ssh` host-public-key files;
custom host-key locations require manual known-hosts configuration.
- Roll back the application revision to remove new entry points.
Existing connection secrets and registered Tailscale nodes retain their
separate lifecycle. Do not drop the table or delete node state as part
of an application rollback.
- Production qualification still needs denied-policy, revocation,
cancellation, and deployment-overlap checks. Local Docker and a
production deployment were not performed.

## Model Used

OpenAI Codex, gpt-6.1-sol, xhigh reasoning, with local code execution
and tool use.

## Checklist

- [x] I have included a thinking path that traces from project context
to this change
- [x] I have specified the model used
- [x] I have checked ROADMAP.md and this extends existing connector and
environment features
- [x] I have searched GitHub for duplicate or related PRs and linked
them above
- [x] I have described the issue in-PR using the feature request fields
- [x] I have not referenced internal issues, local URLs, or private
machine identifiers
- [x] My branch name describes the change
- [x] I have run focused tests locally and they pass
- [x] I have added tests for new behavior and failure paths
- [x] I have updated documentation
- [x] I have documented migration and runtime risks
- [x] All Paperclip CI gates are green
- [ ] Required code-owner approval received for the workflow change
- [x] Greptile Apex is 5/5 on the final head with no unresolved comments
- [x] I will address CI and review findings before requesting merge

---------

Co-authored-by: Paperclip <noreply@paperclip.ing>
2026-11-13 15:15:43 -08:00

1639 lines
60 KiB
TypeScript

import { expect, test, type Page, type Route } from "@playwright/test";
import {
fulfill,
installChatControlPlaneMock,
json,
seedCompanyAndAgent,
PROVIDERS,
bodyOf,
type Seed,
} from "./chat-adapters-ui.shared";
/**
* Native chat-connector messaging coverage: destination partial updates,
* board send delivery refresh, and exact failed-run retry. Shared fixtures
* and the chat-control-plane mock live in ./chat-adapters-ui.shared.ts; the
* provider-setup describes run in chat-adapters-ui-providers.spec.ts.
*/
test.describe("chat destination partial updates", () => {
let seed: Seed;
test.beforeAll(async ({ request }) => {
seed = await seedCompanyAndAgent(request);
});
for (const initiallyEnabled of [false, true]) {
test(`a stale Settings view preserves another view's ${initiallyEnabled ? "revocation" : "grant"}`, async ({
context,
page,
}) => {
const provider = PROVIDERS.find((item) => item.provider === "discord")!;
// Both real pages share one server fixture, but have separate query caches.
const mock = await installChatControlPlaneMock(context, provider, seed, {
enableChatConnectors: true,
});
mock.setStatus("active");
const settingsUrl = `/${seed.prefix}/apps/chat/endpoint-discord/settings`;
const primarySwitch = (view: Page) =>
view.getByRole("switch", { name: `Enable ${provider.resourceLabel}` });
const secondarySwitch = (view: Page) =>
view.getByRole("switch", {
name: `Enable ${provider.secondaryResourceLabel}`,
});
await page.goto(settingsUrl);
await expect(primarySwitch(page)).not.toBeChecked();
if (initiallyEnabled) {
await primarySwitch(page).click();
await expect(primarySwitch(page)).toBeChecked();
}
const staleView = await context.newPage();
const resourcesPath = "/api/chat-endpoints/endpoint-discord/resources";
const initialResources = staleView.waitForResponse(response =>
new URL(response.url()).pathname === resourcesPath && response.request().method() === "GET",
);
await staleView.goto(settingsUrl);
const snapshot = await (await initialResources).json();
let retainSnapshot = true;
await staleView.route(`**${resourcesPath}`, async route => {
const method = route.request().method();
if (method === "GET" && retainSnapshot) {
await fulfill(route, snapshot);
return;
}
if (method === "PUT") retainSnapshot = false;
await route.fallback();
});
await expect(primarySwitch(staleView)).toBeChecked({
checked: initiallyEnabled,
});
await expect(secondarySwitch(staleView)).not.toBeChecked();
await primarySwitch(page).click();
await expect(primarySwitch(page)).toBeChecked({
checked: !initiallyEnabled,
});
await expect(primarySwitch(staleView)).toBeChecked({
checked: initiallyEnabled,
});
await secondarySwitch(staleView).click();
await expect(secondarySwitch(staleView)).toBeChecked();
await expect(primarySwitch(staleView)).toBeChecked({
checked: !initiallyEnabled,
});
expect(mock.resourceUpdates.at(-1)).toEqual([
{ id: "resource-discord-secondary", enabled: true },
]);
// The full response refreshes this page, and persisted state survives reload.
await page.reload();
await expect(primarySwitch(page)).toBeChecked({
checked: !initiallyEnabled,
});
await expect(secondarySwitch(page)).toBeChecked();
await staleView.close();
});
}
test("a pending destination change stays truthful on rejection and explicit retry", async ({
page,
}, testInfo) => {
const provider = PROVIDERS.find((item) => item.provider === "discord")!;
const mock = await installChatControlPlaneMock(page, provider, seed, {
enableChatConnectors: true,
});
mock.setStatus("active");
const attempts: unknown[] = [];
let holdFirstPut!: (route: Route) => void;
const firstPut = new Promise<Route>((resolve) => {
holdFirstPut = resolve;
});
await page.route(
"**/api/chat-endpoints/endpoint-discord/resources",
async (route) => {
if (route.request().method() === "PUT") {
attempts.push(bodyOf(route));
if (attempts.length === 1) {
holdFirstPut(route);
return;
}
}
await route.fallback();
},
);
await page.goto(`/${seed.prefix}/apps/chat/endpoint-discord/settings`);
const primary = page.getByRole("switch", { name: "Enable #general" });
const secondary = page.getByRole("switch", { name: "Enable #support" });
await expect(primary).not.toBeChecked();
await primary.click();
const held = await firstPut;
try {
await expect(primary).toBeDisabled();
await expect(secondary).toBeDisabled();
await expect(primary).not.toBeChecked();
await expect(secondary).not.toBeChecked();
expect(mock.resourceUpdates).toEqual([]);
await page.screenshot({
path: testInfo.outputPath("destination-pending.png"),
});
} finally {
await fulfill(
held,
{ error: "Destination is no longer available. Refresh and try again." },
409,
);
}
await expect(
page.getByText("Couldn't update destination", { exact: true }),
).toBeVisible();
await expect(
page.getByText(
"Destination is no longer available. Refresh and try again.",
{ exact: true },
),
).toBeVisible();
await expect(primary).toBeEnabled();
await expect(secondary).toBeEnabled();
await expect(primary).not.toBeChecked();
await expect(secondary).not.toBeChecked();
expect(mock.resourceUpdates).toEqual([]);
expect(attempts).toEqual([
{ resources: [{ id: "resource-discord", enabled: true }] },
]);
// Visibility alone also matches the toast's initial transparent animation frame.
await expect(
page
.getByRole("listitem")
.filter({ hasText: "Couldn't update destination" }),
).toHaveCSS("opacity", "1");
await page.screenshot({
path: testInfo.outputPath("destination-rejected.png"),
});
await primary.click();
await expect(primary).toBeChecked();
await expect(secondary).not.toBeChecked();
expect(attempts).toEqual([
{ resources: [{ id: "resource-discord", enabled: true }] },
{ resources: [{ id: "resource-discord", enabled: true }] },
]);
expect(mock.resourceUpdates).toEqual([
[{ id: "resource-discord", enabled: true }],
]);
await page.reload();
await expect(primary).toBeChecked();
await expect(secondary).not.toBeChecked();
await page.screenshot({
path: testInfo.outputPath("destination-retry-saved.png"),
});
});
test("one toggle succeeds with more than 500 discovered destinations", async ({
page,
}) => {
const provider = PROVIDERS.find((item) => item.provider === "discord")!;
const mock = await installChatControlPlaneMock(page, provider, seed, {
enableChatConnectors: true,
resourceCount: 501,
});
mock.setStatus("active");
await page.goto(`/${seed.prefix}/apps/chat/endpoint-discord/settings`);
await expect(page.getByRole("switch", { name: /^Enable / })).toHaveCount(
501,
);
const target = page.getByRole("switch", {
name: "Enable Extra destination 499",
});
await expect(target).not.toBeChecked();
await target.click();
await expect(target).toBeChecked();
expect(mock.resourceUpdates).toEqual([
[{ id: "resource-discord-extra-498", enabled: true }],
]);
await expect(
page.getByRole("switch", { name: "Enable #general" }),
).not.toBeChecked();
await page.reload();
await expect(target).toBeChecked();
await expect(page.getByRole("switch", { name: /^Enable / })).toHaveCount(
501,
);
});
});
test.describe("Board send delivery refresh", () => {
for (const classic of [false, true]) {
for (const entry of [
"uuid",
"uppercase-uuid",
"wrong-prefix-identifier",
] as const) {
test(`opens external task links in their own organization and uploads safely (${entry}, classic=${classic})`, async ({
page,
request,
}) => {
await page.addLocatorHandler(
page.getByRole("complementary", { name: "Paperclip announcements", exact: true })
.getByRole("button", { name: "Dismiss announcement", exact: true }),
async (dismiss) => {
const menuOpen = await page.getByRole("menu", { name: "Add to composer", exact: true }).isVisible();
if (menuOpen) await page.keyboard.press("Escape");
await dismiss.click();
if (menuOpen) await page.getByRole("button", { name: "Add to composer", exact: true }).click();
},
);
const selected = await seedCompanyAndAgent(request);
const target = await seedCompanyAndAgent(request);
const issue = await json<{ id: string; identifier: string }>(
await request.post(`/api/companies/${target.companyId}/issues`, {
data: { title: "Organization-bound task link", status: "backlog" },
}),
"create linked task in another organization",
);
await page.route("**/api/workspace-preferences/me", route => fulfill(route, {
userId: "local-board", coordinatorWorkspaceEnabled: !classic, updatedAt: null,
}));
await page.route("**/api/instance/settings/experimental", (route) =>
fulfill(route, {
enableChatConnectors: true,
enableClassicTaskInterface: classic,
}),
);
await page.goto(`/${selected.prefix}/issues`);
await expect
.poll(() =>
page.evaluate(() =>
localStorage.getItem("paperclip.selectedCompanyId"),
),
)
.toBe(selected.companyId);
await page.goto(
entry === "uuid"
? `/issues/${issue.id}`
: entry === "uppercase-uuid"
? `/issues/${issue.id.toUpperCase()}`
: `/${selected.prefix}/issues/${issue.identifier}?external=chat#files`,
);
if (!classic) {
await expect(page.getByTestId("task-chat-history-content")).toBeVisible({ timeout: 30_000 });
}
await expect(
page.getByRole("heading", {
name: "Organization-bound task link",
exact: true,
}),
).toBeVisible();
await expect
.soft(page)
.toHaveURL(
new RegExp(
`/${target.prefix}/issues/${issue.identifier}${
entry === "wrong-prefix-identifier"
? "\\?external=chat#files"
: ""
}$`,
),
{ timeout: 4_000 },
);
const file = {
name: classic ? "task-link-report.txt" : "task-link-image.png",
mimeType: classic ? "text/plain" : "image/png",
buffer: classic
? Buffer.from("Synthetic cross-organization upload proof.\n")
: Buffer.from(
"iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAQAAAC1HAwCAAAAC0lEQVR42mP8/x8AAwMCAO+jfFoAAAAASUVORK5CYII=",
"base64",
),
};
if (!classic) {
await page.getByRole("button", { name: "Add to composer" }).click();
}
const chooserPromise = page.waitForEvent("filechooser");
await (classic
? page.getByRole("button", { name: "Upload attachment", exact: true })
: page.getByRole("menuitem", { name: "Files and images", exact: true })
).click();
const responsePromise = page.waitForResponse(
(response) =>
response.request().method() === "POST" &&
/\/api\/companies\/[^/]+\/issues\/[^/]+\/attachments$/.test(
new URL(response.url()).pathname,
),
);
await (await chooserPromise).setFiles(file);
const response = await responsePromise;
expect.soft(response.status(), await response.text()).toBe(201);
expect
.soft(new URL(response.url()).pathname)
.toBe(
`/api/companies/${target.companyId}/issues/${issue.id}/attachments`,
);
const attachments = await json<
{
originalFilename: string;
contentPath: string;
issueCommentId: string | null;
}[]
>(
await request.get(`/api/issues/${issue.id}/attachments`),
"read linked task attachments",
);
expect(attachments).toHaveLength(1);
expect(attachments[0]).toMatchObject({
originalFilename: file.name,
issueCommentId: null,
});
expect(
await (await request.get(attachments[0].contentPath)).body(),
).toEqual(file.buffer);
expect(
await json<unknown[]>(
await request.get(`/api/issues/${issue.id}/comments`),
"read linked task comments",
),
).toHaveLength(0);
await expect
.poll(() =>
page.evaluate(() =>
localStorage.getItem("paperclip.selectedCompanyId"),
),
)
.toBe(target.companyId);
});
}
}
test("keeps the connected-task banner readable in narrow task panes", async ({
page,
request,
}) => {
const seed = await seedCompanyAndAgent(request);
const issue = await json<{ id: string; identifier: string }>(
await request.post(`/api/companies/${seed.companyId}/issues`, {
data: { title: "Connected banner layout", status: "backlog" },
}),
"create connected banner task",
);
await page.route("**/api/instance/settings/experimental", (route) =>
fulfill(route, { enableChatConnectors: true }),
);
await page.route(`**/api/issues/${issue.id}/chat-binding`, (route) =>
fulfill(route, {
endpointId: "aaaaaaaa-aaaa-4aaa-8aaa-aaaaaaaaaaaa",
conversationId: "bbbbbbbb-bbbb-4bbb-8bbb-bbbbbbbbbbbb",
provider: "discord",
externalLabel: "#a-long-but-readable-qualification-channel-name",
externalUrl: "https://discord.com/channels/test-server/test-thread",
assignedAgentLocked: true,
}),
);
await page.goto(`/${seed.prefix}/issues/${issue.identifier}`);
const banner = page.getByRole("region", {
name: "External conversation",
exact: true,
});
const heading = banner.getByText("Connected to Discord", { exact: true });
await expect(heading).toBeVisible();
// Exercise container widths independently of the operator's sidebar and
// Properties preferences. These are test constraints, not product styles.
for (const width of [340, 500, 760]) {
await banner.evaluate((element, value) => {
element.style.width = `${value}px`;
}, width);
await expect
.poll(() =>
heading
.evaluate((element) => ({
height: element.getBoundingClientRect().height,
lineHeight: Number.parseFloat(
getComputedStyle(element).lineHeight,
),
}))
.then(({ height, lineHeight }) => height <= lineHeight * 1.5),
)
.toBe(true);
const bounds = await banner.boundingBox();
expect(bounds).not.toBeNull();
for (const action of [
banner.getByRole("link", { name: "Open Discord", exact: true }),
banner.getByRole("button", { name: "Send to channel", exact: true }),
banner.getByRole("link", { name: "Connection", exact: true }),
]) {
await expect(action).toBeVisible();
const box = await action.boundingBox();
expect(box).not.toBeNull();
expect(box!.x).toBeGreaterThanOrEqual(bounds!.x);
expect(box!.x + box!.width).toBeLessThanOrEqual(
bounds!.x + bounds!.width,
);
expect(box!.y + box!.height).toBeLessThanOrEqual(
bounds!.y + bounds!.height,
);
}
}
});
test("uploads images and files directly from an empty channel composer without publishing early", async ({
page,
request,
}) => {
const seed = await seedCompanyAndAgent(request);
const issue = await json<{ id: string; identifier: string }>(
await request.post(`/api/companies/${seed.companyId}/issues`, {
data: { title: "Upload channel files", status: "backlog" },
}),
"create upload task",
);
const endpointId = "aaaaaaaa-aaaa-4aaa-8aaa-aaaaaaaaaaaa";
const conversationId = "bbbbbbbb-bbbb-4bbb-8bbb-bbbbbbbbbbbb";
const publicationId = "cccccccc-cccc-4ccc-8ccc-cccccccccccc";
const sends: Record<string, unknown>[] = [];
let releaseSend!: () => void;
const sendResponse = new Promise<void>((resolve) => {
releaseSend = resolve;
});
await page.route("**/api/instance/settings/experimental", (route) =>
fulfill(route, { enableChatConnectors: true }),
);
await page.route(`**/api/issues/${issue.id}/chat-binding`, (route) =>
fulfill(route, {
endpointId,
conversationId,
provider: "discord",
externalLabel: "#upload-test",
assignedAgentLocked: true,
}),
);
await page.route(
`**/api/chat-endpoints/${endpointId}/conversations/${conversationId}/publications`,
async (route) => {
sends.push(bodyOf(route));
await sendResponse;
return fulfill(
route,
{ id: publicationId, state: "streaming", attempts: 1 },
201,
);
},
);
await page.route(
`**/api/chat-endpoints/${endpointId}/conversations/${conversationId}/publications/${publicationId}/status`,
(route) =>
fulfill(route, {
publication: { id: publicationId, state: "pending", attempts: 0 },
total: 3,
published: 0,
}),
);
await page.goto(`/${seed.prefix}/issues/${issue.identifier}`);
await page
.getByRole("button", { name: "Send to channel", exact: true })
.click();
const input = page.getByLabel("Attach file to channel update", {
exact: true,
});
const files = [
{
name: "channel-image.png",
mimeType: "image/png",
buffer: Buffer.from(
"iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAQAAAC1HAwCAAAAC0lEQVR42mP8/x8AAwMCAO+jfFoAAAAASUVORK5CYII=",
"base64",
),
},
{
name: "channel-report.txt",
mimeType: "text/plain",
buffer: Buffer.from("Synthetic channel upload proof.\n"),
},
];
for (const file of files) {
await input.setInputFiles(file);
await expect(
page
.getByRole("group", { name: "Include task files", exact: true })
.getByRole("checkbox", { name: file.name, exact: true }),
).toBeChecked();
await expect(input).toBeEnabled();
}
expect(sends).toHaveLength(0);
const stored = await json<
{
id: string;
originalFilename: string;
contentPath: string;
issueCommentId: string | null;
}[]
>(
await request.get(`/api/issues/${issue.id}/attachments`),
"read uploaded files",
);
expect(stored).toHaveLength(2);
for (const file of files) {
const attachment = stored.find(
(item) => item.originalFilename === file.name,
)!;
expect(attachment.issueCommentId).toBeNull();
const content = await request.get(attachment.contentPath);
expect(content.ok()).toBe(true);
expect(await content.body()).toEqual(file.buffer);
}
expect(
await json<unknown[]>(
await request.get(`/api/issues/${issue.id}/comments`),
"read internal comments",
),
).toHaveLength(0);
await page
.getByRole("textbox", { name: "Board update", exact: true })
.fill("Publish these two synthetic files.");
await page
.getByRole("button", { name: "Send to channel", exact: true })
.last()
.click();
await expect.poll(() => sends.length).toBe(1);
await expect(
page.getByRole("button", { name: "Sending…", exact: true }),
).toBeDisabled();
await expect(
page.getByText("Delivery result not confirmed", { exact: true }),
).toHaveCount(0);
releaseSend();
expect(sends[0].attachmentIds).toEqual(
files.map(
(file) =>
stored.find((item) => item.originalFilename === file.name)!.id,
),
);
await expect(input).toBeDisabled();
await page.reload();
const retained = page.getByRole("group", {
name: "Files in this send",
exact: true,
});
for (const file of files) {
await expect(
retained.getByRole("checkbox", { name: file.name, exact: true }),
).toBeChecked();
await expect(
retained.getByRole("checkbox", { name: file.name, exact: true }),
).toBeDisabled();
}
expect(sends).toHaveLength(1);
});
test("recovers an uncertain channel send into a durable rejection before an explicit correction", async ({
page,
request,
}, testInfo) => {
const seed = await seedCompanyAndAgent(request);
const issue = await json<{ id: string; identifier: string }>(
await request.post(`/api/companies/${seed.companyId}/issues`, {
data: { title: "Rejected channel selection", status: "backlog" },
}),
"create rejected-send task",
);
const endpointId = "aaaaaaaa-aaaa-4aaa-8aaa-aaaaaaaaaaaa";
const conversationId = "bbbbbbbb-bbbb-4bbb-8bbb-bbbbbbbbbbbb";
await page.route("**/api/instance/settings/experimental", (route) =>
fulfill(route, { enableChatConnectors: false, enableGitHubReviewBots: true }),
);
await page.route(`**/api/issues/${issue.id}/chat-binding`, (route) =>
fulfill(route, {
endpointId,
conversationId,
provider: "github",
externalLabel: "test/rejected-send",
assignedAgentLocked: true,
}),
);
const sends: Record<string, unknown>[] = [];
let attachmentId = "";
let privateComment: { id: string } | undefined;
// The lost send resends on its own; hold that resend until the waiting
// state has been checked.
let releaseResend!: () => void;
const resendReleased = new Promise<void>((resolve) => {
releaseResend = resolve;
});
await page.route(
`**/api/chat-endpoints/${endpointId}/conversations/${conversationId}/publications`,
async (route) => {
const input = bodyOf(route);
sends.push(input);
if (sends.length === 1) {
expect(input.attachmentIds).toEqual([attachmentId]);
// Consume the file only after the browser has captured its send.
// Binding it before Send lets live refresh remove it from the draft,
// making the mocked rejection inconsistent with the actual request.
privateComment = await json<{ id: string }>(
await request.post(`/api/issues/${issue.id}/comments`, {
data: { body: "Private Board file", attachmentIds: [attachmentId] },
}),
"bind selected file to private comment",
);
return route.abort("connectionreset");
}
if (sends.length === 2) {
await resendReleased;
return fulfill(
route,
{
error: "A selected file already belongs to another comment",
details: {
code: "chat_board_send_attachments_already_bound",
endpointId,
conversationId,
idempotencyKey: input.idempotencyKey,
attachmentIds: [attachmentId],
},
},
409,
);
}
return fulfill(
route,
{
id: "cccccccc-cccc-4ccc-8ccc-cccccccccccc",
state: "published",
attempts: 1,
},
201,
);
},
);
await page.goto(`/${seed.prefix}/issues/${issue.identifier}`);
const banner = page.getByRole("region", { name: "External conversation" });
await banner
.getByRole("button", { name: "Send to channel", exact: true })
.click();
await banner
.getByLabel("Attach file to channel update", { exact: true })
.setInputFiles({
name: "rejected-send.txt",
mimeType: "text/plain",
buffer: Buffer.from("Synthetic rejected send proof.\n"),
});
await expect(
banner.getByRole("checkbox", { name: "rejected-send.txt" }),
).toBeChecked();
const [file] = await json<{ id: string }[]>(
await request.get(`/api/issues/${issue.id}/attachments`),
"read selected file",
);
attachmentId = file!.id;
// The first intercepted send binds the file to a concurrent Board comment.
// The real TX/idempotency and delete/retry behavior are covered in PostgreSQL.
const draft =
"Share the verified result, without the private Board comment.";
await banner.getByRole("textbox", { name: "Board update" }).fill(draft);
await banner
.getByRole("button", { name: "Send to channel", exact: true })
.last()
.click();
// A lost response waits and resends on its own with the same identity.
await expect(
banner.getByText("Sending when reconnected…", { exact: true }),
).toBeVisible();
await expect(
banner.getByRole("textbox", { name: "Board update" }),
).toBeDisabled();
await expect.poll(() => sends.length).toBe(2);
releaseResend();
await expect(
banner.getByText("Update was not sent", { exact: true }),
).toBeVisible();
expect(sends[1]).toEqual(sends[0]);
await page.reload();
await expect(
banner.getByText("Update was not sent", { exact: true }),
).toBeVisible();
await expect(
banner.getByRole("textbox", { name: "Board update" }),
).toHaveValue(draft);
expect(sends).toHaveLength(2);
await banner.screenshot({
path: testInfo.outputPath("durable-rejected-channel-send.png"),
});
await banner
.getByRole("button", { name: "Edit rejected send", exact: true })
.click();
await expect(
banner.getByRole("textbox", { name: "Board update" }),
).toBeEnabled();
await expect(
banner.getByText(/Attach a new copy or share the task link/),
).toBeVisible();
await expect(banner.getByRole("checkbox")).toHaveCount(0);
await banner
.getByRole("button", { name: "Send to channel", exact: true })
.last()
.click();
await expect(
banner.getByRole("textbox", { name: "Board update" }),
).toHaveCount(0);
expect(sends).toHaveLength(3);
expect(sends[2]!.body).toBe(draft);
expect(sends[2]!.attachmentIds ?? []).toEqual([]);
expect(sends[2]!.idempotencyKey).not.toBe(sends[0]!.idempotencyKey);
const attachments = await json<{ id: string; issueCommentId: string }[]>(
await request.get(`/api/issues/${issue.id}/attachments`),
"verify immutable original binding",
);
expect(attachments).toEqual([
expect.objectContaining({
id: attachmentId,
issueCommentId: privateComment!.id,
}),
]);
});
for (const cancelledHead of [false, true]) {
test(`keeps Teams file consent anchored across reload (${cancelledHead ? "cancelled head with waiting tail" : "mixed terminal receipt and explicit dismiss"})`, async ({
page,
request,
}, testInfo) => {
const seed = await seedCompanyAndAgent(request);
const issue = await json<{ id: string; identifier: string }>(
await request.post(`/api/companies/${seed.companyId}/issues`, {
data: { title: "Teams consent receipt", status: "backlog" },
}),
"create consent receipt task",
);
const endpointId = "aaaaaaaa-aaaa-4aaa-8aaa-aaaaaaaaaaaa";
const conversationId = "bbbbbbbb-bbbb-4bbb-8bbb-bbbbbbbbbbbb";
const anchor = "cccccccc-cccc-4ccc-8ccc-cccccccccccc";
const nextAnchor = "ffffffff-ffff-4fff-8fff-ffffffffffff";
const filePublications = [
"dddddddd-dddd-4ddd-8ddd-dddddddddddd",
"eeeeeeee-eeee-4eee-8eee-eeeeeeeeeeee",
];
const filenames = ["consent-report.txt", "consent-notes.txt"];
const posts: Record<string, unknown>[] = [];
const statusReads: string[] = [];
let terminal = false;
const publicationsPath = `/api/chat-endpoints/${endpointId}/conversations/${conversationId}/publications`;
const session = await json<{ user: { id: string } }>(
await request.get("/api/auth/get-session"),
"read receipt owner",
);
const storageKey = `paperclip:board-send:v2:${JSON.stringify([session.user.id, seed.companyId, issue.id, endpointId, conversationId])}`;
await page.route("**/api/instance/settings/experimental", (route) =>
fulfill(route, { enableChatConnectors: true }),
);
await page.route(`**/api/issues/${issue.id}/chat-binding`, (route) =>
fulfill(route, {
endpointId,
conversationId,
provider: "microsoft-teams",
externalLabel: "Personal file conversation",
assignedAgentLocked: true,
}),
);
// Only the publication API is simulated. Task creation and safe file
// uploads use this test's isolated Paperclip instance, never Teams.
await page.route(`**${publicationsPath}`, (route) => {
expect(route.request().method()).toBe("POST");
posts.push(bodyOf(route));
return fulfill(
route,
{
id: posts.length === 1 ? anchor : nextAnchor,
state: "pending",
attempts: 0,
},
201,
);
});
await page.route(`**${publicationsPath}/*/status`, (route) => {
expect(route.request().method()).toBe("GET");
const path = new URL(route.request().url()).pathname;
statusReads.push(path);
if (path.endsWith(`/${nextAnchor}/status`)) {
return fulfill(route, {
publication: { id: nextAnchor, state: "pending", attempts: 0 },
total: 1,
published: 0,
awaitingConsent: 0,
declined: 0,
expired: 0,
cancelled: 0,
settled: 0,
canDismiss: false,
});
}
expect(path).toBe(`${publicationsPath}/${anchor}/status`);
const parts = [
{ id: anchor, state: "published", attempts: 1 },
...filePublications.map((id, index) => ({
id,
state:
terminal || (cancelledHead && index === 0)
? "cancelled"
: "awaiting_consent",
attempts: 1,
fileTransfer: {
provider: "microsoft-teams",
filename: filenames[index],
phase: terminal
? index === 0
? "declined"
: "expired"
: cancelledHead && index === 0
? "cancelled"
: "awaiting_consent",
version: terminal ? 3 : 2,
},
})),
];
return fulfill(route, {
publication: parts[1],
parts,
total: 3,
published: 1,
awaitingConsent: terminal ? 0 : cancelledHead ? 1 : 2,
declined: terminal ? 1 : 0,
expired: terminal ? 1 : 0,
cancelled: !terminal && cancelledHead ? 1 : 0,
settled: terminal ? 3 : cancelledHead ? 2 : 1,
canDismiss: terminal,
});
});
await page.goto(`/${seed.prefix}/issues/${issue.identifier}`);
const banner = page.getByRole("region", {
name: "External conversation",
exact: true,
});
await banner
.getByRole("button", { name: "Send to channel", exact: true })
.click();
for (const name of filenames) {
await banner
.getByLabel("Attach file to channel update", { exact: true })
.setInputFiles({
name,
mimeType: "text/plain",
buffer: Buffer.from(`Synthetic consent fixture: ${name}.\n`),
});
await expect(
banner.getByRole("checkbox", { name, exact: true }),
).toBeChecked();
await expect(
banner.getByLabel("Attach file to channel update", { exact: true }),
).toBeEnabled();
}
await expect(
banner.getByRole("group", { name: "Include task files", exact: true }),
).toContainText(
"In personal Teams chats, recipients accept each file before upload. Channels and group chats receive supported images directly; other files stay on the task, with a task link or private-task notice.",
);
await banner.screenshot({
path: testInfo.outputPath("teams-file-guidance.png"),
});
expect(posts).toHaveLength(0);
await banner
.getByRole("textbox", { name: "Board update", exact: true })
.fill("Please review these two files.");
await banner
.getByRole("button", { name: "Send to channel", exact: true })
.last()
.click();
await expect.poll(() => posts.length).toBe(1);
expect(posts[0].attachmentIds).toHaveLength(2);
await expect(
banner.getByText(
cancelledHead
? "1 published · 1 awaiting consent · 1 cancelled"
: "1 published · 2 awaiting consent",
{ exact: true },
),
).toBeVisible();
const retainedBeforeReload = await page.evaluate(
(key) => sessionStorage.getItem(key),
storageKey,
);
expect(JSON.parse(retainedBeforeReload!).publication.id).toBe(anchor);
const readsBeforeReload = statusReads.length;
await page.reload();
await expect
.poll(() => statusReads.length)
.toBeGreaterThan(readsBeforeReload);
expect(
await page.evaluate((key) => sessionStorage.getItem(key), storageKey),
).toBe(retainedBeforeReload);
expect(
statusReads.every(
(path) => path === `${publicationsPath}/${anchor}/status`,
),
).toBe(true);
await expect(
banner.getByRole("textbox", { name: "Board update", exact: true }),
).toBeDisabled();
await expect(
banner.getByLabel("Attach file to channel update", { exact: true }),
).toBeDisabled();
await expect(
banner
.getByRole("button", { name: "Send to channel", exact: true })
.last(),
).toBeDisabled();
await expect(
banner.getByRole("button", {
name: "Dismiss delivery receipt",
exact: true,
}),
).toHaveCount(0);
await expect(
banner.getByText(
cancelledHead
? "Waiting for remaining file consent"
: "Waiting for file consent",
{ exact: true },
),
).toBeVisible();
await expect(
banner.getByText("Channel delivery cancelled", { exact: true }),
).toHaveCount(0);
await expect(
banner.getByText("Sent to channel", { exact: true }),
).toHaveCount(0);
for (const name of filenames) {
await expect(
banner.getByRole("checkbox", { name, exact: true }),
).toBeChecked();
await expect(
banner.getByRole("checkbox", { name, exact: true }),
).toBeDisabled();
}
expect(posts).toHaveLength(1);
await banner.screenshot({
path: testInfo.outputPath("consent-waiting.png"),
});
if (cancelledHead) return;
terminal = true;
await expect(
banner.getByText("Delivery settled with mixed outcomes", {
exact: true,
}),
).toBeVisible({ timeout: 8_000 });
await expect(
banner.getByText("1 published · 1 declined · 1 expired", {
exact: true,
}),
).toBeVisible();
await expect(
banner.getByText("consent-report.txt — Declined", { exact: true }),
).toBeVisible();
await expect(
banner.getByText("consent-notes.txt — Consent expired", {
exact: true,
}),
).toBeVisible();
await expect(
banner
.getByRole("button", { name: "Send to channel", exact: true })
.last(),
).toBeDisabled();
await banner.screenshot({
path: testInfo.outputPath("consent-mixed.png"),
});
expect(posts).toHaveLength(1);
await banner
.getByRole("button", { name: "Dismiss delivery receipt", exact: true })
.click();
await expect(
banner.getByRole("textbox", { name: "Board update", exact: true }),
).toHaveValue("");
await expect(
banner.getByRole("textbox", { name: "Board update", exact: true }),
).toBeEnabled();
await expect(
banner
.getByRole("button", { name: "Send to channel", exact: true })
.last(),
).toBeDisabled();
expect(
await page.evaluate((key) => sessionStorage.getItem(key), storageKey),
).toBeNull();
expect(posts).toHaveLength(1);
await expect(
page.getByText("Sent to channel", { exact: true }),
).toHaveCount(0);
for (const name of filenames) {
await expect(
banner.getByRole("checkbox", { name, exact: true }),
).not.toBeChecked();
}
await banner
.getByRole("textbox", { name: "Board update", exact: true })
.fill("A separate text-only update.");
expect(posts).toHaveLength(1);
await banner
.getByRole("button", { name: "Send to channel", exact: true })
.last()
.click();
await expect.poll(() => posts.length).toBe(2);
expect(posts[1]).toMatchObject({
body: "A separate text-only update.",
});
expect(posts[1]).not.toHaveProperty("attachmentIds");
expect(posts[1].idempotencyKey).not.toBe(posts[0].idempotencyKey);
});
}
for (const outcome of [
"published",
"failed",
"delivery_unknown",
"response_lost",
] as const) {
test(`tracks the whole file batch across reload and ${outcome} without a new send identity`, async ({
page,
request,
}) => {
const seed = await seedCompanyAndAgent(request);
const issue = await json<{ id: string; identifier: string }>(
await request.post(`/api/companies/${seed.companyId}/issues`, {
data: { title: "Board delivery refresh", status: "backlog" },
}),
"create board-send task",
);
const endpointId = "aaaaaaaa-aaaa-4aaa-8aaa-aaaaaaaaaaaa";
const conversationId = "bbbbbbbb-bbbb-4bbb-8bbb-bbbbbbbbbbbb";
const publicationId = "cccccccc-cccc-4ccc-8ccc-cccccccccccc";
const attachmentId = "dddddddd-dddd-4ddd-8ddd-dddddddddddd";
const statusPath = `/api/chat-endpoints/${endpointId}/conversations/${conversationId}/publications/${publicationId}/status`;
let sends = 0;
const submittedPayloads: Record<string, unknown>[] = [];
let reads = 0;
let canonicalAttachmentReadsAfterSend = 0;
let canonicalCommentReadsAfterSend = 0;
let status = "streaming";
let releaseResend!: () => void;
const resendReleased = new Promise<void>((resolve) => {
releaseResend = resolve;
});
await page.route("**/api/instance/settings/experimental", (route) =>
fulfill(route, { enableChatConnectors: true }),
);
await page.route(`**/api/issues/${issue.id}/chat-binding`, (route) =>
fulfill(route, {
endpointId,
conversationId,
provider: "slack",
externalLabel: "#board-send-test",
assignedAgentLocked: true,
}),
);
// The comment and attachment reads below are faked. The chat bootstrap
// would answer them from the server, so make the page read them itself.
await page.route(/\/chat-bootstrap(?:\?|$)/, (route) => route.abort());
await page.route(
new RegExp(
`/api/issues/(${issue.id}|${issue.identifier})/(?:recent-comments|comments)(?:\\?|$)`,
),
async (route) => {
if (
sends &&
route.request().url().includes(`/issues/${issue.identifier}/`)
)
canonicalCommentReadsAfterSend += 1;
const comments = sends
? [
{
id: publicationId,
companyId: seed.companyId,
issueId: issue.id,
authorAgentId: null,
authorUserId: "local-board",
authorType: "user",
body: "Board batch must finish all files.",
createdAt: new Date().toISOString(),
updatedAt: new Date().toISOString(),
},
]
: [];
await fulfill(route, route.request().url().includes("/recent-comments")
? { comments, latestCommentId: comments.at(-1)?.id ?? null, hasMore: false }
: comments);
},
);
await page.route(
new RegExp(
`/api/issues/(${issue.id}|${issue.identifier})/attachments$`,
),
async (route) => {
if (
sends &&
route.request().url().includes(`/issues/${issue.identifier}/`)
)
canonicalAttachmentReadsAfterSend += 1;
await fulfill(route, [
{
id: attachmentId,
companyId: seed.companyId,
issueId: issue.id,
issueCommentId: sends ? publicationId : null,
assetId: attachmentId,
provider: "local_disk",
objectKey: "board-send-test.txt",
contentType: "text/plain",
byteSize: 12,
sha256: "a".repeat(64),
originalFilename: "board-send-test.txt",
createdByAgentId: null,
createdByUserId: "local-board",
createdAt: new Date().toISOString(),
updatedAt: new Date().toISOString(),
contentPath: `/api/attachments/${attachmentId}/content`,
},
{
id: "eeeeeeee-eeee-4eee-8eee-eeeeeeeeeeee",
companyId: seed.companyId,
issueId: issue.id,
issueCommentId: null,
assetId: "eeeeeeee-eeee-4eee-8eee-eeeeeeeeeeee",
provider: "local_disk",
objectKey: "internal-only.txt",
contentType: "text/plain",
byteSize: 8,
sha256: "b".repeat(64),
originalFilename: "internal-only.txt",
createdByAgentId: null,
createdByUserId: "local-board",
createdAt: new Date().toISOString(),
updatedAt: new Date().toISOString(),
contentPath:
"/api/attachments/eeeeeeee-eeee-4eee-8eee-eeeeeeeeeeee/content",
},
]);
},
);
await page.route(
`**/api/chat-endpoints/${endpointId}/conversations/${conversationId}/publications`,
async (route) => {
expect(route.request().method()).toBe("POST");
expect(bodyOf(route).attachmentIds).toEqual([attachmentId]);
sends += 1;
submittedPayloads.push(bodyOf(route));
if (outcome === "response_lost" && sends === 1) {
await route.abort("failed");
return;
}
if (outcome === "response_lost" && sends === 2) {
// The automatic resend is still in flight when the page reloads;
// the browser drops it.
await resendReleased;
await route.abort("failed").catch(() => {});
return;
}
await fulfill(
route,
{ id: publicationId, state: "streaming", attempts: 1 },
201,
);
},
);
await page.route(`**${statusPath}`, async (route) => {
expect(route.request().method()).toBe("GET");
reads += 1;
await fulfill(route, {
publication: {
id: status === "streaming" ? publicationId : attachmentId,
state: status,
attempts: 1,
},
total: 2,
published: status === "published" ? 2 : 1,
});
});
await page.goto(`/${seed.prefix}/issues/${issue.identifier}`);
await page
.getByRole("button", { name: "Send to channel", exact: true })
.click();
await page
.getByRole("textbox", { name: "Board update", exact: true })
.fill("Board batch must finish all files.");
await page.getByRole("checkbox", { name: "board-send-test.txt" }).check();
await page
.getByRole("button", { name: "Send to channel", exact: true })
.last()
.click();
const expectRetainedFiles = async () => {
const files = page.getByRole("group", {
name: "Files in this send",
exact: true,
});
await expect(files).toBeVisible();
await expect(files.getByRole("checkbox")).toHaveCount(1);
await expect(
files.getByRole("checkbox", { name: "board-send-test.txt" }),
).toBeChecked();
await expect(
files.getByRole("checkbox", { name: "board-send-test.txt" }),
).toBeDisabled();
await expect(
files.getByText("internal-only.txt", { exact: true }),
).toHaveCount(0);
};
if (outcome === "response_lost") {
// The lost send resends on its own with the same identity.
await expect(
page.getByText("Sending when reconnected…", { exact: true }),
).toBeVisible();
await expect.poll(() => submittedPayloads.length).toBe(2);
expect(submittedPayloads[1]).toEqual(submittedPayloads[0]);
// A send restored after reload has an unknown outcome and waits for
// an explicit, same-identity retry.
await page.reload();
releaseResend();
await expect(
page.getByText("Delivery result not confirmed", { exact: true }),
).toBeVisible();
await expect(
page.getByRole("textbox", { name: "Board update", exact: true }),
).toBeDisabled();
await expectRetainedFiles();
expect(sends).toBe(2);
expect(reads).toBe(0);
await page
.getByRole("button", { name: "Retry safely", exact: true })
.click();
await expect.poll(() => submittedPayloads.length).toBe(3);
expect(submittedPayloads[2]).toEqual(submittedPayloads[0]);
} else {
await expect(
page.getByText("Publishing to channel", { exact: true }).first(),
).toBeVisible();
// The canonical task view must refresh its comment/files before any reload.
await expect
.poll(() => canonicalCommentReadsAfterSend)
.toBeGreaterThan(0);
await expect
.poll(() => canonicalAttachmentReadsAfterSend)
.toBeGreaterThan(0);
await expectRetainedFiles();
const readsBeforeReload = reads;
await page.reload();
await expect
.poll(() => reads, { timeout: 8_000 })
.toBeGreaterThan(readsBeforeReload);
expect(sends).toBe(1);
}
await expect.poll(() => reads, { timeout: 8_000 }).toBeGreaterThan(0);
await expectRetainedFiles();
await expect(
page.getByRole("textbox", { name: "Board update", exact: true }),
).toHaveValue("Board batch must finish all files.");
await expect(
page.getByRole("textbox", { name: "Board update", exact: true }),
).toBeDisabled();
status = outcome === "response_lost" ? "published" : outcome;
if (status === "published") {
await expect(
page.getByRole("textbox", { name: "Board update", exact: true }),
).toHaveCount(0, { timeout: 8_000 });
await expect(
page.getByText("Sent to channel", { exact: true }),
).toBeVisible();
} else {
await expect(
page.getByText(
outcome === "failed"
? "Channel delivery failed"
: "Delivery not confirmed",
{ exact: true },
),
).toBeVisible({ timeout: 8_000 });
await expect(
page.getByRole("textbox", { name: "Board update", exact: true }),
).toHaveValue("Board batch must finish all files.");
await expect(
page
.getByRole("button", { name: "Send to channel", exact: true })
.last(),
).toBeDisabled();
await expect(
page.getByRole("link", { name: "Open Activity", exact: true }),
).toBeVisible();
// An explicit resolution elsewhere may complete the batch; this surface only reads it.
status = "published";
await expect(
page.getByRole("textbox", { name: "Board update", exact: true }),
).toHaveCount(0, { timeout: 8_000 });
}
// response_lost: the lost send, its automatic resend, and the explicit
// retry after reload, all with one identity.
const expectedSends = outcome === "response_lost" ? 3 : 1;
expect(sends).toBe(expectedSends);
expect(canonicalCommentReadsAfterSend).toBeGreaterThan(0);
expect(canonicalAttachmentReadsAfterSend).toBeGreaterThan(0);
await expect(
page.getByText("Board batch must finish all files.", { exact: true }),
).toBeVisible();
await page
.getByRole("button", { name: "Send to channel", exact: true })
.click();
const newFiles = page.getByRole("group", {
name: "Include task files",
exact: true,
});
await expect(
newFiles.getByRole("checkbox", { name: "board-send-test.txt" }),
).toHaveCount(0);
await expect(
newFiles.getByRole("checkbox", { name: "internal-only.txt" }),
).not.toBeChecked();
await expect(
newFiles.getByRole("checkbox", { name: "internal-only.txt" }),
).toBeEnabled();
expect(sends).toBe(expectedSends);
});
}
});
test.describe("Failed chat task and exact run retry", () => {
let seed: Seed;
let issue: { id: string; identifier: string; title: string };
const failedRunId = "11111111-aaaa-4aaa-8aaa-111111111111";
const actionId = "22222222-bbbb-4bbb-8bbb-222222222222";
const denial =
"This chat source is no longer authorized. Open the task to review its current channel access before retrying.";
test.beforeAll(async ({ request }) => {
seed = await seedCompanyAndAgent(request);
issue = await json<typeof issue>(
await request.post(`/api/companies/${seed.companyId}/issues`, {
data: { title: "Exact chat retry destination", status: "backlog" },
}),
"create exact-retry task",
);
});
for (const surface of ["agent run", "Inbox", "Coordinator Tasks", "Legacy Inbox"] as const) {
for (const outcome of ["queued", "deferred", "denied"] as const) {
test(`${surface}: selected run ${outcome} preserves exact retry authority and truthful feedback`, async ({
page,
}, testInfo) => {
const usesTaskRetry = surface === "Inbox" || surface === "Coordinator Tasks";
const now = Date.now();
const run = {
id: failedRunId,
companyId: seed.companyId,
agentId: seed.agentId,
status: "failed",
invocationSource: "assignment",
triggerDetail: "system",
startedAt: new Date(now - 60_000).toISOString(),
finishedAt: new Date(now - 30_000).toISOString(),
createdAt: new Date(now - 60_000).toISOString(),
updatedAt: new Date(now - 30_000).toISOString(),
error: "The fixture provider turn failed.",
errorCode: "adapter_failed",
exitCode: 1,
signal: null,
responsibleUserId: null,
runtimeMode: "native",
driverKind: "codex_app_server",
nativeIssueId: issue.id,
usageJson: null,
resultJson: null,
sessionIdBefore: null,
sessionIdAfter: null,
logStore: null,
logRef: null,
logBytes: 0,
retryOfRunId: null,
scheduledRetryAt: null,
scheduledRetryAttempt: 0,
scheduledRetryReason: null,
contextSnapshot: {
source: "chat:slack",
issueId: issue.id,
taskId: "33333333-cccc-4ccc-8ccc-333333333333",
taskKey: "untrusted-copy-of-another-task",
wakeCommentId: "44444444-dddd-4ddd-8ddd-444444444444",
wakeCommentIds: ["44444444-dddd-4ddd-8ddd-444444444444"],
chatFailedRunRetry: { actionId: "untrusted-client-action" },
},
};
const requests: Array<{
companyId: string | null;
body: Record<string, unknown>;
}> = [];
const destinations: string[] = [];
page.on("framenavigated", (frame) => {
if (frame === page.mainFrame()) destinations.push(frame.url());
});
await page.route("**/api/**", async (route) => {
const url = new URL(route.request().url());
const pathname = url.pathname;
if (pathname === "/api/workspace-preferences/me") {
await fulfill(route, {
userId: "local-board",
coordinatorWorkspaceEnabled: surface === "Coordinator Tasks",
updatedAt: null,
});
return;
}
if (pathname === "/api/instance/settings/experimental") {
await fulfill(route, {
enableChatConnectors: true,
enableStreamlinedUi: surface !== "Legacy Inbox",
});
return;
}
if (pathname === `/api/companies/${seed.companyId}/heartbeat-runs`) {
await fulfill(route, [run]);
return;
}
if (pathname === `/api/heartbeat-runs/${failedRunId}`) {
await fulfill(route, run);
return;
}
if (
pathname === `/api/heartbeat-runs/${failedRunId}/events` ||
pathname ===
`/api/heartbeat-runs/${failedRunId}/workspace-operations` ||
pathname === `/api/companies/${seed.companyId}/provider-traces`
) {
await fulfill(route, []);
return;
}
if (pathname === `/api/heartbeat-runs/${failedRunId}/issues`) {
await fulfill(route, [
{
issueId: issue.id,
identifier: issue.identifier,
title: issue.title,
status: "backlog",
priority: "medium",
},
]);
return;
}
if (pathname === `/api/heartbeat-runs/${failedRunId}/log`) {
await fulfill(route, {
runId: failedRunId,
content: "",
nextOffset: 0,
});
return;
}
const retryPath = usesTaskRetry
? `/api/issues/${issue.id}/retry`
: `/api/agents/${seed.agentId}/wakeup`;
if (pathname === retryPath) {
expect(route.request().method()).toBe("POST");
requests.push({
companyId: url.searchParams.get("companyId"),
body: bodyOf(route),
});
if (outcome === "denied") {
await fulfill(
route,
{
error: denial,
details: { code: "chat_failed_run_retry_source_denied" },
},
409,
);
} else {
// The durable action exists, but no run has been admitted yet.
await fulfill(
route,
usesTaskRetry
? {
requestId: actionId,
accepted: true,
stale: false,
observedRunId: failedRunId,
presentation: {
intentId: actionId,
responsibility: "system",
state: outcome === "queued" ? "working" : "retry_scheduled",
nextRetryAt: null,
canRetry: false,
userAction: null,
sourceRunIds: [failedRunId],
observedRunId: failedRunId,
},
}
: { actionId, issueId: issue.id, runId: null, status: outcome },
202,
);
}
return;
}
await route.continue();
});
const startPath =
surface === "agent run"
? `/${seed.prefix}/agents/maya/runs/${failedRunId}`
: `/${seed.prefix}/inbox/all`;
const canonicalAgentResponse =
surface === "agent run"
? page.waitForResponse((response) => {
const url = new URL(response.url());
return (
response.request().method() === "GET" &&
url.pathname === "/api/agents/maya" &&
url.searchParams.get("companyId") === seed.companyId
);
})
: null;
await page.goto(startPath);
if (canonicalAgentResponse) {
const response = await canonicalAgentResponse;
expect(response.ok()).toBe(true);
expect(await response.json()).toMatchObject({
id: seed.agentId,
companyId: seed.companyId,
urlKey: "maya",
});
await expect(page).toHaveURL(
new RegExp(`/${seed.prefix}/agents/maya/runs/${failedRunId}$`),
);
}
const retry = page
.getByRole("button", { name: "Retry", exact: true })
.filter({ visible: true });
await expect(retry).toHaveCount(1);
await retry.click();
await expect.poll(() => requests.length).toBe(1);
expect(requests[0]).toEqual(usesTaskRetry
? {
companyId: null,
body: {
idempotencyKey: expect.stringMatching(
/^[0-9a-f]{8}-[0-9a-f]{4}-4[0-9a-f]{3}-[89ab][0-9a-f]{3}-[0-9a-f]{12}$/i,
),
observedRunId: failedRunId,
},
}
: {
companyId: seed.companyId,
body: {
source: "on_demand",
triggerDetail: "manual",
reason: "retry_failed_run",
failedRunId,
},
});
if (outcome === "denied") {
await expect(page.getByText(denial, { exact: true })).toBeVisible();
if (surface !== "agent run") {
await expect(
page.getByText("Run retry failed", { exact: true }),
).toBeVisible();
const toast = page.getByRole("listitem").filter({
has: page.getByText("Run retry failed", { exact: true }),
});
// Visibility alone accepts opacity:0 during the toast entrance.
// The operator must actually be able to read the denial.
await expect(toast).toHaveCSS("opacity", "1");
await expect(toast).toBeInViewport();
}
// Agent routes canonicalize the UUID to its human-readable URL key.
// The selected failed run must remain unchanged across that redirect.
await expect(page).toHaveURL(
surface === "agent run"
? new RegExp(
`/${seed.prefix}/agents/(${seed.agentId}|maya)/runs/${failedRunId}$`,
)
: surface === "Coordinator Tasks"
? new RegExp(`/${seed.prefix}/issues\\?view=everything$`)
: new RegExp(`${startPath}$`),
);
await expect(retry).toBeEnabled();
await testInfo.attach(`${surface}-retry-denied`, {
body: await page.screenshot(),
contentType: "image/png",
});
} else {
await expect(page).toHaveURL(
new RegExp(
`/${seed.prefix}/issues/(${issue.id}|${issue.identifier})$`,
),
);
await expect(
page.getByText(issue.title, { exact: true }).first(),
).toBeVisible();
await expect(
page.getByText("Run retry failed", { exact: true }),
).toHaveCount(0);
}
expect(requests).toHaveLength(1);
expect(
destinations.some((url) =>
/\/runs\/(null|undefined)(?:[/?#]|$)/.test(url),
),
).toBe(false);
});
}
}
});