mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-15 12:28:10 +02:00
## Thinking Path
> - Paperclip is the open source app people use to manage AI agents for
work.
> - Agents use governed API tools to inspect task evidence.
> - Large API results become saved assets with short previews.
> - Reading an asset through the same tool used to create another asset,
so the agent could not reach the rest of the evidence.
> - The 10 MiB response cap also blocked useful large results. Removing
all bounds allowed excessive disk use.
> - This pull request streams responses up to 1 GiB and makes saved text
readable in bounded pages. It adds durable run budgets and capture
admission limits.
> - Agents can inspect complete evidence while tool results, memory use,
and capture work stay bounded.
## Linked Issues or Issue Description
**What happened?**
A large response became an asset. Reading that asset returned another
asset and the same preview. Responses above 10 MiB failed before the
agent could read any page.
**Expected behavior**
The agent can fetch a large response and read its saved text to EOF.
Each page stays bounded. New snapshots have a generous finite limit and
a durable run budget. Existing larger assets remain readable through
byte ranges.
**Steps to reproduce**
1. Call a GET operation that returns more than 10 MiB of text or JSON.
2. Before the fix, the tool returns `api_transport_failure`.
3. With this change, responses up to 1 GiB become streamed snapshots
with artifact references.
4. Read `GET /api/assets/{assetId}/content` with `responseText:
{offsetBytes: 0, limitBytes: 8192}`. Follow `nextOffsetBytes` until
null.
Related work: #14186 added the API fallback tools. #14218 bounded API
discovery.
## What Changed
- Add authenticated UTF-8 text windows to `call_api`, with byte offsets
and total size. Keep each page at or below 24 KiB.
- Stream new responses above 24 KiB through private temporary files into
company-owned assets. Bound each capture to 1 GiB of decoded bytes.
Reject oversized declared lengths before reading and count streamed
bytes before writing.
- Reserve capture budget in the run record before spilling. Allow 4 GiB
per run. Settle successful captures to their actual size. Failed or
interrupted captures retain their full 1 GiB reservation. Run restarts
do not reset the budget.
- Enforce a 20 GiB company snapshot quota with database reservations.
Count legacy snapshots and unfinished storage work across runs and
processes. Asset deletion frees quota.
- Limit large captures to two per company and four per server process.
Hold slots through storage upload and temporary-file cleanup. Use a
10-minute download deadline and 30-second connection/idle-read timeouts.
- Return explicit size, budget, busy, and timeout errors. Preserve
unknown outcomes for mutations whose response cannot be captured.
- Read saved assets through authenticated storage ranges, with at most
two extra bytes for UTF-8 and EOF handling. Unpaged reads return the
existing asset and digest with a bounded preview. Reads create no copies
and do not consume capture budget.
- Keep existing assets above 1 GiB readable in pages. Use safe integer
offsets and PostgreSQL `bigint` asset sizes.
- Stream large S3 uploads through ordered multipart requests. Abort
failed uploads and remove partial local files.
- Revalidate run authority during downloads. Keep company authorization,
GET-only text paging, redirect denial, and mutation replay receipts.
- Document the separate 10 MiB upload limits. This PR does not raise
memory-buffered attachment ingestion limits. Future large video uploads
need streamed ingestion and storage quotas.
## Verification
- Full workspace `pnpm -r typecheck` and `pnpm build` pass after
rebasing on master.
- Focused API and response tests: 1,761 pass. Cover declared and chunked
oversize responses, incorrect Content-Length, exact-limit success,
active-stream deadline, cancellation, cleanup, concurrency admission,
and mutation outcome handling.
- Real HTTP integration: 28 tests pass, including runnerd → PRP →
authority → HTTP, a 12 MiB snapshot, final-page/EOF reads, cross-company
denial, a persisted 3 GiB sparse asset, and large mutation receipt
replay.
- The HTTP suite verifies durable run-budget accounting, simultaneous
runs competing for company quota, legacy snapshot accounting, deletion
refunds, failed-storage reservations, cleaned-failure refunds,
metadata-rollback cleanup refunds, preservation after a lost commit
acknowledgement, and small/saved reads after capture-budget exhaustion.
- A standalone proof streams exactly 1 GiB through the production
capture helper, verifies the final bytes, and removes its temporary
file. It uses repeated 256 KiB chunks and records a peak process RSS of
191 MiB.
- Earlier storage verification covers exact S3 multipart boundaries,
cleanup/abort failures, and a 17 MiB transfer through the real AWS SDK
to a local HTTP S3 endpoint. No cloud S3 qualification was run for this
follow-up.
- The local full test run was interrupted for the company-quota changes.
A later targeted run hit exhausted macOS shared-memory slots before
tests started; two unattached PostgreSQL segments with dead owners were
reclaimed before retrying. All 55 current-head checks pass at
`aebb80ceeeee77d5a56b67bfffd835f2f846878c`, including the full CI test
suite, typecheck, build, browser suites, security scan, and Greptile
(5/5). There are no unresolved review threads. The combined rebased test
catalog also passes (48 tests).
- Earlier paging acceptance passed Daytona and separate staging at
`7739879e9`. Those runs predate the streaming and budget changes.
## Risks
- The 1 GiB response cap and 10-minute active-download deadline are
intentional product limits. Larger live results must use endpoint
pagination or a direct file workflow. Existing larger assets remain
readable through bounded ranges.
- A durable 20 GiB company snapshot quota counts stored runner-api
assets and active/orphan reservations across runs and processes. The
operator can set PAPERCLIP_RUNNER_API_COMPANY_CAPTURE_MAX_BYTES to a
finite value of at least 1 GiB. Deleting snapshots frees capacity;
possible orphan storage must be reconciled before releasing its
reservation.
- A failed capture uses its full reservation. A new large capture needs
a full 1 GiB available, even if it later completes at a smaller size.
Small reads and existing asset pages remain available.
- Concurrency limits apply per server process. The run byte budget is
shared through the database.
- The `integer` to `bigint` migration rewrites asset metadata and takes
an exclusive table lock. File bytes stay in storage.
- A live endpoint is fetched once before returning its snapshot.
Continue reading the saved artifact for stable pages. Mutations may
commit before any size or transport error; inspect state before
retrying.
- Attachment uploads and native file handoffs still default to 10 MiB.
Raising buffered ingestion paths to GiB sizes is separate work.
## Model Used
OpenAI Codex, based on GPT-6, with code execution and repository tools.
The runtime does not expose an exact serving model variant or
context-window size. The earlier paging work also used browser testing
and subagents.
## Checklist
- [x] I have included a thinking path that traces from project context
to this change
- [x] I have specified the model used (with version and capability
details)
- [x] I have checked ROADMAP.md and confirmed this PR does not duplicate
planned core work
- [x] I have searched GitHub for duplicate or related PRs and linked
them above
- [x] I have either (a) linked existing issues with `Fixes: #` / `Closes
#` / `Refs #` OR (b) described the issue in-PR following the relevant
issue template
- [x] I have not referenced internal/instance-local Paperclip issues or
links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip`
URLs)
- [x] My branch name describes the change (e.g. `docs/...`, `fix/...`)
and contains no internal Paperclip ticket id or instance-derived details
- [x] I have run tests locally and they pass
- [x] I have added or updated tests where applicable
- [x] I have updated relevant documentation to reflect my changes
- [x] I have considered and documented any risks above
- [x] All Paperclip CI gates are green
- [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups
- [x] I will address all Greptile and reviewer comments before
requesting merge
---------
Co-authored-by: Paperclip <noreply@paperclip.ing>
143 lines
7.0 KiB
TypeScript
143 lines
7.0 KiB
TypeScript
import { createHash } from "node:crypto";
|
|
import { access, readdir } from "node:fs/promises";
|
|
import { tmpdir } from "node:os";
|
|
import { describe, expect, it, vi } from "vitest";
|
|
import { captureRunnerApiResponse } from "./runner-api-response.js";
|
|
import { acquireRunnerApiResponseSlot, runnerApiCompanyCaptureMaxBytes, RUNNER_API_RESPONSE_MAX_BYTES } from "./runner-api-response-limits.js";
|
|
|
|
const controller = () => new AbortController();
|
|
describe("streamed API response capture", () => {
|
|
it("rejects an oversized Content-Length before reading or reserving disk", async () => {
|
|
let cancelled = false;
|
|
let reserved = false;
|
|
const abort = controller();
|
|
const response = new Response(new ReadableStream({ cancel() { cancelled = true; } }), { headers: { "content-length": String(RUNNER_API_RESPONSE_MAX_BYTES + 1) } });
|
|
await expect(captureRunnerApiResponse(response, 24 * 1024, abort, 1000, undefined, {
|
|
beforeSpill: async () => { reserved = true; },
|
|
})).rejects.toMatchObject({ code: "api_response_too_large" });
|
|
expect(cancelled).toBe(true);
|
|
expect(abort.signal.aborted).toBe(true);
|
|
expect(reserved).toBe(false);
|
|
});
|
|
it.each([undefined, "1"])("counts streamed bytes with Content-Length %s and removes partial files", async contentLength => {
|
|
const before = new Set(await readdir(tmpdir()));
|
|
let cancelled = false;
|
|
let reserved = 0;
|
|
const response = new Response(new ReadableStream({
|
|
pull(target) { target.enqueue(Buffer.alloc(4096)); },
|
|
cancel() { cancelled = true; },
|
|
}), { headers: contentLength ? { "content-length": contentLength } : {} });
|
|
await expect(captureRunnerApiResponse(response, 4096, controller(), 1000, undefined, {
|
|
maxBytes: 16 * 1024,
|
|
beforeSpill: async () => { reserved++; },
|
|
})).rejects.toMatchObject({ code: "api_response_too_large" });
|
|
expect(cancelled).toBe(true);
|
|
expect(reserved).toBe(1);
|
|
expect((await readdir(tmpdir())).filter(name => name.startsWith("paperclip-api-response-") && !before.has(name))).toEqual([]);
|
|
});
|
|
it("accepts exactly the capture limit", async () => {
|
|
const captured = await captureRunnerApiResponse(new Response(Buffer.alloc(8192)), 4096, controller(), 1000, undefined, { maxBytes: 8192 });
|
|
try { expect(captured.byteSize).toBe(8192); }
|
|
finally { await captured.dispose(); }
|
|
});
|
|
it("stops an active endless stream at the total deadline", async () => {
|
|
let cancelled = false;
|
|
const response = new Response(new ReadableStream({
|
|
async pull(target) {
|
|
await new Promise(resolve => setTimeout(resolve, 5));
|
|
if (!cancelled) target.enqueue(Buffer.alloc(4096));
|
|
},
|
|
cancel() { cancelled = true; },
|
|
}));
|
|
await expect(captureRunnerApiResponse(response, 4096, controller(), 1000, undefined, { deadlineMs: 30 })).rejects.toMatchObject({ code: "api_response_timeout" });
|
|
expect(cancelled).toBe(true);
|
|
});
|
|
it("spills a chunked response and reads only requested bytes, preserving its digest", async () => {
|
|
const chunk = Buffer.alloc(64 * 1024, 65);
|
|
const digest = createHash("sha256");
|
|
let emitted = 0;
|
|
const response = new Response(new ReadableStream({
|
|
pull(target) {
|
|
if (emitted++ === 200) return target.close();
|
|
digest.update(chunk);
|
|
target.enqueue(chunk);
|
|
},
|
|
}));
|
|
const captured = await captureRunnerApiResponse(response, 24 * 1024, controller(), 1000);
|
|
expect(Buffer.isBuffer(captured.body)).toBe(false);
|
|
if (Buffer.isBuffer(captured.body)) throw new Error("Expected a file");
|
|
const path = captured.body.path;
|
|
try {
|
|
expect(captured.body).toMatchObject({ byteSize: 200 * chunk.length, sha256: digest.digest("hex") });
|
|
expect(await captured.read(11 * 1024 * 1024, 4)).toEqual(Buffer.from("AAAA"));
|
|
expect(await captured.read(captured.byteSize, 4)).toHaveLength(0);
|
|
} finally { await captured.dispose(); }
|
|
await expect(access(path)).rejects.toThrow();
|
|
});
|
|
it("keeps small bodies inline", async () => {
|
|
const captured = await captureRunnerApiResponse(new Response("small"), 24 * 1024, controller(), 1000);
|
|
try { expect(captured.body).toEqual(Buffer.from("small")); }
|
|
finally { await captured.dispose(); }
|
|
});
|
|
it("stops a long capture when its run loses authority", async () => {
|
|
let checks = 0;
|
|
let cancelled = false;
|
|
const response = new Response(new ReadableStream({
|
|
pull(target) { target.enqueue(Buffer.alloc(64 * 1024)); },
|
|
cancel() { cancelled = true; },
|
|
}));
|
|
await expect(captureRunnerApiResponse(response, 24 * 1024, controller(), 1000, async () => {
|
|
if (++checks === 2) throw new Error("run stopped");
|
|
})).rejects.toThrow("run stopped");
|
|
expect(cancelled).toBe(true);
|
|
expect(checks).toBe(2);
|
|
});
|
|
it("allows active downloads longer than the idle timeout", async () => {
|
|
let chunks = 0;
|
|
const response = new Response(new ReadableStream({
|
|
async pull(target) {
|
|
await new Promise(resolve => setTimeout(resolve, 20));
|
|
if (chunks++ === 5) target.close();
|
|
else target.enqueue(Buffer.from("a"));
|
|
},
|
|
}));
|
|
const captured = await captureRunnerApiResponse(response, 24 * 1024, controller(), 100);
|
|
try { expect(captured.body).toEqual(Buffer.from("aaaaa")); }
|
|
finally { await captured.dispose(); }
|
|
});
|
|
it("cancels stalled bodies and aborts the HTTP request", async () => {
|
|
let cancelled = false;
|
|
const response = new Response(new ReadableStream({ cancel() { cancelled = true; } }));
|
|
const abort = controller();
|
|
await expect(captureRunnerApiResponse(response, 24 * 1024, abort, 10)).rejects.toThrow("timed out");
|
|
expect(cancelled).toBe(true);
|
|
expect(abort.signal.aborted).toBe(true);
|
|
});
|
|
});
|
|
|
|
describe("large response concurrency", () => {
|
|
it("only accepts finite positive operator quotas, never unlimited settings", () => {
|
|
try {
|
|
for (const value of ["0", "-1", "Infinity", "NaN", "1", "9007199254740992"]) {
|
|
vi.stubEnv("PAPERCLIP_RUNNER_API_COMPANY_CAPTURE_MAX_BYTES", value);
|
|
expect(runnerApiCompanyCaptureMaxBytes()).toBe(20 * RUNNER_API_RESPONSE_MAX_BYTES);
|
|
}
|
|
vi.stubEnv("PAPERCLIP_RUNNER_API_COMPANY_CAPTURE_MAX_BYTES", String(2 * RUNNER_API_RESPONSE_MAX_BYTES));
|
|
expect(runnerApiCompanyCaptureMaxBytes()).toBe(2 * RUNNER_API_RESPONSE_MAX_BYTES);
|
|
} finally { vi.unstubAllEnvs(); }
|
|
});
|
|
it("limits each company and the server and releases slots idempotently", () => {
|
|
const releases: Array<() => void> = [];
|
|
try {
|
|
releases.push(acquireRunnerApiResponseSlot("a"), acquireRunnerApiResponseSlot("a"));
|
|
expect(() => acquireRunnerApiResponseSlot("a")).toThrow("busy");
|
|
releases.push(acquireRunnerApiResponseSlot("b"), acquireRunnerApiResponseSlot("b"));
|
|
expect(() => acquireRunnerApiResponseSlot("c")).toThrow("busy");
|
|
releases[0](); releases[0]();
|
|
releases.push(acquireRunnerApiResponseSlot("c"));
|
|
expect(() => acquireRunnerApiResponseSlot("d")).toThrow("busy");
|
|
} finally { for (const release of releases) release(); }
|
|
acquireRunnerApiResponseSlot("a")();
|
|
});
|
|
});
|