mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-11 05:31:46 +02:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work > - Paperclip records agent run outcomes through telemetry and run lifecycle services > - Terminal run transitions need one consistent event for outcome analysis > - The current paths do not report every terminal transition through one event > - This pull request adds the agent.task_run event and emits it at each terminal transition > - The benefit is complete run outcome data without exposing raw task identifiers ## Linked Issues or Issue Description **What existing behavior does this improve?** Paperclip telemetry reports agent activity, but it does not report every terminal task run through one event. **Subsystem affected** Cross-cutting (multiple of the above): packages/shared telemetry and server run lifecycle services. **Current behavior** Several run paths write a terminal status without a matching agent.task_run telemetry event. **Proposed behavior** Each terminal run transition emits one agent.task_run event. The event records the terminal state and uses the existing pseudonym helper for the optional task identifier. **Reason and benefit** Complete terminal-run data helps operators measure agent outcomes. The pseudonym helper prevents the raw task identifier from leaving the installation. **Breaking changes** None. The change adds an event and keeps existing event behavior compatible. ## What Changed - Add the agent.task_run telemetry contract and client helper. - Reuse the existing pseudonym helper for the task identifier. The helper hashes the identifier with a per-installation salt and returns 16 hexadecimal characters. The raw identifier never leaves the installation. Existing identifiers do not move. - Emit one event from each legacy, native, recovery, and issue terminal transition. - Keep emissions outside database transactions and make delivery best-effort. - Add regression tests for event shape, hashing, terminal transitions, and emission failures. - Document the event and its privacy rule in the telemetry data contract. ## Verification - `npx tsc --noEmit` in `server/` passes at the submitted commit. - The pull-request CI suite must pass. CI is the authority because local Vitest has a known dependency artifact. - The added regression tests cover event output shape, per-installation hash divergence, raw identifier handoff, omitted identifiers, and non-throwing emits. ## Risks - A missed terminal path could reduce event coverage. - Telemetry delivery remains best-effort and cannot change run finalization. - The pseudonym helper uses installation-specific state, so identifiers differ between installations. ## Model Used OpenAI Codex, GPT-5, tool use and code execution. Context window details were not provided. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes: #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I have addressed all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
233 lines
7.4 KiB
TypeScript
233 lines
7.4 KiB
TypeScript
import { createHash } from "node:crypto";
|
|
import { describe, expect, it, vi } from "vitest";
|
|
import {
|
|
trackAgentCreated,
|
|
trackAgentFirstHeartbeat,
|
|
trackAgentTaskCompleted,
|
|
trackAgentTaskRun,
|
|
trackInteractionCreated,
|
|
trackInteractionResolved,
|
|
trackInstallCompleted,
|
|
} from "@paperclipai/shared/telemetry";
|
|
import type { EventDimensionsMap, TelemetryClient } from "@paperclipai/shared/telemetry";
|
|
|
|
function createClient(): TelemetryClient {
|
|
return {
|
|
track: vi.fn(),
|
|
hashPrivateRef: vi.fn((value: string) => createHash("sha256").update(value).digest("hex").slice(0, 16)),
|
|
} as unknown as TelemetryClient;
|
|
}
|
|
|
|
function runtimeValue<T>(value: string): T {
|
|
return value as T;
|
|
}
|
|
|
|
describe("shared telemetry agent events", () => {
|
|
it("includes agent_id for agent.created", () => {
|
|
const client = createClient();
|
|
|
|
trackAgentCreated(client, {
|
|
agentRole: "engineer",
|
|
agentId: "11111111-1111-4111-8111-111111111111",
|
|
});
|
|
|
|
expect(client.track).toHaveBeenCalledWith("agent.created", {
|
|
agent_role: "engineer",
|
|
agent_id: "11111111-1111-4111-8111-111111111111",
|
|
});
|
|
});
|
|
|
|
it("passes an unrecognized agent role through for backend normalization", () => {
|
|
const client = createClient();
|
|
|
|
trackAgentCreated(client, {
|
|
agentRole: runtimeValue<EventDimensionsMap["agent.created"]["agent_role"]>("coder"),
|
|
agentId: "44444444-4444-4444-8444-444444444444",
|
|
});
|
|
|
|
expect(client.track).toHaveBeenCalledWith("agent.created", {
|
|
agent_role: "coder",
|
|
agent_id: "44444444-4444-4444-8444-444444444444",
|
|
});
|
|
});
|
|
|
|
it("includes agent_id for agent.first_heartbeat", () => {
|
|
const client = createClient();
|
|
|
|
trackAgentFirstHeartbeat(client, {
|
|
agentRole: "engineer",
|
|
agentId: "22222222-2222-4222-8222-222222222222",
|
|
});
|
|
|
|
expect(client.track).toHaveBeenCalledWith("agent.first_heartbeat", {
|
|
agent_role: "engineer",
|
|
agent_id: "22222222-2222-4222-8222-222222222222",
|
|
});
|
|
});
|
|
|
|
it("includes agent_id for agent.task_completed", () => {
|
|
const client = createClient();
|
|
|
|
trackAgentTaskCompleted(client, {
|
|
agentRole: "qa",
|
|
agentId: "33333333-3333-4333-8333-333333333333",
|
|
adapterType: "codex_local",
|
|
});
|
|
|
|
expect(client.track).toHaveBeenCalledWith("agent.task_completed", {
|
|
agent_role: "qa",
|
|
agent_id: "33333333-3333-4333-8333-333333333333",
|
|
adapter_type: "codex_local",
|
|
});
|
|
});
|
|
|
|
it("hashes the task id for agent.task_completed and never sends the raw value", () => {
|
|
const client = createClient();
|
|
const rawTaskId = "11111111-1111-4111-8111-111111111111";
|
|
|
|
trackAgentTaskCompleted(client, {
|
|
agentRole: "qa",
|
|
agentId: "33333333-3333-4333-8333-333333333333",
|
|
adapterType: "codex_local",
|
|
taskId: rawTaskId,
|
|
});
|
|
|
|
expect(client.hashPrivateRef).toHaveBeenCalledWith(rawTaskId);
|
|
const sentDimensions = vi.mocked(client.track).mock.calls[0]?.[1] as Record<string, unknown>;
|
|
expect(sentDimensions.task_id).toMatch(/^[0-9a-f]{16}$/);
|
|
expect(sentDimensions.task_id).not.toBe(rawTaskId);
|
|
expect(JSON.stringify(sentDimensions)).not.toContain(rawTaskId);
|
|
});
|
|
|
|
it("omits task_id for agent.task_completed when the caller gives no task id", () => {
|
|
const client = createClient();
|
|
|
|
trackAgentTaskCompleted(client, {
|
|
agentRole: "qa",
|
|
agentId: "33333333-3333-4333-8333-333333333333",
|
|
adapterType: "codex_local",
|
|
});
|
|
|
|
expect(client.hashPrivateRef).not.toHaveBeenCalled();
|
|
expect(client.track).toHaveBeenCalledWith("agent.task_completed", {
|
|
agent_role: "qa",
|
|
agent_id: "33333333-3333-4333-8333-333333333333",
|
|
adapter_type: "codex_local",
|
|
});
|
|
});
|
|
|
|
it("sends all ten dimensions for agent.task_run when present", () => {
|
|
const client = createClient();
|
|
const rawTaskId = "22222222-2222-4222-8222-222222222222";
|
|
|
|
trackAgentTaskRun(client, {
|
|
agentId: "44444444-4444-4444-8444-444444444444",
|
|
state: "succeeded",
|
|
adapterType: "claude_local",
|
|
agentRole: "engineer",
|
|
model: "claude-sonnet-5",
|
|
durationSeconds: 12.5,
|
|
inputTokens: 100,
|
|
outputTokens: 200,
|
|
cachedTokens: 50,
|
|
taskId: rawTaskId,
|
|
});
|
|
|
|
expect(client.hashPrivateRef).toHaveBeenCalledWith(rawTaskId);
|
|
const sentDimensions = vi.mocked(client.track).mock.calls[0]?.[1] as Record<string, unknown>;
|
|
expect(sentDimensions).toMatchObject({
|
|
agent_id: "44444444-4444-4444-8444-444444444444",
|
|
state: "succeeded",
|
|
adapter_type: "claude_local",
|
|
agent_role: "engineer",
|
|
model: "claude-sonnet-5",
|
|
duration_seconds: 12.5,
|
|
input_tokens: 100,
|
|
output_tokens: 200,
|
|
cached_tokens: 50,
|
|
});
|
|
expect(sentDimensions.task_id).toMatch(/^[0-9a-f]{16}$/);
|
|
});
|
|
|
|
it("omits every absent optional dimension for agent.task_run", () => {
|
|
const client = createClient();
|
|
|
|
trackAgentTaskRun(client, {
|
|
agentId: "55555555-5555-4555-8555-555555555555",
|
|
state: "failed",
|
|
});
|
|
|
|
expect(client.hashPrivateRef).not.toHaveBeenCalled();
|
|
expect(client.track).toHaveBeenCalledWith("agent.task_run", {
|
|
agent_id: "55555555-5555-4555-8555-555555555555",
|
|
state: "failed",
|
|
});
|
|
});
|
|
|
|
it("keeps non-agent event dimensions unchanged", () => {
|
|
const client = createClient();
|
|
|
|
trackInstallCompleted(client, { adapterType: "codex_local" });
|
|
|
|
expect(client.track).toHaveBeenCalledWith("install.completed", {
|
|
adapter_type: "codex_local",
|
|
});
|
|
expect(client.track).not.toHaveBeenCalledWith(
|
|
"install.completed",
|
|
expect.objectContaining({ agent_id: expect.any(String) }),
|
|
);
|
|
});
|
|
|
|
it("passes interaction.resolved enum dimensions through for backend normalization", () => {
|
|
const client = createClient();
|
|
|
|
trackInteractionResolved(client, {
|
|
interactionKind: runtimeValue<EventDimensionsMap["interaction.resolved"]["interaction_kind"]>(
|
|
"single_confirmation",
|
|
),
|
|
status: "accepted",
|
|
resolvedByKind: runtimeValue<EventDimensionsMap["interaction.resolved"]["resolved_by_kind"]>("operator"),
|
|
resolutionReason: "accepted",
|
|
createdByKind: "agent",
|
|
creatorAgentRole: runtimeValue<EventDimensionsMap["interaction.resolved"]["creator_agent_role"]>("coder"),
|
|
continuationPolicy: runtimeValue<EventDimensionsMap["interaction.resolved"]["continuation_policy"]>(
|
|
"wake_everyone",
|
|
),
|
|
targetType: "issue_document",
|
|
optionCount: 2,
|
|
selectedOptionCount: 1,
|
|
skippedTaskCount: 3,
|
|
legacyInheritedRestriction: true,
|
|
});
|
|
|
|
expect(client.track).toHaveBeenCalledWith("interaction.resolved", {
|
|
interaction_kind: "single_confirmation",
|
|
status: "accepted",
|
|
resolved_by_kind: "operator",
|
|
resolution_reason: "accepted",
|
|
created_by_kind: "agent",
|
|
creator_agent_role: "coder",
|
|
continuation_policy: "wake_everyone",
|
|
target_type: "issue_document",
|
|
option_count: 2,
|
|
selected_option_count: 1,
|
|
skipped_task_count: 3,
|
|
legacy_inherited_restriction: true,
|
|
});
|
|
});
|
|
|
|
it("emits only enum and boolean dimensions for interaction creation compatibility", () => {
|
|
const client = createClient();
|
|
|
|
trackInteractionCreated(client, {
|
|
interactionKind: "request_confirmation",
|
|
usedDeprecatedResolverPolicyAlias: true,
|
|
});
|
|
|
|
expect(client.track).toHaveBeenCalledWith("interaction.created", {
|
|
interaction_kind: "request_confirmation",
|
|
used_deprecated_resolver_policy_alias: true,
|
|
});
|
|
});
|
|
});
|